Re: [v3 2/7] powerpc/mce: Bug fixes for MCE handling in kernel space

2019-07-06 Thread Nicholas Piggin
Santosh Sivaraj's on July 6, 2019 7:26 am: > From: Balbir Singh > > The code currently assumes PAGE_SHIFT as the shift value of > the pfn, This comment doesn't really make sense on its own. Linux pfns are always units of page shift, so if it's not that then it's not a pfn. I think you want the

[v3 2/7] powerpc/mce: Bug fixes for MCE handling in kernel space

2019-07-05 Thread Santosh Sivaraj
From: Balbir Singh The code currently assumes PAGE_SHIFT as the shift value of the pfn, this works correctly (mostly) for user space pages, but the correct thing to do is 1. Extract the shift value returned via the pte-walk API's 2. Use the shift value to access the instruction address. Note,