Re: Build failure: -Wno-unused-const-variable DNE on old GCC

On Thu, 7 Jan 2016, Brian Norris wrote: > > Perhaps most uses of -Werror without some CONFIG_ guard > > should be removed or replaced by some other mechanism. > > +1000. I'd personally like to see all one-off uses of -Werror removed. > > > $ git grep -E "=\s*\-Werror" | grep -v CONFIG > > [...]

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

On Sat, 2016-01-30 at 14:20 +, Maciej W. Rozycki wrote: > On Thu, 7 Jan 2016, Brian Norris wrote: > > > > Perhaps most uses of -Werror without some CONFIG_ guard > > > should be removed or replaced by some other mechanism. > > > > +1000. I'd personally like to see all one-off uses of -Werror

RE: Build failure: -Wno-unused-const-variable DNE on old GCC

From: Michael Ellerman > Sent: 08 January 2016 02:17 > > I doubt you plan to fix all those. So making -Werror configurable seems like > > the only way forward, then. (Glad you agreed!) > > Yep, I'm happy to make Werror configurable. > > cxl can probably just use the existing PPC_WERROR.

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

Excerpts from Brian Norris's message of 2016-01-08 10:02:25 +1100: > > - It forces cxl developers to a higher standard. cxl has already had > >more than it's fair share of incredibly difficult to debug issues, > >so any way we can reduce the risk of errors going in makes our lives > >

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

Hi Arnd, Thanks for your patch. Acked-by: Daniel Axtens > Alternatively, remove the -Werror. We occasionally get people that add this > flag to a Makefile, but it tends to cause more trouble whenever a new > gcc version arrives. Speaking up as the person who added -Werror to

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

On Fri, Jan 08, 2016 at 09:51:35AM +1100, Daniel Axtens wrote: > > > Alternatively, remove the -Werror. We occasionally get people that add this > > flag to a Makefile, but it tends to cause more trouble whenever a new > > gcc version arrives. ^^ Your reasons below don't really address this

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

On Fri, Jan 08, 2016 at 12:31:54PM +1100, Ian Munsie wrote: > Excerpts from Brian Norris's message of 2016-01-08 10:02:25 +1100: > > > - It forces cxl developers to a higher standard. cxl has already had > > >more than it's fair share of incredibly difficult to debug issues, > > >so any

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

On Thu, 2016-01-07 at 18:07 -0800, Brian Norris wrote: > On Fri, Jan 08, 2016 at 12:31:54PM +1100, Ian Munsie wrote: > > Excerpts from Brian Norris's message of 2016-01-08 10:02:25 +1100: > > > > - It forces cxl developers to a higher standard. cxl has already had > > > >more than it's fair

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

Acked-by: Ian Munsie As suggested by Brian we might also gate the -Werror with CONFIG_PPC_WERROR, but that can be in a separate commit. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

On Thu, 2016-01-07 at 20:44 +0100, Michal Marek wrote: > Dne 7.1.2016 v 20:37 Joe Perches napsal(a): > > On Thu, 2016-01-07 at 10:54 -0800, Brian Norris wrote: > > > I'm using a GCC 4.6.3 compiler for some compile tests, and I noticed > > > that commit 2cd55c68c0a4 ("cxl: Fix build failure due to

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

On Thu, Jan 07, 2016 at 11:57:31AM -0800, Joe Perches wrote: > On Thu, 2016-01-07 at 20:44 +0100, Michal Marek wrote: > > Dne 7.1.2016 v 20:37 Joe Perches napsal(a): > > > On Thu, 2016-01-07 at 10:54 -0800, Brian Norris wrote: > > > > I'm using a GCC 4.6.3 compiler for some compile tests, and I

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

On Thursday 07 January 2016 10:54:06 Brian Norris wrote: > > I'm using a GCC 4.6.3 compiler for some compile tests, and I noticed > that commit 2cd55c68c0a4 ("cxl: Fix build failure due to -Wunused-variable > behaviour change") breaks my builds, because the > -Wno-unused-const-variable doesn't

Build failure: -Wno-unused-const-variable DNE on old GCC

Hi, I'm using a GCC 4.6.3 compiler for some compile tests, and I noticed that commit 2cd55c68c0a4 ("cxl: Fix build failure due to -Wunused-variable behaviour change") breaks my builds, because the -Wno-unused-const-variable doesn't exist on GCC 4.6.3. drivers/misc/cxl/base.c: At top level: