Re: Build regressions/improvements in v5.16-rc1
On 11/17/21 03:19, Nick Terrell wrote: > > >> On Nov 16, 2021, at 6:05 PM, Randy Dunlap wrote: >> >> On 11/16/21 5:59 PM, Nick Terrell wrote: On Nov 15, 2021, at 8:44 AM, Helge Deller wrote: On 11/15/21 17:12, Geert Uytterhoeven wrote: > On Mon, Nov 15, 2021 at 4:54 PM Geert Uytterhoeven > wrote: >> Below is the list of build error/warning regressions/improvements in >> v5.16-rc1[1] compared to v5.15[2]. >> >> Summarized: >> - build errors: +20/-13 >> - build warnings: +3/-28 >> >> Happy fixing! ;-) >> >> Thanks to the linux-next team for providing the build service. >> >> [1] >> http://kisskb.ellerman.id.au/kisskb/branch/linus/head/fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf/ >>(all 90 configs) >> [2] >> http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8bb7eca972ad531c9b149c0a51ab43a417385813/ >>(all 90 configs) >> >> >> *** ERRORS *** >> >> 20 error regressions: >> + /kisskb/src/arch/parisc/include/asm/jump_label.h: error: expected ':' >> before '__stringify': => 33:4, 18:4 >> + /kisskb/src/arch/parisc/include/asm/jump_label.h: error: label >> 'l_yes' defined but not used [-Werror=unused-label]: => 38:1, 23:1 > >due to static_branch_likely() in crypto/api.c > > parisc-allmodconfig fixed now in the parisc for-next git tree. >> + /kisskb/src/drivers/gpu/drm/msm/msm_drv.h: error: "COND" redefined >> [-Werror]: => 531 >> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame >> size of 3252 bytes is larger than 1536 bytes >> [-Werror=frame-larger-than=]: => 47:1 >> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame >> size of 3360 bytes is larger than 1536 bytes >> [-Werror=frame-larger-than=]: => 499:1 >> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame >> size of 5344 bytes is larger than 1536 bytes >> [-Werror=frame-larger-than=]: => 334:1 >> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame >> size of 5380 bytes is larger than 1536 bytes >> [-Werror=frame-larger-than=]: => 354:1 >> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of >> 1824 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => >> 372:1 >> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of >> 2224 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => >> 204:1 >> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of >> 3800 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => >> 476:1 > > parisc-allmodconfig parisc needs much bigger frame sizes, so I'm not astonished here. During the v5.15 cycl I increased it to 1536 (from 1280), so I'm simply tempted to increase it this time to 4096, unless someone has a better idea >>> This patch set should fix the zstd stack size warnings [0]. I’ve >>> verified the fix using the same tooling: gcc-8-hppa-linux-gnu. >>> I’ll send the PR to Linus tomorrow. I’ve been informed that it >>> isn't strictly necessary to send the patches to the mailing list >>> for bug fixes, but its already done, so I’ll wait and see if there >>> is any feedback. >> >> IMO several (or many more) people would disagree with that. >> >> "strictly?" OK, it's probably possible that almost any patch >> could be merged without being on a mailing list, but it's not >> desirable (except in the case of "security" patches). > > Good to know! Thanks for the advice, I wasn’t really sure what > the best practice is for sending patches to your own tree, as I > didn't see anything about it in the maintainer guide. Nick, thanks a lot for your efforts to get the frame size usage down! I've applied your patch series to the parisc for-next tree [1], so that it gets some testing in the upstream for-next tree. My tests so far are good, although I'm only using gcc-11. If you don't mind, and if it doesn't generate issues for other platforms & architectures I could submit them upstream to Linus when I send the next pull request. Helge [1] https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/log/?h=for-next
Re: Build regressions/improvements in v5.16-rc1
Hi Nick,
On Wed, Nov 17, 2021 at 3:20 AM Nick Terrell wrote:
> > On Nov 16, 2021, at 6:05 PM, Randy Dunlap wrote:
> > On 11/16/21 5:59 PM, Nick Terrell wrote:
> >> I’ll send the PR to Linus tomorrow. I’ve been informed that it
> >> isn't strictly necessary to send the patches to the mailing list
> >> for bug fixes, but its already done, so I’ll wait and see if there
> >> is any feedback.
> >
> > IMO several (or many more) people would disagree with that.
> >
> > "strictly?" OK, it's probably possible that almost any patch
> > could be merged without being on a mailing list, but it's not
> > desirable (except in the case of "security" patches).
>
> Good to know! Thanks for the advice, I wasn’t really sure what
> the best practice is for sending patches to your own tree, as I
> didn't see anything about it in the maintainer guide.
All patches must be sent to public mailing lists for review.
You might get away with not doing that for a simple and trivial fix,
but be prepared to end up on people's "special" lists if you did get
it wrong.
We are Legion. We do not forgive. We do not forget ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: Build regressions/improvements in v5.16-rc1
On 11/16/21 5:59 PM, Nick Terrell wrote: On Nov 15, 2021, at 8:44 AM, Helge Deller wrote: On 11/15/21 17:12, Geert Uytterhoeven wrote: On Mon, Nov 15, 2021 at 4:54 PM Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v5.16-rc1[1] compared to v5.15[2]. Summarized: - build errors: +20/-13 - build warnings: +3/-28 Happy fixing! ;-) Thanks to the linux-next team for providing the build service. [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf/ (all 90 configs) [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8bb7eca972ad531c9b149c0a51ab43a417385813/ (all 90 configs) *** ERRORS *** 20 error regressions: + /kisskb/src/arch/parisc/include/asm/jump_label.h: error: expected ':' before '__stringify': => 33:4, 18:4 + /kisskb/src/arch/parisc/include/asm/jump_label.h: error: label 'l_yes' defined but not used [-Werror=unused-label]: => 38:1, 23:1 due to static_branch_likely() in crypto/api.c parisc-allmodconfig fixed now in the parisc for-next git tree. + /kisskb/src/drivers/gpu/drm/msm/msm_drv.h: error: "COND" redefined [-Werror]: => 531 + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size of 3252 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 47:1 + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size of 3360 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 499:1 + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size of 5344 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 334:1 + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size of 5380 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 354:1 + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of 1824 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 372:1 + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of 2224 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 204:1 + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of 3800 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 476:1 parisc-allmodconfig parisc needs much bigger frame sizes, so I'm not astonished here. During the v5.15 cycl I increased it to 1536 (from 1280), so I'm simply tempted to increase it this time to 4096, unless someone has a better idea This patch set should fix the zstd stack size warnings [0]. I’ve verified the fix using the same tooling: gcc-8-hppa-linux-gnu. I’ll send the PR to Linus tomorrow. I’ve been informed that it isn't strictly necessary to send the patches to the mailing list for bug fixes, but its already done, so I’ll wait and see if there is any feedback. IMO several (or many more) people would disagree with that. "strictly?" OK, it's probably possible that almost any patch could be merged without being on a mailing list, but it's not desirable (except in the case of "security" patches). -- ~Randy
Re: Build regressions/improvements in v5.16-rc1
On Mon, Nov 15, 2021 at 05:12:50PM +0100, Geert Uytterhoeven wrote: > > + error: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] > > undefined!: => N/A > > + error: modpost: "mips_cm_lock_other" > > [drivers/pci/controller/pcie-mt7621.ko] undefined!: => N/A > > + error: modpost: "mips_cm_unlock_other" > > [drivers/pci/controller/pcie-mt7621.ko] undefined!: => N/A > > + error: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] > > undefined!: => N/A > > + error: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] > > undefined!: => N/A > > mips-allmodconfig there is a patchset fixing this https://lore.kernel.org/all/2025070809.15529-1-sergio.paracuel...@gmail.com/ > > 3 warning regressions: > > + : warning: #warning syscall futex_waitv not implemented [-Wcpp]: > > => 1559:2 > > powerpc, m68k, mips, s390, parisc (and probably more) I've queued a patch to fix this for mips. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]
Re: Build regressions/improvements in v5.16-rc1
On Mon, Nov 15, 2021 at 05:44:33PM +0100, Marco Elver wrote:
> On Mon, Nov 15, 2021 at 05:12PM +0100, Geert Uytterhoeven wrote:
> [...]
> > > + /kisskb/src/include/linux/fortify-string.h: error: call to
> > > '__read_overflow' declared with attribute error: detected read beyond
> > > size of object (1st parameter): => 263:25, 277:17
> >
> > in lib/test_kasan.c
> >
> > s390-all{mod,yes}config
> > arm64-allmodconfig (gcc11)
>
> Kees, wasn't that what [1] was meant to fix?
> [1] https://lkml.kernel.org/r/20211006181544.1670992-1-keesc...@chromium.org
Ah, I found it:
http://kisskb.ellerman.id.au/kisskb/buildresult/14660585/log/
it's actually:
inlined from 'kasan_memcmp' at /kisskb/src/lib/test_kasan.c:897:2:
and
inlined from 'kasan_memchr' at /kisskb/src/lib/test_kasan.c:872:2:
I can send a patch doing the same as what [1] does for these cases too.
--
Kees Cook
Re: Build regressions/improvements in v5.16-rc1
On Mon, Nov 15, 2021 at 05:44:33PM +0100, Marco Elver wrote:
> On Mon, Nov 15, 2021 at 05:12PM +0100, Geert Uytterhoeven wrote:
> [...]
> > > + /kisskb/src/include/linux/fortify-string.h: error: call to
> > > '__read_overflow' declared with attribute error: detected read beyond
> > > size of object (1st parameter): => 263:25, 277:17
> >
> > in lib/test_kasan.c
> >
> > s390-all{mod,yes}config
> > arm64-allmodconfig (gcc11)
>
> Kees, wasn't that what [1] was meant to fix?
> [1] https://lkml.kernel.org/r/20211006181544.1670992-1-keesc...@chromium.org
[1] fixed the ones I found when scanning for __write_overflow(). [2]
fixed some others, so it's possible there are yet more to fix?
Taking a look at Linus's tree, though, the "263" and "277" lines don't
line up correctly. I'll go see if I can reproduce this. Is this with
W=1?
-Kees
[2]
https://www.ozlabs.org/~akpm/mmotm/broken-out/kasan-test-consolidate-workarounds-for-unwanted-__alloc_size-protection.patch
--
Kees Cook
Re: Build regressions/improvements in v5.16-rc1
On 11/15/21 17:12, Geert Uytterhoeven wrote:
> On Mon, Nov 15, 2021 at 4:54 PM Geert Uytterhoeven
> wrote:
>> Below is the list of build error/warning regressions/improvements in
>> v5.16-rc1[1] compared to v5.15[2].
>>
>> Summarized:
>> - build errors: +20/-13
>> - build warnings: +3/-28
>>
>> Happy fixing! ;-)
>>
>> Thanks to the linux-next team for providing the build service.
>>
>> [1]
>> http://kisskb.ellerman.id.au/kisskb/branch/linus/head/fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf/
>> (all 90 configs)
>> [2]
>> http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8bb7eca972ad531c9b149c0a51ab43a417385813/
>> (all 90 configs)
>>
>>
>> *** ERRORS ***
>>
>> 20 error regressions:
>> + /kisskb/src/arch/parisc/include/asm/jump_label.h: error: expected ':'
>> before '__stringify': => 33:4, 18:4
>> + /kisskb/src/arch/parisc/include/asm/jump_label.h: error: label 'l_yes'
>> defined but not used [-Werror=unused-label]: => 38:1, 23:1
>
> due to static_branch_likely() in crypto/api.c
>
> parisc-allmodconfig
fixed now in the parisc for-next git tree.
>> + /kisskb/src/drivers/gpu/drm/msm/msm_drv.h: error: "COND" redefined
>> [-Werror]: => 531
>> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size
>> of 3252 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: =>
>> 47:1
>> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size
>> of 3360 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: =>
>> 499:1
>> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size
>> of 5344 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: =>
>> 334:1
>> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size
>> of 5380 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: =>
>> 354:1
>> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of 1824
>> bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 372:1
>> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of 2224
>> bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 204:1
>> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of 3800
>> bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 476:1
>
> parisc-allmodconfig
parisc needs much bigger frame sizes, so I'm not astonished here.
During the v5.15 cycl I increased it to 1536 (from 1280), so I'm simply tempted
to
increase it this time to 4096, unless someone has a better idea
>> + /kisskb/src/fs/ntfs/aops.c: error: the frame size of 2240 bytes is
>> larger than 2048 bytes [-Werror=frame-larger-than=]: => 1311:1
>> + /kisskb/src/fs/ntfs/aops.c: error: the frame size of 2304 bytes is
>> larger than 2048 bytes [-Werror=frame-larger-than=]: => 1311:1
>> + /kisskb/src/fs/ntfs/aops.c: error: the frame size of 2320 bytes is
>> larger than 2048 bytes [-Werror=frame-larger-than=]: => 1311:1
>
> powerpc-allmodconfig
>
>> + /kisskb/src/include/linux/compiler_types.h: error: call to
>> '__compiletime_assert_366' declared with attribute error: FIELD_PREP: value
>> too large for the field: => 335:38
>
> in drivers/pinctrl/pinctrl-apple-gpio.c
>
> arm64-allmodconfig (gcc8)
>
>> + /kisskb/src/include/linux/fortify-string.h: error: call to
>> '__read_overflow' declared with attribute error: detected read beyond size
>> of object (1st parameter): => 263:25, 277:17
>
> in lib/test_kasan.c
>
> s390-all{mod,yes}config
> arm64-allmodconfig (gcc11)
>
>> + error: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko]
>> undefined!: => N/A
>> + error: modpost: "mips_cm_lock_other"
>> [drivers/pci/controller/pcie-mt7621.ko] undefined!: => N/A
>> + error: modpost: "mips_cm_unlock_other"
>> [drivers/pci/controller/pcie-mt7621.ko] undefined!: => N/A
>> + error: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko]
>> undefined!: => N/A
>> + error: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko]
>> undefined!: => N/A
>
> mips-allmodconfig
>
>> 3 warning regressions:
>> + : warning: #warning syscall futex_waitv not implemented [-Wcpp]:
>> => 1559:2
>
> powerpc, m68k, mips, s390, parisc (and probably more)
Will someone update all of them at once?
Helge
>> + arch/m68k/configs/multi_defconfig: warning: symbol value 'm' invalid for
>> MCTP: => 322
>> + arch/m68k/configs/sun3_defconfig: warning: symbol value 'm' invalid for
>> MCTP: => 295
>
> Yeah, that happens when symbols are changed from tristate to bool...
> Will be fixed in 5.17-rc1, with the next defconfig refresh.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
>
Re: Build regressions/improvements in v5.16-rc1
On Mon, Nov 15, 2021 at 4:54 PM Geert Uytterhoeven wrote:
> Below is the list of build error/warning regressions/improvements in
> v5.16-rc1[1] compared to v5.15[2].
>
> Summarized:
> - build errors: +20/-13
> - build warnings: +3/-28
>
> Happy fixing! ;-)
>
> Thanks to the linux-next team for providing the build service.
>
> [1]
> http://kisskb.ellerman.id.au/kisskb/branch/linus/head/fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf/
> (all 90 configs)
> [2]
> http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8bb7eca972ad531c9b149c0a51ab43a417385813/
> (all 90 configs)
>
>
> *** ERRORS ***
>
> 20 error regressions:
> + /kisskb/src/arch/parisc/include/asm/jump_label.h: error: expected ':'
> before '__stringify': => 33:4, 18:4
> + /kisskb/src/arch/parisc/include/asm/jump_label.h: error: label 'l_yes'
> defined but not used [-Werror=unused-label]: => 38:1, 23:1
due to static_branch_likely() in crypto/api.c
parisc-allmodconfig
> + /kisskb/src/drivers/gpu/drm/msm/msm_drv.h: error: "COND" redefined
> [-Werror]: => 531
> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size
> of 3252 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 47:1
> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size
> of 3360 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: =>
> 499:1
> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size
> of 5344 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: =>
> 334:1
> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size
> of 5380 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: =>
> 354:1
> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of 1824
> bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 372:1
> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of 2224
> bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 204:1
> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of 3800
> bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 476:1
parisc-allmodconfig
> + /kisskb/src/fs/ntfs/aops.c: error: the frame size of 2240 bytes is larger
> than 2048 bytes [-Werror=frame-larger-than=]: => 1311:1
> + /kisskb/src/fs/ntfs/aops.c: error: the frame size of 2304 bytes is larger
> than 2048 bytes [-Werror=frame-larger-than=]: => 1311:1
> + /kisskb/src/fs/ntfs/aops.c: error: the frame size of 2320 bytes is larger
> than 2048 bytes [-Werror=frame-larger-than=]: => 1311:1
powerpc-allmodconfig
> + /kisskb/src/include/linux/compiler_types.h: error: call to
> '__compiletime_assert_366' declared with attribute error: FIELD_PREP: value
> too large for the field: => 335:38
in drivers/pinctrl/pinctrl-apple-gpio.c
arm64-allmodconfig (gcc8)
> + /kisskb/src/include/linux/fortify-string.h: error: call to
> '__read_overflow' declared with attribute error: detected read beyond size of
> object (1st parameter): => 263:25, 277:17
in lib/test_kasan.c
s390-all{mod,yes}config
arm64-allmodconfig (gcc11)
> + error: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko]
> undefined!: => N/A
> + error: modpost: "mips_cm_lock_other"
> [drivers/pci/controller/pcie-mt7621.ko] undefined!: => N/A
> + error: modpost: "mips_cm_unlock_other"
> [drivers/pci/controller/pcie-mt7621.ko] undefined!: => N/A
> + error: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko]
> undefined!: => N/A
> + error: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko]
> undefined!: => N/A
mips-allmodconfig
> 3 warning regressions:
> + : warning: #warning syscall futex_waitv not implemented [-Wcpp]:
> => 1559:2
powerpc, m68k, mips, s390, parisc (and probably more)
> + arch/m68k/configs/multi_defconfig: warning: symbol value 'm' invalid for
> MCTP: => 322
> + arch/m68k/configs/sun3_defconfig: warning: symbol value 'm' invalid for
> MCTP: => 295
Yeah, that happens when symbols are changed from tristate to bool...
Will be fixed in 5.17-rc1, with the next defconfig refresh.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
