Re: [Qemu-devel] Re: Extending virtio_console to support multiple ports

2009-08-28 Thread Jamie Lokier
Alan Cox wrote: - Then, are we certain that there's no case where the tty layer will call us with some lock held or in an atomic context ? To be honest, I've totally lost track of the locking rules in tty land lately so it might well be ok, but something to verify. Some of the less

Re: [Qemu-devel] Re: Extending virtio_console to support multiple ports

2009-08-27 Thread Amit Shah
On (Thu) Aug 27 2009 [14:07:03], Benjamin Herrenschmidt wrote: On Wed, 2009-08-26 at 21:15 +0530, Amit Shah wrote: - Convert hvc's usage of spinlocks to mutexes. I've no idea how this will play out; I'm no expert here. But I did try doing this and so far it all looks OK. No

Re: Extending virtio_console to support multiple ports

2009-08-27 Thread Amit Shah
On (Thu) Aug 27 2009 [15:04:45], Michael Ellerman wrote: On Wed, 2009-08-26 at 21:15 +0530, Amit Shah wrote: [cc'ing some people who have made some commits in hvc_console.c] On (Wed) Aug 26 2009 [16:57:18], Amit Shah wrote: On (Tue) Aug 25 2009 [11:47:20], Amit Shah wrote:

Re: Extending virtio_console to support multiple ports

2009-08-27 Thread Benjamin Herrenschmidt
On Thu, 2009-08-27 at 10:08 +0100, Alan Cox wrote: - Then, are we certain that there's no case where the tty layer will call us with some lock held or in an atomic context ? To be honest, I've totally lost track of the locking rules in tty land lately so it might well be ok, but something

Re: Extending virtio_console to support multiple ports

2009-08-27 Thread Alan Cox
- Then, are we certain that there's no case where the tty layer will call us with some lock held or in an atomic context ? To be honest, I've totally lost track of the locking rules in tty land lately so it might well be ok, but something to verify. Some of the less well behaved line

Re: Extending virtio_console to support multiple ports

2009-08-27 Thread Ryan Arnold
On Thu, 2009-08-27 at 12:22 +0530, Amit Shah wrote: On (Thu) Aug 27 2009 [15:04:45], Michael Ellerman wrote: Ryan you called his code pure legacy baggage if you don't ;)

Re: Extending virtio_console to support multiple ports

2009-08-26 Thread Amit Shah
[cc'ing some people who have made some commits in hvc_console.c] On (Wed) Aug 26 2009 [16:57:18], Amit Shah wrote: On (Tue) Aug 25 2009 [11:47:20], Amit Shah wrote: Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications.

Re: Extending virtio_console to support multiple ports

2009-08-26 Thread Benjamin Herrenschmidt
On Wed, 2009-08-26 at 21:15 +0530, Amit Shah wrote: - Convert hvc's usage of spinlocks to mutexes. I've no idea how this will play out; I'm no expert here. But I did try doing this and so far it all looks OK. No lockups, lockdep warnings, nothing. I have full debugging enabled.

Re: Extending virtio_console to support multiple ports

2009-08-26 Thread Michael Ellerman
On Wed, 2009-08-26 at 21:15 +0530, Amit Shah wrote: [cc'ing some people who have made some commits in hvc_console.c] On (Wed) Aug 26 2009 [16:57:18], Amit Shah wrote: On (Tue) Aug 25 2009 [11:47:20], Amit Shah wrote: Hello all, Here is a new iteration of the patch series that