; Marcus Eder;
Stefan
Roscher; David Miller
Subject: Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for
TCP traffic
Here is a quick reply before something more official can
be written up:
Linas Vepstas wrote:
-- what is LRO?
Large Receive Offload
-- Basic principles
Hi,
Thanks for finding these bugs! I'll post an updated version soon (2 patches
with no separate Kconfig patches, one LRO and one eHEA patch). See comments
below.
Thanks,
Jan-Bernd
On Monday 30 July 2007 22:32, Andrew Gallatin wrote:
I was working on testing the myri10ge patch, and I ran into
Jan-Bernd Themann wrote:
On Monday 30 July 2007 22:32, Andrew Gallatin wrote:
Second, you still need to set skb-ip_summed = CHECKSUM_UNNECESSARY
when modified packets are flushed, else the stack will see bad
checksums for packets from CHECKSUM_COMPLETE drivers using the
skb interface. Fixed
Seems pretty good to me, save for one minor detail: patches #1/#2
should be combined together for greater git-bisect happiness. Ditto for
patches #3/#4. Largely harmless in this case, but keeps the git history
pollution to a minimum.
Caveat reviewer: I'm not an expert of net/ipv4/* code,
Jan-Bernd Themann wrote:
Hi,
this patch set contains the latest generic LRO code, a Kconfig / Makefile
and an eHEA patch demonstrating how the aggregate SKB interface has to
to be used.
Drew, could you provide a patch for the myri10ge driver to show how the
receive in page interface works?
From: Jeff Garzik [EMAIL PROTECTED]
Date: Mon, 30 Jul 2007 12:17:58 -0400
David, thoughts on merging? I'm not We could stick this into your tree
or mine. Whether yours or mine, I would like to keep the driver and
net-core patches together in the same git tree.
No objections and I'll stick
David Miller wrote:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Mon, 30 Jul 2007 12:17:58 -0400
David, thoughts on merging? I'm not We could stick this into your tree
or mine. Whether yours or mine, I would like to keep the driver and
net-core patches together in the same git tree.
No
