Re: [PATCH v2 1/4] xilinx_spi: Split into of driver and generic part.

2009-11-12 Thread Grant Likely
On Thu, Nov 12, 2009 at 7:26 AM, Richard Röjfors richard.rojf...@mocean-labs.com wrote: This patch splits the xilinx_spi driver into a generic part and a OF driver part. The reason for this is to later add in a platform driver as well. Signed-off-by: Richard Röjfors

Re: [PATCH v2 1/4] xilinx_spi: Split into of driver and generic part.

2009-11-12 Thread Richard Röjfors
Hi, There are some proposed updates from you which are inherited from the old code I think it's better that you (xilinx?) take responsibility for that part, I really don't want to maintain others' code which I even can't compile. There was a type error I will fix. Comments below... //Richard

Re: [PATCH v2 1/4] xilinx_spi: Split into of driver and generic part.

2009-11-12 Thread Richard Röjfors
On 11/12/09 6:17 PM, John Linn wrote: Have you compile tested this? platform_data is a void*, the dereference will not work. I know you don't have hardware; but getting the needed cross compiler is easy. Here's the fixes I did to make it compile. On to testing :) Great! I tested this

RE: [PATCH v2 1/4] xilinx_spi: Split into of driver and generic part.

2009-11-12 Thread John Linn
; John Linn Subject: Re: [PATCH v2 1/4] xilinx_spi: Split into of driver and generic part. On Thu, Nov 12, 2009 at 7:26 AM, Richard Röjfors richard.rojf...@mocean-labs.com wrote: This patch splits the xilinx_spi driver into a generic part and a OF driver part. The reason