Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Mark Brown
On Thu, Jan 14, 2021 at 02:42:26PM +0100, Christophe Leroy wrote: > Le 14/01/2021 à 14:22, Mark Brown a écrit : > > For GPIO chipselects you should really fix the driver to just hand the > > GPIO off to the core rather than trying to implement this itself, that > > will avoid driver specific

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Christophe Leroy
Le 14/01/2021 à 14:22, Mark Brown a écrit : For GPIO chipselects you should really fix the driver to just hand the GPIO off to the core rather than trying to implement this itself, that will avoid driver specific differences like this. IIUC, it is not trivial as it requires implementing

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Mark Brown
; So changing the board config is compensated by the above, and at the end > > > it still doesn't work. > > This is a driver bug, the driver set_cs() operation should not be > > modifying the value it is told to set. > A driver bug ? Or maybe a change forgotten in comm

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Christophe Leroy
ten in commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors") ? I'm almost sure it was not a bug, it is in line which what is said in the comment removed by the above mentionned commit. I'll send a fix. Christophe

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Mark Brown
On Thu, Jan 14, 2021 at 12:27:42PM +0100, Christophe Leroy wrote: > Today I have in the DTS the CS GPIOs declared as ACTIVE_LOW. > If I declare them as ACTIVE_HIGH instead, then I also have to set > spi-cs-high property, otherwise of_gpio_flags_quirks() is not happy and > forces the GPIO ACTIVE

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Christophe Leroy
Le 13/01/2021 à 13:33, Mark Brown a écrit : On Wed, Jan 13, 2021 at 09:49:12AM +0100, Christophe Leroy wrote: With commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors") reverted, it is back to work: ... What shall I do ? I would guess th

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-13 Thread Mark Brown
On Wed, Jan 13, 2021 at 09:49:12AM +0100, Christophe Leroy wrote: > With commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO > descriptors") reverted, it is back to work: ... > What shall I do ? I would guess that there's an error with the chip select pol

SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-13 Thread Christophe Leroy
: SPI adapter temp1: +0.0 C lm74-spi-0-1 Adapter: SPI adapter temp1: +0.0 C With commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors") reverted, it is back to work: root@vgoip:~# sensors lm

Re: Using gpio in MPC8309

2012-07-13 Thread Gary Thomas
On 2012-07-12 18:08, Gal Afel wrote: Hello, I just got a TWR-MPC8309 from Freescale running Embedded Linux OS. The kernel version is Linux 2.6.11+pq3 patches and the kernel preconfig file is linux_2.6.11_mpc8548_cds_def.config. That's a really OLD kernel, plus it doesn't seem to match your

Using gpio in MPC8309

2012-07-12 Thread Gal Afel
Hello, I just got a TWR-MPC8309 from Freescale running Embedded Linux OS. The kernel version is Linux 2.6.11+pq3 patches and the kernel preconfig file is linux_2.6.11_mpc8548_cds_def.config. I'm new to processors running Linux and I'm having a hard time trying to understand how can I program the

Re: Using GPIO

2008-06-06 Thread Ludovic Desroches
Hi, I am also trying to use Xilinx GPIO driver on my board but I encounter some problems. I thought they will be resolved with this information but it doesn't. I use GPIO driver as built-in but during kernel boot but I don't see log about it contrary to Xemac driver for instance. First I wanted

Re: Using GPIO

2008-06-06 Thread Guillaume Dargaud
I think there are some more details in my notes: https://lpsc-secure.in2p3.fr/trac/akido/wiki/CrossCompile#GettingGPIOtoworkinuserspace I am also trying to use Xilinx GPIO driver on my board but I encounter some problems. I thought they will be resolved with this information but it doesn't.

Re: Using GPIO

2008-05-19 Thread Guillaume Dargaud
Thanks for the answer, Dts files are not used with arch/ppc. My question was more general, since arch/ppc will soon (?) disapear... In arch/ppc, the drivers that are in the system depend on the arch/ppc/platforms/4xx/xparameters/xparameters_ml405.h to setup the addresses of the devices and

Re: Using GPIO

2008-05-19 Thread Josh Boyer
On Mon, 19 May 2008 13:56:12 +0200 Guillaume Dargaud [EMAIL PROTECTED] wrote: Thanks for the answer, Dts files are not used with arch/ppc. My question was more general, since arch/ppc will soon (?) disapear... Device Tree Souce files. See lots of examples in arch/powerpc/boot/dts/. Those

Re: Using GPIO

2008-05-16 Thread Guillaume Dargaud
If you're using arch/powerpc, my understanding is that CONFIG_XILINX_GPIO needs to be enabled as well as having the right info in the dts file. I'm using arch/ppc, so excuse my ignorance but what are dts files ? I see arch/powerpc/boot/dts/ml405.dts in the kernel tree which would need some

RE: Using GPIO

2008-05-16 Thread John Linn
- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Guillaume Dargaud Sent: Friday, May 16, 2008 2:16 AM To: linuxppc-dev@ozlabs.org Subject: Re: Using GPIO If you're using arch/powerpc, my understanding is that CONFIG_XILINX_GPIO needs to be enabled as well as having the right info

Using GPIO

2008-05-15 Thread Guillaume Dargaud
Hello all, I'm trying to use the Xilinx GPIO from a user program. Since I haven't managed to compile their example (simon.c is given without a makefile), I wanted to try using /dev/gpio... So I added /dev/gpio0 c 666 0 0 10 185 - - - to device_table.txt when I generated my root