Re: [2/3] block/ps3vram: Check return of ps3vram_cache_init

2017-08-18 Thread Michael Ellerman 
On Mon, 2017-08-07 at 20:09:20 UTC, Geoff Levand wrote:
> Cc: Markus Elfring 
> Cc: Jim Paris 
> Cc: Jens Axboe 
> Signed-off-by: Geoff Levand 

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/00e7c259e9c44f414ead5fc9bb3c45

cheers

Re: block/ps3vram: Check return of ps3vram_cache_init

2017-08-08 Thread SF Markus Elfring 
> @@ -741,7 +741,11 @@ static int ps3vram_probe(struct ps3_system_bus_device 
> *dev)
>   goto out_unmap_reports;
>   }
>  
> - ps3vram_cache_init(dev);
> + error = ps3vram_cache_init(dev);
> + if (error < 0) {
> + goto out_unmap_reports;
> + }
> +
>   ps3vram_proc_init(dev);
>  
>   queue = blk_alloc_queue(GFP_KERNEL);

I pointed a few development concerns out.
https://patchwork.ozlabs.org/patch/798575/

Will the commit subject “block/ps3vram: Check return value of 
ps3vram_cache_init()”
be more appropriate?

Regards,
Markus

[PATCH 2/3] block/ps3vram: Check return of ps3vram_cache_init

2017-08-07 Thread Geoff Levand 
Cc: Markus Elfring 
Cc: Jim Paris 
Cc: Jens Axboe 
Signed-off-by: Geoff Levand 
---
 drivers/block/ps3vram.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c
index ba97d037279e..6a55959cbf78 100644
--- a/drivers/block/ps3vram.c
+++ b/drivers/block/ps3vram.c
@@ -741,7 +741,11 @@ static int ps3vram_probe(struct ps3_system_bus_device *dev)
goto out_unmap_reports;
}
 
-   ps3vram_cache_init(dev);
+   error = ps3vram_cache_init(dev);
+   if (error < 0) {
+   goto out_unmap_reports;
+   }
+
ps3vram_proc_init(dev);
 
queue = blk_alloc_queue(GFP_KERNEL);
-- 
2.11.0