Re: drivers/tty: ehv_bytechan fails to build as a module
On Sat, 2014-01-04 at 11:15 -0800, Guenter Roeck wrote: On Mon, Dec 09, 2013 at 04:03:10PM +1100, Anton Blanchard wrote: ehv_bytechan is marked tristate but fails to build as a module: drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int] It doesn't make much sense for a console driver to be built as a module, so change it to a bool. Signed-off-by: Anton Blanchard an...@samba.org Any comments on this patch ? The problem still causes powerpc:allmodconfig to fail. It's fine with me... Greg, are you going to take this via tty.git or do you want it to go via PPC? -Scott Guenter --- Index: b/drivers/tty/Kconfig === --- a/drivers/tty/Kconfig +++ b/drivers/tty/Kconfig @@ -366,7 +366,7 @@ config TRACE_SINK Trace data router for MIPI P1149.7 cJTAG standard. config PPC_EPAPR_HV_BYTECHAN - tristate ePAPR hypervisor byte channel driver + bool ePAPR hypervisor byte channel driver depends on PPC select EPAPR_PARAVIRT help ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: drivers/tty: ehv_bytechan fails to build as a module
On Tue, Jan 07, 2014 at 07:21:03PM -0600, Scott Wood wrote: On Sat, 2014-01-04 at 11:15 -0800, Guenter Roeck wrote: On Mon, Dec 09, 2013 at 04:03:10PM +1100, Anton Blanchard wrote: ehv_bytechan is marked tristate but fails to build as a module: drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int] It doesn't make much sense for a console driver to be built as a module, so change it to a bool. Signed-off-by: Anton Blanchard an...@samba.org Any comments on this patch ? The problem still causes powerpc:allmodconfig to fail. It's fine with me... Greg, are you going to take this via tty.git or do you want it to go via PPC? Feel free to take it through PPC. Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: drivers/tty: ehv_bytechan fails to build as a module
On Mon, Dec 09, 2013 at 04:03:10PM +1100, Anton Blanchard wrote: ehv_bytechan is marked tristate but fails to build as a module: drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int] It doesn't make much sense for a console driver to be built as a module, so change it to a bool. Signed-off-by: Anton Blanchard an...@samba.org Any comments on this patch ? The problem still causes powerpc:allmodconfig to fail. Guenter --- Index: b/drivers/tty/Kconfig === --- a/drivers/tty/Kconfig +++ b/drivers/tty/Kconfig @@ -366,7 +366,7 @@ config TRACE_SINK Trace data router for MIPI P1149.7 cJTAG standard. config PPC_EPAPR_HV_BYTECHAN - tristate ePAPR hypervisor byte channel driver + bool ePAPR hypervisor byte channel driver depends on PPC select EPAPR_PARAVIRT help ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH] drivers/tty: ehv_bytechan fails to build as a module
ehv_bytechan is marked tristate but fails to build as a module: drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int] It doesn't make much sense for a console driver to be built as a module, so change it to a bool. Signed-off-by: Anton Blanchard an...@samba.org --- Index: b/drivers/tty/Kconfig === --- a/drivers/tty/Kconfig +++ b/drivers/tty/Kconfig @@ -366,7 +366,7 @@ config TRACE_SINK Trace data router for MIPI P1149.7 cJTAG standard. config PPC_EPAPR_HV_BYTECHAN - tristate ePAPR hypervisor byte channel driver + bool ePAPR hypervisor byte channel driver depends on PPC select EPAPR_PARAVIRT help ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
