Re: powerpc/eeh-powernv: Fix unbalanced IRQ warning

2015-07-30 Thread Michael Ellerman
On Thu, 2015-30-07 at 06:53:54 UTC, Alistair Popple wrote:
 pnv_eeh_next_error() re-enables the eeh opal event interrupt but it
 gets called from a loop if there are more outstanding events to
 process, resulting in a warning due to enabling an already enabled
 interrupt. Instead the interrupt should only be re-enabled once the
 last outstanding event has been processed.
 
 Tested-by: Daniel Axtens d...@axtens.net
 Reported-by: Daniel Axtens d...@axtens.net
 Signed-off-by: Alistair Popple alist...@popple.id.au
 Acked-by: Gavin Shan gws...@linux.vnet.ibm.com

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/b8d65e9662b1ffb3b52a

cheers
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc/eeh-powernv: Fix unbalanced IRQ warning

2015-07-30 Thread Alistair Popple
pnv_eeh_next_error() re-enables the eeh opal event interrupt but it
gets called from a loop if there are more outstanding events to
process, resulting in a warning due to enabling an already enabled
interrupt. Instead the interrupt should only be re-enabled once the
last outstanding event has been processed.

Tested-by: Daniel Axtens d...@axtens.net
Reported-by: Daniel Axtens d...@axtens.net
Signed-off-by: Alistair Popple alist...@popple.id.au
Acked-by: Gavin Shan gws...@linux.vnet.ibm.com
---
 arch/powerpc/platforms/powernv/eeh-powernv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c 
b/arch/powerpc/platforms/powernv/eeh-powernv.c
index ca825ec..ff41c03 100644
--- a/arch/powerpc/platforms/powernv/eeh-powernv.c
+++ b/arch/powerpc/platforms/powernv/eeh-powernv.c
@@ -1478,7 +1478,7 @@ static int pnv_eeh_next_error(struct eeh_pe **pe)
}
 
/* Unmask the event */
-   if (eeh_enabled())
+   if (ret == EEH_NEXT_ERR_NONE  eeh_enabled())
enable_irq(eeh_event_irq);
 
return ret;
-- 
1.8.3.2

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev