Re: powerpc/opal: fix minor off-by-one error in opal_mce_check_early_recovery()

[Michael Ellerman]

On Mon, 2015-21-12 at 07:28:37 UTC, Andrew Donnellan wrote:
> Fix off-by-one error in opal_mce_check_early_recovery() when checking
> whether the NIP falls within OPAL space.
> 
> Signed-off-by: Andrew Donnellan 

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/dc3799bb9ab2666fa19081121f

cheers
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc/opal: fix minor off-by-one error in opal_mce_check_early_recovery()

[Andrew Donnellan]

Fix off-by-one error in opal_mce_check_early_recovery() when checking
whether the NIP falls within OPAL space.

Signed-off-by: Andrew Donnellan 

---

Only very slightly more correct, but I'm fairly sure it's more correct...
---
 arch/powerpc/platforms/powernv/opal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/opal.c 
b/arch/powerpc/platforms/powernv/opal.c
index 57cffb8..488b989 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -555,7 +555,7 @@ bool opal_mce_check_early_recovery(struct pt_regs *regs)
goto out;
 
if ((regs->nip >= opal.base) &&
-   (regs->nip <= (opal.base + opal.size)))
+   (regs->nip < (opal.base + opal.size)))
recover_addr = find_recovery_address(regs->nip);
 
/*
-- 
Andrew Donnellan  Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com  Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev