Re: powerpc: add va_end()

[Michael Ellerman]

On Thu, 2015-17-12 at 08:41:00 UTC, Daniel Axtens wrote:
> cppcheck picked up that there were a couple of missing va_end()
> calls in functions using va_start().
> 
> Signed-off-by: Daniel Axtens 
> Reviewed-by: Russell Currey 

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/1b855e167b90fcb353977c0893

cheers
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc: add va_end()

[Daniel Axtens]

cppcheck picked up that there were a couple of missing va_end()
calls in functions using va_start().

Signed-off-by: Daniel Axtens 
---
 arch/powerpc/kernel/prom_init.c  | 1 +
 arch/powerpc/platforms/powermac/bootx_init.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 92dea8df6b26..da5192590c44 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -389,6 +389,7 @@ static void __init prom_printf(const char *format, ...)
break;
}
}
+   va_end(args);
 }
 
 
diff --git a/arch/powerpc/platforms/powermac/bootx_init.c 
b/arch/powerpc/platforms/powermac/bootx_init.c
index 76f5013c35e5..c3c9bbb3573a 100644
--- a/arch/powerpc/platforms/powermac/bootx_init.c
+++ b/arch/powerpc/platforms/powermac/bootx_init.c
@@ -84,6 +84,7 @@ static void __init bootx_printf(const char *format, ...)
break;
}
}
+   va_end(args);
 }
 #else /* CONFIG_BOOTX_TEXT */
 static void __init bootx_printf(const char *format, ...) {}
-- 
2.6.2

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc: add va_end()

[Russell Currey]

On Thu, 2015-12-17 at 19:41 +1100, Daniel Axtens wrote:
> cppcheck picked up that there were a couple of missing va_end()
> calls in functions using va_start().
> 
> Signed-off-by: Daniel Axtens 
Hey Daniel,

It's probably not worth a V2 but I think this could use a commit title that's a
bit more detailed.  Right now it doesn't really allude to what it fixes or what
it affects.

Reviewed-by: Russell Currey 
> ---
>  arch/powerpc/kernel/prom_init.c  | 1 +
>  arch/powerpc/platforms/powermac/bootx_init.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/powerpc/kernel/prom_init.c
> b/arch/powerpc/kernel/prom_init.c
> index 92dea8df6b26..da5192590c44 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -389,6 +389,7 @@ static void __init prom_printf(const char *format, ...)
>   break;
>   }
>   }
> + va_end(args);
>  }
>  
>  
> diff --git a/arch/powerpc/platforms/powermac/bootx_init.c
> b/arch/powerpc/platforms/powermac/bootx_init.c
> index 76f5013c35e5..c3c9bbb3573a 100644
> --- a/arch/powerpc/platforms/powermac/bootx_init.c
> +++ b/arch/powerpc/platforms/powermac/bootx_init.c
> @@ -84,6 +84,7 @@ static void __init bootx_printf(const char *format, ...)
>   break;
>   }
>   }
> + va_end(args);
>  }
>  #else /* CONFIG_BOOTX_TEXT */
>  static void __init bootx_printf(const char *format, ...) {}

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc: add va_end()

[Michael Ellerman]

On Thu, 2015-12-17 at 23:09 +1100, Russell Currey wrote:
> On Thu, 2015-12-17 at 19:41 +1100, Daniel Axtens wrote:
> > cppcheck picked up that there were a couple of missing va_end()
> > calls in functions using va_start().
> > 
> > Signed-off-by: Daniel Axtens 
> Hey Daniel,
> 
> It's probably not worth a V2 but I think this could use a commit title that's 
> a
> bit more detailed.  Right now it doesn't really allude to what it fixes or 
> what
> it affects.

Yeah, the change log is OK, but the actual subject is a bit terse.

I changed it to "powerpc: Add missing calls to va_end()".

cheers

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc: add va_end()

[Daniel Axtens]

Hi all,

Yes, sorry, that was a bit lax of me.
Michael, your title sounds good.
Thanks!

Regards,
Daniel


> On Thu, 2015-12-17 at 23:09 +1100, Russell Currey wrote:
>> On Thu, 2015-12-17 at 19:41 +1100, Daniel Axtens wrote:
>> > cppcheck picked up that there were a couple of missing va_end()
>> > calls in functions using va_start().
>> > 
>> > Signed-off-by: Daniel Axtens 
>> Hey Daniel,
>> 
>> It's probably not worth a V2 but I think this could use a commit title 
>> that's a
>> bit more detailed.  Right now it doesn't really allude to what it fixes or 
>> what
>> it affects.
>
> Yeah, the change log is OK, but the actual subject is a bit terse.
>
> I changed it to "powerpc: Add missing calls to va_end()".
>
> cheers
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev