Re: [PATCH] powerpc: warning: allocated section `.data_nosave' not in segment

2009-09-29 Thread Segher Boessenkool
ALIGN(PAGE_SIZE); .data_nosave : AT(ADDR(.data_nosave) - LOAD_OFFSET) { NOSAVE_DATA } Acked-by: Segher Boessenkool The patch is good and fixes a real problem. But, I still don't see how it caused the "warning: allocated section `.data_nosave' not in se

[PATCH] powerpc: warning: allocated section `.data_nosave' not in segment

2009-09-29 Thread Sean MacLennan
We need to align before the output section. Having the align inside the output section causes the linker to put some filler in there, which makes it a non-empty section, but this section isn't assigned to a segment so you get a warning from the linker. Signed-off-by: Sean MacLennan --- diff --git

Re: warning: allocated section `.data_nosave' not in segment

2009-09-28 Thread Segher Boessenkool
> Here is the ld -M output for the "bad" compile: > > .data_nosave0xc0376790 0x870 load address 0x00376790 > 0xc0377000. = ALIGN (0x1000) > *fill* 0xc0376790 0x870 00 Ah right. Having the ALIGN() inside the output section causes the linker to

Re: warning: allocated section `.data_nosave' not in segment

2009-09-28 Thread Sean MacLennan
Here is the ld -M output for the "bad" compile: .data_nosave0xc0376790 0x870 load address 0x00376790 0xc0377000. = ALIGN (0x1000) *fill* 0xc0376790 0x870 00 0xc0377000__nosave_begin = . *(.data.nosave)

Re: warning: allocated section `.data_nosave' not in segment

2009-09-28 Thread Segher Boessenkool
If you ignore the VMLINUX_SYMBOL, the only difference is moving the ALIGN inside the brackets. If I move the ALIGN back where it was, then the warning goes away. But other sections moved the ALIGN without an issue. Could it be a compiler problem? We are using version 4.0.0 (DENX ELDK 4.1 4.0.0).

Re: warning: allocated section `.data_nosave' not in segment

2009-09-28 Thread Sean MacLennan
I looked into it some more the patch converts this section: . = ALIGN(PAGE_SIZE); .data_nosave : AT(ADDR(.data_nosave) - LOAD_OFFSET) { __nosave_begin = .; *(.data.nosave) . = ALIGN(PAGE_SIZE); __nosave_end = .;

Re: warning: allocated section `.data_nosave' not in segment

2009-09-27 Thread Sean MacLennan
If I revert the commit show at the bottom of this email, the warnings go away. It took a while to find this, git bisect kept pointing me to a file from arch/alpha :( Cheers, Sean powerpc: Cleanup linker script using new linker script macros. author Tim Abbott Thu, 24 Sep 2009

warning: allocated section `.data_nosave' not in segment

2009-09-25 Thread Sean MacLennan
Anybody else getting these? They just started popping up with the recent changes for 2.6.32. ppc_4xxFP-ld: .tmp_vmlinux1: warning: allocated section `.data_nosave' not in segment KSYM.tmp_kallsyms1.S AS .tmp_kallsyms1.o LD .tmp_vmlinux2 ppc_4xxFP-ld: .tmp_vmlinux2: wa