Re: [PATCH 1/3] kernel/sched: introduce vcpu preempted check interface

On Mon, Jun 27, 2016 at 04:00:43PM +0200, Peter Zijlstra wrote: > On Mon, Jun 27, 2016 at 01:41:28PM -0400, Pan Xinhui wrote: > > +++ b/include/linux/sched.h > > @@ -3293,6 +3293,15 @@ static inline void set_task_cpu(struct task_struct > > *p, unsigned int cpu) > > > > #endif /* CONFIG_SMP */

Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ?

On Tue, Jun 28, 2016 at 08:06:56AM +0100, David Binderman wrote: > I think you can also get a similar warning if you tweek the gcc compiler > warning > flags. -Wformat=2 maybe. -Wformat=1 (which is enabled by -Wall) already warns for this. warning: format '%x' expects argument of type 'unsigned

Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ?

Hello there, On Tue, Jun 28, 2016 at 5:08 AM, Michael Ellerman wrote: > What config / toolchain are you using? I've never seen these. A static analyser for C & C++ called cppcheck. Available from sourceforge. I think you can also get a similar warning if you tweek the gcc

Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ?

On Tue, 2016-06-28 at 08:06 +0100, David Binderman wrote: > On Tue, Jun 28, 2016 at 5:08 AM, Michael Ellerman wrote: > > What config / toolchain are you using? I've never seen these. > > A static analyser for C & C++ called cppcheck. Available from sourceforge. > > I think

[PATCH] powerpc/mm: Use VM_WARN_ONCE() for irqs disabled check

The check for !arch_irqs_disabled() in find_linux_pte_or_hugepte() is a debugging aid, and needn't be enabled for production builds. Switch it to a VM_WARN_ONCE(), which is compiled out when CONFIG_DEBUG_VM=n. Signed-off-by: Michael Ellerman ---

Re: [RESEND, v7, 2/2] cxl: Add set and get private data to context struct

On Fri, 2016-24-06 at 06:47:07 UTC, Philippe Bergheaud wrote: > From: Michael Neuling > > This provides AFU drivers a means to associate private data with a cxl > context. This is particularly intended for make the new callbacks for > driver specific events easier for AFU

Re: [PATCH v5] tools/perf: Fix the mask in regs_dump__printf and print_sample_iregs

On Thu, Jun 23, 2016 at 11:19:27AM +0530, Madhavan Srinivasan wrote: SNIP > > Changelog v1: > 1)updated commit message and patch subject > 2)Add the fix to print_sample_iregs() in builtin-script.c > > tools/include/linux/bitmap.h | 2 ++ > tools/lib/bitmap.c | 18 ++

Re: [RESEND v7,2/2] cxl: Add set and get private data to context struct

On 24/06/16 16:47, Philippe Bergheaud wrote: From: Michael Neuling This provides AFU drivers a means to associate private data with a cxl context. This is particularly intended for make the new callbacks for driver specific events easier for AFU drivers to use, as they can

Re: [RESEND, v7, 2/2] cxl: Add set and get private data to context struct

Michael Ellerman wrote: On Fri, 2016-24-06 at 06:47:07 UTC, Philippe Bergheaud wrote: From: Michael Neuling This provides AFU drivers a means to associate private data with a cxl context. This is particularly intended for make the new callbacks for driver specific events

Re: [PATCH 1/3] kernel/sched: introduce vcpu preempted check interface

On 2016年06月28日 15:00, Heiko Carstens wrote: On Mon, Jun 27, 2016 at 04:00:43PM +0200, Peter Zijlstra wrote: On Mon, Jun 27, 2016 at 01:41:28PM -0400, Pan Xinhui wrote: +++ b/include/linux/sched.h @@ -3293,6 +3293,15 @@ static inline void set_task_cpu(struct task_struct *p, unsigned int cpu)

[PATCH v2 4/4] kernel/locking: Drop the overload of {mutex, rwsem}_spin_on_owner

An over-committed guest with more vCPUs than pCPUs has a heavy overload in the two spin_on_owner. This blames on the lock holder preemption issue. Kernel has an interface bool vcpu_is_preempted(int cpu) to see if a vCPU is currently running or not. So break the spin loops on true condition.

Re: [PATCH] powerpc/mm: update arch_{add,remove}_memory() for radix

On Thu, 2016-06-23 at 14:37 -0500, Reza Arbab wrote: > On Thu, Jun 23, 2016 at 10:47:20PM +0530, Aneesh Kumar K.V wrote: > > Reza Arbab writes: > > > These functions are making direct calls to the hash table APIs, > > > leading to a BUG() on systems using radix. > > > >

[PATCH 1/4] perf: Utility function to fetch arch from evsel

Add Utility function to fetch 'arch' from 'evsel'. (evsel->env->arch) Signed-off-by: Ravi Bangoria --- tools/perf/util/evsel.c | 7 +++ tools/perf/util/evsel.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/tools/perf/util/evsel.c

Re: [PATCH 06/38] powerpc: Move 64-bit feature fixup earlier

Benjamin Herrenschmidt writes: > On Tue, 2016-06-28 at 16:35 +0530, Aneesh Kumar K.V wrote: >> Why not move it immediately after we finish all the device tress >> scan. > > Do you need it in early_init_mmu ? The important thing is to have it > done before we *turn on*

Re: [V4, 2/3] powerpc/opal: Add #define to get rc from an ASYNC_COMP opal_msg

On Tue, 2016-28-06 at 04:40:56 UTC, Suraj Jitindar Singh wrote: > An opal_msg of type OPAL_MSG_ASYNC_COMP contains the return code in the > params[1] struct member. However this isn't intuitive or obvious when > reading the code and requires that a user look at the skiboot > documentation or

[PATCH v2 2/4] powerpc/spinlock: support vcpu preempted check

This is to fix some lock holder preemption issues. Some other locks implementation do a spin loop before acquiring the lock itself. Currently kernel has an interface of bool vcpu_is_preempted(int cpu). It take the cpu as parameter and return true if the cpu is preempted. Then kernel can break the

Re: Proposed: Patch to fix boot on PA6T

Hi Darren, On Sun, 2016-26-06 at 17:42:11 UTC, Darren Stevens wrote: > Hello All, > > commit d6a9996e84ac4beb7713e9485f4563e100a9b03e > powerpc/mm: vmalloc abstraction in preparation for radix > > This commit introduced variables for some linux kernel addresses that had > before >

Re: [PATCH] powerpc/mm: Use VM_WARN_ONCE() for irqs disabled check

On Tue, 2016-06-28 at 16:15 +0530, Aneesh Kumar K.V wrote: > Michael Ellerman writes: > > diff --git a/arch/powerpc/include/asm/pgtable.h > > b/arch/powerpc/include/asm/pgtable.h > > index ee09e99097f0..651848039dc4 100644 > > --- a/arch/powerpc/include/asm/pgtable.h > > +++

[PATCH 4/4] perf annotate: Define macro for arch names

Define macro for each arch name and use them instead of using arch name as string. Signed-off-by: Ravi Bangoria --- tools/perf/arch/common.c | 36 ++-- tools/perf/arch/common.h | 11 +++

[PATCH 3/4] perf annotate: add powerpc support

From: "Naveen N. Rao" Powerpc has long list of branch instructions and hardcoding them in table appears to be error-prone. So, add new function to find instruction instead of creating table. Signed-off-by: Naveen N. Rao

Re: [PATCH 29/38] powerpc: Move 32-bit probe() machine to later in the boot process

On Tue, 2016-06-28 at 13:42 +0200, Gerhard Pircher wrote: > The question is, if a compile time option that simply clear ?s > CPU_FTR_NEED_COHERENT after identify_cpu() would be acceptable. And > then I still wonder why KVM needs its own similar fix to work on the > AmigaOne. I specifically had to

Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ?

On Tue, 2016-06-28 at 08:06 +0100, David Binderman wrote: > > I don't know the code, but given that insn is unsigned long and so > can go > past 32 bits, using a cast to unsigned int might throw away the > possibly important > upper bits. our instructions are only ever 32-bits. That xmon code is

[PATCH v2 1/4] kernel/sched: introduce vcpu preempted check interface

This patch support to fix lock holder preemption issue. For kernel users, we could use bool vcpu_is_preempted(int cpu) to detech if one vcpu is preempted or not. The default implementation is a macro defined by false. So compiler can wrap it out if arch dose not support such vcpu pteempted

Re: [PATCH 06/38] powerpc: Move 64-bit feature fixup earlier

On Tue, 2016-06-28 at 16:35 +0530, Aneesh Kumar K.V wrote: > Why not move it immediately after we finish all the device tress > scan. Do you need it in early_init_mmu ? The important thing is to have it done before we *turn on* the MMU but yeah, there's no big deal moving it even further up I

[PATCH 2/4] perf annotate: Enable cross arch annotate

Change current data structures and function to enable cross arch annotate. Current implementation does not contain logic of record on one arch and annotate on other. This remote annotate is partially possible with current implementation for x86 (or may be arm as well) only. But, to make remote

Re: [PATCH 06/38] powerpc: Move 64-bit feature fixup earlier

On Tue, 2016-06-28 at 17:19 +0530, Aneesh Kumar K.V wrote: > If we can do feature fixup early. Then this patch series become > simpler. > > https://lkml.kernel.org/r/1465887288-12952-1-git-send-email-aneesh.ku > m...@linux.vnet.ibm.com > > ie, we can now start using

Re: [PATCH 07/17] powerpc/opal: Add real mode call wrappers

On Tue, 2016-06-28 at 21:37 +1000, Michael Ellerman wrote: > Yeah Ben already told me. > > I don't know which will go in first yet, this has had zero revisions and zero > reviews so it might not go in straight away ;) The point was that patch could go in independently of the rest but I really

[PATCH v2 0/4] implement vcpu preempted check

change fomr v1: a simplier definition of default vcpu_is_preempted skip mahcine type check on ppc, and add config. remove dedicated macro. add one patch to drop overload of rwsem_spin_on_owner and mutex_spin_on_owner. add more comments thanks boqun and

Re: [PATCH] powerpc/mm: Use VM_WARN_ONCE() for irqs disabled check

Michael Ellerman writes: > The check for !arch_irqs_disabled() in find_linux_pte_or_hugepte() is a > debugging aid, and needn't be enabled for production builds. > > Switch it to a VM_WARN_ONCE(), which is compiled out when > CONFIG_DEBUG_VM=n. > > Signed-off-by: Michael

Re: [PATCH 06/38] powerpc: Move 64-bit feature fixup earlier

Benjamin Herrenschmidt writes: > Make it part of early_setup() as we really want the feature fixups > to be applied before we turn on the MMU since they can have an impact > on the various assembly path related to MMU management and interrupts. > > This makes 64-bit

[PATCH 0/4] perf annotate: Enable cross arch annotate

Perf can currently only support code navigation (branches and calls) in annotate when run on the same architecture where perf.data was recorded. But cross arch annotate is not supported. This patchset enables cross arch annotate. Currently I've used x86 and arm instructions which are already

Re: [PATCH 07/17] powerpc/opal: Add real mode call wrappers

On Tue, 2016-06-28 at 14:18 +1000, Michael Neuling wrote: > mpe, > > Just flagging this as going to conflict with Shreyas' stop instruction > patch series. It's relatively easy to fix so you can do it manually. > > Alternatively you could take this one patch now and get Shreyas to rebase. Yeah

Re: [PATCH 29/38] powerpc: Move 32-bit probe() machine to later in the boot process

On Mon, 2016-06-27 at 23:40 +0200, Benjamin Herrenschmidt wrote: > On Mon, 2016-06-27 at 22:42 +0200, Gerhard Pircher wrote: > > This patch series reminds me of a long-standing issue with the > > AmigaOne platform code, which would have to clear the coherence > > (M) flag for every memory mapping

Re: Proposed: Patch to fix boot on PA6T

Darren Stevens writes: > Hello All, > > commit d6a9996e84ac4beb7713e9485f4563e100a9b03e > powerpc/mm: vmalloc abstraction in preparation for radix > > This commit introduced variables for some linux kernel addresses that had > before > been constants,

Re: [PATCH] powerpc/mm: update arch_{add,remove}_memory() for radix

Michael Ellerman writes: > On Thu, 2016-06-23 at 14:37 -0500, Reza Arbab wrote: >> On Thu, Jun 23, 2016 at 10:47:20PM +0530, Aneesh Kumar K.V wrote: >> > Reza Arbab writes: >> > > These functions are making direct calls to the hash table APIs, >> >

Re: [PATCH] ASoC: fsl_spdif: fix spelling mistake: "receivce" -> "receive"

On Tue, Jun 28, 2016 at 01:47:59PM +0100, Colin King wrote: > From: Colin Ian King Please fix things so that your mail configuration matches your git configuration, it makes things harder to review since it looks like you've got a non-author signoff with a missing

Re: [PATCH] powerpc/pseries: Auto online hotplugged memory

On 06/27/2016 10:46 PM, Michael Ellerman wrote: > On Mon, 2016-06-27 at 09:41 -0500, Nathan Fontenot wrote: >> On 06/24/2016 12:35 AM, Michael Ellerman wrote: >>> On Mon, 2016-06-20 at 21:14 -0500, Nathan Fontenot wrote: On 06/20/2016 07:57 PM, Michael Ellerman wrote: > On Mon, 2016-06-20

RE: [PATCH 3/4] perf annotate: add powerpc support

From: Ravi Bangoria > Sent: 28 June 2016 12:37 > > Powerpc has long list of branch instructions and hardcoding them in table > appears to be error-prone. So, add new function to find instruction > instead of creating table. > > Signed-off-by: Naveen N. Rao >

Applied "ASoC: fsl_spdif: fix spelling mistake: "receivce" -> "receive"" to the asoc tree

The patch ASoC: fsl_spdif: fix spelling mistake: "receivce" -> "receive" has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

On 06/27/16 at 04:21pm, Dave Young wrote: > Please ignore previous reply, I mistakenly send a broken mail without > subject, sorry about it. Resend the reply here. > > On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave Young: > > > On

Re: [v7, 1/2] cxl: Add mechanism for delivering AFU driver specific events

> On Jun 23, 2016, at 8:03 AM, Philippe Bergheaud > wrote: > > This adds an afu_driver_ops structure with fetch_event() and > event_delivered() callbacks. An AFU driver such as cxlflash can fill > this out and associate it with a context to enable passing custom AFU >

Re: powerpc/pci: Reduce log level of PCI I/O space warning

On Wed, 2016-22-06 at 07:23:07 UTC, Benjamin Herrenschmidt wrote: > If a PHB has no I/O space, there's no need to make it look like > something bad happened, a pr_debug() is plenty enough since this > is the case of all our modern POWER chips. > > Signed-off-by: Benjamin Herrenschmidt

[PATCH] ASoC: fsl_spdif: fix spelling mistake: "receivce" -> "receive"

From: Colin Ian King trivial fix to spelling mistake in dev_err message Signed-off-by: Colin Ian King --- sound/soc/fsl/fsl_spdif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_spdif.c

linux-next: manual merge of the powerpc tree with Linus' tree

Hi all, Today's linux-next merge of the powerpc tree got a conflict in: arch/powerpc/Kconfig between commit: 844e3be47693 ("powerpc/bpf/jit: Disable classic BPF JIT on ppc64le") from Linus' tree and commit: 156d0e290e96 ("powerpc/ebpf/jit: Implement JIT compiler for extended BPF")

Re: [PATCH 29/38] powerpc: Move 32-bit probe() machine to later in the boot process

On Tue, 2016-06-28 at 14:01 +0200, Benjamin Herrenschmidt wrote: > On Tue, 2016-06-28 at 13:42 +0200, Gerhard Pircher wrote: > > The question is, if a compile time option that simply clear ?s > > CPU_FTR_NEED_COHERENT after identify_cpu() would be acceptable. And > > then I still wonder why KVM

Re: linux-next: manual merge of the powerpc tree with Linus' tree

On 2016/06/29 10:35AM, Stephen Rothwell wrote: > Hi all, Hi Stephen, > > Today's linux-next merge of the powerpc tree got a conflict in: > > arch/powerpc/Kconfig > > between commit: > > 844e3be47693 ("powerpc/bpf/jit: Disable classic BPF JIT on ppc64le") Ah, I see that the above commit

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

Am Donnerstag, 23 Juni 2016, 10:25:06 schrieb Dave Young: > On 06/22/16 at 08:30pm, Thiago Jung Bauermann wrote: > > Am Mittwoch, 22 Juni 2016, 18:20:47 schrieb Dave Young: > > > The patch looks good, but could the subject be more specific? > > > > > > For example just like the first sentence of

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > On 06/27/16 at 04:21pm, Dave Young wrote: > > Please ignore previous reply, I mistakenly send a broken mail without > > subject, sorry about it. Resend the reply here. > > > > On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > > > Am

Re: [PATCH 29/38] powerpc: Move 32-bit probe() machine to later in the boot process

On Tue, 2016-06-28 at 15:25 +0200, Gerhard Pircher wrote: > > No we could just add something to early_init_devtree that does clear > > that bit if it sees the relevant piece of broken HW, it's not the AmigaOne > > per-se, it's the northbridge right ? > Does that work for CPU_FTR_NEED_COHERENT,

Re: [V4, 2/3] powerpc/opal: Add #define to get rc from an ASYNC_COMP opal_msg

On Tue, 28 Jun 2016 21:58:28 +1000 (AEST) Michael Ellerman wrote: > On Tue, 2016-28-06 at 04:40:56 UTC, Suraj Jitindar Singh wrote: > > An opal_msg of type OPAL_MSG_ASYNC_COMP contains the return code in > > the params[1] struct member. However this isn't intuitive or > >

[PATCH V5 1/3] devicetree/bindings: Add binding for operator panel on FSP machines

Add a binding to Documentation/devicetree/bindings/powerpc/opal (oppanel-opal.txt) for the operator panel which is present on IBM Power Systems machines with FSPs. Signed-off-by: Suraj Jitindar Singh Acked-by: Rob Herring Acked-by: Stewart Smith

[PATCH V5 3/3] powerpc/drivers: Add driver for operator panel on FSP machines

Implement new character device driver to allow access from user space to the operator panel display present on IBM Power Systems machines with FSPs. This will allow status information to be presented on the display which is visible to a user. The driver implements a character buffer which a user

[PATCH V5 2/3] powerpc/opal: Add inline function to get rc from an ASYNC_COMP opal_msg

An opal_msg of type OPAL_MSG_ASYNC_COMP contains the return code in the params[1] struct member. However this isn't intuitive or obvious when reading the code and requires that a user look at the skiboot documentation or opal-api.h to verify this. Add an inline function to get the return code

Re: [PATCH 1/4] kvm/ppc/book3s_hv: Change vcore element runnable_threads from linked-list to array

On 24/06/16 19:59, Paul Mackerras wrote: > On Wed, Jun 15, 2016 at 07:21:05PM +1000, Suraj Jitindar Singh wrote: >> The struct kvmppc_vcore is a structure used to store various information >> about a virtual core for a kvm guest. The runnable_threads element of the >> struct provides a list of all

Re: [PATCHv2, 2/7] ppc: bpf/jit: Fix/enhance 32-bit Load Immediate implementation

On Wed, 2016-22-06 at 16:25:02 UTC, "Naveen N. Rao" wrote: > The existing LI32() macro can sometimes result in a sign-extended 32-bit > load that does not clear the top 32-bits properly. As an example, > loading 0x7fff results in the register containing > 0x7fff. While this does

Re: [v6, 07/11] powerpc/powernv: set power_save func after the idle states are initialized

On Wed, 2016-08-06 at 16:54:27 UTC, "Shreyas B. Prabhu" wrote: > pnv_init_idle_states discovers supported idle states from the > device tree and does the required initialization. Set power_save > function pointer only after this initialization is done > > Reviewed-by: Gautham R. Shenoy