[RFC PATCH 05/12] [WIP] powerpc/tm: Reclaim/recheckpoint on entry/exit

2018-02-19 Thread Cyril Bur
--- arch/powerpc/include/asm/exception-64s.h | 25 + arch/powerpc/kernel/entry_64.S | 5 + arch/powerpc/kernel/process.c| 37 3 files changed, 63 insertions(+), 4 deletions(-) diff --git

[RFC PATCH 08/12] [WIP] powerpc/tm: Fix *unavailable_tm exceptions

2018-02-19 Thread Cyril Bur
--- arch/powerpc/kernel/process.c | 11 ++- arch/powerpc/kernel/traps.c | 3 --- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index 574b05fe7d66..8a32fd062a2b 100644 --- a/arch/powerpc/kernel/process.c +++

Re: [RFC PATCH 05/12] [WIP] powerpc/tm: Reclaim/recheckpoint on entry/exit

2018-02-19 Thread Michael Neuling
On Tue, 2018-02-20 at 11:22 +1100, Cyril Bur wrote: The comment from the cover sheet should be here > --- > arch/powerpc/include/asm/exception-64s.h | 25 + > arch/powerpc/kernel/entry_64.S | 5 + > arch/powerpc/kernel/process.c| 37 >

[RFC PATCH 04/12] selftests/powerpc: Use less common thread names

2018-02-19 Thread Cyril Bur
"ping" and "pong" (in particular "ping") are common names. If a selftests causes a kernel BUG_ON or any kind of backtrace the process name is displayed. Setting a more unique name avoids confusion as to which process caused the problem. Signed-off-by: Cyril Bur ---

[RFC PATCH 01/12] powerpc/tm: Remove struct thread_info param from tm_reclaim_thread()

2018-02-19 Thread Cyril Bur
tm_reclaim_thread() doesn't use the parameter anymore, both callers have to bother getting it as they have no need for a struct thread_info either. It was previously used but became unused in dc3106690b20 ("powerpc: tm: Always use fp_state and vr_state to store live registers") Just remove it

[RFC PATCH 12/12] [WIP] selftests/powerpc: Remove incorrect tm-syscall selftest

2018-02-19 Thread Cyril Bur
Currently we perform transactional memory work at late as possible. That is we run in the kernel with the userspace checkpointed state on the CPU untill we absolultely must remove it and store it away. Likely a process switch, but possibly also signals or ptrace. What this means is that if

[RFC PATCH 03/12] selftests/powerpc: Add tm-signal-drop-transaction TM test

2018-02-19 Thread Cyril Bur
This test uses a signal to 'discard' a transaction. That is, it will take a signal of a thread in a suspended transaction and just remove the suspended MSR bit. Because this will send the userspace thread back to the tebgin + 4 address, we should also set CR0 to be nice. Signed-off-by: Cyril Bur

[RFC PATCH 09/12] [WIP] powerpc/tm: Tweak signal code to handle new reclaim/recheckpoint times

2018-02-19 Thread Cyril Bur
--- arch/powerpc/kernel/process.c | 13 - arch/powerpc/kernel/signal.c| 11 ++- arch/powerpc/kernel/signal_32.c | 16 ++-- arch/powerpc/kernel/signal_64.c | 41 + 4 files changed, 49 insertions(+), 32 deletions(-) diff

[RFC PATCH 10/12] [WIP] powerpc/tm: Correctly save/restore checkpointed sprs

2018-02-19 Thread Cyril Bur
--- arch/powerpc/kernel/process.c | 57 +-- arch/powerpc/kernel/ptrace.c | 9 +++ 2 files changed, 58 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index cd3ae80a6878..674f75c56172 100644 ---

Re: [RFC PATCH 10/12] [WIP] powerpc/tm: Correctly save/restore checkpointed sprs

2018-02-19 Thread Cyril Bur
On Tue, 2018-02-20 at 14:00 +1100, Michael Neuling wrote: > This needs a description of what you're trying to do. "Correctly" doesn't > really mean anything. > > > On Tue, 2018-02-20 at 11:22 +1100, Cyril Bur wrote: > > --- > > arch/powerpc/kernel/process.c | 57 > >

Re: [RFC PATCH 05/12] [WIP] powerpc/tm: Reclaim/recheckpoint on entry/exit

2018-02-19 Thread Cyril Bur
On Tue, 2018-02-20 at 16:25 +1100, Michael Neuling wrote: > > > > @@ -1055,6 +1082,8 @@ void restore_tm_state(struct pt_regs *regs) > > > > msr_diff = current->thread.ckpt_regs.msr & ~regs->msr; > > > > msr_diff &= MSR_FP | MSR_VEC | MSR_VSX; > > > > > > > > +

[RFC PATCH 00/12] Deal with TM on kernel entry and exit

2018-02-19 Thread Cyril Bur
This is very much a proof of concept and if it isn't clear from the commit names, still a work in progress. I believe I have something that works - all the powerpc selftests pass. I would like to get some eyes on it to a) see if I've missed anything big and b) some opinions on if it is looking

[RFC PATCH 11/12] [WIP] powerpc/tm: Afterthoughts

2018-02-19 Thread Cyril Bur
--- arch/powerpc/kernel/process.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index 674f75c56172..6ce41ee62b24 100644 --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c @@

Re: [RFC PATCH 12/12] [WIP] selftests/powerpc: Remove incorrect tm-syscall selftest

2018-02-19 Thread Michael Neuling
> --- a/tools/testing/selftests/powerpc/tm/tm-syscall.c > +++ /dev/null > @@ -1,106 +0,0 @@ > -/* > - * Copyright 2015, Sam Bobroff, IBM Corp. > - * Licensed under GPLv2. > - * > - * Test the kernel's system call code to ensure that a system call > - * made from within an active HTM transaction is

Re: [RFC PATCH 12/12] [WIP] selftests/powerpc: Remove incorrect tm-syscall selftest

2018-02-19 Thread Cyril Bur
On Tue, 2018-02-20 at 14:04 +1100, Michael Neuling wrote: > > --- a/tools/testing/selftests/powerpc/tm/tm-syscall.c > > +++ /dev/null > > @@ -1,106 +0,0 @@ > > -/* > > - * Copyright 2015, Sam Bobroff, IBM Corp. > > - * Licensed under GPLv2. > > - * > > - * Test the kernel's system call code to

Re: [RFC PATCH 05/12] [WIP] powerpc/tm: Reclaim/recheckpoint on entry/exit

2018-02-19 Thread Cyril Bur
On Tue, 2018-02-20 at 13:50 +1100, Michael Neuling wrote: > On Tue, 2018-02-20 at 11:22 +1100, Cyril Bur wrote: > > > The comment from the cover sheet should be here > > > --- > > arch/powerpc/include/asm/exception-64s.h | 25 + > > arch/powerpc/kernel/entry_64.S

[RFC PATCH 02/12] selftests/powerpc: Fix tm.h helpers

2018-02-19 Thread Cyril Bur
Turns out the tcheck() helpers were subtly wrong Signed-off-by: Cyril Bur --- tools/testing/selftests/powerpc/tm/tm.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/powerpc/tm/tm.h

[RFC PATCH 06/12] [WIP] powerpc/tm: Remove dead code from __switch_to_tm()

2018-02-19 Thread Cyril Bur
--- arch/powerpc/kernel/process.c | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index ea75da0fd506..574b05fe7d66 100644 --- a/arch/powerpc/kernel/process.c +++

Re: [PATCH] fix double ;;s in code

2018-02-19 Thread Rob Clark
On Mon, Feb 19, 2018 at 2:33 PM, Pavel Machek wrote: > On Mon 2018-02-19 16:41:35, Daniel Vetter wrote: >> On Sun, Feb 18, 2018 at 11:00:56AM +0100, Christophe LEROY wrote: >> > >> > >> > Le 17/02/2018 à 22:19, Pavel Machek a écrit : >> > > >> > > Fix double ;;'s in code. >> > > >>

Re: [PATCH V5] cxl: Fix timebase synchronization status on P9

2018-02-19 Thread Andrew Donnellan
On 20/02/18 01:28, Christophe Lombard wrote: The PSL Timebase register is updated by the PSL to maintain the timebase. On P9, the Timebase value is only provided by the CAPP as received the last time a timebase request was performed. The timebase requests are initiated through the adapter

Re: [RFC PATCH 06/12] [WIP] powerpc/tm: Remove dead code from __switch_to_tm()

2018-02-19 Thread Michael Neuling
Not sure I understand this.. should it be merged with the last patch? Needs a comment here. On Tue, 2018-02-20 at 11:22 +1100, Cyril Bur wrote: > --- > arch/powerpc/kernel/process.c | 24 +--- > 1 file changed, 5 insertions(+), 19 deletions(-) > > diff --git

Re: [RFC PATCH 10/12] [WIP] powerpc/tm: Correctly save/restore checkpointed sprs

2018-02-19 Thread Michael Neuling
On Tue, 2018-02-20 at 14:59 +1100, Cyril Bur wrote: > On Tue, 2018-02-20 at 14:00 +1100, Michael Neuling wrote: > > This needs a description of what you're trying to do. "Correctly" doesn't > > really mean anything. > > > > > > On Tue, 2018-02-20 at 11:22 +1100, Cyril Bur wrote: > > > --- > > >

[RFC PATCH 07/12] [WIP] powerpc/tm: Add TM_KERNEL_ENTRY in more delicate exception pathes

2018-02-19 Thread Cyril Bur
--- arch/powerpc/kernel/entry_64.S | 15 ++- arch/powerpc/kernel/exceptions-64s.S | 31 --- 2 files changed, 42 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S index

Re: [PATCH] fix double ;;s in code

2018-02-19 Thread Vineet Gupta
On 02/17/2018 01:19 PM, Pavel Machek wrote: Fix double ;;'s in code. Signed-off-by: Pavel Machek diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c index 9d27331..ec12fe1 100644 --- a/arch/arc/kernel/setup.c +++ b/arch/arc/kernel/setup.c @@ -373,7 +373,7 @@ static

Re: [PATCH] fix double ;;s in code

2018-02-19 Thread Michael Ellerman
Daniel Vetter writes: > On Sun, Feb 18, 2018 at 11:00:56AM +0100, Christophe LEROY wrote: >> Le 17/02/2018 à 22:19, Pavel Machek a écrit : >> > >> > Fix double ;;'s in code. >> > >> > Signed-off-by: Pavel Machek >> >> A summary of the files modified on top of

Re: [RFC PATCH 10/12] [WIP] powerpc/tm: Correctly save/restore checkpointed sprs

2018-02-19 Thread Michael Neuling
This needs a description of what you're trying to do. "Correctly" doesn't really mean anything. On Tue, 2018-02-20 at 11:22 +1100, Cyril Bur wrote: > --- > arch/powerpc/kernel/process.c | 57 +- > - > arch/powerpc/kernel/ptrace.c | 9 +++ > 2 files

Re: [RFC PATCH 06/12] [WIP] powerpc/tm: Remove dead code from __switch_to_tm()

2018-02-19 Thread Cyril Bur
On Tue, 2018-02-20 at 13:52 +1100, Michael Neuling wrote: > Not sure I understand this.. should it be merged with the last patch? > Its all going to have to be one patch - I've left it split out to make it more obvious which bits have had to mess with, this series absolutely doesn't bisect. >

Re: [RFC PATCH 05/12] [WIP] powerpc/tm: Reclaim/recheckpoint on entry/exit

2018-02-19 Thread Michael Neuling
> > > @@ -1055,6 +1082,8 @@ void restore_tm_state(struct pt_regs *regs) > > > msr_diff = current->thread.ckpt_regs.msr & ~regs->msr; > > > msr_diff &= MSR_FP | MSR_VEC | MSR_VSX; > > > > > > + tm_recheckpoint(>thread); > > > + > > > > So why do we do tm_recheckpoint at all? Shouldn't most

Re: [PATCH 16/18] crypto: talitos - do hw_context DMA mapping outside the requests

2018-02-19 Thread Horia Geantă
On 2/19/2018 9:58 AM, Christophe LEROY wrote: > Le 18/02/2018 à 18:14, Horia Geantă a écrit : >> There is no ahash_exit() callback mirroring ahash_init(). >> >> The clean-up of request ctx should be done in the last states of the hash >> flows >> described here: >>

Re: [PATCH 16/18] crypto: talitos - do hw_context DMA mapping outside the requests

2018-02-19 Thread Christophe LEROY
Le 19/02/2018 à 09:30, Horia Geantă a écrit : On 2/19/2018 9:58 AM, Christophe LEROY wrote: Le 18/02/2018 à 18:14, Horia Geantă a écrit : There is no ahash_exit() callback mirroring ahash_init(). The clean-up of request ctx should be done in the last states of the hash flows described here:

Re: [PATCH] powerpc/xmon: Dont register sysrq key when kernel param xmon=off

2018-02-19 Thread Michael Ellerman
Vaibhav Jain writes: > Michael Ellerman writes: >> >> >> What would be nice is if we keep that behaviour, but any action you take >> in xmon that requires xmon to remain resident, ie. setting a breakpoint, >> calls a function which makes sure

[PATCH] powerpc: Use generic pci_mmap_resource_range()

2018-02-19 Thread David Woodhouse
Commit f719582435 ("PCI: Add pci_mmap_resource_range() and use it for ARM64") added this generic function with the intent of using it everywhere and ultimately killing the old arch-specific implementations. Let's get on with that eradication... Signed-off-by: David Woodhouse

Re: Build regressions/improvements in v4.16-rc2

2018-02-19 Thread Geert Uytterhoeven
On Mon, Feb 19, 2018 at 2:57 PM, Geert Uytterhoeven wrote: > JFYI, when comparing v4.16-rc2[1] to v4.16-rc1[3], the summaries are: > - build errors: +5/-2 + /home/kisskb/slave/src/arch/arm64/kernel/head.S: Error: junk at end of line, first unrecognized character is `U':

Re: [PATCH V5] cxl: Fix timebase synchronization status on P9

2018-02-19 Thread Vaibhav Jain
Christophe Lombard writes: > The PSL Timebase register is updated by the PSL to maintain the > timebase. > On P9, the Timebase value is only provided by the CAPP as received > the last time a timebase request was performed. > The timebase requests are initiated

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

2018-02-19 Thread Ulf Magnusson
Hello, On Sun, Feb 18, 2018 at 11:13 PM, Sam Ravnborg wrote: > Hi Masahiro. > > On Sat, Feb 17, 2018 at 03:38:28AM +0900, Masahiro Yamada wrote: >> I brushed up the implementation in this version. >> >> In the previous RFC, CC_HAS_ was described by using 'option shell=', >>

Re: [PATCH 16/18] crypto: talitos - do hw_context DMA mapping outside the requests

2018-02-19 Thread Horia Geantă
On 2/19/2018 11:14 AM, Christophe LEROY wrote: > Le 19/02/2018 à 09:30, Horia Geantă a écrit : >> On 2/19/2018 9:58 AM, Christophe LEROY wrote: >>> Le 18/02/2018 à 18:14, Horia Geantă a écrit : There is no ahash_exit() callback mirroring ahash_init(). The clean-up of request ctx

Linux 4.16: Reported regressions as of Monday, 2018-02-19 (Was: Linux 4.16-rc2)

2018-02-19 Thread Thorsten Leemhuis
Hi! Find below my first regression report for Linux 4.16. It lists 2 regressions I'm currently aware of. Are you aware of any other regressions? Then please let me know by mail (a simple bounce or forward to the email address is enough!). For details see http://bit.ly/lnxregtrackid And please

Re: [mainline][Memory off/on][83e3c48] kernel Oops with memory hot-unplug on ppc

2018-02-19 Thread Kirill A. Shutemov
On Mon, Feb 19, 2018 at 02:47:35PM +0100, Michal Hocko wrote: > [CC Kirill - I have a vague recollection that there were some follow ups > for 83e3c48729d9 ("mm/sparsemem: Allocate mem_section at runtime for > CONFIG_SPARSEMEM_EXTREME=y"). Does any of them apply to this issue?] All fixups are

[PATCH V5] cxl: Fix timebase synchronization status on P9

2018-02-19 Thread Christophe Lombard
The PSL Timebase register is updated by the PSL to maintain the timebase. On P9, the Timebase value is only provided by the CAPP as received the last time a timebase request was performed. The timebase requests are initiated through the adapter configuration or application registers. The specific

[PATCH] cpuidle/powernv : Restore different PSSCR for idle and hotplug

2018-02-19 Thread Akshay Adiga
commit 1e1601b38e6e ("powerpc/powernv/idle: Restore SPRs for deep idle states via stop API.") uses stop-api provided by the firmware to restore PSSCR. PSSCR restore is required for handling special wakeup. When special wakeup is completed, the core enters stop state based on restored PSSCR.

Re: [PATCH V3] cxl: Fix timebase synchronization status on P9

2018-02-19 Thread christophe lombard
Le 19/02/2018 à 07:10, Vaibhav Jain a écrit : Hi Christophe, Mostly ok with this patch. Some very minor review comments: Christophe Lombard writes: --- a/drivers/misc/cxl/sysfs.c +++ b/drivers/misc/cxl/sysfs.c @@ -62,6 +62,16 @@ static ssize_t

[PATCH V4] cxl: Fix timebase synchronization status on P9

2018-02-19 Thread Christophe Lombard
The PSL Timebase register is updated by the PSL to maintain the timebase. On P9, the Timebase value is only provided by the CAPP as received the last time a timebase request was performed. The timebase requests are initiated through the adapter configuration or application registers. The specific

[RFC PATCH 1/2] powerpc/64: drop redundant defination of spin_until_cond

2018-02-19 Thread Sudeep Holla
linux/processor.h has exactly same defination for spin_until_cond. Drop the redundant defination in asm/processor.h Cc: Nicholas Piggin Cc: Michael Ellerman Signed-off-by: Sudeep Holla --- arch/powerpc/include/asm/processor.h | 11

Re: [PATCH] fix double ;;s in code

2018-02-19 Thread Daniel Vetter
On Sun, Feb 18, 2018 at 11:00:56AM +0100, Christophe LEROY wrote: > > > Le 17/02/2018 à 22:19, Pavel Machek a écrit : > > > > Fix double ;;'s in code. > > > > Signed-off-by: Pavel Machek > > A summary of the files modified on top of the patch would help understand > the impact.

Re: [PATCH] fix double ;;s in code

2018-02-19 Thread Pavel Machek
On Mon 2018-02-19 16:41:35, Daniel Vetter wrote: > On Sun, Feb 18, 2018 at 11:00:56AM +0100, Christophe LEROY wrote: > > > > > > Le 17/02/2018 à 22:19, Pavel Machek a écrit : > > > > > > Fix double ;;'s in code. > > > > > > Signed-off-by: Pavel Machek > > > > A summary of the

[PATCH 2/2] powerpc/watchdog: include linux/processor.h for spin_until_cond

2018-02-19 Thread Sudeep Holla
This implementation uses spin_until_cond in wd_smp_lock including neither linux/processor.h nor asm/processor.h This patch includes linux/processor.h here for spin_until_cond usage. Cc: Nicholas Piggin Cc: Michael Ellerman Signed-off-by: Sudeep Holla