Re: [PATCH] soc: fsl: guts: us devm_kstrdup_const() for RO data

2018-12-22 Thread Nicholas Mc Guire
On Fri, Dec 21, 2018 at 08:29:56PM -0600, Scott Wood wrote: > On Fri, 2018-12-07 at 09:22 +0100, Nicholas Mc Guire wrote: > > devm_kstrdup() may return NULL if internal allocation failed, but > > as machine is from the device tree, and thus RO, devm_kstrdup_const() > > can be used here, which

Re: powerpc/8xx: add exception frame marker

2018-12-22 Thread Michael Ellerman
On Tue, 2018-11-27 at 17:38:16 UTC, Christophe Leroy wrote: > This patch adds STACK_FRAME_REGS_MARKER in the stack at exception entry > in order to see interrupts in call traces as below: > > [0.013964] Call Trace: > [0.014014] [c0745db0] [c007a9d4] tick_periodic.constprop.5+0xd8/0x104 >

Re: lib: fix build failure in CONFIG_DEBUG_VIRTUAL test

2018-12-22 Thread Michael Ellerman
On Mon, 2018-12-10 at 08:08:28 UTC, Christophe Leroy wrote: > On several arches, virt_to_phys() is in io.h > > Build fails without it: > > CC lib/test_debug_virtual.o > lib/test_debug_virtual.c: In function 'test_debug_virtual_init': > lib/test_debug_virtual.c:26:7: error: implicit

Re: powerpc/mm: define an empty slice_init_new_context_exec()

2018-12-22 Thread Michael Ellerman
On Mon, 2018-12-10 at 12:23:05 UTC, Christophe Leroy wrote: > Define slice_init_new_context_exec() at all time to avoid > > Signed-off-by: Christophe Leroy Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/badb9687cec50bdba59746532de196 cheers

Re: ocxl/afu_irq: Don't include

2018-12-22 Thread Michael Ellerman
On Mon, 2018-12-10 at 15:13:38 UTC, Greg Kurz wrote: > The AFU irq code doesn't need to reach out to the platform. > > Signed-off-by: Greg Kurz > Acked-by: Andrew Donnellan Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/d1f75a96842b265ca2a89b7ed477a5 cheers

Re: powerpc/ptrace: cleanup do_syscall_trace_enter

2018-12-22 Thread Michael Ellerman
On Sun, 2018-12-16 at 17:28:28 UTC, "Dmitry V. Levin" wrote: > Invoke tracehook_report_syscall_entry once. > > Signed-off-by: Dmitry V. Levin Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/8dbdec0bcb416d0ef0bfd737620d08 cheers

Re: [NEXT, v2, 1/4] powerpc/pasemi: Add PCI initialisation for Nemo board.

2018-12-22 Thread Michael Ellerman
On Sun, 2018-08-19 at 20:21:55 UTC, Darren Stevens wrote: > The A-Eon Amigaone X1000's Nemo motherboard has an AMD SB600 > connected to one of the PCI-e root ports on its PaSemi > Pwrficient 1628M SoC. Normally the SB600 southbridge would be > connected to a hidden PCI-e port on the system's

Re: powerpc/mm: Eliminate not possible mmu features at compile time

2018-12-22 Thread Michael Ellerman
On Fri, 2018-11-16 at 17:08:03 UTC, Christophe Leroy wrote: > Depending on the CONFIG selected, many of the MMU features are > not possible. Lets only get the possible ones in MMU_FTRS_POSSIBLE. > > This allows gcc to get rid at compile time of code related to > not possible features. > >

Re: powerpc/book3s/32: fix number of bats in p/v_block_mapped()

2018-12-22 Thread Michael Ellerman
On Fri, 2018-11-16 at 17:27:42 UTC, Christophe Leroy wrote: > This patch fixes the loop in p_block_mapped() and v_block_mapped() > to scan the entire bat_addrs[] array. > > Signed-off-by: Christophe Leroy Applied to powerpc next, thanks.

Re: [for-next][PATCH 05/24] powerpc/frace: Use ftrace_graph_get_ret_stack() instead of curr_ret_stack

2018-12-22 Thread Michael Ellerman
Steven Rostedt writes: > From: "Steven Rostedt (VMware)" > > The structure of the ret_stack array on the task struct is going to > change, and accessing it directly via the curr_ret_stack index will no > longer give the ret_stack entry that holds the return address. To access > that,

Re: [v2, 1/2] powerpc/perf: Update perf_regs structure to include SIER

2018-12-22 Thread Michael Ellerman
On Sun, 2018-12-09 at 09:25:35 UTC, Madhavan Srinivasan wrote: > On each sample, Sample Instruction Event Register (SIER) content > is saved in pt_regs. SIER does not have a entry as-is in the pt_regs > but instead, SIER content is saved in the "dar" register of pt_regs. > > Patch adds another

Re: powerpc/perf: Fix thersholding counter data for unknown type

2018-12-22 Thread Michael Ellerman
On Sun, 2018-12-09 at 09:18:15 UTC, Madhavan Srinivasan wrote: > MMCRA[34:36] and MMCRA[38:44] expose the thresholding counter value. > Thresholding counter can be used to count latency cycles such as > load miss to reload. But threshold counter value is not relevant > when the sampled instruction

Re: [1/8] powerpc: allow NOT_COHERENT_CACHE for amigaone

2018-12-22 Thread Michael Ellerman
On Sun, 2018-12-16 at 17:19:44 UTC, Christoph Hellwig wrote: > AMIGAONE selects NOT_COHERENT_CACHE, so we better allow it. > > Signed-off-by: Christoph Hellwig Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/9286356907caa2d4737bd9dd8afe0b cheers

Re: powerpc: use mm zones more sensibly

2018-12-22 Thread Michael Ellerman
On Sun, 2018-12-16 at 16:53:49 UTC, Christoph Hellwig wrote: > Powerpc has somewhat odd usage where ZONE_DMA is used for all memory on > common 64-bit configfs, and ZONE_DMA32 is used for 31-bit schemes. > > Move to a scheme closer to what other architectures use (and I dare to > say the intent

Re: [-next] powerpc/eeh: Fix debugfs_simple_attr.cocci warnings

2018-12-22 Thread Michael Ellerman
On Thu, 2018-12-20 at 02:42:51 UTC, YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to >

Re: [v3] powerpc: implement CONFIG_DEBUG_VIRTUAL

2018-12-22 Thread Michael Ellerman
On Tue, 2018-12-11 at 22:40:53 UTC, Christophe Leroy wrote: > This patch implements CONFIG_DEBUG_VIRTUAL to warn about > incorrect use of virt_to_phys() and page_to_phys() > > Below is the result of test_debug_virtual: > > [1.438746] WARNING: CPU: 0 PID: 1 at

Re: [NEXT,v2,3/4] powerpc/pasemi: Add Nemo board device init code.

2018-12-22 Thread Michael Ellerman
On Sun, 2018-08-19 at 20:23:57 UTC, Darren Stevens wrote: > Add routines for Nemo specific devices to init at boot time, these > being board level power-off and SB600's rtc. > > Also add a run time variable to prevent these being activated > if we boot on a reference board. > >

Re: [NEXT,v2,2/4] powerpc/pasemi: Add Nemo board IRQ initroutine

2018-12-22 Thread Michael Ellerman
On Sun, 2018-08-19 at 20:21:47 UTC, Darren Stevens wrote: > Add a IRQ init routine for the Nemo board which inits and attatches > the i8259 found in the SB600, and a cascade routine to dispatch the > interrupts. > > Signed-off-by: Darren Stevens Applied to powerpc next, thanks.

Re: powerpc: Add some documentation of ISA versions

2018-12-22 Thread Michael Ellerman
On Mon, 2018-11-05 at 09:01:01 UTC, Michael Ellerman wrote: > Add some documentation on which CPU versions map to which ISA > versions. This is all publicly available information, some of it > already in the kernel source, but it's much nicer to have it all in > one place. > > Signed-off-by:

Re: powerpc/xmon: fix dump_segments()

2018-12-22 Thread Michael Ellerman
On Fri, 2018-11-16 at 17:31:08 UTC, Christophe Leroy wrote: > mfsrin() takes segment num from bits 0-3 > > Signed-off-by: Christophe Leroy Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/32c8c4c621897199e690760c2d5705 cheers

Re: [PATCH 00/11 v2] powerpc/fsl: NXP PowerPC Spectre variant 2 workarounds

2018-12-22 Thread Michael Ellerman
Diana Craciun writes: > Implement Spectre variant 2 workarounds for NXP PowerPC Book3E > processors. > > Diana Craciun (11): > Add infrastructure to fixup branch predictor flush > Add macro to flush the branch predictor > Fix spectre_v2 mitigations reporting > Emulate SPRN_BUCSR register

Re: powerpc/mm/hash: Hand user access of kernel address gracefully

2018-12-22 Thread Michael Ellerman
On Mon, 2018-11-26 at 14:35:04 UTC, "Aneesh Kumar K.V" wrote: > With commit 2865d08dd9ea ("powerpc/mm: Move the DSISR_PROTFAULT sanity check") > we moved the protection fault access check before vma lookup. That means we > hit that WARN_ON when user space access a kernel address. Before the

Re: powerpc: remove remaining bits from CONFIG_APUS

2018-12-22 Thread Michael Ellerman
On Tue, 2018-12-04 at 17:59:15 UTC, Christophe Leroy wrote: > commit f21f49ea639a ("[POWERPC] Remove the dregs of APUS support from > arch/powerpc") removed CONFIG_APUS, but forgot to remove the logic > which adapts tophys() and tovirt() for it. > > This patch removes the last stale pieces. > >

Re: [v2] powerpc/32: Move the old 6xx -mcpu logic before the TARGET_CPU logic

2018-12-22 Thread Michael Ellerman
On Wed, 2018-12-05 at 17:53:55 UTC, Mathieu Malaterre wrote: > The code: > > ifdef CONFIG_6xx > KBUILD_CFLAGS += -mcpu=powerpc > endif > > was added in 2006 in commit f48b8296b315 ("[PATCH] powerpc32: Set cpu > explicitly in kernel compiles"). This change was acceptable since the

Re: ocxl: Clarify error path in setup_xsl_irq()

2018-12-22 Thread Michael Ellerman
On Mon, 2018-12-10 at 15:18:13 UTC, Greg Kurz wrote: > Implementing rollback with goto and labels is a common practice that > leads to prettier and more maintainable code. FWIW, this design pattern > is already being used in alloc_link() a few lines below in this file. > > Do the same in

Re: [01/11] powerpc/fsl: Add infrastructure to fixup branch predictor flush

2018-12-22 Thread Michael Ellerman
On Wed, 2018-12-12 at 14:03:00 UTC, Diana Craciun wrote: > In order to protect against speculation attacks (Spectre > variant 2) on NXP PowerPC platforms, the branch predictor > should be flushed when the privillege level is changed. > This patch is adding the infrastructure to fixup at runtime >

Re: [v2] powerpc/prom: fix early DEBUG messages

2018-12-22 Thread Michael Ellerman
On Fri, 2018-12-14 at 10:27:47 UTC, Christophe Leroy wrote: > This patch fixes early DEBUG messages in prom.c: > - Use %px instead of %p to see the addresses > - Cast memblock_phys_mem_size() with (unsigned long long) to > avoid build failure when phys_addr_t is not 64 bits. > > Signed-off-by:

Re: powerpc/prom: move the device tree if not in declared memory.

2018-12-22 Thread Michael Ellerman
On Mon, 2018-12-17 at 14:18:27 UTC, Christophe Leroy wrote: > If the device tree doesn't reside in the memory which is declared > inside it, it has to be moved as well as this memory will not be > mapped by the kernel. > > Signed-off-by: Christophe Leroy Applied to powerpc next, thanks.

Re: [1/9] powerpc: simplify patch_instruction_site() and patch_branch_site()

2018-12-22 Thread Michael Ellerman
On Fri, 2018-11-09 at 17:33:15 UTC, Christophe Leroy wrote: > Using patch_site_addr() helper, patch_instruction_site() and > patch_branch_site() can be simplified and inlined. > > Signed-off-by: Christophe Leroy Series applied to powerpc next, thanks.

Re: [v2] powerpc/32: Avoid unsupported flags with clang

2018-12-22 Thread Michael Ellerman
On Mon, 2018-11-12 at 05:28:06 UTC, Joel Stanley wrote: > When building for ppc32 with clang these flags are unsupported: > > -ffixed-r2 and -mmultiple > > llvm's lib/Target/PowerPC/PPCRegisterInfo.cpp marks r2 as reserved on > when building for SVR4ABI and !ppc64: > > // The SVR4 ABI

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread Christian Lamparter
On Saturday, December 22, 2018 11:59:04 AM CET christophe leroy wrote: > > Le 22/12/2018 à 11:09, Christian Lamparter a écrit : > > This patch fixes a recent regression in ocm: > > > > ocm.c: In function ‘ocm_init_node’: > > ocm.c:182:18: error: invalid operands to binary | > > ocm.c:197:17:

Re: [v3] powerpc/mm: add exec protection on powerpc 603

2018-12-22 Thread Michael Ellerman
On Wed, 2018-11-28 at 17:21:10 UTC, Christophe Leroy wrote: > The 603 doesn't have a HASH table, TLB misses are handled by > software. It is then possible to generate page fault when > _PAGE_EXEC is not set like in nohash/32. > > There is one "reserved" PTE bit available, this patch uses > it for

Re: [v2] powerpc/ipic: Remove unused ipic_set_priority()

2018-12-22 Thread Michael Ellerman
On Thu, 2018-12-06 at 06:58:59 UTC, Michael Ellerman wrote: > ipic_set_priority() has been unused since 2006 when the last usage was > removed in commit b9f0f1bb2bca ("[POWERPC] Adapt ipic driver to new > host_ops interface, add set_irq_type to set IRQ sense"). > > Reported-by: Dan Carpenter >

Re: powerpc/configs: Don't enable PPC_EARLY_DEBUG in defconfigs

2018-12-22 Thread Michael Ellerman
On Fri, 2018-12-14 at 13:57:11 UTC, Michael Ellerman wrote: > This reverts the remains of commit b9ef7d6b11c1 ("powerpc: Update > default configurations"). > > That commit was proceeded by a commit which added a config option to > control use of BOOTX for early debug, ie. PPC_EARLY_DEBUG_BOOTX,

Re: [1/2] powerpc/perf: Add constraints for power9 l2/l3 bus events

2018-12-22 Thread Michael Ellerman
On Sun, 2018-06-10 at 14:27:01 UTC, Madhavan Srinivasan wrote: > In previous generation processors, both bus events and direct > events of performance monitoring unit can be individually > programmabled and monitored in PMCs. > > But in Power9, L2/L3 bus events are always available as a > "bank"

Re: [v2,1/2] powerpc/perf: Cleanup cache_sel bits comment

2018-12-22 Thread Michael Ellerman
On Mon, 2017-10-09 at 14:12:39 UTC, Madhavan Srinivasan wrote: > Update the raw event code comment in power9-pmu.c with respect to > "cache" bits, since power9 MMCRC does not support these. > > Signed-off-by: Madhavan Srinivasan Series applied to powerpc next, thanks.

Re: [v2] raid6/ppc: Fix build for clang

2018-12-22 Thread Michael Ellerman
On Fri, 2018-11-02 at 00:44:55 UTC, Joel Stanley wrote: > We cannot build these files with clang as it does not allow altivec > instructions in assembly when -msoft-float is passed. > > Jinsong Ji wrote: > > We currently disable Altivec/VSX support when enabling soft-float. So > > any usage of

[PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread Christian Lamparter
This patch fixes a recent regression in ocm: ocm.c: In function ‘ocm_init_node’: ocm.c:182:18: error: invalid operands to binary | ocm.c:197:17: error: invalid operands to binary | Fixes: 56f3c1413f5c ("powerpc/mm: properly set PAGE_KERNEL flags in ioremap()") Signed-off-by: Christian Lamparter

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread christophe leroy
Le 22/12/2018 à 11:09, Christian Lamparter a écrit : This patch fixes a recent regression in ocm: ocm.c: In function ‘ocm_init_node’: ocm.c:182:18: error: invalid operands to binary | ocm.c:197:17: error: invalid operands to binary | Fixes: 56f3c1413f5c ("powerpc/mm: properly set

Re: Pull request: scottwood/linux.git next

2018-12-22 Thread christophe leroy
Hi Scott, Le 22/12/2018 à 05:42, Scott Wood a écrit : Highlights include elimination of legacy clock bindings use from dts files, an 83xx watchdog handler, fixes to old dts interrupt errors, and some minor cleanup. The following changes since commit 8c6c942d33f2a79439e86f8f406afae40a5bc767:

Re: [v3] powerpc/uaccess: fix warning/error with access_ok()

2018-12-22 Thread Michael Ellerman
On Mon, 2018-12-10 at 06:50:09 UTC, Christophe Leroy wrote: > With the following piece of code, the following compilation warning > is encountered: > > if (_IOC_DIR(ioc) != _IOC_NONE) { > int verify = _IOC_DIR(ioc) & _IOC_READ ? VERIFY_WRITE : > VERIFY_READ; > >

Re: powerpc: eeh_event: convert semaphore to completion

2018-12-22 Thread Michael Ellerman
On Mon, 2018-12-10 at 21:51:57 UTC, Arnd Bergmann wrote: > For this use case, completions and semaphores are equivalent, > but semaphores are an awkward interface that should generally > be avoided, so use the completion instead. > > Signed-off-by: Arnd Bergmann Applied to powerpc next, thanks.

Re: powerpc/44x/bamboo: Fix PCI range

2018-12-22 Thread Michael Ellerman
On Tue, 2018-12-11 at 02:27:33 UTC, Benjamin Herrenschmidt wrote: > >From 88509506b80b4960004146280eb740be64513a0b Mon Sep 17 00:00:00 2001 > The bamboo dts has a bug: it uses a non-naturally aligned range > for PCI memory space. This isnt' supported by the code, thus > causing PCI to break on

Re: [v2] powerpc/mm: make NULL pointer deferences explicit on bad page faults.

2018-12-22 Thread Michael Ellerman
On Fri, 2018-12-14 at 15:23:33 UTC, Christophe Leroy wrote: > As several other arches including x86, this patch makes it explicit > that a bad page fault is a NULL pointer dereference when the fault > address is lower than PAGE_SIZE > > In the mean time, this page makes all bad_page_fault()

Re: ocxl: Fix endiannes bug in ocxl_link_update_pe()

2018-12-22 Thread Michael Ellerman
On Sun, 2018-12-16 at 21:28:50 UTC, Greg Kurz wrote: > All fields in the PE are big-endian. Use cpu_to_be32() like everywhere > else something is written to the PE. Otherwise a wrong TID will be used > by the NPU. If this TID happens to point to an existing thread sharing > the same mm, it could

Re: [NEXT,v2,2/4] powerpc/pasemi: Add Nemo board IRQ initroutine

2018-12-22 Thread Michael Ellerman
On Sun, 2018-08-19 at 20:21:47 UTC, Darren Stevens wrote: > Add a IRQ init routine for the Nemo board which inits and attatches > the i8259 found in the SB600, and a cascade routine to dispatch the > interrupts. > > Signed-off-by: Darren Stevens Applied to powerpc next, thanks.

Re: powerpc/mm: remove unused variable

2018-12-22 Thread Michael Ellerman
On Thu, 2018-10-18 at 05:22:06 UTC, Christophe Leroy wrote: > In file included from ./include/linux/hugetlb.h:445:0, > from arch/powerpc/kernel/setup-common.c:37: > ./arch/powerpc/include/asm/hugetlb.h: In function > ‘huge_ptep_clear_flush’: >

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread Segher Boessenkool
On Sat, Dec 22, 2018 at 02:08:02PM +0100, christophe leroy wrote: > > Usually, Guarded implies no exec (at least on 6xx and 8xx). Huh? What do you mean here? Segher

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread christophe leroy
Le 22/12/2018 à 18:16, Segher Boessenkool a écrit : On Sat, Dec 22, 2018 at 02:08:02PM +0100, christophe leroy wrote: Usually, Guarded implies no exec (at least on 6xx and 8xx). Huh? What do you mean here? From the 885 Reference Manual: Address translation: the EA is translated by

Re: [PATCH v2] powerpc/4xx/ocm: fix compilation error

2018-12-22 Thread christophe leroy
Le 22/12/2018 à 15:35, Christian Lamparter a écrit : This patch fixes a recent compilation regression in ocm: | ocm.c: In function ‘ocm_init_node’: | ocm.c:182:18: error: invalid operands to binary | | (have ‘int’ and ‘pgprot_t’ {aka ‘struct ’}) | _PAGE_EXEC | PAGE_KERNEL_NCG); |

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread christophe leroy
Le 22/12/2018 à 12:27, Christian Lamparter a écrit : On Saturday, December 22, 2018 11:59:04 AM CET christophe leroy wrote: Le 22/12/2018 à 11:09, Christian Lamparter a écrit : This patch fixes a recent regression in ocm: ocm.c: In function ‘ocm_init_node’: ocm.c:182:18: error: invalid

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread Christian Lamparter
On Saturday, December 22, 2018 2:08:02 PM CET christophe leroy wrote: > > Le 22/12/2018 à 12:27, Christian Lamparter a écrit : > > On Saturday, December 22, 2018 11:59:04 AM CET christophe leroy wrote: > >> > >> Le 22/12/2018 à 11:09, Christian Lamparter a écrit : > >>> This patch fixes a recent

Re: [for-next][PATCH 05/24] powerpc/frace: Use ftrace_graph_get_ret_stack() instead of curr_ret_stack

2018-12-22 Thread Steven Rostedt
On Sat, 22 Dec 2018 20:51:21 +1100 Michael Ellerman wrote: > I did test the previous series you posted and I think everything was OK > running the ftracetest suite (I got one or two fails but I think that > was because of missing CONFIG options). > > Acked-by: Michael Ellerman (powerpc)

[PATCH v2] powerpc/4xx/ocm: fix compilation error

2018-12-22 Thread Christian Lamparter
This patch fixes a recent compilation regression in ocm: | ocm.c: In function ‘ocm_init_node’: | ocm.c:182:18: error: invalid operands to binary | | (have ‘int’ and ‘pgprot_t’ {aka ‘struct ’}) | _PAGE_EXEC | PAGE_KERNEL_NCG); | ^ | | ocm.c:197:17: error: invalid

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread Segher Boessenkool
On Sat, Dec 22, 2018 at 08:37:28PM +0100, christophe leroy wrote: > Le 22/12/2018 à 18:16, Segher Boessenkool a écrit : > >On Sat, Dec 22, 2018 at 02:08:02PM +0100, christophe leroy wrote: > >> > >>Usually, Guarded implies no exec (at least on 6xx and 8xx). > > > >Huh? What do you mean here? > >

Re: Pull request: scottwood/linux.git next

2018-12-22 Thread Scott Wood
On Sat, 2018-12-22 at 11:50 +0100, christophe leroy wrote: > Hi Scott, > > Le 22/12/2018 à 05:42, Scott Wood a écrit : > > Christophe Leroy (1): > >powerpc/83xx: handle machine check caused by watchdog timer > > kbuild robot reported a build failure, most likely due to missing >