Re: [PATCH] mm: add account_locked_vm utility function

2019-05-03 Thread Jason Gunthorpe
On Fri, May 03, 2019 at 01:16:30PM -0700, Daniel Jordan wrote: > locked_vm accounting is done roughly the same way in five places, so > unify them in a helper. Standardize the debug prints, which vary > slightly. Error codes stay the same, so user-visible behavior does too. > > Signed-off-by:

Re: [PATCH 14/15] um: switch to generic version of pte allocation

2019-05-03 Thread Anton Ivanov
On 02/05/2019 16:28, Mike Rapoport wrote: um allocates PTE pages with __get_free_page() and uses GFP_KERNEL | __GFP_ZERO for the allocations. Switch it to the generic version that does exactly the same thing for the kernel page tables and adds __GFP_ACCOUNT for the user PTEs. The pte_free()

Re: [PATCH V6 1/3] ASoC: fsl_asrc: Fix the issue about unsupported rate

2019-05-03 Thread Mark Brown
On Mon, Apr 22, 2019 at 04:52:02AM +, S.j. Wang wrote: > When the output sample rate is [8kHz, 30kHz], the limitation > of the supported ratio range is [1/24, 8]. In the driver > we use (8kHz, 30kHz) instead of [8kHz, 30kHz]. > So this patch is to fix this issue and the potential rounding >

[PATCH v3 1/3] powerpc: Move PPC_HA() PPC_HI() and PPC_LO() to ppc-opcode.h

2019-05-03 Thread Christophe Leroy
PPC_HA() PPC_HI() and PPC_LO() macros are nice macros. Move them from module64.c to ppc-opcode.h in order to use them in other places. Signed-off-by: Christophe Leroy --- v3: no change v2: no change arch/powerpc/include/asm/ppc-opcode.h | 7 +++ arch/powerpc/kernel/module_64.c | 7

Re: [PATCH v11 10/13] powerpc/32: Add KASAN support

2019-05-03 Thread Christophe Leroy
Le 26/04/2019 à 18:23, Christophe Leroy a écrit : This patch adds KASAN support for PPC32. The following patch will add an early activation of hash table for book3s. Until then, a warning will be raised if trying to use KASAN on an hash 6xx. To support KASAN, this patch initialises that MMU

Re: [PATCH v2] powerpc/64s: Remove 'dummy_copy_buffer'

2019-05-03 Thread Michael Ellerman
On Wed, 2019-03-13 at 20:00:30 UTC, Mathieu Malaterre wrote: > In commit 2bf1071a8d50 ("powerpc/64s: Remove POWER9 DD1 support") the > function __switch_to remove usage for 'dummy_copy_buffer'. Since it is > not used anywhere else, remove it completely. > > This remove the following warning: > >

Re: [PATCH 1/7] powerpc/fadump: define an empty fadump_cleanup()

2019-05-03 Thread Michael Ellerman
On Fri, 2019-03-22 at 08:08:39 UTC, Christophe Leroy wrote: > To avoid #ifdefs, define an static inline fadump_cleanup() function > when CONFIG_FADUMP is not selected > > Signed-off-by: Christophe Leroy Series applied to powerpc next, thanks.

Re: [PATCH] powerpc/irq: drop __irq_offset_value

2019-05-03 Thread Michael Ellerman
On Sat, 2019-03-09 at 17:47:27 UTC, Christophe Leroy wrote: > This patch drops__irq_offset_value which has not been used since > commit 9c4cb8251513 ("powerpc: Remove use of CONFIG_PPC_MERGE") > > This removes a sparse warning. > > Fixes: 9c4cb8251513 ("powerpc: Remove use of CONFIG_PPC_MERGE")

Re: [PATCH 08/14] powerpc: entry: Remove unneeded need_resched() loop

2019-05-03 Thread Michael Ellerman
On Mon, 2019-03-11 at 22:47:46 UTC, Valentin Schneider wrote: > Since the enabling and disabling of IRQs within preempt_schedule_irq() > is contained in a need_resched() loop, we don't need the outer arch > code loop. > > Signed-off-by: Valentin Schneider > Cc: Benjamin Herrenschmidt > Cc: Paul

Re: [PATCH v4 1/7] ocxl: Split pci.c

2019-05-03 Thread Michael Ellerman
On Wed, 2019-03-27 at 05:31:30 UTC, "Alastair D'Silva" wrote: > From: Alastair D'Silva > > In preparation for making core code available for external drivers, > move the core code out of pci.c and into core.c > > Signed-off-by: Alastair D'Silva > Acked-by: Frederic Barrat > Acked-by: Andrew

Re: [PATCH v2 01/11] powerpc/mm: fix erroneous duplicate slb_addr_limit init

2019-05-03 Thread Michael Ellerman
On Thu, 2019-04-25 at 14:29:27 UTC, Christophe Leroy wrote: > Commit 67fda38f0d68 ("powerpc/mm: Move slb_addr_linit to > early_init_mmu") moved slb_addr_limit init out of setup_arch(). > > Commit 701101865f5d ("powerpc/mm: Reduce memory usage for mm_context_t > for radix") brought it back into

Re: [PATCH] powerpc: vdso: drop unnecessary cc-ldoption

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-23 at 21:11:14 UTC, Nick Desaulniers wrote: > Towards the goal of removing cc-ldoption, it seems that --hash-style= > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > of binutils for the kernel according to > Documentation/process/changes.rst is 2.20. > >

Re: [PATCH][next] powerpc/mm: fix spelling mistake "Outisde" -> "Outside"

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-23 at 15:10:17 UTC, Colin King wrote: > From: Colin Ian King > > There are several identical spelling mistakes in warning messages, > fix these. > > Signed-off-by: Colin Ian King Applied to powerpc next, thanks.

Re: [PATCH] arch: fix without checked-return value with lseek

2019-05-03 Thread Michael Ellerman
On Tue, 2018-10-30 at 13:21:55 UTC, Bo YU wrote: > lseek should have returned value but we miss it maybe. > This is detected by Coverity scan: > CID: 1440481 > > Signed-off-by: Bo YU Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/5d085ec04a000fefb5182d3b03ee46ca cheers

Re: [PATCH] powerpc/powernv: Restrict OPAL symbol map to only be readable by root

2019-05-03 Thread Andrew Donnellan
On 3/5/19 5:48 pm, Greg KH wrote: no tab? checkpatch.pl is your friend :) Ughh. Sadly our CI is currently down ;) Respun. -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

[PATCH v2] powerpc/powernv: Restrict OPAL symbol map to only be readable by root

2019-05-03 Thread Andrew Donnellan
Currently the OPAL symbol map is globally readable, which seems bad as it contains physical addresses. Restrict it to root. Suggested-by: Michael Ellerman Cc: Jordan Niethe Cc: Stewart Smith Fixes: c8742f85125d ("powerpc/powernv: Expose OPAL firmware symbol map") Cc: sta...@vger.kernel.org

[PATCH v3 10/10] powerpc: tsi108: support of_get_mac_address new ERR_PTR error

2019-05-03 Thread Petr Štetiar
There was NVMEM support added to of_get_mac_address, so it could now return NULL and ERR_PTR encoded error values, so we need to adjust all current users of of_get_mac_address to this new fact. Signed-off-by: Petr Štetiar --- arch/powerpc/sysdev/tsi108_dev.c | 2 +- 1 file changed, 1

Re: [PATCH v2] powerpc/powernv: Restrict OPAL symbol map to only be readable by root

2019-05-03 Thread Greg KH
On Fri, May 03, 2019 at 05:52:53PM +1000, Andrew Donnellan wrote: > Currently the OPAL symbol map is globally readable, which seems bad as it > contains physical addresses. > > Restrict it to root. > > Suggested-by: Michael Ellerman > Cc: Jordan Niethe > Cc: Stewart Smith > Fixes:

Re: [PATCH] powerpc/powernv/ioda2: Add __printf format/argument verification

2019-05-03 Thread Mathieu Malaterre
On Fri, May 3, 2019 at 10:21 AM Joe Perches wrote: > > On Fri, 2019-05-03 at 16:59 +1000, Michael Ellerman wrote: > > On Thu, 2017-03-30 at 10:19:25 UTC, Joe Perches wrote: > > > Fix fallout too. > > > > > > Signed-off-by: Joe Perches > > > > Applied to powerpc next, thanks. > > > >

Re: [PATCH] Selftests/powerpc: Add a signal fuzzer selftest

2019-05-03 Thread Michael Ellerman
On Thu, 2019-01-17 at 17:01:54 UTC, Breno Leitao wrote: > This is a new selftest that raises SIGUSR1 signals and handles it in a set > of different ways, trying to create different scenario for testing > purpose. > > This test works raising a signal and calling sigreturn interleaved with > TM

Re: [PATCH] powerpc: config: skiroot: Add (back) MLX5 ethernet support

2019-05-03 Thread Michael Ellerman
On Wed, 2019-04-03 at 00:49:26 UTC, Joel Stanley wrote: > It turns out that some defconfig changes and kernel config option > changes meant we accidentally dropped Ethernet support for Mellanox CLX5 > cards. > > Reported-by: Carol L Soto > Suggested-by: Carol L Soto > Signed-off-by: Stewart

Re: [PATCH 2/2] powerpc/perf: Add generic compat mode pmu driver

2019-05-03 Thread Michael Ellerman
On Thu, 2019-04-04 at 11:54:50 UTC, Madhavan Srinivasan wrote: > Most of the power processor generation performance monitoring > unit (PMU) driver code is bundled in the kernel and one of those > is enabled/registered based on the oprofile_cpu_type check at > the boot. > > But things get little

Re: [PATCH v2 01/15] powerpc/mm: drop __bad_pte()

2019-05-03 Thread Michael Ellerman
On Fri, 2019-04-26 at 15:57:59 UTC, Christophe Leroy wrote: > This has never been called (since Kernel has been in git at least), > drop it. > > Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Christophe Leroy Series applied to powerpc next, thanks.

Re: [PATCH v11 01/13] powerpc/32: Move early_init() in a separate file

2019-05-03 Thread Michael Ellerman
On Fri, 2019-04-26 at 16:23:25 UTC, Christophe Leroy wrote: > In preparation of KASAN, move early_init() into a separate > file in order to allow deactivation of KASAN for that function. > > Signed-off-by: Christophe Leroy Series applied to powerpc next, thanks.

Re: [PATCH] powerpc/64: Don't trace code that runs with the soft irq mask unreconciled

2019-05-03 Thread Michael Ellerman
On Thu, 2019-05-02 at 05:21:07 UTC, Nicholas Piggin wrote: > "Reconciling" in terms of interrupt handling, is to bring the soft irq > mask state in to synch with the hardware, after an interrupt causes > MSR[EE] to be cleared (while the soft mask may be enabled, and hard > irqs not marked

Re: [PATCH v2] powerpc/pseries: Track LMB nid instead of using device tree

2019-05-03 Thread Michael Ellerman
On Tue, 2018-10-02 at 15:35:59 UTC, Nathan Fontenot wrote: > When removing memory we need to remove the memory from the node > it was added to instead of looking up the node it should be in > in the device tree. > > During testing we have seen scenarios where the affinity for a > LMB changes due

[PATCH] powerpc/powernv: Restrict OPAL symbol map to only be readable by root

2019-05-03 Thread Andrew Donnellan
Currently the OPAL symbol map is globally readable, which seems bad as it contains physical addresses. Restrict it to root. Suggested-by: Michael Ellerman Cc: Jordan Niethe Cc: Stewart Smith Fixes: c8742f85125d ("powerpc/powernv: Expose OPAL firmware symbol map") Cc: sta...@vger.kernel.org

Re: [PATCH 04/15] arm64: switch to generic version of pte allocation

2019-05-03 Thread Mark Rutland
Hi, On Thu, May 02, 2019 at 06:28:31PM +0300, Mike Rapoport wrote: > The PTE allocations in arm64 are identical to the generic ones modulo the > GFP flags. > > Using the generic pte_alloc_one() functions ensures that the user page > tables are allocated with __GFP_ACCOUNT set. > > The arm64

Re: [PATCH v2] powerpc: Add force enable of DAWR on P9 option

2019-05-03 Thread Michael Ellerman
On Mon, 2019-04-01 at 06:03:12 UTC, Michael Neuling wrote: > This adds a flag so that the DAWR can be enabled on P9 via: > echo Y > /sys/kernel/debug/powerpc/dawr_enable_dangerous > > The DAWR was previously force disabled on POWER9 in: > 9654153158 powerpc: Disable DAWR in the base POWER9

Re: [PATCH v5 01/16] powerpc/xive: add OPAL extensions for the XIVE native exploitation support

2019-05-03 Thread Michael Ellerman
On Wed, 2019-04-10 at 17:04:33 UTC, =?utf-8?q?C=C3=A9dric_Le_Goater?= wrote: > The support for XIVE native exploitation mode in Linux/KVM needs a > couple more OPAL calls to get and set the state of the XIVE internal > structures being used by a sPAPR guest. > > Signed-off-by: Céddric Le Goater

Re: [PATCH] powerpc/perf: Return accordingly on invalid chip-id in

2019-05-03 Thread Michael Ellerman
On Tue, 2018-11-27 at 08:24:52 UTC, Anju T Sudhakar wrote: > Nest hardware counter memory resides in a per-chip reserve-memory. > During nest_imc_event_init(), chip-id of the event-cpu is considered to > calculate the base memory addresss for that cpu. Return, proper error > condition if the

Re: [PATCH v4] powerpc/xmon: add read-only mode

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-16 at 03:26:38 UTC, "Christopher M. Riedl" wrote: > Operations which write to memory and special purpose registers should be > restricted on systems with integrity guarantees (such as Secure Boot) > and, optionally, to avoid self-destructive behaviors. > > Add a config option,

Re: [PATCH v3 1/3] powerpc/32s: drop Hash_end

2019-05-03 Thread Michael Ellerman
On Fri, 2019-04-26 at 16:36:36 UTC, Christophe Leroy wrote: > Hash_end has never been used, drop it. > > Signed-off-by: Christophe Leroy Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/57e0491b58fa2a217029b69651149900 cheers

Re: [PATCH v3 1/3] powernv/mce: reduce mce console logs to lesser lines.

2019-05-03 Thread Michael Ellerman
On Mon, 2019-04-29 at 18:15:48 UTC, Mahesh Salgaonkar wrote: > Also add cpu number while displaying mce log. This will help cleaner logs > when mce hits on multiple cpus simultaneously. > > before the changes the mce o/p was: > > [ 127.223515] Severe Machine check interrupt [Recovered] > [

Re: [PATCH v3 01/16] powerpc/32: Refactor EXCEPTION entry macros for head_8xx.S and head_32.S

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-30 at 12:38:50 UTC, Christophe Leroy wrote: > EXCEPTION_PROLOG is similar in head_8xx.S and head_32.S > > This patch creates head_32.h and moves EXCEPTION_PROLOG macro > into it. It also converts it from a GCC macro to a GAS macro > in order to ease refactorisation with 40x later,

Re: [PATCH v2] powerpc/32s: fix BATs setting with CONFIG_STRICT_KERNEL_RWX

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-30 at 16:11:59 UTC, Christophe Leroy wrote: > Serge reported some crashes with CONFIG_STRICT_KERNEL_RWX enabled > on a book3s32 machine. > > Analysis shows two issues: > - BATs addresses and sizes are not properly aligned. > - There is a gap between the last address covered by

Re: [PATCH] powerpc/powernv/ioda2: Add __printf format/argument verification

2019-05-03 Thread Joe Perches
On Fri, 2019-05-03 at 16:59 +1000, Michael Ellerman wrote: > On Thu, 2017-03-30 at 10:19:25 UTC, Joe Perches wrote: > > Fix fallout too. > > > > Signed-off-by: Joe Perches > > Applied to powerpc next, thanks. > > https://git.kernel.org/powerpc/c/1e496391a8452101308a23b7395cdd49 2+ years

Re: [PATCH v2] powerpc/perf: Fix loop exit condition in nest_imc_event_init

2019-05-03 Thread Michael Ellerman
On Tue, 2018-12-18 at 06:20:41 UTC, Anju T Sudhakar wrote: > The data structure (i.e struct imc_mem_info) to hold the memory address > information for nest imc units is allocated based on the number of nodes > in the system. > > nest_imc_event_init() traverse this struct array to calculate the

Re: [PATCH] powerpc/tm: Avoid machine crash on rt_sigreturn

2019-05-03 Thread Michael Ellerman
On Wed, 2019-01-16 at 16:47:44 UTC, Breno Leitao wrote: > There is a kernel crash that happens if rt_sigreturn is called inside a > transactional block. > > This crash happens if the kernel hits an in-kernel page fault when > accessing userspace memory, usually through copy_ckvsx_to_user(). A

Re: [PATCH v1 1/4] powerpc/mm: change #include "mmu_decl.h" to

2019-05-03 Thread Michael Ellerman
On Fri, 2019-03-29 at 09:59:59 UTC, Christophe Leroy wrote: > This patch make inclusion of mmu_decl.h independant of the location > of the file including it. > > Signed-off-by: Christophe Leroy Series applied to powerpc next, thanks.

Re: [PATCH] Documentation: powerpc: Expand the DAWR acronym

2019-05-03 Thread Michael Ellerman
On Mon, 2019-04-01 at 06:11:56 UTC, Joel Stanley wrote: > Those not of us not drowning in POWER might not know what this means. > > Signed-off-by: Joel Stanley > Acked-by: Michael Neuling Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/29b861ea7742e571c1940366944eabc2

Re: [PATCH v2] powerpc/watchdog: Use hrtimers for per-CPU heartbeat

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-09 at 04:40:05 UTC, Nicholas Piggin wrote: > Using a jiffies timer creates a dependency on the tick_do_timer_cpu > incrementing jiffies. If that CPU has locked up and jiffies is not > incrementing, the watchdog heartbeat timer for all CPUs stops and > creates false positives and

Re: [PATCH] powerpc: Fix kobject memleak

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-30 at 01:09:23 UTC, "Tobin C. Harding" wrote: > Currently error return from kobject_init_and_add() is not followed by a > call to kobject_put(). This means there is a memory leak. > > Add call to kobject_put() in error path of kobject_init_and_add(). > > Signed-off-by: Tobin C.

Re: [PATCH v4 1/5] powerpc/include: Add data structures and macros for IMC trace mode

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-16 at 09:48:27 UTC, Anju T Sudhakar wrote: > Add the macros needed for IMC (In-Memory Collection Counters) trace-mode > and data structure to hold the trace-imc record data. > Also, add the new type "OPAL_IMC_COUNTERS_TRACE" in 'opal-api.h', since > there is a new switch case added

Re: [PATCH v2 03/17] powerpc/book3e: drop mmu_get_tsize()

2019-05-03 Thread Michael Ellerman
On Fri, 2019-04-26 at 05:59:38 UTC, Christophe Leroy wrote: > This function is not used anymore, drop it. > > Fixes: b42279f0165c ("powerpc/mm/nohash: MM_SLICE is only used by book3s 64") > Signed-off-by: Christophe Leroy Patches 3-17 applied to powerpc next, thanks.

Re: [PATCH] MAINTAINERS: Update cxl/ocxl email address

2019-05-03 Thread Michael Ellerman
On Thu, 2019-05-02 at 06:00:41 UTC, Andrew Donnellan wrote: > Use my @linux.ibm.com email to avoid a layer of redirection. > > Signed-off-by: Andrew Donnellan Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/4c1bd90477c60618eb6dfba2e92d3a28 cheers

Re: [PATCH] powerpc/powernv/ioda2: Add __printf format/argument verification

2019-05-03 Thread Michael Ellerman
On Thu, 2017-03-30 at 10:19:25 UTC, Joe Perches wrote: > Fix fallout too. > > Signed-off-by: Joe Perches Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/1e496391a8452101308a23b7395cdd49 cheers

Re: [PATCH] powerpc: Add doorbell tracepoints

2019-05-03 Thread Michael Ellerman
On Thu, 2018-10-04 at 06:23:37 UTC, Anton Blanchard wrote: > When analysing sources of OS jitter, I noticed that doorbells cannot be > traced. > > Signed-off-by: Anton Blanchard Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/5b2a15296210d3b70e06d0f09a8e701f cheers

Re: [PATCH] powerpc/powernv: Restrict OPAL symbol map to only be readable by root

2019-05-03 Thread Greg KH
On Fri, May 03, 2019 at 05:44:05PM +1000, Andrew Donnellan wrote: > Currently the OPAL symbol map is globally readable, which seems bad as it > contains physical addresses. > > Restrict it to root. > > Suggested-by: Michael Ellerman > Cc: Jordan Niethe > Cc: Stewart Smith > Fixes:

Re: [PATCH v2] powerpc/powernv: Restrict OPAL symbol map to only be readable by root

2019-05-03 Thread Andrew Donnellan
On 3/5/19 6:35 pm, Greg KH wrote: Are we actually racing against userspace in a subsys initcall? You can be, if you subsys is a module :) For various reasons, we don't compile core system firmware interfaces into modules... that could be an interesting exercise. :D -- Andrew Donnellan

Re: [RESEND PATCH v3 05/11] mtd: rawnand: vf610_nfc: add initializer to avoid -Wmaybe-uninitialized

2019-05-03 Thread Masahiro Yamada
Hi Miquel, On Thu, May 2, 2019 at 11:14 PM Miquel Raynal wrote: > > Hi Masahiro, > > Masahiro Yamada wrote on Tue, 23 Apr > 2019 12:49:53 +0900: > > > This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common > > place. We need to eliminate potential issues beforehand. > > > > Kbuild

[PATCH v3 3/3] powerpc/module64: Use symbolic instructions names.

2019-05-03 Thread Christophe Leroy
To increase readability/maintainability, replace hard coded instructions values by symbolic names. Signed-off-by: Christophe Leroy --- v3: fixed warning by adding () in an 'if' around X | Y (unlike said in v2 history, this change was forgotten in v2) v2: rearranged comments

[PATCH v3 2/3] powerpc/module32: Use symbolic instructions names.

2019-05-03 Thread Christophe Leroy
To increase readability/maintainability, replace hard coded instructions values by symbolic names. Signed-off-by: Christophe Leroy --- v3: no change v2: Remove the ENTRY_JMP0 and ENTRY_JMP1 macros ; left real instructions as a comment. arch/powerpc/kernel/module_32.c | 24

Re: [PATCH v9 1/2] powerpc/64s: reimplement book3s idle code in C

2019-05-03 Thread Michael Ellerman
On Fri, 2019-04-12 at 14:30:52 UTC, Nicholas Piggin wrote: > Reimplement Book3S idle code in C, moving POWER7/8/9 implementation > speific HV idle code to the powernv platform code. > > Book3S assembly stubs are kept in common code and used only to save > the stack frame and non-volatile GPRs

Re: [PATCH] powerpc/hmi: Fix kernel hang when TB is in error state.

2019-05-03 Thread Michael Ellerman
On Mon, 2019-03-04 at 19:42:19 UTC, Mahesh J Salgaonkar wrote: > From: Mahesh Salgaonkar > > On TOD/TB errors timebase register stops/freezes until HMI error recovery > gets TOD/TB back into running state. On successful recovery, TB starts > running again and udelay() that relies on TB value

Re: [PATCH] powerpc/dts/fsl: add crypto node alias for B4

2019-05-03 Thread Michael Ellerman
On Wed, 2019-03-20 at 12:55:16 UTC, =?utf-8?q?Horia_Geant=C4=83?= wrote: > crypto node alias is needed by U-boot to identify the node and > perform fix-ups, like adding "fsl,sec-era" property. > > Signed-off-by: Horia Geantă Applied to powerpc next, thanks.

Re: [PATCH] powerpc/book3e: drop BUG_ON() in map_kernel_page()

2019-05-03 Thread Michael Ellerman
On Thu, 2019-03-28 at 13:03:45 UTC, Christophe Leroy wrote: > early_alloc_pgtable() never returns NULL as it panics on failure. > > This patch drops the three BUG_ON() which check the non nullity > of early_alloc_pgtable() returned value. > > Signed-off-by: Christophe Leroy Applied to powerpc

Re: [PATCH] powerpc/perf: Remove PM_BR_CMPL_ALT from power9 event list

2019-05-03 Thread Michael Ellerman
On Mon, 2019-04-01 at 06:20:39 UTC, Madhavan Srinivasan wrote: > PM_BR_CMPL_ALT event is not supported and remove from the power9 event list > > Fixes: 24bedcb7c811 ('powerpc/perf: Fix branch event code for power9') > Signed-off-by: Madhavan Srinivasan Applied to powerpc next, thanks.

Re: [PATCH v4 1/4] ocxl: Rename struct link to ocxl_link

2019-05-03 Thread Michael Ellerman
On Mon, 2019-03-25 at 05:34:52 UTC, "Alastair D'Silva" wrote: > From: Alastair D'Silva > > The term 'link' is ambiguous (especially when the struct is used for a > list), so rename it for clarity. > > Signed-off-by: Alastair D'Silva > Reviewed-by: Greg Kurz > Acked-by: Frederic Barrat >

Re: [PATCH] powerpc/nohash64: clean pgtable.h

2019-05-03 Thread Michael Ellerman
On Thu, 2019-03-28 at 13:19:47 UTC, Christophe Leroy wrote: > TRANSPARENT_HUGEPAGE is only supported by book3s > > VMEMMAP_REGION_ID is never used > > Signed-off-by: Christophe Leroy Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/71faf8145cdc20f22aa398eb7b206b33 cheers

Re: [PATCH -next] ocxl: remove set but not used variables 'tid' and 'lpid'

2019-05-03 Thread Michael Ellerman
On Fri, 2019-03-29 at 15:44:56 UTC, Yue Haibing wrote: > From: YueHaibing > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/misc/ocxl/link.c: In function 'xsl_fault_handler': > drivers/misc/ocxl/link.c:187:17: warning: variable 'tid' set but not used > [-Wunused-but-set-variable]

Re: [PATCH 4/9] powerpc/prom_init: get rid of PROM_SCRATCH_SIZE

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-02 at 09:08:38 UTC, Christophe Leroy wrote: > PROM_SCRATCH_SIZE is same as sizeof(prom_scratch) > > Signed-off-by: Christophe Leroy Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/d7fbe2a0439ce6f20917a65990a78c9e cheers

Re: [PATCH] powerpc/security: Show powerpc_security_features in debugfs

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-09 at 13:14:20 UTC, Michael Ellerman wrote: > This can be helpful for debugging problems with the security feature > flags, especially on guests where the flags come from the hypervisor > via an hcall and so can't be observed in the device tree. > > Signed-off-by: Michael Ellerman

Re: [PATCH v2 1/2] powerpc/perf: init pmu from core-book3s

2019-05-03 Thread Michael Ellerman
On Thu, 2019-04-04 at 11:54:49 UTC, Madhavan Srinivasan wrote: > Currenty pmu driver file for each ppc64 generation processor > has a __init call in itself. Refactor the code by moving the > __init call to core-books.c. This also clean's up compat mode > pmu driver registration. > > Suggested-by:

Re: [PATCH kernel] powerpc/powernv/ioda: Handle failures correctly in pnv_pci_ioda_iommu_bypass_supported

2019-05-03 Thread Michael Ellerman
On Wed, 2019-04-10 at 06:48:00 UTC, Alexey Kardashevskiy wrote: > When the return value type was changed from int to bool, few places were > left unchanged, this fixes them. We did not hit these failures as > the first one is not happening at all and the second one is little more > likely to

Re: [PATCH v2] powerpc/booke64: set RI in default MSR

2019-05-03 Thread Michael Ellerman
On Mon, 2019-04-15 at 11:52:11 UTC, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > Set RI in the default kernel's MSR so that the architected way of > detecting unrecoverable machine check interrupts has a chance to work. > This is inline with the MSR setup of the rest of booke

Re: [PATCH v2] powerpc: remove the __kernel_io_end export

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-30 at 18:27:39 UTC, Christoph Hellwig wrote: > This export was added in this merge window, but without any actual > user, or justification for a modular user. > > Fixes: a35a3c6f6065 ("powerpc/mm/hash64: Add a variable to track the end of > IO mapping") > Signed-off-by: Christoph

Re: [PATCH v2 1/2] powerpc/mm/ptdump: Wrap seq_printf() to handle NULL pointers

2019-05-03 Thread Michael Ellerman
On Thu, 2019-05-02 at 07:39:46 UTC, Russell Currey wrote: > Lovingly borrowed from the arch/arm64 ptdump code. > > This doesn't seem to be an issue in practice, but is necessary for my > upcoming commit. > > Signed-off-by: Russell Currey Series applied to powerpc next, thanks.

Re: [PATCH] powerpc/mm/radix: Fix kernel crash when running subpage protect test

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-30 at 07:59:07 UTC, "Aneesh Kumar K.V" wrote: > This patch fixes the below crash by making sure we touch the subpage > protection > related structures only if we know they are allocated on the platform. With > radix translation we don't allocate hash context at all and trying to

Re: [PATCH v11 09/13] powerpc: disable KASAN instrumentation on early/critical files.

2019-05-03 Thread Christophe Leroy
Le 26/04/2019 à 18:23, Christophe Leroy a écrit : All files containing functions run before kasan_early_init() is called must have KASAN instrumentation disabled. For those file, branch profiling also have to be disabled otherwise each if () generates a call to ftrace_likely_update().

[PATCH v3 05/10] net: ethernet: support of_get_mac_address new ERR_PTR error

2019-05-03 Thread Petr Štetiar
There was NVMEM support added to of_get_mac_address, so it could now return NULL and ERR_PTR encoded error values, so we need to adjust all current users of of_get_mac_address to this new fact. While at it, remove superfluous is_valid_ether_addr as the MAC address returned from of_get_mac_address

Re: [PATCH v2] powerpc/powernv: Restrict OPAL symbol map to only be readable by root

2019-05-03 Thread Andrew Donnellan
On 3/5/19 5:59 pm, Greg KH wrote:>> -static BIN_ATTR_RO(symbol_map, 0); +static struct bin_attribute symbol_map_attr = { + .attr = {.name = "symbol_map", .mode = 0400}, + .read = symbol_map_read +}; There's no real need to rename the structure, right? Why not just keep the

Re: [PATCH v2] powerpc/powernv: Restrict OPAL symbol map to only be readable by root

2019-05-03 Thread Greg KH
On Fri, May 03, 2019 at 06:27:18PM +1000, Andrew Donnellan wrote: > On 3/5/19 5:59 pm, Greg KH wrote:>> -static BIN_ATTR_RO(symbol_map, 0); > > > +static struct bin_attribute symbol_map_attr = { > > > + .attr = {.name = "symbol_map", .mode = 0400}, > > > + .read = symbol_map_read > > > +}; > > >

[PATCH v3] dpaa_eth: fix SG frame cleanup

2019-05-03 Thread laurentiu . tudor
From: Laurentiu Tudor Fix issue with the entry indexing in the sg frame cleanup code being off-by-1. This problem showed up when doing some basic iperf tests and manifested in traffic coming to a halt. Signed-off-by: Laurentiu Tudor Acked-by: Madalin Bucur Cc: --- v3: - added cc:stable tag

Re: [PATCH] Documentation: Add ARM64 to kernel-parameters.rst

2019-05-03 Thread Will Deacon
On Fri, May 03, 2019 at 06:37:56AM -0600, Jonathan Corbet wrote: > On Fri, 12 Apr 2019 22:56:21 -0500 > Josh Poimboeuf wrote: > > > Add ARM64 to the legend of architectures. It's already used in several > > places in kernel-parameters.txt. > > > > Suggested-by: Randy Dunlap > > Signed-off-by:

Re: [PATCH] Documentation: Add ARM64 to kernel-parameters.rst

2019-05-03 Thread Jonathan Corbet
On Fri, 3 May 2019 13:39:40 +0100 Will Deacon wrote: > > It looks like nobody has picked this up...so I've applied it. > > It's queued and tagged in the arm64 tree, which should also be in next! Just looked again, I still don't see it there. Josh's mitigations= change is there, but not this

[PATCH] soc: fsl: qe: gpio: Fix an error code in qe_pin_request()

2019-05-03 Thread Dan Carpenter
There was a missing error code in this path. It meant that we returned ERR_PTR(0) which is NULL and would result in a NULL dereference in the caller. Fixes: 1a2d397a6eb5 ("gpio/powerpc: Eliminate duplication of of_get_named_gpio_flags()") Signed-off-by: Dan Carpenter ---

Re: [PATCH] powerpc/powernv/ioda2: Add __printf format/argument verification

2019-05-03 Thread Michael Ellerman
Joe Perches writes: > On Fri, 2019-05-03 at 16:59 +1000, Michael Ellerman wrote: >> On Thu, 2017-03-30 at 10:19:25 UTC, Joe Perches wrote: >> > Fix fallout too. >> > >> > Signed-off-by: Joe Perches >> >> Applied to powerpc next, thanks. >> >>

Re: [PATCH] Documentation: Add ARM64 to kernel-parameters.rst

2019-05-03 Thread Will Deacon
On Fri, May 03, 2019 at 06:47:19AM -0600, Jonathan Corbet wrote: > On Fri, 3 May 2019 13:39:40 +0100 > Will Deacon wrote: > > > > It looks like nobody has picked this up...so I've applied it. > > > > It's queued and tagged in the arm64 tree, which should also be in next! > > Just looked

Re: [RESEND PATCH v3 05/11] mtd: rawnand: vf610_nfc: add initializer to avoid -Wmaybe-uninitialized

2019-05-03 Thread Miquel Raynal
Hi Masahiro, Masahiro Yamada wrote on Fri, 3 May 2019 19:36:35 +0900: > Hi Miquel, > > On Thu, May 2, 2019 at 11:14 PM Miquel Raynal > wrote: > > > > Hi Masahiro, > > > > Masahiro Yamada wrote on Tue, 23 Apr > > 2019 12:49:53 +0900: > > > > > This prepares to move CONFIG_OPTIMIZE_INLINING

Re: [PATCH] Documentation: Add ARM64 to kernel-parameters.rst

2019-05-03 Thread Jonathan Corbet
On Fri, 12 Apr 2019 22:56:21 -0500 Josh Poimboeuf wrote: > Add ARM64 to the legend of architectures. It's already used in several > places in kernel-parameters.txt. > > Suggested-by: Randy Dunlap > Signed-off-by: Josh Poimboeuf It looks like nobody has picked this up...so I've applied it.

Re: [PATCH 5/5] asm-generic: remove ptrace.h

2019-05-03 Thread Arnd Bergmann
On Wed, May 1, 2019 at 1:40 PM Christoph Hellwig wrote: > > No one is using this helper anymore. > > Signed-off-by: Christoph Hellwig Acked-by: Arnd Bergmann

[PATCH] net: ucc_geth - fix Oops when changing number of buffers in the ring

2019-05-03 Thread Christophe Leroy
When changing the number of buffers in the RX ring while the interface is running, the following Oops is encountered due to the new number of buffers being taken into account immediately while their allocation is done when opening the device only. [ 69.882706] Unable to handle kernel paging

Re: Linux 5.1-rc5

2019-05-03 Thread Michael Ellerman
Greg KH writes: > On Mon, Apr 15, 2019 at 09:17:10AM -0700, Linus Torvalds wrote: >> On Sun, Apr 14, 2019 at 10:19 PM Christoph Hellwig >> wrote: >> > >> > Can we please have the page refcount overflow fixes out on the list >> > for review, even if it is after the fact? >> >> They were

Re: [PATCH 05/15] csky: switch to generic version of pte allocation

2019-05-03 Thread Guo Ren
Hi Mike, Acked-by: Guo Ren On Thu, May 02, 2019 at 06:28:32PM +0300, Mike Rapoport wrote: > The csky implementation pte_alloc_one(), pte_free_kernel() and pte_free() > is identical to the generic except of lack of __GFP_ACCOUNT for the user > PTEs allocation. > > Switch csky to use generic

Re: [PATCH 05/15] csky: switch to generic version of pte allocation

2019-05-03 Thread Guo Ren
On Sat, May 04, 2019 at 12:03:48AM +0800, Guo Ren wrote: > Hi Mike, > > Acked-by: Guo Ren > > On Thu, May 02, 2019 at 06:28:32PM +0300, Mike Rapoport wrote: > > The csky implementation pte_alloc_one(), pte_free_kernel() and pte_free() > > is identical to the generic except of lack of

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-05-03 Thread Segher Boessenkool
On Wed, May 01, 2019 at 01:42:21PM +1000, Alexey Kardashevskiy wrote: > At the moment, on 256CPU + 256 PCI devices guest, it takes the guest > about 8.5sec to fetch the entire device tree via the client interface > as the DT is traversed twice - for strings blob and for struct blob. > Also,

[PATCH v5] ASoC: fsl_esai: Add pm runtime function

2019-05-03 Thread Nicolin Chen
From: "S.j. Wang" Add pm runtime support and move clock handling there. Close the clocks at suspend to reduce the power consumption. fsl_esai_suspend is replaced by pm_runtime_force_suspend. fsl_esai_resume is replaced by pm_runtime_force_resume. Signed-off-by: Shengjiu Wang Signed-off-by:

Re: [PATCH] soc: fsl: qe: gpio: Fix an error code in qe_pin_request()

2019-05-03 Thread Dan Carpenter
On Fri, May 03, 2019 at 01:45:07PM -0500, Li Yang wrote: > On Fri, May 3, 2019 at 8:19 AM Dan Carpenter wrote: > > > > There was a missing error code in this path. It meant that we returned > > ERR_PTR(0) which is NULL and would result in a NULL dereference in the > > caller. > > Thanks Dan.

Re: [EXT] Re: [PATCH V4] ASoC: fsl_esai: Add pm runtime function

2019-05-03 Thread Nicolin Chen
Hi Mark, On Fri, May 03, 2019 at 01:27:31PM +0900, Mark Brown wrote: > On Thu, May 02, 2019 at 09:13:58AM +, S.j. Wang wrote: > > > I am checking, but I don't know why this patch failed in your side. I > > Tried to apply this patch on for-5.1, for 5.2, for-linus and for-next, > > all are

Re: [RESEND PATCH v3 09/11] powerpc/mm/radix: mark __radix__flush_tlb_range_psize() as __always_inline

2019-05-03 Thread Masahiro Yamada
Hi Christophe, On Tue, Apr 30, 2019 at 12:36 AM Christophe Leroy wrote: > > > > Le 23/04/2019 à 05:49, Masahiro Yamada a écrit : > > This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common > > place. We need to eliminate potential issues beforehand. > > How did you identify the

Re: [PATCH] powerpc/32: Remove memory clobber asm constraint on dcbX() functions

2019-05-03 Thread Christophe Leroy
Segher, A while ago I proposed the following patch, and didn't get any comment back on it. Do you have any opinion on it ? Is it good and worth it ? Thanks Christophe Le 09/01/2018 à 07:57, Christophe Leroy a écrit : Instead of just telling GCC that dcbz(), dcbi(), dcbf() and dcbst()

Re: [PATCH] powerpc/32: Remove memory clobber asm constraint on dcbX() functions

2019-05-03 Thread Christophe Leroy
Segher, A while ago I proposed the following patch, and didn't get any comment back on it. Do you have any opinion on it ? Is it good and worth it ? Thanks Christophe Le 09/01/2018 à 07:57, Christophe Leroy a écrit : Instead of just telling GCC that dcbz(), dcbi(), dcbf() and dcbst()

[PATCH v4 05/10] net: ethernet: support of_get_mac_address new ERR_PTR error

2019-05-03 Thread Petr Štetiar
There was NVMEM support added to of_get_mac_address, so it could now return ERR_PTR encoded error values, so we need to adjust all current users of of_get_mac_address to this new fact. While at it, remove superfluous is_valid_ether_addr as the MAC address returned from of_get_mac_address is

[PATCH v4 10/10] powerpc: tsi108: support of_get_mac_address new ERR_PTR error

2019-05-03 Thread Petr Štetiar
There was NVMEM support added to of_get_mac_address, so it could now return ERR_PTR encoded error values, so we need to adjust all current users of of_get_mac_address to this new fact. Signed-off-by: Petr Štetiar --- Changes since v3: * IS_ERR_OR_NULL -> IS_ERR

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-05-03 Thread Segher Boessenkool
On Fri, May 03, 2019 at 10:10:57AM +1000, Stewart Smith wrote: > David Gibson writes: > > On Wed, May 01, 2019 at 01:42:21PM +1000, Alexey Kardashevskiy wrote: > >> At the moment, on 256CPU + 256 PCI devices guest, it takes the guest > >> about 8.5sec to fetch the entire device tree via the

Re: [PATCH] powerpc/32: Remove memory clobber asm constraint on dcbX() functions

2019-05-03 Thread Segher Boessenkool
Hi Christophe, On Fri, May 03, 2019 at 04:14:13PM +0200, Christophe Leroy wrote: > A while ago I proposed the following patch, and didn't get any comment > back on it. I didn't see it. Maybe because of holiday :-) > Do you have any opinion on it ? Is it good and worth it ? > Le 09/01/2018 à

Re: [PATCH] soc: fsl: qe: gpio: Fix an error code in qe_pin_request()

2019-05-03 Thread Li Yang
On Fri, May 3, 2019 at 8:19 AM Dan Carpenter wrote: > > There was a missing error code in this path. It meant that we returned > ERR_PTR(0) which is NULL and would result in a NULL dereference in the > caller. Thanks Dan. An early version of this patch has been included in a pending pull

[PATCH] mm: add account_locked_vm utility function

2019-05-03 Thread Daniel Jordan
locked_vm accounting is done roughly the same way in five places, so unify them in a helper. Standardize the debug prints, which vary slightly. Error codes stay the same, so user-visible behavior does too. Signed-off-by: Daniel Jordan Cc: Alan Tull Cc: Alexey Kardashevskiy Cc: Alex