Re: [PATCH 2/5] powerpc/lib: Initialize a temporary mm for code patching

2020-06-03 Thread Christophe Leroy
Le 03/06/2020 à 07:19, Christopher M. Riedl a écrit : When code patching a STRICT_KERNEL_RWX kernel the page containing the address to be patched is temporarily mapped with permissive memory protections. Currently, a per-cpu vmalloc patch area is used for this purpose. While the patch area is

Re: [PATCH 3/5] powerpc/lib: Use a temporary mm for code patching

2020-06-03 Thread Christophe Leroy
Le 03/06/2020 à 07:19, Christopher M. Riedl a écrit : Currently, code patching a STRICT_KERNEL_RWX exposes the temporary mappings to other CPUs. These mappings should be kept local to the CPU doing the patching. Use the pre-initialized temporary mm and patching address for this purpose. Also a

Re: [PATCH 4/5] powerpc/lib: Add LKDTM accessor for patching addr

2020-06-03 Thread Christophe Leroy
Le 03/06/2020 à 07:19, Christopher M. Riedl a écrit : When live patching a STRICT_RWX kernel, a mapping is installed at a "patching address" with temporary write permissions. Provide a LKDTM-only accessor function for this address in preparation for a LKDTM test which attempts to "hijack" this

Re: [PATCH 5/5] powerpc: Add LKDTM test to hijack a patch mapping

2020-06-03 Thread Christophe Leroy
Le 03/06/2020 à 07:19, Christopher M. Riedl a écrit : When live patching with STRICT_KERNEL_RWX, the CPU doing the patching must use a temporary mapping which allows for writing to kernel text. During the entire window of time when this temporary mapping is in use, another CPU could write to t

[PATCH v4 1/4] riscv: Move kernel mapping to vmalloc zone

2020-06-03 Thread Alexandre Ghiti
This is a preparatory patch for relocatable kernel. The kernel used to be linked at PAGE_OFFSET address and used to be loaded physically at the beginning of the main memory. Therefore, we could use the linear mapping for the kernel mapping. But the relocated kernel base address will be different

[PATCH v4 2/4] riscv: Introduce CONFIG_RELOCATABLE

2020-06-03 Thread Alexandre Ghiti
This config allows to compile the kernel as PIE and to relocate it at any virtual address at runtime: this paves the way to KASLR and to 4-level page table folding at runtime. Runtime relocation is possible since relocation metadata are embedded into the kernel. Note that relocating at runtime int

[PATCH v4 3/4] powerpc: Move script to check relocations at compile time in scripts/

2020-06-03 Thread Alexandre Ghiti
Relocating kernel at runtime is done very early in the boot process, so it is not convenient to check for relocations there and react in case a relocation was not expected. Powerpc architecture has a script that allows to check at compile time for such unexpected relocations: extract the common lo

[PATCH v4 4/4] riscv: Check relocations at compile time

2020-06-03 Thread Alexandre Ghiti
Relocating kernel at runtime is done very early in the boot process, so it is not convenient to check for relocations there and react in case a relocation was not expected. There exists a script in scripts/ that extracts the relocations from vmlinux that is then used at postlink to check the reloc

[PATCH v4 0/4] vmalloc kernel mapping and relocatable kernel

2020-06-03 Thread Alexandre Ghiti
This patchset originally implemented relocatable kernel support but now also moves the kernel mapping into the vmalloc zone. The first patch explains why we need to move the k

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-06-03 Thread Michal Simek
Hi Michael, On 26. 05. 20 15:44, Michael Ellerman wrote: > Michal Simek writes: >> Hi Michael, >> >> On 01. 04. 20 13:30, Michal Simek wrote: >>> On 01. 04. 20 12:38, Takashi Iwai wrote: On Wed, 01 Apr 2020 12:35:16 +0200, Michael Ellerman wrote: > > Michal Simek writes: >>

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-06-03 Thread Christophe Leroy
Hi, Le 03/06/2020 à 10:10, Michal Simek a écrit : Hi Michael, On 26. 05. 20 15:44, Michael Ellerman wrote: Michal Simek writes: Hi Michael, On 01. 04. 20 13:30, Michal Simek wrote: On 01. 04. 20 12:38, Takashi Iwai wrote: On Wed, 01 Apr 2020 12:35:16 +0200, Michael Ellerman wrote: Micha

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-06-03 Thread Michal Simek
On 03. 06. 20 10:13, Christophe Leroy wrote: > Hi, > > Le 03/06/2020 à 10:10, Michal Simek a écrit : >> Hi Michael, >> >> On 26. 05. 20 15:44, Michael Ellerman wrote: >>> Michal Simek writes: Hi Michael, On 01. 04. 20 13:30, Michal Simek wrote: > On 01. 04. 20 12:38, Takashi Iw

Re: [RFC PATCH 1/2] libnvdimm: Add prctl control for disabling synchronous fault support.

2020-06-03 Thread Jan Kara
On Tue 02-06-20 17:59:08, Williams, Dan J wrote: > [ forgive formatting, a series of unfortunate events has me using Outlook for > the moment ] > > > From: Jan Kara > > > > > These flags are device properties that affect the kernel and > > > > > userspace's handling of persistence. > > > > > > >

linux-next: manual merge of the akpm-current tree with the powerpc tree

2020-06-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the akpm-current tree got a conflict in: arch/powerpc/mm/ptdump/ptdump.c between commit: 6b789a26d7da ("powerpc/ptdump: Handle hugepd at PGD level") from the powerpc tree and patch: "powerpc: add support for folded p4d page tables" from the akpm-curr

Re: [RFC PATCH 1/2] libnvdimm: Add prctl control for disabling synchronous fault support.

2020-06-03 Thread Aneesh Kumar K.V
On 6/3/20 1:56 PM, Jan Kara wrote: On Tue 02-06-20 17:59:08, Williams, Dan J wrote: [ forgive formatting, a series of unfortunate events has me using Outlook for the moment ] From: Jan Kara These flags are device properties that affect the kernel and userspace's handling of persistence.

Re: [PATCH v8 0/8] powerpc: switch VDSO to C implementation

2020-06-03 Thread Michael Ellerman
Christophe Leroy writes: > Hi Michael, > > Le 28/04/2020 à 15:16, Christophe Leroy a écrit : >> This is the seventh version of a series to switch powerpc VDSO to >> generic C implementation. >> >> Main changes since v7 are: >> - Added gettime64 on PPC32 >> >> This series applies on today's power

linux-next: fix ups for clashes between akpm and powerpc trees

2020-06-03 Thread Stephen Rothwell
Hi all, Some things turned up in the powerpc tree today that required some changes to patches in the akpm tree and also the following fixup patch provided (mostly) by Michael. I have applied this as a single patch today, but parts of it should probably go in some other patches. From: Stephen Roth

Re: [PATCH 1/2] powerpc/pseries: remove cede offline state for CPUs

2020-06-03 Thread Gautham R Shenoy
Hello Nathan, On Mon, Jun 01, 2020 at 11:31:39PM -0500, Nathan Lynch wrote: > This effectively reverts commit 3aa565f53c39 ("powerpc/pseries: Add > hooks to put the CPU into an appropriate offline state"), which added > an offline mode for CPUs which uses the H_CEDE hcall instead of the > architec

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-06-03 Thread Michael Ellerman
Christophe Leroy writes: > Hi, > > Le 03/06/2020 à 10:10, Michal Simek a écrit : >> Hi Michael, >> >> On 26. 05. 20 15:44, Michael Ellerman wrote: >>> Michal Simek writes: Hi Michael, On 01. 04. 20 13:30, Michal Simek wrote: > On 01. 04. 20 12:38, Takashi Iwai wrote: >> On

Re: [PATCH] cxl: Fix kobject memleak

2020-06-03 Thread Andrew Donnellan
On 2/6/20 10:07 pm, Wang Hai wrote: Currently the error return path from kobject_init_and_add() is not followed by a call to kobject_put() - which means we are leaking the kobject. Fix it by adding a call to kobject_put() in the error path of kobject_init_and_add(). Fixes: b087e6190ddc ("cxl: E

Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-06-03 Thread Michael Ellerman
Dan Carpenter writes: > On Tue, Jun 02, 2020 at 09:23:57PM +1000, Michael Ellerman wrote: >> Markus Elfring writes: >> Please just remove the message instead, it's a tiny allocation that's >> unlikely to ever fail, and the caller will print an error anyway. >> >>> >> >>> How do you thin

Re: [PATCH] cxl: Fix kobject memleak

2020-06-03 Thread wanghai (M)
在 2020/6/3 19:33, Andrew Donnellan 写道: On 2/6/20 10:07 pm, Wang Hai wrote: Currently the error return path from kobject_init_and_add() is not followed by a call to kobject_put() - which means we are leaking the kobject. Fix it by adding a call to kobject_put() in the error path of kobject_ini

[PATCH] powerpc/boot: Add LZMA and LZO __decompress in cuboot to avoid build failure

2020-06-03 Thread Christophe Leroy
The commits identified below added LZMA and LZO compression for the uImage. However it seems that some targets select both uImage and other image type like cuImage. In that case, the selected compression type applies to both uImage and cuImage, and leads to build failure due to missing __decompress

Re: [mainline][Oops][bisected 2ba3e6 ] 5.7.0 boot fails with kernel panic on powerpc

2020-06-03 Thread Joerg Roedel
hi Abdul, On Wed, Jun 03, 2020 at 04:20:57PM +0530, Abdul Haleem wrote: > Greeting's > > Today's mainline kernel panics when booting on my powerpc lpar Thanks for the report, I am looking into it with my limited powerpc knowledge. But I have an idea and will send you something to test later toda

Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-06-03 Thread Dan Carpenter
On Wed, Jun 03, 2020 at 09:37:18PM +1000, Michael Ellerman wrote: > Dan Carpenter writes: > > On Tue, Jun 02, 2020 at 09:23:57PM +1000, Michael Ellerman wrote: > >> Markus Elfring writes: > >> Please just remove the message instead, it's a tiny allocation that's > >> unlikely to ever fa

Re: [PATCH v1 4/4] KVM: PPC: Book3S HV: migrate hot plugged memory

2020-06-03 Thread Ram Pai
On Tue, Jun 02, 2020 at 10:31:32AM +0200, Laurent Dufour wrote: > Le 31/05/2020 à 04:27, Ram Pai a écrit : > >From: Laurent Dufour > > > >When a memory slot is hot plugged to a SVM, GFNs associated with that > >memory slot automatically default to secure GFN. Hence migrate the > >PFNs associated w

Re: [mainline][Oops][bisected 2ba3e6 ] 5.7.0 boot fails with kernel panic on powerpc

2020-06-03 Thread Joerg Roedel
On Wed, Jun 03, 2020 at 04:20:57PM +0530, Abdul Haleem wrote: > @Joerg, Could you please have a look? Can you please try the attached patch? diff --git a/include/asm-generic/5level-fixup.h b/include/asm-generic/5level-fixup.h index 58046ddc08d0..afbab31fbd7e 100644 --- a/include/asm-generic/5lev

Re: [PATCH 10/10] dt-bindings: mtd: fsl-upm-nand: Deprecate chip-delay and fsl,upm-wait-flags

2020-06-03 Thread Boris Brezillon
And I forgot to Cc the DT maintainer/ML on this one :-/ On Wed, 3 Jun 2020 15:49:22 +0200 Boris Brezillon wrote: > Those properties are no longer parsed by the driver which is being passed > those information by the core now. Let's deprecate them. > > Signed-off-by: Boris Brezillon > --- > D

Re: [PATCH 03/10] mtd: rawnand: fsl_upm: Allocate the fsl_upm_nand object using devm_kzalloc()

2020-06-03 Thread Miquel Raynal
Boris Brezillon wrote on Wed, 3 Jun 2020 15:49:15 +0200: > This simplifies the init error patch and remove function. path? Otherwise: Reviewed-by: Miquel Raynal > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/raw/fsl_upm.c | 18 ++---

Re: [PATCH 04/10] mtd: rawnand: fsl_upm: Use devm_kasprintf() to allocate the MTD name

2020-06-03 Thread Miquel Raynal
Boris Brezillon wrote on Wed, 3 Jun 2020 15:49:16 +0200: > This simplifies the init() error path and the remove() handler. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/raw/fsl_upm.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/

[PATCH 05/10] mtd: rawnand: fsl_upm: Use platform_get_resource() + devm_ioremap_resource()

2020-06-03 Thread Boris Brezillon
Replace the of_address_to_resource() + devm_ioremap() calls by platform_get_resource() + devm_ioremap_resource() ones which allows us to get rid of one error message since devm_ioremap_resource() already takes care of that. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/fsl_upm.c | 23 +

[PATCH 06/10] mtd: rawnand: fsl_upm: Use gpio descriptors

2020-06-03 Thread Boris Brezillon
The integer-based GPIO ids are now deprecated in favor of the GPIO desc API. The PPC platforms have already been converted to GPIOLIB, so let's use gpio descs in the NAND driver too. While at it, we use devm_gpiod_get_index_optional() so we can get rid of the manual gpio desc release done in the i

[PATCH 02/10] mtd: rawnand: fsl_upm: Get rid of the unused fsl_upm_nand.parts field

2020-06-03 Thread Boris Brezillon
fsl_upm_nand.parts is unused, let's get rid of it. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/fsl_upm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c index 76d1032cd35e..6eba2f4a2f5a 100644 --- a/drivers/mtd/nand/r

[PATCH 00/10] mtd: rawnand: fsl_upm: Convert to exec_op() (and more)

2020-06-03 Thread Boris Brezillon
Hello, A bit of context to explain the motivation behind those conversions I've been sending for the last few weeks. The raw NAND subsystem carries a lot of history which makes any rework not only painful, but also subject to regressions which we only detect when someone dares to update its kernel

[PATCH 09/10] mtd: rawnand: fsl_upm: Get rid of the legacy interface implementation

2020-06-03 Thread Boris Brezillon
Now that the driver implements exec_op(), we can get rid of the legacy interface implementation. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/fsl_upm.c | 133 - 1 file changed, 133 deletions(-) diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/

[PATCH 01/10] mtd: rawnand: fsl_upm: Remove unused mtd var

2020-06-03 Thread Boris Brezillon
The mtd var in fun_wait_rnb() is now unused, let's get rid of it and fix the warning resulting from this unused var. Fixes: 50a487e7719c ("mtd: rawnand: Pass a nand_chip object to chip->dev_ready()") Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/fsl_upm.c | 1 - 1 file changed, 1 dele

[PATCH 07/10] mtd: rawnand: fsl_upm: Inherit from nand_controller

2020-06-03 Thread Boris Brezillon
Explicitly inherit from nand_controller instead of relying on the nand_chip.legacy.dummy_controller field. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/fsl_upm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c inde

[PATCH 08/10] mtd: rawnand: fsl_upm: Implement exec_op()

2020-06-03 Thread Boris Brezillon
Implement exec_op() so we can get rid of the legacy interface implementation. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/fsl_upm.c | 86 ++ 1 file changed, 86 insertions(+) diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c

[PATCH 03/10] mtd: rawnand: fsl_upm: Allocate the fsl_upm_nand object using devm_kzalloc()

2020-06-03 Thread Boris Brezillon
This simplifies the init error patch and remove function. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/fsl_upm.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c index 6eba2f4a2f5a..

[PATCH 04/10] mtd: rawnand: fsl_upm: Use devm_kasprintf() to allocate the MTD name

2020-06-03 Thread Boris Brezillon
This simplifies the init() error path and the remove() handler. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/fsl_upm.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c index 9cf79c62ef22..a3e3a9

[PATCH 10/10] dt-bindings: mtd: fsl-upm-nand: Deprecate chip-delay and fsl, upm-wait-flags

2020-06-03 Thread Boris Brezillon
Those properties are no longer parsed by the driver which is being passed those information by the core now. Let's deprecate them. Signed-off-by: Boris Brezillon --- Documentation/devicetree/bindings/mtd/fsl-upm-nand.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --gi

Re: [PATCH 05/10] mtd: rawnand: fsl_upm: Use platform_get_resource() + devm_ioremap_resource()

2020-06-03 Thread Miquel Raynal
Boris Brezillon wrote on Wed, 3 Jun 2020 15:49:17 +0200: > Replace the of_address_to_resource() + devm_ioremap() calls by > platform_get_resource() + devm_ioremap_resource() ones which allows us > to get rid of one error message since devm_ioremap_resource() already > takes care of that. > >

Re: [PATCH 01/10] mtd: rawnand: fsl_upm: Remove unused mtd var

2020-06-03 Thread Miquel Raynal
Boris Brezillon wrote on Wed, 3 Jun 2020 15:49:13 +0200: > The mtd var in fun_wait_rnb() is now unused, let's get rid of it and > fix the warning resulting from this unused var. > > Fixes: 50a487e7719c ("mtd: rawnand: Pass a nand_chip object to > chip->dev_ready()") > Signed-off-by: Boris Br

Re: [PATCH 02/10] mtd: rawnand: fsl_upm: Get rid of the unused fsl_upm_nand.parts field

2020-06-03 Thread Miquel Raynal
Boris Brezillon wrote on Wed, 3 Jun 2020 15:49:14 +0200: > fsl_upm_nand.parts is unused, let's get rid of it. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/raw/fsl_upm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/

Re: [PATCH 06/10] mtd: rawnand: fsl_upm: Use gpio descriptors

2020-06-03 Thread Miquel Raynal
Boris Brezillon wrote on Wed, 3 Jun 2020 15:49:18 +0200: > The integer-based GPIO ids are now deprecated in favor of the GPIO desc > API. The PPC platforms have already been converted to GPIOLIB, so let's > use gpio descs in the NAND driver too. > > While at it, we use devm_gpiod_get_index_op

Re: [PATCH 04/10] mtd: rawnand: fsl_upm: Use devm_kasprintf() to allocate the MTD name

2020-06-03 Thread Boris Brezillon
On Wed, 3 Jun 2020 15:55:31 +0200 Miquel Raynal wrote: > Boris Brezillon wrote on Wed, 3 Jun > 2020 15:49:16 +0200: > > > This simplifies the init() error path and the remove() handler. > > > > Signed-off-by: Boris Brezillon > > --- > > drivers/mtd/nand/raw/fsl_upm.c | 8 +++- > > 1 fil

Re: [PATCH 05/10] mtd: rawnand: fsl_upm: Use platform_get_resource() + devm_ioremap_resource()

2020-06-03 Thread Boris Brezillon
On Wed, 3 Jun 2020 15:58:02 +0200 Miquel Raynal wrote: > Boris Brezillon wrote on Wed, 3 Jun > 2020 15:49:17 +0200: > > > Replace the of_address_to_resource() + devm_ioremap() calls by > > platform_get_resource() + devm_ioremap_resource() ones which allows us > > to get rid of one error messag

Re: [PATCH 07/10] mtd: rawnand: fsl_upm: Inherit from nand_controller

2020-06-03 Thread Miquel Raynal
Boris Brezillon wrote on Wed, 3 Jun 2020 15:49:19 +0200: > Explicitly inherit from nand_controller instead of relying on the > nand_chip.legacy.dummy_controller field. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/raw/fsl_upm.c | 3 +++ > 1 file changed, 3 insertions(+) > > d

Re: [PATCH 08/10] mtd: rawnand: fsl_upm: Implement exec_op()

2020-06-03 Thread Miquel Raynal
Boris Brezillon wrote on Wed, 3 Jun 2020 15:49:20 +0200: > Implement exec_op() so we can get rid of the legacy interface > implementation. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/raw/fsl_upm.c | 86 ++ > 1 file changed, 86 insertions(+) >

Re: [mainline][Oops][bisected 2ba3e6 ] 5.7.0 boot fails with kernel panic on powerpc

2020-06-03 Thread Satheesh Rajendran
On Wed, Jun 03, 2020 at 03:32:57PM +0200, Joerg Roedel wrote: > On Wed, Jun 03, 2020 at 04:20:57PM +0530, Abdul Haleem wrote: > > @Joerg, Could you please have a look? > > Can you please try the attached patch? Hi Joerg, I did hit the similar boot failue on a Power9 baremetal box(mentioned in No

Re: [PATCH kernel] powerpc/perf: Stop crashing with generic_compat_pmu

2020-06-03 Thread Madhavan Srinivasan
On 6/2/20 8:26 AM, Alexey Kardashevskiy wrote: The bhrb_filter_map ("The Branch History Rolling Buffer") callback is only defined in raw CPUs' power_pmu structs. The "architected" CPUs use generic_compat_pmu which does not have this callback and crashed occur. This add a NULL pointer chec

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm, uapi: Add support for PAPR nvdimm specific methods

2020-06-03 Thread Vaibhav Jain
Hi Ira, Thanks for reviewing this patch. My responses below: Ira Weiny writes: > On Tue, Jun 02, 2020 at 03:44:37PM +0530, Vaibhav Jain wrote: >> Introduce support for PAPR NVDIMM Specific Methods (PDSM) in papr_scm >> module and add the command family NVDIMM_FAMILY_PAPR to the white list >> of

Re: [RESEND PATCH v9 5/5] powerpc/papr_scm: Implement support for PAPR_PDSM_HEALTH

2020-06-03 Thread Vaibhav Jain
Hi Ira, Thanks for reviewing this patch. My responses below: Ira Weiny writes: > On Tue, Jun 02, 2020 at 03:44:38PM +0530, Vaibhav Jain wrote: >> This patch implements support for PDSM request 'PAPR_PDSM_HEALTH' >> that returns a newly introduced 'struct nd_papr_pdsm_health' instance >> contain

Re: [PATCH v4 08/14] powerpc: add support for folded p4d page tables

2020-06-03 Thread Andrew Morton
On Tue, 14 Apr 2020 18:34:49 +0300 Mike Rapoport wrote: > Implement primitives necessary for the 4th level folding, add walks of p4d > level where appropriate and replace 5level-fixup.h with pgtable-nop4d.h. A bunch of new material just landed in linux-next/powerpc. The timing is awkward! I tr

[powerpc:topic/ppc-kvm] BUILD SUCCESS bf8036a4098d1548cdccf9ed5c523ef4e83e3c68

2020-06-03 Thread kernel test robot
randconfig-a005-20200601 i386 randconfig-a003-20200601 i386 randconfig-a004-20200601 i386 randconfig-a001-20200603 i386 randconfig-a006-20200603 i386 randconfig-a002-20200603 i386 randconfig-a005-20200603

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm, uapi: Add support for PAPR nvdimm specific methods

2020-06-03 Thread Vaibhav Jain
Hi Ira, Thanks again for reviewing this patch. My Response below: Ira Weiny writes: > On Tue, Jun 02, 2020 at 01:51:49PM -0700, 'Ira Weiny' wrote: >> On Tue, Jun 02, 2020 at 03:44:37PM +0530, Vaibhav Jain wrote: > > ... > >> > + >> > +/* >> > + * PDSM Envelope: >> > + * >> > + * The ioctl ND_CM

[PATCH] ibmvscsi: don't send host info in adapter info MAD after LPM

2020-06-03 Thread Tyrel Datwyler
The adatper info MAD is used to send the client info and receive the host info as a response. A peristent buffer is used and as such the client info is overwritten after the response. During the course of a normal adapter reset the client info is refreshed in the buffer in preparation for sending t

Re: Re: [RESEND PATCH v5 5/5] Documentation/vmcoreinfo: Add documentation for 'TCR_EL1.T1SZ'

2020-06-03 Thread Bhupesh Sharma
Hello Scott, On Thu, Jun 4, 2020 at 12:17 AM Scott Branden wrote: > > Hi Bhupesh, > > Would be great to get this patch series upstreamed? > > On 2019-12-25 10:49 a.m., Bhupesh Sharma wrote: > > Hi James, > > > > On 12/12/2019 04:02 PM, James Morse wrote: > >> Hi Bhupesh, > > > > I am sorry this r

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-06-03 Thread Andrew Morton
On Thu, 21 May 2020 10:42:50 -0700 Ira Weiny wrote: > > > > > > Actually it occurs to me that the patch consolidating kmap_prot is odd for > > > sparc 32 bit... > > > > > > Its a long shot but could you try reverting this patch? > > > > > > 4ea7d2419e3f kmap: consolidate kmap_prot definitions

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-06-03 Thread Ira Weiny
On Wed, Jun 03, 2020 at 01:57:36PM -0700, Andrew Morton wrote: > On Thu, 21 May 2020 10:42:50 -0700 Ira Weiny wrote: > > > > > > > > > Actually it occurs to me that the patch consolidating kmap_prot is odd > > > > for > > > > sparc 32 bit... > > > > > > > > Its a long shot but could you try re

[PATCH] net: ethernet: freescale: remove unneeded include for ucc_geth

2020-06-03 Thread Valentin Longchamp
net/sch_generic.h does not need to be included, remove it. Signed-off-by: Valentin Longchamp --- drivers/net/ethernet/freescale/ucc_geth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index 552e7554a9f8.

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-03 Thread Ira Weiny
On Wed, Jun 03, 2020 at 11:41:42PM +0530, Vaibhav Jain wrote: > Hi Ira, > > Thanks for reviewing this patch. My responses below: > > Ira Weiny writes: > ... > >> + * > >> + * Payload Version: > >> + * > >> + * A 'payload_version' field is present in PDSM header that indicates a > >> specific

Re: Re: [RESEND PATCH v5 5/5] Documentation/vmcoreinfo: Add documentation for 'TCR_EL1.T1SZ'

2020-06-03 Thread Scott Branden
Hi Bhupesh, Would be great to get this patch series upstreamed? On 2019-12-25 10:49 a.m., Bhupesh Sharma wrote: Hi James, On 12/12/2019 04:02 PM, James Morse wrote: Hi Bhupesh, I am sorry this review mail skipped my attention due to holidays and focus on other urgent issues. On 29/11/20

Re: [PATCH] pwm: Add missing "CONFIG_" prefix

2020-06-03 Thread Joe Perches
On Wed, 2020-06-03 at 15:40 -0700, Kees Cook wrote: > The IS_ENABLED() use was missing the CONFIG_ prefix which would have > lead to skipping this code. > > Fixes: 3ad1f3a33286 ("pwm: Implement some checks for lowlevel drivers") > Signed-off-by: Kees Cook > --- > drivers/pwm/core.c | 2 +- > 1 f

Re: [PATCH v1 3/4] KVM: PPC: Book3S HV: migrate remaining normal-GFNs to secure-GFNs in H_SVM_INIT_DONE

2020-06-03 Thread Ram Pai
On Tue, Jun 02, 2020 at 03:36:39PM +0530, Bharata B Rao wrote: > On Mon, Jun 01, 2020 at 12:05:35PM -0700, Ram Pai wrote: > > On Mon, Jun 01, 2020 at 05:25:18PM +0530, Bharata B Rao wrote: > > > On Sat, May 30, 2020 at 07:27:50PM -0700, Ram Pai wrote: > > > > H_SVM_INIT_DONE incorrectly assumes tha

Re: [RESEND PATCH v9 5/5] powerpc/papr_scm: Implement support for PAPR_PDSM_HEALTH

2020-06-03 Thread Ira Weiny
On Thu, Jun 04, 2020 at 12:34:04AM +0530, Vaibhav Jain wrote: > Hi Ira, > > Thanks for reviewing this patch. My responses below: > > Ira Weiny writes: > > > On Tue, Jun 02, 2020 at 03:44:38PM +0530, Vaibhav Jain wrote: > >> This patch implements support for PDSM request 'PAPR_PDSM_HEALTH' > >>

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-03 Thread Ira Weiny
On Thu, Jun 04, 2020 at 01:58:00AM +0530, Vaibhav Jain wrote: > Hi Ira, > > Thanks again for reviewing this patch. My Response below: > > Ira Weiny writes: > > > On Tue, Jun 02, 2020 at 01:51:49PM -0700, 'Ira Weiny' wrote: > >> On Tue, Jun 02, 2020 at 03:44:37PM +0530, Vaibhav Jain wrote: > > >

Re: [PATCH] pwm: Add missing "CONFIG_" prefix

2020-06-03 Thread Kees Cook
On Wed, Jun 03, 2020 at 04:04:31PM -0700, Joe Perches wrote: > more odd uses (mostly in comments) > > $ git grep -P -oh '\bIS_ENABLED\s*\(\s*\w+\s*\)'| \ > sed -r 's/\s+//g'| \ > grep -v '(CONFIG_' | \ > sort | uniq -c | sort -rn I think a missed a bunch because my grep was messy. :) This i

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-06-03 Thread Guenter Roeck
mmots which already has > Ira's patches and it booted fine. I've used sparc32_defconfig to build > the kernel and qemu-system-sparc with default machine and CPU. > > > Mike, am I wrong? Do you think the kmap() patches are still causing issues? > For my part, all I can say is that -next is in pretty bad shape right now. The summary of my tests says: Build results: total: 151 pass: 130 fail: 21 Qemu test results: total: 430 pass: 375 fail: 55 sparc32 smp images in next-20200603 still crash for me with a spinlock recursion. s390 images hang early in boot. Several others (alpha, arm64, various ppc) don't even compile. I can run some more bisects over time, but this is becoming a full-time job :-(. Guenter

Re: [PATCH 1/3] ASoC: fsl_easrc: Fix -Wmissing-prototypes warning

2020-06-03 Thread Nicolin Chen
On Wed, Jun 03, 2020 at 11:39:39AM +0800, Shengjiu Wang wrote: > Obtained with: > $ make W=1 > > sound/soc/fsl/fsl_easrc.c:967:5: warning: no previous prototype for function > 'fsl_easrc_config_context' [-Wmissing-prototypes] > int fsl_easrc_config_context(struct fsl_asrc *easrc, unsigned int ctx

Re: [PATCH 2/3] ASoC: fsl_easrc: Fix -Wunused-but-set-variable

2020-06-03 Thread Nicolin Chen
On Wed, Jun 03, 2020 at 11:39:40AM +0800, Shengjiu Wang wrote: > Obtained with: > $ make W=1 > > sound/soc/fsl/fsl_easrc.c: In function 'fsl_easrc_set_rs_ratio': > sound/soc/fsl/fsl_easrc.c:182:15: warning: variable 'int_bits' set but not > used [-Wunused-but-set-variable] > unsigned int int_bi

Re: [PATCH 3/3] ASoC: fsl_easrc: Fix "Function parameter not described" warnings

2020-06-03 Thread Nicolin Chen
On Wed, Jun 03, 2020 at 11:39:41AM +0800, Shengjiu Wang wrote: > Obtained with: > $ make W=1 > > sound/soc/fsl/fsl_easrc.c:403: warning: Function parameter or member 'easrc' > not described in 'fsl_easrc_normalize_filter' > sound/soc/fsl/fsl_easrc.c:403: warning: Function parameter or member > '

Re: [PATCH] cxl: Fix kobject memleak

2020-06-03 Thread Andrew Donnellan
On 3/6/20 9:57 pm, wanghai (M) wrote: kfree(cr) can be called when kobject_put()-->kobject_release()-->kobject_cleanup()-->kobj_type->release() is called.  The kobj_type here is afu_config_record_type Of course, I missed that. In that case Acked-by: Andrew Donnellan Thanks for the fix! --

Re: [PATCH v3 2/7] documentation for stats_fs

2020-06-03 Thread Randy Dunlap
Hi-- Here are a few comments for you. On 5/26/20 4:03 AM, Emanuele Giuseppe Esposito wrote: > Html docs for a complete documentation of the stats_fs API, > filesystem and usage. > > Signed-off-by: Emanuele Giuseppe Esposito > --- > Documentation/filesystems/index.rst| 1 + > Documentati

RE: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-03 Thread Williams, Dan J
[ forgive formatting I'm temporarily stuck using Outlook this week... ] > From: Vaibhav Jain [..] > > Introduce support for PAPR NVDIMM Specific Methods (PDSM) in papr_scm > module and add the command family NVDIMM_FAMILY_PAPR to the white > list of NVDIMM command sets. Also advertise support fo

Re: [PATCH 1/2] powerpc/pseries: remove cede offline state for CPUs

2020-06-03 Thread Nathan Lynch
Hi Gautham, Gautham R Shenoy writes: > On Mon, Jun 01, 2020 at 11:31:39PM -0500, Nathan Lynch wrote: >> This effectively reverts commit 3aa565f53c39 ("powerpc/pseries: Add >> hooks to put the CPU into an appropriate offline state"), which added >> an offline mode for CPUs which uses the H_CEDE hc

Re: Re: [RESEND PATCH v5 5/5] Documentation/vmcoreinfo: Add documentation for 'TCR_EL1.T1SZ'

2020-06-03 Thread Scott Branden
Hi Bhupesh, On Wed, 3 Jun 2020 at 13:39, Bhupesh Sharma wrote: > Hello Scott, > > On Thu, Jun 4, 2020 at 12:17 AM Scott Branden > wrote: > > > > Hi Bhupesh, > > > > Would be great to get this patch series upstreamed? > > > > On 2019-12-25 10:49 a.m., Bhupesh Sharma wrote: > > > Hi James, > > >

Re: [PATCH v1 3/4] KVM: PPC: Book3S HV: migrate remaining normal-GFNs to secure-GFNs in H_SVM_INIT_DONE

2020-06-03 Thread Bharata B Rao
On Wed, Jun 03, 2020 at 04:10:25PM -0700, Ram Pai wrote: > On Tue, Jun 02, 2020 at 03:36:39PM +0530, Bharata B Rao wrote: > > On Mon, Jun 01, 2020 at 12:05:35PM -0700, Ram Pai wrote: > > > On Mon, Jun 01, 2020 at 05:25:18PM +0530, Bharata B Rao wrote: > > > > On Sat, May 30, 2020 at 07:27:50PM -070

Re: [PATCH v4 1/4] riscv: Move kernel mapping to vmalloc zone

2020-06-03 Thread Zong Li
On Wed, Jun 3, 2020 at 4:01 PM Alexandre Ghiti wrote: > > This is a preparatory patch for relocatable kernel. > > The kernel used to be linked at PAGE_OFFSET address and used to be loaded > physically at the beginning of the main memory. Therefore, we could use > the linear mapping for the kernel

[PATCH v2 0/8] powerpc/watchpoint: Enable 2nd DAWR on baremetal and powervm

2020-06-03 Thread Ravi Bangoria
Last series[1] was to add basic infrastructure support for more than one watchpoint on Book3S powerpc. This series actually enables the 2nd DAWR for baremetal and powervm. Kvm guest is still not supported. v1: https://lore.kernel.org/linuxppc-dev/20200602040106.127693-1-ravi.bango...@linux.ibm.c

[PATCH v2 1/8] powerpc/watchpoint: Fix 512 byte boundary limit

2020-06-03 Thread Ravi Bangoria
Milton reported that we are aligning start and end address to wrong size SZ_512M. It should be SZ_512. Fix that. While doing this change I also found a case where ALIGN() comparison fails. Within a given aligned range, ALIGN() of two addresses does not match when start address is pointing to the f

[PATCH v2 2/8] powerpc/watchpoint: Enable watchpoint functionality on power10 guest

2020-06-03 Thread Ravi Bangoria
CPU_FTR_DAWR is by default enabled for host via CPU_FTRS_DT_CPU_BASE (controlled by CONFIG_PPC_DT_CPU_FTRS). But cpu-features device-tree node is not PAPR compatible and thus not yet used by kvm or pHyp guests. Enable watchpoint functionality on power10 guest (both kvm and powervm) by adding CPU_FT

[PATCH v2 3/8] powerpc/dt_cpu_ftrs: Add feature for 2nd DAWR

2020-06-03 Thread Ravi Bangoria
Add new device-tree feature for 2nd DAWR. If this feature is present, 2nd DAWR is supported, otherwise not. Signed-off-by: Ravi Bangoria --- arch/powerpc/include/asm/cputable.h | 7 +-- arch/powerpc/kernel/dt_cpu_ftrs.c | 7 +++ 2 files changed, 12 insertions(+), 2 deletions(-) diff -

[PATCH v2 4/8] powerpc/watchpoint: Set CPU_FTR_DAWR1 based on pa-features bit

2020-06-03 Thread Ravi Bangoria
As per the PAPR, bit 0 of byte 64 in pa-features property indicates availability of 2nd DAWR registers. i.e. If this bit is set, 2nd DAWR is present, otherwise not. Host generally uses "cpu-features", which masks "pa-features". But "cpu-features" are still not used for guests and thus this change i

[PATCH v2 5/8] powerpc/watchpoint: Rename current H_SET_MODE DAWR macro

2020-06-03 Thread Ravi Bangoria
Current H_SET_MODE hcall macro name for setting/resetting DAWR0 is H_SET_MODE_RESOURCE_SET_DAWR. Add suffix 0 to macro name as well. Signed-off-by: Ravi Bangoria --- arch/powerpc/include/asm/hvcall.h | 2 +- arch/powerpc/include/asm/plpar_wrappers.h | 2 +- arch/powerpc/kvm/book3s_hv.c

[PATCH v2 6/8] powerpc/watchpoint: Guest support for 2nd DAWR hcall

2020-06-03 Thread Ravi Bangoria
2nd DAWR can be set/unset using H_SET_MODE hcall with resource value 5. Enable powervm guest support with that. This has no effect on kvm guest because kvm will return error if guest does hcall with resource value 5. Signed-off-by: Ravi Bangoria --- arch/powerpc/include/asm/hvcall.h | 1

[PATCH v2 7/8] powerpc/watchpoint: Return available watchpoints dynamically

2020-06-03 Thread Ravi Bangoria
So far Book3S Powerpc supported only one watchpoint. Power10 is introducing 2nd DAWR. Enable 2nd DAWR support for Power10. Availability of 2nd DAWR will depend on CPU_FTR_DAWR1. Signed-off-by: Ravi Bangoria --- arch/powerpc/include/asm/cputable.h | 4 +++- arch/powerpc/include/asm/hw_breakp

[PATCH v2 8/8] powerpc/watchpoint: Remove 512 byte boundary

2020-06-03 Thread Ravi Bangoria
Power10 has removed 512 bytes boundary from match criteria. i.e. The watch range can cross 512 bytes boundary. Signed-off-by: Ravi Bangoria --- arch/powerpc/kernel/hw_breakpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch

Re: [mainline][Oops][bisected 2ba3e6 ] 5.7.0 boot fails with kernel panic on powerpc

2020-06-03 Thread Abdul Haleem
On Wed, 2020-06-03 at 15:32 +0200, Joerg Roedel wrote: > On Wed, Jun 03, 2020 at 04:20:57PM +0530, Abdul Haleem wrote: > > @Joerg, Could you please have a look? > > Can you please try the attached patch? Thanks Joerg, The given patch fixes the boot problem. Please add Reported-by in fix commit.

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-06-03 Thread Mike Rapoport
atus? > > > > I believe the tests were failing for Guenter due to another patch set...[1] > > > > My tests with just this series are working. > > > >>From my understanding the other failures were unrelated.[2] > > > > > > I've

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-06-03 Thread Ira Weiny
s that -next is in pretty bad shape right now. > The summary of my tests says: > > Build results: > total: 151 pass: 130 fail: 21 > Qemu test results: > total: 430 pass: 375 fail: 55 > > sparc32 smp images in next-20200603 still crash for me with a spinlock >

[PATCH] ASoC: fsl-asoc-card: Defer probe when fail to find codec device

2020-06-03 Thread Shengjiu Wang
Defer probe when fail to find codec device, because the codec device maybe probed later than machine driver. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl-asoc-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-c

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-06-03 Thread Mike Rapoport
gt; lock: 0xf53ef350, .magic: dead4ead, .owner: S01syslogd/139, .owner_cpu: 0 > CPU: 0 PID: 139 Comm: S01syslogd Not tainted 5.7.0-next-20200603 #1 > [f0067d00 : > do_raw_spin_lock+0xa8/0xd8 ] > [f00d598c : > copy_page_range+0x328/0x804 ] > [f0025c34 : > dup_mm+0x334/0x4

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-06-03 Thread Ira Weiny
> >>> Is there another test I need to run? > > >> > > >> This all petered out, but as I understand it, this patchset still might > > >> have issues on various architectures. > > >> > > >> Can folks please provide an update on t

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-06-03 Thread Ira Weiny
> > > ... > > Starting syslogd: BUG: spinlock recursion on CPU#0, S01syslogd/139 > > lock: 0xf53ef350, .magic: dead4ead, .owner: S01syslogd/139, .owner_cpu: 0 > > CPU: 0 PID: 139 Comm: S01syslogd Not tainted 5.7.0-next-20200603 #1 > > [f0067d00 : > > do_

Re: linux-next: fix ups for clashes between akpm and powerpc trees

2020-06-03 Thread Stephen Rothwell
Hi all, On Wed, 3 Jun 2020 20:26:55 +1000 Stephen Rothwell wrote: > > Some things turned up in the powerpc tree today that required some changes > to patches in the akpm tree and also the following fixup patch provided > (mostly) by Michael. I have applied this as a single patch today, but > par