[PATCH v2 2/2] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable

2020-06-23 Thread Shengjiu Wang
Fix unchecked return value for clk_prepare_enable, add error handler in fsl_mqs_runtime_resume. Fixes: 9e28f6532c61 ("ASoC: fsl_mqs: Add MQS component driver") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_mqs.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff

Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-23 Thread Nicolin Chen
On Tue, Jun 23, 2020 at 02:01:11PM +0800, Shengjiu Wang wrote: > Because clk_prepare_enable and clk_disable_unprepare should > check input clock parameter is NULL or not internally, then > we don't need to check them before calling the function. > > Fixes: 9e28f6532c61 ("ASoC: fsl_mqs: Add MQS

[PATCH v2 0/2] Fix unchecked return value for clk_prepare_enable

2020-06-23 Thread Shengjiu Wang
First patch is to remove the check of clock pointer before calling clk API. Second patch is to fix the issue that the return value of clk_prepare_enable is not checked. changes in v2: - split the patch to separate patches Shengjiu Wang (2): ASoC: fsl_mqs: Don't check clock is NULL before

[PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-23 Thread Shengjiu Wang
Because clk_prepare_enable and clk_disable_unprepare should check input clock parameter is NULL or not internally, then we don't need to check them before calling the function. Fixes: 9e28f6532c61 ("ASoC: fsl_mqs: Add MQS component driver") Signed-off-by: Shengjiu Wang ---

[PATCH 2/2] ASoC: bindings: fsl-asoc-card: Add compatible string for wm8524

2020-06-23 Thread Shengjiu Wang
In order to support wm8524 codec with fsl-asoc-card machine driver, add compatible string "fsl,imx-audio-wm8524". Signed-off-by: Shengjiu Wang --- Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 1/2] ASoC: fsl-asoc-card: Add WM8524 support

2020-06-23 Thread Shengjiu Wang
WM8524 only supports playback mode, and only works at slave mode. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl-asoc-card.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index d0543a53764e..57ea1b072326 100644

Re: [PATCH v2 2/2] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable

2020-06-23 Thread Nicolin Chen
On Tue, Jun 23, 2020 at 02:01:12PM +0800, Shengjiu Wang wrote: > Fix unchecked return value for clk_prepare_enable, add error > handler in fsl_mqs_runtime_resume. > > Fixes: 9e28f6532c61 ("ASoC: fsl_mqs: Add MQS component driver") > Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen

[PATCH v2 11/15] docs: powerpc: fix some issues at vas-api.rst

2020-06-23 Thread Mauro Carvalho Chehab
There are a few issues on this document, when built via the building with ``make htmldocs``: Documentation/powerpc/vas-api.rst:116: WARNING: Unexpected indentation. Documentation/powerpc/vas-api.rst:116: WARNING: Inline emphasis start-string without end-string.

[PATCH v1 1/3] powerpc/mm/radix: Create separate mappings for hot-plugged memory

2020-06-23 Thread Bharata B Rao
Memory that gets hot-plugged _during_ boot (and not the memory that gets plugged in after boot), is mapped with 1G mappings and will undergo splitting when it is unplugged. The splitting code has a few issues: 1. Recursive locking Memory unplug path takes cpu_hotplug_lock and

Re: [PATCH v4 6/8] arm: Break cyclic percpu include

2020-06-23 Thread Will Deacon
On Tue, Jun 23, 2020 at 10:36:51AM +0200, Peter Zijlstra wrote: > In order to use in irqflags.h, we need to make sure > asm/percpu.h does not itself depend on irqflags.h. > > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/arm/include/asm/percpu.h |2 ++ > 1 file changed, 2

Re: [PATCH V3 (RESEND) 0/3] arm64: Enable vmemmap mapping from device memory

2020-06-23 Thread Jia He
Hi I also tested the addional cases on arm64 1, 4k page size + devdax + --map=mem 2, 64k page size + devdax + --map=mem 3, 4k page size + devdax + --map=dev 4, 64k page size + devdax + --map=dev case 4 is important to verify Anshuman's this series. Host kernel: 5.7-rc3 guest kernel:

[PATCH v2] hmi: Move hmi irq stat from percpu variable to paca.

2020-06-23 Thread Mahesh Salgaonkar
With the proposed change in percpu bootmem allocator to use page mapping [1], the percpu first chunk memory area can come from vmalloc ranges. This makes hmi handler to crash the kernel whenever percpu variable is accessed in real mode. This patch fixes this issue by moving the hmi irq stat

Re: [PATCH v1 3/3] powerpc/mm/radix: Free PUD table when freeing pagetable

2020-06-23 Thread Aneesh Kumar K.V
Bharata B Rao writes: > remove_pagetable() isn't freeing PUD table. This causes memory > leak during memory unplug. Fix this. > Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Bharata B Rao > --- > arch/powerpc/mm/book3s64/radix_pgtable.c | 16 > 1 file changed, 16

Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-23 Thread Shengjiu Wang
On Tue, Jun 23, 2020 at 4:55 PM Markus Elfring wrote: > > > clk_prepare_enable and clk_disable_unprepare check the input > > clock parameter in the beginning of the function, > > These functions call further functions which perform null pointer checks. > > > >

Re: [PATCH v2 0/2] Fix unchecked return value for clk_prepare_enable

2020-06-23 Thread Mark Brown
On Tue, 23 Jun 2020 14:01:10 +0800, Shengjiu Wang wrote: > First patch is to remove the check of clock pointer before calling > clk API. > > Second patch is to fix the issue that the return value of > clk_prepare_enable is not checked. > > changes in v2: > - split the patch to separate patches >

[PATCH] powerpc/boot/dts: Fix dtc "pciex" warnings

2020-06-23 Thread Michael Ellerman
With CONFIG_OF_ALL_DTBS=y, as set by eg. allmodconfig, we see lots of warnings about our dts files, such as: arch/powerpc/boot/dts/glacier.dts:492.26-532.5: Warning (pci_bridge): /plb/pciex@d: node name is not "pci" or "pcie" The node name should not particularly matter, it's just

[PATCH v6 2/5] KVM: arm64: clean up redundant 'kvm_run' parameters

2020-06-23 Thread Tianjia Zhang
In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This patch does a unified cleanup of these remaining redundant parameters.

Re: [PATCH v1 2/3] powerpc/mm/radix: Fix PTE/PMD fragment count for early page table mappings

2020-06-23 Thread Bharata B Rao
On Tue, Jun 23, 2020 at 04:07:34PM +0530, Aneesh Kumar K.V wrote: > Bharata B Rao writes: > > > We can hit the following BUG_ON during memory unplug: > > > > kernel BUG at arch/powerpc/mm/book3s64/pgtable.c:342! > > Oops: Exception in kernel mode, sig: 5 [#1] > > LE PAGE_SIZE=64K MMU=Radix SMP

Re: linux-next: manual merge of the pidfd tree with the powerpc-fixes tree

2020-06-23 Thread Michael Ellerman
Christian Brauner writes: > On Fri, Jun 19, 2020 at 09:17:30PM +1000, Michael Ellerman wrote: >> Stephen Rothwell writes: >> > Hi all, >> > >> > Today's linux-next merge of the pidfd tree got a conflict in: >> > >> > arch/powerpc/kernel/syscalls/syscall.tbl >> > >> > between commit: >> > >> >

Re: [v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-23 Thread Markus Elfring
>>> if the parameter >>> is NULL, clk_prepare_enable and clk_disable_unprepare will >>> return immediately. >> >> The interpretation of these function implementations seems to be reasonable. >> Would you like to achieve any improvements

[PATCH v6 4/5] KVM: MIPS: clean up redundant 'kvm_run' parameters

2020-06-23 Thread Tianjia Zhang
In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This patch does a unified cleanup of these remaining redundant parameters.

[PATCH v6 1/5] KVM: s390: clean up redundant 'kvm_run' parameters

2020-06-23 Thread Tianjia Zhang
In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This patch does a unified cleanup of these remaining redundant parameters.

[PATCH v6 0/5] clean up redundant 'kvm_run' parameters

2020-06-23 Thread Tianjia Zhang
In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This patch does a unified cleanup of these remaining redundant parameters. This series

[PATCH v6 3/5] KVM: PPC: clean up redundant kvm_run parameters in assembly

2020-06-23 Thread Tianjia Zhang
In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This patch does a unified cleanup of these remaining redundant parameters.

Re: [PATCH] ASoC: fsl_easrc: Fix uninitialized scalar variable in fsl_easrc_set_ctx_format

2020-06-23 Thread Mark Brown
On Mon, 22 Jun 2020 17:03:31 +0800, Shengjiu Wang wrote: > The "ret" in fsl_easrc_set_ctx_format is not initialized, then > the unknown value maybe returned by this function. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_easrc:

[PATCH v6 5/5] KVM: MIPS: clean up redundant kvm_run parameters in assembly

2020-06-23 Thread Tianjia Zhang
In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This patch does a unified cleanup of these remaining redundant parameters.

[PATCH v1 2/3] powerpc/mm/radix: Fix PTE/PMD fragment count for early page table mappings

2020-06-23 Thread Bharata B Rao
We can hit the following BUG_ON during memory unplug: kernel BUG at arch/powerpc/mm/book3s64/pgtable.c:342! Oops: Exception in kernel mode, sig: 5 [#1] LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA pSeries NIP [c0093308] pmd_fragment_free+0x48/0xc0 LR [c147bfec]

[PATCH v4 3/8] sparc64: Fix asm/percpu.h build error

2020-06-23 Thread Peter Zijlstra
In order to break a header dependency between lockdep and task_struct, I need per-cpu stuff from lockdep. Signed-off-by: Peter Zijlstra (Intel) --- arch/sparc/include/asm/percpu_64.h |2 ++ arch/sparc/include/asm/trap_block.h |2 ++ 2 files changed, 4 insertions(+) ---

[PATCH v4 8/8] lockdep: Remove lockdep_hardirq{s_enabled, _context}() argument

2020-06-23 Thread Peter Zijlstra
Now that the macros use per-cpu data, we no longer need the argument. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/entry/common.c|2 +- include/linux/irqflags.h |8 include/linux/lockdep.h|2 +- kernel/locking/lockdep.c | 30

[PATCH v4 2/8] x86/entry: Fix NMI vs IRQ state tracking

2020-06-23 Thread Peter Zijlstra
While the nmi_enter() users did trace_hardirqs_{off_prepare,on_finish}() there was no matching lockdep_hardirqs_*() calls to complete the picture. Introduce idtentry_{enter,exit}_nmi() to enable proper IRQ state tracking across the NMIs. Signed-off-by: Peter Zijlstra (Intel) ---

Re: [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread()

2020-06-23 Thread Geert Uytterhoeven
On Tue, Jun 23, 2020 at 1:47 AM Christian Brauner wrote: > Now that HAVE_COPY_THREAD_TLS has been removed, rename copy_thread_tls() > back simply copy_thread(). It's a simpler name, and doesn't imply that only > tls is copied here. This finishes an outstanding chunk of internal process > creation

[PATCH v4 6/8] arm: Break cyclic percpu include

2020-06-23 Thread Peter Zijlstra
In order to use in irqflags.h, we need to make sure asm/percpu.h does not itself depend on irqflags.h. Signed-off-by: Peter Zijlstra (Intel) --- arch/arm/include/asm/percpu.h |2 ++ 1 file changed, 2 insertions(+) --- a/arch/arm/include/asm/percpu.h +++ b/arch/arm/include/asm/percpu.h @@

[PATCH v4 5/8] s390: Break cyclic percpu include

2020-06-23 Thread Peter Zijlstra
In order to use in irqflags.h, we need to make sure asm/percpu.h does not itself depend on irqflags.h Signed-off-by: Peter Zijlstra (Intel) --- arch/s390/include/asm/smp.h |1 + arch/s390/include/asm/thread_info.h |1 - 2 files changed, 1 insertion(+), 1 deletion(-) ---

Re: [PATCH v1 1/3] powerpc/mm/radix: Create separate mappings for hot-plugged memory

2020-06-23 Thread Aneesh Kumar K.V
Bharata B Rao writes: > Memory that gets hot-plugged _during_ boot (and not the memory > that gets plugged in after boot), is mapped with 1G mappings > and will undergo splitting when it is unplugged. The splitting > code has a few issues: > > 1. Recursive locking > > Memory

Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-23 Thread Shengjiu Wang
On Tue, Jun 23, 2020 at 3:38 PM Markus Elfring wrote: > > > In-Reply-To: > > I guess that it should be sufficient to specify such a field once > for the header information. seems it's caused by my "git format-patch" command, I will update it, hope it is better next time. > > > > Because

[PATCH v4 7/8] lockdep: Change hardirq{s_enabled, _context} to per-cpu variables

2020-06-23 Thread Peter Zijlstra
Currently all IRQ-tracking state is in task_struct, this means that task_struct needs to be defined before we use it. Especially for lockdep_assert_irq*() this can lead to header-hell. Move the hardirq state into per-cpu variables to avoid the task_struct dependency. Signed-off-by: Peter

[PATCH v4 0/8] lockdep: Change IRQ state tracking to use per-cpu variables

2020-06-23 Thread Peter Zijlstra
Ahmed and Sebastian wanted additional lockdep_assert*() macros and ran into header hell. I figured using per-cpu variables would cure that, and also ran into header hell, still tracktable though. By moving the IRQ state into per-cpu variables we remove the dependency on task_struct. Patches go

[PATCH v2 00/15] Documentation fixes

2020-06-23 Thread Mauro Carvalho Chehab
Hi Jon, As requested, this is a rebase of a previous series posted on Jan, 15. Since then, several patches got merged via other trees or became obsolete. There were also 2 patches before that fits better at the ReST conversion patchset. So, I'll be sending it on another patch series together

[PATCH v1 0/3] powerpc/mm/radix: Memory unplug fixes

2020-06-23 Thread Bharata B Rao
This is the next version of the fixes for memory unplug on radix. The issues and the fix are described in the actual patches. Changes in v1: == - Rebased to latest kernel. - Took care of p4d changes. - Addressed Aneesh's review feedback: - Added comments. - Indentation fixed. -

Re: [PATCH 16/17] arch: remove HAVE_COPY_THREAD_TLS

2020-06-23 Thread Geert Uytterhoeven
On Tue, Jun 23, 2020 at 1:47 AM Christian Brauner wrote: > All architectures support copy_thread_tls() now, so remove the legacy > copy_thread() function and the HAVE_COPY_THREAD_TLS config option. Everyone > uses the same process creation calling convention based on > copy_thread_tls() and

Re: [PATCH v4 0/7] clean up redundant 'kvm_run' parameters

2020-06-23 Thread Tianjia Zhang
On 2020/6/23 17:42, Paolo Bonzini wrote: On 27/04/20 06:35, Tianjia Zhang wrote: In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time.

Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-23 Thread Markus Elfring
> In-Reply-To: I guess that it should be sufficient to specify such a field once for the header information. > Because clk_prepare_enable and clk_disable_unprepare should > check input clock parameter is NULL or not internally, I find this change description unclear. > then we don't need to

[PATCH v4 1/8] lockdep: Prepare for NMI IRQ state tracking

2020-06-23 Thread Peter Zijlstra
There is no reason not to always, accurately, track IRQ state. This change also makes IRQ state tracking ignore lockdep_off(). Signed-off-by: Peter Zijlstra (Intel) --- kernel/locking/lockdep.c | 44 +--- 1 file changed, 41 insertions(+), 3

Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-23 Thread Markus Elfring
> clk_prepare_enable and clk_disable_unprepare check the input > clock parameter in the beginning of the function, These functions call further functions which perform null pointer checks. > if the parameter > is NULL,

[PATCH v1 3/3] powerpc/mm/radix: Free PUD table when freeing pagetable

2020-06-23 Thread Bharata B Rao
remove_pagetable() isn't freeing PUD table. This causes memory leak during memory unplug. Fix this. Signed-off-by: Bharata B Rao --- arch/powerpc/mm/book3s64/radix_pgtable.c | 16 1 file changed, 16 insertions(+) diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c

[PATCH v4 4/8] powerpc64: Break asm/percpu.h vs spinlock_types.h dependency

2020-06-23 Thread Peter Zijlstra
In order to use in lockdep.h, we need to make sure asm/percpu.h does not itself depend on lockdep. The below seems to make that so and builds powerpc64-defconfig + PROVE_LOCKING. Signed-off-by: Peter Zijlstra (Intel) --- arch/powerpc/include/asm/dtl.h | 52

Re: [PATCH v4 0/7] clean up redundant 'kvm_run' parameters

2020-06-23 Thread Paolo Bonzini
On 27/04/20 06:35, Tianjia Zhang wrote: > In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' > structure. For historical reasons, many kvm-related function parameters > retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This > patch does a unified cleanup of

Re: [PATCH v4 0/7] clean up redundant 'kvm_run' parameters

2020-06-23 Thread Paolo Bonzini
On 23/06/20 12:00, Tianjia Zhang wrote: > > > On 2020/6/23 17:42, Paolo Bonzini wrote: >> On 27/04/20 06:35, Tianjia Zhang wrote: >>> In the current kvm version, 'kvm_run' has been included in the >>> 'kvm_vcpu' >>> structure. For historical reasons, many kvm-related function parameters >>>

Re: [PATCH v1 2/3] powerpc/mm/radix: Fix PTE/PMD fragment count for early page table mappings

2020-06-23 Thread Aneesh Kumar K.V
Bharata B Rao writes: > We can hit the following BUG_ON during memory unplug: > > kernel BUG at arch/powerpc/mm/book3s64/pgtable.c:342! > Oops: Exception in kernel mode, sig: 5 [#1] > LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA pSeries > NIP [c0093308] pmd_fragment_free+0x48/0xc0 >

Re: [PATCH] KVM: PPC: Book3S HV: increase KVMPPC_NR_LPIDS on POWER8 and POWER9

2020-06-23 Thread Cédric Le Goater
On 6/8/20 1:57 PM, Cédric Le Goater wrote: > POWER8 and POWER9 have 12-bit LPIDs. Change LPID_RSVD to support up to > (4096 - 2) guests on these processors. POWER7 is kept the same with a > limitation of (1024 - 2), but it might be time to drop KVM support for > POWER7. > > Tested with 2048

Re: [PATCH 04/18] powerpc/numa: remove unreachable topology update code

2020-06-23 Thread Srikar Dronamraju
* Nathan Lynch [2020-06-12 00:12:24]: > Since the topology_updates_enabled flag is now always false, remove it > and the code which has become unreachable. This is the minimum change > that prevents 'defined but unused' warnings emitted by the compiler > after stubbing out the

Re: [PATCH 08/18] powerpc/numa: remove vphn_enabled and prrn_enabled internal flags

2020-06-23 Thread Srikar Dronamraju
* Nathan Lynch [2020-06-12 00:12:28]: > These flags are always zero now; remove them and suitably adjust the > remaining references to them. > > Signed-off-by: Nathan Lynch > --- > arch/powerpc/mm/numa.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > Looks good to me.

Re: [PATCH 10/18] powerpc/numa: remove timed_topology_update()

2020-06-23 Thread Srikar Dronamraju
* Nathan Lynch [2020-06-12 00:12:30]: > timed_topology_update is a no-op now, so remove it and all call sites. > > Signed-off-by: Nathan Lynch > --- > arch/powerpc/include/asm/topology.h | 5 - > arch/powerpc/mm/numa.c | 9 - >

Re: [PATCH 07/18] powerpc/numa: remove unreachable topology workqueue code

2020-06-23 Thread Srikar Dronamraju
* Nathan Lynch [2020-06-12 00:12:27]: > Since vphn_enabled is always 0, we can remove the call to > topology_schedule_update() and remove the code which becomes > unreachable as a result. > > Signed-off-by: Nathan Lynch > --- > arch/powerpc/mm/numa.c | 14 -- > 1 file changed, 14

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 05:00:31PM +0200, Ahmed S. Darwish wrote: > On Tue, Jun 23, 2020 at 10:36:52AM +0200, Peter Zijlstra wrote: > ... > > -#define lockdep_assert_irqs_disabled() do { > > \ > > - WARN_ONCE(debug_locks && !current->lockdep_recursion && \

Re: [PATCH v6 1/5] KVM: s390: clean up redundant 'kvm_run' parameters

2020-06-23 Thread Christian Borntraeger
On 23.06.20 15:14, Tianjia Zhang wrote: > In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' > structure. For historical reasons, many kvm-related function parameters > retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This > patch does a unified cleanup of

Re: [PATCH 12/18] powerpc/rtasd: simplify handle_rtas_event(), emit message on events

2020-06-23 Thread Srikar Dronamraju
* Nathan Lynch [2020-06-12 00:12:32]: > prrn_is_enabled() always returns false/0, so handle_rtas_event() can > be simplified and some dead code can be removed. Use machine_is() > instead of #ifdef to run this code only on pseries, and add an > informational ratelimited message that we are

Re: [PATCH 05/18] powerpc/numa: make vphn_enabled, prrn_enabled flags const

2020-06-23 Thread Srikar Dronamraju
* Nathan Lynch [2020-06-12 00:12:25]: > Previous changes have made it so these flags are never changed; > enforce this by making them const. > > Signed-off-by: Nathan Lynch > --- Looks good to me. Reviewed-by: Srikar Dronamraju > arch/powerpc/mm/numa.c | 4 ++-- > 1 file changed, 2

Re: [PATCH 11/18] powerpc/numa: remove start/stop_topology_update()

2020-06-23 Thread Srikar Dronamraju
* Nathan Lynch [2020-06-12 00:12:31]: > These APIs have become no-ops, so remove them and all call sites. > > Signed-off-by: Nathan Lynch > --- Looks good to me. Reviewed-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju

Re: [PATCH 03/18] powerpc/numa: remove ability to enable topology updates

2020-06-23 Thread Srikar Dronamraju
* Nathan Lynch [2020-06-12 00:12:23]: > Remove the /proc/powerpc/topology_updates interface and the > topology_updates=on/off command line argument. The internal > topology_updates_enabled flag remains for now, but always false. > Looks good to me. Reviewed-by: Srikar Dronamraju >

Re: [PATCH 06/18] powerpc/numa: remove unreachable topology timer code

2020-06-23 Thread Srikar Dronamraju
* Nathan Lynch [2020-06-12 00:12:26]: > Since vphn_enabled is always 0, we can stub out > timed_topology_update() and remove the code which becomes unreachable. > > Signed-off-by: Nathan Lynch > --- > arch/powerpc/mm/numa.c | 21 - > 1 file changed, 21 deletions(-) >

Re: [PATCH 09/18] powerpc/numa: stub out numa_update_cpu_topology()

2020-06-23 Thread Srikar Dronamraju
* Nathan Lynch [2020-06-12 00:12:29]: > Previous changes have removed the code which sets bits in > cpu_associativity_changes_mask and thus it is never modifed at > runtime. From this we can reason that numa_update_cpu_topology() > always returns 0 without doing anything. Remove the body of >

Re: [PATCH 13/18] powerpc/numa: remove prrn_is_enabled()

2020-06-23 Thread Srikar Dronamraju
* Nathan Lynch [2020-06-12 00:12:33]: > All users of this prrn_is_enabled() are gone; remove it. > > Signed-off-by: Nathan Lynch > --- > arch/powerpc/include/asm/topology.h | 5 - > arch/powerpc/mm/numa.c | 5 - > 2 files changed, 10 deletions(-) > Looks good to me.

Re: [PATCH 14/18] powerpc/numa: remove arch_update_cpu_topology

2020-06-23 Thread Srikar Dronamraju
* Nathan Lynch [2020-06-12 00:12:34]: > Since arch_update_cpu_topology() doesn't do anything on powerpc now, > remove it and associated dead code. > > Signed-off-by: Nathan Lynch > --- > arch/powerpc/include/asm/topology.h | 6 -- > arch/powerpc/mm/numa.c | 10 -- >

[PATCH AUTOSEL 5.4 07/24] ibmvnic: Harden device login requests

2020-06-23 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit dff515a3e71dc8ab3b9dcc2e23a9b5fca88b3c18 ] The VNIC driver's "login" command sequence is the final step in the driver's initialization process with device firmware, confirming the available device queue resources to be utilized by the driver. Under high

[PATCH AUTOSEL 4.19 07/15] ibmvnic: Harden device login requests

2020-06-23 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit dff515a3e71dc8ab3b9dcc2e23a9b5fca88b3c18 ] The VNIC driver's "login" command sequence is the final step in the driver's initialization process with device firmware, confirming the available device queue resources to be utilized by the driver. Under high

[PATCH] KVM: PPC: Book3S HV: Use feature flag CPU_FTR_P9_TIDR when accessing TIDR

2020-06-23 Thread Cédric Le Goater
The TIDR register is only available on POWER9 systems and code accessing this register is not always protected by the CPU_FTR_P9_TIDR flag. Fix that to make sure POWER10 systems won't use it as TIDR has been removed. Signed-off-by: Cédric Le Goater --- arch/powerpc/kvm/book3s_hv.c|

Re: [PATCH 1/2] powerpc/papr_scm: Fetch nvdimm performance stats from PHYP

2020-06-23 Thread Ira Weiny
On Mon, Jun 22, 2020 at 09:54:50AM +0530, Vaibhav Jain wrote: > Update papr_scm.c to query dimm performance statistics from PHYP via > H_SCM_PERFORMANCE_STATS hcall and export them to user-space as PAPR > specific NVDIMM attribute 'perf_stats' in sysfs. The patch also > provide a sysfs ABI

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 06:13:21PM +0200, Ahmed S. Darwish wrote: > Well, freshly merged code is using it. For example, KCSAN: > > => f1bc96210c6a ("kcsan: Make KCSAN compatible with lockdep") > => kernel/kcsan/report.c: > > void kcsan_report(...) > { > ... > /* >

[PATCH AUTOSEL 5.7 08/28] ibmvnic: Harden device login requests

2020-06-23 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit dff515a3e71dc8ab3b9dcc2e23a9b5fca88b3c18 ] The VNIC driver's "login" command sequence is the final step in the driver's initialization process with device firmware, confirming the available device queue resources to be utilized by the driver. Under high

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 07:59:57PM +0200, Marco Elver wrote: > On Tue, Jun 23, 2020 at 06:37PM +0200, Peter Zijlstra wrote: > > On Tue, Jun 23, 2020 at 06:13:21PM +0200, Ahmed S. Darwish wrote: > > > Well, freshly merged code is using it. For example, KCSAN: > > > > > > => f1bc96210c6a

Re: [PATCH 2/2] powerpc/papr_scm: Add support for fetching nvdimm 'fuel-gauge' metric

2020-06-23 Thread Ira Weiny
On Mon, Jun 22, 2020 at 09:54:51AM +0530, Vaibhav Jain wrote: > We add support for reporting 'fuel-gauge' NVDIMM metric via > PAPR_PDSM_HEALTH pdsm payload. 'fuel-gauge' metric indicates the usage > life remaining of a papr-scm compatible NVDIMM. PHYP exposes this > metric via the

Re: [PATCH] powerpc/boot/dts: Fix dtc "pciex" warnings

2020-06-23 Thread Stephen Rothwell
Hi Michael, On Tue, 23 Jun 2020 23:03:20 +1000 Michael Ellerman wrote: > > With CONFIG_OF_ALL_DTBS=y, as set by eg. allmodconfig, we see lots of > warnings about our dts files, such as: > > arch/powerpc/boot/dts/glacier.dts:492.26-532.5: > Warning (pci_bridge): /plb/pciex@d: node

Re: [PATCH 2/2] ASoC: bindings: fsl-asoc-card: Add compatible string for wm8524

2020-06-23 Thread Nicolin Chen
On Tue, Jun 23, 2020 at 02:52:47PM +0800, Shengjiu Wang wrote: > In order to support wm8524 codec with fsl-asoc-card machine > driver, add compatible string "fsl,imx-audio-wm8524". > > Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen

Re: [PATCH 1/2] ASoC: fsl-asoc-card: Add WM8524 support

2020-06-23 Thread Nicolin Chen
On Tue, Jun 23, 2020 at 02:52:46PM +0800, Shengjiu Wang wrote: > WM8524 only supports playback mode, and only works at > slave mode. > > Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen

[PATCH 1/3] powerpc/64s: restore_math remove TM test

2020-06-23 Thread Nicholas Piggin
The TM test in restore_math added by commit dc16b553c949e ("powerpc: Always restore FPU/VEC/VSX if hardware transactional memory in use") is no longer necessary after commit a8318c13e79ba ("powerpc/tm: Fix restoring FP/VMX facility incorrectly on interrupts"), which removed the cases where

[PATCH 3/3] powerpc: re-initialise lazy FPU/VEC counters on every fault

2020-06-23 Thread Nicholas Piggin
When a FP/VEC/VSX unavailable fault loads registers and enables the facility in the MSR, re-set the lazy restore counters to 1 rather than incrementing them so every fault gets the same number of restores before the next fault. This probably shouldn't be a practical change because if a lazy

RE: [PATCH v2 0/2] cpufreq: Specify the default governor on command line

2020-06-23 Thread Doug Smythies
Hi Quentin, Thanks for your quick reply. On 2020.06.23 11:05 Quentin Perret wrote: > Hi Doug, > > On Tuesday 23 Jun 2020 at 10:54:33 (-0700), Doug Smythies wrote: > > Hi Quentin, > > > > Because I am lazy and sometimes do not want to recompile > > the distro source, I have a need/desire for

[PATCH RFC 1/1] powerpc/eeh: Provide a unique ID for each EEH recovery

2020-06-23 Thread Sam Bobroff
Give a unique ID to each recovery event, to ease log parsing and prepare for parallel recovery. Also add some new messages with a very simple format that may be useful to log-parsers. Signed-off-by: Sam Bobroff --- This patch should be applied on top of my recent(ish) set: "powerpc/eeh:

[PATCH RFC 1/1] powerpc/eeh: PE info tree via debugfs and syslog

2020-06-23 Thread Sam Bobroff
Provide an ASCII art tree display of the PEs affected by recovery, with as much state as possible, at the start and end of recovery. Some platform specific information is provided via a new eeh_ops member. The same information is made available from debugfs at:

Re: [PATCH v2 2/2] cpufreq: Specify default governor on command line

2020-06-23 Thread Viresh Kumar
On 23-06-20, 15:21, Quentin Perret wrote: > Currently, the only way to specify the default CPUfreq governor is via > Kconfig options, which suits users who can build the kernel themselves > perfectly. > > However, for those who use a distro-like kernel (such as Android, with > the Generic Kernel

[PATCH RFC 1/1] powerpc/eeh: Asynchronous recovery

2020-06-23 Thread Sam Bobroff
Currently, EEH recovery is entirely serialized and takes place within a single kernel thread. This can cause recovery to take a long time when there are many devices. To shorten recovery time, this change allows recovery to proceed in parallel in two ways: - Each PHB is given it's own recovery

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 08:12:32PM +0200, Peter Zijlstra wrote: > Fair enough; I'll rip it all up and boot a KCSAN kernel, see what if > anything happens. OK, so the below patch doesn't seem to have any nasty recursion issues here. The only 'problem' is that lockdep now sees report_lock can cause

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 10:24:04PM +0200, Peter Zijlstra wrote: > On Tue, Jun 23, 2020 at 08:12:32PM +0200, Peter Zijlstra wrote: > > Fair enough; I'll rip it all up and boot a KCSAN kernel, see what if > > anything happens. > > OK, so the below patch doesn't seem to have any nasty recursion

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 09:13:35PM +0200, Marco Elver wrote: > I see the below report when I boot with your branch + KCSAN and > PROVE_LOCKING. config attached. Trying to make sense of what's > happening. Ah, I was still playing with tip/master + PROVE_LOCKING + KCSAN and slowly removing parts of

Re: [PATCH v6 1/5] KVM: s390: clean up redundant 'kvm_run' parameters

2020-06-23 Thread Tianjia Zhang
On 2020/6/23 23:31, Christian Borntraeger wrote: On 23.06.20 15:14, Tianjia Zhang wrote: In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the

Re: [PATCH V3 0/4] mm/debug_vm_pgtable: Add some more tests

2020-06-23 Thread Anshuman Khandual
On 06/15/2020 09:07 AM, Anshuman Khandual wrote: > This series adds some more arch page table helper validation tests which > are related to core and advanced memory functions. This also creates a > documentation, enlisting expected semantics for all page table helpers as > suggested by Mike

[PATCH] powerpc/boot: Use address-of operator on section symbols

2020-06-23 Thread Nathan Chancellor
Clang warns: arch/powerpc/boot/main.c:107:18: warning: array comparison always evaluates to a constant [-Wtautological-compare] if (_initrd_end > _initrd_start) { ^ arch/powerpc/boot/main.c:155:20: warning: array comparison always evaluates to a constant

Re: [PATCH v4 3/8] sparc64: Fix asm/percpu.h build error

2020-06-23 Thread David Miller
From: Peter Zijlstra Date: Tue, 23 Jun 2020 10:36:48 +0200 > In order to break a header dependency between lockdep and task_struct, > I need per-cpu stuff from lockdep. > > Signed-off-by: Peter Zijlstra (Intel) Acked-by: David S. Miller

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Ahmed S. Darwish
On Tue, Jun 23, 2020 at 10:36:52AM +0200, Peter Zijlstra wrote: ... > -#define lockdep_assert_irqs_disabled() do { > \ > - WARN_ONCE(debug_locks && !current->lockdep_recursion && \ > - current->hardirqs_enabled,

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Ahmed S. Darwish
On Tue, Jun 23, 2020 at 05:24:50PM +0200, Peter Zijlstra wrote: > On Tue, Jun 23, 2020 at 05:00:31PM +0200, Ahmed S. Darwish wrote: > > On Tue, Jun 23, 2020 at 10:36:52AM +0200, Peter Zijlstra wrote: > > ... > > > -#define lockdep_assert_irqs_disabled() do { > > > \ >