Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-24 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 10:24:04PM +0200, Peter Zijlstra wrote: > On Tue, Jun 23, 2020 at 08:12:32PM +0200, Peter Zijlstra wrote: > > Fair enough; I'll rip it all up and boot a KCSAN kernel, see what if > > anything happens. > > OK, so the below patch doesn't seem to have any nasty recursion issue

[PATCH v5 0/3] Offline memoryless cpuless node 0

2020-06-24 Thread Srikar Dronamraju
Changelog v4:->v5: - rebased to v5.8-rc2 link v4: http://lore.kernel.org/lkml/20200512132937.19295-1-sri...@linux.vnet.ibm.com/t/#u Changelog v3:->v4: - Resolved comments from Christopher. Link v3: http://lore.kernel.org/lkml/20200501031128.19584-1-sri...@linux.vnet.ibm.com/t/#u Changelog v2:->

[PATCH v5 1/3] powerpc/numa: Set numa_node for all possible cpus

2020-06-24 Thread Srikar Dronamraju
A Powerpc system with multiple possible nodes and with CONFIG_NUMA enabled always used to have a node 0, even if node 0 does not any cpus or memory attached to it. As per PAPR, node affinity of a cpu is only available once its present / online. For all cpus that are possible but not present, cpu_to

[PATCH v5 2/3] powerpc/numa: Prefer node id queried from vphn

2020-06-24 Thread Srikar Dronamraju
Node id queried from the static device tree may not be correct. For example: it may always show 0 on a shared processor. Hence prefer the node id queried from vphn and fallback on the device tree based node id if vphn query fails. Cc: linuxppc-dev@lists.ozlabs.org Cc: linux...@kvack.org Cc: linux-

[PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

2020-06-24 Thread Srikar Dronamraju
Currently Linux kernel with CONFIG_NUMA on a system with multiple possible nodes, marks node 0 as online at boot. However in practice, there are systems which have node 0 as memoryless and cpuless. This can cause numa_balancing to be enabled on systems with only one node with memory and CPUs. The

Re: [PATCH v5 1/3] powerpc/numa: Set numa_node for all possible cpus

2020-06-24 Thread Gautham R Shenoy
On Wed, Jun 24, 2020 at 02:58:44PM +0530, Srikar Dronamraju wrote: > A Powerpc system with multiple possible nodes and with CONFIG_NUMA > enabled always used to have a node 0, even if node 0 does not any cpus > or memory attached to it. As per PAPR, node affinity of a cpu is only > available once i

[PATCH v2 0/2] Add cpu hotplug support for powerpc/perf/hv-24x7

2020-06-24 Thread Kajol Jain
This patchset add cpu hotplug support for hv_24x7 driver by adding online/offline cpu hotplug function. It also add sysfs file "cpumask" to expose current online cpu that can be used for hv_24x7 event count. Changelog: v1 -> v2 - Changed function to pick active cpu incase of offline from "cpumas

Re: [PATCH v5 2/3] powerpc/numa: Prefer node id queried from vphn

2020-06-24 Thread Gautham R Shenoy
Hello Srikar, On Wed, Jun 24, 2020 at 02:58:45PM +0530, Srikar Dronamraju wrote: > Node id queried from the static device tree may not > be correct. For example: it may always show 0 on a shared processor. > Hence prefer the node id queried from vphn and fallback on the device tree > based node i

Re: [PATCH v2 1/2] powerpc/perf/hv-24x7: Add cpu hotplug support

2020-06-24 Thread Gautham R Shenoy
On Wed, Jun 24, 2020 at 03:47:53PM +0530, Kajol Jain wrote: > Patch here adds cpu hotplug functions to hv_24x7 pmu. > A new cpuhp_state "CPUHP_AP_PERF_POWERPC_HV_24x7_ONLINE" enum > is added. > > The online function update the cpumask only if its NULL. ^^

Re: [PATCH v2 1/2] powerpc/perf/hv-24x7: Add cpu hotplug support

2020-06-24 Thread kajoljain
On 6/24/20 4:06 PM, Gautham R Shenoy wrote: > On Wed, Jun 24, 2020 at 03:47:53PM +0530, Kajol Jain wrote: >> Patch here adds cpu hotplug functions to hv_24x7 pmu. >> A new cpuhp_state "CPUHP_AP_PERF_POWERPC_HV_24x7_ONLINE" enum >> is added. >> >> The online function update the cpumask only if it

Re: [PATCH v2 2/2] powerpc/hv-24x7: Add sysfs files inside hv-24x7 device to show cpumask

2020-06-24 Thread Gautham R Shenoy
Hi Kajol, On Wed, Jun 24, 2020 at 03:47:54PM +0530, Kajol Jain wrote: > Patch here adds a cpumask attr to hv_24x7 pmu along with ABI documentation. > > command:# cat /sys/devices/hv_24x7/cpumask > 0 Since this sysfs interface is read-only, and the user cannot change the CPU which will be making

[PATCH v2 0/6] consolidate PowerPC instruction encoding macros

2020-06-24 Thread Balamuruhan S
ppc-opcode.h have base instruction encoding wrapped with stringify_in_c() for raw encoding to have compatibility. But there are redundant macros for base instruction encodings in bpf, instruction emulation test infrastructure and powerpc selftests. Currently PPC_INST_* macros are used for encoding

[PATCH v2 1/6] powerpc/ppc-opcode: introduce PPC_RAW_* macros for base instruction encoding

2020-06-24 Thread Balamuruhan S
Introduce PPC_RAW_* macros to have all the bare encoding of ppc instructions. Move `VSX_XX*()` and `TMRN()` macros up to reuse it. Signed-off-by: Balamuruhan S Acked-by: Naveen N. Rao Tested-by: Naveen N. Rao --- arch/powerpc/include/asm/ppc-opcode.h | 90 --- 1 file ch

[PATCH v2 2/6] powerpc/ppc-opcode: move ppc instruction encoding from test_emulate_step

2020-06-24 Thread Balamuruhan S
Few ppc instructions are encoded in test_emulate_step.c, consolidate them and use it from ppc-opcode.h Signed-off-by: Balamuruhan S Acked-by: Naveen N. Rao Tested-by: Naveen N. Rao Acked-by: Sandipan Das --- arch/powerpc/include/asm/ppc-opcode.h | 18 +++ arch/powerpc/lib/test_emulate_step.c

Re: [PATCH V3 0/4] mm/debug_vm_pgtable: Add some more tests

2020-06-24 Thread Gerald Schaefer
On Wed, 24 Jun 2020 13:05:39 +0200 Alexander Gordeev wrote: > On Wed, Jun 24, 2020 at 08:43:10AM +0530, Anshuman Khandual wrote: > > [...] > > > Hello Gerald/Christophe/Vineet, > > > > It would be really great if you could give this series a quick test > > on s390/ppc/arc platforms respectivel

Re: [PATCH v2 2/2] powerpc/hv-24x7: Add sysfs files inside hv-24x7 device to show cpumask

2020-06-24 Thread Madhavan Srinivasan
On 6/24/20 4:26 PM, Gautham R Shenoy wrote: Hi Kajol, On Wed, Jun 24, 2020 at 03:47:54PM +0530, Kajol Jain wrote: Patch here adds a cpumask attr to hv_24x7 pmu along with ABI documentation. command:# cat /sys/devices/hv_24x7/cpumask 0 Since this sysfs interface is read-only, and the user c

Re: [PATCH v2 2/2] cpufreq: Specify default governor on command line

2020-06-24 Thread Rafael J. Wysocki
On Wed, Jun 24, 2020 at 7:50 AM Viresh Kumar wrote: > > On 23-06-20, 15:21, Quentin Perret wrote: > > Currently, the only way to specify the default CPUfreq governor is via > > Kconfig options, which suits users who can build the kernel themselves > > perfectly. > > > > However, for those who use

Re: [PATCH 2/2] powerpc/papr_scm: Add support for fetching nvdimm 'fuel-gauge' metric

2020-06-24 Thread Vaibhav Jain
Thanks for reviewing this patch Ira, My responses below: Ira Weiny writes: [snip] >> +static int papr_pdsm_fuel_gauge(struct papr_scm_priv *p, >> +union nd_pdsm_payload *payload) >> +{ >> +int rc, size; >> +struct papr_scm_perf_stat *stat; >> +struct papr

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-24 Thread Peter Zijlstra
On Wed, Jun 24, 2020 at 01:32:46PM +0200, Marco Elver wrote: > From: Marco Elver > Date: Wed, 24 Jun 2020 11:23:22 +0200 > Subject: [PATCH] kcsan: Make KCSAN compatible with new IRQ state tracking > > The new IRQ state tracking code does not honor lockdep_off(), and as > such we should again perm

Re: [PATCH 1/2] ASoC: fsl-asoc-card: Add WM8524 support

2020-06-24 Thread Mark Brown
On Tue, 23 Jun 2020 14:52:46 +0800, Shengjiu Wang wrote: > WM8524 only supports playback mode, and only works at > slave mode. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: fsl-asoc-card: Add WM8524 support commit: 3cd99026740

Re: [PATCH 1/2] powerpc/papr_scm: Fetch nvdimm performance stats from PHYP

2020-06-24 Thread Ira Weiny
On Wed, Jun 24, 2020 at 08:28:57PM +0530, Vaibhav Jain wrote: > Thanks for reviewing this patch Ira, > > My responses below inline. > > Ira Weiny writes: > > > On Mon, Jun 22, 2020 at 09:54:50AM +0530, Vaibhav Jain wrote: > >> Update papr_scm.c to query dimm performance statistics from PHYP via

Re: FSL P5020/P5040: DPAA Ethernet issue with the latest Git kernel

2020-06-24 Thread Alexander Gordeev
On Sun, Jun 21, 2020 at 08:40:14AM +0200, Christian Zigotzky wrote: > Hello Alexander, > > The DPAA Ethernet doesn’t work anymore on our FSL P5020/P5040 boards [1] > since the RC1 of kernel 5.8 [2]. > We bisected last days [3] and found the problematic commit [4]. I was able to > revert it [5].

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

2020-06-24 Thread Geoff Levand
Hi Nathan, On 6/23/20 8:59 PM, Nathan Chancellor wrote: > These are not true arrays, they are linker defined symbols, which are > just addresses. Using the address of operator silences the warning > and does not change the resulting assembly with either clang/ld.lld > or gcc/ld (tested with diff

[PATCH v2 0/4] powerpc/mm/radix: Memory unplug fixes

2020-06-24 Thread Aneesh Kumar K.V
This is the next version of the fixes for memory unplug on radix. The issues and the fix are described in the actual patches. Changes from v1: - Added back patch to drop split_kernel_mapping - Most of the split_kernel_mapping related issues are now described in the removal patch - drop pte fragm

[PATCH v2 1/4] powerpc/mm/radix: Fix PTE/PMD fragment count for early page table mappings

2020-06-24 Thread Aneesh Kumar K.V
We can hit the following BUG_ON during memory unplug: kernel BUG at arch/powerpc/mm/book3s64/pgtable.c:342! Oops: Exception in kernel mode, sig: 5 [#1] LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA pSeries NIP [c0093308] pmd_fragment_free+0x48/0xc0 LR [c147bfec] remove_pagetable

[PATCH v2 3/4] powerpc/mm/radix: Remove split_kernel_mapping()

2020-06-24 Thread Aneesh Kumar K.V
From: Bharata B Rao We split the page table mapping on memory unplug if the linear range was mapped with huge page mapping (for ex: 1G) The page table splitting code has a few issues: 1. Recursive locking Memory unplug path takes cpu_hotplug_lock and calls stop_machine() for

[PATCH v2 4/4] powerpc/mm/radix: Create separate mappings for hot-plugged memory

2020-06-24 Thread Aneesh Kumar K.V
To enable memory unplug without splitting kernel page table mapping, we force the max mapping size to the LMB size. LMB size is the unit in which hypervisor will do memory add/remove operation. This implies on pseries system, we now end up mapping memory with 2M page size instead of 1G. To improve