Re: [RFC PATCH 1/2] KVM: PPC: Use the ppc_inst type

2020-09-02 Thread Jordan Niethe
On Wed, Sep 2, 2020 at 4:18 PM Paul Mackerras wrote: > > On Thu, Aug 20, 2020 at 01:39:21PM +1000, Jordan Niethe wrote: > > The ppc_inst type was added to help cope with the addition of prefixed > > instructions to the ISA. Convert KVM to use this new type for dealing > > wiht instructions. For

Re: [PATCH 0/2] dma-mapping: update default segment_boundary_mask

2020-09-02 Thread Niklas Schnelle
On 9/2/20 12:16 AM, Nicolin Chen wrote: > These two patches are to update default segment_boundary_mask. > > PATCH-1 fixes overflow issues in callers of dma_get_seg_boundary. > Previous version was a series: https://lkml.org/lkml/2020/8/31/1026 > > Then PATCH-2 sets default

Re: ptrace_syscall_32 is failing

2020-09-02 Thread Thomas Gleixner
On Tue, Sep 01 2020 at 17:09, Andy Lutomirski wrote: > On Tue, Sep 1, 2020 at 4:50 PM Thomas Gleixner wrote: >> > I think that they almost work for x86, but not quite as >> > indicated by this bug. Even if we imagine we can somehow hack around >> > this bug, I imagine we're going to find other

Re: [PATCH 2/2] powerpc/vdso32: link vdso64 with linker

2020-09-02 Thread Christophe Leroy
On 9/1/20 10:25 PM, Nick Desaulniers wrote: Rather than invoke the compiler as the driver, use the linker. That way we can check --orphan-handling=warn support correctly, as cc-ldoption was removed in commit 055efab3120b ("kbuild: drop support for cc-ldoption"). Requires dropping the .got

Re: [PATCH 05/10] lkdtm: disable set_fs-based tests for !CONFIG_SET_FS

2020-09-02 Thread Christoph Hellwig
On Tue, Sep 01, 2020 at 11:57:37AM -0700, Kees Cook wrote: > On Sat, Aug 29, 2020 at 11:24:06AM +0200, Christoph Hellwig wrote: > > On Thu, Aug 27, 2020 at 11:06:28AM -0700, Linus Torvalds wrote: > > > On Thu, Aug 27, 2020 at 8:00 AM Christoph Hellwig wrote: > > > > > > > > Once we can't

Re: [PATCH] powerpc: Fix random segfault when freeing hugetlb range

2020-09-02 Thread Christophe Leroy
Le 02/09/2020 à 05:23, Aneesh Kumar K.V a écrit : Christophe Leroy writes: The following random segfault is observed from time to time with map_hugetlb selftest: root@localhost:~# ./map_hugetlb 1 19 524288 kB hugepages Mapping 1 Mbytes Segmentation fault [ 31.219972] map_hugetlb[365]:

[PATCH] mm: check for memory's node later during boot

2020-09-02 Thread Laurent Dufour
register_mem_sect_under_nodem() is checking the memory block's node id only if the system state is "SYSTEM_BOOTING". On PowerPC, the memory blocks are registered while the system state is "SYSTEM_SCHEDULING", the one before SYSTEM_RUNNING. The consequence on PowerPC guest with interleaved memory

Re: [RFC PATCH 1/2] KVM: PPC: Use the ppc_inst type

2020-09-02 Thread Paul Mackerras
On Wed, Sep 02, 2020 at 06:00:24PM +1000, Jordan Niethe wrote: > On Wed, Sep 2, 2020 at 4:18 PM Paul Mackerras wrote: > > > > On Thu, Aug 20, 2020 at 01:39:21PM +1000, Jordan Niethe wrote: > > > The ppc_inst type was added to help cope with the addition of prefixed > > > instructions to the ISA.

Re: remove the last set_fs() in common code, and remove it for x86 and powerpc v2

2020-09-02 Thread Christoph Hellwig
On Tue, Sep 01, 2020 at 06:25:12PM +0100, Al Viro wrote: > On Tue, Sep 01, 2020 at 07:13:00PM +0200, Christophe Leroy wrote: > > > 10.92% dd [kernel.kallsyms] [k] iov_iter_zero > > Interesting... Could you get an instruction-level profile inside > iov_iter_zero(), > along with the

Re: [PATCH] cpuidle-pseries: Fix CEDE latency conversion from tb to us

2020-09-02 Thread Gautham R Shenoy
Hello Joel, On Wed, Sep 02, 2020 at 01:08:35AM +, Joel Stanley wrote: > On Tue, 1 Sep 2020 at 14:09, Gautham R. Shenoy > wrote: > > > > From: "Gautham R. Shenoy" > > > > commit d947fb4c965c ("cpuidle: pseries: Fixup exit latency for > > CEDE(0)") sets the exit latency of CEDE(0) based on

Re: [PATCH 4/4] powerpc/64s/radix: Fix mm_cpumask trimming race vs kthread_use_mm

2020-09-02 Thread Nicholas Piggin
Excerpts from Michael Ellerman's message of September 1, 2020 10:00 pm: > Nicholas Piggin writes: >> Commit 0cef77c7798a7 ("powerpc/64s/radix: flush remote CPUs out of >> single-threaded mm_cpumask") added a mechanism to trim the mm_cpumask of >> a process under certain conditions. One of the

Re: [PATCH] powerpc: Fix random segfault when freeing hugetlb range

2020-09-02 Thread Aneesh Kumar K.V
On 9/2/20 1:41 PM, Christophe Leroy wrote: Le 02/09/2020 à 05:23, Aneesh Kumar K.V a écrit : Christophe Leroy writes: The following random segfault is observed from time to time with map_hugetlb selftest: root@localhost:~# ./map_hugetlb 1 19 524288 kB hugepages Mapping 1 Mbytes

Re: [RFC PATCH 2/2] KVM: PPC: Book3S HV: Support prefixed instructions

2020-09-02 Thread Jordan Niethe
On Wed, Sep 2, 2020 at 4:18 PM Paul Mackerras wrote: > > On Thu, Aug 20, 2020 at 01:39:22PM +1000, Jordan Niethe wrote: > > There are two main places where instructions are loaded from the guest: > > * Emulate loadstore - such as when performing MMIO emulation > > triggered by an HDSI >

[Bug 209029] kernel 5.9-rc2 fails to boot on a PowerMac G5 11,2 - BUG: Kernel NULL pointer dereference on read at 0x00000020

2020-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209029 --- Comment #4 from Erhard F. (erhar...@mailbox.org) --- (In reply to Christophe Leroy from comment #3) > Did you try without CONFIG_DEBUG_VM_PGTABLE ? Without CONFIG_DEBUG_VM_PGTABLE the G5 boots fine. Thanks! > If you want

Re: [PATCH 2/2] powerpc/vdso32: link vdso64 with linker

2020-09-02 Thread Christophe Leroy
On 9/1/20 10:25 PM, Nick Desaulniers wrote: Rather than invoke the compiler as the driver, use the linker. That way we can check --orphan-handling=warn support correctly, as cc-ldoption was removed in commit 055efab3120b ("kbuild: drop support for cc-ldoption"). Requires dropping the .got

Re: [PATCH 10/10] powerpc: remove address space overrides using set_fs()

2020-09-02 Thread Christophe Leroy
Le 27/08/2020 à 17:00, Christoph Hellwig a écrit : Stop providing the possibility to override the address space using set_fs() now that there is no need for that any more. Signed-off-by: Christoph Hellwig --- arch/powerpc/Kconfig | 1 -

Re: [RFC PATCH 2/2] KVM: PPC: Book3S HV: Support prefixed instructions

2020-09-02 Thread Paul Mackerras
On Thu, Aug 20, 2020 at 01:39:22PM +1000, Jordan Niethe wrote: > There are two main places where instructions are loaded from the guest: > * Emulate loadstore - such as when performing MMIO emulation > triggered by an HDSI > * After an HV emulation assistance interrupt (e40) > > If

Re: [RFC PATCH 1/2] KVM: PPC: Use the ppc_inst type

2020-09-02 Thread Paul Mackerras
On Thu, Aug 20, 2020 at 01:39:21PM +1000, Jordan Niethe wrote: > The ppc_inst type was added to help cope with the addition of prefixed > instructions to the ISA. Convert KVM to use this new type for dealing > wiht instructions. For now do not try to add further support for > prefixed

Re: [PATCH v1 09/10] powerpc/pseries/iommu: Make use of DDW even if it does not map the partition

2020-09-02 Thread Leonardo Bras
On Mon, 2020-08-31 at 14:35 +1000, Alexey Kardashevskiy wrote: > > On 29/08/2020 04:36, Leonardo Bras wrote: > > On Mon, 2020-08-24 at 15:17 +1000, Alexey Kardashevskiy wrote: > > > On 18/08/2020 09:40, Leonardo Bras wrote: > > > > As of today, if the biggest DDW that can be created can't map the

Re: [PATCH 2/2] powerpc/vdso32: link vdso64 with linker

2020-09-02 Thread Christophe Leroy
On 09/01/2020 10:25 PM, Nick Desaulniers wrote: Rather than invoke the compiler as the driver, use the linker. That way we can check --orphan-handling=warn support correctly, as cc-ldoption was removed in commit 055efab3120b ("kbuild: drop support for cc-ldoption"). Requires dropping the

Re: [PATCH 2/2] powerpc/vdso32: link vdso64 with linker

2020-09-02 Thread Segher Boessenkool
On Wed, Sep 02, 2020 at 05:43:03PM +0200, Christophe Leroy wrote: > >Try with a newer ld? If it still happens with current versions, please > >open a bug report? https://sourceware.org/bugzilla > > Yes it works with 2.30 and 2.34 Ah okay, I missed this part. > But minimum for building kernel

Re: [PATCH v3 12/13] mm/debug_vm_pgtable/hugetlb: Disable hugetlb test on ppc64

2020-09-02 Thread Anshuman Khandual
On 09/01/2020 12:00 PM, Aneesh Kumar K.V wrote: > On 9/1/20 9:33 AM, Anshuman Khandual wrote: >> >> >> On 08/27/2020 01:34 PM, Aneesh Kumar K.V wrote: >>> The seems to be missing quite a lot of details w.r.t allocating >>> the correct pgtable_t page (huge_pte_alloc()), holding the right >>>

Re: [PATCH v3 12/13] mm/debug_vm_pgtable/hugetlb: Disable hugetlb test on ppc64

2020-09-02 Thread Aneesh Kumar K.V
Anshuman Khandual writes: > On 09/01/2020 12:00 PM, Aneesh Kumar K.V wrote: >> On 9/1/20 9:33 AM, Anshuman Khandual wrote: >>> >>> >>> On 08/27/2020 01:34 PM, Aneesh Kumar K.V wrote: The seems to be missing quite a lot of details w.r.t allocating the correct pgtable_t page

Re: [PATCH 10/10] powerpc: remove address space overrides using set_fs()

2020-09-02 Thread Christophe Leroy
Le 02/09/2020 à 15:51, David Laight a écrit : From: Christophe Leroy Sent: 02 September 2020 14:25 Le 02/09/2020 à 15:13, David Laight a écrit : From: Christoph Hellwig Sent: 02 September 2020 13:37 On Wed, Sep 02, 2020 at 08:15:12AM +0200, Christophe Leroy wrote: - return

[Bug 206203] kmemleak reports various leaks in drivers/of/unittest.c

2020-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206203 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #288185|0 |1 is obsolete|

Re: [PATCH 2/2] powerpc/vdso32: link vdso64 with linker

2020-09-02 Thread Christophe Leroy
Hi, Le 02/09/2020 à 16:14, Segher Boessenkool a écrit : Hi! On Wed, Sep 02, 2020 at 06:46:45AM +, Christophe Leroy wrote: ld crashes: LD arch/powerpc/kernel/vdso32/vdso32.so.dbg /bin/sh: line 1: 23780 Segmentation fault (core dumped) ppc-linux-ld -EB -m elf32ppc -shared

Re: ptrace_syscall_32 is failing

2020-09-02 Thread Andy Lutomirski
On Wed, Sep 2, 2020 at 1:29 AM Thomas Gleixner wrote: > > On Tue, Sep 01 2020 at 17:09, Andy Lutomirski wrote: > > On Tue, Sep 1, 2020 at 4:50 PM Thomas Gleixner wrote: > >> > I think that they almost work for x86, but not quite as > >> > indicated by this bug. Even if we imagine we can somehow

Re: [PATCH 1/2] powerpc/vdso64: link vdso64 with linker

2020-09-02 Thread Christophe Leroy
Le 02/09/2020 à 19:41, Nick Desaulniers a écrit : On Wed, Sep 2, 2020 at 5:14 AM Michael Ellerman wrote: Nick Desaulniers writes: Fixes: commit f2af201002a8 ("powerpc/build: vdso linker warning for orphan sections") I think I'll just revert that for v5.9 ? SGTM; you'll probably

Re: [PATCH 10/10] powerpc: remove address space overrides using set_fs()

2020-09-02 Thread Linus Torvalds
On Wed, Sep 2, 2020 at 8:17 AM Christophe Leroy wrote: > > > With this fix, I get > > root@vgoippro:~# time dd if=/dev/zero of=/dev/null count=1M > 536870912 bytes (512.0MB) copied, 6.776327 seconds, 75.6MB/s > > That's still far from the 91.7MB/s I get with 5.9-rc2, but better than > the

[PATCH v4 03/13] mm/debug_vm_pgtable/ppc64: Avoid setting top bits in radom value

2020-09-02 Thread Aneesh Kumar K.V
ppc64 use bit 62 to indicate a pte entry (_PAGE_PTE). Avoid setting that bit in random value. Signed-off-by: Aneesh Kumar K.V --- mm/debug_vm_pgtable.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index

[PATCH v4 02/13] powerpc/mm: Move setting pte specific flags to pfn_pte

2020-09-02 Thread Aneesh Kumar K.V
powerpc used to set the pte specific flags in set_pte_at(). This is different from other architectures. To be consistent with other architecture update pfn_pte to set _PAGE_PTE on ppc64. Also, drop now unused pte_mkpte. We add a VM_WARN_ON() to catch the usage of calling set_pte_at() without

[PATCH v4 01/13] powerpc/mm: Add DEBUG_VM WARN for pmd_clear

2020-09-02 Thread Aneesh Kumar K.V
With the hash page table, the kernel should not use pmd_clear for clearing huge pte entries. Add a DEBUG_VM WARN to catch the wrong usage. Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/include/asm/book3s/64/pgtable.h | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH v4 09/13] mm/debug_vm_pgtable/locks: Take correct page table lock

2020-09-02 Thread Aneesh Kumar K.V
Make sure we call pte accessors with correct lock held. Signed-off-by: Aneesh Kumar K.V --- mm/debug_vm_pgtable.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index

Re: [PATCH 10/10] powerpc: remove address space overrides using set_fs()

2020-09-02 Thread Christophe Leroy
Le 02/09/2020 à 15:13, David Laight a écrit : From: Christoph Hellwig Sent: 02 September 2020 13:37 On Wed, Sep 02, 2020 at 08:15:12AM +0200, Christophe Leroy wrote: - return 0; - return (size == 0 || size - 1 <= seg.seg - addr); + if (addr >= TASK_SIZE_MAX) +

[PATCH v4 13/13] mm/debug_vm_pgtable: Avoid none pte in pte_clear_test

2020-09-02 Thread Aneesh Kumar K.V
pte_clear_tests operate on an existing pte entry. Make sure that is not a none pte entry. Signed-off-by: Aneesh Kumar K.V --- mm/debug_vm_pgtable.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index

Re: [PATCH 2/2] powerpc/vdso32: link vdso64 with linker

2020-09-02 Thread Segher Boessenkool
Hi! On Wed, Sep 02, 2020 at 06:46:45AM +, Christophe Leroy wrote: > ld crashes: > > LD arch/powerpc/kernel/vdso32/vdso32.so.dbg > /bin/sh: line 1: 23780 Segmentation fault (core dumped) > ppc-linux-ld -EB -m elf32ppc -shared -soname linux-vdso32.so.1 > --eh-frame-hdr

Re: [PATCH 10/10] powerpc: remove address space overrides using set_fs()

2020-09-02 Thread Christophe Leroy
Le 02/09/2020 à 14:36, Christoph Hellwig a écrit : On Wed, Sep 02, 2020 at 08:15:12AM +0200, Christophe Leroy wrote: - return 0; - return (size == 0 || size - 1 <= seg.seg - addr); + if (addr >= TASK_SIZE_MAX) + return false; + if (size == 0) +

[PATCH v4 04/13] mm/debug_vm_pgtables/hugevmap: Use the arch helper to identify huge vmap support.

2020-09-02 Thread Aneesh Kumar K.V
ppc64 supports huge vmap only with radix translation. Hence use arch helper to determine the huge vmap support. Signed-off-by: Aneesh Kumar K.V --- mm/debug_vm_pgtable.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/mm/debug_vm_pgtable.c

[PATCH v4 12/13] mm/debug_vm_pgtable/hugetlb: Disable hugetlb test on ppc64

2020-09-02 Thread Aneesh Kumar K.V
The seems to be missing quite a lot of details w.r.t allocating the correct pgtable_t page (huge_pte_alloc()), holding the right lock (huge_pte_lock()) etc. The vma used is also not a hugetlb VMA. ppc64 do have runtime checks within CONFIG_DEBUG_VM for most of these. Hence disable the test on

[Bug 206203] kmemleak reports various leaks in drivers/of/unittest.c

2020-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206203 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #288187|0 |1 is obsolete|

[PATCH v4 08/13] mm/debug_vm_pgtable/locks: Move non page table modifying test together

2020-09-02 Thread Aneesh Kumar K.V
This will help in adding proper locks in a later patch Signed-off-by: Aneesh Kumar K.V --- mm/debug_vm_pgtable.c | 51 --- 1 file changed, 28 insertions(+), 23 deletions(-) diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index

[PATCH v4 07/13] mm/debug_vm_pgtable/set_pte/pmd/pud: Don't use set_*_at to update an existing pte entry

2020-09-02 Thread Aneesh Kumar K.V
set_pte_at() should not be used to set a pte entry at locations that already holds a valid pte entry. Architectures like ppc64 don't do TLB invalidate in set_pte_at() and hence expect it to be used to set locations that are not a valid PTE. Signed-off-by: Aneesh Kumar K.V ---

[PATCH v4 11/13] mm/debug_vm_pgtable/pmd_clear: Don't use pmd/pud_clear on pte entries

2020-09-02 Thread Aneesh Kumar K.V
pmd_clear() should not be used to clear pmd level pte entries. Signed-off-by: Aneesh Kumar K.V --- mm/debug_vm_pgtable.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index 26023d990bd0..b53903fdee85 100644 ---

Re: [PATCH 10/10] powerpc: remove address space overrides using set_fs()

2020-09-02 Thread Christoph Hellwig
On Wed, Sep 02, 2020 at 08:15:12AM +0200, Christophe Leroy wrote: >> -return 0; >> -return (size == 0 || size - 1 <= seg.seg - addr); >> +if (addr >= TASK_SIZE_MAX) >> +return false; >> +if (size == 0) >> +return false; > > __access_ok() was

RE: [PATCH 10/10] powerpc: remove address space overrides using set_fs()

2020-09-02 Thread David Laight
From: Christophe Leroy > Sent: 02 September 2020 14:25 > Le 02/09/2020 à 15:13, David Laight a écrit : > > From: Christoph Hellwig > >> Sent: 02 September 2020 13:37 > >> > >> On Wed, Sep 02, 2020 at 08:15:12AM +0200, Christophe Leroy wrote: > -return 0; > -return

[PATCH v4 06/13] mm/debug_vm_pgtable/THP: Mark the pte entry huge before using set_pmd/pud_at

2020-09-02 Thread Aneesh Kumar K.V
kernel expects entries to be marked huge before we use set_pmd_at()/set_pud_at(). Signed-off-by: Aneesh Kumar K.V --- mm/debug_vm_pgtable.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index

[PATCH v4 05/13] mm/debug_vm_pgtable/savedwrite: Enable savedwrite test with CONFIG_NUMA_BALANCING

2020-09-02 Thread Aneesh Kumar K.V
Saved write support was added to track the write bit of a pte after marking the pte protnone. This was done so that AUTONUMA can convert a write pte to protnone and still track the old write bit. When converting it back we set the pte write bit correctly thereby avoiding a write fault again. Hence

Re: [PATCH 1/2] powerpc/vdso64: link vdso64 with linker

2020-09-02 Thread Michael Ellerman
Nick Desaulniers writes: > Rather than invoke the compiler as the driver, use the linker. That way > we can check --orphan-handling=warn support correctly, as cc-ldoption > was removed in > commit 055efab3120b ("kbuild: drop support for cc-ldoption"). Ouch. Seems make is quite happy to $(call

Re: [PATCH v4 02/13] powerpc/mm: Move setting pte specific flags to pfn_pte

2020-09-02 Thread Christophe Leroy
Le 02/09/2020 à 13:42, Aneesh Kumar K.V a écrit : powerpc used to set the pte specific flags in set_pte_at(). This is different from other architectures. To be consistent with other architecture update pfn_pte to set _PAGE_PTE on ppc64. Also, drop now unused pte_mkpte. We add a VM_WARN_ON()

RE: [PATCH 10/10] powerpc: remove address space overrides using set_fs()

2020-09-02 Thread David Laight
From: Christoph Hellwig > Sent: 02 September 2020 13:37 > > On Wed, Sep 02, 2020 at 08:15:12AM +0200, Christophe Leroy wrote: > >> - return 0; > >> - return (size == 0 || size - 1 <= seg.seg - addr); > >> + if (addr >= TASK_SIZE_MAX) > >> + return false; > >> + if (size == 0)

[Bug 206203] kmemleak reports various leaks in drivers/of/unittest.c

2020-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206203 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #288189|0 |1 is obsolete|

[PATCH v4 00/13] mm/debug_vm_pgtable fixes

2020-09-02 Thread Aneesh Kumar K.V
This patch series includes fixes for debug_vm_pgtable test code so that they follow page table updates rules correctly. The first two patches introduce changes w.r.t ppc64. The patches are included in this series for completeness. We can merge them via ppc64 tree if required. Hugetlb test is

[PATCH v4 10/13] mm/debug_vm_pgtable/thp: Use page table depost/withdraw with THP

2020-09-02 Thread Aneesh Kumar K.V
Architectures like ppc64 use deposited page table while updating the huge pte entries. Signed-off-by: Aneesh Kumar K.V --- mm/debug_vm_pgtable.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index

[PATCH v4 13/13] mm/debug_vm_pgtable: Avoid none pte in pte_clear_test

2020-09-02 Thread Aneesh Kumar K.V
pte_clear_tests operate on an existing pte entry. Make sure that is not a none pte entry. Signed-off-by: Aneesh Kumar K.V --- mm/debug_vm_pgtable.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index

Re: [PATCH v4 04/13] mm/debug_vm_pgtables/hugevmap: Use the arch helper to identify huge vmap support.

2020-09-02 Thread Christophe Leroy
Le 02/09/2020 à 13:42, Aneesh Kumar K.V a écrit : ppc64 supports huge vmap only with radix translation. Hence use arch helper to determine the huge vmap support. Signed-off-by: Aneesh Kumar K.V --- mm/debug_vm_pgtable.c | 14 -- 1 file changed, 12 insertions(+), 2

Re: [PATCH v4 04/13] mm/debug_vm_pgtables/hugevmap: Use the arch helper to identify huge vmap support.

2020-09-02 Thread Aneesh Kumar K.V
On 9/2/20 6:10 PM, Christophe Leroy wrote: Le 02/09/2020 à 13:42, Aneesh Kumar K.V a écrit : ppc64 supports huge vmap only with radix translation. Hence use arch helper to determine the huge vmap support. Signed-off-by: Aneesh Kumar K.V ---   mm/debug_vm_pgtable.c | 14 --   1

RE: [PATCH 10/10] powerpc: remove address space overrides using set_fs()

2020-09-02 Thread David Laight
From: Christophe Leroy > Sent: 02 September 2020 15:13 > > > Le 02/09/2020 à 15:51, David Laight a écrit : > > From: Christophe Leroy > >> Sent: 02 September 2020 14:25 > >> Le 02/09/2020 à 15:13, David Laight a écrit : > >>> From: Christoph Hellwig > Sent: 02 September 2020 13:37 > >

Re: [PATCH] powerpc/64s: handle ISA v3.1 local copy-paste context switches

2020-09-02 Thread Paul Mackerras
On Tue, Aug 25, 2020 at 05:55:35PM +1000, Nicholas Piggin wrote: > The ISA v3.1 the copy-paste facility has a new memory move functionality > which allows the copy buffer to be pasted to domestic memory (RAM) as > opposed to foreign memory (accelerator). > > This means the POWER9 trick of

Re: [PATCH v2] scsi: ibmvfc: interface updates for future FPIN and MQ support

2020-09-02 Thread Martin K. Petersen
Tyrel, > Fixup complier errors from neglected commit --amend Bunch of formatting-related checkpatch warnings. Please fix. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode

2020-09-02 Thread Nicolin Chen
On Thu, Sep 03, 2020 at 11:09:15AM +0800, Shengjiu Wang wrote: > Transmit data pins will output zero when slots are masked or channels > are disabled. In CHMOD TDM mode, transmit data pins are tri-stated when > slots are masked or channels are disabled. When data pins are tri-stated, > there is

Re: [PATCH v1 01/10] powerpc/pseries/iommu: Replace hard-coded page shift

2020-09-02 Thread Alexey Kardashevskiy
On 02/09/2020 07:38, Leonardo Bras wrote: On Mon, 2020-08-31 at 13:48 +1000, Alexey Kardashevskiy wrote: Well, I created this TCE_RPN_BITS = 52 because the previous mask was a hardcoded 40-bit mask (0xfful), for hard-coded 12-bit (4k) pagesize, and on PAPR+/LoPAR also defines TCE as

Re: [PATCH v1 02/10] powerpc/kernel/iommu: Align size for IOMMU_PAGE_SIZE on iommu_*_coherent()

2020-09-02 Thread Alexey Kardashevskiy
On 02/09/2020 08:34, Leonardo Bras wrote: On Mon, 2020-08-31 at 10:47 +1000, Alexey Kardashevskiy wrote: Maybe testing with host 64k pagesize and IOMMU 16MB pagesize in qemu should be enough, is there any chance to get indirect mapping in qemu like this? (DDW but with smaller DMA window

Re: [PATCH 1/2] dma-mapping: introduce dma_get_seg_boundary_nr_pages()

2020-09-02 Thread Michael Ellerman
Nicolin Chen writes: > diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c > index 9704f3f76e63..cbc2e62db597 100644 > --- a/arch/powerpc/kernel/iommu.c > +++ b/arch/powerpc/kernel/iommu.c > @@ -236,15 +236,10 @@ static unsigned long iommu_range_alloc(struct device > *dev, >

Re: [PATCH 0/2] dma-mapping: update default segment_boundary_mask

2020-09-02 Thread Nicolin Chen
On Wed, Sep 02, 2020 at 10:13:12AM +0200, Niklas Schnelle wrote: > On 9/2/20 12:16 AM, Nicolin Chen wrote: > > These two patches are to update default segment_boundary_mask. > > > > PATCH-1 fixes overflow issues in callers of dma_get_seg_boundary. > > Previous version was a series:

Re: [PATCH v2] scsi: ibmvfc: interface updates for future FPIN and MQ support

2020-09-02 Thread Tyrel Datwyler
On 9/2/20 7:11 PM, Martin K. Petersen wrote: > > Tyrel, > >> Fixup complier errors from neglected commit --amend > > Bunch of formatting-related checkpatch warnings. Please fix. > > Thanks! > So, I stuck to the existing style already in that header. If I'm going to fixup to make