Re: [PATCH 7/9] docs: remove description of DISCONTIGMEM

2021-06-09 Thread David Hildenbrand
On 02.06.21 12:53, Mike Rapoport wrote: From: Mike Rapoport Remove description of DISCONTIGMEM from the "Memory Models" document and update VM sysctl description so that it won't mention DISCONIGMEM. Signed-off-by: Mike Rapoport --- Documentation/admin-guide/sysctl/vm.rst | 12 +++

Re: [PATCH 6/9] arch, mm: remove stale mentions of DISCONIGMEM

2021-06-09 Thread David Hildenbrand
On 02.06.21 12:53, Mike Rapoport wrote: From: Mike Rapoport There are several places that mention DISCONIGMEM in comments or have stale code guarded by CONFIG_DISCONTIGMEM. Remove the dead code and update the comments. Signed-off-by: Mike Rapoport --- arch/ia64/kernel/topology.c | 5

[PATCH] powerpc: Move update_power8_hid0() into its only user

2021-06-09 Thread Christophe Leroy
update_power8_hid0() is used only by powernv platform subcore.c Move it there. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/reg.h | 10 -- arch/powerpc/platforms/powernv/subcore.c | 10 ++ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git

Re: [PATCH 3/9] arc: remove support for DISCONTIGMEM

2021-06-09 Thread David Hildenbrand
On 02.06.21 12:53, Mike Rapoport wrote: From: Mike Rapoport DISCONTIGMEM was replaced by FLATMEM with freeing of the unused memory map in v5.11. Remove the support for DISCONTIGMEM entirely. Signed-off-by: Mike Rapoport Acked-by: David Hildenbrand -- Thanks, David / dhildenb

Re: [PATCH v2 3/3] powerpc/mm/hash: Avoid multiple HPT resize-downs on memory hotunplug

2021-06-09 Thread David Gibson
On Wed, Jun 09, 2021 at 02:30:36AM -0300, Leonardo Brás wrote: > On Mon, 2021-06-07 at 15:20 +1000, David Gibson wrote: > > On Fri, Apr 30, 2021 at 11:36:10AM -0300, Leonardo Bras wrote: > > > During memory hotunplug, after each LMB is removed, the HPT may be > > > resized-down if it would map a

Re: [PATCH] powerpc/bpf: Use bctrl for making function calls

2021-06-09 Thread Christophe Leroy
Le 09/06/2021 à 11:00, Naveen N. Rao a écrit : blrl corrupts the link stack. Instead use bctrl when making function calls from BPF programs. What's the link stack ? Is it the PPC64 branch predictor stack ? Reported-by: Anton Blanchard Signed-off-by: Naveen N. Rao ---

Re: [RFC] powerpc/pseries: Interface to represent PAPR firmware attributes

2021-06-09 Thread Pratik Sampat
Hello, Thank you for your comments on the design. On 09/06/21 3:43 am, Fabiano Rosas wrote: "Pratik R. Sampat" writes: Hi, I have some general comments and questions, mostly trying to understand design of the hcall and use cases of the sysfs data: Adds a generic interface to represent the

Re: [PATCH 9/9] mm: replace CONFIG_FLAT_NODE_MEM_MAP with CONFIG_FLATMEM

2021-06-09 Thread David Hildenbrand
On 02.06.21 12:53, Mike Rapoport wrote: From: Mike Rapoport After removal of the DISCONTIGMEM memory model the FLAT_NODE_MEM_MAP configuration option is equivalent to FLATMEM. Drop CONFIG_FLAT_NODE_MEM_MAP and use CONFIG_FLATMEM instead. Signed-off-by: Mike Rapoport ---

Re: [PATCH v2 1/3] powerpc/mm/hash: Avoid resizing-down HPT on first memory hotplug

2021-06-09 Thread David Gibson
On Wed, Jun 09, 2021 at 02:51:49AM -0300, Leonardo Brás wrote: > On Wed, 2021-06-09 at 14:40 +1000, David Gibson wrote: > > On Tue, Jun 08, 2021 at 09:52:10PM -0300, Leonardo Brás wrote: > > > On Mon, 2021-06-07 at 15:02 +1000, David Gibson wrote: > > > > On Fri, Apr 30, 2021 at 11:36:06AM -0300,

Re: [PATCH 5/9] mm: remove CONFIG_DISCONTIGMEM

2021-06-09 Thread David Hildenbrand
On 02.06.21 12:53, Mike Rapoport wrote: From: Mike Rapoport There are no architectures that support DISCONTIGMEM left. Remove the configuration option and the dead code it was guarding in the generic memory management code. Signed-off-by: Mike Rapoport ---

Re: [PATCH 8/9] mm: replace CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA

2021-06-09 Thread David Hildenbrand
On 02.06.21 12:53, Mike Rapoport wrote: From: Mike Rapoport After removal of DISCINTIGMEM the NEED_MULTIPLE_NODES and NUMA configuration options are equivalent. Drop CONFIG_NEED_MULTIPLE_NODES and use CONFIG_NUMA instead. Done with $ sed -i

[PATCH] powerpc/bpf: Use bctrl for making function calls

2021-06-09 Thread Naveen N. Rao
blrl corrupts the link stack. Instead use bctrl when making function calls from BPF programs. Reported-by: Anton Blanchard Signed-off-by: Naveen N. Rao --- arch/powerpc/include/asm/ppc-opcode.h | 1 + arch/powerpc/net/bpf_jit_comp32.c | 4 ++-- arch/powerpc/net/bpf_jit_comp64.c | 12

Re: [PATCH 04/16] bvec: add a bvec_kmap_local helper

2021-06-09 Thread Ilya Dryomov
On Tue, Jun 8, 2021 at 6:06 PM Christoph Hellwig wrote: > > Add a helper to call kmap_local_page on a bvec. There is no need for > an unmap helper given that kunmap_local accept any address in the mapped > page. > > Signed-off-by: Christoph Hellwig > --- > include/linux/bvec.h | 6 ++ > 1

Re: [PATCH v1 05/12] mm/memory_hotplug: remove nid parameter from remove_memory() and friends

2021-06-09 Thread David Hildenbrand
On 08.06.21 13:18, David Hildenbrand wrote: On 08.06.21 13:11, Michael Ellerman wrote: David Hildenbrand writes: There is only a single user remaining. We can simply try to offline all online nodes - which is fast, because we usually span pages and can skip such nodes right away. That makes

Re: [PATCH 2/9] arc: update comment about HIGHMEM implementation

2021-06-09 Thread David Hildenbrand
On 02.06.21 12:53, Mike Rapoport wrote: From: Mike Rapoport Arc does not use DISCONTIGMEM to implement high memory, update the comment describing how high memory works to reflect this. Signed-off-by: Mike Rapoport --- arch/arc/mm/init.c | 13 + 1 file changed, 5 insertions(+),

Re: [PATCH v3 8/9] mm: replace CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA

2021-06-09 Thread Mike Rapoport
On Tue, Jun 08, 2021 at 05:25:44PM -0700, Andrew Morton wrote: > On Tue, 8 Jun 2021 12:13:15 +0300 Mike Rapoport wrote: > > > From: Mike Rapoport > > > > After removal of DISCINTIGMEM the NEED_MULTIPLE_NODES and NUMA > > configuration options are equivalent. > > > > Drop

Re: [PATCH v1 1/1] powerpc/prom_init: Move custom isspace() to its own namespace

2021-06-09 Thread Michael Ellerman
Andy Shevchenko writes: > On Mon, May 10, 2021 at 05:49:25PM +0300, Andy Shevchenko wrote: >> If by some reason any of the headers will include ctype.h >> we will have a name collision. Avoid this by moving isspace() >> to the dedicate namespace. >> >> First appearance of the code is in the

Re: [PATCH 07/16] rbd: use memzero_bvec

2021-06-09 Thread Ilya Dryomov
On Tue, Jun 8, 2021 at 6:06 PM Christoph Hellwig wrote: > > Use memzero_bvec instead of reimplementing it. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/rbd.c | 15 ++- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/block/rbd.c

Re: [PATCH 1/9] alpha: remove DISCONTIGMEM and NUMA

2021-06-09 Thread David Hildenbrand
On 02.06.21 12:53, Mike Rapoport wrote: From: Mike Rapoport NUMA is marked broken on alpha for more than 15 years and DISCONTIGMEM was replaced with SPARSEMEM in v5.11. Remove both NUMA and DISCONTIGMEM support from alpha. Signed-off-by: Mike Rapoport --- arch/alpha/Kconfig

Re: [PATCH v2 0/9] Remove DISCINTIGMEM memory model

2021-06-09 Thread Arnd Bergmann
On Fri, Jun 4, 2021 at 8:49 AM Mike Rapoport wrote: > > From: Mike Rapoport > > Hi, > > SPARSEMEM memory model was supposed to entirely replace DISCONTIGMEM a > (long) while ago. The last architectures that used DISCONTIGMEM were > updated to use other memory models in v5.11 and it is about the

Re: [PATCH] powerpc/bpf: Use bctrl for making function calls

2021-06-09 Thread Naveen N. Rao
Christophe Leroy wrote: Le 09/06/2021 à 11:00, Naveen N. Rao a écrit : blrl corrupts the link stack. Instead use bctrl when making function calls from BPF programs. What's the link stack ? Is it the PPC64 branch predictor stack ? c974809a26a13e ("powerpc/vdso: Avoid link stack corruption

Re: [PATCH 2/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats

2021-06-09 Thread kajoljain
On 6/8/21 11:06 PM, Peter Zijlstra wrote: > On Tue, Jun 08, 2021 at 05:26:58PM +0530, Kajol Jain wrote: >> +static int nvdimm_pmu_cpu_offline(unsigned int cpu, struct hlist_node *node) >> +{ >> +struct nvdimm_pmu *nd_pmu; >> +u32 target; >> +int nodeid; >> +const struct cpumask

Re: [PATCH v2 0/9] Remove DISCINTIGMEM memory model

2021-06-09 Thread Mike Rapoport
Hi Arnd, On Wed, Jun 09, 2021 at 01:30:39PM +0200, Arnd Bergmann wrote: > On Fri, Jun 4, 2021 at 8:49 AM Mike Rapoport wrote: > > > > From: Mike Rapoport > > > > Hi, > > > > SPARSEMEM memory model was supposed to entirely replace DISCONTIGMEM a > > (long) while ago. The last architectures that

[PATCH] ASoC:fsl_spdif:Remove superfluous error message around platform_get_irq()

2021-06-09 Thread  Zhongjun Tan
From: Tan Zhongjun The platform_get_irq() prints error message telling that interrupt is missing, hence there is no need to duplicated that message. Signed-off-by: Tan Zhongjun --- sound/soc/fsl/fsl_spdif.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH] fs: btrfs: Disable BTRFS on platforms having 256K pages

2021-06-09 Thread Christophe Leroy
With a config having PAGE_SIZE set to 256K, BTRFS build fails with the following message include/linux/compiler_types.h:326:38: error: call to '__compiletime_assert_791' declared with attribute error: BUILD_BUG_ON failed: (BTRFS_MAX_COMPRESSED % PAGE_SIZE) != 0 BTRFS_MAX_COMPRESSED being

Re: [PATCH 1/1] of/pci: Add IORESOURCE_MEM_64 to resource flags for 64-bit memory addresses

2021-06-09 Thread Bjorn Helgaas
On Thu, Apr 15, 2021 at 01:59:52PM -0500, Rob Herring wrote: > On Thu, Apr 15, 2021 at 1:01 PM Leonardo Bras wrote: > > > > Many other resource flag parsers already add this flag when the input > > has bits 24 & 25 set, so update this one to do the same. [Adding this to the thread for

Re: [RFC] powerpc/pseries: Interface to represent PAPR firmware attributes

2021-06-09 Thread Fabiano Rosas
Pratik Sampat writes: >>> 3. version info - 1 byte >>> 4. A data array of size num attributes, which contains the following: >>>a. attribute ID - 8 bytes >>>b. attribute value in number - 8 bytes >>>c. attribute name in string - 64 bytes >>>d.