Re: [PATCH v2] powerpc/xive: Do not skip CPU-less nodes when creating the IPIs

2021-08-10 Thread Laurent Vivier
On 07/08/2021 09:20, Cédric Le Goater wrote: > On PowerVM, CPU-less nodes can be populated with hot-plugged CPUs at > runtime. Today, the IPI is not created for such nodes, and hot-plugged > CPUs use a bogus IPI, which leads to soft lockups. > > We can not directly allocate and request the IPI on

[bug report] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-08-10 Thread Dan Carpenter
Hello Maxim Kochetkov, The patch be7ecbd240b2: "soc: fsl: qe: convert QE interrupt controller to platform_device" from Aug 3, 2021, leads to the following static checker warning: drivers/soc/fsl/qe/qe_ic.c:438 qe_ic_init() warn: unsigned 'qe_ic->virq_low' is never less than zero.

Re: [PATCH v2 3/4] powerpc: Optimize register usage for dear register

2021-08-10 Thread Xiongwei Song
On Sat, Aug 7, 2021 at 2:58 PM Christophe Leroy wrote: > > > > Le 07/08/2021 à 03:02, sxwj...@me.com a écrit : > > From: Xiongwei Song > > > > Create an anonymous union for dar and dear regsiters, we can reference > > dear to get the effective address when CONFIG_4xx=y or CONFIG_BOOKE=y. > >

Re: [PATCH v2 1/4] powerpc: Optimize register usage for esr register

2021-08-10 Thread Xiongwei Song
On Sat, Aug 7, 2021 at 2:57 PM Christophe Leroy wrote: > > > > Le 07/08/2021 à 03:02, sxwj...@me.com a écrit : > > From: Xiongwei Song > > > > Create an anonymous union for dsisr and esr regsiters, we can reference > > esr to get the exception detail when CONFIG_4xx=y or CONFIG_BOOKE=y. > >

Re: [PATCH v4 0/5] nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP

2021-08-10 Thread Srinivas Kandagatla
On 01/08/2021 08:38, Emmanuel Gil Peyrot wrote: The OTP is a read-only memory area which contains various keys and signatures used to decrypt, encrypt or verify various pieces of storage. Its size depends on the console, it is 128 bytes on the Wii and 1024 bytes on the Wii U (split into

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-08-10 Thread Srikar Dronamraju
* Valentin Schneider [2021-08-09 13:52:38]: > On 09/08/21 12:22, Srikar Dronamraju wrote: > > * Valentin Schneider [2021-08-08 16:56:47]: > >> Wait, doesn't the distance matrix (without any offline node) say > >> > >> distance(0, 3) == 40 > >> > >> ? We should have at the very least: > >> >

Re: [PATCH v2] powerpc/xive: Do not skip CPU-less nodes when creating the IPIs

2021-08-10 Thread Srikar Dronamraju
* C?dric Le Goater [2021-08-07 09:20:57]: > On PowerVM, CPU-less nodes can be populated with hot-plugged CPUs at > runtime. Today, the IPI is not created for such nodes, and hot-plugged > CPUs use a bogus IPI, which leads to soft lockups. > > We can not directly allocate and request the IPI on

Re: [PATCH v2] powerpc/xive: Do not skip CPU-less nodes when creating the IPIs

2021-08-10 Thread Cédric Le Goater
On 8/7/21 9:20 AM, Cédric Le Goater wrote: > On PowerVM, CPU-less nodes can be populated with hot-plugged CPUs at > runtime. Today, the IPI is not created for such nodes, and hot-plugged > CPUs use a bogus IPI, which leads to soft lockups. > > We can not directly allocate and request the IPI on

[PATCH v4 5/6] sched/fair: Carve out logic to mark a group for asymmetric packing

2021-08-10 Thread Ricardo Neri
Create a separate function, sched_asym(). A subsequent changeset will introduce logic to deal with SMT in conjunction with asmymmetric packing. Such logic will need the statistics of the scheduling group provided as argument. Update them before calling sched_asym(). Cc: Aubrey Li Cc: Ben Segall

[PATCH v4 1/6] x86/sched: Decrease further the priorities of SMT siblings

2021-08-10 Thread Ricardo Neri
When scheduling, it is better to prefer a separate physical core rather than the SMT sibling of a high priority core. The existing formula to compute priorities takes such fact in consideration. There may exist, however, combinations of priorities (i.e., maximum frequencies) in which the priority

[PATCH v4 0/6] sched/fair: Fix load balancing of SMT siblings with ASYM_PACKING

2021-08-10 Thread Ricardo Neri
This is v4 the series. v1, v2, and v3 patches and test results can be found in [1], [2], and [3], respectively. === Problem statement === ++ Load balancing ++ When using asymmetric packing, there exists CPU topologies with three priority levels in which only a subset of the physical cores

[PATCH v4 2/6] sched/topology: Introduce sched_group::flags

2021-08-10 Thread Ricardo Neri
There exist situations in which the load balance needs to know the properties of the CPUs in a scheduling group. When using asymmetric packing, for instance, the load balancer needs to know not only the state of dst_cpu but also of its SMT siblings, if any. Use the flags of the child scheduling

[PATCH v4 4/6] sched/fair: Provide update_sg_lb_stats() with sched domain statistics

2021-08-10 Thread Ricardo Neri
Before deciding to pull tasks when using asymmetric packing of tasks, on some architectures (e.g., x86) it is necessary to know not only the state of dst_cpu but also of its SMT siblings. The decision to classify a candidate busiest group as group_asym_packing is done in update_sg_lb_stats(). Give

[PATCH v4 3/6] sched/fair: Optimize checking for group_asym_packing

2021-08-10 Thread Ricardo Neri
sched_asmy_prefer() always returns false when called on the local group. By checking local_group, we can avoid additional checks and invoking sched_asmy_prefer() when it is not needed. No functional changes are introduced. Cc: Aubrey Li Cc: Ben Segall Cc: Daniel Bristot de Oliveira Cc: Dietmar

[PATCH v4 6/6] sched/fair: Consider SMT in ASYM_PACKING load balance

2021-08-10 Thread Ricardo Neri
When deciding to pull tasks in ASYM_PACKING, it is necessary not only to check for the idle state of the destination CPU, dst_cpu, but also of its SMT siblings. If dst_cpu is idle but its SMT siblings are busy, performance suffers if it pulls tasks from a medium priority CPU that does not have

Re: [PATCH v2] powerpc/xive: Do not skip CPU-less nodes when creating the IPIs

2021-08-10 Thread Cédric Le Goater
> I forgot to add that this version does break irqbalance anymore, since ... does not break ... Sorry for the noise, > Linux is not mapping interrupts of CPU-less nodes. > > Anyhow, irqbalance is now fixed : > > >

[powerpc:next-test 60/60] arch/powerpc/kernel/misc_32.S:240: Error: unrecognized opcode: `emit_warn_entry'

2021-08-10 Thread kernel test robot
-buildonly-randconfig-r001-20210810 (attached as .config) compiler: powerpc-linux-gcc (GCC) 10.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org

Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

2021-08-10 Thread Tom Lendacky
On 8/10/21 1:45 PM, Kuppuswamy, Sathyanarayanan wrote: > > > On 7/27/21 3:26 PM, Tom Lendacky wrote: >> diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c >> index de01903c3735..cafed6456d45 100644 >> --- a/arch/x86/kernel/head64.c >> +++ b/arch/x86/kernel/head64.c >> @@ -19,7

Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

2021-08-10 Thread Kuppuswamy, Sathyanarayanan
On 7/27/21 3:26 PM, Tom Lendacky wrote: diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c index de01903c3735..cafed6456d45 100644 --- a/arch/x86/kernel/head64.c +++ b/arch/x86/kernel/head64.c @@ -19,7 +19,7 @@ #include #include #include -#include +#include #include

Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

2021-08-10 Thread Kuppuswamy, Sathyanarayanan
On 8/10/21 12:48 PM, Tom Lendacky wrote: On 8/10/21 1:45 PM, Kuppuswamy, Sathyanarayanan wrote: On 7/27/21 3:26 PM, Tom Lendacky wrote: diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c index de01903c3735..cafed6456d45 100644 --- a/arch/x86/kernel/head64.c +++

[PATCH] powerpc/interrupt: Fix OOPS by not calling do_IRQ() from timer_interrupt()

2021-08-10 Thread Christophe Leroy
An interrupt handler shall not be called from another interrupt handler otherwise this leads to problems like the following: Kernel attempted to write user page (afd4fa84) - exploit attempt? (uid: 1000) [ cut here ] Bug: Write fault blocked by

[PATCH] powerpc/interrupt: Do not call single_step_exception() from other exceptions

2021-08-10 Thread Christophe Leroy
single_step_exception() is called by emulate_single_step() which is called from (at least) alignment exception() handler and program_check_exception() handler. Redefine it as a regular __single_step_exception() which is called by both single_step_exception() handler and emulate_single_step()

Re: clang/ld.lld build fails with `can't create dynamic relocation R_PPC64_ADDR64 against local symbol in readonly segment`

2021-08-10 Thread Paul Menzel
Dear Linux folks, Am 29.07.21 um 10:23 schrieb Paul Menzel: I just wanted to make you aware that building Linux for ppc64le with clang/lld.ld fails with [1]:     ld.lld: error: can't create dynamic relocation R_PPC64_ADDR64 against symbol: empty_zero_page in readonly segment; recompile

[powerpc:next-test] BUILD REGRESSION 5e3aa4531ecc7febbfa18218145c903dab17e651

2021-08-10 Thread kernel test robot
/202108110231.pw76zfp3-...@intel.com Error/Warning in current branch: arch/powerpc/kernel/misc_32.S:240: Error: unrecognized opcode: `emit_warn_entry' Error/Warning ids grouped by kconfigs: gcc_recent_errors `-- powerpc64-buildonly-randconfig-r001-20210810 `-- arch-powerpc-kernel-misc_32

Re: [PATCH v2] powerpc/kprobes: Fix kprobe Oops happens in booke

2021-08-10 Thread Pu Lehui
Ping, serious problem here. All booke ppc will trigger Oops when perform kprobes related operations. On 2021/8/9 10:36, Pu Lehui wrote: When using kprobe on powerpc booke series processor, Oops happens as show bellow: / # echo "p:myprobe do_nanosleep" > /sys/kernel/debug/tracing/kprobe_events

[powerpc:fixes-test] BUILD SUCCESS 43e8f76006592cb1573a959aa287c45421066f9c

2021-08-10 Thread kernel test robot
allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20210810 x86_64 randconfig-a006-20210810 x86_64 randconfig-a003-20210810 x86_64 randconfig-a005-20210810 x86_64

Re: [PATCH v7 5/6] powerpc/pseries: Add support for FORM2 associativity

2021-08-10 Thread Aneesh Kumar K.V
David Gibson writes: > On Mon, Aug 09, 2021 at 10:54:33AM +0530, Aneesh Kumar K.V wrote: >> PAPR interface currently supports two different ways of communicating >> resource >> grouping details to the OS. These are referred to as Form 0 and Form 1 >> associativity grouping. Form 0 is the older

Re: [powerpc:next-test 60/60] arch/powerpc/kernel/misc_32.S:240: Error: unrecognized opcode: `emit_warn_entry'

2021-08-10 Thread Christophe Leroy
/__WARN_FLAGS() with asm goto config: powerpc64-buildonly-randconfig-r001-20210810 (attached as .config) compiler: powerpc-linux-gcc (GCC) 10.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross

Re: [PATCH v2] powerpc/kprobes: Fix kprobe Oops happens in booke

2021-08-10 Thread Christophe Leroy
Le 11/08/2021 à 04:53, Pu Lehui a écrit : Ping, serious problem here. All booke ppc will trigger Oops when perform kprobes related operations. As far as I can see it is in the fixes branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/log/?h=fixes On 2021/8/9