Re: [PATCH] serial: 8250: SERIAL_8250_FSL should not default to y when compile-testing

2021-09-16 Thread Johan Hovold
On Wed, Sep 15, 2021 at 02:56:52PM +0200, Geert Uytterhoeven wrote: > Commit b1442c55ce8977aa ("serial: 8250: extend compile-test coverage") > added compile-test support to the Freescale 16550 driver. However, as > SERIAL_8250_FSL is an invisible symbol, merely enabling COMPILE_TEST now > enables

Re: [PATCH] serial: 8250: SERIAL_8250_FSL should not default to y when compile-testing

2021-09-16 Thread Geert Uytterhoeven
Hi Johan, On Thu, Sep 16, 2021 at 10:46 AM Johan Hovold wrote: > On Wed, Sep 15, 2021 at 02:56:52PM +0200, Geert Uytterhoeven wrote: > > Commit b1442c55ce8977aa ("serial: 8250: extend compile-test coverage") > > added compile-test support to the Freescale 16550 driver. However, as > >

[PATCH v3 00/30]Change wildcards on ABI files

2021-09-16 Thread Mauro Carvalho Chehab
The ABI files are meant to be parsed via a script (scripts/get_abi.pl). A new improvement on it will allow it to help to detect if an ABI description is missing, or if the What: field won't match the actual location of the symbol. In order for get_abi.pl to convert What: into regex, changes are

[PATCH v3 07/30] ABI: sysfs-class-cxl: place "not in a guest" at description

2021-09-16 Thread Mauro Carvalho Chehab
The What: field should have just the location of the ABI. Anything else should be inside the description. This fixes its parsing by get_abi.pl script. Acked-by: Andrew Donnellan Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/testing/sysfs-class-cxl | 15 ++- 1 file

Re: [PATCH] serial: 8250: SERIAL_8250_FSL should not default to y when compile-testing

2021-09-16 Thread Johan Hovold
On Thu, Sep 16, 2021 at 10:55:49AM +0200, Geert Uytterhoeven wrote: > Hi Johan, > > On Thu, Sep 16, 2021 at 10:46 AM Johan Hovold wrote: > > On Wed, Sep 15, 2021 at 02:56:52PM +0200, Geert Uytterhoeven wrote: > > > Commit b1442c55ce8977aa ("serial: 8250: extend compile-test coverage") > > >

Re: [PATCH v4] lockdown,selinux: fix wrong subject in some SELinux lockdown checks

2021-09-16 Thread Ondrej Mosnacek
On Thu, Sep 16, 2021 at 4:59 AM Paul Moore wrote: > On Mon, Sep 13, 2021 at 5:05 PM Paul Moore wrote: > > > > On Mon, Sep 13, 2021 at 10:02 AM Ondrej Mosnacek > > wrote: > > > > > > Commit 59438b46471a ("security,lockdown,selinux: implement SELinux > > > lockdown") added an implementation of

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-16 Thread Christoph Hellwig
On Wed, Sep 15, 2021 at 07:18:34PM +0200, Christophe Leroy wrote: > Could you please provide more explicit explanation why inlining such an > helper is considered as bad practice and messy ? Because now we get architectures to all subly differ. Look at the mess for ioremap and the ioremap*

Re: [PATCH] powerpc: warn on emulation of dcbz instruction

2021-09-16 Thread Benjamin Herrenschmidt
On Wed, 2021-09-15 at 16:31 +0200, Christophe Leroy wrote: > dcbz instruction shouldn't be used on non-cached memory. Using > it on non-cached memory can result in alignment exception and > implies a heavy handling. > > Instead of silentely emulating the instruction and resulting in high >

Re: [PATCH] powerpc: warn on emulation of dcbz instruction

2021-09-16 Thread Benjamin Herrenschmidt
On Thu, 2021-09-16 at 17:15 +1000, Benjamin Herrenschmidt wrote: > On Wed, 2021-09-15 at 16:31 +0200, Christophe Leroy wrote: > > dcbz instruction shouldn't be used on non-cached memory. Using > > it on non-cached memory can result in alignment exception and > > implies a heavy handling. > > > >

Re: [PATCH] powerpc: warn on emulation of dcbz instruction

2021-09-16 Thread Christophe Leroy
Le 16/09/2021 à 09:16, Benjamin Herrenschmidt a écrit : On Thu, 2021-09-16 at 17:15 +1000, Benjamin Herrenschmidt wrote: On Wed, 2021-09-15 at 16:31 +0200, Christophe Leroy wrote: dcbz instruction shouldn't be used on non-cached memory. Using it on non-cached memory can result in alignment

[PATCH 5.14 232/432] hvsi: dont panic on tty_register_driver failure

2021-09-16 Thread Greg Kroah-Hartman
From: Jiri Slaby [ Upstream commit 7ccbdcc4d08a6d7041e4849219bbb12ffa45db4c ] The alloc_tty_driver failure is handled gracefully in hvsi_init. But tty_register_driver is not. panic is called if that one fails. So handle the failure of tty_register_driver gracefully too. This will keep at least

Re: [RFC PATCH 1/8] arm64: add CPU field to struct thread_info

2021-09-16 Thread Catalin Marinas
On Tue, Sep 14, 2021 at 02:10:29PM +0200, Ard Biesheuvel wrote: > The CPU field will be moved back into thread_info even when > THREAD_INFO_IN_TASK is enabled, so add it back to arm64's definition of > struct thread_info. > > Signed-off-by: Ard Biesheuvel Acked-by: Catalin Marinas

[PATCH v2] powerpc: warn on emulation of dcbz instruction in kernel mode

2021-09-16 Thread Christophe Leroy
dcbz instruction shouldn't be used on non-cached memory. Using it on non-cached memory can result in alignment exception and implies a heavy handling. Instead of silentely emulating the instruction and resulting in high performance degradation, warn whenever an alignment exception is taken in

Re: [PATCH v3 0/8] Implement generic cc_platform_has() helper function

2021-09-16 Thread Borislav Petkov
On Wed, Sep 15, 2021 at 10:26:06AM -0700, Kuppuswamy, Sathyanarayanan wrote: > I have a Intel variant patch (please check following patch). But it includes > TDX changes as well. Shall I move TDX changes to different patch and just > create a separate patch for adding intel_cc_platform_has()?

[PATCH 5.13 205/380] hvsi: dont panic on tty_register_driver failure

2021-09-16 Thread Greg Kroah-Hartman
From: Jiri Slaby [ Upstream commit 7ccbdcc4d08a6d7041e4849219bbb12ffa45db4c ] The alloc_tty_driver failure is handled gracefully in hvsi_init. But tty_register_driver is not. panic is called if that one fails. So handle the failure of tty_register_driver gracefully too. This will keep at least

RE: [PATCH] powerpc: warn on emulation of dcbz instruction

2021-09-16 Thread David Laight
From: Christophe Leroy > Sent: 16 September 2021 08:24 > > Le 16/09/2021 à 09:16, Benjamin Herrenschmidt a écrit : > > On Thu, 2021-09-16 at 17:15 +1000, Benjamin Herrenschmidt wrote: > >> On Wed, 2021-09-15 at 16:31 +0200, Christophe Leroy wrote: > >>> dcbz instruction shouldn't be used on

[PATCH] lib/zlib_inflate/inffast: Check config in C to avoid unused function warning

2021-09-16 Thread Paul Menzel
Building Linux for ppc64le with Ubuntu clang version 12.0.0-3ubuntu1~21.04.1 shows the warning below. arch/powerpc/boot/inffast.c:20:1: warning: unused function 'get_unaligned16' [-Wunused-function] get_unaligned16(const unsigned short *p) ^ 1 warning generated. Fix it, by

[PATCH 5.10 163/306] hvsi: dont panic on tty_register_driver failure

2021-09-16 Thread Greg Kroah-Hartman
From: Jiri Slaby [ Upstream commit 7ccbdcc4d08a6d7041e4849219bbb12ffa45db4c ] The alloc_tty_driver failure is handled gracefully in hvsi_init. But tty_register_driver is not. panic is called if that one fails. So handle the failure of tty_register_driver gracefully too. This will keep at least

Re: [PATCH] nvmem: NVMEM_NINTENDO_OTP should depend on WII

2021-09-16 Thread Emmanuel Gil Peyrot
Hi, thanks for this patch, once the Wii U platform will be added it will need an additional test for WIIU, but for now this is: Reviewed-by: Emmanuel Gil Peyrot On Tue, Sep 14, 2021 at 11:29:49AM +0200, Geert Uytterhoeven wrote: > The Nintendo Wii and Wii U OTP is only present on Nintendo Wii

Re: [PATCH] lib/zlib_inflate/inffast: Check config in C to avoid unused function warning

2021-09-16 Thread Nathan Chancellor
Hi Paul, On 9/16/2021 7:22 AM, Paul Menzel wrote: Building Linux for ppc64le with Ubuntu clang version 12.0.0-3ubuntu1~21.04.1 shows the warning below. arch/powerpc/boot/inffast.c:20:1: warning: unused function 'get_unaligned16' [-Wunused-function] get_unaligned16(const unsigned

[PATCH] powerpc/lib/sstep: Don't use __{get/put}_user() on kernel addresses

2021-09-16 Thread Christophe Leroy
In the old days, when we didn't have kernel userspace access protection and had set_fs(), it was wise to use __get_user() and friends to read kernel memory. Nowadays, get_user() and put_user() are granting userspace access and are exclusively for userspace access. Convert single step emulation

Re: [PATCH v3 0/8] Implement generic cc_platform_has() helper function

2021-09-16 Thread Kuppuswamy, Sathyanarayanan
On 9/16/21 8:02 AM, Borislav Petkov wrote: On Wed, Sep 15, 2021 at 10:26:06AM -0700, Kuppuswamy, Sathyanarayanan wrote: I have a Intel variant patch (please check following patch). But it includes TDX changes as well. Shall I move TDX changes to different patch and just create a separate

Re: [PATCH] lib/zlib_inflate/inffast: Check config in C to avoid unused function warning

2021-09-16 Thread kernel test robot
Hi Paul, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.15-rc1 next-20210916] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

Re: [PATCH v5 6/6] sched/fair: Consider SMT in ASYM_PACKING load balance

2021-09-16 Thread Ricardo Neri
On Wed, Sep 15, 2021 at 05:43:44PM +0200, Vincent Guittot wrote: > On Sat, 11 Sept 2021 at 03:19, Ricardo Neri > wrote: > > > > When deciding to pull tasks in ASYM_PACKING, it is necessary not only to > > check for the idle state of the destination CPU, dst_cpu, but also of > > its SMT siblings.

Re: [PATCH] lib/zlib_inflate/inffast: Check config in C to avoid unused function warning

2021-09-16 Thread kernel test robot
Hi Paul, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.15-rc1 next-20210916] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

Re: [PATCH] lib/zlib_inflate/inffast: Check config in C to avoid unused function warning

2021-09-16 Thread Christophe Leroy
Le 16/09/2021 à 16:22, Paul Menzel a écrit : Building Linux for ppc64le with Ubuntu clang version 12.0.0-3ubuntu1~21.04.1 shows the warning below. arch/powerpc/boot/inffast.c:20:1: warning: unused function 'get_unaligned16' [-Wunused-function] get_unaligned16(const unsigned short

Re: [PATCH 1/3] perf: Add macros to specify onchip L2/L3 accesses

2021-09-16 Thread Michael Ellerman
Peter Zijlstra writes: > On Tue, Sep 14, 2021 at 08:40:38PM +1000, Michael Ellerman wrote: >> Peter Zijlstra writes: > >> > I'm thinking we ought to keep hops as steps along the NUMA fabric, with >> > 0 hops being the local node. That only gets us: >> > >> > L2, remote=0, hops=HOPS_0 -- our L2

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-16 Thread Michael Ellerman
Christoph Hellwig writes: > On Wed, Sep 15, 2021 at 07:18:34PM +0200, Christophe Leroy wrote: >> Could you please provide more explicit explanation why inlining such an >> helper is considered as bad practice and messy ? > > Because now we get architectures to all subly differ. Look at the mess

Re: [PATCH] swiotlb: set IO TLB segment size via cmdline

2021-09-16 Thread Roman Skakun
Hi Stefano, > Also, Option 1 listed in the webpage seems to be a lot better. Any > reason you can't do that? Because that option both solves the problem > and increases performance. Yes, Option 1 is probably more efficient. But I use another platform under Xen without DMA adjustment