Re: [PATCH 1/4] crypto: nintendo-aes - add a new AES driver

2021-09-22 Thread Ard Biesheuvel
On Tue, 21 Sept 2021 at 23:49, Emmanuel Gil Peyrot wrote: > > This engine implements AES in CBC mode, using 128-bit keys only. It is > present on both the Wii and the Wii U, and is apparently identical in > both consoles. > > The hardware is capable of firing an interrupt when the operation is >

Re: [PATCH 1/4] crypto: nintendo-aes - add a new AES driver

2021-09-22 Thread Emmanuel Gil Peyrot
On Wed, Sep 22, 2021 at 12:10:41PM +0200, Ard Biesheuvel wrote: > On Tue, 21 Sept 2021 at 23:49, Emmanuel Gil Peyrot > wrote: > > > > This engine implements AES in CBC mode, using 128-bit keys only. It is > > present on both the Wii and the Wii U, and is apparently identical in > > both

Re: [PATCH] powerpc/paravirt: correct preempt debug splat in vcpu_is_preempted()

2021-09-22 Thread Michael Ellerman
Nathan Lynch writes: > vcpu_is_preempted() can be used outside of preempt-disabled critical > sections, yielding warnings such as: > > BUG: using smp_processor_id() in preemptible [] code: > systemd-udevd/185 > caller is rwsem_spin_on_owner+0x1cc/0x2d0 > CPU: 1 PID: 185 Comm:

Re: [PATCH 5/7] PCI: Add pci_find_dvsec_capability to find designated VSEC

2021-09-22 Thread Frederic Barrat
On 22/09/2021 00:04, Ben Widawsky wrote: Add pci_find_dvsec_capability to locate a Designated Vendor-Specific Extended Capability with the specified DVSEC ID. The Designated Vendor-Specific Extended Capability (DVSEC) allows one or more vendor specific capabilities that aren't tied to the

Re: [PATCH 7/7] ocxl: Use pci core's DVSEC functionality

2021-09-22 Thread Frederic Barrat
On 22/09/2021 02:44, Dan Williams wrote: On Tue, Sep 21, 2021 at 3:05 PM Ben Widawsky wrote: Reduce maintenance burden of DVSEC query implementation by using the centralized PCI core implementation. Cc: linuxppc-dev@lists.ozlabs.org Cc: Frederic Barrat Cc: Andrew Donnellan

Re: [PATCH 1/4] crypto: nintendo-aes - add a new AES driver

2021-09-22 Thread Ard Biesheuvel
On Wed, 22 Sept 2021 at 12:43, Emmanuel Gil Peyrot wrote: > > On Wed, Sep 22, 2021 at 12:10:41PM +0200, Ard Biesheuvel wrote: > > On Tue, 21 Sept 2021 at 23:49, Emmanuel Gil Peyrot > > wrote: > > > > > > This engine implements AES in CBC mode, using 128-bit keys only. It is > > > present on

Re: [PATCH] powerpc/code-patching: Return error on patch_branch() out-of-range failure

2021-09-22 Thread Naveen N. Rao
Christophe Leroy wrote: Do not silentely ignore a failure of create_branch() in patch_branch(). Return -ERANGE. Signed-off-by: Christophe Leroy --- arch/powerpc/lib/code-patching.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Naveen N. Rao diff --git

Re: [PATCH] powerpc/paravirt: correct preempt debug splat in vcpu_is_preempted()

2021-09-22 Thread Srikar Dronamraju
* Nathan Lynch [2021-09-20 22:12:13]: > vcpu_is_preempted() can be used outside of preempt-disabled critical > sections, yielding warnings such as: > > BUG: using smp_processor_id() in preemptible [] code: > systemd-udevd/185 > caller is rwsem_spin_on_owner+0x1cc/0x2d0 > CPU: 1 PID:

Re: [PATCH 1/4] crypto: nintendo-aes - add a new AES driver

2021-09-22 Thread Corentin Labbe
Le Tue, Sep 21, 2021 at 11:39:27PM +0200, Emmanuel Gil Peyrot a écrit : > This engine implements AES in CBC mode, using 128-bit keys only. It is > present on both the Wii and the Wii U, and is apparently identical in > both consoles. > > The hardware is capable of firing an interrupt when the

[RESEND PATCH 1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration

2021-09-22 Thread Krzysztof Kozlowski
g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c, so it should have a declaration to fix W=1 warning: arch/powerpc/platforms/powermac/feature.c:1533:6: error: no previous prototype for ‘g5_phy_disable_cpu1’ [-Werror=missing-prototypes] Signed-off-by: Krzysztof

Re: [RESEND PATCH 2/2] powerpc/powermac: constify device_node in of_irq_parse_oldworld()

2021-09-22 Thread Christophe Leroy
Le 22/09/2021 à 10:44, Krzysztof Kozlowski a écrit : The of_irq_parse_oldworld() does not modify passed device_node so make it a pointer to const for safety. AFAIKS this patch is unrelated to previous one so you should send them out separately instead of sending as a series.

Re: [RESEND PATCH 2/2] powerpc/powermac: constify device_node in of_irq_parse_oldworld()

2021-09-22 Thread Krzysztof Kozlowski
On 22/09/2021 15:55, Christophe Leroy wrote: > > > Le 22/09/2021 à 10:44, Krzysztof Kozlowski a écrit : >> The of_irq_parse_oldworld() does not modify passed device_node so make >> it a pointer to const for safety. > > AFAIKS this patch is unrelated to previous one so you should send them >

[PATCH v3 0/6] powerpc/64s: interrupt speedups

2021-09-22 Thread Nicholas Piggin
Here's a few stragglers. The first patch was submitted already but had some bugs with unrecoverable exceptions on HPT (current->blah being accessed before MSR[RI] was enabled). Those should be fixed now. The others are generally for helping asynch interrupts, which are a bit harder to measure

[PATCH v3 1/6] powerpc/64/interrupt: make normal synchronous interrupts enable MSR[EE] if possible

2021-09-22 Thread Nicholas Piggin
Make synchronous interrupt handler entry wrappers enable MSR[EE] if MSR[EE] was enabled in the interrupted context. IRQs are soft-disabled at this point so there is no change to high level code, but it's a masked interrupt could fire. This is a performance disadvantage for interrupts which do not

[PATCH v3 5/6] powerpc/64/interrupt: reduce expensive debug tests

2021-09-22 Thread Nicholas Piggin
Move the assertions requiring restart table searches under CONFIG_PPC_IRQ_SOFT_MASK_DEBUG. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/interrupt.h | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/include/asm/interrupt.h

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-22 Thread Tom Lendacky
On 9/21/21 4:58 PM, Kirill A. Shutemov wrote: On Tue, Sep 21, 2021 at 04:43:59PM -0500, Tom Lendacky wrote: On 9/21/21 4:34 PM, Kirill A. Shutemov wrote: On Tue, Sep 21, 2021 at 11:27:17PM +0200, Borislav Petkov wrote: On Wed, Sep 22, 2021 at 12:20:59AM +0300, Kirill A. Shutemov wrote: I

Re: [RESEND PATCH 1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration

2021-09-22 Thread Krzysztof Kozlowski
On 22/09/2021 15:52, Christophe Leroy wrote: > > > Le 22/09/2021 à 10:44, Krzysztof Kozlowski a écrit : >> g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c, >> so it should have a declaration to fix W=1 warning: >> >>arch/powerpc/platforms/powermac/feature.c:1533:6: >>

Re: [PATCH 0/5] KVM: rseq: Fix and a test for a KVM+rseq bug

2021-09-22 Thread Paolo Bonzini
On 18/08/21 02:12, Sean Christopherson wrote: Patch 1 fixes a KVM+rseq bug where KVM's handling of TIF_NOTIFY_RESUME, e.g. for task migration, clears the flag without informing rseq and leads to stale data in userspace's rseq struct. Patch 2 is a cleanup to try and make future bugs less likely.

[PATCH v3 6/6] powerpc/64s/interrupt: avoid saving CFAR in some asynchronous interrupts

2021-09-22 Thread Nicholas Piggin
Reading the CFAR register is quite costly (~20 cycles on POWER9). It is a good idea to have for most synchronous interrupts, but for async ones it is much less important. Doorbell, external, and decrementer interrupts are the important asynchronous ones. HV interrupts can't skip CFAR if KVM HV is

[PATCH] powerpc/breakpoint: Cleanup

2021-09-22 Thread Christophe Leroy
cache_op_size() does exactly the same as l1_dcache_bytes(). Remove it. MSR_64BIT already exists, no need to enclode the check around #ifdef __powerpc64__ Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/hw_breakpoint_constraints.c | 15 +++ 1 file changed, 3 insertions(+),

Re: [RESEND PATCH 1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration

2021-09-22 Thread Christophe Leroy
Le 22/09/2021 à 10:44, Krzysztof Kozlowski a écrit : g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c, so it should have a declaration to fix W=1 warning: arch/powerpc/platforms/powermac/feature.c:1533:6: error: no previous prototype for ‘g5_phy_disable_cpu1’

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-22 Thread Kirill A. Shutemov
On Wed, Sep 22, 2021 at 08:40:43AM -0500, Tom Lendacky wrote: > On 9/21/21 4:58 PM, Kirill A. Shutemov wrote: > > On Tue, Sep 21, 2021 at 04:43:59PM -0500, Tom Lendacky wrote: > > > On 9/21/21 4:34 PM, Kirill A. Shutemov wrote: > > > > On Tue, Sep 21, 2021 at 11:27:17PM +0200, Borislav Petkov

[PATCH v3 4/6] powerpc/64s/interrupt: Don't enable MSR[EE] in irq handlers unless perf is in use

2021-09-22 Thread Nicholas Piggin
Enabling MSR[EE] in interrupt handlers while interrupts are still soft masked allows PMIs to profile interrupt handlers to some degree, beyond what SIAR latching allows. When perf is not being used, this is almost useless work. It requires an extra mtmsrd in the irq handler, and it also opens the

[PATCH v3 3/6] powerpc/64s/perf: add power_pmu_wants_prompt_pmi to say whether perf wants PMIs to be soft-NMI

2021-09-22 Thread Nicholas Piggin
Interrupt code enables MSR[EE] in some irq handlers while keeping local irqs disabled via soft-mask, allowing PMI interrupts to be taken as soft-NMI to improve profiling of irq handlers. When perf is not enabled, there is no point to doing this, it's additional overhead. So provide a function

[Bug 213837] "Kernel panic - not syncing: corrupted stack end detected inside scheduler" at building via distcc on a G5

2021-09-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213837 --- Comment #7 from Erhard F. (erhar...@mailbox.org) --- Created attachment 298919 --> https://bugzilla.kernel.org/attachment.cgi?id=298919=edit dmesg (5.15-rc2 + patch, PowerMac G5 11,2) (In reply to mpe from comment #6) > Can you try this

Re: [PATCH 01/16] ASoC: eureka-tlv320: Update to modern clocking terminology

2021-09-22 Thread Mark Brown
On Tue, 21 Sep 2021 22:10:25 +0100, Mark Brown wrote: > As part of moving to remove the old style defines for the bus clocks update > the eureka-tlv320 driver to use more modern terminology for clocking. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

Re: [PATCH v2 01/16] ASoC: eureka-tlv320: Update to modern clocking terminology

2021-09-22 Thread Mark Brown
On Tue, 21 Sep 2021 22:35:27 +0100, Mark Brown wrote: > As part of moving to remove the old style defines for the bus clocks update > the eureka-tlv320 driver to use more modern terminology for clocking. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

[RESEND PATCH 2/2] powerpc/powermac: constify device_node in of_irq_parse_oldworld()

2021-09-22 Thread Krzysztof Kozlowski
The of_irq_parse_oldworld() does not modify passed device_node so make it a pointer to const for safety. Signed-off-by: Krzysztof Kozlowski --- arch/powerpc/platforms/powermac/pic.c | 2 +- include/linux/of_irq.h| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v1] powerpc/64/interrupt: Reconcile soft-mask state in NMI and fix false BUG

2021-09-22 Thread Nicholas Piggin
If a NMI hits early in an interrupt handler before the irq soft-mask state is reconciled, that can cause a false-positive BUG with a CONFIG_PPC_IRQ_SOFT_MASK_DEBUG assertion. Remove that assertion and instead check the case that if regs->msr has EE clear, then regs->softe should be marked as

[PATCH v3 2/6] powerpc/64s/interrupt: handle MSR EE and RI in interrupt entry wrapper

2021-09-22 Thread Nicholas Piggin
The mtmsrd to enable MSR[RI] can be combined with the mtmsrd to enable MSR[EE] in interrupt entry code, for those interrupts which enable EE. This helps performance of important synchronous interrupts (e.g., page faults). This is similar to what commit dd152f70bdc1 ("powerpc/64s: system call

Re: [PATCH] powerpc/paravirt: correct preempt debug splat in vcpu_is_preempted()

2021-09-22 Thread Nathan Lynch
Michael Ellerman writes: > Nathan Lynch writes: >> --- a/arch/powerpc/include/asm/paravirt.h >> +++ b/arch/powerpc/include/asm/paravirt.h >> @@ -97,7 +97,14 @@ static inline bool vcpu_is_preempted(int cpu) >> >> #ifdef CONFIG_PPC_SPLPAR >> if (!is_kvm_guest()) { >> -int

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-22 Thread Borislav Petkov
On Wed, Sep 22, 2021 at 05:30:15PM +0300, Kirill A. Shutemov wrote: > Not fine, but waiting to blowup with random build environment change. Why is it not fine? Are you suspecting that the compiler might generate something else and not a rip-relative access? -- Regards/Gruss, Boris.

doesn't boot if linkaddr=0x0090.0000

2021-09-22 Thread cp
hi I am new to this list. Hope this is the right place to ask. I am working with a PPC405GP board, and as far as I understand, the support for ppc40x platforms like Acadia and Walnut were dropped with kernel 5.8.0, so this seems like a pretty straightforward question, but extensive experiments

Re: [PATCH] powerpc/paravirt: correct preempt debug splat in vcpu_is_preempted()

2021-09-22 Thread Nathan Lynch
Srikar Dronamraju writes: > * Nathan Lynch [2021-09-22 11:01:12]: > >> Srikar Dronamraju writes: >> > * Nathan Lynch [2021-09-20 22:12:13]: >> > >> >> vcpu_is_preempted() can be used outside of preempt-disabled critical >> >> sections, yielding warnings such as: >> >> >> >> BUG: using

doesn't boot when linkaddr=0x0090.0000

2021-09-22 Thread cp
hi I am new to this list. Hope this is the right place to ask. I am working with a PPC405GP board, and as far as I understand, the support for ppc40x platforms like Acadia and Walnut were dropped with kernel 5.8.0, so this seems like a pretty straightforward question, but extensive experiments

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-22 Thread Kirill A. Shutemov
On Wed, Sep 22, 2021 at 09:52:07PM +0200, Borislav Petkov wrote: > On Wed, Sep 22, 2021 at 05:30:15PM +0300, Kirill A. Shutemov wrote: > > Not fine, but waiting to blowup with random build environment change. > > Why is it not fine? > > Are you suspecting that the compiler might generate

Re: [PATCH] powerpc/paravirt: correct preempt debug splat in vcpu_is_preempted()

2021-09-22 Thread Nathan Lynch
Srikar Dronamraju writes: > * Nathan Lynch [2021-09-20 22:12:13]: > >> vcpu_is_preempted() can be used outside of preempt-disabled critical >> sections, yielding warnings such as: >> >> BUG: using smp_processor_id() in preemptible [] code: >> systemd-udevd/185 >> caller is

doesn't boot when linkaddr=0x0090.0000

2021-09-22 Thread cp
hi I am new to this list. Hope this is the right place to ask. I am working with a PPC405GP board, and as far as I understand, the support for ppc40x platforms like Acadia and Walnut were dropped with kernel 5.8.0, so this seems like a pretty straightforward question, but extensive experiments

Re: [PATCH] powerpc/paravirt: correct preempt debug splat in vcpu_is_preempted()

2021-09-22 Thread Srikar Dronamraju
* Nathan Lynch [2021-09-22 11:01:12]: > Srikar Dronamraju writes: > > * Nathan Lynch [2021-09-20 22:12:13]: > > > >> vcpu_is_preempted() can be used outside of preempt-disabled critical > >> sections, yielding warnings such as: > >> > >> BUG: using smp_processor_id() in preemptible []

[PATCH v2 2/2] powerpc/powermac: constify device_node in of_irq_parse_oldworld()

2021-09-22 Thread Krzysztof Kozlowski
The of_irq_parse_oldworld() does not modify passed device_node so make it a pointer to const for safety. Drop the extern while modifying the line. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Drop extern. --- arch/powerpc/platforms/powermac/pic.c | 2 +- include/linux/of_irq.h

[PATCH v2 1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration

2021-09-22 Thread Krzysztof Kozlowski
g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c, so it should have a declaration to fix W=1 warning: arch/powerpc/platforms/powermac/feature.c:1533:6: error: no previous prototype for ‘g5_phy_disable_cpu1’ [-Werror=missing-prototypes] Signed-off-by: Krzysztof

[PATCH AUTOSEL 5.14 01/34] ibmvnic: check failover_pending in login response

2021-09-22 Thread Sasha Levin
From: Sukadev Bhattiprolu [ Upstream commit d437f5aa23aa2b7bd07cd44b839d7546cc17166f ] If a failover occurs before a login response is received, the login response buffer maybe undefined. Check that there was no failover before accessing the login response buffer. Signed-off-by: Sukadev

[PATCH AUTOSEL 4.19 01/15] ibmvnic: check failover_pending in login response

2021-09-22 Thread Sasha Levin
From: Sukadev Bhattiprolu [ Upstream commit d437f5aa23aa2b7bd07cd44b839d7546cc17166f ] If a failover occurs before a login response is received, the login response buffer maybe undefined. Check that there was no failover before accessing the login response buffer. Signed-off-by: Sukadev

[PATCH AUTOSEL 5.10 01/26] ibmvnic: check failover_pending in login response

2021-09-22 Thread Sasha Levin
From: Sukadev Bhattiprolu [ Upstream commit d437f5aa23aa2b7bd07cd44b839d7546cc17166f ] If a failover occurs before a login response is received, the login response buffer maybe undefined. Check that there was no failover before accessing the login response buffer. Signed-off-by: Sukadev

[PATCH AUTOSEL 5.4 01/19] ibmvnic: check failover_pending in login response

2021-09-22 Thread Sasha Levin
From: Sukadev Bhattiprolu [ Upstream commit d437f5aa23aa2b7bd07cd44b839d7546cc17166f ] If a failover occurs before a login response is received, the login response buffer maybe undefined. Check that there was no failover before accessing the login response buffer. Signed-off-by: Sukadev

Re: [PATCH v3 1/6] powerpc/64/interrupt: make normal synchronous interrupts enable MSR[EE] if possible

2021-09-22 Thread Christophe Leroy
Le 22/09/2021 à 16:54, Nicholas Piggin a écrit : Make synchronous interrupt handler entry wrappers enable MSR[EE] if MSR[EE] was enabled in the interrupted context. IRQs are soft-disabled at this point so there is no change to high level code, but it's a masked interrupt could fire. This is

Re: [PATCH v3 5/6] powerpc/64/interrupt: reduce expensive debug tests

2021-09-22 Thread Christophe Leroy
Le 22/09/2021 à 16:54, Nicholas Piggin a écrit : Move the assertions requiring restart table searches under CONFIG_PPC_IRQ_SOFT_MASK_DEBUG. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/interrupt.h | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff