Re: [PATCH 2/2] powerpc/kexec: avoid hard coding when automatically allocating mem for crashkernel

2022-07-07 Thread Christophe Leroy
Le 31/08/2018 à 09:30, Pingfan Liu a écrit : If no start address is specified for crashkernel, the current program hard code as: crashk_res.start = min(0x800ULL, (ppc64_rma_size / 2)); This limits the candidate memory region, and may cause failure while there is enough mem for

[Bug 213079] [bisected] IRQ problems and crashes on a PowerMac G5 with 5.12.3

2022-07-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213079 --- Comment #19 from Erhard F. (erhar...@mailbox.org) --- (Luckily) I am no longer able to reproduce this. Re-tested on 5.19-rc5. Perhaps the problem was also specific for this specific NVMe SSD. I swapped it for another one and now I have not

Re: [PATCH 3/3] powerpc/platforms/83xx/suspend: Remove write-only global variable

2022-07-07 Thread Christophe Leroy
Le 07/07/2022 à 08:14, Uwe Kleine-König a écrit : > pmc_dev is only assigned in .probe(), otherwise the variable is unused. > So drop this pointer that serves no purpose. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Christophe Leroy > --- > arch/powerpc/platforms/83xx/suspend.c | 2 --

[Bug 213837] [bisected] "Kernel panic - not syncing: corrupted stack end detected inside scheduler" at building via distcc on a G5

2022-07-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213837 --- Comment #21 from Erhard F. (erhar...@mailbox.org) --- (Luckily) I am no longer able to reproduce this. Re-tested on 5.19-rc5. I'll keep an eye on it and will close here if it stays like that for the next few stable kernels. -- You may

Re: [PATCH 1/3] powerpc/platforms/83xx/suspend: Reorder to get rid of a forward declaration

2022-07-07 Thread Christophe Leroy
Le 07/07/2022 à 08:14, Uwe Kleine-König a écrit : > By moving up pmc_types and pmc_match, the forward declaration for pmc_match > can be dropped. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Christophe Leroy > --- > arch/powerpc/platforms/83xx/suspend.c | 43

Re: [PATCH] powerpc/52xx: Mark gpt driver as not removable

2022-07-07 Thread Christophe Leroy
Le 12/06/2022 à 23:34, Uwe Kleine-König a écrit : > Returning an error code (here -EBUSY) from a remove callback doesn't > prevent the driver from being unloaded. The only effect is that an error > message is emitted and the driver is removed anyhow. > > So instead drop the remove function

Re: [PATCH] powerpc: e500: Fix compilation with gcc e500 compiler

2022-07-07 Thread Christophe Leroy
Le 04/07/2022 à 15:43, Arnd Bergmann a écrit : > On Mon, Jul 4, 2022 at 3:29 PM Pali Rohár wrote: >> >> And still what to do with 4bf4f42a2feb ("powerpc/kbuild: Set default >> generic machine type for 32-bit compile")? I'm somehow lost there... > > As far as I can tell, that is not needed, as

Re: [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-07 Thread Chen, Rong A
org, net...@vger.kernel.org, k...@vger.kernel.org, da...@lists.linux.dev, linux...@kvack.org, accessrunner-gene...@lists.sourceforge.net, linux1394-de...@lists.sourceforge.net, linux-l...@vger.kernel.org, rds-de...@oss.oracle.com, linux-...@vger.kernel.org, d...@vger.kernel.org,

Re: [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-07 Thread Greg KH
org, net...@vger.kernel.org, k...@vger.kernel.org, da...@lists.linux.dev, linux...@kvack.org, accessrunner-gene...@lists.sourceforge.net, linux1394-de...@lists.sourceforge.net, linux-l...@vger.kernel.org, rds-de...@oss.oracle.com, linux-...@vger.kernel.org, d...@vger.kernel.org,

Re: [PATCH] powerpc: e500: Fix compilation with gcc e500 compiler

2022-07-07 Thread Pali Rohár
On Thursday 07 July 2022 09:56:04 Christophe Leroy wrote: > Le 04/07/2022 à 15:43, Arnd Bergmann a écrit : > > On Mon, Jul 4, 2022 at 3:29 PM Pali Rohár wrote: > >> > >> And still what to do with 4bf4f42a2feb ("powerpc/kbuild: Set default > >> generic machine type for 32-bit compile")? I'm

Re: linux-next: manual merge of the random tree with the powerpc tree

2022-07-07 Thread Stephen Rothwell
Hi Jason, On Thu, 7 Jul 2022 12:52:54 +0200 "Jason A. Donenfeld" wrote: > > Oh darn. Any clever tricks to prevent the merge conflict from > happening? Or is this trivial enough that we'll let Linus deal with > it? Just leave it for Linus, its pretty trivial. -- Cheers, Stephen Rothwell

[PATCH] KVM: PPC: Use the arg->size directly for kvm_vm_ioctl_create_spapr_tce

2022-07-07 Thread Deming Wang
Use arg->size directly may be better for code readability.Because, the variable of size has not been found for special purpose at present. Also,We can reduce the use of a variable. Signed-off-by: Deming Wang --- arch/powerpc/kvm/book3s_64_vio.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH] pseries/hotplug: Add more delay in pseries_cpu_die while waiting for rtas-stop

2022-07-07 Thread Christophe Leroy
Le 06/12/2018 à 12:31, Gautham R. Shenoy a écrit : > From: "Gautham R. Shenoy" > > Currently running DLPAR offline/online operations in a loop on a > POWER9 system with SMT=off results in the following crash: > > [ 223.321032] cpu 112 (hwid 112) Ready to die... > [ 223.355963] Querying

[linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-07 Thread kernel test robot
l.org, da...@lists.linux.dev, Linux Memory Management List , accessrunner-gene...@lists.sourceforge.net, linux1394-de...@lists.sourceforge.net, linux-l...@vger.kernel.org, rds-de...@oss.oracle.com, linux-...@vger.kernel.org, d...@vger.kernel.org, intel-wired-...@lists.osuosl.org,

[PATCH v2] powerpc/code-patching: Speed up page mapping/unmapping on PPC32

2022-07-07 Thread Christophe Leroy
Since commit 591b4b268435 ("powerpc/code-patching: Pre-map patch area") the patch area is premapped so intermediate page tables are already allocated. Use __set_pte_at() directly instead of the heavy map_kernel_page(), at for unmapping just do a pte_clear() followed by a flush. __set_pte_at()

Re: [PATCH 2/3] powerpc/platforms/83xx/suspend: Prevent unloading the driver

2022-07-07 Thread Christophe Leroy
Le 07/07/2022 à 08:14, Uwe Kleine-König a écrit : > Returning an error in .remove() doesn't prevent a driver from being > unloaded. On unbind this only results in an error message, but the > device is remove anyhow. > > I guess the author's idea of just returning -EPERM in .remove() was to >

Re: [PATCH/RFC] powerpc/module_64: allow .init_array constructors to run

2022-07-07 Thread Christophe Leroy
Le 17/08/2021 à 15:02, Jan Stancek a écrit : gcov and kasan rely on compiler generated constructor code. For modules, gcc-8 with gcov enabled generates .init_array section, but on ppc64le it doesn't get executed. find_module_sections() never finds .init_array section, because

Re: [PATCH/RFC] powerpc/module_64: allow .init_array constructors to run

2022-07-07 Thread Jan Stancek
On Thu, Jul 7, 2022 at 1:20 PM Christophe Leroy wrote: > > > > Le 17/08/2021 à 15:02, Jan Stancek a écrit : > > gcov and kasan rely on compiler generated constructor code. > > For modules, gcc-8 with gcov enabled generates .init_array section, > > but on ppc64le it doesn't get executed.

linux-next: manual merge of the random tree with the powerpc tree

2022-07-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the random tree got a conflict in: arch/powerpc/Kconfig between commit: cea9d62b64c9 ("powerpc: Kconfig: Replace tabs with whitespaces") from the powerpc tree and commit: a2ff4b7600cd ("random: remove CONFIG_ARCH_RANDOM") from the random tree. I

Re: [PATCH] powerpc/powernv: Map OPAL msglog in IOREMAP area

2022-07-07 Thread Christophe Leroy
Hi Le 16/03/2017 à 07:17, Gavin Shan a écrit : With OPAL msglog driver, there are two interfaces to retrieve the firmware (skiboot) logs: /sys/firmware/opal/msglog and xmon "do" command. The memory console header (descritpor) and output buffer are resident in memory blocks whose addresses are

[PATCH v2 1/4] video: fbdev: offb: Include missing linux/platform_device.h

2022-07-07 Thread Christophe Leroy
A lot of drivers were getting platform and of headers indirectly via headers like asm/pci.h or asm/prom.h Most of them were fixed during 5.19 cycle but a newissue was introduced by commit 52b1b46c39ae ("of: Create platform devices for OF framebuffers") Include missing platform_device.h to allow

[PATCH v2 2/4] scsi: cxlflash: Include missing linux/irqdomain.h

2022-07-07 Thread Christophe Leroy
powerpc's asm/prom.h brings some headers that it doesn't need itself. Once those headers are removed from asm/prom.h, the following errors occur: CC [M] drivers/scsi/cxlflash/ocxl_hw.o drivers/scsi/cxlflash/ocxl_hw.c: In function 'afu_map_irq': drivers/scsi/cxlflash/ocxl_hw.c:195:16: error:

[PATCH v2] powerpc: Merge hardirq stack and softirq stack

2022-07-07 Thread Christophe Leroy
__do_IRQ() doesn't switch on hardirq stack if we are on softirq stack. do_softirq() bail out early without doing anything when already in an interrupt. invoke_softirq() is on task_stack when it calls do_softirq_own_stack(). So there are neither situation where we switch from hardirq stack to

[PATCH v5 1/2] powerpc/perf: Use PVR rather than oprofile field to determine CPU version

2022-07-07 Thread Christophe Leroy
From: Rashmica Gupta Currently the perf CPU backend drivers detect what CPU they're on using cur_cpu_spec->oprofile_cpu_type. Although that works, it's a bit crufty to be using oprofile related fields, especially seeing as oprofile is more or less unused these days. It also means perf is

Re: [PATCH kernel] powerpc/iommu: Add iommu_ops to report capabilities and allow blocking domains

2022-07-07 Thread Jason Gunthorpe
On Thu, Jul 07, 2022 at 11:55:52PM +1000, Alexey Kardashevskiy wrote: > Historically PPC64 managed to avoid using iommu_ops. The VFIO driver > uses a SPAPR TCE sub-driver and all iommu_ops uses were kept in > the Type1 VFIO driver. Recent development though has added a coherency > capability check

[PATCH kernel] powerpc/iommu: Add iommu_ops to report capabilities and allow blocking domains

2022-07-07 Thread Alexey Kardashevskiy
Historically PPC64 managed to avoid using iommu_ops. The VFIO driver uses a SPAPR TCE sub-driver and all iommu_ops uses were kept in the Type1 VFIO driver. Recent development though has added a coherency capability check to the generic part of VFIO and essentially disabled VFIO on PPC64; the

[PATCH v5 2/2] powerpc: Remove remaining parts of oprofile

2022-07-07 Thread Christophe Leroy
Commit 9850b6c69356 ("arch: powerpc: Remove oprofile") removed oprofile. Remove all remaining parts of it. Signed-off-by: Christophe Leroy Acked-by: Viresh Kumar --- arch/powerpc/include/asm/cputable.h | 3 - arch/powerpc/kernel/cputable.c| 67 +--

Re: [PATCH v5 5/6] of: kexec: Refactor IMA buffer related functions to make them reusable

2022-07-07 Thread Stefan Berger
On 7/7/22 10:47, Jonathan McDowell wrote: On Wed, Jul 06, 2022 at 11:23:28AM -0400, Stefan Berger wrote: Refactor IMA buffer related functions to make them reusable for carrying TPM logs across kexec. Signed-off-by: Stefan Berger Cc: Rob Herring Cc: Frank Rowand Cc: Mimi Zohar --- v5:

[PATCH 3/3] powerpc/ppc-opcode: Define and use PPC_RAW_SETB()

2022-07-07 Thread Christophe Leroy
We have PPC_INST_SETB then build the 'setb' instruction in the user. Instead, define PPC_RAW_SETB() and use it. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/ppc-opcode.h | 2 +- arch/powerpc/lib/test_emulate_step.c | 9 +++-- 2 files changed, 4 insertions(+), 7

[PATCH 1/3] powerpc/probes: Remove ppc_opcode_t

2022-07-07 Thread Christophe Leroy
ppc_opcode_t is just an u32. There is no point in hiding u32 behind such a typedef. Remove it. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/kprobes.h | 2 +- arch/powerpc/include/asm/probes.h | 1 - arch/powerpc/include/asm/uprobes.h | 2 +- 3 files changed, 2 insertions(+), 3

[PATCH 2/3] powerpc/ppc-opcode: Define and use PPC_RAW_TRAP() and PPC_RAW_TW()

2022-07-07 Thread Christophe Leroy
Add and use PPC_RAW_TRAP() instead of opencoding. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/ppc-opcode.h | 2 ++ arch/powerpc/include/asm/probes.h | 3 ++- arch/powerpc/xmon/xmon.c | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 4/4] watchdog/pseries-wdt: initial support for H_WATCHDOG-based watchdog timers

2022-07-07 Thread Scott Cheloha
On Fri, Jun 24, 2022 at 11:51:01PM +1000, Michael Ellerman wrote: > Scott Cheloha writes: > ... > > + > > +static struct platform_driver pseries_wdt_driver = { > > + .driver = { > > + .name = DRV_NAME, > > + .owner = THIS_MODULE, > > That owner assignment is not required. >

Re: [PATCH v2 3/4] powerpc/pseries: register pseries-wdt device with platform bus

2022-07-07 Thread Scott Cheloha
On Fri, Jun 24, 2022 at 11:27:36PM +1000, Michael Ellerman wrote: > Nathan Lynch writes: > > Scott Cheloha writes: > >> PAPR v2.12 defines a new hypercall, H_WATCHDOG. The hypercall permits > >> guest control of one or more virtual watchdog timers. > ... > > > > Seems like we don't need

Re: [PATCH v2 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h

2022-07-07 Thread kernel test robot
Hi Christophe, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on mkp-scsi/for-next jejb-scsi/for-next linus/master v5.19-rc5 next-20220707] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[PATCH v2 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h

2022-07-07 Thread Christophe Leroy
asm/pci.h and asm/mpc52xx.h don't need asm/prom.h Declare struct device_node locally to avoid including of.h Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/mpc52xx.h | 3 ++- arch/powerpc/include/asm/pci.h | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 4/4] powerpc: Finally remove unnecessary headers from asm/prom.h

2022-07-07 Thread Christophe Leroy
Remove all headers included from asm/prom.h which are not used by asm/prom.h itself. Declare struct device_node and struct property locally to avoid including of.h Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/prom.h | 10 ++ 1 file changed, 2 insertions(+), 8

Re: [PATCH v3 0/3] phase out CONFIG_VIRT_TO_BUS

2022-07-07 Thread Martin K. Petersen
On Fri, 24 Jun 2022 17:52:23 +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The virt_to_bus/bus_to_virt interface has been deprecated for > decades. After Jakub Kicinski put a lot of work into cleaning out the > network drivers using them, there are only a couple of other drivers > left,

Re: [PATCH v2 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h

2022-07-07 Thread kernel test robot
Hi Christophe, I love your patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on mkp-scsi/for-next jejb-scsi/for-next linus/master v5.19-rc5 next-20220707] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH v5] random: remove CONFIG_ARCH_RANDOM

2022-07-07 Thread Jason A. Donenfeld
When RDRAND was introduced, there was much discussion on whether it should be trusted and how the kernel should handle that. Initially, two mechanisms cropped up, CONFIG_ARCH_RANDOM, a compile time switch, and "nordrand", a boot-time switch. Later the thinking evolved. With a properly designed

Re: [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-07 Thread Guenter Roeck
undation.org, keyri...@vger.kernel.org, net...@vger.kernel.org, k...@vger.kernel.org, da...@lists.linux.dev, linux...@kvack.org, accessrunner-gene...@lists.sourceforge.net, linux1394-de...@lists.sourceforge.net, linux-l...@vger.kernel.org, rds-de...@oss.oracle.com, linux-...@vger.kernel.org,

[PATCH v6 2/6] drivers: of: kexec ima: Support 32-bit platforms

2022-07-07 Thread Stefan Berger
From: Palmer Dabbelt RISC-V recently added kexec_file() support, which uses enables kexec IMA. We're the first 32-bit platform to support this, so we found a build bug. Acked-by: Rob Herring Signed-off-by: Palmer Dabbelt Reviewed-by: Mimi Zohar --- drivers/of/kexec.c | 4 ++-- 1 file

[PATCH v6 3/6] x86/kexec: Carry forward IMA measurement log on kexec

2022-07-07 Thread Stefan Berger
From: Jonathan McDowell On kexec file load, the Integrity Measurement Architecture (IMA) subsystem may verify the IMA signature of the kernel and initramfs, and measure it. The command line parameters passed to the kernel in the kexec call may also be measured by IMA. A remote attestation

[PATCH v6 0/6] tpm: Preserve TPM measurement log across kexec (ppc64)

2022-07-07 Thread Stefan Berger
The of-tree subsystem does not currently preserve the IBM vTPM 1.2 and vTPM 2.0 measurement logs across a kexec on PowerVM and PowerKVM. This series fixes this for the kexec_file_load() syscall using the flattened device tree (fdt) to carry the TPM measurement log's buffer across kexec. Stefan

[PATCH v6 4/6] tpm: of: Make of-tree specific function commonly available

2022-07-07 Thread Stefan Berger
Simplify tpm_read_log_of() by moving reusable parts of the code into an inline function that makes it commonly available so it can be used also for kexec support. Call the new of_tpm_get_sml_parameters() function from the TPM Open Firmware driver. Signed-off-by: Stefan Berger Cc: Jarkko Sakkinen

Re: [PATCH v2 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h

2022-07-07 Thread kernel test robot
Hi Christophe, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on mkp-scsi/for-next jejb-scsi/for-next linus/master v5.19-rc5 next-20220707] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[PATCH v6 5/6] of: kexec: Refactor IMA buffer related functions to make them reusable

2022-07-07 Thread Stefan Berger
Refactor IMA buffer related functions to make them reusable for carrying TPM logs across kexec. Signed-off-by: Stefan Berger Cc: Rob Herring Cc: Frank Rowand Cc: Mimi Zohar --- v6: - Add __init to get_kexec_buffer as suggested by Jonathan v5: - Rebased on Jonathan McDowell's commit

[PATCH v6 1/6] of: check previous kernel's ima-kexec-buffer against memory bounds

2022-07-07 Thread Stefan Berger
From: Vaibhav Jain Presently ima_get_kexec_buffer() doesn't check if the previous kernel's ima-kexec-buffer lies outside the addressable memory range. This can result in a kernel panic if the new kernel is booted with 'mem=X' arg and the ima-kexec-buffer was allocated beyond that range by the

[PATCH v6 6/6] tpm/kexec: Duplicate TPM measurement log in of-tree for kexec

2022-07-07 Thread Stefan Berger
The memory area of the TPM measurement log is currently not properly duplicated for carrying it across kexec when an Open Firmware Devicetree is used. Therefore, the contents of the log get corrupted. Fix this for the kexec_file_load() syscall by allocating a buffer and copying the contents of the

Re: [PATCH v2 4/4] watchdog/pseries-wdt: initial support for H_WATCHDOG-based watchdog timers

2022-07-07 Thread Scott Cheloha
On Fri, Jun 24, 2022 at 11:27:24PM +1000, Michael Ellerman wrote: > Hi Scott, > > A few comments below ... > > Scott Cheloha writes: > > > > [...] > > > > diff --git a/Documentation/watchdog/watchdog-parameters.rst > > b/Documentation/watchdog/watchdog-parameters.rst > > index

Re: [PATCH kernel] powerpc/iommu: Add iommu_ops to report capabilities and allow blocking domains

2022-07-07 Thread Alexey Kardashevskiy
On 7/8/22 01:10, Jason Gunthorpe wrote: On Thu, Jul 07, 2022 at 11:55:52PM +1000, Alexey Kardashevskiy wrote: Historically PPC64 managed to avoid using iommu_ops. The VFIO driver uses a SPAPR TCE sub-driver and all iommu_ops uses were kept in the Type1 VFIO driver. Recent development though

[PATCH 3/3] powerpc/platforms/83xx/suspend: Remove write-only global variable

2022-07-07 Thread Uwe Kleine-König
pmc_dev is only assigned in .probe(), otherwise the variable is unused. So drop this pointer that serves no purpose. Signed-off-by: Uwe Kleine-König --- arch/powerpc/platforms/83xx/suspend.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/platforms/83xx/suspend.c

[PATCH 2/3] powerpc/platforms/83xx/suspend: Prevent unloading the driver

2022-07-07 Thread Uwe Kleine-König
Returning an error in .remove() doesn't prevent a driver from being unloaded. On unbind this only results in an error message, but the device is remove anyhow. I guess the author's idea of just returning -EPERM in .remove() was to prevent unbinding a device. To achieve that set the

[PATCH 1/3] powerpc/platforms/83xx/suspend: Reorder to get rid of a forward declaration

2022-07-07 Thread Uwe Kleine-König
By moving up pmc_types and pmc_match, the forward declaration for pmc_match can be dropped. Signed-off-by: Uwe Kleine-König --- arch/powerpc/platforms/83xx/suspend.c | 43 +-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git