Re: [PATCH v2 04/10] drm/simpledrm: Compute framebuffer stride if not set

2022-07-27 Thread Thomas Zimmermann
Hi Am 25.07.22 um 17:13 schrieb Javier Martinez Canillas: Hello Geert, On 7/21/22 16:46, Geert Uytterhoeven wrote: Hi Thomas, On Wed, Jul 20, 2022 at 4:27 PM Thomas Zimmermann wrote: Compute the framebuffer's scanline stride length if not given by the simplefb data. Signed-off-by: Thomas

Re: [PATCH v2 06/10] drm/simpledrm: Move some functionality into fwfb helper library

2022-07-27 Thread Thomas Zimmermann
Hi Am 25.07.22 um 18:23 schrieb Javier Martinez Canillas: On 7/20/22 16:27, Thomas Zimmermann wrote: Move some of simpledrm's functionality into a helper library. Other drivers for firmware-provided framebuffers will also need functions to handle fixed modes and color formats, or update the

[PATCH] watchdog: Fix build error when CONFIG_SOFTLOCKUP_DETECTOR is not set

2022-07-27 Thread Laurent Dufour
Sachin reported the following build error when CONFIG_SOFTLOCKUP_DETECTOR is not set: kernel/watchdog.c:597:20: error: static declaration of 'lockup_detector_reconfigure' follows non-static declaration static inline void lockup_detector_reconfigure(void)

Re: [PATCH v3] PCI/ERR: Use pcie_aer_is_native() to judge whether OS owns AER

2022-07-27 Thread Zhuo Chen
On 7/26/22 1:35 PM, Zhuo Chen wrote: On 7/26/22 9:02 PM, Sathyanarayanan Kuppuswamy wrote: On 7/26/22 8:53 PM, Zhuo Chen wrote: Use pcie_aer_is_native() in place of "host->native_aer || pcie_ports_native" to judge whether OS has native control of AER in pcie_do_recovery(). Replace

[linux-next] Build failure kernel/watchdog [powerpc]

2022-07-27 Thread Sachin Sant
Linux-next (5.19.0-rc8-next-20220726) fails to build on powerpc with following error: kernel/watchdog.c:597:20: error: static declaration of 'lockup_detector_reconfigure' follows non-static declaration static inline void lockup_detector_reconfigure(void)

Re: [PATCH v2 02/10] drm/simpledrm: Inline device-init helpers

2022-07-27 Thread Javier Martinez Canillas
Hello Thomas, On 7/27/22 09:50, Thomas Zimmermann wrote: > Hi > > Am 25.07.22 um 17:01 schrieb Javier Martinez Canillas: >> Hello Thomas, >> >> On 7/20/22 16:27, Thomas Zimmermann wrote: >>> Inline the helpers for initializing the hardware FB, the memory >>> management and the modesetting into

Re: [PATCH v2 06/10] drm/simpledrm: Move some functionality into fwfb helper library

2022-07-27 Thread Javier Martinez Canillas
On 7/27/22 10:24, Thomas Zimmermann wrote: > Hi > > Am 25.07.22 um 18:23 schrieb Javier Martinez Canillas: >> On 7/20/22 16:27, Thomas Zimmermann wrote: >>> Move some of simpledrm's functionality into a helper library. Other >>> drivers for firmware-provided framebuffers will also need functions

Re: [PATCH v2 05/10] drm/simpledrm: Convert to atomic helpers

2022-07-27 Thread Thomas Zimmermann
Hi Am 25.07.22 um 17:46 schrieb Javier Martinez Canillas: On 7/20/22 16:27, Thomas Zimmermann wrote: Replace the simple-KMS helpers with the regular atomic helpers. The regular helpers are better architectured and therefore allow for easier code sharing among drivers. No functional changes.

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-07-27 Thread Javier Martinez Canillas
On 7/27/22 10:41, Thomas Zimmermann wrote: [...] >> >>> +static void __iomem *ofdrm_mach64_cmap_ioremap(struct ofdrm_device *odev, >>> + struct device_node *of_node, >>> + u64 fb_base) >>> +{ >>> + struct

Re: [PATCH] watchdog: Fix build error when CONFIG_SOFTLOCKUP_DETECTOR is not set

2022-07-27 Thread Sachin Sant
> The definition of lockup_detector_reconfigure should be exported even in > that case, and __lockup_detector_reconfigure should remain static. > > Fixes: 24a1260705b7 ("watchdog: export lockup_detector_reconfigure") > Reported-by: Sachin Sant > Signed-off-by: Laurent Dufour > --- >

Re: [PATCH] watchdog: Fix build error when CONFIG_SOFTLOCKUP_DETECTOR is not set

2022-07-27 Thread Michael Ellerman
Laurent Dufour writes: > Sachin reported the following build error when CONFIG_SOFTLOCKUP_DETECTOR > is not set: > > kernel/watchdog.c:597:20: error: static declaration of > 'lockup_detector_reconfigure' follows non-static declaration > static inline void lockup_detector_reconfigure(void) >

Re: [PATCH v2 02/10] drm/simpledrm: Inline device-init helpers

2022-07-27 Thread Thomas Zimmermann
Hi Am 25.07.22 um 17:01 schrieb Javier Martinez Canillas: Hello Thomas, On 7/20/22 16:27, Thomas Zimmermann wrote: Inline the helpers for initializing the hardware FB, the memory management and the modesetting into the device-creation function. No functional changes. Could you please

Re: [PATCH v2 09/10] drm/ofdrm: Add per-model device function

2022-07-27 Thread Thomas Zimmermann
Hi Am 26.07.22 um 21:22 schrieb Javier Martinez Canillas: Hello Michal, On 7/26/22 16:40, Michal Suchánek wrote: Hello, On Tue, Jul 26, 2022 at 03:38:37PM +0200, Javier Martinez Canillas wrote: On 7/20/22 16:27, Thomas Zimmermann wrote: Add a per-model device-function structure in

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-07-27 Thread Thomas Zimmermann
Hi Am 26.07.22 um 15:49 schrieb Javier Martinez Canillas: On 7/20/22 16:27, Thomas Zimmermann wrote: Support the CRTC's color-management property and implement each model's palette support. The OF hardware has different methods of setting the palette. The respective code has been taken from

[PATCH v6 2/3] powerpc/powernv/kvm: Use darn for H_RANDOM on Power9

2022-07-27 Thread Michael Ellerman
From: "Jason A. Donenfeld" The existing logic in KVM to support guests calling H_RANDOM only works on Power8, because it looks for an RNG in the device tree, but on Power9 we just use darn. In addition the existing code needs to work in real mode, so we have the special cased

[PATCH v6 1/3] powerpc/powernv: Avoid crashing if rng is NULL

2022-07-27 Thread Michael Ellerman
On a bare-metal Power8 system that doesn't have an "ibm,power-rng", a malicious QEMU and guest that ignore the absence of the KVM_CAP_PPC_HWRNG flag, and calls H_RANDOM anyway, will dereference a NULL pointer. In practice all Power8 machines have an "ibm,power-rng", but let's not rely on that,

Re: [PATCH] watchdog: Fix build error when CONFIG_SOFTLOCKUP_DETECTOR is not set

2022-07-27 Thread Laurent Dufour
Le 27/07/2022 à 13:38, Michael Ellerman a écrit : > Laurent Dufour writes: >> Sachin reported the following build error when CONFIG_SOFTLOCKUP_DETECTOR >> is not set: >> >> kernel/watchdog.c:597:20: error: static declaration of >> 'lockup_detector_reconfigure' follows non-static declaration >>

[PATCH v6 3/3] powerpc/powernv: rename remaining rng powernv_ functions to pnv_

2022-07-27 Thread Michael Ellerman
From: "Jason A. Donenfeld" The preferred nomenclature is pnv_, not powernv_, but rng.c used powernv_ for some reason, which isn't consistent with the rest. A recent commit added a few pnv_ functions to rng.c, making the file a bit of a mishmash. This commit just replaces the rest of them.

Re: [PATCH] powerpc/64s: Disable stack variable initialisation for prom_init

2022-07-27 Thread Michael Ellerman
On Mon, 18 Jul 2022 23:44:18 +1000, Michael Ellerman wrote: > With GCC 12 allmodconfig prom_init fails to build: > > Error: External symbol 'memset' referenced from prom_init.c > make[2]: *** [arch/powerpc/kernel/Makefile:204: > arch/powerpc/kernel/prom_init_check] Error 1 > > The

Re: [PATCH v2 1/2] powerpc/pci: Add config option for using OF 'reg' for PCI domain

2022-07-27 Thread Michael Ellerman
Pali Rohár writes: > Since commit 63a72284b159 ("powerpc/pci: Assign fixed PHB number based on > device-tree properties"), powerpc kernel always fallback to PCI domain > assignment from OF / Device Tree 'reg' property of the PCI controller. > > In most cases 'reg' property is not zero and

linux-next: build warnings after merge of the powerpc tree

2022-07-27 Thread Stephen Rothwell
Hi all, After merging the powerpc tree, today's linux-next build (htmldocs) produces these warnings: Documentation/powerpc/elf_hwcaps.rst:82: WARNING: Unexpected indentation. Documentation/powerpc/elf_hwcaps.rst:100: WARNING: Unexpected indentation. Documentation/powerpc/elf_hwcaps.rst:117:

Re: [PATCH -next v3 2/2] powerpc: add support for syscall stack randomization

2022-07-27 Thread Kees Cook
On Fri, Jul 01, 2022 at 04:24:35PM +0800, Xiu Jianfeng wrote: > Add support for adding a random offset to the stack while handling > syscalls. This patch uses mftb() instead of get_random_int() for better > performance. > > In order to avoid unconditional stack canaries on syscall entry (due to >

[PATCH 2/3] Documentation: use different label names for each arch's elf_hwcaps.rst

2022-07-27 Thread Bagas Sanjaya
Sphinx reported duplicate label warning: WARNING: duplicate label elf_hwcaps_index, other instance in Documentation/arm64/elf_hwcaps.rst The warning is caused by elf_hwcaps_index label name is already used for arm64 documentation, whileas powerpc use the same name. Disambiguate the label name

Re: [PATCH] watchdog: Fix build error when CONFIG_SOFTLOCKUP_DETECTOR is not set

2022-07-27 Thread Michael Ellerman
Laurent Dufour writes: > Le 27/07/2022 à 13:38, Michael Ellerman a écrit : >> Laurent Dufour writes: >>> Sachin reported the following build error when CONFIG_SOFTLOCKUP_DETECTOR >>> is not set: >>> >>> kernel/watchdog.c:597:20: error: static declaration of >>> 'lockup_detector_reconfigure'

[PATCH 1/3] Documentation: powerpc: fix indentation warnings

2022-07-27 Thread Bagas Sanjaya
Sphinx reported unexpected indentation warnings: Documentation/powerpc/elf_hwcaps.rst:82: WARNING: Unexpected indentation. Documentation/powerpc/elf_hwcaps.rst:100: WARNING: Unexpected indentation. Documentation/powerpc/elf_hwcaps.rst:117: WARNING: Unexpected indentation.

[PATCH 3/3] Documentation: powerpc: add elf_hwcaps to table of contents

2022-07-27 Thread Bagas Sanjaya
elf_hwcaps documentation is missing from table of contents at index.rst, hence triggers Sphinx warning: Documentation/powerpc/elf_hwcaps.rst: WARNING: document isn't included in any toctree Add the documentation to the index to fix the warning. Link:

[PATCH 0/3] Documentation: powerpc: documentation fixes for Documentation/powerpc/elf_hwcaps.rst

2022-07-27 Thread Bagas Sanjaya
After merging powerpc tree for linux-next integration testing, Stephen Rothwell reported htmldocs warnings at [1]. Fix these with self-explanatory fixes in the shortlog below. [1]: https://lore.kernel.org/linuxppc-dev/20220727220050.549db...@canb.auug.org.au/ Bagas Sanjaya (3): Documentation: