Re: [PATCH] MAINTAINERS: Remove myself as EEH maintainer

2022-08-11 Thread Michael Ellerman
Russell Currey writes: > I haven't touched EEH in a long time I don't have much knowledge of the > subsystem at this point either, so it's misleading to have me as a > maintainer. Thank you for your service. > I remain grateful to Oliver for picking up my slack over the years. Ack. But I

Re: [PATCH] MAINTAINERS: Remove myself as EEH maintainer

2022-08-11 Thread Oliver O'Halloran
On Thu, Aug 11, 2022 at 4:22 PM Michael Ellerman wrote: > > Russell Currey writes: > > I haven't touched EEH in a long time I don't have much knowledge of the > > subsystem at this point either, so it's misleading to have me as a > > maintainer. > > Thank you for your service. > > > I remain

Re: [PATCHv3, resend] powerpc: mm: radix_tlb: rearrange the if-else block

2022-08-11 Thread Michael Ellerman
Anders Roxell writes: > Clang warns: > > arch/powerpc/mm/book3s64/radix_tlb.c:1191:23: error: variable 'hstart' is > uninitialized when used here [-Werror,-Wuninitialized] > __tlbiel_va_range(hstart, hend, pid, >

[5.19.0-next-20220811] Build failure drivers/vdpa

2022-08-11 Thread Sachin Sant
5.19.0-next-20220811 linux-next fails to build on IBM Power with following error: drivers/vdpa/vdpa_sim/vdpa_sim_blk.c: In function 'vdpasim_blk_handle_req': drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:201:3: error: a label can only be part of a statement and a declaration is not a statement struct

Re: [PATCH v2 11/14] powerpc/64s: Clear/restore caller gprs in syscall interrupt/return

2022-08-11 Thread Andrew Donnellan
On Mon, 2022-07-25 at 16:31 +1000, Rohan McLure wrote: > Clear user state in gprs (assign to zero) to reduce the influence of > user > registers on speculation within kernel syscall handlers. Clears occur > at the very beginning of the sc and scv 0 interrupt handlers, with > restores occurring

Re: [5.19.0-next-20220811] Build failure drivers/vdpa

2022-08-11 Thread Stefano Garzarella
On Thu, Aug 11, 2022 at 12:06 PM Sachin Sant wrote: > > 5.19.0-next-20220811 linux-next fails to build on IBM Power with > following error: > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c: In function 'vdpasim_blk_handle_req': > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:201:3: error: a labe

Re: [5.19.0-next-20220811] Build failure drivers/vdpa

2022-08-11 Thread Sachin Sant
> On 11-Aug-2022, at 3:45 PM, Stefano Garzarella wrote: > >> Date: Wed Aug 10 11:43:47 2022 +0200 >>vdpa_sim_blk: add support for discard and write-zeroes >> > > Thanks for the report, I already re-sent a new series with that patch fixed: >

Re: [PATCHv3, resend] powerpc: mm: radix_tlb: rearrange the if-else block

2022-08-11 Thread Anders Roxell
On Thu, 11 Aug 2022 at 11:41, Michael Ellerman wrote: > > Anders Roxell writes: > > Clang warns: > > > > arch/powerpc/mm/book3s64/radix_tlb.c:1191:23: error: variable 'hstart' is > > uninitialized when used here [-Werror,-Wuninitialized] > >

Re: [PATCH v2 11/14] powerpc/64s: Clear/restore caller gprs in syscall interrupt/return

2022-08-11 Thread Segher Boessenkool
Hi! On Mon, Jul 25, 2022 at 04:31:11PM +1000, Rohan McLure wrote: > + /* > + * Zero user registers to prevent influencing speculative execution > + * state of kernel code. > + */ > + NULLIFY_GPRS(5, 12) > + NULLIFY_NVGPRS() "Nullify" means "invalidate", which is not

Re: [PATCH v2 04/10] drm/simpledrm: Compute framebuffer stride if not set

2022-08-11 Thread Thomas Zimmermann
Am 11.08.22 um 20:26 schrieb Thomas Zimmermann: Hi Daniel Am 11.08.22 um 19:23 schrieb Daniel Vetter: On Wed, 27 Jul 2022 at 09:53, Thomas Zimmermann wrote: Hi Am 25.07.22 um 17:13 schrieb Javier Martinez Canillas: Hello Geert, On 7/21/22 16:46, Geert Uytterhoeven wrote: Hi Thomas,

Re: [PATCH v2 04/10] drm/simpledrm: Compute framebuffer stride if not set

2022-08-11 Thread Thomas Zimmermann
Hi Daniel Am 11.08.22 um 19:23 schrieb Daniel Vetter: On Wed, 27 Jul 2022 at 09:53, Thomas Zimmermann wrote: Hi Am 25.07.22 um 17:13 schrieb Javier Martinez Canillas: Hello Geert, On 7/21/22 16:46, Geert Uytterhoeven wrote: Hi Thomas, On Wed, Jul 20, 2022 at 4:27 PM Thomas Zimmermann

Re: [PATCH v2 04/10] drm/simpledrm: Compute framebuffer stride if not set

2022-08-11 Thread Daniel Vetter
On Wed, 27 Jul 2022 at 09:53, Thomas Zimmermann wrote: > > Hi > > Am 25.07.22 um 17:13 schrieb Javier Martinez Canillas: > > Hello Geert, > > > > On 7/21/22 16:46, Geert Uytterhoeven wrote: > >> Hi Thomas, > >> > >> On Wed, Jul 20, 2022 at 4:27 PM Thomas Zimmermann > >> wrote: > >>> Compute the

Re: [PATCH 15/17] powerpc/qspinlock: reduce remote node steal spins

2022-08-11 Thread Jordan Niethe
On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > Allow for a reduction in the number of times a CPU from a different > node than the owner can attempt to steal the lock before queueing. > This could bias the transfer behaviour of the lock across the > machine and reduce NUMA crossings.

Re: [PATCH 09/17] powerpc/qspinlock: implement option to yield to previous node

2022-08-11 Thread Jordan Niethe
On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > Queued waiters which are not at the head of the queue don't spin on > the lock word but their qnode lock word, waiting for the previous queued > CPU to release them. Add an option which allows these waiters to yield > to the previous CPU

Re: [PATCH 12/17] powerpc/qspinlock: add ability to prod new queue head CPU

2022-08-11 Thread Jordan Niethe
On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > After the head of the queue acquires the lock, it releases the > next waiter in the queue to become the new head. Add an option > to prod the new head if its vCPU was preempted. This may only > have an effect if queue waiters are

Re: [RESEND PATCH 2/2] lib/nodemask: inline next_node_in() and node_random()

2022-08-11 Thread Aneesh Kumar K.V
Yury Norov writes: > The functions are pretty thin wrappers around find_bit engine, and > keeping them in c-file prevents compiler from small_const_nbits() > optimization, which must take place for all systems with MAX_NUMNODES > less than BITS_PER_LONG (default is 16 for me). > > Moving them to

Re: [RESEND PATCH 2/2] lib/nodemask: inline next_node_in() and node_random()

2022-08-11 Thread Yury Norov
On Fri, Aug 12, 2022 at 10:46:57AM +0530, Aneesh Kumar K.V wrote: > Yury Norov writes: > > > The functions are pretty thin wrappers around find_bit engine, and > > keeping them in c-file prevents compiler from small_const_nbits() > > optimization, which must take place for all systems with

Re: [PATCH 07/17] powerpc/qspinlock: store owner CPU in lock word

2022-08-11 Thread Jordan Niethe
On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > Store the owner CPU number in the lock word so it may be yielded to, > as powerpc's paravirtualised simple spinlocks do. > --- > arch/powerpc/include/asm/qspinlock.h | 8 +++- > arch/powerpc/include/asm/qspinlock_types.h | 10

Re: [PATCH 16/17] powerpc/qspinlock: allow indefinite spinning on a preempted owner

2022-08-11 Thread Jordan Niethe
On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > Provide an option that holds off queueing indefinitely while the lock > owner is preempted. This could reduce queueing latencies for very > overcommitted vcpu situations. > > This is disabled by default. > --- >

Re: [PATCH 13/17] powerpc/qspinlock: trylock and initial lock attempt may steal

2022-08-11 Thread Jordan Niethe
On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > This gives trylock slightly more strength, and it also gives most > of the benefit of passing 'val' back through the slowpath without > the complexity. > --- > arch/powerpc/include/asm/qspinlock.h | 39 +++- >

Re: [PATCH 08/17] powerpc/qspinlock: paravirt yield to lock owner

2022-08-11 Thread Jordan Niethe
On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > Waiters spinning on the lock word should yield to the lock owner if the > vCPU is preempted. This improves performance when the hypervisor has > oversubscribed physical CPUs. > --- > arch/powerpc/lib/qspinlock.c | 97

[PATCH] lib: remove lib/nodemask.c

2022-08-11 Thread Yury Norov
Commit 36d4b36b69590 (lib/nodemask: inline next_node_in() and node_random()) removed the lib/nodemask.c file, but the remove didn't happen when the patch was applied. Reported-by: "Aneesh Kumar K.V" Signed-off-by: Yury Norov --- lib/nodemask.c | 23 --- 1 file changed, 23

Re: [PATCH 10/17] powerpc/qspinlock: allow stealing when head of queue yields

2022-08-11 Thread Jordan Niethe
On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > If the head of queue is preventing stealing but it finds the owner vCPU > is preempted, it will yield its cycles to the owner which could cause it > to become preempted. Add an option to re-allow stealers before yielding, > and disallow

Re: [PATCH 14/17] powerpc/qspinlock: use spin_begin/end API

2022-08-11 Thread Jordan Niethe
On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > Use the spin_begin/spin_cpu_relax/spin_end APIs in qspinlock, which helps > to prevent threads issuing a lot of expensive priority nops which may not > have much effect due to immediately executing low then medium priority. Just a

Re: [PATCH 11/17] powerpc/qspinlock: allow propagation of yield CPU down the queue

2022-08-11 Thread Jordan Niethe
On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > Having all CPUs poll the lock word for the owner CPU that should be > yielded to defeats most of the purpose of using MCS queueing for > scalability. Yet it may be desirable for queued waiters to to yield > to a preempted owner. > > s390

[PATCH AUTOSEL 5.19 065/105] crypto: vmx - Fix warning on p8_ghash_alg

2022-08-11 Thread Sasha Levin
From: Herbert Xu [ Upstream commit cc8166bfc829043020b5cc3b7cdba02a17d03b6d ] The compiler complains that p8_ghash_alg isn't declared which is because the header file aesp8-ppc.h isn't included in ghash.c. This patch fixes the warning. Signed-off-by: Herbert Xu Acked-by: Breno Leitao

Re: [PATCH v2 11/14] powerpc/64s: Clear/restore caller gprs in syscall interrupt/return

2022-08-11 Thread Christophe Leroy
Le 11/08/2022 à 17:13, Segher Boessenkool a écrit : > Hi! > > On Mon, Jul 25, 2022 at 04:31:11PM +1000, Rohan McLure wrote: >> +/* >> + * Zero user registers to prevent influencing speculative execution >> + * state of kernel code. >> + */ >> +NULLIFY_GPRS(5, 12) >> +

[PATCH AUTOSEL 5.18 58/93] crypto: vmx - Fix warning on p8_ghash_alg

2022-08-11 Thread Sasha Levin
From: Herbert Xu [ Upstream commit cc8166bfc829043020b5cc3b7cdba02a17d03b6d ] The compiler complains that p8_ghash_alg isn't declared which is because the header file aesp8-ppc.h isn't included in ghash.c. This patch fixes the warning. Signed-off-by: Herbert Xu Acked-by: Breno Leitao

Re: [PATCH v2 11/14] powerpc/64s: Clear/restore caller gprs in syscall interrupt/return

2022-08-11 Thread Segher Boessenkool
On Thu, Aug 11, 2022 at 03:39:58PM +, Christophe Leroy wrote: > > > Le 11/08/2022 à 17:13, Segher Boessenkool a écrit : > > Hi! > > > > On Mon, Jul 25, 2022 at 04:31:11PM +1000, Rohan McLure wrote: > >> + /* > >> + * Zero user registers to prevent influencing speculative execution > >> +

[PATCH AUTOSEL 5.15 48/69] crypto: vmx - Fix warning on p8_ghash_alg

2022-08-11 Thread Sasha Levin
From: Herbert Xu [ Upstream commit cc8166bfc829043020b5cc3b7cdba02a17d03b6d ] The compiler complains that p8_ghash_alg isn't declared which is because the header file aesp8-ppc.h isn't included in ghash.c. This patch fixes the warning. Signed-off-by: Herbert Xu Acked-by: Breno Leitao

[PATCH AUTOSEL 5.10 30/46] crypto: vmx - Fix warning on p8_ghash_alg

2022-08-11 Thread Sasha Levin
From: Herbert Xu [ Upstream commit cc8166bfc829043020b5cc3b7cdba02a17d03b6d ] The compiler complains that p8_ghash_alg isn't declared which is because the header file aesp8-ppc.h isn't included in ghash.c. This patch fixes the warning. Signed-off-by: Herbert Xu Acked-by: Breno Leitao

[PATCH AUTOSEL 5.4 15/25] crypto: vmx - Fix warning on p8_ghash_alg

2022-08-11 Thread Sasha Levin
From: Herbert Xu [ Upstream commit cc8166bfc829043020b5cc3b7cdba02a17d03b6d ] The compiler complains that p8_ghash_alg isn't declared which is because the header file aesp8-ppc.h isn't included in ghash.c. This patch fixes the warning. Signed-off-by: Herbert Xu Acked-by: Breno Leitao

[PATCH AUTOSEL 4.19 08/14] crypto: vmx - Fix warning on p8_ghash_alg

2022-08-11 Thread Sasha Levin
From: Herbert Xu [ Upstream commit cc8166bfc829043020b5cc3b7cdba02a17d03b6d ] The compiler complains that p8_ghash_alg isn't declared which is because the header file aesp8-ppc.h isn't included in ghash.c. This patch fixes the warning. Signed-off-by: Herbert Xu Acked-by: Breno Leitao

[PATCH AUTOSEL 4.14 08/14] crypto: vmx - Fix warning on p8_ghash_alg

2022-08-11 Thread Sasha Levin
From: Herbert Xu [ Upstream commit cc8166bfc829043020b5cc3b7cdba02a17d03b6d ] The compiler complains that p8_ghash_alg isn't declared which is because the header file aesp8-ppc.h isn't included in ghash.c. This patch fixes the warning. Signed-off-by: Herbert Xu Acked-by: Breno Leitao

[PATCH AUTOSEL 4.9 07/12] crypto: vmx - Fix warning on p8_ghash_alg

2022-08-11 Thread Sasha Levin
From: Herbert Xu [ Upstream commit cc8166bfc829043020b5cc3b7cdba02a17d03b6d ] The compiler complains that p8_ghash_alg isn't declared which is because the header file aesp8-ppc.h isn't included in ghash.c. This patch fixes the warning. Signed-off-by: Herbert Xu Acked-by: Breno Leitao