Re: [PATCH v5 0/6] DCP as trusted keys backend

2024-02-05 Thread David Gstir
Hi, > On 15.12.2023, at 12:06, David Gstir wrote: > > This is a revival of the previous patch set submitted by Richard Weinberger: > https://lore.kernel.org/linux-integrity/20210614201620.30451-1-rich...@nod.at/ > > v4 is here: >

Re: [PATCH v2 1/2] powerpc: Add Power11 architected and raw mode

2024-02-05 Thread Aneesh Kumar K . V
Madhavan Srinivasan writes: > reg.h is updated with Power11 pvr. pvr_mask value of 0x0F07 > means we are arch v3.1 compliant. > If it is called arch v3.1, it will conflict with. #define PVR_ARCH_31 0x0f06 >This is used by phyp and > kvm when booting as a pseries guest to detect

Re: [kvm-unit-tests PATCH v2 1/9] (arm|powerpc|s390x): Makefile: Fix .aux.o generation

2024-02-05 Thread Thomas Huth
On 02/02/2024 10.30, Andrew Jones wrote: On Fri, Feb 02, 2024 at 04:57:32PM +1000, Nicholas Piggin wrote: Using all prerequisites for the source file results in the build dying on the second time around with: gcc: fatal error: cannot specify ‘-o’ with ‘-c’, ‘-S’ or ‘-E’ with multiple files

Re: [kvm-unit-tests PATCH v2 3/9] arch-run: Clean up initrd cleanup

2024-02-05 Thread Thomas Huth
On 02/02/2024 07.57, Nicholas Piggin wrote: Rather than put a big script into the trap handler, have it call a function. Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/scripts/arch-run.bash

14:59,[Bisected] [commit dd6c3c544126] [linux-next] [6.8.0-rc2] Task hungs for infinite time call traces

2024-02-05 Thread Tasmiya Nalatwad
[linux-next] [6.8.0-rc2-next-20240130] [FC/XFS] Task hungs for infinite time while running bonnie test XFS filesystem Bisected the issue. Git bisect points to the below commit commit dd6c3c5441263723305a9c52c5ccc899a4653000   workqueue: Move pwq_dec_nr_in_flight() to the end of work

Re: [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y

2024-02-05 Thread Jan Stancek
On Mon, Feb 5, 2024 at 12:50 PM Michael Ellerman wrote: > > Jan Stancek writes: > > On Tue, Nov 21, 2023 at 10:51:34AM +1000, Nicholas Piggin wrote: > >>On Tue Nov 21, 2023 at 9:23 AM AEST, Masahiro Yamada wrote: > >>> crtsavres.o is linked to modules. However, as explained in commit > >>>

Re: [PATCH v2] KVM: PPC: Book3S HV: Fix L2 guest reboot failure due to empty 'arch_compat'

2024-02-05 Thread Aneesh Kumar K . V
Amit Machhiwal writes: > Currently, rebooting a pseries nested qemu-kvm guest (L2) results in > below error as L1 qemu sends PVR value 'arch_compat' == 0 via > ppc_set_compat ioctl. This triggers a condition failure in > kvmppc_set_arch_compat() resulting in an EINVAL. > > qemu-system-ppc64:

Re: [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y

2024-02-05 Thread Michael Ellerman
Jan Stancek writes: > On Tue, Nov 21, 2023 at 10:51:34AM +1000, Nicholas Piggin wrote: >>On Tue Nov 21, 2023 at 9:23 AM AEST, Masahiro Yamada wrote: >>> crtsavres.o is linked to modules. However, as explained in commit >>> d0e628cd817f ("kbuild: doc: clarify the difference between extra-y >>> and

[PATCH v2] KVM: PPC: Book3S HV: Fix L2 guest reboot failure due to empty 'arch_compat'

2024-02-05 Thread Amit Machhiwal
Currently, rebooting a pseries nested qemu-kvm guest (L2) results in below error as L1 qemu sends PVR value 'arch_compat' == 0 via ppc_set_compat ioctl. This triggers a condition failure in kvmppc_set_arch_compat() resulting in an EINVAL. qemu-system-ppc64: Unable to set CPU compatibility mode in

Re: Re: [PATCH v2 1/3] powerpc/code-patching: Add generic memory patching

2024-02-05 Thread Naveen N Rao
On Mon, Feb 05, 2024 at 01:30:46PM +1100, Benjamin Gray wrote: > On Thu, 2023-11-30 at 15:55 +0530, Naveen N Rao wrote: > > On Mon, Oct 16, 2023 at 04:01:45PM +1100, Benjamin Gray wrote: > > > > > > diff --git a/arch/powerpc/include/asm/code-patching.h > > >

Fwd: [Bisected] [commit dd6c3c544126] [linux-next] [6.8.0-rc2] Task hungs for infinite time call traces

2024-02-05 Thread Tasmiya Nalatwad
Forwarded Message Subject: [Bisected] [commit dd6c3c544126] [linux-next] [6.8.0-rc2] Task hungs for infinite time call traces Date: Mon, 5 Feb 2024 14:10:24 +0530 From: Tasmiya Nalatwad To: linux-ker...@vger.kernel.org , linuxppc-dev@lists.ozlabs.org ,

[Bisected] [commit dd6c3c544126] [linux-next] [6.8.0-rc2] Task hungs for infinite time call traces

2024-02-05 Thread Tasmiya Nalatwad
[linux-next] [6.8.0-rc2-next-20240130] [FC/XFS] Task hungs for infinite time while running bonnie test XFS filesystem Bisected the issue. Git bisect points to the below commit commit dd6c3c5441263723305a9c52c5ccc899a4653000   workqueue: Move pwq_dec_nr_in_flight() to the end of work

[Bisected] [commit dd6c3c544126] [linux-next] [6.8.0-rc2] Task hungs for infinite time call traces

2024-02-05 Thread Tasmiya Nalatwad
Greetings, [linux-next] [6.8.0-rc2-next-20240130] [FC/XFS] Task hungs for infinite time while running bonnie test XFS filesystem Bisected the issue. Git bisect points to the below commit commit dd6c3c5441263723305a9c52c5ccc899a4653000 Author: Tejun Heo --- Traces --- [ 981.280811] Call

Re: [kvm-unit-tests PATCH v2 4/9] migration: use a more robust way to wait for background job

2024-02-05 Thread Marc Hartmayer
On Fri, Feb 02, 2024 at 04:57 PM +1000, Nicholas Piggin wrote: > Starting a pipeline of jobs in the background does not seem to have > a simple way to reliably find the pid of a particular process in the > pipeline (because not all processes are started when the shell > continues to execute). >

Re: [kvm-unit-tests PATCH v2 1/9] (arm|powerpc|s390x): Makefile: Fix .aux.o generation

2024-02-05 Thread Marc Hartmayer
On Fri, Feb 02, 2024 at 04:57 PM +1000, Nicholas Piggin wrote: > Using all prerequisites for the source file results in the build > dying on the second time around with: > > gcc: fatal error: cannot specify ‘-o’ with ‘-c’, ‘-S’ or ‘-E’ with multiple > files > > This is due to auxinfo.h becoming

Re: Re: [PATCH v2] KVM: PPC: Book3S HV: Fix L2 guest reboot failure due to empty 'arch_compat'

2024-02-05 Thread Amit Machhiwal
Hi Vaibhav, Thanks for looking into the patch. On 2024/02/05 11:05 PM, Vaibhav Jain wrote: > Hi Amit, > > Thanks for the patch. Minor comment on the patch below: > > Amit Machhiwal writes: > > > > > > > +static inline unsigned long map_pcr_to_cap(unsigned long pcr) > > +{ > > +

[Bisected] [commit dd6c3c544126] [linux-next] [6.8.0-rc2] Task hungs for infinite time call traces

2024-02-05 Thread Tasmiya Nalatwad
Greetings, [Linux-next] [6.8.0-rc2-next-20240130] [FC / XFS] Task hangs for infinite time while running bonnie test XFS filesystem Bisected the issue. Git bisect points to the below commit commit dd6c3c5441263723305a9c52c5ccc899a4653000   workqueue: Move pwq_dec_nr_in_flight() to the

Re: [PATCH v2] KVM: PPC: Book3S HV: Fix L2 guest reboot failure due to empty 'arch_compat'

2024-02-05 Thread Vaibhav Jain
Hi Amit, Thanks for the patch. Minor comment on the patch below: Amit Machhiwal writes: > > +static inline unsigned long map_pcr_to_cap(unsigned long pcr) > +{ > + unsigned long cap = 0; > + > + switch (pcr) { > + case PCR_ARCH_300: > + cap = H_GUEST_CAP_POWER9; > +

[PATCH v3] KVM: PPC: Book3S HV: Fix L2 guest reboot failure due to empty 'arch_compat'

2024-02-05 Thread Amit Machhiwal
Currently, rebooting a pseries nested qemu-kvm guest (L2) results in below error as L1 qemu sends PVR value 'arch_compat' == 0 via ppc_set_compat ioctl. This triggers a condition failure in kvmppc_set_arch_compat() resulting in an EINVAL. qemu-system-ppc64: Unable to set CPU compatibility mode in

Re: [PATCH v2 1/6] net: wan: Add support for QMC HDLC

2024-02-05 Thread Herve Codina
Hi Paolo, On Thu, 01 Feb 2024 12:41:32 +0100 Paolo Abeni wrote: [...] > > +static inline struct qmc_hdlc *netdev_to_qmc_hdlc(struct net_device > > *netdev) > > +{ > > + return dev_to_hdlc(netdev)->priv; > > +} > > Please, no 'inline' function in c files. You could move this function > and

Re: [PATCH v2 1/6] net: wan: Add support for QMC HDLC

2024-02-05 Thread Herve Codina
On Mon, 05 Feb 2024 16:49:33 +0100 Paolo Abeni wrote: [... > > > > > > In general is quite bad that the existing infra does not allow > > > leveraging NAPI. Have you considered expanding the QMC to accomodate > > > such user? > > > > I cannot mask/unmask the 'end of transfer' interrupt. > >

Re: [Bisected] [commit dd6c3c544126] [linux-next] [6.8.0-rc2] Task hungs for infinite time call traces

2024-02-05 Thread Tejun Heo
Hello, On Mon, Feb 05, 2024 at 03:24:17PM +0530, Tasmiya Nalatwad wrote: > Greetings, > > [Linux-next] [6.8.0-rc2-next-20240130] [FC / XFS] Task hangs for infinite > time while running bonnie test XFS filesystem > > Bisected the issue. Git bisect points to the below commit > commit

Re: [PATCH v2 5/6] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support

2024-02-05 Thread Herve Codina
Hi Paolo, On Thu, 01 Feb 2024 13:01:51 +0100 Paolo Abeni wrote: [...] > > > > +static int qmc_hdlc_xlate_slot_map(struct qmc_hdlc *qmc_hdlc, > > + u32 slot_map, struct qmc_chan_ts_info > > *ts_info) > > +{ > > + DECLARE_BITMAP(ts_mask_avail, 64); > > +

Re: [PATCH v2 1/6] net: wan: Add support for QMC HDLC

2024-02-05 Thread Paolo Abeni
On Mon, 2024-02-05 at 15:22 +0100, Herve Codina wrote: > Hi Paolo, > > On Thu, 01 Feb 2024 12:41:32 +0100 > Paolo Abeni wrote: > > [...] > > > +static inline struct qmc_hdlc *netdev_to_qmc_hdlc(struct net_device > > > *netdev) > > > +{ > > > + return dev_to_hdlc(netdev)->priv; > > > +} > >

Re: [PATCH v2 1/4] PCI/AER: Store more information in aer_err_info

2024-02-05 Thread Bjorn Helgaas
On Thu, Jan 25, 2024 at 02:27:59PM +0800, Wang, Qingshun wrote: > When Advisory Non-Fatal errors are raised, both correctable and > uncorrectable error statuses will be set. The current kernel code cannot > store both statuses at the same time, thus failing to handle ANFE properly. > In addition,

Re: [PATCH v2 2/4] PCI/AER: Handle Advisory Non-Fatal properly

2024-02-05 Thread Bjorn Helgaas
In the subject, "properly" really doesn't convey information. I think this patch does two things: - Prints error bits that might be ANFE - Clears UNCOR_STATUS bits that were previously not cleared Maybe the subject line could say something about those (clearing UNCOR_STATUS might be more

Re: Build regressions/improvements in v6.8-rc1

2024-02-05 Thread Jesse Brandeburg
On 1/23/2024 3:45 AM, Geert Uytterhoeven wrote: > in drivers/net/ethernet/intel/ice/ice_base.c > > powerpc-gcc5/ppc32_allmodconfig > in drivers/net/ethernet/intel/ice/ice_nvm.c > > aarcharm64-gcc5/arm64-allmodconfig > powerpc-gcc5/ppc32_allmodconfig > powerpc-gcc5/powerpc-allmodconfig >

Re: [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y

2024-02-05 Thread Masahiro Yamada
On Mon, Feb 5, 2024 at 10:22 PM Jan Stancek wrote: > > On Mon, Feb 5, 2024 at 12:50 PM Michael Ellerman wrote: > > > > Jan Stancek writes: > > > On Tue, Nov 21, 2023 at 10:51:34AM +1000, Nicholas Piggin wrote: > > >>On Tue Nov 21, 2023 at 9:23 AM AEST, Masahiro Yamada wrote: > > >>> crtsavres.o

Re: [kvm-unit-tests PATCH v2 3/9] arch-run: Clean up initrd cleanup

2024-02-05 Thread Nicholas Piggin
On Mon Feb 5, 2024 at 10:04 PM AEST, Thomas Huth wrote: > On 02/02/2024 07.57, Nicholas Piggin wrote: > > Rather than put a big script into the trap handler, have it call > > a function. > > > > Signed-off-by: Nicholas Piggin > > --- > > scripts/arch-run.bash | 12 +++- > > 1 file

Re: [PATCH v2 1/2] powerpc: Add Power11 architected and raw mode

2024-02-05 Thread Madhavan Srinivasan
On 2/5/24 2:13 PM, Aneesh Kumar K.V wrote: Madhavan Srinivasan writes: reg.h is updated with Power11 pvr. pvr_mask value of 0x0F07 means we are arch v3.1 compliant. If it is called arch v3.1, it will conflict with. #define PVR_ARCH_31 0x0f06 Nice catch. My bad, missed to

Re: (subset) [PATCH 00/42] Fix coccicheck warnings

2024-02-05 Thread Martin K. Petersen
On Tue, 16 Jan 2024 12:10:47 +0800, Li Zhijian wrote: > make coccicheck COCCI=$PWD/scripts/coccinelle/api/device_attr_show.cocci` > complians some warnnings as following[1]: > > Not sure if someone had tried these fixes, feel free to ignore this > patch set if we have come to a *NOT-FIX*

Re: [kvm-unit-tests PATCH v2 4/9] migration: use a more robust way to wait for background job

2024-02-05 Thread Nicholas Piggin
On Tue Feb 6, 2024 at 12:58 AM AEST, Marc Hartmayer wrote: > On Fri, Feb 02, 2024 at 04:57 PM +1000, Nicholas Piggin > wrote: > > Starting a pipeline of jobs in the background does not seem to have > > a simple way to reliably find the pid of a particular process in the > > pipeline (because not