Re: [PATCH] rtc/rtc-opal: Enable alarms only when opal supports tpo

2015-07-22 Thread Alexandre Belloni
changed, 5 insertions(+), 4 deletions(-) Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org

Re: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular

2015-10-20 Thread Alexandre Belloni
state and allow building as a module. I think it currently fails because of console_initcall() but that is certainly fixable. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ___ Linuxppc-dev mai

Re: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular

2015-10-21 Thread Alexandre Belloni
On 20/10/2015 at 20:20:07 -0400, Paul Gortmaker wrote : > [Re: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular] > On 20/10/2015 (Tue 17:10) Alexandre Belloni wrote: > > > On 18/10/2015 at 18:21:13 -0400, Paul Gortmaker wrote : > > > The one co

Re: [PATCH] powerpc: Remove broken GregorianDay()

2015-12-15 Thread Alexandre Belloni
d drop the function. > (There are over a dozen other drivers in drivers/rtc that do > this.) > > Found using UBSAN. > > Cc: Andrey Ryabinin <aryabi...@virtuozzo.com> > Cc: Andrew Morton <a...@linux-foundation.org> # as an example of what UBSan > finds. > Cc: Al

Re: [PATCH v4 00/16] genrtc removal

2016-05-30 Thread Alexandre Belloni
en converted to a standard SPI driver in v4.6. Following some discussion, driving it using gpios will be added. m32r will have to use one of those two interfaces. It is broken on that architecture for now but we never got any reply from maintainers. -- Alexandre Belloni, Free Electrons Embedd

Re: [PATCH v3 00/16] genrtc removal

2016-05-29 Thread Alexandre Belloni
Hi, On 03/05/2016 at 12:05:34 +0200, Arnd Bergmann wrote : > On Tuesday 03 May 2016 09:24:18 Alexandre Belloni wrote: > > Hi Arnd, > > > > I see you didn't copy Greg on that series (that may explain his > > confusion on the previous patch), do you expect me to take

Re: [PATCH 4/6] parisc: rtc: provide rtc_class_ops directly

2016-03-09 Thread Alexandre Belloni
_generic_ops, > + sizeof(rtc_generic_ops)); > + > + spurious blank line > return PTR_ERR_OR_ZERO(pdev); > } > device_initcall(rtc_init); > -- > 2.7.0 > -- Alexandre Belloni, Free Electrons Embedded Linux,

Re: [PATCH 0/6] rtc: generic: follow up for COMPILE_TEST

2016-03-09 Thread Alexandre Belloni
can also remove the now unnecessary definitions from the various asm/rtc.h. I have a small nitpick on the parisc patch. I'll take the first patch, no need to resend that one. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com

Re: [PATCH 13/14] rtc: rtc-sa1100: DT spelling s/interrupt-name/interrupt-names/

2016-04-20 Thread Alexandre Belloni
On 20/04/2016 at 17:32:18 +0200, Geert Uytterhoeven wrote : > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> > --- > Documentation/devicetree/bindings/rtc/sa1100-rtc.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Be

Re: char: legacy RTC cleanups

2016-04-27 Thread Alexandre Belloni
them both. The remaining three > architectures (m68k, parisc, powerpc) actually all support > the newer rtc-generic driver, so we could remove genrtc completely > if we want to. > Personally, I'd go for the kill and remove genrtc instead of cleaning it up. -- Alexandre Belloni, Free El

Re: [PATCH 2/8] char/rtc: legacy RTC is no longer supported on x86

2016-04-27 Thread Alexandre Belloni
C drivers that contain a two older implementations of > the CONFIG_RTC_DRV_CMOS driver. > > This removes x86 from the list. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Two down, still four dr

Re: [PATCH 4/8] char/rtc: move mc146818rtc code out of asm-generic/rtc.h

2016-04-27 Thread Alexandre Belloni
The subject should be: rtc: cmos: move mc146818rtc code out of asm-generic/rtc.h Else, you can add: Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> On 26/04/2016 at 23:44:08 +0200, Arnd Bergmann wrote : > Drivers should not really include stuff from asm-generic

Re: [PATCH 3/8] char/rtc: remove empty asm/mc146818rtc.h files

2016-04-27 Thread Alexandre Belloni
> > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> > --- > arch/frv/include/asm/mc146818rtc.h| 16 > arch/h8300/include/asm/mc146818rtc.h | 9 - > arch/ia64/include/asm/mc146818r

Re: [PATCH v3 00/16] genrtc removal

2016-05-03 Thread Alexandre Belloni
class_ops directly > [PATCH v3 13/16] char/genrtc: remove powerpc support > [PATCH v3 14/16] rtc: generic: remove get_rtc_time/set_rtc_time > [PATCH v3 15/16] char/genrtc: remove asm-generic/rtc.h from mips > [PATCH v3 16/16] char/genrtc: remove the rest of the driver -- Alex

Re: [PATCH] rtc: rtctest: Improve support detection

2017-08-12 Thread Alexandre Belloni
INVAL) { > + if (errno == EINVAL || errno ==EIO) { > fprintf(stderr, > "\n...Alarm IRQs not supported.\n"); > goto test_PIE; > -- > 2.9.4 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [PATCH] rtc/tpo: Handle disabled TPO in opal_get_tpo_time()

2017-05-31 Thread Alexandre Belloni
n such a case. This signals generic rtc that no alarm is set and it > bails out from the alarm initialization flow without reporting the > above error. > > Signed-off-by: Vaibhav Jain <vaib...@linux.vnet.ibm.com> > Reported-by: Steve Best <sb...@redhat.com> > --- > d

Re: [PATCH] drivers/rtc/interface.c: Validate alarm-time before handling rollover

2017-05-31 Thread Alexandre Belloni
and if rtc_valid_tm() still > reports it to be invalid then bails out of the function without > handling the rollover. > > Reported-by: Steve Best <sb...@redhat.com> > Signed-off-by: Vaibhav Jain <vaib...@linux.vnet.ibm.com> > --- > drivers/rtc/interface.c | 9

[PATCH 1/3] RTC: rv3029: fix vendor string

2017-09-14 Thread Alexandre Belloni
The vendor string for Microcrystal is microcrystal. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- Documentation/devicetree/bindings/trivial-devices.txt | 2 +- drivers/rtc/rtc-rv3029c2.c| 2 ++ 2 files changed, 3 insertions(+), 1 de

[PATCH 2/3] ARM: dts: at91: usb_a9g20: fix rtc node

2017-09-14 Thread Alexandre Belloni
The rv3029 compatible is missing its vendor string, add it. Also fix the node name to be a proper generic name. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- arch/arm/boot/dts/usb_a9g20_common.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 3/3] powerpc/5200: dts: digsy_mtc.dts: fix rv3029 compatible

2017-09-14 Thread Alexandre Belloni
The proper compatible for rv3029 is microcrystal,rv3029. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- arch/powerpc/boot/dts/digsy_mtc.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/boot/dts/digsy_mtc.dts b/arch/powerp

Re: [PATCH 3/3] powerpc/5200: dts: digsy_mtc.dts: fix rv3029 compatible

2017-09-26 Thread Alexandre Belloni
Hi, On 15/09/2017 at 09:13:26 +0200, Anatolij Gustschin wrote: > On Fri, 15 Sep 2017 04:00:04 +0200 > Alexandre Belloni alexandre.bell...@free-electrons.com wrote: > > >The proper compatible for rv3029 is microcrystal,rv3029. > > > >Signed-off-by: Alexandre Bell

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Alexandre Belloni
to work > properly for these modified functions. > > Miscellanea: > > o Remove extra trailing ; and blank line from xfs_agf_verify > > Signed-off-by: Joe Perches <j...@perches.com> For RTC: Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> -- Alexandr

Re: [PATCH] char: nvram: disable on ARM

2018-02-07 Thread Alexandre Belloni
On 07/02/2018 at 16:47:00 +0100, Alexandre Belloni wrote: > > >> > I really don't think anyone is using that but I don't really know much > > >> > about x86 and the specification this may be part of. > > >> > > > >> > I see the info may b

Re: rtc-opal: Fix handling of firmware error codes, prevent busy loops

2018-02-06 Thread Alexandre Belloni
one through my tree but it was not sent to linux-rtc or me. I guess what happened is that Michael cleaned up the Linux PPC patchwork queue. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com

Re: [PATCH] char: nvram: disable on ARM

2018-02-06 Thread Alexandre Belloni
IOS) > FPU: not installed > I really don't think anyone is using that but I don't really know much about x86 and the specification this may be part of. I see the info may be used in drivers/video/fbdev/ and drivers/platform/x86/thinkpad_acpi.c -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com

Re: rtc-opal: Fix handling of firmware error codes, prevent busy loops

2018-02-06 Thread Alexandre Belloni
h I did. > > In future I'll ping you if there's something that seems to have fallen > through the cracks. > Great thanks! -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com

Re: [PATCH] char: nvram: disable on ARM

2018-02-07 Thread Alexandre Belloni
On 07/02/2018 at 15:00:04 +0100, Arnd Bergmann wrote: > On Wed, Feb 7, 2018 at 1:48 PM, Alexandre Belloni > <alexandre.bell...@bootlin.com> wrote: > > On 07/02/2018 at 11:33:55 +0100, Arnd Bergmann wrote: > >> On Wed, Feb 7, 2018 at 2:55 AM, Alexandre Belloni > &g

Re: [PATCH] char: nvram: disable on ARM

2018-02-07 Thread Alexandre Belloni
On 07/02/2018 at 11:33:55 +0100, Arnd Bergmann wrote: > On Wed, Feb 7, 2018 at 2:55 AM, Alexandre Belloni > <alexandre.bell...@bootlin.com> wrote: > > On 06/02/2018 at 23:55:02 +0100, Arnd Bergmann wrote: > >> * arch/arm/kernel/time.c has this code > >>

[PATCH] powerpc/time: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- arch/powerpc/kernel/time.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH RESEND] powerpc/5200: dts: digsy_mtc.dts: fix rv3029 compatible

2018-02-16 Thread Alexandre Belloni
The proper compatible for rv3029 is microcrystal,rv3029. Acked-by: Anatolij Gustschin <ag...@denx.de> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- Hi, I'm resending that one because I prefer not taking DT patches through the RTC tree. arch/powe

[PATCH 2/2] soc: fsl: qbman: qman: avoid allocating from non existing gen_pool

2018-08-23 Thread Alexandre Belloni
If the qman driver didn't probe, calling qman_alloc_fqid_range, qman_alloc_pool_range or qman_alloc_cgrid_range (as done in dpaa_eth) will pass a NULL pointer to gen_pool_alloc, leading to a NULL pointer dereference. Signed-off-by: Alexandre Belloni --- drivers/soc/fsl/qbman/qman.c | 3 +++ 1

[PATCH 1/2] soc: fsl: qbman: qman_portal: defer probing when qman is not available

2018-08-23 Thread Alexandre Belloni
that qman didn't probe when the pool mask is 0. Signed-off-by: Alexandre Belloni --- drivers/soc/fsl/qbman/qman_portal.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soc/fsl/qbman/qman_portal.c b/drivers/soc/fsl/qbman/qman_portal.c index a120002b630e..4fc80d2c8feb 100644

Re: [PATCH 2/3] powerpc/powernv: Fix OPAL RTC driver OPAL_BUSY loops

2018-04-10 Thread Alexandre Belloni
lse if (rc != OPAL_BUSY && rc != OPAL_BUSY_EVENT) > - break; > + } else if (rc == OPAL_BUSY) { > + msleep(OPAL_BUSY_DELAY_MS); > + } else if (rc == OPAL_HARDWARE || rc == OPAL_INTERNAL_ERROR) { > +

Re: [PATCH 2/3] powerpc/powernv: Fix OPAL RTC driver OPAL_BUSY loops

2018-04-24 Thread Alexandre Belloni
On 10/04/2018 23:01:36+1000, Nicholas Piggin wrote: > On Tue, 10 Apr 2018 14:07:28 +0200 > Alexandre Belloni <alexandre.bell...@bootlin.com> wrote: > > > Fixes ("powerpc/powernv: Add RTC and NVRAM support plus RTAS > > > fallbacks" > > > Cc:

Re: [PATCH 2/3] powerpc/powernv: Fix OPAL RTC driver OPAL_BUSY loops

2018-04-25 Thread Alexandre Belloni
On 25/04/2018 13:28:27+1000, Michael Ellerman wrote: > Alexandre Belloni <alexandre.bell...@bootlin.com> writes: > > On 10/04/2018 23:01:36+1000, Nicholas Piggin wrote: > >> On Tue, 10 Apr 2018 14:07:28 +0200 > >> Alexandre Belloni <alexandre.bell...@bootlin.co

Re: [PATCH 19/36] dt-bindings: arm: Convert Atmel board/soc bindings to json-schema

2018-10-05 Thread Alexandre Belloni
1 device tree bindings. > + > +maintainers: > + - Alexandre Belloni > + - Jean-Christophe PLAGNIOL-VILLARD Jean-Christophe has not been active for years, I'd mention Ludovic instead. > +description: | > + Boards with a SoC of the Atmel AT91 or SMART family shall have the

Re: [PATCH 1/2] soc: fsl: qbman: qman_portal: defer probing when qman is not available

2018-09-26 Thread Alexandre Belloni
On 25/09/2018 21:45:56+0200, Olof Johansson wrote: > Hi, > > > On Thu, Aug 23, 2018 at 11:36 PM Alexandre Belloni > wrote: > > > > If the qman driver (qman_ccsr) doesn't probe or fail to probe before > > qman_portal, qm_ccsr_start will be either NULL or a stal

[PATCH] powerpc/fsl-rio: fix spelling mistake "reserverd" -> "reserved"

2018-11-20 Thread Alexandre Belloni
Fix a spelling mistake in a register description. Signed-off-by: Alexandre Belloni --- arch/powerpc/sysdev/fsl_rio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/fsl_rio.h b/arch/powerpc/sysdev/fsl_rio.h index 12dd18fd4795..6c13d9a7b7b2 100644

Re: [PATCH -next] rtc: opal: Make opal_tpo_alarm_irq_enable static

2019-03-24 Thread Alexandre Belloni
s/rtc/rtc-opal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH -next] soc: fsl: Enable COMPILE_TEST

2019-11-08 Thread Alexandre Belloni
> > config FSL_RCPM > bool "Freescale RCPM support" > - depends on PM_SLEEP && (ARM || ARM64) > + depends on PM_SLEEP && (ARM || ARM64 || COMPILE_TEST) > help > The NXP QorIQ Processors based on ARM Core have RCPM module >

Re: [PATCH] rtc: fsl-ftm-alarm: remove select FSL_RCPM and default y from Kconfig

2019-11-15 Thread Alexandre Belloni
not a critical feature for the > systems. > > Signed-off-by: Li Yang > --- > drivers/rtc/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 1/3] rtc: ds1374: add uie_unsupported property to drop warning

2020-05-08 Thread Alexandre Belloni
ependent and certainly doesn't require an (undocumented) DT property. > #ifdef CONFIG_RTC_DRV_DS1374_WDT > save_client = client; > ret = misc_register(_miscdev); > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 2/3] dts: ppc: t4240rdb: add uie_unsupported property to drop warning

2020-05-08 Thread Alexandre Belloni
// The ds1374's INT pin isn't > + // connected to cpu's INT pin, > + // so the rtc cannot synchronize > + // clock tick per second. > + uie_unsupported; > }

Re: [PATCH 1/5] ARM: configs: drop unused BACKLIGHT_GENERIC option

2020-11-30 Thread Alexandre Belloni
om all ARM configurations. > > Fixes: 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is > unused") > Cc: Sam Ravnborg > Signed-off-by: Andrey Zhizhikin Acked-by: Alexandre Belloni > --- > arch/arm/configs/at91_dt_defconfig| 1 - > arch/arm

Re: [PATCH v2 0/5] drop unused BACKLIGHT_GENERIC option

2020-12-08 Thread Alexandre Belloni
option > commit: 4e9c44b128d3eb5da129e53c7312240f838c2dbf > [5/5] powerpc/configs: drop unused BACKLIGHT_GENERIC option > commit: 4985c506303fb6a41a885d503a6e1f3d3126431d > >Arnd -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 1/5] ARM: configs: drop unused BACKLIGHT_GENERIC option

2020-12-01 Thread Alexandre Belloni
ng the > > > secret-soc address. :) > > I tried to convince them before, it didn't work. I guess they don't like > to be spammed ;). The first rule of arm-soc is: you do not talk about arm@ and soc@ > Or rather, SoC-specific patches, even to defconfig, > should go through t

[PATCH 04/17] rtc: cmos: remove cmos_rtc_ops_no_alarm

2021-01-10 Thread Alexandre Belloni
Clear RTC_FEATURE_ALARM to signal that alarms are not available instead of having a supplementary struct rtc_class_ops with a NULL .set_alarm. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-cmos.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/rtc

[PATCH 09/17] rtc: rx8010: drop a struct rtc_class_ops

2021-01-10 Thread Alexandre Belloni
Merge both struct rtc_class_ops in a single one and use RTC_FEATURE_ALARM to signal to the core whether alarms are available. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx8010.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/rtc-rx8010.c

[PATCH 15/17] rtc: rv3032: constify rv3032_rtc_ops

2021-01-10 Thread Alexandre Belloni
Use RTC_FEATURE_ALARM to signal to the core whether alarms are available instead of changing the global struct rtc_class_ops, allowing to make it const. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv3032.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH 00/17] rtc: constify all rtc_class_ops

2021-01-10 Thread Alexandre Belloni
Hello, This first introduces a features bitfield that is used to handle the presence or absence of alarms instead of relying only on the presence of the alarm callbacks. The drivers modifying a struct rtc_class_ops or using two different structures are then converted. Alexandre Belloni (17

[PATCH 07/17] rtc: pcf2127: remove pcf2127_rtc_alrm_ops

2021-01-10 Thread Alexandre Belloni
Move the alarm callbacks in pcf2127_rtc_ops and use RTC_FEATURE_ALARM to signal to the core whether alarms are available instead of having a supplementary struct rtc_class_ops without alarm callbacks. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf2127.c | 11 +++ 1 file

[PATCH 12/17] rtc: opal: constify opal_rtc_ops

2021-01-10 Thread Alexandre Belloni
Use RTC_FEATURE_ALARM to signal to the core whether alarms are available instead of changing the global struct rtc_class_ops, allowing to make it const. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-opal.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git

[PATCH 13/17] rtc: rv3028: constify rv3028_rtc_ops

2021-01-10 Thread Alexandre Belloni
Use RTC_FEATURE_ALARM to signal to the core whether alarms are available instead of changing the global struct rtc_class_ops, allowing to make it const. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv3028.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH 17/17] rtc: tps65910: remove tps65910_rtc_ops_noirq

2021-01-10 Thread Alexandre Belloni
Clear RTC_FEATURE_ALARM to signal that alarms are not available instead of having a supplementary struct rtc_class_ops without alarm callbacks. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-tps65910.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git

[PATCH 02/17] rtc: pl031: use RTC_FEATURE_ALARM

2021-01-10 Thread Alexandre Belloni
Clear RTC_FEATURE_ALARM instead of setting set_alarm, read_alarm and alarm_irq_enable to NULL. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pl031.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c index

[PATCH 03/17] rtc: armada38x: remove armada38x_rtc_ops_noirq

2021-01-10 Thread Alexandre Belloni
Clear RTC_FEATURE_ALARM to signal that alarms are not available instead of having a supplementary struct rtc_class_ops with a NULL .set_alarm. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-armada38x.c | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff

[PATCH 06/17] rtc: m48t59: remove m48t02_rtc_ops

2021-01-10 Thread Alexandre Belloni
Clear RTC_FEATURE_ALARM to signal that alarms are not available instead of having a supplementary struct rtc_class_ops without alarm callbacks. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-m48t59.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git

[PATCH 05/17] rtc: mv: remove mv_rtc_alarm_ops

2021-01-10 Thread Alexandre Belloni
Move the alarm callbacks in mv_rtc_ops and clear RTC_FEATURE_ALARM to signal that alarms are not available instead of having a supplementary struct rtc_class_ops. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mv.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions

[PATCH 14/17] rtc: rv3029: constify rv3029_rtc_ops

2021-01-10 Thread Alexandre Belloni
Use RTC_FEATURE_ALARM to signal to the core whether alarms are available instead of changing the global struct rtc_class_ops, allowing to make it const. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv3029c2.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH] rtc: opal: set range

2021-01-10 Thread Alexandre Belloni
It is a BCD RTC with 4 digits for the year. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-opal.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-opal.c b/drivers/rtc/rtc-opal.c index 7b9f8bcf86fe..c586f695bdc9 100644 --- a/drivers/rtc

[PATCH 01/17] rtc: introduce features bitfield

2021-01-10 Thread Alexandre Belloni
to then test whether alarms are available instead of relying on the presence of ops->set_alarm. Signed-off-by: Alexandre Belloni --- drivers/rtc/class.c | 5 + drivers/rtc/interface.c | 12 ++-- include/linux/rtc.h | 2 ++ include/uapi/linux/rtc.h | 5 + 4 files changed,

[PATCH 08/17] rtc: pcf85063: remove pcf85063_rtc_ops_alarm

2021-01-10 Thread Alexandre Belloni
Move the alarm callbacks in pcf85063_rtc_ops and use RTC_FEATURE_ALARM to signal to the core whether alarms are available instead of having a supplementary struct rtc_class_ops without alarm callbacks. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf85063.c | 11 ++- 1 file

[PATCH 11/17] rtc: m41t80: constify m41t80_rtc_ops

2021-01-10 Thread Alexandre Belloni
Use RTC_FEATURE_ALARM to signal to the core whether alarms are available instead of changing the global struct rtc_class_ops, allowing to make it const. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-m41t80.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH 10/17] rtc: pcf85363: drop a struct rtc_class_ops

2021-01-10 Thread Alexandre Belloni
Merge both struct rtc_class_ops in a single one and use RTC_FEATURE_ALARM to signal to the core whether alarms are available. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf85363.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-pcf85363.c b

[PATCH 16/17] rtc: rv8803: constify rv8803_rtc_ops

2021-01-10 Thread Alexandre Belloni
Use RTC_FEATURE_ALARM to signal to the core whether alarms are available instead of changing the global struct rtc_class_ops, allowing to make it const. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv8803.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] bus: Make remove callback return void

2021-07-06 Thread Alexandre Belloni
ted buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Signed-off-by: Uwe Kleine-König Acked-by: Alexandre Belloni > --- > Hello, > > this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove > return

Re: [PATCH 04/17] rtc: cmos: remove cmos_rtc_ops_no_alarm

2021-04-28 Thread Alexandre Belloni
-22 I think I know what is happening, there is one patch I wanted to send this cycle but didn't, can you test it? https://github.com/alexandrebelloni/linux/commit/50641a5a19cedf7561410d7db614da46c228bacc Thanks for the report! -- Alexandre Belloni, co-owner and COO, Bootlin Embedded L

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread Alexandre Belloni
On 24/03/2021 09:19:58+0100, Geert Uytterhoeven wrote: > Hi Alexandre, > > On Tue, Mar 23, 2021 at 11:18 PM Alexandre Belloni > wrote: > > On 23/03/2021 05:12:57-0400, He Ying wrote: > > > We found these warnings in arch/powerpc/kernel/time.c as follows: > > &

Re: [PATCH V3 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread Alexandre Belloni
> diff --git a/arch/powerpc/platforms/chrp/time.c > b/arch/powerpc/platforms/chrp/time.c > index acde7bbe0716..b94dfd5090d8 100644 > --- a/arch/powerpc/platforms/chrp/time.c > +++ b/arch/powerpc/platforms/chrp/time.c > @@ -30,8 +30,6 @@ > > #include > > -extern spinlock_t rtc_lock; > - > #define NVRAM_AS0 0x74 > #define NVRAM_AS1 0x75 > #define NVRAM_DATA 0x77 > -- > 2.17.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH V3 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-25 Thread Alexandre Belloni
x86 still needs it. I'll work on that. Again, the patch is fine as is. Reviewed-by: Alexandre Belloni -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-23 Thread Alexandre Belloni
n_unlock_irq(_lock); > + spin_unlock_irq(_rtc_lock); > return 0; > } > > @@ -296,7 +296,7 @@ static int rtc_probe(struct platform_device *pdev) > rtc->range_max = (1ULL << 33) - 1; > rtc->max_user_freq = MAX_PERIODIC_RATE; > > - spin_lock_irq(_lock); > + spin_lock_irq(_rtc_lock); > > rtc1_write(ECMPLREG, 0); > rtc1_write(ECMPMREG, 0); > @@ -304,7 +304,7 @@ static int rtc_probe(struct platform_device *pdev) > rtc1_write(RTCL1LREG, 0); > rtc1_write(RTCL1HREG, 0); > > - spin_unlock_irq(_lock); > + spin_unlock_irq(_rtc_lock); > > aie_irq = platform_get_irq(pdev, 0); > if (aie_irq <= 0) { > -- > 2.17.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-23 Thread Alexandre Belloni
On 23/03/2021 23:18:17+0100, Alexandre Belloni wrote: > Hello, > > On 23/03/2021 05:12:57-0400, He Ying wrote: > > We found these warnings in arch/powerpc/kernel/time.c as follows: > > warning: symbol 'decrementer_max' was not declared. Should it be static? > >

Re: [PATCH v3 0/5] rtc: nintendo: Add a RTC driver for the GameCube, Wii and Wii U

2021-12-16 Thread Alexandre Belloni
powerpc: gamecube_defconfig: Enable the RTC driver commit: 57bd7d356506b713d0df8d8e42da7810a18864df [5/5] powerpc: wii_defconfig: Enable the RTC driver commit: 69e8ba80ddda4db31e59facbf2db19773ad3785b This one didn't apply ceanly but I believe I did the right thing. Can you check? Best regards, -- Alexandre Belloni

Re: [PATCH v3 0/5] rtc: nintendo: Add a RTC driver for the GameCube, Wii and Wii U

2021-12-16 Thread Alexandre Belloni
gt; I have nothing queued in the powerpc tree that touches any of those > files, so conflicts are unlikely. > > So I'm happy for this to go via the rtc tree whenever it's ready. > > Acked-by: Michael Ellerman (powerpc) That's done, thanks. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v3 0/5] rtc: nintendo: Add a RTC driver for the GameCube, Wii and Wii U

2021-12-16 Thread Alexandre Belloni
On 16/12/2021 21:22:20+0100, Emmanuel Gil Peyrot wrote: > On Thu, Dec 16, 2021 at 10:49:44AM +0100, Alexandre Belloni wrote: > > On Wed, 15 Dec 2021 18:54:56 +0100, Emmanuel Gil Peyrot wrote: > > > These three consoles share a device, the MX23L4005, which contains a > &

Re: [PATCH v2 2/5] rtc: gamecube: Report low battery as invalid data

2021-11-30 Thread Alexandre Belloni
+} > + > static const struct rtc_class_ops gamecube_rtc_ops = { > .read_time = gamecube_rtc_read_time, > .set_time = gamecube_rtc_set_time, > + .ioctl = gamecube_rtc_ioctl, > }; > > static int gamecube_rtc_read_offset_from_sram(struct priv *d) > -- > 2.33.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

[PATCH 07/29] rtc: opal: switch to RTC_FEATURE_UPDATE_INTERRUPT

2022-03-09 Thread Alexandre Belloni
Stop using uie_unsupported and clear RTC_FEATURE_UPDATE_INTERRUPT instead. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-opal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-opal.c b/drivers/rtc/rtc-opal.c index f8f49a969c23..ad41aaf8a17f 100644