Re: [PATCH 2/4]: CPUIDLE: Introduce architecture independent cpuidle_pm_idle in drivers/cpuidle/cpuidle.c

2009-08-28 Thread Balbir Singh
* Peter Zijlstra a.p.zijls...@chello.nl [2009-08-28 08:48:05]: On Fri, 2009-08-28 at 11:44 +0530, Arun R Bharadwaj wrote: * Peter Zijlstra a.p.zijls...@chello.nl [2009-08-27 14:53:27]: Hi Peter, Ben, I've put the whole thing in a sort of a block diagram. Hope it explains things

Re: [PATCH] Fix fake numa on ppc

2009-08-31 Thread Balbir Singh
* Ankita Garg ank...@in.ibm.com [2009-09-01 10:33:16]: Hello, Below is a patch to fix a couple of issues with fake numa node creation on ppc: 1) Presently, fake nodes could be created such that real numa node boundaries are not respected. So a node could have lmbs that belong to

Re: [PATCH] Fix fake numa on ppc

2009-09-01 Thread Balbir Singh
* Ankita Garg ank...@in.ibm.com [2009-09-01 14:54:07]: Hi Balbir, On Tue, Sep 01, 2009 at 11:27:53AM +0530, Balbir Singh wrote: * Ankita Garg ank...@in.ibm.com [2009-09-01 10:33:16]: Hello, Below is a patch to fix a couple of issues with fake numa node creation on ppc

Re: [v4 PATCH 1/5]: cpuidle: Cleanup drivers/cpuidle/cpuidle.c

2009-09-01 Thread Balbir Singh
* Arun R B a...@linux.vnet.ibm.com [2009-09-01 17:08:40]: * Arun R Bharadwaj a...@linux.vnet.ibm.com [2009-09-01 17:07:04]: Cleanup drivers/cpuidle/cpuidle.c Cpuidle maintains a pm_idle_old void pointer because, currently in x86 there is no clean way of registering and unregistering a

Re: [PATCH v2] Fix fake numa on ppc

2009-09-02 Thread Balbir Singh
help do ppc. Sounds interesting, I'd definitely be interested in seeing your proposal, but I would think of that as additional development on top of this patch Balbir Singh. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [PATCH v3 0/3] cpu: pseries: Cpu offline states framework

2009-09-15 Thread Balbir Singh
* Peter Zijlstra a.p.zijls...@chello.nl [2009-09-15 14:11:41]: On Tue, 2009-09-15 at 17:36 +0530, Gautham R Shenoy wrote: This patchset contains the offline state driver implemented for pSeries. For pSeries, we define three available_hotplug_states. They are: online: The

Re: [v6 PATCH 0/7]: cpuidle/x86/POWER: Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER.

2009-09-25 Thread Balbir Singh
for such inconsistency? Balbir Singh ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [v7 PATCH 0/7]: cpuidle/x86/POWER: Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER.

2009-10-07 Thread Balbir Singh
* Vaidy sva...@linux.vnet.ibm.com [2009-10-07 16:56:48]: * Peter Zijlstra a.p.zijls...@chello.nl [2009-10-06 20:04:39]: On Tue, 2009-10-06 at 22:05 +0530, Arun R Bharadwaj wrote: Also, the per-cpu nature of registration/unregistration of cpuidle has been maintained as ACPI needs

Re: [v8 PATCH 0/8]: cpuidle: Cleanup cpuidle/ Introduce cpuidle to POWER

2009-10-12 Thread Balbir Singh
* Arun R B a...@linux.vnet.ibm.com [2009-10-08 15:18:28]: Hi Please consider this for inclusion into the testing tree. This patchset introduces cpuidle infrastructure to POWER, prototyping for pSeries, and also does a major refactoring of current x86 idle power management and a cleanup

Re: [v8 PATCH 1/8]: cpuidle: cleanup drivers/cpuidle/cpuidle.c

2009-10-12 Thread Balbir Singh
* Arun R B a...@linux.vnet.ibm.com [2009-10-08 15:19:42]: * Arun R Bharadwaj a...@linux.vnet.ibm.com [2009-10-08 15:18:28]: This patch cleans up drivers/cpuidle/cpuidle.c Earlier cpuidle assumed pm_idle as the default idle loop. Break that assumption and make it more generic.

Build failure with 2.6.24-mm1

2008-02-04 Thread Balbir Singh
* Balbir Singh [EMAIL PROTECTED] [2008-02-04 15:35:09]: I just saw the following build failure on a power machine. In file included from include/acpi/platform/acenv.h:140, from include/acpi/acpi.h:54, from include/acpi/acpi_bus.h:31, from

Re: [PATCH 1/2] Add scaled time to taskstats based process accounting

2007-08-16 Thread Balbir Singh
= + cputime_to_msecs(tsk-stimescaled) * USEC_PER_MSEC; stats-ac_minflt = tsk-min_flt; stats-ac_majflt = tsk-maj_flt; -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH 2/2] [POWERPC] Add scaled time accounting

2007-08-16 Thread Balbir Singh
; /* FIXME: document */ + u64 spurrdelta; /* FIXME: document */ }; extern struct paca_struct paca[]; -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL ___ Linuxppc-dev mailing list

Re: [PATCH 1/2] Add scaled time to taskstats based process accounting

2007-08-16 Thread Balbir Singh
, Balbir Singh Linux Technology Center IBM, ISTL ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/2] Add scaled time to taskstats based process accounting

2007-08-19 Thread Balbir Singh
is complete and I think the implementation would provide a good reference for other implementations to follow. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH] taskstats scaled time cleanup

2007-10-24 Thread Balbir Singh
Singh [EMAIL PROTECTED] -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] Restore deterministic CPU accounting on powerpc

2007-11-03 Thread Balbir Singh
, HARDIRQ_OFFSET, jiffies_to_cputime(1)); + account_system_time_scaled(p, jiffies_to_cputime(1)); + } +} +#endif + Hi, Paul, So, scaled accounting will not be available if CONFIG_VIRT_CPU_ACCOUNTING is defined? Am I reading this correctly Balbir Singh

Re: [PATCH] Restore deterministic CPU accounting on powerpc

2007-11-03 Thread Balbir Singh
Paul Mackerras wrote: Balbir Singh writes: So, scaled accounting will not be available if CONFIG_VIRT_CPU_ACCOUNTING is defined? Am I reading this correctly No, what makes you think that? If VIRT_CPU_ACCOUNTING=y it is the responsibility of the arch's account_process_tick to update

Re: 2.6.24-rc1-git15 Kernel build fails on powerpc - Unrecognized opcode: `dssall'

2007-11-06 Thread Balbir Singh
On Nov 6, 2007 4:04 PM, Kamalesh Babulal [EMAIL PROTECTED] wrote: Hi, The build fails on the power6 machine while compiling 2.6.24-rc1-git15 kernel, with randconfig, CHK include/linux/compile.h AS arch/powerpc/kernel/swsusp_32.o arch/powerpc/kernel/swsusp_32.S: Assembler

Re: 2.6.24-rc1-git15 Kernel build fails on powerpc - Unrecognized opcode: `dssall'

2007-11-06 Thread Balbir Singh
swsusp_32.S which assumes that ALTIVEC is enabled (see CPU_FTR_ALTIVEC). You ideally need to have -Wa,-maltivec passed in your CFLAGS. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL ___ Linuxppc-dev mailing

Re: [PATCH] fix scaled time accounting possible divide by zero

2007-11-19 Thread Balbir Singh
Michael Neuling wrote: This fixes a problem noticed by Balbir Singh Signed-off-by: Michael Neuling [EMAIL PROTECTED] --- Paulus: can we send this up for 2.6.24? arch/powerpc/kernel/time.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: linux-2.6-ozlabs/arch

Re: [PATCH] powerpc: Quieten cede latency printk

2010-02-08 Thread Balbir Singh
On Mon, Feb 8, 2010 at 5:22 AM, Anton Blanchard an...@samba.org wrote: The cede latency stuff is relatively new and we don't need to complain about it not working on older firmware. Signed-off-by: Anton Blanchard an...@samba.org Acked-by: Balbir Singh bal...@linux.vnet.ibm.com Seems like

Re: [PATCH] powerpc: Set a smaller value for RECLAIM_DISTANCE to enable zone reclaim

2010-02-19 Thread Balbir Singh
than unmapped pages, we start reclaim the cached pages first. The min_unmapped_pages almost sounds like the higher level watermark - or am I misreading the code. Balbir Singh ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [PATCH] powerpc: Set a smaller value for RECLAIM_DISTANCE to enable zone reclaim

2010-02-19 Thread Balbir Singh
moving on to another node? Balbir Singh. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc: Set a smaller value for RECLAIM_DISTANCE to enable zone reclaim

2010-02-19 Thread Balbir Singh
* Christoph Lameter c...@linux-foundation.org [2010-02-19 09:51:12]: On Fri, 19 Feb 2010, Balbir Singh wrote: zone_reclaim. The others back off and try the next zone in the zonelist instead. I'm not sure what the original intention was but most likely it was to prevent too many

Re: [BUGFIX][PATCH] memcg: avoid use cmpxchg in swap cgroup maintainance (Was Re: 34-rc1-git3 build failure with CGROUP_MEM_RES_CTLR_SWAP=y

2010-03-14 Thread Balbir Singh
consider something better ? We need a quick fix. Looks good to me Acked-by: Balbir Singh bal...@linux.vnet.ibm.com -- Three Cheers, Balbir ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo

Badness seen on 2.6.26-rc2 with lockdep enabled

2008-05-14 Thread Balbir Singh
-- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 0/8] De-couple sysfs memory directories from memory sections

2010-09-23 Thread Balbir Singh
* Nathan Fontenot nf...@austin.ibm.com [2010-09-22 09:15:43]: This set of patches decouples the concept that a single memory section corresponds to a single directory in /sys/devices/system/memory/. On systems with large amounts of memory (1+ TB) there are performance issues related to

Re: [PATCH 7/9] v3 Define memory_block_size_bytes for powerpc/pseries

2010-10-03 Thread Balbir Singh
* Nathan Fontenot nf...@austin.ibm.com [2010-10-01 13:35:54]: Define a version of memory_block_size_bytes() for powerpc/pseries such that a memory block spans an entire lmb. I hope I am not missing anything obvious, but why not just call it lmb_size, why do we need memblock_size? Is lmb_size

Re: [PATCH 7/9] v3 Define memory_block_size_bytes for powerpc/pseries

2010-10-03 Thread Balbir Singh
* Dave Hansen d...@linux.vnet.ibm.com [2010-10-03 11:11:01]: On Sun, 2010-10-03 at 13:07 -0500, Robin Holt wrote: On Sun, Oct 03, 2010 at 11:25:00PM +0530, Balbir Singh wrote: * Nathan Fontenot nf...@austin.ibm.com [2010-10-01 13:35:54]: Define a version of memory_block_size_bytes

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
David Rientjes wrote: On Sat, 8 Dec 2007, Balbir Singh wrote: Yes, they all appear on node 0. We could have tweaks to distribute CPU's as well. You're going to want to distribute the cpu's based on how they match up physically with the actual platform that you're running on. x86_64

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
David Rientjes wrote: On Sat, 8 Dec 2007, Balbir Singh wrote: To be able to test the memory controller under NUMA, I use fake NUMA nodes. x86-64 has a similar feature, the code I have here is the simplest I could come up with for PowerPC. Magnus Damm had patches from over a year ago

[PATCH] Fake NUMA emulation for PowerPC (Take 2)

2007-12-07 Thread Balbir Singh
simple. Comments are as always welcome! Signed-off-by: Balbir Singh [EMAIL PROTECTED] --- arch/powerpc/mm/numa.c | 59 - 1 file changed, 54 insertions(+), 5 deletions(-) diff -puN arch/powerpc/mm/numa.c~ppc-fake-numa-easy arch/powerpc/mm/numa.c

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
Nathan Lynch wrote: Hi Balbir- Balbir Singh wrote: Here's a dumb simple implementation of fake NUMA nodes for PowerPC. Fake NUMA nodes can be specified using the following command line option numa=fake=node range node range is of the format range1,range2,...rangeN Each of the rangeX

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
Arnd Bergmann wrote: On Friday 07 December 2007, Balbir Singh wrote: Balbir Singh wrote: Geert Uytterhoeven wrote: On Sat, 8 Dec 2007, Balbir Singh wrote: + if (strstr(p, fake=)) + cmdline = p + 5;/* 5 is faster than strlen(fake=) */ Really? My gcc is smart enough

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
Balbir Singh wrote: Geert Uytterhoeven wrote: On Sat, 8 Dec 2007, Balbir Singh wrote: + if (strstr(p, fake=)) + cmdline = p + 5;/* 5 is faster than strlen(fake=) */ Really? My gcc is smart enough to replace the `strlen(fake=)' by 5, even without -O. Thanks

[PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
simple. Comments are as always welcome! Signed-off-by: Balbir Singh [EMAIL PROTECTED] --- arch/powerpc/mm/numa.c | 55 - 1 file changed, 50 insertions(+), 5 deletions(-) diff -puN arch/powerpc/mm/numa.c~ppc-fake-numa-easy arch/powerpc/mm/numa.c

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
Arnd Bergmann wrote: On Friday 07 December 2007, Balbir Singh wrote: Here's a dumb simple implementation of fake NUMA nodes for PowerPC. Fake NUMA nodes can be specified using the following command line option numa=fake=node range node range is of the format range1,range2,...rangeN

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
Kumar Gala wrote: On Dec 7, 2007, at 4:12 PM, Balbir Singh wrote: Kumar Gala wrote: On Dec 7, 2007, at 3:35 PM, Balbir Singh wrote: Olof Johansson wrote: Hi, On Sat, Dec 08, 2007 at 02:44:25AM +0530, Balbir Singh wrote: Comments are as always welcome! Care to explain what

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
Geert Uytterhoeven wrote: On Sat, 8 Dec 2007, Balbir Singh wrote: +if (strstr(p, fake=)) +cmdline = p + 5;/* 5 is faster than strlen(fake=) */ Really? My gcc is smart enough to replace the `strlen(fake=)' by 5, even without -O. Thanks for pointing that out, but I

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
Olof Johansson wrote: Hi, On Sat, Dec 08, 2007 at 02:44:25AM +0530, Balbir Singh wrote: Comments are as always welcome! Care to explain what this is useful for? (Not saying it's a stupid idea, just wondering what the reason for doing it is). In my case, I use it to test parts of my

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
Kumar Gala wrote: On Dec 7, 2007, at 3:35 PM, Balbir Singh wrote: Olof Johansson wrote: Hi, On Sat, Dec 08, 2007 at 02:44:25AM +0530, Balbir Singh wrote: Comments are as always welcome! Care to explain what this is useful for? (Not saying it's a stupid idea, just wondering what

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-09 Thread Balbir Singh
Pavel Machek wrote: On Sat 2007-12-08 09:52:06, Balbir Singh wrote: David Rientjes wrote: On Sat, 8 Dec 2007, Balbir Singh wrote: To be able to test the memory controller under NUMA, I use fake NUMA nodes. x86-64 has a similar feature, the code I have here is the simplest I could come up

Re: [PATCH] Fake NUMA emulation for PowerPC (Take 2)

2007-12-10 Thread Balbir Singh
Balbir Singh wrote: Changelog 1. Get rid of the constant 5 (based on comments from [EMAIL PROTECTED]) 2. Implement suggestions from Olof Johannson 3. Check if cmdline is NULL in fake_numa_create_new_node() Tested with additional parameters from Olof

Re: Patches added to for-2.6.25 and master branches of powerpc.git

2007-12-11 Thread Balbir Singh
On Dec 11, 2007 10:59 AM, Paul Mackerras [EMAIL PROTECTED] wrote: [snip] Hi, Paul, Any chance we could get in Fake NUMA nodes patch at http://lkml.org/lkml/2007/12/7/294? Should I get it into -mm first? It was acked by Olof at http://lkml.org/lkml/2007/12/10/247. Thanks, Balbir Singh

Build breakage on powerpc with 2.6.24-rc6-mm1

2007-12-23 Thread Balbir Singh
/net] Error 2 make: *** [drivers] Error 2 Here's a patch, compile tested to fix the compilation problem Remove unused variable rc and fix a typo, veth_port_type was called veth_port_typeq Signed-off-by: Balbir Singh [EMAIL PROTECTED] --- drivers/net/iseries_veth.c |4 ++-- 1 file changed, 2

SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-23 Thread Balbir Singh
-- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-26 Thread Balbir Singh
FUJITA Tomonori wrote: On Mon, 24 Dec 2007 10:18:50 +0530 Balbir Singh [EMAIL PROTECTED] wrote: [snip] I might break the IOMMU code. Can you reproduce it easily? If so, reverting my IOMMU patches (I've attached a patch to revert them) fix the problem? [snip] Yes, this patch fixes

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-26 Thread Balbir Singh
FUJITA Tomonori wrote: On Thu, 27 Dec 2007 10:08:25 +0530 Balbir Singh [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: On Mon, 24 Dec 2007 10:18:50 +0530 Balbir Singh [EMAIL PROTECTED] wrote: [snip] I might break the IOMMU code. Can you reproduce it easily? If so, reverting my IOMMU

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-27 Thread Balbir Singh
)) { /* we could do more effectively */ start = index + 1; This on top of -mm? Or on top of the reverted iommu patch. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL ___ Linuxppc-dev

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-31 Thread Balbir Singh
FUJITA Tomonori wrote: Oops, it's for -mm. Hi, I just tested this patch and it works fine for me so far. Tested-by: Balbir Singh [EMAIL PROTECTED] -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL

Re: [PATCH] Fake NUMA emulation for PowerPC (Take 2)

2008-01-18 Thread Balbir Singh
* Michael Ellerman [EMAIL PROTECTED] [2008-01-18 16:44:58]: On Fri, 2008-01-18 at 16:34 +1100, Michael Ellerman wrote: On Sat, 2007-12-08 at 04:07 +0530, Balbir Singh wrote: Changelog 1. Get rid of the constant 5 (based on comments from [EMAIL

Re: [PATCH] Fake NUMA emulation for PowerPC (Take 2)

2008-01-18 Thread Balbir Singh
* Michael Ellerman [EMAIL PROTECTED] [2008-01-18 16:55:03]: On Sat, 2007-12-08 at 04:07 +0530, Balbir Singh wrote: Here's a dumb simple implementation of fake NUMA nodes for PowerPC. Fake NUMA nodes can be specified using the following command line option Comments are as always

Re: [PATCH] Fake NUMA emulation for PowerPC (Take 2)

2008-01-18 Thread Balbir Singh
* Michael Ellerman [EMAIL PROTECTED] [2008-01-18 16:34:53]: On Sat, 2007-12-08 at 04:07 +0530, Balbir Singh wrote: Changelog 1. Get rid of the constant 5 (based on comments from [EMAIL PROTECTED]) 2. Implement suggestions from Olof Johannson 3. Check

Re: [PATCH] Fake NUMA emulation for PowerPC (Take 2)

2008-01-25 Thread Balbir Singh
iff (as in if and only if) fake NUMA nodes are created. Signed-off-by: Balbir Singh [EMAIL PROTECTED] --- arch/powerpc/mm/numa.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff -puN arch/powerpc/mm/numa.c~fix-fake-numa-nid-on-numa arch/powerpc/mm/numa.c --- linux-2.6.24-rc8

Re: [PATCH] Fake NUMA emulation for PowerPC (Take 2)

2008-01-27 Thread Balbir Singh
* Paul Mackerras [EMAIL PROTECTED] [2008-01-27 22:55:43]: Balbir Singh writes: Here's a better and more complete fix for the problem. Could you please see if it works for you? I tested it on a real NUMA box and it seemed to work fine there. There are a couple of other changes

Re: [PATCH] Fake NUMA emulation for PowerPC (Take 2)

2008-01-28 Thread Balbir Singh
* Nish Aravamudan [EMAIL PROTECTED] [2008-01-27 12:22:54]: On 1/27/08, Balbir Singh [EMAIL PROTECTED] wrote: * Paul Mackerras [EMAIL PROTECTED] [2008-01-27 22:55:43]: Balbir Singh writes: Here's a better and more complete fix for the problem. Could you please see if it works

[PATCH powerpc] Fake NUMA emulation for PowerPC (Take 3)

2008-01-28 Thread Balbir Singh
* Paul Mackerras [EMAIL PROTECTED] [2008-01-27 22:55:43]: Balbir Singh writes: Here's a better and more complete fix for the problem. Could you please see if it works for you? I tested it on a real NUMA box and it seemed to work fine there. There are a couple of other changes

Re: [PATCH powerpc] Fake NUMA emulation for PowerPC (Take 3)

2008-01-29 Thread Balbir Singh
-- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 0/3] cpu: idle state framework for offline CPUs.

2009-08-16 Thread Balbir Singh
* Dipankar Sarma dipan...@in.ibm.com [2009-08-16 23:56:29]: On Fri, Aug 14, 2009 at 01:30:21PM +0200, Pavel Machek wrote: It depends on the hypervisor implementation. On pseries (powerpc) hypervisor, for example, they are different. By offlining a vcpu (and in turn shutting a cpu),

Re: [RFC PATCH V1 01/33] powerpc/mm: add _PAGE_HASHPTE similar to 4K hash

2016-01-12 Thread Balbir Singh
On Tue, 12 Jan 2016 12:45:36 +0530 "Aneesh Kumar K.V" wrote: > Not really needed. But this brings it back to as it was before > Could you expand on not really needed. Could the changelog describe how the bits will be used in the follow on patches. Balbir

Re: [RFC PATCH V1 03/33] powerpc/mm: Switch book3s 64 with 64K page size to 4 level page table

2016-01-13 Thread Balbir Singh
On Tue, 12 Jan 2016 12:45:38 +0530 "Aneesh Kumar K.V" wrote: > This is needed so that we can support both hash and radix page table > using single kernel. Radix kernel uses a 4 level table. > > Signed-off-by: Aneesh Kumar K.V >

Re: [PATCH 1/2] powerpc/timer - large decrementer support

2016-06-02 Thread Balbir Singh
assumed and LD mode is >> disabled. >> >> This patch was based on initial work by Jack Miller. >> >> Signed-off-by: Oliver O'Halloran <ooh...@gmail.com> >> Cc: Michael Neuling <mi...@neuling.org> > > Acked-by: Michael Neuling <mi...@neuling.org&

Re: [PATCH] powerpc/pseries: Add POWER8NVL support to ibm,client-architecture-support call

2016-06-07 Thread Balbir Singh
Fixes: ddee09c099c3 ("powerpc: Add PVR for POWER8NVL processor") >>> >>> And therefore: >>> >>> Cc: sta...@vger.kernel.org # v4.0+ >>> >>> Am I right? >> >> Right. (At least for virtualized systems ... for bare-metal system

Re: [PATCH] powerpc/mm: use _raw variant of page table accessors

2016-06-02 Thread Balbir Singh
s_fast+0x530> > break; > Signed-off-by: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com> > --- Can we just save the cpu_to_be64(_PAGE_PTE) as _BE64_PAGE_PTE constant in big-endian (pgtable-be-types.h) and similar for other things. I know its not the best opt

Re: [PATCH 1/3] powerpc/mm/radix: Update LPCR only if it is powernv

2016-06-02 Thread Balbir Singh
> + > mtspr(SPRN_PTCR, > __pa(partition_tb) | (PATB_SIZE_SHIFT - 12)); > + } > } > > void radix__setup_initial_memory_limit(phys_addr_t first_memblock_base, > Balbir Singh. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/mm/radix: Make the pid unsigned long

2016-06-02 Thread Balbir Singh
context.id; > @@ -207,7 +207,7 @@ EXPORT_SYMBOL(radix__flush_tlb_mm_pwc); > void radix___flush_tlb_page(struct mm_struct *mm, unsigned long vmaddr, > unsigned long ap, int nid) > { > - unsigned int pid; > + unsigned long pid; > > preempt_d

[PATCH] New MMU feature for new hpte format in ISA3

2016-06-14 Thread Balbir Singh
ux.vnet.ibm.com> Signed-off-by: Balbir Singh <bsinghar...@gmail.com> --- arch/powerpc/include/asm/book3s/64/mmu-hash.h | 5 ++--- arch/powerpc/include/asm/cputable.h | 2 +- arch/powerpc/include/asm/mmu.h| 11 ++- arch/powerpc/kernel/prom.c

[V2][PATCH] New MMU feature for new hpte format in ISA3

2016-06-14 Thread Balbir Singh
On 15/06/16 10:38, Balbir Singh wrote: > > Thanks for a review, I'll do a V2 with some changes > > Balbir > Michael, please review and check if you like the #ifdef, since we are crossing the 32 bit boundary, I've used a conditional define to select the feature. Changelog v2:

Re: [V2][PATCH] New MMU feature for new hpte format in ISA3

2016-06-15 Thread Balbir Singh
On 15/06/16 15:42, Aneesh Kumar K.V wrote: > Balbir Singh <bsinghar...@gmail.com> writes: > >> On 15/06/16 10:38, Balbir Singh wrote: >>> >>> Thanks for a review, I'll do a V2 with some changes >>> >>> Balbir >>> >> &g

[PATCH] Add support for power9 in ibm_architecture_vec

2016-06-15 Thread Balbir Singh
The PVR list has been updated and IBM_ARCH_VEC_NRCORES_OFFSET. Signed-off-by: Balbir Singh <bsinghar...@gmail.com> --- arch/powerpc/include/asm/prom.h | 5 - arch/powerpc/kernel/prom_init.c | 5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/inclu

Re: [PATCH] Add support for power9 in ibm_architecture_vec

2016-06-15 Thread Balbir Singh
hael, can you please check. I did a quick check with gdb Balbir Singh ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/mm: use _raw variant of page table accessors

2016-06-05 Thread Balbir Singh
On 06/06/16 08:30, Benjamin Herrenschmidt wrote: > On Fri, 2016-06-03 at 15:34 +1000, Balbir Singh wrote: >> >> Can we just save the cpu_to_be64(_PAGE_PTE) as _BE64_PAGE_PTE constant >> in big-endian (pgtable-be-types.h) and similar for other things. I know its >>

Re: [PATCH v3 0/9] kexec_file_load implementation for PowerPC

2016-06-22 Thread Balbir Singh
re >registered) accross kexec to the second kernel, so that the event >history is preserved. OK.. and this is safe? Do both the kernels need to be signed by the same certificate? Balbir Singh ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] New MMU feature for new hpte format in ISA3

2016-06-14 Thread Balbir Singh
On Wed, Jun 15, 2016 at 2:51 AM, Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com> wrote: > Balbir Singh <bsinghar...@gmail.com> writes: > >> This patch has been lightly tested and needs testing >> on additional platforms and different page sizes, largely >> d

Re: [Patch v2 1/2] powerpc: Send SIGBUS on unaligned copy and paste

2016-06-17 Thread Balbir Singh
+ * synchronisation point for preceding copy/paste sequences. > + */ > +if ((instruction & 0xfc0006fe) == PPC_INST_COPY) > +return -EIO; Should this all be under cpu_has_feature(CPU_FTR_ARCH_300)? Balbir Singh. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] cpuidle/powernv: Fix snooze timeout

2016-06-22 Thread Balbir Singh
On 23/06/16 05:36, Shreyas B. Prabhu wrote: > Snooze is a poll idle state in powernv and pseries platforms. Snooze > has a timeout so that if a cpu stays in snooze for more than target > residency of the next available idle state, then it would exit thereby > giving chance to the cpuidle

Re: [PATCH v3 0/9] kexec_file_load implementation for PowerPC

2016-06-22 Thread Balbir Singh
rect. What I meant was how does the new kernel know that the old kernel did not cheat while passing on the values? I presume because we trust that kernel via a signature. and How do we know the new kernel is safe to load - I guess via a signature that the new kernel is signed with (assuming it is

Re: [PATCH] cpuidle/powernv: Fix snooze timeout

2016-06-23 Thread Balbir Singh
On 23/06/16 14:58, Shreyas B Prabhu wrote: > > > On 06/23/2016 05:18 AM, Balbir Singh wrote: >> >> >> On 23/06/16 05:36, Shreyas B. Prabhu wrote: >>> Snooze is a poll idle state in powernv and pseries platforms. Snooze >>> has a timeout so that

Re: [PATCH] cpuidle/powernv: Fix snooze timeout

2016-06-23 Thread Balbir Singh
>> This is still a rounding error but at a different site. I see we saved >> a division by doing a >> 10, but we added it right back by doing a /20 >> later in the platform code. > > While a >> 10 is done at every idle exit, div by 20 is done once during > boot, so this doesn't negate the previous

[PATCH][V2] Add support for power9 in ibm_architecture_vec

2016-06-15 Thread Balbir Singh
On 16/06/16 10:09, Balbir Singh wrote: > Yes, my bad.. I'll respin. I thought I had it, but I clearly did not > V2: Update the vector length for OV1 after adding 3.0 support The PVR list has been updated and IBM_ARCH_VEC_NRCORES_OFFSET. This provides the cpu version supported to the hype

Re: [PATCH] Add support for power9 in ibm_architecture_vec

2016-06-15 Thread Balbir Singh
On 16/06/16 01:58, Aneesh Kumar K.V wrote: > Balbir Singh <bsinghar...@gmail.com> writes: > >> On Wed, Jun 15, 2016 at 9:17 PM, Aneesh Kumar K.V >> <aneesh.ku...@linux.vnet.ibm.com> wrote: >>> Shouldn't this be 125 + 16 ? >> >> Actually the

Re: [PATCH v3 0/9] kexec_file_load implementation for PowerPC

2016-06-23 Thread Balbir Singh
On 24/06/16 02:44, Thiago Jung Bauermann wrote: > Am Donnerstag, 23 Juni 2016, 09:57:51 schrieb Balbir Singh: >> On 23/06/16 03:02, Thiago Jung Bauermann wrote: >>>>> 3. have IMA pass-on its event log (where integrity measurements are >>>>> >>>>

Re: [PATCH] powerpc/mm: update arch_{add,remove}_memory() for radix

2016-06-23 Thread Balbir Singh
mapped. From the patch perspective, I think we need the equivalent of just mapping the pages in kernel. The address may differ based on whether vmemmap is used or not and of-course page_size, Balbir Singh ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC PATCH V1 03/33] powerpc/mm: Switch book3s 64 with 64K page size to 4 level page table

2016-01-14 Thread Balbir Singh
On 12/01/16 18:15, Aneesh Kumar K.V wrote: > This is needed so that we can support both hash and radix page table > using single kernel. Radix kernel uses a 4 level table. > > Signed-off-by: Aneesh Kumar K.V > --- > arch/powerpc/Kconfig

Re: [PATCH] powerpc/mm/radix: Update Radix tree size as per ISA 3.0

2016-06-15 Thread Balbir Singh
* bits 0 - 3 of rts -> bits 6 - 8 unsigned long > + * bits 4 - 5 of rts -> bits 62 - 63 of unsigned long > + */ > + rts_field = (0x5UL << 5); /* 6 - 8 bits */ > + rts_field |= (0x2UL << 61); > + > + return rts_field; > +} Looks good otherwise Reviewed

Re: kernel bug in "Drop WIMG in favour of new constants"?

2016-06-15 Thread Balbir Singh
On 16/06/16 14:33, Darrick J. Wong wrote: > Hi Aneesh, > > I noticed when trying out 4.7-rc3 on qemu-2.5 that the kernel no longer > boots. 4.6 booted just fine, so I bisected the kernel to the commit > 30bda41aba4efb2370c97e2cbe7385de93ccc372, which is "powerpc/mm: Drop WIMG in > favour of

Re: [PATCH][V2] Add support for power9 in ibm_architecture_vec

2016-06-15 Thread Balbir Singh
On 16/06/16 15:31, Michael Ellerman wrote: >> Subject: [PATCH][V2] Add support for power9 in ibm_architecture_vec > > Can you use "[PATCH v2]", my scripts don't grok your format. > > On Thu, 2016-06-16 at 14:54 +1000, Balbir Singh wrote: >> >> On 16/06/

[PATCH][v3] Add support for power9 in ibm_architecture_vec

2016-06-15 Thread Balbir Singh
The PVR list has been updated and IBM_ARCH_VEC_NRCORES_OFFSET. This provides the cpu versions supported to the hypervisor and in this case tells the hypervisor that the guest supports ISA 3.0 and Power9. Signed-off-by: Balbir Singh <bsinghar...@gmail.com> --- Changelog v3:

Re: [PATCH v6 1/9] ppc64 (le): prepare for -mprofile-kernel

2016-02-04 Thread Balbir Singh
On Thu, Feb 4, 2016 at 10:02 PM, Petr Mladek wrote: > On Thu 2016-02-04 18:31:40, AKASHI Takahiro wrote: >> Jiri, Torsten >> >> Thank you for your explanation. >> >> On 02/03/2016 08:24 PM, Torsten Duwe wrote: >> >On Wed, Feb 03, 2016 at 09:55:11AM +0100, Jiri Kosina wrote: >>

Re: Fix kgdb on little endian ppc64le

2016-02-10 Thread Balbir Singh
On Tue, 2016-02-09 at 21:11 +1100, Michael Ellerman wrote: > On Mon, 2016-01-02 at 06:03:25 UTC, Balbir Singh wrote: > > From: Balbir Singh <bsinghar...@gmail.com> > > > > I spent some time trying to use kgdb and debugged my inability to > > resume f

Re: [PATCH v8 0/8] ftrace with regs + live patching for ppc64 LE (ABI v2)

2016-02-10 Thread Balbir Singh
 |   5 + >  scripts/recordmcount.c  |   6 +- >  scripts/recordmcount.h  |  17 ++- >  19 files changed, 552 insertions(+), 47 deletions(-) >  create mode 100755 arch/powerpc/gcc-mprofile-kernel-notrace.sh >  create mode 100644 arch/powe

Re: [PATCH v8 4/8] ppc64 ftrace_with_regs configuration variables

2016-02-10 Thread Balbir Singh
On Wed, 2016-02-10 at 17:25 +0100, Torsten Duwe wrote: snip > diff --git a/arch/powerpc/gcc-mprofile-kernel-notrace.sh > b/arch/powerpc/gcc-mprofile-kernel-notrace.sh > new file mode 100755 > index 000..68d6482 > --- /dev/null > +++ b/arch/powerpc/gcc-mprofile-kernel-notrace.sh > @@ -0,0

Re: [PATCH v8 4/8] ppc64 ftrace_with_regs configuration variables

2016-02-11 Thread Balbir Singh
On Thu, 2016-02-11 at 14:09 +0530, Kamalesh Babulal wrote: > * Balbir Singh <bsinghar...@gmail.com> [2016-02-11 18:48:17]: > > > On Wed, 2016-02-10 at 17:25 +0100, Torsten Duwe wrote: > > > > snip > > > > > diff --git a/arch/powerpc/gcc-mprofi

Re: [PATCH v8 4/8] ppc64 ftrace_with_regs configuration variables

2016-02-11 Thread Balbir Singh
On Thu, 2016-02-11 at 09:42 +0100, Torsten Duwe wrote: > On Thu, Feb 11, 2016 at 06:48:17PM +1100, Balbir Singh wrote: > > On Wed, 2016-02-10 at 17:25 +0100, Torsten Duwe wrote: > > > + > > > +echo "int func() { return 0; }" | \ > > > +$* -S -x

Re: [PATCH v8 8/8] livepatch: Detect offset for the ftrace location during build

2016-02-12 Thread Balbir Singh
On Thu, 2016-01-28 at 16:32 +0100, Torsten Duwe wrote: > From: Petr Mladek > > Livepatch works on x86_64 and s390 only when the ftrace call > is at the very beginning of the function. But PPC is different. > We need to handle TOC and save LR there before calling the > global

Re: [PATCH v6 0/9] ftrace with regs + live patching for ppc64 LE (ABI v2)

2016-01-27 Thread Balbir Singh
On Wed, 27 Jan 2016 13:19:04 +0100 Torsten Duwe <d...@lst.de> wrote: > Thanks! Make sure you use a compiler that can disable -mprofile-kernel with > "notrace". gcc-6? I have gcc-5.2.1 Balbir Singh. ___ Linuxppc-dev mai

Re: [PATCH v7 0/6] cpufreq: powernv: Redesign the presentation of throttle notification and solve bug-fixes in the driver

2016-01-28 Thread Balbir Singh
ip_id() in hot path which reads DT every time > to find the chip id. > - Patches [4] to [6] will add a perf trace point > "power:powernv_throttle" and sysfs throttle counter stats in > /sys/devices/system/cpu/cpufreq/chipN. > Loo

Re: [PATCH] Fix kgdb on little endian ppc64le

2016-02-01 Thread Balbir Singh
On Mon, 1 Feb 2016 21:39:00 +1100 Andrew Donnellan <andrew.donnel...@au1.ibm.com> wrote: > On 01/02/16 17:03, Balbir Singh wrote: > > From: Balbir Singh <bsinghar...@gmail.com> > > > > I spent some time trying to use kgdb and debugged my inability to > > re

[PATCH] Fix kgdb on little endian ppc64le

2016-01-31 Thread Balbir Singh
From: Balbir Singh <bsinghar...@gmail.com> I spent some time trying to use kgdb and debugged my inability to resume from kgdb_handle_breakpoint(). NIP is not incremented and that leads to a loop in the debugger. I've tested this lightly on a virtual instance with KDB enabled. After the pa

  1   2   3   4   5   6   7   8   9   10   >