t introduces
> the implementation of the new functions is to separate the changes generated
> with Coccinelle from the rest, and keep the patches' size reasonable.
>
You can add my:
Tested-by: Boris Brezillon
and
Acked-by: Boris Brezillon
for the at91 part.
> Signed-off-by
inux-...@lists.infradead.org; linuxppc-dev ;
> > Prabhakar Kushwaha ; Raghav Dogra
> > ; Jaiprakash Singh ; Boris
> > Brezillon
> > Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0
> >
> > Hi,
> >
> > On Wed, Mar 30, 201
d, NULL, 0)) {
> > - printk(KERN_ERR "pasemi_nand: Unable to register MTD
> > device\n");
> > + pr_err("Unable to register MTD device\n");
>
> And why not to use dev_err(&ofdev->dev, …); ?
Yep, I think it's better to use dev_err().
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
ERR "pasemi_nand: Unable to register MTD device\n");
> + dev_err(dev, "Unable to register MTD device\n");
> err = -ENODEV;
> goto out_lpc;
> }
>
> - printk(KERN_INFO "PA Semi
Hello Joel,
On Wed, 6 Feb 2019 11:06:58 +1030
Joel Stanley wrote:
> This converts the powernv flash driver to use SPDX, and adds some
> clarifying comments that came out of a discussion on how the mtd driver
> works.
Can you split that in 2 patches, one adding the SPDX header, and the
other on
Hello Aneesh,
On Fri, 8 Feb 2019 20:44:18 +0530
"Aneesh Kumar K.V" wrote:
> With this patch, we use the mtd->name instead of concatenating the name with
> '0'
>
> Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem
> API")
> Signed-off-by: Aneesh Kumar K.V
You forg
On Mon, 11 Feb 2019 16:26:38 +0530
"Aneesh Kumar K.V" wrote:
> On 2/10/19 6:25 PM, Boris Brezillon wrote:
> > Hello Aneesh,
> >
> > On Fri, 8 Feb 2019 20:44:18 +0530
> > "Aneesh Kumar K.V" wrote:
> >
> >> With this patch, we use
Subject prefix should be "mtd: powernv_flash: "
On Mon, 11 Feb 2019 19:03:38 +0530
"Aneesh Kumar K.V" wrote:
> This change helps me to get multiple mtd device registered. Without this
> I get
>
> sysfs: cannot create duplicate filename '/bus/nvmem/devices/flash0'
> CPU: 0 PID: 1 Comm: swapper/0
From: Boris Brezillon
On Mon, 2019-02-11 at 13:33:38 UTC, "Aneesh Kumar K.V" wrote:
> This change helps me to get multiple mtd device registered. Without this
> I get
>
> sysfs: cannot create duplicate filename '/bus/nvmem/devices/flash0'
> CPU: 0 PID: 1 Co
From: Boris Brezillon
On Mon, 2019-02-11 at 13:33:37 UTC, "Aneesh Kumar K.V" wrote:
> With this patch, we use the mtd->name instead of concatenating the name with
> '0'
>
> Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem
&
On Fri, 13 Jul 2018 10:15:59 +0200
Rafał Miłecki wrote:
> From: Rafał Miłecki
>
> This enables some features implemented in mtd subsystem like reading
> label and partitioning info from DT.
>
> Reported-by: Timothy Pearson
> Signed-off-by: Rafał Miłecki
Applied.
Thanks,
Boris
> ---
> dr
And I forgot to Cc the DT maintainer/ML on this one :-/
On Wed, 3 Jun 2020 15:49:22 +0200
Boris Brezillon wrote:
> Those properties are no longer parsed by the driver which is being passed
> those information by the core now. Let's deprecate them.
>
> Signed-off-by
Replace the of_address_to_resource() + devm_ioremap() calls by
platform_get_resource() + devm_ioremap_resource() ones which allows us
to get rid of one error message since devm_ioremap_resource() already
takes care of that.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/fsl_upm.c | 23
n the init error path and in the
remove function.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/fsl_upm.c | 44 --
1 file changed, 10 insertions(+), 34 deletions(-)
diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c
index 54851e9
fsl_upm_nand.parts is unused, let's get rid of it.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/fsl_upm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c
index 76d1032cd35e..6eba2f4a2f5a 100644
--- a/drivers/mtd
onsider removing the
driver instead.
Regards,
Boris
Boris Brezillon (10):
mtd: rawnand: fsl_upm: Remove unused mtd var
mtd: rawnand: fsl_upm: Get rid of the unused fsl_upm_nand.parts field
mtd: rawnand: fsl_upm: Allocate the fsl_upm_nand object using
devm_kzalloc()
mtd: rawnand: fsl_upm
Now that the driver implements exec_op(), we can get rid of the legacy
interface implementation.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/fsl_upm.c | 133 -
1 file changed, 133 deletions(-)
diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd
The mtd var in fun_wait_rnb() is now unused, let's get rid of it and
fix the warning resulting from this unused var.
Fixes: 50a487e7719c ("mtd: rawnand: Pass a nand_chip object to
chip->dev_ready()")
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/fsl_upm.c | 1 -
Explicitly inherit from nand_controller instead of relying on the
nand_chip.legacy.dummy_controller field.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/fsl_upm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c
Implement exec_op() so we can get rid of the legacy interface
implementation.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/fsl_upm.c | 86 ++
1 file changed, 86 insertions(+)
diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c
This simplifies the init error patch and remove function.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/fsl_upm.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c
index 6eba2f4a2f5a
This simplifies the init() error path and the remove() handler.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/fsl_upm.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c
index 9cf79c62ef22
Those properties are no longer parsed by the driver which is being passed
those information by the core now. Let's deprecate them.
Signed-off-by: Boris Brezillon
---
Documentation/devicetree/bindings/mtd/fsl-upm-nand.txt | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
On Wed, 3 Jun 2020 15:55:31 +0200
Miquel Raynal wrote:
> Boris Brezillon wrote on Wed, 3 Jun
> 2020 15:49:16 +0200:
>
> > This simplifies the init() error path and the remove() handler.
> >
> > Signed-off-by: Boris Brezillon
> > ---
> > drivers/mtd
On Wed, 3 Jun 2020 15:58:02 +0200
Miquel Raynal wrote:
> Boris Brezillon wrote on Wed, 3 Jun
> 2020 15:49:17 +0200:
>
> > Replace the of_address_to_resource() + devm_ioremap() calls by
> > platform_get_resource() + devm_ioremap_resource() ones which allows us
> &
f the system.
>
> Signed-off-by: Cyril Bur
Acked-by: Boris Brezillon
> ---
> drivers/mtd/devices/powernv_flash.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/powernv_flash.c
> b/drivers/mtd/devices/powernv_flash.c
> index f5
n error rather we should wrap up and return promptly to
> the caller.
>
> Signed-off-by: Cyril Bur
Acked-by: Boris Brezillon
> ---
> I'll note here that currently no OPAL exists that will return
> OPAL_SUCCESS so there isn't the possibility of a bug today.
>
On Tue, 10 Oct 2017 14:32:55 +1100
Cyril Bur wrote:
Can you please add a short description here?
Once done you can add
Acked-by: Boris Brezillon
> Signed-off-by: Cyril Bur
> ---
> drivers/mtd/devices/powernv_flash.c | 16 ++--
> 1 file changed, 6 insertions(+),
e what to do.
>
> Signed-off-by: Cyril Bur
Acked-by: Boris Brezillon
> ---
> drivers/mtd/devices/powernv_flash.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mtd/devices/powernv_flash.c
> b/drivers/mtd/devices/powernv_flash.c
> index 4d
comments (see below). Once addressed you can add
Acked-by: Boris Brezillon
> ---
> drivers/mtd/devices/powernv_flash.c | 57
> +++--
> 1 file changed, 35 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/mtd/devices/powernv_flash.c
&g
On Tue, 10 Oct 2017 14:32:52 +1100
Cyril Bur wrote:
> V4: Rework and rethink.
>
> To recap:
> Userspace MTD read()s/write()s and erases to powernv_flash become
> calls into the OPAL firmware which subsequently handles flash access.
> Because the read()s, write()s or erases can be large (bounded
Hi Raghavan,
On Fri, 6 Jan 2017 10:07:29 +
"Anurag Raghavan (RBEI/ETW11)" wrote:
> Hi All,
>
> My appdata partition could not be mounted or where the partition was not able
> to be used. Anyone can help me to find out the root cause of this. What are
> the possibilities of this ubifs corr
On Tue, 24 Jan 2017 12:01:22 +0100
wrote:
> From: Mark Marshall
>
> The commit 7a654172161c ("mtd/ifc: Add support for IFC controller
> version 2.0") added support for version 2.0 of the IFC controller.
> The version 2.0 controller has the ECC status registers at a different
> location to the p
On Thu, 26 Jan 2017 16:18:27 +0100
wrote:
> From: Mark Marshall
>
> The commit 7a654172161c ("mtd/ifc: Add support for IFC controller
> version 2.0") added support for version 2.0 of the IFC controller.
> The version 2.0 controller has the ECC status registers at a different
> location to the p
Some fields are not used by MTD drivers, users or core code. Moreover,
those fields are not documented, so get rid of them to avoid any
confusion.
Signed-off-by: Boris Brezillon
---
include/linux/mtd/mtd.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/include/linux/mtd/mtd.h b/include
mtd_erase() can return an error before ->fail_addr is initialized to
MTD_FAIL_ADDR_UNKNOWN. Move this initialization at the very beginning
of the function.
Signed-off-by: Boris Brezillon
---
drivers/mtd/mtdcore.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/
sistent and
allows us to get rid of a few hundred lines of code.
Regards,
Boris
Boris Brezillon (5):
mtd: Initialize ->fail_addr early in mtd_erase()
mtd: Get rid of unused fields in struct erase_info
mtd: Stop assuming mtd_erase() is asynchronous
mtd: Unconditionally update ->fail_a
rase_info->callback() and are thus only taking the
->addr_fail and ->addr fields into account after part_erase() has
returned.
While we're at it, get rid of the erase_info->mtd field which was only
needed to let mtd_erase_callback() get the partition device back.
Signed-off-by: Boris B
None of the mtd->_erase() implementations work in an asynchronous manner,
so let's simplify MTD users that call mtd_erase(). All they need to do
is check the value returned by mtd_erase() and assume that != 0 means
failure.
Signed-off-by: Boris Brezillon
---
drivers/mtd/devices/bcm47xx
>state field, all MTD_ERASE_XXX definitions and the
mtd_erase_callback() function.
Signed-off-by: Boris Brezillon
---
drivers/mtd/chips/cfi_cmdset_0001.c | 16 ++--
drivers/mtd/chips/cfi_cmdset_0002.c | 26 +++---
drivers/mtd/chips/cfi_cmdset_0020.c
e->state = MTD_ERASE_DONE;
> > - }
> > - mtd_erase_callback(erase);
> > +
> > return rc;
> > }
> >
> > diff --git a/drivers/mtd/devices/slram.c b/drivers/mtd/devices/slram.c
> > index 0ec85f316d24..2f05e1801047 100644
> > --- a/drivers/mtd/devices/slram.c
> > +++ b/drivers/mtd/devices/slram.c
> > @@ -88,8 +88,6 @@ static int slram_erase(struct mtd_info *mtd, struct
> > erase_info *instr)
> > * I don't feel at all ashamed. This kind of thing is possible anyway
> > * with flash, but unlikely.
> > */
>
> Same with this comment.
Actually, I'm not sure I understand that comment, but I guess it's
talking about races between read/write and erase paths, so nothing
related to the changed I'm doing here.
>
> > - instr->state = MTD_ERASE_DONE;
> > - mtd_erase_callback(instr);
>
> Space ?
>
> > return(0);
> > }
> >
>
>
>
>
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
On Mon, 12 Feb 2018 22:03:07 +0100
Boris Brezillon wrote:
> mtd_erase() can return an error before ->fail_addr is initialized to
> MTD_FAIL_ADDR_UNKNOWN. Move this initialization at the very beginning
> of the function.
Applied the patchset after addressing Miquel's comments.
On Fri, 4 Nov 2016 19:42:48 +0900
Masahiro Yamada wrote:
> nand_scan(), nand_scan_ident(), nand_scan_tail() return
> an appropriate negative value on error.
>
> Most of drivers return the value from them on error,
> but some of them return the fixed error code -ENXIO
> (and a few return -ENODEV
On Wed, 25 May 2016 14:18:43 -0500
Leo Li wrote:
> On Thu, Apr 7, 2016 at 7:45 PM, Boris Brezillon
> wrote:
> > On Wed, 6 Apr 2016 18:53:39 +
> > Yang-Leo Li wrote:
> >
> >>
> >>
> >> > -Original Message-
> &g
Hi Leo,
On Fri, 27 May 2016 15:15:00 -0500
Leo Li wrote:
> On Wed, May 25, 2016 at 3:34 PM, Boris Brezillon
> wrote:
> > On Wed, 25 May 2016 14:18:43 -0500
> > Leo Li wrote:
> >
> >> On Thu, Apr 7, 2016 at 7:45 PM, Boris Brezillon
> >> wrote:
On Fri, 27 May 2016 14:12:47 -0700
Brian Norris wrote:
>
> > Anyway, Brian, can you take it into your tree and make it appear in
> > -rc1 (or earlier if it's still possible)?
>
> Not sure how I could get it any "earlier"? It's not making -rc1 at t
+PPC maintainers.
Hi Raghav,
Since you're touching powerpc drivers, the least you could do is add
ppc maintainers in Cc, so that they can ack/review your patch...
On Fri, 1 Jul 2016 21:32:30 +0530
Raghav Dogra wrote:
> This patch enables IFC NAND support on ARM layerscape platform.
> It fixes
function prototypes.
Signed-off-by: Boris Brezillon
Signed-off-by: Peter Pan
Cc: Jonathan Corbet
Cc: Sekhar Nori
Cc: Kevin Hilman
Cc: Jason Cooper
Cc: Andrew Lunn
Cc: Sebastian Hesselbarth
Cc: Gregory Clement
Cc: Hartley Sweeten
Cc: Alexander Sverdlin
Cc: Shawn Guo
Cc: Sascha Hauer
Cc
function prototypes.
Signed-off-by: Boris Brezillon
Signed-off-by: Peter Pan
Cc: Jonathan Corbet
Cc: Sekhar Nori
Cc: Kevin Hilman
Cc: Jason Cooper
Cc: Andrew Lunn
Cc: Sebastian Hesselbarth
Cc: Gregory Clement
Cc: Hartley Sweeten
Cc: Alexander Sverdlin
Cc: Shawn Guo
Cc: Sascha Hauer
Cc
Le Fri, 4 Aug 2017 17:29:09 +0200,
Boris Brezillon a écrit :
> We are planning to share more code between different NAND based
> devices (SPI NAND, OneNAND and raw NANDs), but before doing that
> we need to move the existing include/linux/mtd/nand.h file into
> include/linux/mtd/raw
50 matches
Mail list logo
