Re: linux-next: powerpc tree build warning

2009-08-23 Thread Christoph Hellwig
On Mon, Aug 24, 2009 at 10:22:56AM +1000, Stephen Rothwell wrote: Hi all, Today's linux-next build (powerpc ppc64_defconfig) produced this warning: kernel/time/tick-sched.c: In function 'tick_nohz_stop_sched_tick': kernel/time/tick-sched.c:261: warning: format '%02x' expects type 'unsigned

Re: [PATCH] powerpc: Change archdata dma_data type to dma_addr_t

2009-08-24 Thread Christoph Hellwig
On Mon, Aug 24, 2009 at 11:17:14AM -0500, Becky Bruce wrote: Previously, this was specified as a void *, but that's not large enough on 32-bit systems with 36-bit physical addressing support. Change the type to dma_addr_t so it will scale based on the size of a dma address. This looks

Re: [PATCH] macintosh: Explicitly set llseek to no_llseek in ans-lcd

2009-11-16 Thread Christoph Hellwig
On Mon, Nov 02, 2009 at 04:51:52PM +0100, Arnd Bergmann wrote: I looked at what places in the code manipulate file-f_pos directly and found that almost all the uses in driver code are broken because they don't take any locks. Most of them are in driver specific lseek operations. Others are in

Re: [PATCH 4/7] parisc: rtc: Rename rtc-parisc to rtc-generic

2009-03-16 Thread Christoph Hellwig
On Mon, Mar 09, 2009 at 02:26:20PM +0100, Geert Uytterhoeven wrote: The rtc-parisc driver is not PA-RISC specific at all, as it uses the existing (but deprecated) generic RTC infrastructure ([gs]et_rtc_time()). Rename the driver from rtc-parisc to rtc-generic. Maybe it should be called

Re: [PATCH 1/6] powerpc: Move #ifdef'ed body of do_IRQ() into a separate function

2009-04-25 Thread Christoph Hellwig
On Thu, Apr 23, 2009 at 11:31:37AM +1000, Michael Ellerman wrote: +#ifdef CONFIG_IRQSTACKS Wasn't there a plan to make CONFIG_IRQSTACKS the unconditional default? The actual patch looks good to me. ___ Linuxppc-dev mailing list

Re: [PATCH 1/6] powerpc: Move #ifdef'ed body of do_IRQ() into a separate function

2009-04-29 Thread Christoph Hellwig
On Tue, Apr 28, 2009 at 10:49:07AM +1000, Michael Ellerman wrote: On Sat, 2009-04-25 at 20:18 +0200, Christoph Hellwig wrote: On Thu, Apr 23, 2009 at 11:31:37AM +1000, Michael Ellerman wrote: +#ifdef CONFIG_IRQSTACKS Wasn't there a plan to make CONFIG_IRQSTACKS the unconditional default

Re: asm-offsets.c

2008-02-07 Thread Christoph Hellwig
On Wed, Feb 06, 2008 at 11:43:41PM -0500, Sean MacLennan wrote: I just did a git pull of Josh's tree, and arch/powerpc/kernel/asm-offsets.c does not compile. I have only been glossing over the linuxppc-dev emails, so forgive me if this already came up. It looks like, at least for the

Re: [Cbe-oss-dev] [PATCH 1/1] Cell RAS: Remove DEBUG, and add license and copyright

2008-03-02 Thread Christoph Hellwig
On Thu, Feb 14, 2008 at 01:34:17PM +1100, Michael Ellerman wrote: arch/powerpc/platforms/cell/ras.c still has DEBUG #defined, which is no longer neccessary. Disable it, this disables to pr_debugs(). No need to undef it, it's undefined by default. Otherwise the patch looks fine to me.

Re: [PATCH] ppc: Export empty_zero_page

2008-03-13 Thread Christoph Hellwig
On Tue, Mar 11, 2008 at 10:44:06PM -0400, Theodore Ts'o wrote: Stephen Rothwell discovered this issue in the linux-next tree: Today's powerpc allmodconfig build of linux-next failed with: ERROR: empty_zero_page [fs/ext4/ext4dev.ko] undefined! This is because commit

Re: [PATCH 6/8] ptrace: arch_ptrace -ENOSYS return

2008-03-20 Thread Christoph Hellwig
On Wed, Mar 19, 2008 at 07:40:25PM -0700, Linus Torvalds wrote: And I have to say, I really hate that ret = arch_ptrace(child, request, addr, data); if (ret == -ENOSYS !forced_successful_syscall_return()) ret = ptrace_request(child,

Re: [PATCH 6/8] ptrace: arch_ptrace -ENOSYS return

2008-03-21 Thread Christoph Hellwig
On Fri, Mar 21, 2008 at 02:50:01PM +0100, Thomas Gleixner wrote: What about adding a CONFIG_ARCH_HAS_PTRACE2, which is set by the archs which are converted. For those which are not you add a fallback implementation: Bah. Folks, we're talking about adding a single new argument to a single

Re: [PATCH] RTAS - adapt procfs interface

2008-04-03 Thread Christoph Hellwig
On Tue, Apr 01, 2008 at 03:12:20PM +0200, Jens Osterkamp wrote: Hi, rtas_flash was broken since 2.6.24-rc5. This patch fixes it. I think this is a good bugfix candidate for 2.6.25. NACK. driver should not poke into the internal count member. Just provide your own inclusion with a new

Re: [Cbe-oss-dev] [PATCH] RTAS - adapt procfs interface

2008-04-04 Thread Christoph Hellwig
On Fri, Apr 04, 2008 at 07:39:29AM +0200, Arnd Bergmann wrote: Well we still have the regression against 2.6.23 and I'd like to get that fixed in 2.6.25 if it's not already release by the time we get there. Would you prefer using Nathan's proper patch for 2.6.25, or do that for 2.6.26

Re: [PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth

2008-04-09 Thread Christoph Hellwig
On Wed, Apr 09, 2008 at 05:21:34PM +1000, Benjamin Herrenschmidt wrote: The iSeries veth driver uses an on-stack struct completion that it initializes using the COMPLETION_INITIALIZER instead of COMPLETION_INITIALIZER_ONSTACK macro, causing problems with lockdep. should probably go in ASAP

Re: [PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth

2008-04-10 Thread Christoph Hellwig
On Thu, Apr 10, 2008 at 07:03:22AM +1000, Benjamin Herrenschmidt wrote: I don't think there's any difference between the _ONSTACK variant and the normal one without lockdep, is there ? No there's not. Thus it's a guaranteed no-op and can easily go in.

Re: Add compat handler for PTRACE_GETSIGINFO

2008-04-21 Thread Christoph Hellwig
On Sat, Apr 19, 2008 at 06:25:13PM +0200, Andreas Schwab wrote: Current versions of gdb require a working implementation of PTRACE_GETSIGINFO for proper watchpoint support. Since struct siginfo contains pointers it must be converted when passed to a 32-bit debugger. Roland just posted a patch

Re: new warnings from stacktrace patch

2008-04-23 Thread Christoph Hellwig
. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/arch/powerpc/kernel/stacktrace.c === --- linux-2.6.orig/arch/powerpc/kernel/stacktrace.c 2008-04-23 15:28:05.0 +0200 +++ linux-2.6/arch/powerpc/kernel

Re: [PATCH] Consolidate mm_context_t definition in mmu.h

2007-07-11 Thread Christoph Hellwig
On Tue, Jul 10, 2007 at 10:01:49AM -0500, Josh Boyer wrote: + +#ifdef CONFIG_PPC64 +typedef unsigned long mm_context_id_t; + +typedef struct { + mm_context_id_t id; + u16 user_psize; /* page size index */ + +#ifdef CONFIG_PPC_MM_SLICES + u64 low_slices_psize; /* SLB

Re: [PATCH 1/2] Enable SPU switch notification to detect currently active SPU tasks.

2007-07-13 Thread Christoph Hellwig
On Fri, Jul 13, 2007 at 12:12:33PM +0200, Christoph Hellwig wrote: -static inline int spu_stopped(struct spu_context *ctx, u32 * stat) +static inline int spu_stopped(struct spu_context *ctx, u32 *stat) useless (and wrong) reformatting, please remove. Sorry, this looked like going the wrong

Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic

2007-07-15 Thread Christoph Hellwig
On Sat, Jul 14, 2007 at 11:57:48PM -0700, David Miller wrote: only request is to make this thing able to handle ipv6 as well even if no current chips could facilitate that yet. I'm not sure that's a good idea. If current chips can't handle ipv6 lro there is no way to actually test it and the

[PATCH] mv64x60 use mutex instead of semaphore

2007-07-19 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/arch/ppc/syslib/mv64x60.c === --- linux-2.6.orig/arch/ppc/syslib/mv64x60.c2007-07-19 22:47:07.0 +0200 +++ linux-2.6/arch/ppc/syslib/mv64x60.c 2007-07

Re: Generic clk.h wrappers? [Was: Re: [PATCH 1/3] powerpc clk.h interface for platforms]

2007-08-01 Thread Christoph Hellwig
On Wed, Aug 01, 2007 at 09:28:07AM +0200, Domen Puncer wrote: It doesn't make any assumption on struct clk, it's just a wrapper around functions from clk.h. Point of this patch was to abstract exported functions, since arch/powerpc/ can support multiple platfroms in one binary. So...

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Christoph Hellwig
On Wed, Sep 12, 2007 at 04:01:09AM -0700, Andrew Morton wrote: On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens [EMAIL PROTECTED] wrote: On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: The tty: termios locking functions break with new termios type patch

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Christoph Hellwig
On Wed, Sep 12, 2007 at 01:52:57PM +0200, Heiko Carstens wrote: I might be missing something, but the the right fix is probably to apply the arch patches from Alan to powerpc and s390. We don't want to be left over without all the nice termios features on these platforms, do we? But

Re: [PATCH 01/25] spufs: staticify file-internal functions variables

2007-09-14 Thread Christoph Hellwig
On Fri, Sep 14, 2007 at 04:32:54PM +1000, Jeremy Kerr wrote: From: Sebastian Siewior [EMAIL PROTECTED] There are a few symbols used only in one file within spufs; this change makes them static where suitable. Signed-off-by: Sebastian Siewior [EMAIL PROTECTED] Signed-off-by: Jeremy Kerr

Re: [PATCH 09/25] cell: remove DEBUG for spu callbacks

2007-09-14 Thread Christoph Hellwig
On Fri, Sep 14, 2007 at 04:32:54PM +1000, Jeremy Kerr wrote: We don't want SPE programs to be able to flood the kernel log by invoking the SPE callback handler, so don't enable DEBUG for spu_callbacks.c by default. Yeah, sounds sane. ___

Re: [PATCH 02/25] spufs: remove asmlinkage from do_spu_create

2007-09-14 Thread Christoph Hellwig
On Fri, Sep 14, 2007 at 04:32:54PM +1000, Jeremy Kerr wrote: do_spu_create doesn't need the asmlinkage qualifier; remove it. Ah, okay it's solved here. Drop my earlier comment then. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH 10/25] spusched: fix null pointer dereference in find_victim

2007-09-14 Thread Christoph Hellwig
On Fri, Sep 14, 2007 at 04:32:54PM +1000, Jeremy Kerr wrote: From: Christoph Hellwig [EMAIL PROTECTED] find_victim can dereference a NULL pointer when iterating over the list of victim spus because list_mutex only guarantees spu-ct to be stable, but of course not to be non-NULL. Also fix

Re: [PATCH 19/25] spufs: Internal __spufs_get_foo() routines should take a spu_context *

2007-09-14 Thread Christoph Hellwig
On Fri, Sep 14, 2007 at 04:32:54PM +1000, Jeremy Kerr wrote: From: Michael Ellerman [EMAIL PROTECTED] The SPUFS attribute get routines take a void * because the generic attribute code doesn't know what sort of data it's passing around. However our internal __spufs_get_foo() routines can

Re: [PATCH 09/11] [POWERPC] iSeries: move detection of virtual tapes

2007-09-21 Thread Christoph Hellwig
+#if defined(CONFIG_VIOTAPE) || defined(CONFIG_VIOTAPE_MODULE) +/* Handle interrupt events for tape */ +static void __init handle_tape_event(struct HvLpEvent *event) +{ + struct vio_waitevent *we; + struct viotapelpevent *tevent = (struct viotapelpevent *)event; I think we should

Re: [PATCH 1/2] qemu platform, v2

2007-09-22 Thread Christoph Hellwig
On Fri, Sep 21, 2007 at 06:08:31PM -0500, Milton Miller wrote: Here is the second rev of patches to boot a arch powerpc kernel on qemu with the prep architecture. So if this is supposed to be prep why do you need additional kernel support? And if you really needed why isn't it under

Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

2007-09-30 Thread Christoph Hellwig
On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote: + if ((rc = platform_driver_register(ace_platform_driver)) != 0) + goto err_plat; rc = platform_driver_register(ace_platform_driver); if (rc) goto err_plat; please. + err_plat:

annoying prinkts during vmemmap initialization

2007-11-21 Thread Christoph Hellwig
Hi Andi, your patch 'ppc64: SPARSEMEM_VMEMMAP support' adds the following two lines: + printk(KERN_WARNING vmemmap %08lx allocated at %p, + physical %p.\n, start, p, __pa(p)); in a loop around basically every page. That's a lot of flooding

Re: annoying prinkts during vmemmap initialization

2007-11-21 Thread Christoph Hellwig
On Thu, Nov 22, 2007 at 09:41:45AM +1100, Stephen Rothwell wrote: Any reason to keep this? And if yes can we please make it conditional on some kind of vmemmap_debug boot option? These have been changed to pr_debug() in 2.6.24-rc3 kernel. Ah, sorry for not checking. Looks like the spufs

Re: [PATCH 1/11] ibm_newemac: Add BCM5248 and Marvell 88E1111 PHY support

2007-11-29 Thread Christoph Hellwig
On Fri, Nov 30, 2007 at 04:40:23PM +1100, Benjamin Herrenschmidt wrote: From: Stefan Roese [EMAIL PROTECTED] This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. These PHY chips are used on PowerPC 440EPx boards. The PHY code is based on the previous work by Stefan

Re: [PATCH 1/7] powerpc: Reduce footprint of irq_stat

2010-02-01 Thread Christoph Hellwig
On Mon, Feb 01, 2010 at 05:30:23PM +1100, Anton Blanchard wrote: PowerPC is currently using asm-generic/hardirq.h which statically allocates an NR_CPUS irq_stat array. Switch to an arch specific implementation which uses per cpu data: On a kernel with NR_CPUS=1024, this saves quite a lot

Re: ppc64 sys_ipc breakage in 2.6.34-rc2

2010-03-22 Thread Christoph Hellwig
On Mon, Mar 22, 2010 at 05:47:59PM +1100, Anton Blanchard wrote: The patch below changes second from an int to an unsigned long which fixes shmget on ppc64 (and I assume s390, sparc64 and mips64). Looks good, except that the prototype in the header also needs to be adjusted.

Re: [PATCH] powerpc copy_siginfo_from_user32

2008-04-25 Thread Christoph Hellwig
On Sat, Apr 19, 2008 at 03:19:24PM -0700, Roland McGrath wrote: Hi. I posted this before, but I don't see it in any of your powerpc.git trees. Can you push this upstream ASAP? It would make life easier for me trying to merge some more generic changes (that would break powerpc builds without

Re: [RFC][WIP][PATCH] Add IRQSTACKS to ppc32

2008-04-25 Thread Christoph Hellwig
On Thu, Apr 24, 2008 at 12:37:50AM -0500, Kumar Gala wrote: config IRQSTACKS bool Use separate kernel stacks when processing interrupts - depends on PPC64 Why do we have this as a user-selectable option? It should be on by default on 32 or 64bit.

Re: [PATCH] Add fast little-endian switch system call

2008-04-28 Thread Christoph Hellwig
Please see Michael Kerrisk on userspace ABI updates. A nice little manpage for this gimmick would be helpful, and maybe help other platforms that want one aswell to implement the same API. On Mon, Apr 28, 2008 at 01:52:31PM +1000, Paul Mackerras wrote: This adds a system call on 64-bit

Re: [PATCH] Add fast little-endian switch system call

2008-04-29 Thread Christoph Hellwig
On Tue, Apr 29, 2008 at 08:40:47PM +0200, Wolfgang Denk wrote: This probably depends a bit on the performance of the system in question. Did you measure it - for example - on a 50 MHz MPC850 ? You got a 64bit kernel to run on a MPC850? wow :) Not sure what the slowest supported 64bit cpu

Re: WARNING: mutexes are preferred for single holder semaphores

2008-05-05 Thread Christoph Hellwig
On Mon, May 05, 2008 at 12:13:43PM +1000, Paul Mackerras wrote: Sean MacLennan writes: This is a bit OT, but I got the warning in the subject from checkpatch.pl for a piece of code. The code *is* using a mutex. Does it actually mean I shouldn't use a mutex? I don't require zero

Re: [RFC] POWERPC: Merge 32 and 64-bit dma code

2008-05-23 Thread Christoph Hellwig
On Wed, Apr 30, 2008 at 06:36:43PM -0500, Becky Bruce wrote: In addition, the dma_map/unmap_page functions are added to dma_ops on HIGHMEM-enabled configs because we can't just fall back on map/unmap_single when HIGHMEM is enabled. Adding these to dma_ops makes it cleaner to substitute

Re: [RFC: 2.6 patch] powerpc: asm/elf.h: reduce userspace header

2008-06-30 Thread Christoph Hellwig
On Mon, Jun 23, 2008 at 08:48:28PM +0300, Adrian Bunk wrote: This patch makes asm/elf.h export less non-userspace stuff to userspace. I don't think this header should be exported at all. There's a userspace elf.h that should be used instead. ___

Re: [Cbe-oss-dev] [patch 7/9] azfs: initial submit of azfs, a non-buffered filesystem

2008-07-22 Thread Christoph Hellwig
On Tue, Jul 15, 2008 at 09:51:46PM +0200, [EMAIL PROTECTED] wrote: From: Maxim Shchetynin [EMAIL PROTECTED] AZFS is a file system which keeps all files on memory mapped random access storage. It was designed to work on the axonram device driver for IBM QS2x blade servers, but can operate on

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-28 Thread Christoph Hellwig
On Sun, Jul 27, 2008 at 12:56:04PM -0700, David Miller wrote: Yes, please. IMHO, this driver was really rushed in and that was a huge mistake. If it had gone through linux-next we could have tidied all of this stuff up in a less rushed manner. Or just reviewed in at least some way..

[PATHC] powerpc: use generic compat_sys_old_readdir

2008-08-16 Thread Christoph Hellwig
the only one. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/arch/powerpc/include/asm/systbl.h === --- linux-2.6.orig/arch/powerpc/include/asm/systbl.h2008-08-16 13:08:35.0 -0300 +++ linux-2.6/arch

[PATCH] powerpc: use sys_pause for 32bit pause entry point

2008-08-31 Thread Christoph Hellwig
sys32_pause is a useless copy of the generic sys_pause. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/arch/powerpc/include/asm/systbl.h === --- linux-2.6.orig/arch/powerpc/include/asm/systbl.h2008-08-22

Re: [PATCH] powerpc: Reserve syscall number 319

2008-09-02 Thread Christoph Hellwig
On Wed, Sep 03, 2008 at 07:06:15AM +1000, Benjamin Herrenschmidt wrote: Yes. Merge your code or live with the pain of things changing underneath. Period. Pain isn't for me :-) It's for those writing userspace stuff based on my kernel changing all the time :-) They can wait until it's

build failure with current linus tree

2008-09-04 Thread Christoph Hellwig
Current linus tree fail to build for me for a 64bit powerpc config with: WARNING: modpost: Found 13 section mismatch(es). To see full details build your kernel with: 'make CONFIG_DEBUG_SECTION_MISMATCH=y' mm/built-in.o: In function `.strndup_user': (.text+0x1401a): undefined reference to

Re: [PATCH 2/4] POWERPC: Move iommu dma ops from dma.c to dma-iommu.c

2008-09-08 Thread Christoph Hellwig
On Mon, Sep 08, 2008 at 02:09:53PM -0500, Becky Bruce wrote: +/* We support DMA to/from any memory page via the iommu */ +static int dma_iommu_dma_supported(struct device *dev, u64 mask) +{ + struct iommu_table *tbl = dev-archdata.dma_data; + + if (!tbl || tbl-it_offset mask) { +

Re: git apply vs. renamed files index mismatch (was: Re: [PATCH 1/4] POWERPC: Rename dma_64.c to dma.c)

2008-09-08 Thread Christoph Hellwig
On Tue, Sep 09, 2008 at 01:27:17AM +0400, Anton Vorontsov wrote: I always thought that posting -M patches to the public lists is discouraged since it is quite difficult to apply them via patch(1). Also think of non-git users... Yes, it's a horrible idea.

Re: [PATCH 4/4] POWERPC: Merge 32 and 64-bit dma code

2008-09-08 Thread Christoph Hellwig
- if (unlikely(dev == NULL || dev-archdata.dma_ops == NULL)) + + if (unlikely(dev == NULL) || dev-archdata.dma_ops == NULL) { +#ifdef CONFIG_PPC64 return NULL; +#else + /* Use default on 32-bit if dma_ops is not set up */ + return

Re: Get USE_STRICT_MM_TYPECHECKS working again

2008-09-09 Thread Christoph Hellwig
On Tue, Sep 09, 2008 at 03:04:47PM +1000, David Gibson wrote: The typesafe version of the powerpc pagetable handling (with USE_STRICT_MM_TYPECHECKS defined) has bitrotted again. This patch makes a bunch of small fixes to get it building again. It might be a better idea to mark these types

Re: [PATCH 4/4] POWERPC: Merge 32 and 64-bit dma code

2008-09-09 Thread Christoph Hellwig
of the conversation: On May 23, 2008, at 4:51 AM, Christoph Hellwig wrote: On Wed, Apr 30, 2008 at 06:36:43PM -0500, Becky Bruce wrote: In addition, the dma_map/unmap_page functions are added to dma_ops on HIGHMEM-enabled configs because we can't just fall back on map/ unmap_single when

Re: [PATCH 4/4] POWERPC: Merge 32 and 64-bit dma code

2008-09-09 Thread Christoph Hellwig
On Wed, Sep 10, 2008 at 08:10:31AM +1000, Benjamin Herrenschmidt wrote: Yeah, the statement this time should be why do you keep _single :) It don't really mind which one we keep, but having both and both optional seems rather odd. It would be more logic to implement _single on top of

Re: build failure with current linus tree

2008-09-09 Thread Christoph Hellwig
On Fri, Sep 05, 2008 at 03:06:18AM +0200, Christoph Hellwig wrote: Current linus tree fail to build for me for a 64bit powerpc config with: This is cause by commit 7563dc64585324f443f5ac107eb6d89ee813a2d2 Author: Tony Breeds [EMAIL PROTECTED] Date: Tue Sep 2 16:50:38 2008 +1000 powerpc

Re: [PATCH] sputrace : use marker_synchronize_unregister()

2008-09-29 Thread Christoph Hellwig
On Mon, Sep 29, 2008 at 11:11:47AM -0400, Mathieu Desnoyers wrote: We need a marker_synchronize_unregister() before the end of exit() to make sure every probe callers have exited the non preemptible section and thus are not executing the probe code anymore. Looks good.

Re: [RFC/PATCH] Block device for the ISS simulator

2008-10-03 Thread Christoph Hellwig
On Fri, Oct 03, 2008 at 10:08:42AM +1000, Benjamin Herrenschmidt wrote: The ISS simulator is a simple powerpc simulator used among other things for hardware bringup. It implements a simple memory mapped block device interface. This is a simple block driver that attaches to it. Note that the

Re: [PATCH 12/40] x86, compat: convert ia32 layer to use

2010-06-23 Thread Christoph Hellwig
Any reason we need to differenciate between COMPAT_SYSCALL_DEFINE and ARCH_COMPAT_SYSCALL_DEFINE? We don't need this for native system calls, so I can't see the reason to do it for compat system calls. ___ Linuxppc-dev mailing list

Re: [PATCH 12/40] x86, compat: convert ia32 layer to use

2010-06-23 Thread Christoph Hellwig
On Wed, Jun 23, 2010 at 12:36:21PM +0200, Frederic Weisbecker wrote: I think we wanted that to keep the sys32_ prefixed based naming, to avoid collisions with generic compat handler names. For native syscalls we do this by adding a arch prefix inside the syscall name, e.g.:

Re: [PATCH 31/40] trace syscalls: Convert various generic compat syscalls

2010-06-23 Thread Christoph Hellwig
On Wed, Jun 23, 2010 at 02:35:38PM +0200, Andi Kleen wrote: I haven't heard any complains about existing syscalls wrappers. At least for me they always interrupt my grepping. What kind of annotations could solve that? If you put the annotation in a separate macro and leave the original

Re: [PATCH 12/40] x86, compat: convert ia32 layer to use

2010-06-24 Thread Christoph Hellwig
On Wed, Jun 23, 2010 at 12:23:44PM -0700, H. Peter Anvin wrote: arch/s390/kernel/sys_s390.c:SYSCALL_DEFINE(s390_fallocate)(int fd, int mode, loff_t offset, arch/sparc/kernel/sys_sparc_64.c:SYSCALL_DEFINE1(sparc_pipe_real, struct pt_regs *, regs) In fact we sort of wanted to

Re: cc'ing old list

2010-08-20 Thread Christoph Hellwig
On Fri, Aug 20, 2010 at 01:26:42PM +1000, Stephen Rothwell wrote: Yes, I do know that the kernel MAINTAINERS file has the old address. :-( Time to fix it.. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

odd change to drivers/net/ibm_newemac/core.c

2008-10-23 Thread Christoph Hellwig
+#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL dev-features |= EMAC_FTR_NO_FLOW_CONTROL_40x; +#else + printk(KERN_ERR %s: Flow control not disabled!\n, + np-full_name); + return -ENXIO; +#endif

Re: Large stack usage in fs code (especially for PPC64)

2008-11-18 Thread Christoph Hellwig
On Tue, Nov 18, 2008 at 10:03:25AM +1100, Benjamin Herrenschmidt wrote: On Mon, 2008-11-17 at 15:34 -0500, Steven Rostedt wrote: Note, I was using a default config that had CONFIG_IRQSTACKS off and CONFIG_PPC_64K_PAGES on. For one, we definitely need to turn IRQSTACKS on by default ... In

Re: [RFC][POWERPC] Provide a way to protect 4k subpages when using 64k pages

2007-12-11 Thread Christoph Hellwig
On Fri, Dec 07, 2007 at 05:09:27PM +1100, Paul Mackerras wrote: Implicit in this is that the regions of the address space that are protected are switched to use 4k hardware pages rather than 64k hardware pages (on machines with hardware 64k page support). In fact the whole process is switched

Re: [PATCH] Implement pci_set_dma_mask() in terms of the dma_ops

2007-12-17 Thread Christoph Hellwig
On Mon, Dec 17, 2007 at 05:35:53PM +1100, Michael Ellerman wrote: To save adding a hook to the dma mapping ops, pci-set_consistent_dma_mask() simply calls the dma_set_mask() hook and then copies the new mask into dev.coherenet_dma_mask. How is this supposed to work? There are various devices

Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-20 Thread Christoph Hellwig
On Thu, Dec 20, 2007 at 03:58:16AM -0800, Roland McGrath wrote: +obj-$(CONFIG_PPC64) += ../../../fs/compat_binfmt_elf.o Building files from another directory is nasty. Please add a CONFIG_BINFMT_COMPAT_ELF so we can simply build it in fs/

Re: [Cbe-oss-dev] Time for cell code reshuffle?

2007-12-23 Thread Christoph Hellwig
On Sun, Dec 23, 2007 at 12:47:42PM +0900, Jeremy Kerr wrote: Hi all, To the question, where what it should go, I'd leave the decision to Jeremy, but my current idea would be: arch/powerpc/platforms/cell/spufs - arch/powerpc/spufs I'd suggest arch/powerpc/sysdev/spufs to keep

Re: [PATCH 1/2] ipr: Convert to generic DMA API

2014-10-21 Thread Christoph Hellwig
Wendy, Brian, can you give me an ACK for this series? ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/2] ipr: Convert to generic DMA API

2014-10-30 Thread Christoph Hellwig
On Wed, Oct 29, 2014 at 12:34:49PM -0500, Brian King wrote: Acked-by: Brian King brk...@linux.vnet.ibm.com Doesn't apply to me. Brain, can you please resend a rebased version of these two patches with ipr error handlign patch (and anything else ipr related)?

Re: [PATCH 1/3] ipr: Convert to generic DMA API

2014-11-03 Thread Christoph Hellwig
Thanks, I've applied patch 3 to drivers-for-3.18, and patches 1 and 2 to core-for-3.19. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/spufs: Initialise inode-i_ino in spufs_new_inode()

2013-04-23 Thread Christoph Hellwig
Looks good. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 13/13] kvm/powerpc: Allow book3s_hv guests to use SMT processor modes

2011-05-11 Thread Christoph Hellwig
On Wed, May 11, 2011 at 08:46:56PM +1000, Paul Mackerras wrote: arch/powerpc/sysdev/xics/icp-native.c. What kernel tree do I need to actually have that file? ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: mount file system using offset.

2011-09-18 Thread Christoph Hellwig
On Sun, Sep 18, 2011 at 03:21:45PM -0400, F. Heitkamp wrote: Hi, First of all please accept my apologies for posting to this list on this particular topic, but it was the closest match I could find. I pulled the harddisk out of my ps3, because I have forgotten the root password on the

Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig

2014-03-23 Thread Christoph Hellwig
On Sun, Mar 23, 2014 at 02:04:46PM +1100, Benjamin Herrenschmidt wrote: diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 1594945..8122294 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -82,6 +82,7 @@ config ARM http://www.arm.linux.org.uk/. config

Re: [PATCH 08/15] powerpc/cell: Extract duplicated IOPTE_* to asm/iommu.h

2009-05-10 Thread Christoph Hellwig
On Fri, May 08, 2009 at 04:01:17PM +0200, Geert Uytterhoeven wrote: +/* Cell page table entries */ +#define IOPTE_PP_W 0x8000ul /* protection: write */ +#define IOPTE_PP_R 0x4000ul /* protection: read */ +#define IOPTE_M

[PATCH] powerpc: switch to asm-generic/hardirq.h

2009-08-05 Thread Christoph Hellwig
hardirq.h on powerpc defines a __last_jiffy_stamp field, but it's not actually used anywhere. Signed-off-by: Christoph Hellwig h...@lst.de Index: linux-2.6/arch/powerpc/include/asm/hardirq.h === --- linux-2.6.orig/arch/powerpc

Re: [PATCH 2/2] MAINTAINERS: ibmvfc driver maintainer change

2015-01-18 Thread Christoph Hellwig
Brian, can you ACK this one? ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: RFC: prepare for struct scatterlist entries without page backing

2015-08-13 Thread Christoph Hellwig
On Wed, Aug 12, 2015 at 03:42:47PM +0300, Boaz Harrosh wrote: The support I have suggested and submitted for zone-less sections. (In my add_persistent_memory() patchset) Would work perfectly well and transparent for all such multimedia cases. (All hacks removed). In fact I have loaded pmem

Re: [PATCH 29/31] parisc: handle page-less SG entries

2015-08-13 Thread Christoph Hellwig
On Wed, Aug 12, 2015 at 09:01:02AM -0700, Linus Torvalds wrote: I'm assuming that anybody who wants to use the page-less scatter-gather lists always does so on memory that isn't actually virtually mapped at all, or only does so on sane architectures that are cache coherent at a physical level,

Re: RFC: prepare for struct scatterlist entries without page backing

2015-08-13 Thread Christoph Hellwig
On Thu, Aug 13, 2015 at 09:37:37AM +1000, Julian Calaby wrote: I.e. ~90% of this patch set seems to be just mechanically dropping BUG_ON()s and converting open coded stuff to use accessor functions (which should be macros or get inlined, right?) - and the remaining bit is not flushing if we

[PATCH 4/5] dma-mapping: consolidate dma_supported

2015-08-13 Thread Christoph Hellwig
a problem if it's dma_set_mask implementation wasn't a similarly buggy noop. As a few architectures have much more elaborate implementations, we still allow for arch overrides. Signed-off-by: Christoph Hellwig h...@lst.de --- arch/alpha/include/asm/dma-mapping.h | 5 - arch/arm/include

[PATCH 3/5] dma-mapping: cosolidate dma_mapping_error

2015-08-13 Thread Christoph Hellwig
returns 0. Signed-off-by: Christoph Hellwig h...@lst.de --- arch/alpha/include/asm/dma-mapping.h | 5 - arch/arm/include/asm/dma-mapping.h| 9 - arch/arm64/include/asm/dma-mapping.h | 7 --- arch/h8300/include/asm/dma-mapping.h | 5 - arch/hexagon/include

Re: [PATCH 31/31] dma-mapping-common: skip kmemleak checks for page-less SG entries

2015-08-13 Thread Christoph Hellwig
On Wed, Aug 12, 2015 at 09:05:15AM -0700, Linus Torvalds wrote: [ Again, I'm responding to one random patch - this pattern was in other patches too. ] A question: do we actually expect to mix page-less and pageful SG entries in the same SG list? How does that happen? Both for DAX and

[PATCH 1/5] dma-mapping: consolidate dma_{alloc, free}_{attrs, coherent}

2015-08-13 Thread Christoph Hellwig
for that. Signed-off-by: Christoph Hellwig h...@lst.de --- arch/alpha/include/asm/dma-mapping.h | 18 -- arch/arm/include/asm/dma-mapping.h| 29 arch/arm/mm/dma-mapping.c | 11 -- arch/arm64/include/asm/dma-mapping.h | 33

[PATCH 5/5] dma-mapping: consolidate dma_set_mask

2015-08-13 Thread Christoph Hellwig
overload unrelated semantics like changing the dma_ops into it so we still need to allow for an architecture override for now. Signed-off-by: Christoph Hellwig h...@lst.de --- arch/alpha/include/asm/dma-mapping.h | 5 - arch/alpha/kernel/pci-noop.c | 10 -- arch/alpha

provide more common DMA API functions

2015-08-13 Thread Christoph Hellwig
Since 2009 we have a nice asm-generic header implementing lots of DMA API functions for architectures using struct dma_map_ops, but unfortunately it's still missing a lot of APIs that all architectures still have to duplicate. This series consolidates the remaining functions, although we still

[PATCH 2/5] dma-mapping: consolidate dma_{alloc,free}_noncoherent

2015-08-13 Thread Christoph Hellwig
-by: Christoph Hellwig h...@lst.de --- arch/alpha/include/asm/dma-mapping.h | 3 --- arch/arm/include/asm/dma-mapping.h| 15 --- arch/arm64/include/asm/dma-mapping.h | 14 -- arch/h8300/include/asm/dma-mapping.h | 3 --- arch/hexagon/include/asm/dma-mapping.h

Re: provide more common DMA API functions V2

2015-08-17 Thread Christoph Hellwig
On Mon, Aug 17, 2015 at 10:45:52PM -0700, Andrew Morton wrote: I'll merge these 5 patches for 4.3. That means I'll release them into linux-next after 4.2 is released. So you only add for-4.3 code to -next after 4.2 is odd? Isn't thast the wrong way around? Linus will be

Re: provide more common DMA API functions V2

2015-08-17 Thread Christoph Hellwig
On Mon, Aug 17, 2015 at 02:24:29PM -0700, Andrew Morton wrote: 110254 bytes saved, shrinking the kernel by a whopping 0.17%. Thoughts? Sounds fine to me. I'll merge these 5 patches for 4.3. That means I'll release them into linux-next after 4.2 is released. So you only add for-4.3 code

Re: provide more common DMA API functions V2

2015-08-19 Thread Christoph Hellwig
On Tue, Aug 18, 2015 at 09:51:07AM +0200, Ingo Molnar wrote: I.e. shouldn't this be: I'll merge these 5 patches for 4.4. That means I'll release them into linux-next after 4.2 is released. [...] Linus will be releasing 4.2 in 1-2 weeks and until then, linux-next is supposed

Re: [PATCH v3 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-17 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig h...@lst.de ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 2/5] dma-mapping: consolidate dma_{alloc,free}_noncoherent

2015-08-17 Thread Christoph Hellwig
-by: Christoph Hellwig h...@lst.de --- arch/alpha/include/asm/dma-mapping.h | 3 --- arch/arm/include/asm/dma-mapping.h| 21 ++--- arch/arm64/include/asm/dma-mapping.h | 14 -- arch/h8300/include/asm/dma-mapping.h | 3 --- arch/hexagon/include/asm/dma

[PATCH 1/5] dma-mapping: consolidate dma_{alloc, free}_{attrs, coherent}

2015-08-17 Thread Christoph Hellwig
for that. Signed-off-by: Christoph Hellwig h...@lst.de --- arch/alpha/include/asm/dma-mapping.h | 18 -- arch/arm/include/asm/dma-mapping.h| 29 arch/arm/mm/dma-mapping.c | 11 -- arch/arm64/include/asm/dma-mapping.h | 33

provide more common DMA API functions V2

2015-08-17 Thread Christoph Hellwig
Since 2009 we have a nice asm-generic header implementing lots of DMA API functions for architectures using struct dma_map_ops, but unfortunately it's still missing a lot of APIs that all architectures still have to duplicate. This series consolidates the remaining functions, although we still

[PATCH 5/5] dma-mapping: consolidate dma_set_mask

2015-08-17 Thread Christoph Hellwig
for an architecture override for now. Signed-off-by: Christoph Hellwig h...@lst.de --- arch/alpha/include/asm/dma-mapping.h | 5 - arch/alpha/kernel/pci-noop.c | 10 -- arch/alpha/kernel/pci_iommu.c | 11 --- arch/arm/include/asm/dma-mapping.h

[PATCH 4/5] dma-mapping: consolidate dma_supported

2015-08-17 Thread Christoph Hellwig
a problem if it's dma_set_mask implementation wasn't a similarly buggy noop. As a few architectures have much more elaborate implementations, we still allow for arch overrides. Signed-off-by: Christoph Hellwig h...@lst.de --- arch/alpha/include/asm/dma-mapping.h | 5 - arch/arm/include

[PATCH 3/5] dma-mapping: cosolidate dma_mapping_error

2015-08-17 Thread Christoph Hellwig
returns 0. Signed-off-by: Christoph Hellwig h...@lst.de --- arch/alpha/include/asm/dma-mapping.h | 5 - arch/arm/include/asm/dma-mapping.h| 9 - arch/arm64/include/asm/dma-mapping.h | 7 --- arch/h8300/include/asm/dma-mapping.h | 5 - arch/hexagon/include

  1   2   3   4   5   6   7   8   9   10   >