Re: [PATCH v0 1/2] DMA: fsldma: Disable DMA_INTERRUPT when Async_tx enabled

2009-10-15 Thread Dan Williams
[ added Leo and Timur to the Cc ] On Wed, Oct 14, 2009 at 11:41 PM, Vishnu Suresh vis...@freescale.com wrote: This patch disables the use of DMA_INTERRUPT capability with Async_tx The fsldma produces a null transfer with DMA_INTERRUPT capability when used with Async_tx. When RAID devices

Re: [PATCH v0 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-10-29 Thread Dan Williams
On Wed, Oct 14, 2009 at 11:41 PM, Vishnu Suresh vis...@freescale.com wrote: [..] diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index b08403d..343e578 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -192,6 +192,8 @@ config CRYPTO_DEV_TALITOS        select

Re: OOPS on MPC8548 board when writing RAID5 array

2009-11-12 Thread Dan Williams
Hi Hank, Thanks for testing. On Tue, Nov 10, 2009 at 4:44 AM, hank peng pengxi...@gmail.com wrote: CPU is MPC8548, kernel version is 2.6.31.5,CONFIG_FSL_DMA and CONFIG_ASYNC_TX_DMA options are all enabled. #mdadm -C /dev/md0 --assume-clean -l5 -n3 /dev/sd{a,b,c} #dd if=/dev/zero of=/dev/md0

Re: [PATCH] ppc440spe-adma: adds updated ppc440spe adma driver

2009-11-23 Thread Dan Williams
Anatolij Gustschin wrote: This patch adds new version of the PPC440SPe ADMA driver. Signed-off-by: Anatolij Gustschin ag...@denx.de As Josh said please don't drop attribution tags. If you borrowed from Yuri's implementation you can forward his signed-off-by. --- Before applying this

Re: [PATCH v2] ppc440spe-adma: adds updated ppc440spe adma driver

2009-11-30 Thread Dan Williams
Anatolij Gustschin wrote: This patch adds new version of the PPC440SPe ADMA driver. Signed-off-by: Anatolij Gustschin ag...@denx.de Signed-off-by: Yuri Tikhonov y...@emcraft.com [minor] Sign-offs are typically in delivery path order, so yours would appear last. [..]

Re: [PATCH v3] ppc440spe-adma: adds updated ppc440spe adma driver

2009-12-10 Thread Dan Williams
Anatolij Gustschin wrote: This patch adds new version of the PPC440SPe ADMA driver. Signed-off-by: Yuri Tikhonov y...@emcraft.com Signed-off-by: Anatolij Gustschin ag...@denx.de --- Changes since v2: - Correct Sign-offs order. - Place the driver in 'drivers/dma/ppc4xx' directory as there

Re: [PATCH v0] Crypto: Talitos: re-initialize async_tx descriptors

2009-12-14 Thread Dan Williams
On Mon, Dec 14, 2009 at 6:33 AM, Vishnu Suresh vis...@freescale.com wrote: The async_tx descriptors contains dangling pointers. Hence, re-initialize them to NULL before use. Signed-off-by: Vishnu Suresh vis...@freescale.com --- o. Rebased to linux-next as of 20091214  

Re: [PATCH v0] Crypto: Talitos: re-initialize async_tx descriptors

2009-12-15 Thread Dan Williams
Suresh Vishnu-B05022 wrote: On Mon, Dec 14, 2009 at 6:33 AM, Vishnu Suresh vis...@freescale.com wrote: The async_tx descriptors contains dangling pointers. Hence, re-initialize them to NULL before use. Signed-off-by: Vishnu Suresh vis...@freescale.com --- o. Rebased to

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-16 Thread Dan Williams
Kumar Gala wrote: Changes with respect to v1 as per comments received o. Rebased to linux-next as of 20091216 o. The selection is based exclusive of fsldma o. Intoduced a new Kernel Configuration variable *. This enables selecting the Cryptographic functionality of Talitos along with

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-17 Thread Dan Williams
Ira W. Snyder wrote: Yes, I have used the device_prep_dma_interrupt() functionality quite a while back. However, I found it to be pretty much useless. The specific case it is needed for Talitos/raid is a channel switch interrupt. The interrupt causes the cleanup operation to be run which

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-17 Thread Dan Williams
On Thu, Dec 17, 2009 at 11:45 AM, Kumar Gala ga...@kernel.crashing.org wrote: The specific case it is needed for Talitos/raid is a channel switch interrupt.  The interrupt causes the cleanup operation to be run which will kick off any pending dependent operations on the xor channel.  In the

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-18 Thread Dan Williams
On Fri, Dec 18, 2009 at 8:02 AM, Li Yang-R58472 r58...@freescale.com wrote: Subject: Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload Ira W. Snyder wrote: Yes, I have used the device_prep_dma_interrupt() functionality quite a while back. However, I found it to be pretty

Re: [PATCH] fsldma: use PCI Read Multiple command

2009-04-27 Thread Dan Williams
On Mon, Apr 27, 2009 at 1:47 PM, Timur Tabi ti...@freescale.com wrote: Adding Kumar to the CC: list, since he might pick up the patch. Acked-by: Dan Williams dan.j.willi...@intel.com I agree with taking this through Kumar's tree. ___ Linuxppc-dev

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine

2008-03-11 Thread Dan Williams
On Thu, 2008-03-06 at 16:39 -0700, Olof Johansson wrote: pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine First cut at a dma copy offload driver for PA Semi PWRficient. It uses the platform-specific functions to allocate channels, etc. Signed-off-by: Olof Johansson [EMAIL

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

2008-03-11 Thread Dan Williams
On Tue, 2008-03-11 at 10:53 -0700, Andrew Morton wrote: On Tue, 11 Mar 2008 09:25:45 -0500 Olof Johansson [EMAIL PROTECTED] wrote: On Tue, Mar 11, 2008 at 12:06:19AM -0700, Andrew Morton wrote: On Thu, 6 Mar 2008 17:39:00 -0600 Olof Johansson [EMAIL PROTECTED] wrote:

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

2008-03-11 Thread Dan Williams
On Tue, 2008-03-11 at 11:29 -0700, Kumar Gala wrote: My fault for not pushing out this cleanup to the old url while the git-md-accel changeover was pending. Any reason not to push Zhang's fixes for 2.6.25? I plan to push these fixes for 2.6.25. Olof had some valid comments about Fix

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine

2008-03-13 Thread Dan Williams
On Thu, Mar 13, 2008 at 12:54 PM, Olof Johansson [EMAIL PROTECTED] wrote: On Tue, Mar 11, 2008 at 10:04:11AM -0700, Dan Williams wrote: I notice that the driver does not handle callbacks in its descriptor cleanup path. This could be ok if your intent is only to support the net_dma

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine

2008-03-13 Thread Dan Williams
On Thu, Mar 13, 2008 at 4:14 PM, Olof Johansson [EMAIL PROTECTED] wrote: Dummy descriptors that do nothing but cause an interrupt is the intent. Well, it'd be slightly more efficient to do add the interrupt attribute to the last issued descriptor when it's known in advance. If the

Re: [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

2008-03-17 Thread Dan Williams
Acked-by: Dan Williams [EMAIL PROTECTED] --- /dev/null +++ b/drivers/dma/pasemi_dma.c [..] +static void pasemi_dma_clean(struct pasemi_dma_chan *chan) +{ + int old, new, i; + struct pasemi_dma_desc *desc; + dma_async_tx_callback callback; + +restart

Re: [PATCH] fsldma: The MPC8377MDS board device tree node for fsldma driver

2008-03-27 Thread Dan Williams
On Wed, Mar 26, 2008 at 12:42 AM, Zhang Wei [EMAIL PROTECTED] wrote: The fsldma driver is tested on MPC8377MDS board. The patch adds fsldma driver support into MPC8377MDS device tree. Signed-off-by: Zhang Wei [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8377_mds.dts | 27

Re: [PATCH] [POWERPC] fsldma: Use compatiable binding as spec

2008-03-31 Thread Dan Williams
-by: Kumar Gala [EMAIL PROTECTED] --- Dan, if you don't have any issue with this I'll sent it via the powerpc tree (since its not really about functionality). Acked-by: Dan Williams [EMAIL PROTECTED] ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH 3/4] Extend the DMA-engine API.

2007-07-10 Thread Dan Williams
On 7/10/07, Zhang Wei [EMAIL PROTECTED] wrote: Add channel wait queue and transfer callback dma_xfer_callback(). If the DMA controller and driver support interrupt, when the transfer is finished, it will wakeup the wait queue and call the callback function of the channel. Add

Re: [PATCH 3/4] Extend the DMA-engine API.

2007-07-11 Thread Dan Williams
On 7/11/07, Zhang Wei-r63237 [EMAIL PROTECTED] wrote: Hi, Dan, Do you mention here: http://marc.info/?l=linux-raidm=118290909614463w=2 ? I see the async_tx is located at crypto/ of the above page, but my patch is for DMA engine in drivers/dma and for DMA engine driver. Thanks! Wei. Hi

Re: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

2007-09-09 Thread Dan Williams
On 9/9/07, Timur Tabi [EMAIL PROTECTED] wrote: Dan Williams wrote: This routine implies that there is a piece of code somewhere that wants to select which channels it can use. A similar effect can be achieved by registering a dma_client with the dmaengine interface

Re: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xxprocessors.

2007-09-13 Thread Dan Williams
On 9/13/07, Zhang Wei-r63237 [EMAIL PROTECTED] wrote: Hi, +static void fsl_dma_set_src(dma_addr_t addr, + struct dma_async_tx_descriptor *tx, int index) +{ What is index supposed to mean? It's not used, or documented anywhere than I can see. I've

Re: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

2007-09-13 Thread Dan Williams
Hi, Dan, Does I have followed your new API? :-) [..] +static struct dma_chan *of_find_dma_chan_by_phandle(phandle phandle) +{ + struct device_node *np; + struct dma_chan *chan; + struct fsl_dma_device *fdev; + + np =

Re: [PATCH 8/8] fsldma: major cleanups and fixes

2010-02-02 Thread Dan Williams
Ira W. Snyder wrote: In the fsldma driver, all callbacks are run from tasklet (softirq) context. That's under local_irq_disable(), right? Hardirq's certainly aren't disabled there. Actually, my mistake, the cleanup routine does spin_lock_irqsave(), but I now see that it drops the lock across

Re: [async_tx-next PATCH v2 2/2] fsldma: Fix cookie issues

2010-02-28 Thread Dan Williams
On Thu, Feb 25, 2010 at 12:39 PM, Steven J. Magnani st...@digidescorp.com wrote: fsl_dma_update_completed_cookie() appears to calculate the last completed cookie incorrectly in the corner case where DMA on cookie 1 is in progress just following a cookie wrap. Signed-off-by: Steven J. Magnani

Re: [PATCH v3 06/11] dma: Add MPC512x DMA driver

2010-03-01 Thread Dan Williams
Anatolij Gustschin wrote: Hi Dan, any chance this patch could be merged for 2.6.34 ? Looks good to me, I'll include it in the dmaengine pull request. -- Dan ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [patch 1/1] fsldma: the MPC8377MDS board device tree node for fsldma driver

2008-05-14 Thread Dan Williams
. Signed-off-by: Zhang Wei [EMAIL PROTECTED] Cc: Nelson, Shannon [EMAIL PROTECTED] Cc: Dan Williams [EMAIL PROTECTED] Cc: Kumar Gala [EMAIL PROTECTED] Cc: Paul Mackerras [EMAIL PROTECTED] Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED

Re: [PATCH] fsldma: remove internal self-test from Freescale Elo DMA driver

2008-09-24 Thread Dan Williams
On Tue, Sep 23, 2008 at 1:29 PM, Timur Tabi [EMAIL PROTECTED] wrote: The Freescale Elo DMA driver runs an internal self-test before registering the channels with the DMA engine. This self-test has a fundemental flaw in that it calls the DMA engine's callback functions directly before the

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-27 Thread Dan Williams
On Wed, Sep 24, 2008 at 2:59 PM, Timur Tabi [EMAIL PROTECTED] wrote: Modify the Freescale Elo / Elo Plus DMA driver so that it can be compiled as a module. The primary change is to stop treating the DMA controller as a bus, and the DMA channels as devices on the bus. This is because the Open

Re: [PATCH] Adding ADMA support for PPC460EX DMA engine.

2010-07-23 Thread Dan Williams
On Thu, Jul 22, 2010 at 11:15 PM, Stefan Roese s...@denx.de wrote: Hi Marri, On Friday 23 July 2010 02:57:18 tma...@amcc.com wrote: From: Tirumala Marri tma...@amcc.com   This patch will add ADMA support for DMA engine and HW offload for   XOR/ADG (RAID-5/6) functionalities.   1. It

Re: [PATCH 2/2] PPC4xx: Merge xor.h and dma.h into onefile ppc440spe-dma.h

2010-09-23 Thread Dan Williams
On Fri, Sep 17, 2010 at 6:42 PM, tma...@apm.com wrote: From: Tirumala Marri tma...@apm.com This patch combines drivers/dma/ppc4xx/xor.h and driver/dma/dma/ppc4xx/dma.h into drivers/dma/ppc4xx/ppx440spe-dma.h . Is this just code churn, or do we gain anything by combining these header files?

Re: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c

2010-09-23 Thread Dan Williams
On 9/17/2010 6:42 PM, tma...@apm.com wrote: From: Tirumala Marritma...@apm.com This patch generalizes the existing drver/dma/ppc4xx/adma.c, so that common code can be shared between different similar DMA engine drivers in other SoCs. Signed-off-by: Tirumala R Marritma...@apm.com ---

Re: [PATCH] fsldma: add support to 36-bit physical address

2010-09-23 Thread Dan Williams
On Tue, Sep 21, 2010 at 10:41 PM, Kumar Gala ga...@kernel.crashing.org wrote: On Sep 21, 2010, at 5:34 PM, Timur Tabi wrote: On Tue, Sep 21, 2010 at 5:17 PM, Scott Wood scottw...@freescale.com wrote: It needs to be the actual device that is performing the DMA -- the platform may need to do

Re: [PATCH v1 1/4] PPC4xx: Generalizing ADMA driver modifications

2010-09-23 Thread Dan Williams
On 9/23/2010 3:10 PM, tma...@apm.com wrote: From: Tirumala Marritma...@apm.com This patch generalizes the existing drver/dma/ppc4xx/adma.c, so that common code can be shared between different similar DMA engine drivers in other SoCs. Also Makefile and Kconfig changed to accommodate PPC4XX.

Re: [PATCH v1 3/4] PPC4xx: New file with SoC specific functions

2010-09-23 Thread Dan Williams
On 9/23/2010 3:11 PM, tma...@apm.com wrote: From: Tirumala Marritma...@apm.com This patch creates new file with SoC dependent functions. Signed-off-by: Tirumala R Marritma...@apm.com --- V1: * Remove all 440SPe specific references. Maybe it renames ppc440spe to ppc4xx but it adds things

Re: [PATCH v1 1/4] PPC4xx: Generalizing ADMA driver modifications

2010-09-23 Thread Dan Williams
On 9/23/2010 3:44 PM, Tirumala Marri wrote: Did you look at this changelog before sending? It just deletes 4000 lines of code?? [Marri] The reason I have to send it in different file is the size of the patch. There seem to be issue with patch sizes 200k or more. Read the rest of what I

Re: [PATCH RFCv1 1/2] dmaengine: add support for scatterlist to scatterlist transfers

2010-09-24 Thread Dan Williams
On Fri, Sep 24, 2010 at 12:46 PM, Ira W. Snyder i...@ovro.caltech.edu wrote: This adds support for scatterlist to scatterlist DMA transfers. As requested by Dan, this is hidden behind an ifdef so that it can be selected by the drivers that need it. Signed-off-by: Ira W. Snyder

Re: [PATCH RFCv1 1/2] dmaengine: add support for scatterlist to scatterlist transfers

2010-09-24 Thread Dan Williams
On Fri, 2010-09-24 at 14:24 -0700, Ira W. Snyder wrote: On Fri, Sep 24, 2010 at 01:40:56PM -0700, Dan Williams wrote: I don't think any dma channels gracefully handle descriptors that were prepped but not submitted. You would probably need to submit the backlog, poll for completion

Re: [PATCH RFCv1 1/2] dmaengine: add support for scatterlist to scatterlist transfers

2010-09-24 Thread Dan Williams
On Fri, 2010-09-24 at 15:04 -0700, Ira W. Snyder wrote: On Fri, Sep 24, 2010 at 02:53:14PM -0700, Dan Williams wrote: What about overrun or underrun do we not care if src_total != dst_total? Otherwise looks ok. I don't know if we should care about that. The algorithm handles

Re: [PATCH RFCv2 1/2] dmaengine: add support for scatterlist to scatterlist transfers

2010-09-27 Thread Dan Williams
On Mon, Sep 27, 2010 at 10:23 AM, Ira W. Snyder i...@ovro.caltech.edu wrote: On Mon, Sep 27, 2010 at 05:23:34PM +0200, Linus Walleij wrote: 2010/9/25 Ira W. Snyder i...@ovro.caltech.edu: This adds support for scatterlist to scatterlist DMA transfers. This is a good idea, we have a local

Re: [PATCH 4/4] ste_dma40: implement support for scatterlist to scatterlist copy

2010-09-29 Thread Dan Williams
On Mon, Sep 27, 2010 at 3:57 PM, Ira W. Snyder i...@ovro.caltech.edu wrote: Now that the DMAEngine API has support for scatterlist to scatterlist copy, implement support for the STE DMA40 DMA controller. Cc: Linus Walleij linus.ml.wall...@gmail.com Cc: Per Fridén per.fri...@stericsson.com

Re: [PATCH 3/4] fsldma: remove DMA_SLAVE support

2010-09-29 Thread Dan Williams
On Mon, Sep 27, 2010 at 3:57 PM, Ira W. Snyder i...@ovro.caltech.edu wrote: Now that the generic DMAEngine API has support for scatterlist to scatterlist copying, this implementation of the DMA_SLAVE API is no longer necessary. In order to let device_control() continue to function, a stub

Re: [PATCH] PPC4xx: ADMA separating SoC specific functions

2010-09-30 Thread Dan Williams
On Thu, Sep 30, 2010 at 12:08 PM, Wolfgang Denk w...@denx.de wrote: [snip other valid review comments] This is a header file, yet you add here literally thousands of lines of code. Yes, these functions are entirely too large to be inlined. It looks like you are trying to borrow too heavily

Re: [PATCH] PPC4xx: ADMA separating SoC specific functions

2010-09-30 Thread Dan Williams
[ adding Greg ] On Thu, Sep 30, 2010 at 5:16 PM, Tirumala Marri tma...@apm.com wrote: Where  iop_adma_alloc_slots() is implemented differently between iop13xx and iop3xx.  In this case why does ppc440spe-adma.h exist?  If it has code specific to ppe440spe it should just live in the ppe440spe

Re: powerpc allmodconfig

2008-10-16 Thread Dan Williams
. So I'll do it myself later tonight. :-/ The following seems to fix this up... ---snip--- ixgbe, myri10ge: INTEL_IOATDMA can only be selected when X86=y From: Dan Williams [EMAIL PROTECTED] The INTEL_IOATDMA symbol depends on x86. 'select' ignores this dependency. Cc: Brice Goglin [EMAIL

Re: [PATCH 02/11] async_tx: add support for asynchronous GF multiplication

2008-11-14 Thread Dan Williams
On Thu, Nov 13, 2008 at 8:15 AM, Ilya Yanok [EMAIL PROTECTED] wrote: This adds support for doing asynchronous GF multiplication by adding four additional functions to async_tx API: async_pqxor() does simultaneous XOR of sources and XOR of sources GF-multiplied by given coefficients.

Re: Re[2]: [PATCH 02/11] async_tx: add support for asynchronous GF multiplication

2008-11-28 Thread Dan Williams
On Wed, Nov 26, 2008 at 6:26 PM, Yuri Tikhonov [EMAIL PROTECTED] wrote: 3/ In my implementation (unfinished) of async_pq I decided to make the prototype: May I ask do you have in plans to finish and release your implementation? Seems that time would be better spent reviewing / finalizing

Re: [PATCH] ASYNC_TX: async_xor mapping fix

2008-12-08 Thread Dan Williams
On Mon, 2008-12-08 at 12:14 -0700, Yuri Tikhonov wrote: The destination address may be present in the source list, so we should map the addresses from the source list first. Otherwise, if page corresponding to destination is not marked as write- through (with regards to CPU cache), then

Re: [PATCH 01/11] async_tx: don't use src_list argument of async_xor() for dma addresses

2008-12-08 Thread Dan Williams
On Mon, Dec 8, 2008 at 2:55 PM, Yuri Tikhonov [EMAIL PROTECTED] wrote: Using src_list argument of async_xor() as a storage for dma addresses implies sizeof(dma_addr_t) = sizeof(struct page *) restriction which is not always true (e.g. ppc440spe). ppc440spe runs with CONFIG_PHYS_64BIT? If we

Re: Re[2]: [PATCH 01/11] async_tx: don't use src_list argument of async_xor() for dma addresses

2008-12-09 Thread Dan Williams
On Mon, Dec 8, 2008 at 5:41 PM, Yuri Tikhonov [EMAIL PROTECTED] wrote: On Tuesday, December 9, 2008 you wrote: On Mon, Dec 8, 2008 at 2:55 PM, Yuri Tikhonov [EMAIL PROTECTED] wrote: Using src_list argument of async_xor() as a storage for dma addresses implies sizeof(dma_addr_t) =

Re: [PATCH] ASYNC_TX: async_xor mapping fix

2008-12-10 Thread Dan Williams
On Mon, 2008-12-08 at 14:08 -0700, Dan Williams wrote: On Mon, 2008-12-08 at 12:14 -0700, Yuri Tikhonov wrote: The destination address may be present in the source list, so we should map the addresses from the source list first. Otherwise, if page corresponding to destination is not marked

Re: [PATCH 02/11][v2] async_tx: add support for asynchronous GF multiplication

2008-12-17 Thread Dan Williams
Hi Yuri, On Mon, Dec 8, 2008 at 2:55 PM, Yuri Tikhonov y...@emcraft.com wrote: This adds support for doing asynchronous GF multiplication by adding four additional functions to async_tx API: async_pq() does simultaneous XOR of sources and XOR of sources GF-multiplied by given coefficients.

Re: [PATCH 02/11][v3] async_tx: add support for asynchronous GF multiplication

2009-01-14 Thread Dan Williams
-XOR calculations ASYNC_TX API. + * + * based on async_xor.c code written by: + * Dan Williams dan.j.willi...@intel.com + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the Free

Re: [PATCH 03/11][v3] async_tx: add support for asynchronous RAID6 recovery operations

2009-01-14 Thread Dan Williams
On Mon, Jan 12, 2009 at 5:43 PM, Yuri Tikhonov y...@emcraft.com wrote: + /* (2) Calculate Q+Qxy */ + lptrs[0] = ptrs[failb]; + lptrs[1] = ptrs[disks-1]; + lptrs[2] = NULL; + tx = async_pq(lptrs, NULL, 0, 1, bytes, ASYNC_TX_DEP_ACK, + tx,

Re: [PATCH] fsldma: print correct IRQ on mpc83xx

2009-01-14 Thread Dan Williams
Timur Tabi wrote: Peter Korsgaard wrote: The only minor issues we have is the cosmetic problem of the driver printing NO_IRQ (E.G. this patch), and the driver calling free_irq(NO_IRQ) (E.G. the other patch I sent today) in the release path. Ok, I understand. ACK on the patches. Ok, Li

Re: [PATCH 07/11] md: rewrite handle_stripe_dirtying6 in asynchronous way

2009-01-15 Thread Dan Williams
On Mon, Dec 8, 2008 at 2:57 PM, Yuri Tikhonov y...@emcraft.com wrote: Rewrite handle_stripe_dirtying6 function to work asynchronously. Signed-off-by: Yuri Tikhonov y...@emcraft.com Signed-off-by: Ilya Yanok ya...@emcraft.com --- drivers/md/raid5.c | 113

Re: Re[2]: [PATCH 02/11][v3] async_tx: add support for asynchronous GF multiplication

2009-01-16 Thread Dan Williams
On Fri, Jan 16, 2009 at 4:41 AM, Yuri Tikhonov y...@emcraft.com wrote: I don't think this will work as we will be mixing Q into the new P and P into the new Q. In order to support (src_cnt device-max_pq) we need to explicitly tell the driver that the operation is being continued

Re: Re[2]: [PATCH 03/11][v3] async_tx: add support for asynchronous RAID6 recovery operations

2009-01-16 Thread Dan Williams
On Fri, Jan 16, 2009 at 4:51 AM, Yuri Tikhonov y...@emcraft.com wrote: The reason why I preferred to use async_pq() instead of async_xor() here is to maximize the chance that the whole D+D recovery operation will be handled in one ADMA device, i.e. without channels switch and the latency

Re: Re[2]: [PATCH 07/11] md: rewrite handle_stripe_dirtying6 in asynchronous way

2009-01-16 Thread Dan Williams
On Fri, Jan 16, 2009 at 7:24 AM, Yuri Tikhonov y...@emcraft.com wrote: Ok, I now see why this change was made. Please make this changelog more descriptive than Rewrite handle_stripe_dirtying6 function to work asynchronously. Sure, how about the following: md: rewrite

Re: [PATCH 3/4] fsl-dma: support attribute of DMA_MEMORY when async_tx enabled

2012-07-10 Thread Dan Williams
check whether this depend tx descriptor is acked, there are poison contents in the invalid address, then BUG_ON() is thrown, so this descriptor will be freed in the next time. Cc: Dan Williams dan.j.willi...@intel.com Cc: Vinod Koul vinod.k...@intel.com Cc: Li Yang le...@freescale.com Signed

Re: [PATCH v7 0/8] Raid: enable talitos xor offload for improving performance

2012-08-14 Thread Dan Williams
On Tue, Aug 14, 2012 at 2:04 AM, Liu Qiang-B32616 b32...@freescale.com wrote: Hi Vinod, Would you like to apply this series from patch 2/8 to 7/8) in your tree? The link as below, http://patchwork.ozlabs.org/patch/176023/ http://patchwork.ozlabs.org/patch/176024/

Re: [PATCH 00/12] dma: various minor clean ups for slave drivers

2013-05-31 Thread Dan Williams
On Thu, May 30, 2013 at 10:47 AM, Vinod Koul vinod.k...@intel.com wrote: On Mon, May 27, 2013 at 03:14:30PM +0300, Andy Shevchenko wrote: Here is a set of small independent patches that clean up or fix minor things across DMA slave drivers. The series looks fine. I am going to wait a day more

Re: [PATCH] fix dmaengine_unmap failure.

2014-03-18 Thread Dan Williams
On Tue, Mar 18, 2014 at 1:32 AM, xuelin@freescale.com wrote: From: Xuelin Shi xuelin@freescale.com The count which is used to get_unmap_data maybe not the same as the count computed in dmaengine_unmap which causes to free data in a wrong pool. This patch fixes this issue by keeping

Re: [PATCH] fix dmaengine_unmap failure.

2014-03-19 Thread Dan Williams
On Tue, Mar 18, 2014 at 11:39 PM, Xuelin Shi xuelin@freescale.com wrote: Hi Dan, In async_mult(...) of async_raid6_recov.c, the count 3 is used to request an unmap. However the to_cnt and bidi_cnt are both set to 1 and from_cnt to 0. Then while trying to do unmap, we are getting the

Re: [PATCH v2] fix wrong usage of dmaengine_unmap_put in async_xxx

2014-04-09 Thread Dan Williams
On Thu, Mar 20, 2014 at 1:16 AM, xuelin@freescale.com wrote: From: Xuelin Shi xuelin@freescale.com dmaengine_unmap_put does below two things: a) unmap pages for srcs and dests b) free unmap struct The unmap struct data is generated but only initialized while other some dma

Re: [PATCH v2] fix dmaengine_unmap failure

2014-04-09 Thread Dan Williams
On Wed, Mar 19, 2014 at 11:33 PM, xuelin@freescale.com wrote: From: Xuelin Shi xuelin@freescale.com The count which is used to get_unmap_data maybe not the same as the count computed in dmaengine_unmap which causes to free data in a wrong pool. This patch fixes this issue by

Re: [PATCH v3] dmaengine: driver support for FSL RaidEngine device.

2014-04-11 Thread Dan Williams
A few more comments: On Fri, Apr 11, 2014 at 12:41 AM, xuelin@freescale.com wrote: From: Xuelin Shi xuelin@freescale.com The RaidEngine is a new FSL hardware used for Raid5/6 acceration. This patch enables the RaidEngine functionality and provides hardware offloading capability for

Re: [PATCH v3] dmaengine: driver support for FSL RaidEngine device.

2014-04-11 Thread Dan Williams
On Fri, Apr 11, 2014 at 10:42 AM, Dan Williams dan.j.willi...@intel.com wrote: A few more comments: On Fri, Apr 11, 2014 at 12:41 AM, xuelin@freescale.com wrote: From: Xuelin Shi xuelin@freescale.com The RaidEngine is a new FSL hardware used for Raid5/6 acceration. This patch

Re: [PATCH v3] dmaengine: driver support for FSL RaidEngine device.

2014-04-14 Thread Dan Williams
On Sun, Apr 13, 2014 at 7:48 PM, Xuelin Shi xuelin@freescale.com wrote: Hi Dan, fsl dma device and fsl raid device are two differenct devices that both provide async_memcpy capability, so I use !FSL_DMA to disable the fsl dma device. That's to say, either select fsldma device, either

Re: [PATCH v11 3/3] DMA: Freescale: update driver to support 8-channel DMA engine

2013-11-07 Thread Dan Williams
On Mon, Nov 4, 2013 at 6:31 PM, Hongbo Zhang hongbo.zh...@freescale.com wrote: Hi Vinod Koul and Dan Williams, Ping? Not much to review from the dmaengine side, just one question below. It would be helpful if you can send these to the new dmaengine patchwork at dmaeng...@vger.kernel.org

Re: [PATCH v11 3/3] DMA: Freescale: update driver to support 8-channel DMA engine

2013-11-11 Thread Dan Williams
On Mon, Nov 11, 2013 at 1:12 AM, Hongbo Zhang hongbo.zh...@freescale.com wrote: diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 49e8fbd..16a9a48 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1261,7 +1261,9 @@ static int fsl_dma_chan_probe(struct

Re: [PATCH] fsldma: fix issue of slow dma

2010-12-13 Thread Dan Williams
On Thu, Dec 9, 2010 at 12:14 AM, Li Yang le...@freescale.com wrote: From: Forrest Shi b29...@freescale.com Fixed fsl dma slow issue by initializing dma mode register with bandwidth control. It boosts dma performance and should works with 85xx board. Signed-off-by: Forrest Shi

Re: [PATCH v3 7/9] fsldma: support async_tx dependencies and automatic unmapping

2011-03-03 Thread Dan Williams
On Thu, Mar 3, 2011 at 9:54 AM, Ira W. Snyder i...@ovro.caltech.edu wrote: Previous to this patch, the dma_run_dependencies() function has been called while holding desc_lock. This function can call tx_submit() for other descriptors, which may try to re-grab the lock. Avoid this by moving the

Re: [PATCH v3 3/9] fsldma: use channel name in printk output

2011-03-21 Thread Dan Williams
On Thu, Mar 3, 2011 at 9:54 AM, Ira W. Snyder i...@ovro.caltech.edu wrote: This makes debugging the driver much easier when multiple channels are running concurrently. In addition, you can see how much descriptor memory each channel has allocated via the dmapool API in sysfs. Signed-off-by:

Re: [PATCH v7 0/8] Raid: enable talitos xor offload for improving performance

2012-08-29 Thread Dan Williams
On Wed, 2012-08-29 at 11:15 +, Liu Qiang-B32616 wrote: Hi Dan, Ping? Can you apply these patches? Thanks. I'm working my way through them. The first thing I notice is that xor_chan-desc_lock is taken inconsistently. I.e. spin_lock_irqsave() in talitos_process_pending() and

Re: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-02 Thread Dan Williams
On Thu, Aug 30, 2012 at 7:23 AM, Geanta Neag Horia Ioan-B05471 b05...@freescale.com wrote: Besides these: 1. As Dan Williams mentioned, you should explain why you are using both spin_lock_bh and spin_lock_irqsave on the same lock. It looks like talitos_process_pending() can be called from

Re: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-02 Thread Dan Williams
On Thu, Aug 9, 2012 at 1:20 AM, qiang@freescale.com wrote: From: Qiang Liu qiang@freescale.com Expose Talitos's XOR functionality to be used for RAID parity calculation via the Async_tx layer. Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net

Re: [PATCH v7 6/8] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-09-02 Thread Dan Williams
On Thu, Aug 9, 2012 at 1:23 AM, qiang@freescale.com wrote: From: Qiang Liu qiang@freescale.com The use of spin_lock_irqsave() is a stronger locking mechanism than is required throughout the driver. The minimum locking required should be used instead. Interrupts will be turned off and

Re: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-04 Thread Dan Williams
On Tue, Sep 4, 2012 at 5:28 AM, Liu Qiang-B32616 b32...@freescale.com wrote: Will this engine be coordinating with another to handle memory copies? The dma mapping code for async_tx/raid is broken when dma mapping requests overlap or cross dma device boundaries [1]. [1]:

Re: [PATCH] fsldma: Fix compile warnings

2009-05-13 Thread Dan Williams
: warning: cast to pointer from integer of different Signed-off-by: Kumar Gala ga...@kernel.crashing.org Acked-by: Dan Williams dan.j.willi...@intel.com I'm fine with this going through your tree. Thanks, Dan ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [RFC] Using the DMAEngine API for scatter/gather operations

2009-05-14 Thread Dan Williams
On Thu, 2009-05-14 at 09:13 -0700, Ira Snyder wrote: Hello all. I'm working on a driver for a custom board (based heavily on the MPC8349EMDS board) to dump data out of onboard FPGA's. I need to use the onboard DMA controller for this, mostly due to data transfer rate and timing

Re: [GIT PULL] fsldma driver fixes

2009-05-26 Thread Dan Williams
On Fri, May 22, 2009 at 3:47 AM, Li Yang le...@freescale.com wrote: Hi Dan, Here are fixes for Freescale DMA engine driver. Thanks, - Leo The following changes since commit 5805977e63a36ad56594a623f3bd2bebcb7db233:  Linus Torvalds (1):        Merge branch 'for-linus' of

[git pull] dmaengine fixes for 2.6.30-rc8

2009-05-29 Thread Dan Williams
...@kernel.crashing.org Signed-off-by: Dan Williams dan.j.willi...@intel.com commit 2e077f8e8337e52eef3c39c24c31e103b11a0326 Author: Ira Snyder i...@ovro.caltech.edu Date: Fri May 15 09:59:46 2009 -0700 fsldma: fix memory leak on error path in fsl_dma_prep_memcpy() When preparing a memcpy

Re: [PATCH] fsldma: use PCI Read Multiple command

2009-06-12 Thread Dan Williams
Kumar Gala wrote: On Jun 12, 2009, at 4:23 AM, Li Yang wrote: On Thu, Jun 11, 2009 at 11:17 PM, Ira Snyderi...@ovro.caltech.edu wrote: On Wed, Jun 10, 2009 at 09:45:26PM -0500, Kumar Gala wrote: On Apr 27, 2009, at 3:49 PM, Dan Williams wrote: On Mon, Apr 27, 2009 at 1:47 PM, Timur Tabi

Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-16 Thread Dan Williams
for review. Correct functioning of this patch depends on the patches submitted earlier. As suggested by Dan Williams, I implemented DMA_SLAVE support for the fsldma controller to allow me to use the hardware to transfer to/from a scatterlist to a list of hardware address/length pairs. I implemented

Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-17 Thread Dan Williams
Ira Snyder wrote: Using EXPORT_SYMBOL would defeat the purpose of conforming to the dmaengine api which should allow other subsystems to generically discover an fsldma resource. Any driver would still use dma_request_channel(), etc. to get access to a DMA channel. AFAICT, DMA_SLAVE is

Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-18 Thread Dan Williams
Ira Snyder wrote: I can do something similar by calling device_prep_dma_memcpy() lots of times. Once for each page in the scatterlist. This has the advantage of not changing the DMAEngine API. This has the disadvantage of not being a single transaction. The DMA controller will get an interrupt

Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-18 Thread Dan Williams
Ira Snyder wrote: So, I see a couple of ways of moving forward: 1) Keep my implementation, moving the includes to arch/powerpc/include. Do we drop the allocation functions? +1 for option 1. Having it under arch/powerpc/include makes it clear that it is a powerpc specific api, so keep the

Re: [PATCH v3 2/2] fsldma: Add DMA_SLAVE support

2009-06-22 Thread Dan Williams
patch. After discussion with Dan Williams, this is the third version of the DMA_SLAVE API for the Freescale DMA controller. I've tested it heavily with both drivers I have written against this API, an FPGA programmer and an FPGA data grabber. Kumar, Dan asked me to add you to the CC list

Re: [PATCH v3 2/2] fsldma: Add DMA_SLAVE support

2009-06-22 Thread Dan Williams
On Mon, 2009-06-22 at 14:20 -0700, Dan Williams wrote: On Fri, 2009-06-19 at 12:31 -0700, Ira Snyder wrote: Use the DMA_SLAVE capability of the DMAEngine API to copy/from a scatterlist into an arbitrary list of hardware address/length pairs. This allows a single DMA transaction to copy

Re: [PATCH v3 2/2] fsldma: Add DMA_SLAVE support

2009-06-23 Thread Dan Williams
Kumar Gala wrote: Kumar, Leo, Can I get your acked-by's for the current state of async_tx.git/ next? I just pushed out Ira's latest so it may take a moment to mirror out. Acked-by: Li Yang le...@freescale.com However, the addition of arch/powerpc/include/asm/fsldma.h still needs the ack

Re: [PATCH v3 2/2] fsldma: Add DMA_SLAVE support

2009-06-24 Thread Dan Williams
Dan Williams wrote: Kumar Gala wrote: Kumar, Leo, Can I get your acked-by's for the current state of async_tx.git/ next? I just pushed out Ira's latest so it may take a moment to mirror out. Acked-by: Li Yang le...@freescale.com However, the addition of arch/powerpc/include/asm/fsldma.h

Re: [PATCH v3 2/2] fsldma: Add DMA_SLAVE support

2009-06-24 Thread Dan Williams
Kumar Gala wrote: On Jun 24, 2009, at 12:56 PM, Dan Williams wrote: Lets go ahead w/2.6.31 (if its ok w/you). Ok, I'll take this as an acked-by and send it off. Thanks, Dan ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [PATCH 15/62] drivers/dma/fsldma.c: Remove unnecessary semicolons

2009-07-01 Thread Dan Williams
On Sun, Jun 28, 2009 at 9:26 AM, Joe Perchesj...@perches.com wrote: Signed-off-by: Joe Perches j...@perches.com ---  drivers/dma/fsldma.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) Applied 15 and 16. Thanks, Dan ___ Linuxppc-dev

Re: fsldma patches?

2009-07-30 Thread Dan Williams
Kumar Gala wrote: Dan, What happened with the set of patches that Ira posted for fsldma? I have just sent a pull request with the pending backlog of dmaengine fixes. Our discussion of the fsldma slave implementation did not conclude in time for me to get a pull request out before the close

Re: [PATCH] dmaengine: async_xor, fix zero address issue when xor highmem page

2012-01-26 Thread Dan Williams
2012/1/10 Shi Xuelin-B29237 b29...@freescale.com: Hello Dan Williams, Do you have any comment about this patch? Hi, sorrry for the delay. Thanks, Forrest -Original Message- From: Shi Xuelin-B29237 Sent: 2011年12月27日 14:31 To: vinod.k...@intel.com; dan.j.willi...@intel.com

Re: RFC: default ioremap_*() variant defintions

2015-07-04 Thread Dan Williams
On Fri, Jul 3, 2015 at 11:17 AM, Luis R. Rodriguez mcg...@suse.com wrote: The 0-day build bot detected a build issue on a patch not upstream yet that makes a driver use iorempa_uc(), this call is now upstream but we have no drivers yet using it, the patch in question makes the atyfb

  1   2   3   4   >