Re: macmini g4 can't boot with new kernel

2008-06-15 Thread Dave Young
On Sun, Jun 15, 2008 at 3:04 PM, Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Sun, 2008-06-15 at 12:12 +0800, Dave Young wrote: Hi, I recently built kernel 2.6.26-rc5 for my macmini g4, but it can't boot. I'm not sure if it's related to kernel or yaboot, or the open firmware. My

Re: [PATCH 0/5] kexec: minor fixups and enhancements

2014-08-26 Thread Dave Young
On 08/25/14 at 12:59pm, Vivek Goyal wrote: On Fri, Aug 22, 2014 at 06:39:47PM +, Geoff Levand wrote: Hi, Here are a few minor fixups and enhancements for kexec support. Patch 3 and 4 that add preprocessor macros for the kimage list flags are ones that I use in the arm64 kexec

Re: [PATCH 0/8] kexec_file_load implementation for PowerPC

2016-06-13 Thread Dave Young
On 06/12/16 at 12:10am, Thiago Jung Bauermann wrote: > Hello, > > This patch series implements the kexec_file_load system call on PowerPC. > > It starts by removing an x86 assumption from kexec_file: kexec_add_buffer uses > iomem to find reserved memory ranges, but PowerPC uses the memblock

Re: [PATCH 1/8] kexec_file: Remove unused members from struct kexec_buf.

2016-06-13 Thread Dave Young
al.h > @@ -26,8 +26,6 @@ struct kexec_sha_region { > */ > struct kexec_buf { > struct kimage *image; > - char *buffer; > - unsigned long bufsz; > unsigned long mem; > unsigned long memsz; > unsigned long buf_align; > -- >

Re: [PATCH 2/8] kexec_file: Generalize kexec_add_buffer.

2016-06-13 Thread Dave Young
On 06/12/16 at 12:10am, Thiago Jung Bauermann wrote: > Allow architectures to specify different memory walking functions for > kexec_add_buffer. Intel uses iomem to track reserved memory ranges, > but PowerPC uses the memblock subsystem. Can the crashk_res be inserted to iomem_resource so that

Re: [PATCH 2/8] kexec_file: Generalize kexec_add_buffer.

2016-06-13 Thread Dave Young
On 06/12/16 at 12:10am, Thiago Jung Bauermann wrote: > Allow architectures to specify different memory walking functions for > kexec_add_buffer. Intel uses iomem to track reserved memory ranges, > but PowerPC uses the memblock subsystem. > > Also, factor kexec_locate_mem_hole out of

Re: [PATCH v2 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-15 Thread Dave Young
auermann <bauer...@linux.vnet.ibm.com> > Cc: Eric Biederman <ebied...@xmission.com> > Cc: Dave Young <dyo...@redhat.com> > Cc: ke...@lists.infradead.org > Cc: linux-ker...@vger.kernel.org > --- > include/linux/kexec.h | 3 +++ > kernel/kexec_file.c | 44 +

Re: [PATCH 2/8] kexec_file: Generalize kexec_add_buffer.

2016-06-13 Thread Dave Young
> KEXEC_ON_CRASH. > > Am Montag, 13 Juni 2016, 15:29:39 schrieb Dave Young: > > On 06/12/16 at 12:10am, Thiago Jung Bauermann wrote: > > > Allow architectures to specify different memory walking functions for > > > kexec_add_buffer. Intel uses iomem to t

Re: [PATCH 0/6] kexec_file: Add buffer hand-over for the next kernel

2016-06-21 Thread Dave Young
On 06/20/16 at 10:44pm, Thiago Jung Bauermann wrote: > Hello, > > This patch series implements a mechanism which allows the kernel to pass on > a buffer to the kernel that will be kexec'd. This buffer is passed as a > segment which is added to the kimage when it is being prepared by >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
lt;ebied...@xmission.com> > Cc: Dave Young <dyo...@redhat.com> > Cc: ke...@lists.infradead.org > Cc: linux-ker...@vger.kernel.org > --- > include/linux/kexec.h | 4 > kernel/kexec_file.c | 66 > ++- > 2 f

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-22 Thread Dave Young
ent memory walking functions for > kexec_add_buffer. Intel uses iomem to track reserved memory ranges, > but PowerPC uses the memblock subsystem. > > Signed-off-by: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> > Cc: Eric Biederman <ebied...@xmission.com> > Cc: Dave Y

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
- Original Message - From: "Dave Young" <dyo...@redhat.com> To: "Thiago Jung Bauermann" <bauer...@linux.vnet.ibm.com> Cc: linuxppc-dev@lists.ozlabs.org, ke...@lists.infradead.org, linux-ker...@vger.kernel.org, "Eric Biederman" <ebied...@xmis

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/22/16 at 08:34pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 22 Juni 2016, 18:18:01 schrieb Dave Young: > > On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > > > +/** > > > + * kexec_locate_mem_hole - find free memory to load segment or use in > >

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/22/16 at 08:30pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 22 Juni 2016, 18:20:47 schrieb Dave Young: > > The patch looks good, but could the subject be more specific? > > > > For example just like the first sentence of the patch descriotion: > > Allow archite

Re: [PATCH v2 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-15 Thread Dave Young
On 06/15/16 at 01:21pm, Thiago Jung Bauermann wrote: > Hello Dave, > > Am Mittwoch, 15 Juni 2016, 15:33:02 schrieb Dave Young: > > > @@ -472,14 +498,16 @@ int kexec_add_buffer(struct kimage *image, char > > > *buffer, unsigned long bufsz,> >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-27 Thread Dave Young
On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 23 Juni 2016, 01:44:07 schrieb Dave Young: > > Hmm, hold on. For declaring a struct in a header file, comment should be > > just after each fields, like below, your format is for a function instead: >

[no subject]

2016-06-27 Thread Dave Young
6 at 01:37pm, Thiago Jung Bauermann wrote: > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave Young: > > On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote: > > > Am Donnerstag, 23 Juni 2016, 01:44:07 schrieb Dave Young: > > > What is bad about the description of top_do

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-27 Thread Dave Young
Please ignore previous reply, I mistakenly send a broken mail without subject, sorry about it. Resend the reply here. On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave Young: > > On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote:

Re: [PATCH v2 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-17 Thread Dave Young
On 06/16/16 at 05:39pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 16 Juni 2016, 09:58:53 schrieb Dave Young: > > On 06/15/16 at 01:21pm, Thiago Jung Bauermann wrote: > > > +/** > > > + * arch_kexec_walk_mem - call func(data) on free memory regions > >

Re: [RESEND][PATCH v2 1/2] kexec: refactor code parsing size based on memory range

2016-08-04 Thread Dave Young
Hi Hari, On 08/04/16 at 01:03am, Hari Bathini wrote: > crashkernel parameter supports different syntaxes to specify the amount > of memory to be reserved for kdump kernel. Below is one of the supported > syntaxes that needs parsing to find the memory size to reserve, based on > memory range: > >

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-12 Thread Dave Young
On 07/12/16 at 03:50pm, Mark Rutland wrote: > On Tue, Jul 12, 2016 at 04:24:10PM +0200, Arnd Bergmann wrote: > > On Tuesday, July 12, 2016 10:18:11 AM CEST Vivek Goyal wrote: > > > > > > > > On Open Firmware, the DT is extracted from running firmware and copied > > > > into dynamically allocated

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Dave Young
On 07/13/16 at 10:34am, Mark Rutland wrote: > On Wed, Jul 13, 2016 at 10:36:14AM +0800, Dave Young wrote: > > But consider we can kexec to a different kernel and a different initrd so > > there > > will be use cases to pass a total different dtb as well. > >

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Dave Young
On 07/14/16 at 02:38am, AKASHI Takahiro wrote: > Apologies for the slow response. I'm attending LinuxCon this week. > > On Wed, Jul 13, 2016 at 10:34:47AM +0100, Mark Rutland wrote: > > On Wed, Jul 13, 2016 at 10:36:14AM +0800, Dave Young wrote: > > > But consider we

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Dave Young
[snip] > Now, going back to the more fundamental issue raised in my first reply, > about the kernel command line. > > On x86, I can see that it _is_ possible for userspace to specify a > command line, and the kernel loading the image provides the command > line to the to-be-kexeced kernel with

Re: [RFC 3/3] kexec: extend kexec_file_load system call

2016-07-17 Thread Dave Young
On 07/15/16 at 09:09am, Vivek Goyal wrote: > On Tue, Jul 12, 2016 at 10:42:01AM +0900, AKASHI Takahiro wrote: > > [..] > > -SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, > > +SYSCALL_DEFINE6(kexec_file_load, int, kernel_fd, int, initrd_fd, > > unsigned long,

Re: [RFC 3/3] kexec: extend kexec_file_load system call

2016-07-17 Thread Dave Young
On 07/15/16 at 02:19pm, Mark Rutland wrote: > On Fri, Jul 15, 2016 at 09:09:55AM -0400, Vivek Goyal wrote: > > On Tue, Jul 12, 2016 at 10:42:01AM +0900, AKASHI Takahiro wrote: > > > > [..] > > > -SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, > > >

Re: [RFC 3/3] kexec: extend kexec_file_load system call

2016-07-18 Thread Dave Young
On 07/18/16 at 11:07am, Mark Rutland wrote: > On Mon, Jul 18, 2016 at 10:30:24AM +0800, Dave Young wrote: > > On 07/15/16 at 02:19pm, Mark Rutland wrote: > > > On Fri, Jul 15, 2016 at 09:09:55AM -0400, Vivek Goyal wrote: > > > > On Tue, Jul 12, 2016 at 10:42:01A

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-28 Thread Dave Young
On 06/27/16 at 04:21pm, Dave Young wrote: > Please ignore previous reply, I mistakenly send a broken mail without > subject, sorry about it. Resend the reply here. > > On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave You

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-07-04 Thread Dave Young
On 07/01/16 at 05:31pm, Thiago Jung Bauermann wrote: > Am Freitag, 01 Juli 2016, 17:02:23 schrieb Thiago Jung Bauermann: > > Am Freitag, 01 Juli 2016, 14:36:02 schrieb Dave Young: > > > On 07/01/16 at 02:51pm, Thiago Jung Bauermann wrote: > > > > Am Donnerstag, 30 Ju

Re: [RFC] arm64: kexec_file_load support

2016-07-04 Thread Dave Young
On 07/04/16 at 03:58pm, AKASHI Takahiro wrote: > Hi, > > On Fri, Jul 01, 2016 at 12:46:31PM -0300, Thiago Jung Bauermann wrote: > > Am Freitag, 01 Juli 2016, 14:11:12 schrieb AKASHI Takahiro: > > > I'm not sure whether there is any demand for kexec_file_load > > > support on arm64, but anyhow I'm

Re: [RFC] arm64: kexec_file_load support

2016-07-07 Thread Dave Young
On 07/05/16 at 05:03pm, AKASHI Takahiro wrote: > Hi Dave, > > On Tue, Jul 05, 2016 at 09:25:56AM +0800, Dave Young wrote: > > On 07/04/16 at 03:58pm, AKASHI Takahiro wrote: > > > Hi, > > > > > > On Fri, Jul 01, 2016 at 12:46:31PM -0300, Thiago Jung Ba

Re: [PATCH v4 2/9] kexec_file: Change kexec_add_buffer to take kexec_buf as argument.

2016-07-10 Thread Dave Young
existing casts to char * in the code. > > Signed-off-by: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> > Cc: Eric Biederman <ebied...@xmission.com> > Cc: Dave Young <dyo...@redhat.com> > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Ingo Molnar <mi...

Re: [RFC] arm64: kexec_file_load support

2016-07-10 Thread Dave Young
On 07/08/16 at 11:48am, Thiago Jung Bauermann wrote: > Am Donnerstag, 07 Juli 2016, 14:12:45 schrieb Dave Young: > > If so maybe change a bit from your precious mentioned 7 args proposal like > > below? > > > > struct kexec_file_fd { > > enu

Re: [PATCH v4 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-07-10 Thread Dave Young
off-by: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> > > Cc: Eric Biederman <ebied...@xmission.com> > > Cc: Dave Young <dyo...@redhat.com> > > Dave are you happy with the first three patches? If so do you mind > sending an ack? I reviewed the 3 pat

Re: [PATCH v4 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-07-10 Thread Dave Young
lt;ebied...@xmission.com> > Cc: Dave Young <dyo...@redhat.com> > --- > include/linux/kexec.h | 1 + > kernel/kexec_file.c | 25 - > 2 files changed, 21 insertions(+), 5 deletions(-) > > diff --git a/include/linux/kexec.h b/include/l

Re: [PATCH v4 1/9] kexec_file: Allow arch-specific memory walking for kexec_add_buffer

2016-07-10 Thread Dave Young
auermann <bauer...@linux.vnet.ibm.com> > Cc: Eric Biederman <ebied...@xmission.com> > Cc: Dave Young <dyo...@redhat.com> > --- > include/linux/kexec.h | 29 - > kernel/kexec_file.c | 30 ++ > kernel/kexec_inte

Re: [RFC] arm64: kexec_file_load support

2016-07-11 Thread Dave Young
On 07/11/16 at 04:19pm, AKASHI Takahiro wrote: > On Fri, Jul 08, 2016 at 11:48:44AM -0300, Thiago Jung Bauermann wrote: > > Am Donnerstag, 07 Juli 2016, 14:12:45 schrieb Dave Young: > > > If so maybe change a bit from your precious mentioned 7 args proposal like > > >

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/29/16 at 06:18pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 29 Juni 2016, 15:47:51 schrieb Dave Young: > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > > > index e8acb2b43dd9..e16d845d587f

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > > > On 06/27/16 at 04:21pm, Dave

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/30/16 at 01:08pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 11:41:19 schrieb Dave Young: > > On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > > > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > > > On 06/28/16 at 07:18p

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/30/16 at 01:42pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 12:49:44 schrieb Thiago Jung Bauermann: > > Am Donnerstag, 30 Juni 2016, 11:07:00 schrieb Dave Young: > > > On 06/29/16 at 06:18pm, Thiago Jung Bauermann wrote: > > > > I'm not foll

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-07-01 Thread Dave Young
On 07/01/16 at 02:51pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 17:43:57 schrieb Dave Young: > > On 06/30/16 at 01:42pm, Thiago Jung Bauermann wrote: > > > Am Donnerstag, 30 Juni 2016, 12:49:44 schrieb Thiago Jung Bauermann: > > > > To be h

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-29 Thread Dave Young
On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > On 06/27/16 at 04:21pm, Dave Young wrote: > > > Please ignore previous reply, I mistakenly send a broken mail without > > > subject, sorry abou

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-29 Thread Dave Young
On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 23 Juni 2016, 10:25:06 schrieb Dave Young: > > On 06/22/16 at 08:30pm, Thiago Jung Bauermann wrote: > > > Am Mittwoch, 22 Juni 2016, 18:20:47 schrieb Dave Young: > > > > The patch looks good,

Re: [PATCH v2 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-19 Thread Dave Young
On 06/17/16 at 05:51pm, Thiago Jung Bauermann wrote: > Am Freitag, 17 Juni 2016, 15:35:23 schrieb Dave Young: > > On 06/16/16 at 05:39pm, Thiago Jung Bauermann wrote: > > > Am Donnerstag, 16 Juni 2016, 09:58:53 schrieb Dave Young: > > > > On 06/15/16 at 01:21p

Re: [PATCH v2 0/6] kexec_file: Add buffer hand-over for the next kernel

2016-08-16 Thread Dave Young
On 08/13/16 at 12:18am, Thiago Jung Bauermann wrote: > Hello, > > This patch series implements a mechanism which allows the kernel to pass > on a buffer to the kernel that will be kexec'd. This buffer is passed > as a segment which is added to the kimage when it is being prepared > by

Re: [PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for some segments.

2016-08-21 Thread Dave Young
the trimming. > > Am Donnerstag, 18 August 2016, 17:03:30 schrieb Dave Young: > > On 08/13/16 at 12:18am, Thiago Jung Bauermann wrote: > > > Adds checksum argument to kexec_add_buffer specifying whether the given > > > segment should be part of the checksum calcu

Re: [PATCH v2 2/6] powerpc: kexec_file: Add buffer hand-over support for the next kernel

2016-08-21 Thread Dave Young
On 08/13/16 at 12:18am, Thiago Jung Bauermann wrote: > The buffer hand-over mechanism allows the currently running kernel to pass > data to kernel that will be kexec'd via a kexec segment. The second kernel > can check whether the previous kernel sent data and retrieve it. > > This is the

Re: [PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for some segments.

2016-08-21 Thread Dave Young
On 08/22/16 at 12:25am, Thiago Jung Bauermann wrote: > Am Montag, 22 August 2016, 11:17:45 schrieb Dave Young: > > On 08/18/16 at 06:09pm, Thiago Jung Bauermann wrote: > > > Hello Dave, > > > > > > Thanks for your review! > > > > > > [ Tr

Re: [PATCH v2 2/6] powerpc: kexec_file: Add buffer hand-over support for the next kernel

2016-08-22 Thread Dave Young
On 08/22/16 at 12:38am, Thiago Jung Bauermann wrote: > Am Montag, 22 August 2016, 11:21:35 schrieb Dave Young: > > On 08/13/16 at 12:18am, Thiago Jung Bauermann wrote: > > > diff --git a/arch/powerpc/kernel/machine_kexec_64.c > > > b/arch/powerpc/kernel/machine_kexec_64

Re: [PATCH v3 2/2] powerpc/fadump: parse fadump reserve memory size based on memory range

2016-08-25 Thread Dave Young
On 08/10/16 at 03:35pm, Hari Bathini wrote: > When fadump is enabled, by default 5% of system RAM is reserved for > fadump kernel. While that works for most cases, it is not good enough > for every case. > > Currently, to override the default value, fadump supports specifying > memory to reserve

Re: [PATHC v2 5/9] ima: on soft reboot, save the measurement list

2016-08-31 Thread Dave Young
Hi, Mimi On 08/30/16 at 06:40pm, Mimi Zohar wrote: > From: Thiago Jung Bauermann > > This patch uses the kexec buffer passing mechanism to pass the > serialized IMA binary_runtime_measurements to the next kernel. > > Changelog v2: > - Fix build issue by defining a

Re: [PATCH v2 2/2] kexec: extend kexec_file_load system call

2016-08-18 Thread Dave Young
Since Eric was objecting the extension, I think you should convince him, but I will review from code point of view. On 08/11/16 at 08:03pm, Thiago Jung Bauermann wrote: > From: AKASHI Takahiro > > Device tree blob must be passed to a second kernel on DTB-capable >

Re: [PATCH v2 1/2] kexec: add dtb info to struct kimage

2016-08-18 Thread Dave Young
); > image->initrd_buf = NULL; > > + vfree(image->dtb_buf); > + image->dtb_buf = NULL; > + > kfree(image->cmdline_buf); > image->cmdline_buf = NULL; > > -- > 1.9.1 > > > ___ > kexec mailing list > ke...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec Acked-by: Dave Young <dyo...@redhat.com> Thanks Dave

Re: [PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for some segments.

2016-08-18 Thread Dave Young
On 08/13/16 at 12:18am, Thiago Jung Bauermann wrote: > Adds checksum argument to kexec_add_buffer specifying whether the given > segment should be part of the checksum calculation. > Since it is used with add buffer, could it be added to kbuf as a new field? Like kbuf.no_checksum, default value

Re: [PATCH v3 2/2] powerpc/fadump: parse fadump reserve memory size based on memory range

2016-08-25 Thread Dave Young
On 08/25/16 at 11:00pm, Hari Bathini wrote: > > > On Thursday 25 August 2016 12:31 PM, Dave Young wrote: > > On 08/10/16 at 03:35pm, Hari Bathini wrote: > > > When fadump is enabled, by default 5% of system RAM is reserved for > > > fadump kernel. While that wor

Re: [PATCH v10 04/10] kexec_file: Add support for purgatory built as PIE.

2016-11-23 Thread Dave Young
On 11/21/16 at 09:49pm, Thiago Jung Bauermann wrote: > Hello Dave, > > Thanks for your review. > > Am Sonntag, 20. November 2016, 10:45:46 BRST schrieb Dave Young: > > On 11/10/16 at 01:27am, Thiago Jung Bauermann wrote: > > > powerpc's purgatory.ro has

Re: [PATCH v10 04/10] kexec_file: Add support for purgatory built as PIE.

2016-11-21 Thread Dave Young
On 11/21/16 at 09:49pm, Thiago Jung Bauermann wrote: > Hello Dave, > > Thanks for your review. > > Am Sonntag, 20. November 2016, 10:45:46 BRST schrieb Dave Young: > > On 11/10/16 at 01:27am, Thiago Jung Bauermann wrote: > > > powerpc's purgatory.ro has

Re: [PATCH v10 04/10] kexec_file: Add support for purgatory built as PIE.

2016-11-22 Thread Dave Young
On 11/22/16 at 11:44am, Thiago Jung Bauermann wrote: > Am Dienstag, 22. November 2016, 17:01:10 BRST schrieb Michael Ellerman: > > Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> writes: > > > Am Sonntag, 20. November 2016, 10:45:46 BRST schrieb Dave Young: >

Re: [PATCH v10 04/10] kexec_file: Add support for purgatory built as PIE.

2016-11-21 Thread Dave Young
Hi Michael On 11/22/16 at 05:01pm, Michael Ellerman wrote: > Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> writes: > > Am Sonntag, 20. November 2016, 10:45:46 BRST schrieb Dave Young: > >> On 11/10/16 at 01:27am, Thiago Jung Bauermann wrote: > >> > powe

Re: [PATCH v10 04/10] kexec_file: Add support for purgatory built as PIE.

2016-11-19 Thread Dave Young
On 11/10/16 at 01:27am, Thiago Jung Bauermann wrote: > powerpc's purgatory.ro has 12 relocation types when built as > a relocatable object. To implement support for them requires > arch_kexec_apply_relocations_add to duplicate a lot of code with > module_64.c:apply_relocate_add. > > When built as

Re: [PATCH v2 2/5] ia64: reuse append_elf_note() and final_note() functions

2016-11-30 Thread Dave Young
Hi Hari Personally I like V1 more, but split the patch 2 is easier for ia64 people to reivew. I did basic x86 testing, it runs ok. On 11/25/16 at 05:24pm, Hari Bathini wrote: > Get rid of multiple definitions of append_elf_note() & final_note() > functions. Reuse these functions compiled under

Re: [PATCH v4 1/5] crash: move crashkernel parsing and vmcore related code under CONFIG_CRASH_CORE

2017-01-05 Thread Dave Young
| 445 > > kernel/kexec_core.c| 404 > kernel/ksysfs.c|8 + > kernel/printk/printk.c |6 - > 9 files changed, 531 insertions(+), 463 deletions(-) > create mode 100644 include/linux/crash_core.h > create mode 100644 kernel/crash_core.c > [snip] Acked-by: Dave Young <dyo...@redhat.com> Thanks Dave

Re: [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note() functions

2017-01-05 Thread Dave Young
buf, , sizeof(note)); > - buf += (sizeof(note) + 3)/4; > - memcpy(buf, name, note.n_namesz); > - buf += (note.n_namesz + 3)/4; > - memcpy(buf, data, note.n_descsz); > - buf += (note.n_descsz + 3)/4; > - > - return buf; > -} > - > -static void final_note(u32 *buf) > -{ > - struct elf_note note; > - > - note.n_namesz = 0; > - note.n_descsz = 0; > - note.n_type = 0; > - memcpy(buf, , sizeof(note)); > -} > - > void crash_save_cpu(struct pt_regs *regs, int cpu) > { > struct elf_prstatus prstatus; > It looks good to me. But better to have words from IA64 people as well. Acked-by: Dave Young <dyo...@redhat.com> Thanks Dave

Re: [PATCH v3 2/5] ia64: reuse append_elf_note() and final_note() functions

2017-01-04 Thread Dave Young
On 01/02/17 at 07:44pm, Hari Bathini wrote: > Get rid of multiple definitions of append_elf_note() & final_note() > functions. Reuse these functions compiled under CONFIG_CRASH_CORE > Also, define Elf_Word and use it instead of generic u32 or the more > specific Elf64_Word. > > Signed-off-by:

Re: [PATCH v3 1/5] crash: move crashkernel parsing and vmcore related code under CONFIG_CRASH_CORE

2017-01-04 Thread Dave Young
Hi, Hari On 01/02/17 at 07:43pm, Hari Bathini wrote: > Traditionally, kdump is used to save vmcore in case of a crash. Some > architectures like powerpc can save vmcore using architecture specific > support instead of kexec/kdump mechanism. Such architecture specific > support also needs to

Re: [PATCH v4 2/3] powerpc/fadump: Use the correct VMCOREINFO_NOTE_SIZE for phdr

2017-04-26 Thread Dave Young
..) > r = vscnprintf(buf, sizeof(buf), fmt, args); > va_end(args); > > - r = min(r, vmcoreinfo_max_size - vmcoreinfo_size); > + r = min(r, VMCOREINFO_BYTES - vmcoreinfo_size); > > memcpy(_data[vmcoreinfo_size], buf, r); > > -- > 1.8.3.1 > > > ___ > kexec mailing list > ke...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec Reviewed-by: Dave Young <dyo...@redhat.com> Thanks Dave

Re: [PATCH] powerpc: kexec_file: Fix error code when trying to load kdump kernel

2018-03-30 Thread Dave Young
he patch: > > # ~bauermann/src/kexec-tools/build/sbin/kexec -s -p /boot/vmlinuz > kexec_file_load failed: Operation not supported > > Fixes: a0458284f062 ("powerpc: Add support code for kexec_file_load()") > Reported-by: Dave Young <dyo...@redhat.com> > Sign

Re: [PATCH] powerpc/kdump: handle crashkernel memory reservation failure

2018-06-28 Thread Dave Young
return; > + } > } > > int overlaps_crashkernel(unsigned long start, unsigned long size) > It would be better to print a separate error message for !memblock_is_region_memory But I think memblock_reserve is unlikly to fail so this patch is also good. Reviewed-by: Dave Young Thanks Dave

Re: [PATCH v2 0/2] Append new variables to vmcoreinfo (PTRS_PER_PGD for arm64 and MAX_PHYSMEM_BITS for all archs)

2019-03-11 Thread Dave Young
Hi Bhupesh, On 03/10/19 at 03:34pm, Bhupesh Sharma wrote: > Changes since v1: > > - v1 was sent out as a single patch which can be seen here: > http://lists.infradead.org/pipermail/kexec/2019-February/022411.html > > - v2 breaks the single patch into two independent patches: >

Re: [PATCH] powerpc: Fix loading of kernel + initramfs with kexec_file_load()

2019-05-22 Thread Dave Young
KEXEC_BUF_MEM_UNKNOWN; > ret = kexec_add_buffer(); > if (ret) > goto out; > > > ___ > kexec mailing list > ke...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec Reviewed-by: Dave Young Thanks Dave

Re: [PATCHv2] kernel/crash: make parse_crashkernel()'s return value more indicant

2019-04-28 Thread Dave Young
On 04/29/19 at 12:48pm, Pingfan Liu wrote: > On Mon, Apr 29, 2019 at 11:04 AM Pingfan Liu wrote: > > > > On Sun, Apr 28, 2019 at 4:37 PM Dave Young wrote: > > > > > > On 04/25/19 at 04:20pm, Pingfan Liu wrote: > > > > On Wed, Apr 24, 201

Re: [PATCHv2] kernel/crash: make parse_crashkernel()'s return value more indicant

2019-04-28 Thread Dave Young
On 04/25/19 at 04:20pm, Pingfan Liu wrote: > On Wed, Apr 24, 2019 at 4:31 PM Matthias Brugger wrote: > > > > > [...] > > > @@ -139,6 +141,8 @@ static int __init parse_crashkernel_simple(char > > > *cmdline, > > > pr_warn("crashkernel: unrecognized char: %c\n", *cur); > > >

Re: [PATCH 18/39] docs: admin-guide: add kdump documentation into it

2019-07-04 Thread Dave Young
START, or it must be built as a relocatable image > (CONFIG_RELOCATABLE=y). > - For more details see Documentation/kdump/kdump.rst > + For more details see Documentation/admin-guide/kdump/kdump.rst > > config KEXEC_JUMP > bool "kexec jump" > @@ -2094,7 +2094,7 @@ config PHYSICAL_START > the reserved region. In other words, it can be set based on > the "X" value as specified in the "crashkernel=YM@XM" > command line boot parameter passed to the panic-ed > - kernel. Please take a look at Documentation/kdump/kdump.rst > + kernel. Please take a look at > Documentation/admin-guide/kdump/kdump.rst > for more details about crash dumps. > > Usage of bzImage for capturing the crash dump is recommended as > -- > 2.21.0 > Acked-by: Dave Young Thanks Dave

Re: [PATCH 18/39] docs: admin-guide: add kdump documentation into it

2019-07-04 Thread Dave Young
On 07/05/19 at 11:43am, Alex Shi wrote: > > > 在 2019/6/28 下午8:30, Mauro Carvalho Chehab 写道: > > The Kdump documentation describes procedures with admins use > > in order to solve issues on their systems. > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > >

Re: [PATCH v4 0/3] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs)

2019-11-21 Thread Dave Young
On 11/11/19 at 01:31pm, Bhupesh Sharma wrote: > Changes since v3: > > - v3 can be seen here: > http://lists.infradead.org/pipermail/kexec/2019-March/022590.html > - Addressed comments from James and exported TCR_EL1.T1SZ in vmcoreinfo > instead of PTRS_PER_PGD. > - Added a new

Re: [PATCH 01/11] kexec_file: allow archs to handle special regions while locating memory hole

2020-07-02 Thread Dave Young
On 07/02/20 at 12:01am, Hari Bathini wrote: > > > On 01/07/20 1:16 pm, Dave Young wrote: > > On 06/29/20 at 05:26pm, Hari Bathini wrote: > >> Hi Petr, > >> > >> On 29/06/20 5:09 pm, Petr Tesarik wrote: > >>> Hi Hari, > >>> &g

Re: [PATCH 04/11] ppc64/kexec_file: avoid stomping memory used by special regions

2020-07-02 Thread Dave Young
On 07/01/20 at 11:48pm, Hari Bathini wrote: > > > On 01/07/20 1:10 pm, Dave Young wrote: > > Hi Hari, > > On 06/27/20 at 12:35am, Hari Bathini wrote: > >> crashkernel region could have an overlap with special memory regions > >> like opal, rtas, tce-t

Re: [PATCH 04/11] ppc64/kexec_file: avoid stomping memory used by special regions

2020-07-02 Thread Dave Young
> > I'm confused about the "overlap with crashkernel memory", does that mean > > those normal kernel used memory could be put in crashkernel reserved > > memory range? If so why can't just skip those areas while crashkernel > > doing the reservation? > I raised the same question in another mail.

Re: [PATCH v6 1/2] crash_core, vmcoreinfo: Append 'MAX_PHYSMEM_BITS' to vmcoreinfo

2020-07-02 Thread Dave Young
n't > seem to have been cc'ed either (only the kexec list). For the VMCOREINFO part, I'm fine with the changes, but since I do not understand the arm64 pieces so I would like to leave to arm64 people to review. If arm64 bits are good enough, feel free to add: Acked-by: Dave Young Thanks Dave

Re: [PATCH v2 01/12] kexec_file: allow archs to handle special regions while locating memory hole

2020-07-06 Thread Dave Young
; @@ -675,7 +687,7 @@ int kexec_add_buffer(struct kexec_buf *kbuf) > kbuf->buf_align = max(kbuf->buf_align, PAGE_SIZE); > > /* Walk the RAM ranges and allocate a suitable range for the buffer */ > - ret = kexec_locate_mem_hole(kbuf); > + ret = arch_kexec_locate_mem_hole(kbuf); > if (ret) > return ret; > > Acked-by: Dave Young Thanks Dave

Re: [PATCH 01/11] kexec_file: allow archs to handle special regions while locating memory hole

2020-07-01 Thread Dave Young
On 06/29/20 at 05:26pm, Hari Bathini wrote: > Hi Petr, > > On 29/06/20 5:09 pm, Petr Tesarik wrote: > > Hi Hari, > > > > is there any good reason to add two more functions with a very similar > > name to an existing function? AFAICS all you need is a way to call a > > PPC64-specific function

Re: [PATCH 04/11] ppc64/kexec_file: avoid stomping memory used by special regions

2020-07-01 Thread Dave Young
Hi Hari, On 06/27/20 at 12:35am, Hari Bathini wrote: > crashkernel region could have an overlap with special memory regions > like opal, rtas, tce-table & such. These regions are referred to as > exclude memory ranges. Setup this ranges during image probe in order > to avoid them while finding