Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Felipe Balbi
nodes in the core instead of doing this manually in each driver. So, fix the drivers and documentation, too. Signed-off-by: Wolfram Sang w...@the-dreams.de for i2c-omap.c: Reviewed-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCH 42/51] DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks

2013-09-20 Thread Felipe Balbi
callbacks, which may be called during the musb device probing. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk you want me to carry this one through my tree or you prefer getting my Acked-by ? Either way works for me: Acked-by: Felipe Balbi ba...@ti.com there's also the third option of me

Re: [PATCH 37/51] DMA-API: usb: use new dma_coerce_mask_and_coherent()

2013-09-20 Thread Felipe Balbi
-coherent_dma_mask; - ret = dma_set_coherent_mask(dev, DMA_BIT_MASK(32)); + ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32)); if (ret) return ret; for dwc3 and ehci-omap: Acked-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital

Re: [PATCH 36/51] DMA-API: usb: use dma_set_coherent_mask()

2013-09-20 Thread Felipe Balbi
) + goto resource_fail; udc-board = lpc32xx_usbddata; for dwc3 and drivers/usb/gadget: Acked-by: Felipe Balbi ba...@ti.com pretty cool work :-) -- balbi signature.asc Description: Digital signature ___ Linuxppc-dev mailing list

Re: [PATCH v2] usb: fsl_udc: errata - postpone freeing current dTD

2012-05-21 Thread Felipe Balbi
Hi, On Mon, May 21, 2012 at 08:57:22AM +0200, Christoph Fritz wrote: USB controller may access a wrong address for the dTD (endpoint transfer descriptor) and then hang. This happens a lot when doing tests with g_ether module and iperf, a tool for measuring maximum TCP and UDP bandwidth.

Re: [PATCH v2] usb: fsl_udc: errata - postpone freeing current dTD

2012-06-04 Thread Felipe Balbi
On Mon, Jun 04, 2012 at 01:30:24PM +0200, Christoph Fritz wrote: Hi, On Mon, 2012-05-21 at 22:04 +0300, Felipe Balbi wrote: On Mon, May 21, 2012 at 08:57:22AM +0200, Christoph Fritz wrote: USB controller may access a wrong address for the dTD (endpoint transfer descriptor

Re: [PATCH 5/5] usb: gadget: composite: parse dt overrides

2012-07-02 Thread Felipe Balbi
Hi, On Tue, Jun 26, 2012 at 11:27:13AM -0300, Alexandre Pereira da Silva wrote: Grab the devicetree node properties to override VendorId, ProductId, bcdDevice, Manucacturer, Product and SerialNumber Signed-off-by: Alexandre Pereira da Silva aletes@gmail.com I need Grant's acked-by to

Re: [PATCH] usb:gadget: use min_t() macro instead of min()

2011-06-13 Thread Felipe Balbi
Hi, On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote: Signed-off-by: Tatyana Brokhman tlin...@codeaurora.org I need a sensible commit log for this. Why do we need to change all min() to min_t() ? -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb:gadget: use min_t() macro instead of min()

2011-06-13 Thread Felipe Balbi
Hi, On Mon, Jun 13, 2011 at 02:52:34PM +0300, Tanya Brokhman wrote: On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote: Signed-off-by: Tatyana Brokhman tlin...@codeaurora.org I need a sensible commit log for this. Why do we need to change all min() to min_t() ?

Re: [PATCH] usb:gadget: use min_t() macro instead of min()

2011-06-13 Thread Felipe Balbi
Hi, On Mon, Jun 13, 2011 at 03:03:44PM -0400, Alan Stern wrote: The change I suggested involved replacing two typecasts with a single min_t. All (or almost all) the places this patch touches currently contain only one typecast, so the motivation for changing them is a lot weaker.

Re: [PATCH 00/14] Modifications for DWC OTG since v13

2011-08-31 Thread Felipe Balbi
Hi, (you did not add Greg in Cc, he's the USB maintainer. You also didn't Cc myself as maintainer of the gadget framework) On Tue, Aug 30, 2011 at 05:27:47PM +0530, Pratyush Anand wrote: These patches are based on:http://patchwork.ozlabs.org/patch/89560/ After not getting any reply from

Re: [RFC PATCH 0/2] usb: Reuse fsl driver code for synopsys usb controller

2014-04-21 Thread Felipe Balbi
On Sun, Apr 20, 2014 at 09:57:03PM +0530, Punnaiah Choudary Kalluri wrote: Zynq soc contains a dual role usb controller and this IP is from synopsys. We observed that there is driver available for this controller from freescale and decided to reuse this driver for zynq use. Here is the link

Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

2014-05-12 Thread Felipe Balbi
; @@ - SET_ETHTOOL_OPS(dev, ops); + dev-ethtool_ops = ops; Compile tested only, but I'd seriously wonder if this broke anything. Suggested-by: Dave Miller da...@davemloft.net Signed-off-by: Wilfried Klaebe w-l...@lebenslange-mailadresse.de for drivers/usb/gadget/: Acked-by: Felipe Balbi ba...@ti.com

Re: [PATCH V5 1/9] Add Synopsys DesignWare HS USB OTG Control and Status Register (CSR).

2010-10-21 Thread Felipe Balbi
Hi, On Wed, Oct 20, 2010 at 07:42:44PM -0500, Fushen Chen wrote: Control and Status Register (CSR) are classified as follows: - Core Global Registers - Device Mode Registers - Device Global Registers - Device Endpoint Specific Registers - Host Mode Registers - Host Global Registers - Host Port

Re: [PATCH V5 2/9] Add Synopsys DesignWare HS USB OTG driver framework.

2010-10-21 Thread Felipe Balbi
On Wed, Oct 20, 2010 at 07:42:45PM -0500, Fushen Chen wrote: Platform probing is in dwc_otg_apmppc.c. Driver parameter and parameter checking are in dwc_otg_param.c. Signed-off-by: Fushen Chen fc...@apm.com Signed-off-by: Mark Miesfeld mmiesf...@apm.com --- drivers/usb/dwc_otg/dwc_otg_apmppc.c

Re: [PATCH v13 02/10] USB/ppc4xx: Add Synopsys DWC OTG driver framework

2011-04-04 Thread Felipe Balbi
On Sun, Apr 03, 2011 at 04:16:50PM -0700, tma...@apm.com wrote: From: Tirumala Marri tma...@apm.com Platform probing is in dwc_otg_apmppc.c. Driver parameter and parameter checking are in dwc_otg_param.c. Signed-off-by: Tirumala R Marri tma...@apm.com Signed-off-by: Fushen Chen

Re: [PATCH v13 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)

2011-04-04 Thread Felipe Balbi
Hi, On Sun, Apr 03, 2011 at 04:16:53PM -0700, tma...@apm.com wrote: +const char *op_state_str(enum usb_otg_state state) please don't introduce yet another version of this. Make the ones available generic. Place a static inline const char *otg_state_string(struct otg_transceiver *x) on

Re: [PATCH v13 07/10] USB/ppc4xx: Add Synopsys DWC OTG PCD function

2011-04-04 Thread Felipe Balbi
Hi, On Sun, Apr 03, 2011 at 04:17:10PM -0700, tma...@apm.com wrote: +static const struct usb_gadget_ops dwc_otg_pcd_ops = { + .get_frame = dwc_otg_pcd_get_frame, + .wakeup = dwc_otg_pcd_wakeup, + /* not selfpowered */ will you really have a board running this top operating system

Re: [PATCH v13 09/10] USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and Makefile

2011-04-04 Thread Felipe Balbi
On Sun, Apr 03, 2011 at 04:17:24PM -0700, tma...@apm.com wrote: From: Tirumala Marri tma...@apm.com Add Synopsys DesignWare HS USB OTG driver kernel configuration. Synopsys OTG driver may operate in host only, device only, or OTG mode. The driver also allows user configure the core to use

Re: [PATCH v13 08/10] USB ppc4xx: Add Synopsys DWC OTG PCD interrupt function

2011-04-04 Thread Felipe Balbi
On Sun, Apr 03, 2011 at 04:17:13PM -0700, tma...@apm.com wrote: +void start_next_request(struct pcd_ep *ep) this will probably cause namespace clashes at some point. prepent with dwc_ or make it static. -- balbi ___ Linuxppc-dev mailing list

Re: [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)

2011-04-05 Thread Felipe Balbi
On Tue, Apr 05, 2011 at 12:38:03PM +0530, Keshava Munegowda wrote: -Original Message- From: Sergei Shtylyov [mailto:sshtyl...@mvista.com] Sent: Saturday, April 02, 2011 12:26 AM To: Tirumala Marri Cc: Keshava Munegowda; linux-...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;

Re: [PATCH] usb: gadget: fsl_udc_core: remove mapped flag

2012-09-05 Thread Felipe Balbi
Hi, On Tue, Sep 04, 2012 at 07:24:59PM +0200, Enrico Scholz wrote: The 'mapped' flag in 'struct fsl_req' flag is redundant with checking for 'req.dma != DMA_ADDR_INVALID' and it was also set to a wrong value you should not be using DMA_ADDR_INVALID anymore. Use the generic map/unmap routines

Re: [PATCH] usb: gadget: fsl_udc_core: do not immediatly prime STATUS for IN xfer

2012-09-06 Thread Felipe Balbi
On Wed, Sep 05, 2012 at 02:10:39AM +, Chen Peter-B29397 wrote: Because the fsl_udc_core driver shares one 'status_req' object for the complete ep0 control transfer, it is not possible to prime the final STATUS phase immediately after the IN transaction. E.g. ch9getstatus()

Re: [PATCH] usb: gadget: fsl_udc_core: do not immediatly prime STATUS for IN xfer

2012-09-06 Thread Felipe Balbi
Hi, On Thu, Sep 06, 2012 at 04:27:12PM +0200, Enrico Scholz wrote: Felipe Balbi ba...@ti.com writes: Because the fsl_udc_core driver shares one 'status_req' object for the complete ep0 control transfer, it is not possible to prime the final STATUS phase immediately after

Re: [PATCH] usb: gadget: fsl_udc_core: remove mapped flag

2012-09-06 Thread Felipe Balbi
On Thu, Sep 06, 2012 at 04:32:28PM +0200, Enrico Scholz wrote: Chen Peter-B29397 b29...@freescale.com writes: If the class driver has already mapped this address, the req-req.dma is not DMA_ADDR_INVALID either, in this case, the dma_sync_single_for_cpu is enough. ok; forget the patch

Re: [PATCH] usb: gadget: fsl_udc_core: do not immediatly prime STATUS for IN xfer

2012-09-10 Thread Felipe Balbi
On Thu, Sep 06, 2012 at 05:27:42PM +0300, Felipe Balbi wrote: Hi, On Thu, Sep 06, 2012 at 04:27:12PM +0200, Enrico Scholz wrote: Felipe Balbi ba...@ti.com writes: Because the fsl_udc_core driver shares one 'status_req' object for the complete ep0 control transfer

Re: [PATCH 1/7] usb: gadget: fsl_udc: simplify driver init

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 12:24:39PM +0200, Christoph Fritz wrote: To initialize this driver use 'module_platform_driver' instead of '__init' and '__exit'. Signed-off-by: Christoph Fritz chf.fr...@googlemail.com --- drivers/usb/gadget/fsl_udc_core.c | 37

Re: [PATCH 2/7] usb: gadget: fsl_udc: protect fsl_pullup() with spin_lock

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 12:24:40PM +0200, Christoph Fritz wrote: This patch reworks fsl_pullup() against the background of switching over to udc_start()/udc_stop() style: Protect function fsl_pullup() with a spin_lock. Also set vbus_active as default to true. This prevents disabling USB

Re: [PATCH 3/7] usb: gadget: fsl_udc: convert to new ulc style

2012-10-19 Thread Felipe Balbi
Hi, typo on Subject. Should be udc, not ulc. On Fri, Oct 19, 2012 at 12:24:41PM +0200, Christoph Fritz wrote: Convert to new UDC style registration and remove global 'udc_controller' pointer. Signed-off-by: Christoph Fritz chf.fr...@googlemail.com --- drivers/usb/gadget/fsl_udc_core.c |

Re: [PATCH 4/7] usb: gadget: fsl_udc: drop ARCH dependency

2012-10-19 Thread Felipe Balbi
On Fri, Oct 19, 2012 at 12:24:42PM +0200, Christoph Fritz wrote: Drop the big-/little-endian helpers and make use of generic writel()/readl() routines. Signed-off-by: Christoph Fritz chf.fr...@googlemail.com --- drivers/usb/gadget/fsl_udc_core.c | 331

Re: [PATCH 5/7] usb: gadget: fsl_udc: postpone freeing current dTD

2012-10-19 Thread Felipe Balbi
On Fri, Oct 19, 2012 at 12:24:43PM +0200, Christoph Fritz wrote: USB controller may access a wrong address for the dTD (endpoint transfer descriptor) and then hang. This happens a lot when doing tests with g_ether module and iperf, a tool for measuring maximum TCP and UDP bandwidth. This

Re: [PATCH 5/7] usb: gadget: fsl_udc: postpone freeing current dTD

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 12:46:48PM +0200, Christoph Fritz wrote: On Fri, 2012-10-19 at 13:30 +0300, Felipe Balbi wrote: On Fri, Oct 19, 2012 at 12:24:43PM +0200, Christoph Fritz wrote: USB controller may access a wrong address for the dTD (endpoint transfer descriptor) and then hang

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote: Some gadget drivers may attempt to dequeue requests for an endpoint that has already been disabled. For example, in the UVC gadget driver, uvc_function_set_alt() will call usb_ep_disable() when alt setting 0 is selected. When

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-22 Thread Felipe Balbi
On Mon, Oct 22, 2012 at 03:33:19AM +, Li Yang-R58472 wrote: -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Saturday, October 20, 2012 1:37 AM To: Simon Haggett Cc: Li Yang-R58472; Felipe Balbi; Greg Kroah-Hartman; linux- u...@vger.kernel.org; linuxppc

Re: [PATCH 5/7] usb: gadget: fsl_udc: postpone freeing current dTD

2012-10-22 Thread Felipe Balbi
Hi, On Sat, Oct 20, 2012 at 09:12:27PM +0200, Christoph Fritz wrote: On Fri, 2012-10-19 at 13:44 +0300, Felipe Balbi wrote: I thought about this too but wasn't able to use chipidea with MXC_EHCI_INTERNAL_PHY as it's called in fsl_udc. that's a matter of writing the PHY driver, right

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-22 Thread Felipe Balbi
Hi, On Mon, Oct 22, 2012 at 12:47:21PM +0200, Laurent Pinchart wrote: Hi, On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote: On Saturday, October 20, 2012 1:37 AM Felipe Balbi wrote: On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote: Some gadget drivers may attempt

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-26 Thread Felipe Balbi
Hi, On Thu, Oct 25, 2012 at 02:36:24AM +0200, Laurent Pinchart wrote: Hi Felipe, On Monday 22 October 2012 13:56:01 Felipe Balbi wrote: On Mon, Oct 22, 2012 at 12:47:21PM +0200, Laurent Pinchart wrote: On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote: On Saturday, October 20

Re: [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Felipe Balbi
to be shared by every licensee of the chipidea core ? Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Li Yang le...@freescale.com Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org --- drivers

Re: [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 10:35:37PM +0800, Li Yang wrote: On Wed, Oct 31, 2012 at 9:26 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Oct 31, 2012 at 04:06:00PM +0800, Xiaotian Feng wrote: If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished

Re: [PATCH 119/493] usb: remove use of __devexit_p

2012-11-19 Thread Felipe Balbi
...@linux.intel.com Cc: Felipe Balbi ba...@ti.com Cc: Li Yang le...@freescale.com Cc: Alan Stern st...@rowland.harvard.edu Cc: Wan ZongShun mcuos@gmail.com Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Cc: linux-...@vger.kernel.org Cc: linux-o...@vger.kernel.org Cc

Re: [PATCH 159/493] usb: remove use of __devinit

2012-11-19 Thread Felipe Balbi
Cc: Felipe Balbi ba...@ti.com Cc: Li Yang le...@freescale.com Cc: Alan Stern st...@rowland.harvard.edu Cc: Geoff Levand ge...@infradead.org Cc: Wan ZongShun mcuos@gmail.com Cc: Olav Kongas o...@artecdesign.ee Cc: Lennert Buytenhek ker...@wantstofly.org Cc: Ben Dooks ben-li

Re: [PATCH 371/493] usb: remove use of __devinitconst

2012-11-19 Thread Felipe Balbi
Hi, On Mon, Nov 19, 2012 at 01:25:20PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devinitconst is no longer needed. Signed-off-by: Bill Pemberton wf...@virginia.edu Cc: Li Yang le...@freescale.com Cc: Felipe Balbi ba...@ti.com Cc: linux

Re: [PATCH 431/493] usb: remove use of __devexit

2012-11-19 Thread Felipe Balbi
Cc: Felipe Balbi ba...@ti.com Cc: Li Yang le...@freescale.com Cc: Alan Stern st...@rowland.harvard.edu Cc: Wan ZongShun mcuos@gmail.com Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Cc: linux-...@vger.kernel.org Cc: linux-o...@vger.kernel.org Cc

[BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-10 Thread Felipe Balbi
Hi, Some recent patch has caused fsl_mxc_udc.c driver to fail compilation because it can't find mach/hardware.h anymore. I would like this to be fixed still during this -rc cycle. Thank you -- balbi signature.asc Description: Digital signature ___

Re: [BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-11 Thread Felipe Balbi
On Fri, Jan 11, 2013 at 03:23:59AM +, Chen Peter-B29397 wrote: Some recent patch has caused fsl_mxc_udc.c driver to fail compilation because it can't find mach/hardware.h anymore. I would like this to be fixed still during this -rc cycle. Me too, who's sending a

Re: [BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 08:35:29AM +, Chen Peter-B29397 wrote: I am working on it, but there are two versions, this one and chipidea's. Anyway, I will send a patch to fix this problem. if you're already using chipidea, then send me a patch removing this driver and focus

Re: [BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 09:24:16AM +, Li Yang-R58472 wrote: -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, January 11, 2013 4:41 PM To: Chen Peter-B29397 Cc: ba...@ti.com; ker...@pengutronix.de; Li Yang-R58472; Greg KH; linux- u

Re: [PATCH 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 05:56:28PM +0800, Peter Chen wrote: It changes the driver to use platform_device_id rather than cpu_is_xxx to determine the SoC type, and updates the platform code accordingly. Compile ok at imx_v6_v7_defconfig with CONFIG_USB_FSL_USB2 enable. Tested at mx51 bbg

Re: [PATCH 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 05:56:28PM +0800, Peter Chen wrote: It changes the driver to use platform_device_id rather than cpu_is_xxx to determine the SoC type, and updates the platform code accordingly. Compile ok at imx_v6_v7_defconfig with CONFIG_USB_FSL_USB2 enable. Tested at mx51 bbg

Re: [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-13 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 03:18:17PM +0800, Peter Chen wrote: It changes the driver to use platform_device_id rather than cpu_is_xxx to determine the SoC type, and updates the platform code accordingly. Compile ok at imx_v6_v7_defconfig with CONFIG_USB_FSL_USB2 enable. Tested at mx51 bbg

Re: [PATCH 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-13 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 09:12:43AM +0800, Shawn Guo wrote: Balbi, On Fri, Jan 11, 2013 at 02:50:59PM +0200, Felipe Balbi wrote: As I said before, this patch is too big for -rc and is unnecessary considering patch I wrote above. Note that there is no problems in checking if ULPI PHY clk

Re: [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 04:17:35PM +0800, Peter Chen wrote: On Mon, Jan 14, 2013 at 09:48:58AM +0200, Felipe Balbi wrote: Hi, On Mon, Jan 14, 2013 at 03:18:17PM +0800, Peter Chen wrote: It changes the driver to use platform_device_id rather than cpu_is_xxx to determine the SoC

Re: [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 05:13:44PM +0800, Peter Chen wrote: On Mon, Jan 14, 2013 at 10:50:27AM +0200, Felipe Balbi wrote: Hi, On Mon, Jan 14, 2013 at 04:17:35PM +0800, Peter Chen wrote: On Mon, Jan 14, 2013 at 09:48:58AM +0200, Felipe Balbi wrote: Hi, On Mon, Jan 14, 2013

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 06:12:39PM +0800, Peter Chen wrote: @@ -2756,22 +2753,41 @@ static int fsl_udc_otg_resume(struct device *dev) return fsl_udc_resume(NULL); } - /*- Register entry point for

Re: [PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote: As mach/hardware.h is deleted, we can't visit platform code at driver. It has no phy driver to combine with this controller, so it has to use ioremap to map phy address as a workaround. Signed-off-by: Peter Chen

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-Budde wrote: On 01/14/2013 11:16 AM, Felipe Balbi wrote: Hi, On Mon, Jan 14, 2013 at 06:12:39PM +0800, Peter Chen wrote: @@ -2756,22 +2753,41 @@ static int fsl_udc_otg_resume(struct device *dev) return fsl_udc_resume(NULL

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 11:34:05AM +0100, Marc Kleine-Budde wrote: On 01/14/2013 11:24 AM, Felipe Balbi wrote: On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-Budde wrote: On 01/14/2013 11:16 AM, Felipe Balbi wrote: Hi, On Mon, Jan 14, 2013 at 06:12:39PM +0800, Peter Chen wrote

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 11:50:41AM +0100, Marc Kleine-Budde wrote: On 01/14/2013 11:39 AM, Felipe Balbi wrote: On Mon, Jan 14, 2013 at 11:34:05AM +0100, Marc Kleine-Budde wrote: On 01/14/2013 11:24 AM, Felipe Balbi wrote: On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-Budde

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 12:03:04PM +0100, Marc Kleine-Budde wrote: On 01/14/2013 11:53 AM, Felipe Balbi wrote: Hi, On Mon, Jan 14, 2013 at 11:50:41AM +0100, Marc Kleine-Budde wrote: On 01/14/2013 11:39 AM, Felipe Balbi wrote: On Mon, Jan 14, 2013 at 11:34:05AM +0100, Marc Kleine-Budde

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 08:56:33PM +0800, Peter Chen wrote: snip Usually there isn't any Changelog between IP cores used in the different fsl processors (at least available outside of fsl), that makes it quite difficult to say if something found on one imx is really the same as on

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 06:54:22PM +0100, Marc Kleine-Budde wrote: On 01/14/2013 06:40 PM, Felipe Balbi wrote: Hi, On Mon, Jan 14, 2013 at 08:56:33PM +0800, Peter Chen wrote: snip Usually there isn't any Changelog between IP cores used in the different fsl processors (at least

Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Felipe Balbi
On Wed, Jan 16, 2013 at 09:48:25AM +0800, Peter Chen wrote: On Tue, Jan 15, 2013 at 10:03:46PM +0800, Shawn Guo wrote: On Tue, Jan 15, 2013 at 10:29:33AM +0800, Peter Chen wrote: As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides, one

Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 05:28:30PM +0800, Peter Chen wrote: trimming From what I understand balbi's comment, he dislikes this full list of device id. Instead, he prefers to something like below. static const struct platform_device_id fsl_udc_devtype[] = { {

Re: [PATCH v6 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 06:03:17PM +0800, Peter Chen wrote: As we use platform_device_id for fsl-usb2-udc driver, it needs to change clk connection-id, or the related devm_clk_get will be failed. Signed-off-by: Peter Chen peter.c...@freescale.com do I get Acked-by for this one ? -- balbi

Re: [RFC PATCH 1/6] usb: otg: Add an API to bind the USB controller and PHY

2013-01-18 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 04:44:52PM +0530, kishon wrote: @@ -171,6 +188,11 @@ static inline void devm_usb_put_phy(struct device *dev, struct usb_phy *x) { } +static inline struct usb_phy_bind *usb_bind_phy(const char *dev_name, u8 index, + const char

Re: [RFC PATCH 0/6] USB: Add multiple PHYs of same type

2013-01-18 Thread Felipe Balbi
On Wed, Jan 16, 2013 at 08:30:56PM +0530, Kishon Vijay Abraham I wrote: New platforms are being added which has multiple PHY's (of same type) and which has multiple USB controllers. The binding information has to be present in the PHY library (otg.c) in order for it to return the appropriate

[RFC/PATCH 01/32] usb: gadget: udc-core: allow udc class register gadget device

2013-01-24 Thread Felipe Balbi
, we're adding a flag which will be set by UDC driver once it removes the code for registering the gadget device. Once all are converted, the new flag will be removed. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/udc-core.c | 23 +++ include/linux/usb/gadget.h

[RFC/PATCH 03/32] usb: musb: gadget: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can delete a little boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/musb/musb_gadget.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index

[RFC/PATCH 04/32] usb: gadget: omap_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/omap_udc.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c index d0c87b1

[RFC/PATCH 08/32] usb: gadget: bcm63xx_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/bcm63xx_udc.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/gadget/bcm63xx_udc.c b/drivers/usb/gadget/bcm63xx_udc.c index 47a4993

[RFC/PATCH 06/32] usb: gadget: at91_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can remove some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/at91_udc.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c index 10f45fa

[RFC/PATCH 02/32] usb: dwc3: gadget: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
We don't need to register that device ourselves if we simply set gadget-register_my_device. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/dwc3/gadget.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3

[RFC/PATCH 05/32] usb: gadget: amd5536udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/amd5536udc.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c index 3dac001

[RFC/PATCH 00/32] usb: refactor gadget-dev registration

2013-01-24 Thread Felipe Balbi
Hi folks, Please comment on this series as I need help testing it on all UDC controllers so we can send it for v3.10 merge window. NOTE: I will queue this series for v3.10 merge window, so make sure to test and comment. cheers Felipe Balbi (32): usb: gadget: udc-core: allow udc class

[RFC/PATCH 09/32] usb: gadget: dummy_hcd: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/dummy_hcd.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c index 95d584d

[RFC/PATCH 11/32] usb: gadget: fsl_udc_core: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/fsl_udc_core.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c index

[RFC/PATCH 07/32] usb: gadget: atmel_usba_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/atmel_usba_udc.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget

[RFC/PATCH 10/32] usb: gadget: fsl_qe_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/fsl_qe_udc.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/usb/gadget/fsl_qe_udc.c b/drivers/usb/gadget/fsl_qe_udc.c index

[RFC/PATCH 12/32] usb: gadget: fusb300_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/fusb300_udc.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/usb/gadget/fusb300_udc.c b/drivers/usb/gadget/fusb300_udc.c index

[RFC/PATCH 14/32] usb: gadget: imx_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/imx_udc.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/gadget/imx_udc.c b/drivers/usb/gadget/imx_udc.c index a0eb857

[RFC/PATCH 15/32] usb: gadget: lpc32xx_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/lpc32xx_udc.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c index

[RFC/PATCH 13/32] usb: gadget: goku_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/goku_udc.c | 10 +- drivers/usb/gadget/goku_udc.h | 3 +-- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/usb/gadget/goku_udc.c b/drivers

[RFC/PATCH 18/32] usb: gadget: mv_u3d_core: fix a compile warning

2013-01-24 Thread Felipe Balbi
Fix the following compile warning: mv_u3d_core.c:1766:12: warning: 'mv_u3d_remove' \ defined but not used [-Wunused-function] Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/mv_u3d_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb

[RFC/PATCH 16/32] usb: gadget: m66592-udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/m66592-udc.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/gadget/m66592-udc.c b/drivers/usb/gadget/m66592-udc.c index

[RFC/PATCH 17/32] usb: gadget: mv_u3d_core: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/mv_u3d_core.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/usb/gadget/mv_u3d_core.c b/drivers/usb/gadget/mv_u3d_core.c index

[RFC/PATCH 19/32] usb: gadget: mv_udc_core: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/mv_udc_core.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c index

[RFC/PATCH 21/32] usb: gadget: net2280: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/net2280.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c index 708c0b5..630f715 100644

[RFC/PATCH 22/32] usb: gadget: pch_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/pch_udc.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c index a787a8e..7032145

[RFC/PATCH 23/32] usb: gadget: r8a66597-udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/r8a66597-udc.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c

[RFC/PATCH 20/32] usb: gadget: net2272: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/net2272.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/net2272.c b/drivers/usb/gadget/net2272.c index d226058..635248f

[RFC/PATCH 26/32] usb: gadget: s3c2410_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/s3c2410_udc.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index

[RFC/PATCH 25/32] usb: gadget: s3c-hsudc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/s3c-hsudc.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c index 4a3d620

[RFC/PATCH 24/32] usb: gadget: s3c-hsotg: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/s3c-hsotg.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index

[RFC/PATCH 29/32] usb: gadget: pxa27x_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/pxa27x_udc.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/usb/gadget/pxa27x_udc.c b/drivers/usb/gadget/pxa27x_udc.c index f7d2579

[RFC/PATCH 27/32] usb: renesas_usbhs: gadget: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/renesas_usbhs/mod_gadget.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs

[RFC/PATCH 30/32] usb: chipidea: register debugging syfs on our device

2013-01-24 Thread Felipe Balbi
Don't register anything non-generic under the gadget's device as we don't really *own* it. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/chipidea/udc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c

[RFC/PATCH 31/32] usb: chipidea: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/chipidea/udc.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index f64fbea..e95e8bb

[RFC/PATCH 28/32] usb: gadget: pxa25x_udc: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/pxa25x_udc.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/usb/gadget/pxa25x_udc.c b/drivers/usb/gadget/pxa25x_udc.c index fa9c344

[RFC/PATCH 32/32] usb: gadget: drop now unnecessary flag

2013-01-24 Thread Felipe Balbi
We don't need the -register_my_device flag anymore because all UDC drivers have been properly converted. Let's remove every history of it. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/chipidea/udc.c | 1 - drivers/usb/dwc3/gadget.c | 1 - drivers/usb/gadget

Re: [RFC/PATCH 32/32] usb: gadget: drop now unnecessary flag

2013-01-24 Thread Felipe Balbi
On Thu, Jan 24, 2013 at 07:52:52PM +0100, Tomasz Figa wrote: Hi Felipe, On Thursday 24 of January 2013 17:46:10 Felipe Balbi wrote: We don't need the -register_my_device flag anymore because all UDC drivers have been properly converted. Let's remove every history of it. Signed

  1   2   >