Re: Proposed prom parse fix + moving.

2009-04-17 Thread Ilpo Järvinen
fdt stuff into common code (drivers/of/of_fdt.c). But I haven't made a whole lot of progress yet. Original Message Subject: [RFC!] [PATCH] microblaze: fix bug in error handling Date: Thu, 16 Apr 2009 23:05:53 +0300 (EEST) From: Ilpo Järvinen ilpo.jarvi...@helsinki.fi

Re: Proposed prom parse fix + moving.

2009-04-17 Thread Ilpo Järvinen
On Fri, 17 Apr 2009, Ilpo Järvinen wrote: On Fri, 17 Apr 2009, Michal Simek wrote: Grant Likely wrote: On Fri, Apr 17, 2009 at 12:08 AM, Michal Simek mon...@monstr.eu wrote: Hi All, I have got email from Ilpo about prom_parse file. I take this file from powerpc. Who did write

[PATCH] powerpc/spufs: Remove invalid semicolon after if statement

2008-08-18 Thread Ilpo Järvinen
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/spufs/sched.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/sched.c b/arch/powerpc/platforms/cell/spufs/sched.c index 2deeeba..f7e5af8 100644 --- a/arch

Re: [RFC PATCH 6/7] serial: General support for multipoint addresses

2022-03-07 Thread Ilpo Järvinen
On Sun, 6 Mar 2022, Lukas Wunner wrote: > On Wed, Mar 02, 2022 at 11:56:05AM +0200, Ilpo Järvinen wrote: > > > This change is necessary for supporting devices with RS485 > > multipoint addressing [*]. > > If this is only used with RS485, why can't we just store t

Re: [RFC PATCH 6/7] serial: General support for multipoint addresses

2022-03-10 Thread Ilpo Järvinen
On Wed, 9 Mar 2022, Lukas Wunner wrote: > On Mon, Mar 07, 2022 at 11:48:01AM +0200, Ilpo Järvinen wrote: > > On Sun, 6 Mar 2022, Lukas Wunner wrote: > > > On Wed, Mar 02, 2022 at 11:56:05AM +0200, Ilpo Järvinen wrote: > > > > This change is necessary for

[RFC PATCH 6/7] serial: General support for multipoint addresses

2022-03-02 Thread Ilpo Järvinen
as Cc: linuxppc-dev@lists.ozlabs.org Cc: Yoshinori Sato Cc: Rich Felker Cc: linux...@vger.kernel.org Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: linux-...@vger.

[RFC PATCH 5/7] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-03-02 Thread Ilpo Järvinen
Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Ilpo Järvinen --- arch/alpha/inc

[PATCH v2 08/12] serial: General support for multipoint addresses

2022-04-04 Thread Ilpo Järvinen
inori Sato Cc: Rich Felker Cc: linux...@vger.kernel.org Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Ilpo Järvin

Re: [PATCH v2 07/12] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-04-04 Thread Ilpo Järvinen
On Mon, 4 Apr 2022, Arnd Bergmann wrote: > On Mon, Apr 4, 2022 at 10:29 AM Ilpo Järvinen > wrote: > > > > > #define CLOCAL 0010 > > +#define ADDRB 01000 /* address bit */ > > #define CMSPAR 0100 /* mark or space (stic

[PATCH v2 07/12] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-04-04 Thread Ilpo Järvinen
lerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Ilpo Järvinen --- arch/alpha/include/uapi/asm/termbits.h

[PATCH v3 07/12] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-04-11 Thread Ilpo Järvinen
lerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Ilpo Järvinen --- arch/alpha/include/uapi/asm/termbits.h

[PATCH v3 08/12] serial: General support for multipoint addresses

2022-04-11 Thread Ilpo Järvinen
inori Sato Cc: Rich Felker Cc: linux...@vger.kernel.org Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Ilpo Järvin

Re: [PATCH tty v1 00/74] serial: wrappers for uart port lock

2023-09-15 Thread Ilpo Järvinen
On Thu, 14 Sep 2023, John Ogness wrote: > When a serial port is used for kernel console output, then all > modifications to the UART registers which are done from other contexts, > e.g. getty, termios, are interference points for the kernel console. > > So far this has been ignored and the

[PATCH 0/3] PCI: PCI_HEADER_TYPE bugfix & cleanups

2023-10-03 Thread Ilpo Järvinen
through the subsystem specific trees once the define is there). Ilpo Järvinen (3): PCI: vmd: Correct PCI Header Type Register's MFD bit check PCI: Add PCI_HEADER_TYPE_MFD pci_regs.h PCI: Use PCI_HEADER_TYPE_* instead of literals drivers/pci/controller/dwc/pci-layerscape.c | 2

[PATCH 1/3] PCI: vmd: Correct PCI Header Type Register's MFD bit check

2023-10-03 Thread Ilpo Järvinen
with PCI_HEADER_TYPE_MASK. Fixes: 6aab5622296b ("PCI: vmd: Clean up domain before enumeration") Signed-off-by: Ilpo Järvinen Cc: Nirmal Patel --- drivers/pci/controller/vmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/v

[PATCH 2/3] PCI: Add PCI_HEADER_TYPE_MFD pci_regs.h

2023-10-03 Thread Ilpo Järvinen
Add PCI_HEADER_TYPE_MFD into pci_regs.h to be able to replace literals in the code. Signed-off-by: Ilpo Järvinen --- include/uapi/linux/pci_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h index e5f558d96493..06df65f11c39

[PATCH 3/3] PCI: Use PCI_HEADER_TYPE_* instead of literals

2023-10-03 Thread Ilpo Järvinen
Replace literals under drivers/pci/ with PCI_HEADER_TYPE_MASK, PCI_HEADER_TYPE_NORMAL, and PCI_HEADER_TYPE_MFD. While at it, replace !! boolean conversion with FIELD_GET(). Signed-off-by: Ilpo Järvinen --- drivers/pci/controller/dwc/pci-layerscape.c | 2 +- .../controller/mobiveil/pcie

[PATCH 6/7] PCI/DPC: Use defines with DPC reason fields

2023-10-18 Thread Ilpo Järvinen
Add new defines for DPC reason fields and use them instead of literals. Signed-off-by: Ilpo Järvinen --- drivers/pci/pcie/dpc.c| 27 +-- include/uapi/linux/pci_regs.h | 6 ++ 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/drivers/pci/pcie

[PATCH 5/7] PCI/DPC: Use defined fields with DPC_CTL register

2023-10-18 Thread Ilpo Järvinen
Instead of using a literal to clear bits, add PCI_EXP_DPC_CTL_EN_MASK and use the usual pattern to modify a bitfield. While at it, rearrange RMW code more logically together. Signed-off-by: Ilpo Järvinen --- drivers/pci/pcie/dpc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions

[PATCH 4/7] PCI/DPC: Use FIELD_GET()

2023-10-18 Thread Ilpo Järvinen
From: Bjorn Helgaas Use FIELD_GET() to remove dependencies on the field position, i.e., the shift value. No functional change intended. Signed-off-by: Ilpo Järvinen Signed-off-by: Bjorn Helgaas --- drivers/pci/pcie/dpc.c| 5 +++-- drivers/pci/quirks.c | 2 +- include/uapi

[PATCH 3/7] PCI: hotplug: Use FIELD_GET/PREP()

2023-10-18 Thread Ilpo Järvinen
Instead of handcrafted shifts to handle register fields, use FIELD_GET/FIELD_PREP(). Signed-off-by: Ilpo Järvinen --- drivers/pci/hotplug/pciehp_core.c | 3 ++- drivers/pci/hotplug/pciehp_hpc.c | 5 +++-- drivers/pci/hotplug/pnv_php.c | 3 ++- 3 files changed, 7 insertions(+), 4 deletions

Re: [PATCH v5 05/10] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-04-26 Thread Ilpo Järvinen
On Tue, 26 Apr 2022, Greg KH wrote: > On Tue, Apr 26, 2022 at 05:01:31PM +0300, Ilpo Järvinen wrote: > > > > ADDRB value is the same for all archs (it's just this octal vs hex > > notation I've followed as per the nearby defines within the same file > > whic

[PATCH v5 06/10] serial: General support for multipoint addresses

2022-04-26 Thread Ilpo Järvinen
inori Sato Cc: Rich Felker Cc: linux...@vger.kernel.org Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Ilpo Järvin

Re: [PATCH v5 05/10] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-04-26 Thread Ilpo Järvinen
On Tue, 26 Apr 2022, Greg KH wrote: > On Tue, Apr 26, 2022 at 03:24:43PM +0300, Ilpo Järvinen wrote: > > Add ADDRB to termbits to indicate 9th bit addressing mode. This change > > is necessary for supporting devices with RS485 multipoint addressing > > [*]. A later patch in

[PATCH v5 05/10] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-04-26 Thread Ilpo Järvinen
lerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Ilpo Järvinen --- arch/alpha/include/uapi/asm/termbits.h

Re: [PATCH v5 06/10] serial: General support for multipoint addresses

2022-04-26 Thread Ilpo Järvinen
On Tue, 26 Apr 2022, Greg KH wrote: > On Tue, Apr 26, 2022 at 03:24:44PM +0300, Ilpo Järvinen wrote: > > Add generic support for serial multipoint addressing. Two new ioctls > > are added. TIOCSADDR is used to indicate the destination/receive > > address. TIOCGADDR return

Re: [PATCH v5 05/10] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-04-26 Thread Ilpo Järvinen
One additional thing below I missed on the first read. On Tue, 26 Apr 2022, Ilpo Järvinen wrote: > On Tue, 26 Apr 2022, Greg KH wrote: > > > On Tue, Apr 26, 2022 at 03:24:43PM +0300, Ilpo Järvinen wrote: > > > Add ADDRB to termbits to indicate 9th bit address

[PATCH v4 08/13] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-04-25 Thread Ilpo Järvinen
lerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Ilpo Järvinen --- arch/alpha/include/uapi/asm/termbits.h

[PATCH v4 09/13] serial: General support for multipoint addresses

2022-04-25 Thread Ilpo Järvinen
inori Sato Cc: Rich Felker Cc: linux...@vger.kernel.org Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Ilpo Järvin

[PATCH 1/1] termbits: Convert octal defines to hex

2022-05-04 Thread Ilpo Järvinen
mv $i~ $i; done On top of that, some manual processing on alignment and number of zeros. In addition, small tweaks to formatting of a few comments on the same lines. Signed-off-by: Ilpo Järvinen --- I prefer this to go in though Greg's tty tree. arch/alpha/include/uapi

Re: [PATCH 1/1] termbits: Convert octal defines to hex

2022-05-04 Thread Ilpo Järvinen
On Wed, 4 May 2022, Arnd Bergmann wrote: > On Wed, May 4, 2022 at 9:20 AM Ilpo Järvinen > wrote: > > > > Many archs have termbits.h as octal numbers. It makes hard for humans > > to parse the magnitude of large numbers correctly and to compare with > &g

[PATCH 3/3] termbits.h: Remove posix_types.h include

2022-05-09 Thread Ilpo Järvinen
Nothing in termbits seems to require anything from linux/posix_types.h. Signed-off-by: Ilpo Järvinen --- arch/alpha/include/uapi/asm/termbits.h | 2 -- arch/mips/include/uapi/asm/termbits.h | 2 -- arch/parisc/include/uapi/asm/termbits.h | 2 -- arch/sparc/include/uapi/asm/termbits.h | 2

[PATCH 1/3] termbits.h: create termbits-common.h for identical bits

2022-05-09 Thread Ilpo Järvinen
Some defines are the same across all archs. Move the most obvious intersection to termbits-common.h. Signed-off-by: Ilpo Järvinen --- arch/alpha/include/uapi/asm/termbits.h | 52 + arch/mips/include/uapi/asm/termbits.h | 53 +- arch/parisc/include/uapi

[PATCH 0/3] termbits.h: Further improvements

2022-05-09 Thread Ilpo Järvinen
also tcflag_t into termbits-common.h due to the way it is being defined for sparc. However, by the looks of how the type for tcflag_t is being chosen there, having just unsigned int might work also for sparc? Ilpo Järvinen (3): termbits.h: create termbits-common.h for identical bits termbits.h

Re: [PATCH 1/3] termbits.h: create termbits-common.h for identical bits

2022-05-09 Thread Ilpo Järvinen
On Mon, 9 May 2022, Helge Deller wrote: > Hello Ilpo, > > On 5/9/22 11:34, Ilpo Järvinen wrote: > > Some defines are the same across all archs. Move the most obvious > > intersection to termbits-common.h. > > I like your cleanup patches, but in this specific one, doe

[PATCH 2/3] termbits.h: Align lines & format

2022-05-09 Thread Ilpo Järvinen
mann Signed-off-by: Ilpo Järvinen --- arch/alpha/include/uapi/asm/termbits.h | 130 +- arch/mips/include/uapi/asm/termbits.h| 156 ++--- arch/parisc/include/uapi/asm/termbits.h | 77 +-- arch/powerpc/include/uapi/asm/termbits.h | 100 +++---

Re: [PATCH 1/1] termbits: Convert octal defines to hex

2022-05-05 Thread Ilpo Järvinen
On Wed, 4 May 2022, Arnd Bergmann wrote: > On Wed, May 4, 2022 at 10:33 AM Ilpo Järvinen > wrote: > > On Wed, 4 May 2022, Arnd Bergmann wrote: > > > On Wed, May 4, 2022 at 9:20 AM Ilpo Järvinen > > > wrote: > > > > > > > After applying t

[PATCH 1/5] serial: ucc_uart: Remove custom frame size calculation

2022-08-25 Thread Ilpo Järvinen
batim copy of that in cpm_uart/cpm_uart_core.c anyway so perhaps it was just copied over w/o much thinking. Signed-off-by: Ilpo Järvinen --- drivers/tty/serial/ucc_uart.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_ua

[PATCH v2 1/5] serial: ucc_uart: Remove custom frame size calculation

2022-08-30 Thread Ilpo Järvinen
batim copy of that in cpm_uart/cpm_uart_core.c anyway so perhaps it was just copied over w/o much thinking. Reviewed-by: Andy Shevchenko Signed-off-by: Ilpo Järvinen --- drivers/tty/serial/ucc_uart.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/tty/serial/uc

[PATCH 26/44] serial: pmac_zilog: Use uart_xmit_advance()

2022-10-19 Thread Ilpo Järvinen
Take advantage of the new uart_xmit_advance() helper. Signed-off-by: Ilpo Järvinen --- drivers/tty/serial/pmac_zilog.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c index fe2e4ec423f7..13668ffdb1e7

[PATCH 42/44] serial: ucc_uart: Use uart_xmit_advance()

2022-10-19 Thread Ilpo Järvinen
Take advantage of the new uart_xmit_advance() helper. Signed-off-by: Ilpo Järvinen --- drivers/tty/serial/ucc_uart.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index 82cf14dd3d43..b09b6496ee3e 100644

[PATCH 6/8] serial: Make ->set_termios() old ktermios const

2022-08-16 Thread Ilpo Järvinen
There should be no reason to adjust old ktermios which is going to get discarded anyway. Signed-off-by: Ilpo Järvinen --- drivers/tty/serial/21285.c | 2 +- drivers/tty/serial/8250/8250_bcm7271.c | 2 +- drivers/tty/serial/8250/8250_dw.c | 2 +- drivers/tty

[PATCH v2 07/13] tty: Convert ->dtr_rts() to take bool argument

2023-01-10 Thread Ilpo Järvinen
r line status which requires int so use a separate variable for status. Reviewed-by: Jiri Slaby Signed-off-by: Ilpo Järvinen --- drivers/char/pcmcia/synclink_cs.c| 4 +-- drivers/mmc/core/sdio_uart.c | 4 +-- drivers/staging/greybus/uart.c | 2 +- drivers/tty/amise

[PATCH v2 11/13] tty/serial: Call ->dtr_rts() parameter active consistently

2023-01-10 Thread Ilpo Järvinen
Convert various parameter names for ->dtr_rts() and related functions from onoff, on, and raise to active. Signed-off-by: Ilpo Järvinen --- drivers/char/pcmcia/synclink_cs.c | 6 +++--- drivers/mmc/core/sdio_uart.c | 6 +++--- drivers/staging/greybus/uart.c| 4 ++-- drivers/

[PATCH 07/10] tty: Convert ->dtr_rts() to take bool argument

2023-01-04 Thread Ilpo Järvinen
Convert the raise/on parameter in ->dtr_rts() to bool through the callchain. The parameter is used like bool. In USB serial, there remains a few implicit bool -> larger type conversions because some devices use u8 in their control messages. Signed-off-by: Ilpo Järvinen --- drivers/char/

Re: [PATCH 07/10] tty: Convert ->dtr_rts() to take bool argument

2023-01-05 Thread Ilpo Järvinen
On Thu, 5 Jan 2023, Jiri Slaby wrote: > On 04. 01. 23, 16:15, Ilpo Järvinen wrote: > > Convert the raise/on parameter in ->dtr_rts() to bool through the > > callchain. The parameter is used like bool. In USB serial, there > > remains a few implicit bool -> larger ty

[PATCH v3 11/13] tty/serial: Call ->dtr_rts() parameter active consistently

2023-01-11 Thread Ilpo Järvinen
Convert various parameter names for ->dtr_rts() and related functions from onoff, on, and raise to active. Reviewed-by: Jiri Slaby Signed-off-by: Ilpo Järvinen --- drivers/char/pcmcia/synclink_cs.c | 6 +++--- drivers/mmc/core/sdio_uart.c | 6 +++--- drivers/staging/greybus/uart.c

[PATCH v3 07/13] tty: Convert ->dtr_rts() to take bool argument

2023-01-11 Thread Ilpo Järvinen
r line status which requires int so use a separate variable for status. Reviewed-by: Jiri Slaby Signed-off-by: Ilpo Järvinen --- drivers/char/pcmcia/synclink_cs.c| 4 +-- drivers/mmc/core/sdio_uart.c | 4 +-- drivers/staging/greybus/uart.c | 2 +- drivers/tty/amise

[PATCH v4 07/12] tty: Convert ->dtr_rts() to take bool argument

2023-01-17 Thread Ilpo Järvinen
r line status which requires int so use a separate variable for status. Reviewed-by: Jiri Slaby Acked-by: Ulf Hansson # For MMC Signed-off-by: Ilpo Järvinen --- drivers/char/pcmcia/synclink_cs.c | 4 +-- drivers/mmc/core/sdio_uart.c | 4 +-- drivers/staging/greybus/uart.c| 2 +- drive

[PATCH v4 11/12] tty: Call ->dtr_rts() parameter active consistently

2023-01-17 Thread Ilpo Järvinen
Convert various parameter names for ->dtr_rts() and related functions from onoff, on, and raise to active. Reviewed-by: Jiri Slaby Acked-by: Ulf Hansson # For MMC Signed-off-by: Ilpo Järvinen --- drivers/char/pcmcia/synclink_cs.c | 6 +++--- drivers/mmc/core/sdio_uart.c

[PATCH 1/2] serial: ucc_uart: Use uart_circ_empty()

2023-03-20 Thread Ilpo Järvinen
Use uart_circ_empty() rather than open coding it. Signed-off-by: Ilpo Järvinen --- drivers/tty/serial/ucc_uart.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index 32c7a5b43f8e..e6bd1256a4e7 100644

Re: [PATCH v3 2/2] serial: 8250: Apply FSL workarounds also without SERIAL_8250_CONSOLE

2023-06-05 Thread Ilpo Järvinen
put in the same compilation unit as 8250_port.o because the > latter defines some functions needed in the former and so 8250_fsl.o > must not be built-in if 8250_port.o is available in a module. > > Acked-by: Ilpo Järvinen > Link: > https://lore.kernel.org/r/20230531083230.2702181-1-

Re: [PATCH v3 2/2] serial: 8250: Apply FSL workarounds also without SERIAL_8250_CONSOLE

2023-06-05 Thread Ilpo Järvinen
On Mon, 5 Jun 2023, Uwe Kleine-König wrote: > On Mon, Jun 05, 2023 at 04:22:55PM +0300, Ilpo Järvinen wrote: > > On Mon, 5 Jun 2023, Uwe Kleine-König wrote: > > > > > The need to handle the FSL variant of 8250 in a special way is also > > > present w

Re: [PATCH v3 2/2] serial: 8250: Apply FSL workarounds also without SERIAL_8250_CONSOLE

2023-06-05 Thread Ilpo Järvinen
On Mon, 5 Jun 2023, Uwe Kleine-König wrote: > Hello Ilpo, > > On Mon, Jun 05, 2023 at 04:44:08PM +0300, Ilpo Järvinen wrote: > > On Mon, 5 Jun 2023, Uwe Kleine-König wrote: > > > On Mon, Jun 05, 2023 at 04:22:55PM +0300, Ilpo Järvinen wrote: > > > > On Mon

[PATCH 4/4] PCI: Create helper to print TLP Header and Prefix Log

2024-02-06 Thread Ilpo Järvinen
Add pcie_print_tlp_log() helper to print TLP Header and Prefix Log. Print End-End Prefixes only if they are non-zero. Consolidate the few places which currently print TLP using custom formatting. Signed-off-by: Ilpo Järvinen --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +-- drivers

[PATCH 3/4] PCI: Add TLP Prefix reading into pcie_read_tlp_log()

2024-02-06 Thread Ilpo Järvinen
ixes. Signed-off-by: Ilpo Järvinen --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +- drivers/pci/ats.c | 2 +- drivers/pci/pci.c | 37 --- drivers/pci/pcie/aer.c| 4 +- drivers/pci/pcie/d

[PATCH 0/4] PCI: Consolidate TLP Log reading and printing

2024-02-06 Thread Ilpo Järvinen
heck the error handling conversion within the driver is correct. Ilpo Järvinen (4): PCI/AER: Cleanup register variable PCI: Generalize TLP Header Log reading PCI: Add TLP Prefix reading into pcie_read_tlp_log() PCI: Create helper to print TLP Header and Prefix Log drivers/firmware/efi/cp

[PATCH 2/4] PCI: Generalize TLP Header Log reading

2024-02-06 Thread Ilpo Järvinen
ally. Generalize the struct name and members, and use it consistently where TLP Header Log is being handled so that a pcie_read_tlp_log() helper can be easily added. Signed-off-by: Ilpo Järvinen --- drivers/firmware/efi/cper.c | 4 +- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

[PATCH 1/4] PCI/AER: Cleanup register variable

2024-02-06 Thread Ilpo Järvinen
Use u32 for PCIe Capability register variable and name it aercc (Advanced Error Capabilities and Control register, PCIe r6.1 sec 7.8.4.7) instead of temp. Signed-off-by: Ilpo Järvinen --- drivers/pci/pcie/aer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH 0/4] PCI: Consolidate TLP Log reading and printing

2024-02-07 Thread Ilpo Järvinen
Adding Cc Quigshun which I ended up forgotting despite thinking it at one point. -- i. On Tue, 6 Feb 2024, Ilpo Järvinen wrote: > This series consolidates AER & DPC TLP Log handling code. Helpers are > added for reading and printing the TLP Log and the format is made to >

[PATCH 1/1] PCI/DPC: Fix TLP Prefix register reading offset

2024-01-18 Thread Ilpo Järvinen
Signed-off-by: Ilpo Järvinen --- drivers/pci/pcie/dpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c index 94111e438241..e5d7c12854fa 100644 --- a/drivers/pci/pcie/dpc.c +++ b/drivers/pci/pcie/dpc.c @@ -234,7 +234,7 @@ s

[PATCH 2/6] powerpc/fsl-pci: Use PCI_HEADER_TYPE_MASK instead of literal

2023-11-24 Thread Ilpo Järvinen
Replace 0x7f literals with PCI_HEADER_TYPE_MASK. Signed-off-by: Ilpo Järvinen --- arch/powerpc/sysdev/fsl_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index 3868483fbe29..ef7707ea0db7 100644

Re: [PATCH 1/1] PCI/DPC: Fix TLP Prefix register reading offset

2024-01-22 Thread Ilpo Järvinen
On Fri, 19 Jan 2024, Bjorn Helgaas wrote: > On Thu, Jan 18, 2024 at 01:08:15PM +0200, Ilpo Järvinen wrote: > > The TLP Prefix Log Register consists of multiple DWORDs (PCIe r6.1 sec > > 7.9.14.13) but the loop in dpc_process_rp_pio_error() keeps reading > > from the first DWO

Re: [PATCH 0/4] PCI: Consolidate TLP Log reading and printing

2024-03-11 Thread Ilpo Järvinen
On Fri, 8 Mar 2024, Bjorn Helgaas wrote: > On Tue, Feb 06, 2024 at 03:57:13PM +0200, Ilpo Järvinen wrote: > > This series consolidates AER & DPC TLP Log handling code. Helpers are > > added for reading and printing the TLP Log and the format is made to > > include E

Re: [PATCH 0/4] PCI: Consolidate TLP Log reading and printing

2024-03-22 Thread Ilpo Järvinen
On Mon, 11 Mar 2024, Ilpo Järvinen wrote: > On Fri, 8 Mar 2024, Bjorn Helgaas wrote: > > > On Tue, Feb 06, 2024 at 03:57:13PM +0200, Ilpo Järvinen wrote: > > > This series consolidates AER & DPC TLP Log handling code. Helpers are > > > added for reading and p

[PATCH v2 2/2] PCI: Create helper to print TLP Header and Prefix Log

2024-04-03 Thread Ilpo Järvinen
() is not compatible with pci_err() but prints on a separate line. When I asked about this, Andy Shevchenko suggested pr_cont() should not be used in the first place (to eventually get rid of it) so pr_cont() is now replaced with building the string first. Signed-off-by: Ilpo Järvinen --- drivers/pci

[PATCH v2 1/2] PCI: Add TLP Prefix reading into pcie_read_tlp_log()

2024-04-03 Thread Ilpo Järvinen
ixes. Signed-off-by: Ilpo Järvinen --- drivers/pci/ats.c | 2 +- drivers/pci/pci.c | 34 -- drivers/pci/pcie/aer.c| 4 +++- drivers/pci/pcie/dpc.c| 22 +++--- drivers/pci/probe.c

[PATCH v2 0/2] PCI: Consolidate TLP Log reading and printing

2024-04-03 Thread Ilpo Järvinen
This series has the remaining patches of the AER & DPC TLP Log handling consolidation. v2: - Don't add EXPORT()s - Don't include igxbe changes - Don't use pr_cont() as it's incompatible with pci_err() and according to Andy Shevchenko should not be used in the first place Ilpo Järvine

Re: [PATCH v2 1/2] PCI: Add TLP Prefix reading into pcie_read_tlp_log()

2024-04-04 Thread Ilpo Järvinen
On Thu, 4 Apr 2024, Lukas Wunner wrote: > On Wed, Apr 03, 2024 at 01:02:05PM +0300, Ilpo Järvinen wrote: > > pcie_read_tlp_log() handles only 4 TLP Header Log DWORDs but TLP Prefix > > Log (PCIe r6.1 secs 7.8.4.12 & 7.9.14.13) may also be present. > > > &g

[PATCH v3 1/2] PCI: Add TLP Prefix reading into pcie_read_tlp_log()

2024-04-12 Thread Ilpo Järvinen
E-E Prefixes. Signed-off-by: Ilpo Järvinen --- drivers/pci/ats.c | 2 +- drivers/pci/pci.c | 34 -- drivers/pci/pcie/aer.c| 4 +++- drivers/pci/pcie/dpc.c| 22 +++--- drivers/pci/probe.c

[PATCH v3 0/2] PCI: Consolidate TLP Log reading and printing

2024-04-12 Thread Ilpo Järvinen
used in the first place Ilpo Järvinen (2): PCI: Add TLP Prefix reading into pcie_read_tlp_log() PCI: Create helper to print TLP Header and Prefix Log drivers/pci/ats.c | 2 +- drivers/pci/pci.c | 66 +++ drivers/pci/pcie/aer.c

[PATCH v3 2/2] PCI: Create helper to print TLP Header and Prefix Log

2024-04-12 Thread Ilpo Järvinen
() is not compatible with pci_err() but prints on a separate line. When I asked about this, Andy Shevchenko suggested pr_cont() should not be used in the first place (to eventually get rid of it) so pr_cont() is now replaced with building the string first. Signed-off-by: Ilpo Järvinen --- drivers/pci