Re: [RFC] scripts/get_maintainer: add emails based on keywords in the patch

2009-10-09 Thread Joe Perches
On Fri, 2009-10-09 at 12:32 +0200, Wolfram Sang wrote: +my %keywords_to_mail = ( + 'of_get_property' = 'L: devicetree-disc...@lists.ozlabs.org', maybe: '\bof_get_property\b' + # Check the lines which a patch modifies for keywords; add mail if found. + } elsif

Re: [RFC] scripts/get_maintainer: add emails based on keywords in the patch

2009-10-09 Thread Joe Perches
On Fri, 2009-10-09 at 04:23 -0700, Joe Perches wrote: If this facility is desired by many others, it might be better to have a separate file of 'regex generates email' read at initialization. Perhaps it's better to use the existing MAINTAINERS file and extend it with a new K: for keyword entry

[PATCH] MAINTAINERS: Add PowerPC patterns

2009-12-04 Thread Joe Perches
month ago). Anyways, I've been stretched thin with all sort of stuff lately, so bear with me if I'm a bit slow at taking or testing stuff, I'm doing my best. Adding patterns to the PowerPC sections of MAINTAINERS is useful. Signed-off-by: Joe Perches j...@perches.com diff --git a/MAINTAINERS b

Re: [PATCH] MAINTAINERS: Add PowerPC patterns

2009-12-07 Thread Joe Perches
On Tue, 2009-12-08 at 15:56 +1100, Benjamin Herrenschmidt wrote: On Fri, 2009-12-04 at 09:16 -0800, Joe Perches wrote: Adding patterns to the PowerPC sections of MAINTAINERS is useful. Signed-off-by: Joe Perches j...@perches.com Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org

[PATCH] viodasd.c: Remove VIOD_KERN_level macros for printks

2009-12-22 Thread Joe Perches
Use #define pr_fmt(fmt) viod: fmt Remove #define VIOD_KERN_WARNING and VIOD_KERN_INFO Convert printk(VIOD_KERN_level to pr_level Coalesce long format strings Signed-off-by: Joe Perches j...@perches.com Acked-by: Stephen Rothwell s...@canb.auug.org.au drivers/block/viodasd.c | 86

Re: [rtc-linux] Re: [PATCH 7/7] powerpc/ps3: Add rtc-ps3

2009-03-09 Thread Joe Perches
On Mon, 2009-03-09 at 12:06 -0700, Geoff Levand wrote: There was some work by Joe Perches to list the files a maintainer is responsible for into the MAINTAINERS file. I think that would give you what you want, a way to automatically get the maintainer of a file. Joe, could you let us know

Re: [PATCH] Add hvc_console to MAINTAINERS

2009-03-31 Thread Joe Perches
On Tue, 2009-03-31 at 09:29 -0400, Josh Boyer wrote: Add a MAINTAINERS entry for the hypervisor virtual console support used on IBM POWER servers. Signed-off-by: Josh Boyer jwbo...@linux.vnet.ibm.com --- diff --git a/MAINTAINERS b/MAINTAINERS index c5f4e9d..387ad45 100644 ---

Re: [PATCH] [289/2many] MAINTAINERS - LINUX FOR POWERPC

2007-08-13 Thread Joe Perches
On Mon, 2007-08-13 at 06:16 -0500, Josh Boyer wrote: There's also the arch/ppc, include/asm-ppc directories until they get removed. LINUX FOR POWERPC P: Paul Mackerras M: [EMAIL PROTECTED] W: http://www.penguinppc.org/ L: linuxppc-dev@ozlabs.org T: git

Re: [PATCH] [298/2many] MAINTAINERS - LINUX FOR 64BIT POWERPC

2007-08-13 Thread Joe Perches
On Mon, 2007-08-13 at 06:15 -0500, Josh Boyer wrote: Erm, there's a lot more to 64-bit PowerPC than those 3 files. You're better off just doing arch/powerpc/, include/asm-powerpc. LINUX FOR 64BIT POWERPC P: Paul Mackerras M: [EMAIL PROTECTED] M: [EMAIL PROTECTED] P: Anton

Re: [PATCH] [43/2many] MAINTAINERS - AOA (Apple Onboard Audio) ALSA DRIVER

2007-08-13 Thread Joe Perches
On Mon, 2007-08-13 at 16:54 +1000, Michael Ellerman wrote: +F: sound/oao/ Should be aoa. AOA (Apple Onboard Audio) ALSA DRIVER P: Johannes Berg M: [EMAIL PROTECTED] L: linuxppc-dev@ozlabs.org L: [EMAIL PROTECTED] (subscribers-only) S: Maintained F: sound/aoa/

Re: [PATCH] [392/2many] MAINTAINERS - PS3 PLATFORM SUPPORT

2007-08-13 Thread Joe Perches
On Mon, 2007-08-13 at 15:24 -0700, Geoff Levand wrote: +F: include/asm-powerpc/lv1call.h Added to my tree. PS3 PLATFORM SUPPORT P: Geoff Levand M: [EMAIL PROTECTED] L: linuxppc-dev@ozlabs.org L: [EMAIL PROTECTED] S: Supported F: arch/powerpc/boot/ps3* F:

[PATCH 03/59] arch/powerpc: Add missing space

2007-11-19 Thread Joe Perches
Signed-off-by: Joe Perches [EMAIL PROTECTED] --- arch/powerpc/kernel/isa-bridge.c |4 ++-- arch/powerpc/mm/fault.c|2 +- arch/powerpc/platforms/8xx/m8xx_setup.c|2 +- arch/powerpc/platforms/celleb/io-workarounds.c |2 +- arch/powerpc

Re: [RFC] [PATCH] watchdog_info separation and constify

2010-01-19 Thread Joe Perches
On Tue, 2010-01-19 at 22:17 +0100, Wim Van Sebroeck wrote: -static struct watchdog_info at32_wdt_info = { +static const struct watchdog_info at32_wdt_info = { It'd be good to use a consistent structure name: static const struct watchdog_info ident = { etc... } $ grep -Poh

Re: [RFC] [PATCH] watchdog_info separation and constify

2010-01-19 Thread Joe Perches
On Tue, 2010-01-19 at 22:16 +, Mark Brown wrote: On Tue, Jan 19, 2010 at 01:42:31PM -0800, Joe Perches wrote: Maybe a standard #define WATCHDOG_NAME foo .identity = WATCHGOD_NAME I don't really see that the indrection via the #define would buy us anything? Maybe not, just

[PATCH 00/10] treewide: Fix format strings that misuse continuations

2010-01-31 Thread Joe Perches
Format strings that are continued with \ are frequently misused. Change them to use mostly single line formats, some longer than 80 chars. Fix a few miscellaneous typos at the same time. Joe Perches (10): arch/powerpc: Fix continuation line formats arch/blackfin: Fix continuation line formats

[PATCH 01/10] arch/powerpc: Fix continuation line formats

2010-01-31 Thread Joe Perches
String constants that are continued on subsequent lines with \ are not good. Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/kernel/nvram_64.c |6 +++--- arch/powerpc/platforms/pseries/hotplug-cpu.c |8 arch/powerpc/platforms/pseries/smp.c

Re: [PATCH 01/10] arch/powerpc: Fix continuation line formats

2010-02-01 Thread Joe Perches
On Mon, 2010-02-01 at 13:16 +1100, Benjamin Herrenschmidt wrote: On Sun, 2010-01-31 at 12:02 -0800, Joe Perches wrote: String constants that are continued on subsequent lines with \ are not good. Signed-off-by: Joe Perches j...@perches.com You want me to take that in the powerpc tree

[PATCH v2 0/7] wireless: Use macros from wireless.h

2010-03-18 Thread Joe Perches
Move the STD_IW_HANDLER macro from orinoco to wireless.h Use the wireless.h macros in various wireless files Remove local #defines of IW_IOCTL Joe Perches (7): wireless.h: Add STD_IW_HANDLER macro net/wireless/wext_core.c: Use IW_IOCTL_IDX macro net/wireless/wext-core.c: Use IW_EVENT_IDX

[PATCH v2 5/7] drivers/net: Remove local #define IW_IOCTL, use STD_IW_HANDLER

2010-03-18 Thread Joe Perches
Use #define STD_IW_HANDLER from wireless.h instead Signed-off-by: Joe Perches j...@perches.com --- drivers/net/ps3_gelic_wireless.c | 35 +++--- drivers/net/wireless/ipw2x00/ipw2200.c | 83 2 files changed, 58 insertions(+), 60 deletions

[PATCH v3 0/9] wireless: Use macros from wireless.h

2010-03-18 Thread Joe Perches
Create a IW_HANDLER macro for iw_handler array entries in wireless.h Use the wireless.h macros in various wireless files Use starting index define SIOCIWFIRST where appropriate Remove local #defines of IW_IOCTL Remove STD_IW_HANDLER macro in orinoco, use IW_HANDLER instead Joe Perches (9

[PATCH v3 7/9] drivers/net: Remove local #define IW_IOCTL, use IW_HANDLER

2010-03-18 Thread Joe Perches
Use #define IW_HANDLER from wireless.h instead Signed-off-by: Joe Perches j...@perches.com --- drivers/net/ps3_gelic_wireless.c | 35 +++--- drivers/net/wireless/ipw2x00/ipw2200.c | 83 2 files changed, 58 insertions(+), 60 deletions(-) diff

Re: [PATCH 00/12] treewide: Remove unnecessary kmalloc casts

2010-06-09 Thread Joe Perches
On Wed, 2010-06-09 at 02:20 -0500, Milton Miller wrote: On Mon Jun 07 2010 at around 23:53:18 EST, Joe Perches wrote: Trivial cleanups The reason they casts are present is to guard against someone changing the type of p at the top of the function and not changing the type at the kmalloc

Re: [PATCH 0/5] Removing dead code

2010-06-10 Thread Joe Perches
(cc's trimmed and rpjday added) On Wed, 2010-06-09 at 11:58 +0200, Christoph Egger wrote: I've been running a check on the arch/powerpc sourcetree for config Items not defined in Kconfig and found5 such chases. Are you aware of http://www.crashcourse.ca/wiki/index.php/Kernel_cleanup_scripts

[PATCH 03/36] arch/powerpc: Remove unnecessary casts of private_data

2010-07-12 Thread Joe Perches
Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/kvm/timing.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kvm/timing.c b/arch/powerpc/kvm/timing.c index 7037855..46fa04f 100644 --- a/arch/powerpc/kvm/timing.c +++ b/arch/powerpc/kvm/timing.c

Re: question about arch/powerpc/platforms/cell/celleb_scc_uhc.c

2010-09-01 Thread Joe Perches
On Wed, 2010-09-01 at 17:51 +0200, Julia Lawall wrote: The file arch/powerpc/platforms/cell/celleb_scc_uhc.c contains the following function: static inline int uhc_clkctrl_ready(u32 val) { const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBCEN; return((val mask) == mask); } The

[PATCH 05/11] arch/powerpc: Remove pr_level uses of KERN_level

2010-09-11 Thread Joe Perches
Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/kvm/emulate.c |4 ++-- arch/powerpc/sysdev/pmi.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c index 4568ec3..b83ba58 100644 --- a/arch/powerpc/kvm

[PATCH 11/11] sound: Remove pr_level uses of KERN_level

2010-09-11 Thread Joe Perches
Signed-off-by: Joe Perches j...@perches.com --- sound/ppc/snd_ps3.c |2 +- sound/soc/s3c24xx/s3c-dma.c |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c index 2f12da4..581a670 100644 --- a/sound/ppc/snd_ps3.c +++ b

[PATCH 00/11] treewide: Remove pr_level uses with KERN_level

2010-09-11 Thread Joe Perches
Most of these are pr_debug(KERN_foo. pr_level(KERN_level is unnecessary. Joe Perches (11): arch/arm: Remove pr_level uses of KERN_level arch/avr32: Remove pr_level uses of KERN_level arch/microblaze: Remove pr_level uses of KERN_level arch/mips: Remove pr_level uses of KERN_level arch

[PATCH 02/25] arch/powerpc: Use static const char arrays

2010-09-13 Thread Joe Perches
Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/boot/addnote.c|4 ++-- arch/powerpc/boot/cuboot-c2k.c |4 ++-- arch/powerpc/kernel/irq.c |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/boot/addnote.c b/arch/powerpc/boot

[PATCH 04/25] drivers/char: Use static const char arrays

2010-09-13 Thread Joe Perches
Signed-off-by: Joe Perches j...@perches.com --- drivers/char/hvc_vio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/hvc_vio.c b/drivers/char/hvc_vio.c index 27370e9..5e2f52b 100644 --- a/drivers/char/hvc_vio.c +++ b/drivers/char/hvc_vio.c @@ -39,7 +39,7

[PATCH 00/25] treewide-next: Use static const char arrays

2010-09-13 Thread Joe Perches
)]; ... sprintf(foo, bar%c, value + '0'); Joe Perches (25): arch/mips: Use static const char arrays arch/powerpc: Use static const char arrays drivers/acpi: Use static const char arrays drivers/char: Use static const char arrays drivers/i2c: Use static const char arrays drivers/isdn: Use static

[PATCH] include/asm-powerpc/: Spelling fixes

2007-12-17 Thread Joe Perches
Signed-off-by: Joe Perches [EMAIL PROTECTED] --- include/asm-powerpc/8xx_immap.h |2 +- include/asm-powerpc/commproc.h|2 +- include/asm-powerpc/iseries/hv_lp_event.h |2 +- include/asm-powerpc/reg_booke.h |2 +- include/asm-powerpc/smu.h

[PATCH] arch/ppc/: Spelling fixes

2007-12-17 Thread Joe Perches
Signed-off-by: Joe Perches [EMAIL PROTECTED] --- arch/ppc/syslib/ppc8xx_pic.c |2 +- arch/ppc/syslib/ppc_sys.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/ppc/syslib/ppc8xx_pic.c b/arch/ppc/syslib/ppc8xx_pic.c index e8619c7..bce9a75 100644 --- a/arch/ppc

[PATCH] arch/powerpc/: Spelling fixes

2007-12-17 Thread Joe Perches
Signed-off-by: Joe Perches [EMAIL PROTECTED] --- arch/powerpc/boot/4xx.c |2 +- arch/powerpc/kernel/legacy_serial.c |2 +- arch/powerpc/sysdev/bestcomm/bestcomm.h |2 +- arch/powerpc/sysdev/mmio_nvram.c|2 +- 4 files changed, 4 insertions(+), 4

[PATCH] include/asm-ppc/: Spelling fixes

2007-12-17 Thread Joe Perches
Signed-off-by: Joe Perches [EMAIL PROTECTED] --- include/asm-ppc/8xx_immap.h |2 +- include/asm-ppc/commproc.h |2 +- include/asm-ppc/reg_booke.h |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/asm-ppc/8xx_immap.h b/include/asm-ppc/8xx_immap.h index

[PATCH] drivers/usb/: Spelling fixes

2007-12-17 Thread Joe Perches
Signed-off-by: Joe Perches [EMAIL PROTECTED] --- drivers/usb/atm/ueagle-atm.c|2 +- drivers/usb/class/cdc-acm.c |2 +- drivers/usb/gadget/at91_udc.h |2 +- drivers/usb/gadget/fsl_usb2_udc.c |2 +- drivers/usb/gadget/omap_udc.c |2 +- drivers/usb

Re: [PATCH] arch/ppc/: Spelling fixes

2007-12-17 Thread Joe Perches
On Mon, 2007-12-17 at 23:42 +0300, Vitaly Bordug wrote: I'm not really sure we should still care about typos in arch/ppc.. Fine by me. I heard tell of a desire to integrate or rework the power/ppc arches anyway. cheers, Joe ___ Linuxppc-dev mailing

Re: [PATCH] drivers/net/: Spelling fixes

2007-12-17 Thread Joe Perches
On Mon, 2007-12-17 at 21:56 +0100, Stefano Brivio wrote: On Mon, 17 Dec 2007 11:40:08 -0800 Joe Perches [EMAIL PROTECTED] wrote: diff --git a/drivers/net/ucc_geth_ethtool.c b/drivers/net/ucc_geth_ethtool.c index 9a9622c..f8d319b 100644 --- a/drivers/net/ucc_geth_ethtool.c +++ b/drivers

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-23 Thread Joe Perches
-by: Joe Perches [EMAIL PROTECTED] diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 579f50f..147e573 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1337,6 +1337,11 @@ sub process { } } +# Check for bitwise tests written

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-23 Thread Joe Perches
On Thu, 2008-01-24 at 01:18 +0100, Roel Kluin wrote: when you use git-grep -n \(\|||\)${s}0x\([A-Z0-9]*\|[a-z0-9]*\), (with s=[[:space:]]*) there will be false positives [] so i'd propose to change that to +# Check for bitwise tests written as boolean + if ($line =~

Re: [PATCH] hashtable: add hash_for_each_possible_rcu_notrace()

2013-07-22 Thread Joe Perches
On Tue, 2013-07-23 at 12:28 +1000, Alexey Kardashevskiy wrote: Anyone, ping. Is it good, bad, ugly (ack/nack)? Thanks! Is there any trivial patches list? Could not find it on vger. Jiri Kosina has triv...@kernel.org Also, there's kernel-janitors

Re: [PATCH] hashtable: add hash_for_each_possible_rcu_notrace()

2013-07-22 Thread Joe Perches
On Tue, 2013-07-23 at 12:43 +1000, Alexey Kardashevskiy wrote: On 07/23/2013 12:41 PM, Joe Perches wrote: On Tue, 2013-07-23 at 12:28 +1000, Alexey Kardashevskiy wrote: Anyone, ping. Is it good, bad, ugly (ack/nack)? Thanks! Is there any trivial patches list? Could not find it on vger

[PATCH 0/3] networking: Use ETH_ALEN where appropriate

2013-07-28 Thread Joe Perches
Convert the uses mac addresses to ETH_ALEN so it's easier to find and verify where mac addresses need to be __aligned(2) Joe Perches (3): uapi: Convert some uses of 6 to ETH_ALEN include: Convert ethernet mac address declarations to use ETH_ALEN ethernet: Convert mac address uses of 6

[PATCH 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN

2013-07-28 Thread Joe Perches
It's convenient to have ethernet mac addresses use ETH_ALEN to be able to grep for them a bit easier and also to ensure that the addresses are __aligned(2). Add #include linux/if_ether.h as necessary. Signed-off-by: Joe Perches j...@perches.com --- include/acpi/actbl2.h | 4

Re: [PATCH 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN

2013-07-29 Thread Joe Perches
On Mon, 2013-07-29 at 13:59 +0200, Rafael J. Wysocki wrote: On Sunday, July 28, 2013 10:29:04 PM Joe Perches wrote: It's convenient to have ethernet mac addresses use ETH_ALEN to be able to grep for them a bit easier and also to ensure that the addresses are __aligned(2). [] diff --git

[PATCH V2 0/3] networking: Use ETH_ALEN where appropriate

2013-08-01 Thread Joe Perches
Convert the uses mac addresses to ETH_ALEN so it's easier to find and verify where mac addresses need to be __aligned(2) Change from initial submission: - Remove include/acpi/actbl2.h conversion It's a file copied from outside ACPI sources Joe Perches (3): uapi: Convert some uses of 6

[PATCH V2 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN

2013-08-01 Thread Joe Perches
It's convenient to have ethernet mac addresses use ETH_ALEN to be able to grep for them a bit easier and also to ensure that the addresses are __aligned(2). Add #include linux/if_ether.h as necessary. Signed-off-by: Joe Perches j...@perches.com Acked-by: Mauro Carvalho Chehab m.che

[PATCH V3 0/3] networking: Use ETH_ALEN where appropriate

2013-08-01 Thread Joe Perches
) Just note that it's unaligned. Joe Perches (3): uapi: Convert some uses of 6 to ETH_ALEN include: Convert ethernet mac address declarations to use ETH_ALEN ethernet: Convert mac address uses of 6 to ETH_ALEN drivers/net/ethernet/8390/ax88796.c| 4 +- drivers/net

[PATCH V3 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN

2013-08-01 Thread Joe Perches
It's convenient to have ethernet mac addresses use ETH_ALEN to be able to grep for them a bit easier and also to ensure that the addresses are __aligned(2). Add #include linux/if_ether.h as necessary. Signed-off-by: Joe Perches j...@perches.com Acked-by: Mauro Carvalho Chehab m.che

[PATCH] hvc_xen: Remove unnecessary __GFP_ZERO from kzalloc

2013-08-29 Thread Joe Perches
kzalloc already adds this __GFP_ZERO. Signed-off-by: Joe Perches j...@perches.com --- drivers/tty/hvc/hvc_xen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c index 682210d..e61c36c 100644 --- a/drivers/tty/hvc

Re: [EDAC ABI v13 24/25] edac: change the mem allocation scheme to make Documentation/kobject.txt happy

2012-04-18 Thread Joe Perches
On Mon, 2012-04-16 at 17:38 -0300, Mauro Carvalho Chehab wrote: Kernel kobjects have rigid rules: each container object should be dynamically allocated, and can't be allocated into a single kmalloc. EDAC never obeyed this rule: it has a single malloc function that allocates all needed data

Re: [EDAC ABI v13 24/25] edac: change the mem allocation scheme to make Documentation/kobject.txt happy

2012-04-24 Thread Joe Perches
On Thu, 2012-04-19 at 10:14 -0300, Mauro Carvalho Chehab wrote: diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c [] @@ -296,7 +296,7 @@ struct mem_ctl_info *edac_mc_alloc(unsigned edac_index, /* * Alocate and fill the csrow/channels structs */ - mci-csrows

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-27 Thread Joe Perches
On Fri, 2012-04-27 at 15:33 +0200, Borislav Petkov wrote: this patch gives [8.278399] EDAC DEBUG: new_edac_mc_alloc: new_edac_mc_alloc: 0: dimm0 (0:0:0): row 0, chan 0 One too many __func__'s in some combination of the pr_fmt and/or dbg call and/or the actual call site? diff --git

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-28 Thread Joe Perches
On Sat, 2012-04-28 at 11:16 +0200, Borislav Petkov wrote: On Fri, Apr 27, 2012 at 02:52:35PM -0300, Mauro Carvalho Chehab wrote: All those local variables should be sorted in a reverse christmas tree order: u32 this_is_the_longest_array_name[LENGTH]; void

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-28 Thread Joe Perches
On Sat, 2012-04-28 at 10:52 +0200, Borislav Petkov wrote: On Fri, Apr 27, 2012 at 01:07:38PM -0300, Mauro Carvalho Chehab wrote: Yes. This is a common issue at the EDAC core: on several places, it calls the edac debug macros (DEBUGF0...DEBUGF4) passing a __func__ as an argument, while

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-04-29 Thread Joe Perches
On Sun, 2012-04-29 at 12:11 -0300, Mauro Carvalho Chehab wrote: Em 29-04-2012 11:25, Mauro Carvalho Chehab escreveu: Em 28-04-2012 05:52, Borislav Petkov escreveu: On Fri, Apr 27, 2012 at 01:07:38PM -0300, Mauro Carvalho Chehab wrote: Yes. This is a common issue at the EDAC core: on several

Re: [PATCH] gianfar:don't add FCB length to hard_header_len

2012-05-24 Thread Joe Perches
On Thu, 2012-05-24 at 17:04 +0200, Jan Ceuleers wrote: On 05/22/2012 09:18 PM, David Miller wrote: From: Jiajun Wu b06...@freescale.com Date: Tue, 22 May 2012 17:00:48 +0800 FCB(Frame Control Block) isn't the part of netdev hard header. Add FCB to hard_header_len will make GRO fail at

Re: [PATCH] gianfar:don't add FCB length to hard_header_len

2012-05-25 Thread Joe Perches
On Fri, 2012-05-25 at 11:58 -0400, Paul Gortmaker wrote: But you really shouldn't need the hardware to validate this kind of patch anyways -- aside from your code flow change in the irq routine of gianfar_ptp, you should have been simply able to check for object file equivalence before and

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Mon, 2012-07-09 at 10:09 -0700, Greg Kroah-Hartman wrote: is it ok if we just merge this in 3.6-rc1 and backport it to 3.5.1 if it looks ok there? I'd prefer it get accepted now so that refactoring the printk subsystem could occur for 3.6. Another option would be to revert all Kay's

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Sun, 2012-07-08 at 19:55 +0200, Kay Sievers wrote: At the same time the CPU#2 prints the same warning with a continuation line, but the buffer from CPU#1 can not be flushed to the console, nor can the continuation line printk()s from CPU#2 be merged at this point. The consoles are still

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Tue, 2012-07-10 at 00:10 +0200, Kay Sievers wrote: On Mon, Jul 9, 2012 at 11:42 PM, Joe Perches j...@perches.com wrote: On Sun, 2012-07-08 at 19:55 +0200, Kay Sievers wrote: At the same time the CPU#2 prints the same warning with a continuation line, but the buffer from CPU#1 can

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Tue, 2012-07-10 at 00:40 +0200, Kay Sievers wrote: On Tue, Jul 10, 2012 at 12:29 AM, Joe Perches j...@perches.com wrote: On Tue, 2012-07-10 at 00:10 +0200, Kay Sievers wrote: On Mon, Jul 9, 2012 at 11:42 PM, Joe Perches j...@perches.com wrote: On Sun, 2012-07-08 at 19:55 +0200, Kay

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Mon, 2012-07-09 at 16:32 -0700, Joe Perches wrote: Then you've changed semantics and I think you need to fix it. A dev_level call is not guaranteed to be a complete message. There are dev_level and netdev_level calls followed by pr_cont. Maybe these could be fixed up

Re: [PATCH v2 1/2] printk: Add function to return log buffer address and size

2014-07-31 Thread Joe Perches
On Thu, 2014-07-31 at 15:22 -0700, Andrew Morton wrote: Please include this in whatever tree carries powerpc/powernv: Interface to register/unregister opal dump region. At some point, I'd like to redo the patch series that breaks up printk.c into more manageable blocks.

[PATCH 1/2] powerpc: pci-ioda: Remove unnecessary return value from printk

2014-09-21 Thread Joe Perches
The return value is unnecessary and unused, so make the functions void instead of int. Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/platforms/powernv/pci-ioda.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c

[PATCH 0/2] powerpc: pci-ioda: Neatening

2014-09-21 Thread Joe Perches
printk calls should return void Joe Perches (2): powerpc: pci-ioda: Remove unnecessary return value from printk powerpc: pci-ioda: Use a single function to emit logging messages (compiled/untested) arch/powerpc/platforms/powernv/pci-ioda.c | 61 +++ 1 file

[PATCH 2/2] powerpc: pci-ioda: Use a single function to emit logging messages

2014-09-21 Thread Joe Perches
arch/powerpc/platforms/powernv/pci-ioda.o.new 2284011216776 307377811 arch/powerpc/platforms/powernv/pci-ioda.o.old Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/platforms/powernv/pci-ioda.c | 58 --- 1 file changed, 30 insertions(+), 28

[PATCH] tty: pr_warning-pr_warn and logging neatening

2014-11-09 Thread Joe Perches
Convert the pr_warning to the more common pr_warn. Other miscellanea: o Convert unusual PR_FMT define and uses to pr_fmt o Remove unnecessary OOM message o Fix grammar in an error message o Convert a pr_warning with a KERN_ERR to pr_err Signed-off-by: Joe Perches j...@perches.com --- drivers

[PATCH net-next] drivers:net: Remove unnecessary OOM messages after netdev_alloc_skb

2013-03-08 Thread Joe Perches
unused variable. Hoist assignment from if. Signed-off-by: Joe Perches j...@perches.com --- drivers/net/caif/caif_shmcore.c| 5 + drivers/net/ethernet/adi/bfin_mac.c| 6 ++ drivers/net/ethernet/amd/7990.c| 2 -- drivers/net/ethernet

[PATCH 0/3] freescale: Update logging style

2013-04-14 Thread Joe Perches
Convert various printk logging styles to current styles. Uncompiled, untested. Joe Perches (3): fec: Convert printks to netdev_level gianfar: Use netdev_level when possible ucc_geth: Convert ugeth_level to pr_level drivers/net/ethernet/freescale/fec_main.c | 26 +- drivers/net

[PATCH 1/3] fec: Convert printks to netdev_level

2013-04-14 Thread Joe Perches
Use a more current logging message style. Convert the printks where a struct net_device is available to netdev_level. Convert the other printks to pr_level and add pr_fmt where appropriate. Signed-off-by: Joe Perches j...@perches.com --- drivers/net/ethernet/freescale/fec_main.c| 26

[PATCH 2/3] gianfar: Use netdev_level when possible

2013-04-14 Thread Joe Perches
Use a more current logging style. Convert pr_level to netdev_level when a struct net_device is available. Add pr_fmt and neaten other formats too. Signed-off-by: Joe Perches j...@perches.com --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 24 +--- drivers/net

Re: [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff

2013-05-30 Thread Joe Perches
On Thu, 2013-05-30 at 15:07 +0800, liguang wrote: orderly_poweroff is expecting a bool parameter, so use 'ture' instead '1' [] diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c [] @@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log

[Trivial PATCH 00/33] Remove uses of typedef ctl_table

2013-06-13 Thread Joe Perches
It's clearer to use struct ctl_table instead Joe Perches (33): arm: kernel: isa: Convert use of typedef ctl_table to struct ctl_table frv: Convert use of typedef ctl_table to struct ctl_table ia64: crash: Convert use of typedef ctl_table to struct ctl_table mips: lasat: sysctl: Convert

[Trivial PATCH 05/33] powerpc: idle: Convert use of typedef ctl_table to struct ctl_table

2013-06-13 Thread Joe Perches
This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/kernel/idle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/idle.c b/arch/powerpc/kernel/idle.c index 939ea7e..d7216c9 100644

[Trivial PATCH 12/33] macintosh: Convert use of typedef ctl_table to struct ctl_table

2013-06-13 Thread Joe Perches
This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches j...@perches.com --- drivers/macintosh/mac_hid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c index 6a82388..80d30e8 100644

Re: [PATCH 25/45] staging/octeon: Use get/put_online_cpus_atomic() to prevent CPU offline

2013-06-23 Thread Joe Perches
On Mon, 2013-06-24 at 00:25 +0530, Srivatsa S. Bhat wrote: On 06/23/2013 11:47 PM, Greg Kroah-Hartman wrote: On Sun, Jun 23, 2013 at 07:13:33PM +0530, Srivatsa S. Bhat wrote: [] diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c [] Honestly, I don't

[RFC PATCH] Remove CONFIG_DCACHE_WORD_ACCESS

2014-03-04 Thread Joe Perches
defines uses. Signed-off-by: Joe Perches j...@perches.com --- arch/arm/Kconfig | 1 - arch/arm/include/asm/word-at-a-time.h | 4 ++-- arch/arm64/Kconfig| 1 - arch/x86/Kconfig | 1 - fs/Kconfig| 4 fs

rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread Joe Perches
(added some cc's) On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: From: Alistair Popple alist...@popple.id.au Date: Thu, 6 Mar 2014 14:52:25 +1100 + out_be32(dev-reg, in_be32(dev-reg) | WKUP_ETH_RGMIIEN +| WKUP_ETH_TX_OE | WKUP_ETH_RX_IE); When an expression spans

Re: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread Joe Perches
On Fri, 2014-03-07 at 13:30 -0800, j...@joshtriplett.org wrote: On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote: On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: From: Alistair Popple alist...@popple.id.au Date: Thu, 6 Mar 2014 14:52:25 +1100 + out_be32

Re: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread Joe Perches
On Sat, 2014-03-08 at 02:04 +0300, Dan Carpenter wrote: On Fri, Mar 07, 2014 at 01:30:17PM -0800, j...@joshtriplett.org wrote: On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote: On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: From: Alistair Popple alist...@popple.id.au

[PATCH] eeh_pseries: Missing break?

2014-03-07 Thread Joe Perches
Looks like this is unintentional as the result = EEH_STATE_UNAVAILABLE is being overwritten by EEH_STATE_NOT_SUPPORT in the fallthrough to the default case. --- diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c index 8a8f047..83da53f 100644

Re: [PATCH] eeh_pseries: Missing break?

2014-03-08 Thread Joe Perches
On Sun, 2014-03-09 at 00:16 +0800, Gavin Shan wrote: On Fri, Mar 07, 2014 at 04:31:32PM -0800, Joe Perches wrote: Looks like this is unintentional as the result = EEH_STATE_UNAVAILABLE is being overwritten by EEH_STATE_NOT_SUPPORT in the fallthrough to the default case. Thanks, Joe

[PATCH 0/5] Convert last few uses of __FUNCTION__ to __func__

2014-03-25 Thread Joe Perches
Outside of staging, there aren't any more uses of __FUNCTION__ now... Joe Perches (5): powerpc: Convert last uses of __FUNCTION__ to __func__ x86: Convert last uses of __FUNCTION__ to __func__ block: Convert last uses of __FUNCTION__ to __func__ i915: Convert last uses of __FUNCTION__

[PATCH 1/5] powerpc: Convert last uses of __FUNCTION__ to __func__

2014-03-25 Thread Joe Perches
Just about all of these have been converted to __func__, so convert the last uses. Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/platforms/pseries/nvram.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/pseries/nvram.c b/arch

Re: [RFC PATCH] Remove CONFIG_DCACHE_WORD_ACCESS

2014-03-25 Thread Joe Perches
On Wed, 2014-03-12 at 07:37 +1100, Benjamin Herrenschmidt wrote: On Tue, 2014-03-04 at 12:23 -0800, Joe Perches wrote: It seems to duplicate CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS so use that instead. This changes the !CPU_LITTLE_ENDIAN powerpc arch to use unaligned accesses in fs

Re: [PATCH 11/16] byteorder: provide a linux/byteorder.h with {be,le}_to_cpu() and cpu_to_{be,le}() macros

2014-05-27 Thread Joe Perches
On Tue, 2014-05-27 at 17:22 -0700, Cody P Schafer wrote: Rather manually specifying the size of the integer to be converted, key off of the type size. Reduces duplicate size info and the occurance of certain types of bugs (using the wrong sized conversion). [] diff --git

Re: [PATCH 11/16] byteorder: provide a linux/byteorder.h with {be, le}_to_cpu() and cpu_to_{be, le}() macros

2014-05-28 Thread Joe Perches
On Wed, 2014-05-28 at 17:11 -0500, Cody P Schafer wrote: On Wed, May 28, 2014 at 5:05 PM, Cody P Schafer d...@codyps.com wrote: On Wed, May 28, 2014 at 3:45 AM, David Laight david.lai...@aculab.com wrote: From: Cody P Schafer Rather manually specifying the size of the integer to be

[PATCH -next 01/26] powerpc: Use dma_zalloc_coherent

2014-06-15 Thread Joe Perches
Use the zeroing function instead of dma_alloc_coherent memset(,0,) Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/platforms/pasemi/dma_lib.c | 8 +++- arch/powerpc/sysdev/fsl_rmu.c | 9 - 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/arch

[PATCH -next 00/26] treewide: Use dma_zalloc_coherent

2014-06-15 Thread Joe Perches
Use the zeroing function instead of dma_alloc_coherent memset(,0,) Joe Perches (26): powerpc: Use dma_zalloc_coherent sh: Use dma_zalloc_coherent ata: Use dma_zalloc_coherent block: Use dma_zalloc_coherent crypto: Use dma_zalloc_coherent dma: Use dma_zalloc_coherent gpu: Use

[PATCH -next 26/26] sound: Use dma_zalloc_coherent

2014-06-15 Thread Joe Perches
Use the zeroing function instead of dma_alloc_coherent memset(,0,) Signed-off-by: Joe Perches j...@perches.com --- sound/aoa/soundbus/i2sbus/core.c | 12 sound/sparc/dbri.c | 6 ++ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/sound/aoa/soundbus

[PATCH net-next] net:drivers/net: Miscellaneous conversions to ETH_ALEN

2013-10-01 Thread Joe Perches
Convert the memset/memcpy uses of 6 to ETH_ALEN where appropriate. Also convert some struct definitions and u8 array declarations of [6] to ETH_ALEN. Signed-off-by: Joe Perches j...@perches.com --- drivers/net/ethernet/8390/ax88796.c| 2 +- drivers/net/ethernet/amd/atarilance.c

[PATCH 0/8] treewide: Remove OOM message after input_alloc_device

2013-10-23 Thread Joe Perches
Joe Perches (8): Documentation: Remove OOM message after input_allocate_device cell: Remove OOM message after input_allocate_device hid: Remove OOM message after input_allocate_device input: Remove OOM message after input_allocate_device media: Remove OOM message after

[PATCH 2/8] cell: Remove OOM message after input_allocate_device

2013-10-23 Thread Joe Perches
Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done. Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/platforms/cell/cbe_powerbutton.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/platforms/cell

Re: [PATCH] ibmveth: Fix more little endian issues

2013-12-23 Thread Joe Perches
On Mon, 2013-12-23 at 17:38 +1100, Anton Blanchard wrote: The hypervisor expects MAC addresses passed in registers to be big endian u64. So maybe use __be64 declarations? +static unsigned long ibmveth_encode_mac_addr(char *mac) static __be64 ibmveth_encode_mac_addr(const char *mac) ?

Re: [PATCH 1/1] Fixed some coding style problems

2014-01-27 Thread Joe Perches
On Mon, 2014-01-27 at 19:43 -0600, Brandon Stewart wrote: [] diff --git a/drivers/macintosh/adb.c b/drivers/macintosh/adb.c [] @@ -624,8 +623,7 @@ do_adb_query(struct adb_request *req) { int ret = -EINVAL; - switch(req-data[1]) - { + switch(req-data[1]) {

[PATCH] powerpc: numa: Fix decimal permissions

2014-01-28 Thread Joe Perches
This should have been octal. Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/mm/numa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index 86a63de..30a42e2 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm

Re: [PATCH v2 6/6] cpu/idle.c: move to sched/idle.c

2014-01-30 Thread Joe Perches
On Thu, 2014-01-30 at 17:27 +0100, Peter Zijlstra wrote: On Thu, Jan 30, 2014 at 11:03:31AM -0500, Nicolas Pitre wrote: This is not a valid patch for PATCH(1). Please try again. Don't you use git? ;-) Nah, git and me don't get along well. Perhaps you could use a newer version of

[PATCH 3/9] drivers/net: typo fix of faild to failed

2010-10-21 Thread Joe Perches
Signed-off-by: Joe Perches j...@perches.com --- drivers/net/ps3_gelic_net.c |4 ++-- drivers/net/tulip/pnic2.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ps3_gelic_net.c b/drivers/net/ps3_gelic_net.c index 87d6b8f..49f6700 100644 --- a/drivers/net

[PATCH 0/9] Typo fixes of faild to failed

2010-10-21 Thread Joe Perches
Joe Perches (9): drivers/ata: typo fix of faild to failed drivers/gpu: typo fix of faild to failed drivers/net: typo fix of faild to failed drivers/rtc: typo fix of faild to failed drivers/video: typo fix of faild to failed fs/exofs: typo fix of faild to failed fs/jfs: typo fix

  1   2   3   4   >