Re: PCIE device errors after linux kernel upgrade

2013-08-06 Thread Johannes Thumshirn
On Mon, Aug 05, 2013 at 09:38:45AM -0600, Bjorn Helgaas wrote: [+cc linuxppc-dev] On Mon, Aug 5, 2013 at 5:17 AM, Leon Ravich lrav...@gmail.com wrote: Hi all , I am trying to upgrade ours embedded device (freescale powerPC P2020 cpu) linux kernel , till now we used 2.6.32 I am trying to

Re: PCIE device errors after linux kernel upgrade

2013-08-06 Thread Johannes Thumshirn
just a reboot without panic, could there be a watchdog resetting the board? On 6 August 2013 10:07, Johannes Thumshirn johannes.thumsh...@men.de wrote: On Mon, Aug 05, 2013 at 09:38:45AM -0600, Bjorn Helgaas wrote: [+cc linuxppc-dev] On Mon, Aug 5, 2013 at 5:17 AM, Leon Ravich lrav

Handling of multiple MSI Vecotrs on Freescale P1022

2014-10-28 Thread Johannes Thumshirn
Hi, I've a question regarding the handling of multiple MSI Vectors on a Freescale P1022. In arch_setup_msi_irqs (arch/powerpc/kernel/msi.c) there is a comment that PowerPC doesn't support multiple MSI yet. What is the reason for this comment and is there anything I can do to enable multiple MSI

FSL MSI Mapping

2014-10-28 Thread Johannes Thumshirn
Hi, I got notified about your patch to support multiple MSI Vectors on Freescale PowerPC platforms. Is there any reason why it wasn't applied until now? I couldn't find anything about it in the list archives. I think it would be a real benefit for all to have multiple MSI vecotrs on PowerPCs.

Re: FSL MSI Mapping

2014-10-29 Thread Johannes Thumshirn
On Tue, Oct 28, 2014 at 02:10:18PM -0500, Scott Wood wrote: On Tue, 2014-10-28 at 18:06 +0100, Johannes Thumshirn wrote: Hi, I got notified about your patch to support multiple MSI Vectors on Freescale PowerPC platforms. Is there any reason why it wasn't applied until now? I couldn't

Re: FSL MSI Mapping

2014-10-30 Thread Johannes Thumshirn
On Thu, Oct 30, 2014 at 02:51:57PM +1100, Michael Ellerman wrote: On Tue, 2014-10-28 at 18:06 +0100, Johannes Thumshirn wrote: Hi, I got notified about your patch to support multiple MSI Vectors on Freescale PowerPC platforms. Is there any reason why it wasn't applied until now? I

Re: FSL MSI Mapping

2014-10-31 Thread Johannes Thumshirn
On Thu, Oct 30, 2014 at 02:51:57PM +1100, Michael Ellerman wrote: On Tue, 2014-10-28 at 18:06 +0100, Johannes Thumshirn wrote: Hi, I got notified about your patch to support multiple MSI Vectors on Freescale PowerPC platforms. Is there any reason why it wasn't applied until now? I

[PATCH 1/2] irqdomain: add support for creating a continous mapping

2014-11-03 Thread Johannes Thumshirn
on irq_create_mapping() but due to the number argument there is very little in common now. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de Signed-off-by: Johannes Thumshirn johannes.thumsh...@men.de --- include/linux/irqdomain.h | 10 -- kernel/irq/irqdomain.c| 85

[PATCH 2/2] powerpc: msi: fsl: add support for multiple MSI interrupts

2014-11-03 Thread Johannes Thumshirn
This patch pushes the check for nvec 1 MSI into the check function of each MSI driver except for FSL's MSI where the functionality is added. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de Signed-off-by: Johannes Thumshirn johannes.thumsh...@men.de --- arch/powerpc/kernel/msi.c

[PATCH 0/2] Support multiple MSI interrupts on FSL-MPIC

2014-11-03 Thread Johannes Thumshirn
of cause change it immediately. It was just convenient to use my name in the git commit but I don't want to do any kind of copyright infrigement. Johannes Thumshirn (2): irqdomain: add support for creating a continous mapping powerpc: msi: fsl: add support for multiple MSI interrupts arch/powerpc

Re: [PATCH 1/2] irqdomain: add support for creating a continous mapping

2014-11-05 Thread Johannes Thumshirn
On Mon, Nov 03, 2014 at 04:18:51PM -0600, Scott Wood wrote: On Mon, 2014-11-03 at 17:18 +0100, Johannes Thumshirn wrote: A MSI device may have multiple interrupts. That means that the interrupts numbers should be continuos so that pdev-irq refers to the first interrupt, pdev-irq + 1

Re: EDAC PCIe errors when scannning the bus

2014-03-19 Thread Johannes Thumshirn
On Wed, Mar 19, 2014 at 01:46:37PM +0100, Valentin Longchamp wrote: Hello, We have a board that is based on Freescale's P2041 SoC. The boards has 2 PCIe buses with this topology: PCIe 0 --- PEX8505 switch --- 4 network devices PCIE 2 --- FPGA On 3.10.33 + a subset of the Freescale SDK 1.4

Re: [PATCH] powerpc: 85xx: EDAC PCI: request irq as IRQF_SHARED

2014-01-20 Thread Johannes Thumshirn
On Mon, Jan 20, 2014 at 04:56:15PM +0800, Tiejun Chen wrote: AER driver needs to share this PCI err irq with EDAC, otherwise we can't register AER driver successfully as follows: genirq: Flags mismatch irq 482. 0080 (aerdrv) vs. 0020 ([EDAC] PCI err) CPU: 3 PID: 1 Comm: swapper/0

[PATCH] cxl: Destroy cxl_adapter_idr on module_exit

2015-07-08 Thread Johannes Thumshirn
, defines_module_exit.exit; @@ exit(void) { ... idr_destroy(idr); ... } @ missing_module_idr_destroy depends on declares_idr defines_module_exit !on_exit_calls_destroy @ identifier declares_idr.idr, defines_module_exit.exit; @@ exit(void) { ... +idr_destroy(idr); } /SmPL Signed-off-by: Johannes Thumshirn

Re: [PATCH] cxl: Destroy cxl_adapter_idr on module_exit

2015-07-09 Thread Johannes Thumshirn
. -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg

[PATCH] cxl: Destroy afu-contexts_idr on release of an afu

2015-07-09 Thread Johannes Thumshirn
Destroy afu-contexts_idr on release of an afu, reclaiming the allocated memory. Signed-off-by: Johannes Thumshirn jthumsh...@suse.de --- drivers/misc/cxl/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c index c68ef58..16b8e75a 100644

Re: [PATCH v2] EDAC, mpc85xx: Make mpc85xx-pci-edac a platform device

2015-12-09 Thread Johannes Thumshirn
> on boot. > > To fix this, the PCI controller code now creates a child platform > device specifically for EDAC, which the mpc85xx-pci-edac driver binds > to. > > Signed-off-by: Scott Wood <scottw...@freescale.com> > Cc: Jia Hongtao <b38...@freescale.com> > Cc

Re: [PATCH v3] EDAC, mpc85xx: Make mpc85xx-pci-edac a platform device

2015-12-11 Thread Johannes Thumshirn
> on boot. > > To fix this, the PCI controller code now creates a child platform > device specifically for EDAC, which the mpc85xx-pci-edac driver binds > to. > > Signed-off-by: Scott Wood <scottw...@freescale.com> > Cc: Jia Hongtao <b38...@freescale.com> >

Re: [PATCH 5/6] ibmvscsi: Remove unsupported host config MAD and sysfs interface

2016-02-05 Thread Johannes Thumshirn
On Thu, Feb 04, 2016 at 09:48:23AM -0800, Tyrel Datwyler wrote: > On 02/04/2016 12:03 AM, Johannes Thumshirn wrote: > > On Wed, Feb 03, 2016 at 05:28:33PM -0600, Tyrel Datwyler wrote: > >> A VIOSRP_HOST_CONFIG_TYPE management datagram (MAD) has existed in > >> the co

Re: [PATCH v2 5/7] ibmvscsi: Remove unsupported host config MAD

2016-02-11 Thread Johannes Thumshirn
the same returning nothing. > > Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74

Re: [PATCH v2 7/7] ibmvscsi: use H_CLOSED instead of magic number

2016-02-11 Thread Johannes Thumshirn
On Wed, Feb 10, 2016 at 07:32:28PM -0600, Tyrel Datwyler wrote: > In a couple places the magic value of 2 is used to check the return > code of hypercalls. This translates to H_CLOSED. > > Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> Reviewed-by: Johannes

Re: [PATCH v2 2/7] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-11 Thread Johannes Thumshirn
@linux.vnet.ibm.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithar

Re: [PATCH] ibmvfc: byteswap scsi_id, wwpn, and node_name prior to logging

2016-02-12 Thread Johannes Thumshirn
ead byteswap these values to host endian prior to logging. > > Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH 1/6] ibmvscsi: Correct values for several viosrp_crq_format enums

2016-02-04 Thread Johannes Thumshirn
SRP_LINUX_FORMAT = 0x05, > + VIOSRP_INLINE_FORMAT = 0x06 > }; > > enum viosrp_crq_status { > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org >

Re: [PATCH 6/6] ibmvscsi: Add endian conversions to sysfs attribute show functions

2016-02-04 Thread Johannes Thumshirn
n = snprintf(buf, PAGE_SIZE, "%d\n", > +be32_to_cpu(hostdata->madapter_info.os_type)); > return len; > } > > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubs

Re: [PATCH 4/6] ibmvscsi: Use of_root to access OF device tree root node

2016-02-04 Thread Johannes Thumshirn
e_put(rootdn); > + of_node_put(of_root); > } > > static void set_adapter_info(struct ibmvscsi_host_data *hostdata) > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.ke

Re: [PATCH 5/6] ibmvscsi: Remove unsupported host config MAD and sysfs interface

2016-02-04 Thread Johannes Thumshirn
VIOS, which is no longer supported anywhere. Further, it is > not defined in PAPR or supported by any AIX based VIOS. > > Treating as bit rot and removing the sysfs interface and associated > host config code accordingly. Doesn't removing a sysfs interface potentially break userspace code?

Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-04 Thread Johannes Thumshirn
vscsi/viosrp.h > +++ b/drivers/scsi/ibmvscsi/viosrp.h > @@ -51,6 +51,13 @@ union srp_iu { > u8 reserved[SRP_MAX_IU_LEN]; > }; > > +enum viosrp_crq_headers { > + VIOSRP_CRQ_FREE = 0x00, > + VIOSRP_CRQ_VALID = 0x80, > + VIOSRP_CRQ_INIT = 0xC0, > +

Re: [PATCH 3/6] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-04 Thread Johannes Thumshirn
56 > #define SRP_MAX_LOC_LEN 32 > +#define SRP_MAD_VERSION_1 1 > +#define SRP_MAD_OS_LINUX 2 > > union srp_iu { > struct srp_login_req login_req; > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in &

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-17 Thread Johannes Thumshirn
ed the defines to the mad_adapter_info_data structure around > Tyrel> the fields they apply. > > Johannes: Mind checking this out? I'm sorry I though I already did. Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> > > https://patchwork.kernel.org/patch/8276101/ >

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-05 Thread Johannes Thumshirn
nctions... I can give it a shot, but I don't have too much spare time atm and no hardware to test, so it'll have a strong RFC smell attached to it. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 7

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-10-14 Thread Johannes Thumshirn
ing job->request as req->cmd and job->request_len = req->cmd_len. But without checkinf job->request_len we don't know whether we're save to touch job->request (a.k.a. bsg_request). In the meanwhile I try to reproduce your report here. Thanks, Johannes -- Johannes Thumshirn

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-10-25 Thread Johannes Thumshirn
On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote: > On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote: > > Hm, still behaves for me like I reported for v2: > > http://marc.info/?l=linux-scsi=147637177902937=2 > > Hi Steffen, > > Can y

[PATCH v4 03/15] scsi: fc: Export fc_bsg_jobdone and use it in FC drivers

2016-11-17 Thread Johannes Thumshirn
remove the function pointer from struct fc_bsg_job as well. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> Reviewed-by: Christoph Hellwig <h...@lst.de> Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- dri

[PATCH v4 05/15] scsi: fc: provide fc_bsg_to_rport() helper

2016-11-17 Thread Johannes Thumshirn
Provide fc_bsg_to_rport() helper that will become handy when we're moving from struct fc_bsg_job to a plain struct bsg_job. Also move all LLDDs to use the new helper. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> Acked-by: Tyrel D

[PATCH v4 02/15] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-11-17 Thread Johannes Thumshirn
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use helper variables bsg_request and bsg_reply. This will be helpfull when transitioning to bsg-lib. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drive

[PATCH v4 09/15] scsi: change FC drivers to use 'struct bsg_job'

2016-11-17 Thread Johannes Thumshirn
Change FC drivers to use 'struct bsg_job' from bsg-lib.h instead of 'struct fc_bsg_job' from scsi_transport_fc.h and remove 'struct fc_bsg_job'. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> Acked-by: Tyrel Datwyler <tyr...@lin

[PATCH v4 04/15] scsi: fc: provide fc_bsg_to_shost() helper

2016-11-17 Thread Johannes Thumshirn
Provide fc_bsg_to_shost() helper that will become handy when we're moving from struct fc_bsg_job to a plain struct bsg_job. Also use this little helper in the LLDDs. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> Acked-by: Tyrel D

[PATCH v4 12/15] scsi: fc: use bsg_job_done

2016-11-17 Thread Johannes Thumshirn
fc_bsg_jobdone() and bsg_job_done() are 1:1 copies now so use the bsg-lib one instead of the FC private implementation. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> ---

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-11-15 Thread Johannes Thumshirn
On Tue, Nov 15, 2016 at 03:31:27PM +0100, Steffen Maier wrote: > Hi Johannes, > > On 11/15/2016 12:56 PM, Johannes Thumshirn wrote: > > On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote: > > > On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wr

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-11-15 Thread Johannes Thumshirn
On Tue, Nov 15, 2016 at 03:31:27PM +0100, Steffen Maier wrote: > Hi Johannes, > > On 11/15/2016 12:56 PM, Johannes Thumshirn wrote: > > On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote: > > > On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wr

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-11-16 Thread Johannes Thumshirn
On Tue, Nov 15, 2016 at 04:39:33PM +0100, Johannes Thumshirn wrote: > On Tue, Nov 15, 2016 at 03:31:27PM +0100, Steffen Maier wrote: > > Hi Johannes, > > > > On 11/15/2016 12:56 PM, Johannes Thumshirn wrote: > > > On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes T

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-11-15 Thread Johannes Thumshirn
On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote: > On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote: > > On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote: > > > Hm, still behaves for me like I reported for v2: > > > htt

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-11-03 Thread Johannes Thumshirn
On Thu, Nov 03, 2016 at 08:17:51AM -0700, Christoph Hellwig wrote: > On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote: > > On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote: > > > Hm, still behaves for me like I reported for v2: > > > htt

Re: [PATCH v2 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-10-30 Thread Johannes Thumshirn
ere bsg_reply is NULL. > The assignment tries to write to memory at address NULL causing the kernel > page fault. > > Does your suggested change for [PATCH v3 02/16], shuffling the > job->request_len checks, address above kernel page fault? This is what I hope at least. I'm s

[PATCH 41/44] scsi: fc: use bsg_job_done

2016-10-11 Thread Johannes Thumshirn
fc_bsg_jobdone() and bsg_job_done() are 1:1 copies now so use the bsg-lib one instead of the FC private implementation. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s390/scsi/zfcp_fc.c | 2 +- drivers/scsi/bfa/bfad_bsg.c | 4 ++-- drivers/scsi/ibmvscsi/ib

[PATCH 32/44] ibmvfc: use fc_bsg_to_rport() to access a bsg_job's rport

2016-10-11 Thread Johannes Thumshirn
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/ibmvscsi/ibmvfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index f7b50af..35114d9 100644 --- a/drivers/scsi/ibmvscsi/ibmvfc.c

[PATCH 24/44] ibmvfc: use fc_bsg_to_shost() to access a bsg_job's Scsi_Host

2016-10-11 Thread Johannes Thumshirn
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/ibmvscsi/ibmvfc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index 1001d4a..f7b50af 100644 --- a/drivers/scsi/ibmvscsi/ib

[PATCH 12/44] ibmvfc: Use fc_bsg_jobdone()

2016-10-11 Thread Johannes Thumshirn
Use fc_bsg_jobdone() directly instead of the struct bsg_job::job_done() callback. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/ibmvscsi/ibmvfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ib

[PATCH 36/44] scsi: change FC drivers to use 'struct bsg_job'

2016-10-11 Thread Johannes Thumshirn
Change FC drivers to use 'struct bsg_job' from bsg-lib.h instead of 'struct fc_bsg_job' from scsi_transport_fc.h and remove 'struct fc_bsg_job'. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s390/scsi/zfcp_fc.c | 15 drivers/scsi/bfa/bfad_bsg.c

[PATCH 04/44] ibmvfc: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-10-11 Thread Johannes Thumshirn
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use helper variables bsg_request and bsg_reply. This will be helpfull when transitioning to bsg-lib. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/ibmvscsi/ibmvfc.c | 22 --

[PATCH 17/44] scsi: Unify interfaces of fc_bsg_jobdone and bsg_job_done

2016-10-11 Thread Johannes Thumshirn
Unify the interfaces of fc_bsg_jobdone and bsg_job_done. This will reduce the diff when moving from 'struct fc_bsg_job' to a plain 'struct bsg_job' later on. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s390/scsi/zfcp_fc.c | 2 +- drivers/scsi/bfa/bfad_bsg.c

[PATCH v3 03/16] scsi: fc: Export fc_bsg_jobdone and use it in FC drivers

2016-10-13 Thread Johannes Thumshirn
-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drivers/s390/scsi/zfcp_fc.c | 2 +- drivers/scsi/bfa/bfad_bsg.c | 4 ++-- drivers/scsi/ibmvscsi/ibmvfc.c | 2 +- drivers/scsi/libfc/fc_lport.c| 4 ++-- drivers/scsi/lpfc/lpfc_bs

[PATCH v3 05/16] scsi: fc: provide fc_bsg_to_shost() helper

2016-10-13 Thread Johannes Thumshirn
Provide fc_bsg_to_shost() helper that will become handy when we're moving from struct fc_bsg_job to a plain struct bsg_job. Also use this little helper in the LLDDs. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drive

[PATCH v3 04/16] scsi: Unify interfaces of fc_bsg_jobdone and bsg_job_done

2016-10-13 Thread Johannes Thumshirn
Unify the interfaces of fc_bsg_jobdone and bsg_job_done. This will reduce the diff when moving from 'struct fc_bsg_job' to a plain 'struct bsg_job' later on. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drivers/s390/sc

[PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-10-13 Thread Johannes Thumshirn
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use helper variables bsg_request and bsg_reply. This will be helpfull when transitioning to bsg-lib. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drive

[PATCH v3 06/16] scsi: fc: provide fc_bsg_to_rport() helper

2016-10-13 Thread Johannes Thumshirn
Provide fc_bsg_to_rport() helper that will become handy when we're moving from struct fc_bsg_job to a plain struct bsg_job. Also move all LLDDs to use the new helper. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drive

[PATCH v3 10/16] scsi: change FC drivers to use 'struct bsg_job'

2016-10-13 Thread Johannes Thumshirn
Change FC drivers to use 'struct bsg_job' from bsg-lib.h instead of 'struct fc_bsg_job' from scsi_transport_fc.h and remove 'struct fc_bsg_job'. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drivers/s390/scsi/zfcp_ex

[PATCH v3 13/16] scsi: fc: use bsg_job_done

2016-10-13 Thread Johannes Thumshirn
fc_bsg_jobdone() and bsg_job_done() are 1:1 copies now so use the bsg-lib one instead of the FC private implementation. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drivers/s390/scsi/zfcp_fc.c | 2 +- drivers/scsi/bf

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-10-13 Thread Johannes Thumshirn
On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote: > Hm, still behaves for me like I reported for v2: > http://marc.info/?l=linux-scsi=147637177902937=2 > Well given what you've wrote for v2 it's kinda expected. Byte, Johannes -- Johannes

Re: [PATCH v2 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-10-13 Thread Johannes Thumshirn
rid of struct > fc_bsg_buffer > > $ git bisect good > > 3087864ce3d7282f59021245d8a5f83ef1caef18 is the first bad commit > > commit 3087864ce3d7282f59021245d8a5f83ef1caef18 > > Author: Johannes Thumshirn <jthumsh...@suse.de> > > Date: Wed Oct 12 15:06:28 2016 +0200 > > > >

[PATCH v2 13/16] scsi: fc: use bsg_job_done

2016-10-12 Thread Johannes Thumshirn
fc_bsg_jobdone() and bsg_job_done() are 1:1 copies now so use the bsg-lib one instead of the FC private implementation. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s390/scsi/zfcp_fc.c | 2 +- drivers/scsi/bfa/bfad_bsg.c | 4 ++-- drivers/scsi/ibmvscsi/ib

[PATCH v2 05/16] scsi: fc: provide fc_bsg_to_shost() helper

2016-10-12 Thread Johannes Thumshirn
Provide fc_bsg_to_shost() helper that will become handy when we're moving from struct fc_bsg_job to a plain struct bsg_job. Also use this little helper in the LLDDs. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s390/scsi/zfcp_fc.c | 4 +-- drivers/scsi/bfa/bfad

[PATCH v2 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-10-12 Thread Johannes Thumshirn
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use helper variables bsg_request and bsg_reply. This will be helpfull when transitioning to bsg-lib. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s390/scsi/zfcp_fc.c | 9 +- drivers/sc

[PATCH v2 10/16] scsi: change FC drivers to use 'struct bsg_job'

2016-10-12 Thread Johannes Thumshirn
Change FC drivers to use 'struct bsg_job' from bsg-lib.h instead of 'struct fc_bsg_job' from scsi_transport_fc.h and remove 'struct fc_bsg_job'. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s390/scsi/zfcp_ext.h | 4 +-- drivers/s390/scsi/zfcp_fc.c

[PATCH v2 04/16] scsi: Unify interfaces of fc_bsg_jobdone and bsg_job_done

2016-10-12 Thread Johannes Thumshirn
Unify the interfaces of fc_bsg_jobdone and bsg_job_done. This will reduce the diff when moving from 'struct fc_bsg_job' to a plain 'struct bsg_job' later on. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s390/scsi/zfcp_fc.c | 2 +- drivers/scsi/bfa/bfad_bsg.c

[PATCH v2 03/16] scsi: fc: Export fc_bsg_jobdone and use it in FC drivers

2016-10-12 Thread Johannes Thumshirn
-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s390/scsi/zfcp_fc.c | 2 +- drivers/scsi/bfa/bfad_bsg.c | 4 ++-- drivers/scsi/ibmvscsi/ibmvfc.c | 2 +- drivers/scsi/libfc/fc_lport.c| 4 ++-- drivers/scsi/lpfc/lpfc_bsg.c | 38 +- d

[PATCH v2 06/16] scsi: fc: provide fc_bsg_to_rport() helper

2016-10-12 Thread Johannes Thumshirn
Provide fc_bsg_to_rport() helper that will become handy when we're moving from struct fc_bsg_job to a plain struct bsg_job. Also move all LLDDs to use the new helper. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s390/scsi/zfcp_fc.c | 5 +++-- drivers/scsi/ib

Re: [PATCH] ibmvscsi: add write memory barrier to CRQ processing

2016-12-08 Thread Johannes Thumshirn
> done = 1; > } Is this something you have seen in the wild or just a "better save than sorry" barrier? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH 2/2] ibmvscsi: log bad SRP response opcode in hex format

2016-12-08 Thread Johannes Thumshirn
d-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> > --- Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Ma

Re: [PATCH 1/2] ibmvscsi: add vscsi hosts to global list_head

2016-12-08 Thread Johannes Thumshirn
; > Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> > --- Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE

Re: [PATCH] EDAC: mpc85xx: Add T2080 l2-cache support

2016-11-29 Thread Johannes Thumshirn
ham <chris.pack...@alliedtelesis.co.nz> > --- Looks good, Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Fe

Re: [PATCH 2/7] DAC960: don't use block layer bounce buffers

2018-05-09 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 1/7] mtip32xx: don't use block layer bounce buffers

2018-05-09 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH v3] watchdog: add SPDX identifiers for watchdog subsystem

2018-02-22 Thread Johannes Thumshirn
Marcus Folkesson <marcus.folkes...@gmail.com> writes: [...] > drivers/watchdog/mena21_wdt.c | 4 +-- For mena21_wdt: Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn Storage jth

Re: [PATCH v3] watchdog: add SPDX identifiers for watchdog subsystem

2018-02-21 Thread Johannes Thumshirn
ed-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-06 Thread Johannes Thumshirn
Acked-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key

Re: [PATCH 1/2] libnvdimm/altmap: Track namespace boundaries in altmap

2019-09-11 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nürnberg Germany (HRB 247165, AG München) Key

Re: [PATCH 2/9] compat.h: fix a spelling error in

2020-09-18 Thread Johannes Thumshirn
On 18/09/2020 14:48, Christoph Hellwig wrote: > We only have not compat_sys_readv64v2 syscall, only a We have no?

Re: [PATCH 3/9] fs: explicitly check for CHECK_IOVEC_ONLY in rw_copy_check_uvector

2020-09-18 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH] scsi: target/sbp: remove firewire SBP target driver

2020-06-16 Thread Johannes Thumshirn
On 16/06/2020 16:09, Bart Van Assche wrote: > On 2020-06-16 02:42, Finn Thain wrote: >> Martin said, "I'd appreciate a patch to remove it" >> >> And Bart said, "do you want to keep this driver in the kernel tree?" >> >> AFAICT both comments are quite ambiguous. I don't see an actionable >>

Re: [PATCH] bus: Make remove callback return void

2021-07-06 Thread Johannes Thumshirn
drivers/hid/intel-ish-hid/ishtp/bus.c | 4 +--- >> drivers/hv/vmbus_drv.c| 5 + >> drivers/hwtracing/intel_th/core.c | 4 +--- >> drivers/i2c/i2c-core-base.c | 5 + >> drivers/i3c/master.c | 4 +--- >> drivers/input/gameport/gameport.c | 3 +-- >> drivers/input/serio/serio.c | 3 +-- >> drivers/ipack/ipack.c | 4 +--- >> drivers/macintosh/macio_asic.c| 4 +--- >> drivers/mcb/mcb-core.c| 4 +--- Acked-by: Johannes Thumshirn # for drivers/mcb