[PATCH v2 0/2] drivers/crypto/nx: fixes when input data is too large

with Reviewed-By tags where it is appropriate. Marcelo Cerri (2): drivers/crypto/nx: fix physical addresses added to sg lists drivers/crypto/nx: fix limits to sg lists for SHA-2 drivers/crypto/nx/nx-sha256.c | 108 +++- drivers/crypto/nx/nx-sha512.c

[PATCH v2 1/2] drivers/crypto/nx: fix physical addresses added to sg lists

incrementing it even when a page boundary is crossed. This patch fixes this behaviour. Reviewed-by: Fionnuala Gunter f...@linux.vnet.ibm.com Reviewed-by: Joel Schopp jsch...@linux.vnet.ibm.com Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce

[PATCH v2 2/2] drivers/crypto/nx: fix limits to sg lists for SHA-2

Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-sha256.c | 108 +++- drivers/crypto/nx/nx-sha512.c | 113 -- 2 files changed, 129

[PATCH] crypto: nx - fix concurrency issue

locks to protect the data where a race condition can happen. Reviewed-by: Fionnuala Gunter f...@linux.vnet.ibm.com Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-cbc.c | 10 -- drivers/crypto/nx/nx

[PATCH 00/10] Series of fixes for NX driver

modes. - Fixes in how the driver handle zero length messages. This affects XCBC and GCM. - Fixes for SHA-2 when chunks bigger than the block size are provided. Fionnuala Gunter (2): crypto: nx - fix limits to sg lists for AES-XCBC crypto: nx - fix limits to sg lists for AES-CCM Marcelo

[PATCH 01/10] crypto: nx - add offset to nx_build_sg_lists()

Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-cbc.c | 2 +- drivers/crypto/nx/nx-aes-ccm.c | 4 ++-- drivers/crypto/nx/nx-aes-ctr.c | 2 +- drivers/crypto/nx/nx-aes-ecb.c | 2 +- drivers/crypto/nx/nx-aes-gcm.c | 2 +- drivers/crypto/nx/nx.c | 9

[PATCH 03/10] crypto: nx - fix limits to sg lists for AES-CBC

: - The total number of bytes that a scatter/gather list can hold. - The maximum number of elements that a scatter/gather list can have. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-cbc.c | 50

[PATCH 04/10] crypto: nx - fix limits to sg lists for AES-CTR

: - The total number of bytes that a scatter/gather list can hold. - The maximum number of elements that a scatter/gather list can have. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-ctr.c | 50

[PATCH 05/10] crypto: nx - fix limits to sg lists for AES-GCM

: - The total number of bytes that a scatter/gather list can hold. - The maximum number of elements that a scatter/gather list can have. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-gcm.c | 202

[PATCH 02/10] crypto: nx - fix limits to sg lists for AES-ECB

: - The total number of bytes that a scatter/gather list can hold. - The maximum number of elements that a scatter/gather list can have. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-ecb.c | 48

[PATCH 08/10] crypto: nx - fix XCBC for zero length messages

it with an implementation based on the RFC 3566 using ECB. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-xcbc.c | 84 + 1 file changed, 77 insertions(+), 7 deletions

[PATCH 06/10] crypto: nx - fix limits to sg lists for AES-XCBC

From: Fionnuala Gunter f...@linux.vnet.ibm.com This patch updates the NX driver to perform several hyper calls when necessary so that the length limits of scatter/gather lists are respected. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Reviewed-by: Marcelo Cerri mhce...@linux.vnet.ibm.com

[PATCH 09/10] crypto: nx - fix GCM for zero length messages

...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-gcm.c | 132 ++--- 1 file changed, 112 insertions(+), 20 deletions(-) diff --git a/drivers/crypto/nx/nx-aes-gcm.c b/drivers/crypto/nx/nx-aes-gcm.c index

[PATCH 07/10] crypto: nx - fix limits to sg lists for AES-CCM

From: Fionnuala Gunter f...@linux.vnet.ibm.com This patch updates the NX driver to perform several hyper calls when necessary so that the length limits of scatter/gather lists are respected. Reviewed-by: Marcelo Cerri mhce...@linux.vnet.ibm.com Signed-off-by: Joy Latten jmlat

[PATCH 10/10] crypto: nx - fix SHA-2 for chunks bigger than block size

than the block size. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-sha256.c | 2 +- drivers/crypto/nx/nx-sha512.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/nx/nx

Re: [PATCH 03/10] crypto: nx - fix limits to sg lists for AES-CBC

On Thu, Aug 29, 2013 at 02:42:22PM +1000, Herbert Xu wrote: On Fri, Aug 23, 2013 at 05:01:07PM -0300, Marcelo Cerri wrote: This patch updates the nx-aes-cbc implementation to perform several hyper calls if needed in order to always respect the length limits for scatter/gather lists

[PATCH v2 00/10] Series of fixes for NX driver

for AES-CCM Marcelo Cerri (8): crypto: nx - add offset to nx_build_sg_lists() crypto: nx - fix limits to sg lists for AES-ECB crypto: nx - fix limits to sg lists for AES-CBC crypto: nx - fix limits to sg lists for AES-CTR crypto: nx - fix limits to sg lists for AES-GCM crypto: nx - fix

[PATCH v2 01/10] crypto: nx - add offset to nx_build_sg_lists()

Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-cbc.c | 2 +- drivers/crypto/nx/nx-aes-ccm.c | 4 ++-- drivers/crypto/nx/nx-aes-ctr.c | 2 +- drivers/crypto/nx/nx-aes-ecb.c | 2 +- drivers/crypto/nx/nx-aes-gcm.c | 2 +- drivers/crypto/nx/nx.c | 9

[PATCH v2 02/10] crypto: nx - fix limits to sg lists for AES-ECB

: - The total number of bytes that a scatter/gather list can hold. - The maximum number of elements that a scatter/gather list can have. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-ecb.c | 48

[PATCH v2 04/10] crypto: nx - fix limits to sg lists for AES-CTR

: - The total number of bytes that a scatter/gather list can hold. - The maximum number of elements that a scatter/gather list can have. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-ctr.c | 50

[PATCH v2 05/10] crypto: nx - fix limits to sg lists for AES-GCM

: - The total number of bytes that a scatter/gather list can hold. - The maximum number of elements that a scatter/gather list can have. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-gcm.c | 202

[PATCH v2 06/10] crypto: nx - fix limits to sg lists for AES-XCBC

From: Fionnuala Gunter f...@linux.vnet.ibm.com This patch updates the NX driver to perform several hyper calls when necessary so that the length limits of scatter/gather lists are respected. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Reviewed-by: Marcelo Cerri mhce...@linux.vnet.ibm.com

[PATCH v2 07/10] crypto: nx - fix limits to sg lists for AES-CCM

From: Fionnuala Gunter f...@linux.vnet.ibm.com This patch updates the NX driver to perform several hyper calls when necessary so that the length limits of scatter/gather lists are respected. Reviewed-by: Marcelo Cerri mhce...@linux.vnet.ibm.com Signed-off-by: Joy Latten jmlat

[PATCH v2 03/10] crypto: nx - fix limits to sg lists for AES-CBC

: - The total number of bytes that a scatter/gather list can hold. - The maximum number of elements that a scatter/gather list can have. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-cbc.c | 50

[PATCH v2 08/10] crypto: nx - fix XCBC for zero length messages

it with an implementation based on the RFC 3566 using ECB. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-xcbc.c | 84 + 1 file changed, 77 insertions(+), 7 deletions

[PATCH v2 09/10] crypto: nx - fix GCM for zero length messages

...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-gcm.c | 132 ++--- 1 file changed, 112 insertions(+), 20 deletions(-) diff --git a/drivers/crypto/nx/nx-aes-gcm.c b/drivers/crypto/nx/nx-aes-gcm.c index

[PATCH v2 10/10] crypto: nx - fix SHA-2 for chunks bigger than block size

than the block size. Reviewed-by: Joy Latten jmlat...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-sha256.c | 2 +- drivers/crypto/nx/nx-sha512.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/nx/nx

Re: [PATCH 2/2] crypto: vmx - Use skcipher for xts fallback

In addition to cbc comments: On Wed, Feb 22, 2017 at 03:00:45PM -0300, Paulo Flabiano Smorigo wrote: > Signed-off-by: Paulo Flabiano Smorigo > --- > drivers/crypto/vmx/aes_xts.c | 32 ++-- > 1 file changed, 18 insertions(+), 14

Re: [PATCH 1/2] crypto: vmx - Use skcipher for cbc fallback

Hi Paulo. On Wed, Feb 22, 2017 at 03:00:15PM -0300, Paulo Flabiano Smorigo wrote: > Signed-off-by: Paulo Flabiano Smorigo > --- > drivers/crypto/vmx/aes_cbc.c | 41 - > 1 file changed, 20 insertions(+), 21 deletions(-) > >

Re: [PATCH v2 1/2] crypto: vmx - Use skcipher for cbc fallback

On Fri, Feb 24, 2017 at 11:23:54AM -0300, Paulo Flabiano Smorigo wrote: > Signed-off-by: Paulo Flabiano Smorigo > --- > drivers/crypto/vmx/aes_cbc.c | 44 > ++-- > 1 file changed, 22 insertions(+), 22 deletions(-) > > diff

[PATCH] crypto: sha1-powerpc: little-endian support

The driver does not handle endianness properly when loading the input data. Signed-off-by: Marcelo Cerri <marcelo.ce...@canonical.com> --- arch/powerpc/crypto/sha1-powerpc-asm.S | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/crypto/sha1-p

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

Herbert, Wouldn't be enough to provide a pair of import/export functions as the padlock-sha driver does? -- Regards, Marcelo On Mon, Sep 26, 2016 at 10:59:34PM +0800, Herbert Xu wrote: > On Fri, Sep 23, 2016 at 08:22:27PM -0400, Jan Stancek wrote: > > > > This seems to directly correspond

[PATCH 1/3] crypto: ghash-generic - move common definitions to a new header file

Move common values and types used by ghash-generic to a new header file so drivers can directly use ghash-generic as a fallback implementation. Signed-off-by: Marcelo Cerri <marcelo.ce...@canonical.com> --- crypto/ghash-generic.c | 13 + include/crypto/ghash.

[PATCH 2/3] crypto: vmx - Fix memory corruption caused by p8_ghash

Stancek <jstan...@redhat.com> Signed-off-by: Marcelo Cerri <marcelo.ce...@canonical.com> --- drivers/crypto/vmx/ghash.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/crypto/vmx/ghash.c b/drivers/crypto/vmx/ghash.c index 6c999

[PATCH 3/3] crypto: vmx - Ensure ghash-generic is enabled

Add CRYPTO_GHASH as a dependency for vmx_crypto since p8_ghash uses it as the fallback implementation. Signed-off-by: Marcelo Cerri <marcelo.ce...@canonical.com> --- drivers/crypto/vmx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/vmx/Kco

Re: [PATCH] crypto: sha1-powerpc: little-endian support

, 2016 at 05:23:16PM +1100, Michael Ellerman wrote: > Marcelo Cerri <marcelo.ce...@canonical.com> writes: > > > [ Unknown signature status ] > > On Wed, Sep 28, 2016 at 09:20:15PM +0800, Herbert Xu wrote: > >> On Wed, Sep 28, 2016 at 10:15:51AM -0300, Marce

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

Hi, On Tue, Sep 27, 2016 at 05:01:03AM -0400, Jan Stancek wrote: > So, if we extended p8_ghash_desc_ctx to accommodate fallback_desc's ctx > and then provided statesize/import/export, would that be acceptable? > > struct p8_ghash_desc_ctx { > ... > struct shash_desc

[PATCH 0/3] Fix crypto/vmx/p8_ghash memory corruption

This series fixes the memory corruption found by Jan Stancek in 4.8-rc7. The problem however also affects previous versions of the driver. Marcelo Cerri (3): crypto: ghash-generic - move common definitions to a new header file crypto: vmx - Fix memory corruption caused by p8_ghash crypto

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

Hi Herbert, On Wed, Sep 28, 2016 at 10:45:49AM +0800, Herbert Xu wrote: > On Tue, Sep 27, 2016 at 04:46:44PM -0300, Marcelo Cerri wrote: > > > > Can you check if the problem occurs with this patch? > > In light of the fact that padlock-sha is the correct example > to foll

Re: [PATCH] crypto: sha1-powerpc: little-endian support

Hi Herbert, Any thoughts on this one? -- Regards, Marcelo On Fri, Sep 23, 2016 at 04:31:56PM -0300, Marcelo Cerri wrote: > The driver does not handle endianness properly when loading the input > data. > > Signed-off-by: Marcelo Cerri <marcelo.ce...@canonical.com> > --- &

Re: [PATCH] crypto: sha1-powerpc: little-endian support

On Wed, Sep 28, 2016 at 09:20:15PM +0800, Herbert Xu wrote: > On Wed, Sep 28, 2016 at 10:15:51AM -0300, Marcelo Cerri wrote: > > Hi Herbert, > > > > Any thoughts on this one? > > Can this patch wait until the next merge window? On the broken > platforms it should

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

On Wed, Sep 28, 2016 at 08:44:52PM +0800, Herbert Xu wrote: > On Wed, Sep 28, 2016 at 09:38:41AM -0300, Marcelo Cerri wrote: > > > > The patch forces ghash-generic as the fallback. And I don't think that > > is a big problem if we decide to go by this path. > > Rig

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

Hi Hebert, On Wed, Sep 28, 2016 at 08:29:35PM +0800, Herbert Xu wrote: > On Wed, Sep 28, 2016 at 03:40:51AM -0400, Jan Stancek wrote: > > > > Thanks for clearing up how this works in padlock-sha, but > > we are not exactly in same situation with p8_ghash. > > > > p8_ghash_init_tfm() already

Re: [PATCH 0/3] Fix crypto/vmx/p8_ghash memory corruption

Thank you. -- Regards, Marcelo On Sun, Oct 02, 2016 at 10:40:47PM +0800, Herbert Xu wrote: > On Thu, Sep 29, 2016 at 06:59:08AM +1000, Anton Blanchard wrote: > > Hi Marcelo > > > > > This series fixes the memory corruption found by Jan Stancek in > > > 4.8-rc7. The problem however also affects

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

Hi Jan, Just out of curiosity, have you tried to use "76" on both values to check if the problem still happens? -- Regards, Marcelo On Fri, Sep 23, 2016 at 08:22:27PM -0400, Jan Stancek wrote: > Hi, > > I'm chasing a memory corruption with 4.8-rc7 as I'm observing random Oopses > on ppc BE/LE

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

Jan, Can you check if the problem occurs with this patch? --- drivers/crypto/vmx/ghash.c | 28 +--- drivers/crypto/vmx/vmx.c | 9 + 2 files changed, 26 insertions(+), 11 deletions(-) diff --git a/drivers/crypto/vmx/ghash.c b/drivers/crypto/vmx/ghash.c index