[PATCH 0/6] kbuild: refactor Makefiles related with cc-version

2014-12-24 Thread Masahiro Yamada
Masahiro Yamada (6): kbuild: fix cc-ifversion macro kbuild: do not add $(call ...) to invoke cc-version or cc-fullversion kbuild,gcov: remove unnecessary workaround kbuild,gcov: simplify kernel/gcov/Makefile kbuild: allow cc-ifversion to have the argument for false condition kbuild

[PATCH 2/6] kbuild: do not add $(call ...) to invoke cc-version or cc-fullversion

2014-12-24 Thread Masahiro Yamada
The macros cc-version, cc-fullversion and ld-version take no argument. It is not necessary to add $(call ...) to invoke them. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Documentation/kbuild/makefiles.txt | 4 ++-- arch/parisc/Makefile | 2 +- arch/powerpc

[PATCH] ALSA: squash lines for simple wrapper functions

2016-09-06 Thread Masahiro Yamada
Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> --- sound/aoa/fabrics/layout.c | 7 +-- sound/pci/asihpi/hpifunc.c | 7 ++- sound/pci/ctxfi/ctvmem.c| 6 +- sou

[PATCH] powerpc: squash lines for simple wrapper functions

2016-09-06 Thread Masahiro Yamada
Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> --- arch/powerpc/kernel/ptrace.c| 42 ++--- arch/powerpc/kvm/booke.c| 5 +--- arch/powerpc/platforms/ps3/repository.

[PATCH 00/22] mtd: nand: return error code of nand_scan(_ident, _tail) on error

2016-11-04 Thread Masahiro Yamada
. Masahiro Yamada (22): mtd: nand: ams-delta: return error code of nand_scan() on error mtd: nand: cmx270: return error code of nand_scan() on error mtd: nand: cs553x: return error code of nand_scan() on error mtd: nand: gpio: return error code of nand_scan() on error mtd: nand: mpc5121

[PATCH 08/22] mtd: nand: pasemi: return error code of nand_scan() on error

2016-11-04 Thread Masahiro Yamada
The nand_scan() returns an appropriate error value when it fails. Use it instead of the fixed error code -ENXIO. Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> --- drivers/mtd/nand/pasemi_nand.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drive

Re: powerpc-linux-gnu-ld: warning: orphan section `.data.rel.ro' from `arch/powerpc/kernel/head_44x.o' being placed in section `.data.rel.ro'.

2017-11-13 Thread Masahiro Yamada
placed in section `.data.rel.ro'. > > Reported-by: kbuild test robot <fengguang...@intel.com> > Signed-off-by: Nicholas Piggin <npig...@gmail.com> I think this will go to the PPC tree. I will not touch this patch, but if necessary, please feel free to add Reviewed-by: Masahi

Re: [RFC PATCH 1/2] powerpc/kbuild: Use flags variables rather than overriding LD/CC/AS

2018-05-06 Thread Masahiro Yamada
ipts/Makefile.lib So, -m$(BITS) will be doubled for *.S files. > +LDFLAGS+= -m elf$(BITS)$(LDEMULATION) > KBUILD_ARFLAGS += --target=elf$(BITS)-$(GNUTARGET) > endif > -- Best Regards Masahiro Yamada

Re: [PATCH 4/4] powerpc: Allow LD_DEAD_CODE_DATA_ELIMINATION to be selected

2018-05-06 Thread Masahiro Yamada
inux-next. Some requests: - Could you provide information to replace '[ppc32 numbers here]'? (or just remove it) - V2 is welcome if you have code improvement. (I thought so from your comments) Thanks. -- Best Regards Masahiro Yamada

Re: [PATCH v2 3/5] kbuild: call cc-option with the current set of KBUILD_CFLAGS

2018-05-09 Thread Masahiro Yamada
AGS += $(call ld-option, -X) > -- > 2.17.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH v2 0/4] LD_DEAD_CODE_DATA_ELIMINATION fixes and enabling for powerpc

2018-05-13 Thread Masahiro Yamada
ibe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-19 Thread Masahiro Yamada
ror} which isn't > used in the expansion of the macros but serves to push people to > document the reason for using them - per feedback from Kees Cook.] > > Signed-off-by: Arnd Bergmann > Signed-off-by: Paul Burton > Cc: Michal Marek > Cc: Masahiro Yamada > Cc:

Re: [PATCH v5 0/4] powerpc patches for new Kconfig language

2018-05-30 Thread Masahiro Yamada
4th patch must go after it. >> >> v5 changes: >> - Patch 4 update to syntax changed since kconfig-shell-v3 release. >> - Patch 4 suggestions from Masahiro Yamada, remove unnecessary "OK" >> output from check mprofile script, and fold CC_USING_MPROFILE_KERNEL

Re: [PATCH v5 0/4] powerpc patches for new Kconfig language

2018-05-30 Thread Masahiro Yamada
2018-05-31 13:31 GMT+09:00 Michael Ellerman : > Masahiro Yamada writes: >> 2018-05-30 23:39 GMT+09:00 Michael Ellerman : >>> Nicholas Piggin writes: >>> >>>> This series of patches improves th powerpc kbuild system. The >>>> motivation was

Re: [PATCH v4 1/4] powerpc/kbuild: set default generic machine type for 32-bit compile

2018-05-29 Thread Masahiro Yamada
port CROSS32CC CROSS32AR > > ifeq ($(CROSS_COMPILE),) > -- > 2.17.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH v4 4/4] powerpc/kbuild: move -mprofile-kernel check to Kconfig

2018-05-29 Thread Masahiro Yamada
t; endif > > CFLAGS-$(CONFIG_CELL_CPU) += $(call cc-option,-mcpu=cell) > -- > 2.17.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH v5 0/4] powerpc patches for new Kconfig language

2018-06-01 Thread Masahiro Yamada
Hi. 2018-06-01 19:34 GMT+09:00 Michael Ellerman : > Hi Masahiro, > > Masahiro Yamada writes: > ... >> >> Also, the change logs could be dropped. >> >> I see >> >> Since v1: reworded changelog to explain the cause of the problem (thanks >> Se

Re: [PATCH v5 1/4] powerpc/kbuild: set default generic machine type for 32-bit compile

2018-05-30 Thread Masahiro Yamada
-- > 2.17.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH v5 1/4] powerpc/kbuild: set default generic machine type for 32-bit compile

2018-05-30 Thread Masahiro Yamada
ody of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html All applied to linux-kbuild/kconfig. Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH v5 3/4] powerpc/kbuild: Use flags variables rather than overriding LD/CC/AS

2018-05-30 Thread Masahiro Yamada
t; + $cc .= " -mbig-endian "; > + $ld .= " -EB "; > + $ldemulation = "ppc" > +} else { > + $cc .= " -mlittle-endian "; > + $ld .= " -EL "; > + $ldemulation = "lppc" > +} > if ($bits == 64) { > - $type = ".quad"; > +$type = ".quad"; > +$cc .= " -m64 "; > +$ld .= " -m elf64".$ldemulation." "; > +} else { > +$cc .= " -m32 "; > +$ld .= " -m elf32".$ldemulation." "; > } > > } elsif ($arch eq "arm") { > -- > 2.17.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH v5 0/4] powerpc patches for new Kconfig language

2018-05-31 Thread Masahiro Yamada
2018-05-31 20:51 GMT+09:00 Michael Ellerman : > Masahiro Yamada writes: >> 2018-05-31 13:31 GMT+09:00 Michael Ellerman : >>> Masahiro Yamada writes: >>>> 2018-05-30 23:39 GMT+09:00 Michael Ellerman : >>>>> Nicholas Piggin writes: >>>>&

[PATCH] kbuild: move bin2c back to scripts/ from scripts/basic/

2018-06-25 Thread Masahiro Yamada
9301 ("Revert "kexec/purgatory: Add clean-up for purgatory directory"") and commit d6605b6bbee8 ("x86/build: Remove unnecessary preparation for purgatory") removed the redundant purgatory build magic entirely. That means that the move of bin2c was unnecessary in the first

Re: [PATCH v2 0/3] Resolve -Wattribute-alias warnings from SYSCALL_DEFINEx()

2018-06-23 Thread Masahiro Yamada
inux-kbuild/fixes. (since we need to fix warnings from GCC 8.1) Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-20 Thread Masahiro Yamada
2018-06-20 4:02 GMT+09:00 Paul Burton : > Hi Masahiro, > > On Wed, Jun 20, 2018 at 02:34:35AM +0900, Masahiro Yamada wrote: >> 2018-06-16 9:53 GMT+09:00 Paul Burton : >> > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h >> > index

Re: [PATCH v2 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-20 Thread Masahiro Yamada
compiler_types.h. > - Drop all but GCC 8 macros, since we only need to define macros for > versions that we need to introduce pragmas for, and as of this > series that's just GCC 8. > - Capitalize comments in linux/compiler-gcc.h to match the style of > the rest of the file. &

Re: [PATCH] kbuild: move bin2c back to scripts/ from scripts/basic/

2018-07-02 Thread Masahiro Yamada
2018-06-26 1:40 GMT+09:00 Masahiro Yamada : > Commit 8370edea81e3 ("bin2c: move bin2c in scripts/basic") moved bin2c > to the scripts/basic/ directory, incorrectly stating "Kexec wants to > use bin2c and it wants to use it really early in the build process. > See arch/x

Re: [PATCHv5 0/4] Salted build ids via ELF notes

2018-07-03 Thread Masahiro Yamada
round of this work, but the cover letter cannot be committed in git. Could you add this in 1/4 please? If I read only the simple log in 1/4, I would wonder why it is useful... > v5 uses the approach suggested by Masahiro Yamada which uses the > existing ELF note macro to more

Re: [PATCHv5 4/4] arm64: Add build salt to the vDSO

2018-07-03 Thread Masahiro Yamada
infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473k/dom1359731141352.html It says ';' starts a comment line although it is not the case of GAS. Same for 3/4. -- Best Regards Masahiro Yamada

Re: [PATCHv5 1/4] kbuild: Add build salt to the kernel and modules

2018-07-03 Thread Masahiro Yamada
ID is unique, even if the > actual file contents don't change. The easiest way to do this is to insert > a section with some data. > > Add an ELF note to both the kernel and module which contains some data based > off of a config option. > > Signed-off-by: Masahiro Yamada > Sig

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

2018-02-20 Thread Masahiro Yamada
-foo) is y, but $(cc-option, -m64 -foo) is n ? (or vice versa) If the answer is yes, $(cc-option -foo) would have to be re-calculated every time CONFIG_64BIT is toggled. This is what I'd like to avoid, though. -- Best Regards Masahiro Yamada

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

2018-02-21 Thread Masahiro Yamada
2018-02-21 18:56 GMT+09:00 Arnd Bergmann <a...@arndb.de>: > On Wed, Feb 21, 2018 at 8:38 AM, Masahiro Yamada > <yamada.masah...@socionext.com> wrote: >> 2018-02-20 0:18 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >> >>>> >>>> I'm not

[PATCH 21/23] gcc-plugins: move GCC version check for PowerPC to Kconfig

2018-02-16 Thread Masahiro Yamada
For PowerPC, GCC 5.2 is the requirement for GCC plugins. Move the version check to Kconfig, and remove the ugly checker. Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> --- arch/powerpc/Kconfig | 2 +- scripts/Makefile.gcc-plugins | 8 2 files chan

[PATCH 00/23] kconfig: move compiler capability tests to Kconfig

2018-02-16 Thread Masahiro Yamada
elect user configuration. If this is required, $(shell ) must be dynamically re-calculated depending on other symbols. But, this is difficult, and may cause performance issue. Masahiro Yamada (22): kbuild: remove kbuild cache kbuild: remove CONFIG_CROSS_COMPILE support kconfig: add xstrdu

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

2018-02-21 Thread Masahiro Yamada
2018-02-21 19:52 GMT+09:00 Arnd Bergmann <a...@arndb.de>: > On Wed, Feb 21, 2018 at 11:20 AM, Masahiro Yamada > <yamada.masah...@socionext.com> wrote: >> 2018-02-21 18:56 GMT+09:00 Arnd Bergmann <a...@arndb.de>: >>> On Wed, Feb 21, 2018 at 8:3

Re: powerpc: 32BIT vs. 64BIT (PPC32 vs. PPC64)

2018-07-30 Thread Masahiro Yamada
+ This option selects whether a 32-bit or a 64-bit kernel >> + will be built. >> + >> source "arch/powerpc/platforms/Kconfig.cputype" >> >> config PPC32 >> diff --git a/arch/powerpc/platforms/Kconfig.cputype >> b/arch/powerpc/platforms/Kconfig.cputype >> index e6a1de521319..f6e5d6ef9782 100644 >> --- a/arch/powerpc/platforms/Kconfig.cputype >> +++ b/arch/powerpc/platforms/Kconfig.cputype >> @@ -1,12 +1,4 @@ >> # SPDX-License-Identifier: GPL-2.0 >> -config PPC64 >> - bool "64-bit kernel" >> - default n >> - select ZLIB_DEFLATE >> - help >> - This option selects whether a 32-bit or a 64-bit kernel >> - will be built. >> - >> menu "Processor support" >> choice >> prompt "Processor Type" >> > > > -- > ~Randy > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH 6/8] kbuild: consolidate Devicetree dtb build rules

2018-08-25 Thread Masahiro Yamada
t; dtc. > > This change enables support 'dtbs_install' on some arches which were > missing the target. > > Cc: Masahiro Yamada > Cc: Michal Marek > Cc: Vineet Gupta > Cc: Russell King > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Yoshinori Sato > Cc: Michal Simek &

[PATCH] powerpc: remove pre-build checks for old GCC versions

2018-08-26 Thread Masahiro Yamada
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") bumped the minimum GCC version to 4.6 for all architectures. The GCC version checks in arch/powerpc/Makefile are obsolete now. Signed-off-by: Masahiro Yamada --- arch/powerpc/Mak

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

2018-09-07 Thread Masahiro Yamada
Hi Rob, 2018-09-07 21:17 GMT+09:00 Rob Herring : > On Fri, Sep 7, 2018 at 5:33 AM Masahiro Yamada > wrote: >> >> 2018-09-06 8:53 GMT+09:00 Rob Herring : >> > There is nothing arch specific about building dtb files other than their >> > location under /arch/*/

Re: [PATCH 6/8] kbuild: consolidate Devicetree dtb build rules

2018-09-07 Thread Masahiro Yamada
2018-08-27 8:56 GMT+09:00 Rob Herring : > On Sat, Aug 25, 2018 at 9:06 PM Masahiro Yamada > wrote: >> >> Hi Rob, >> >> >> 2018-08-22 6:55 GMT+09:00 Rob Herring : >> > There is nothing arch specific about building dtb files other than their >> &g

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

2018-09-09 Thread Masahiro Yamada
gt; This change enables support 'dtbs_install' on some arches which were > missing the target. > > Cc: Masahiro Yamada > Cc: Michal Marek > Cc: Vineet Gupta > Cc: Russell King > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Yoshinori Sato > Cc: Michal Simek > Cc

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

2018-09-07 Thread Masahiro Yamada
gt; This change enables support 'dtbs_install' on some arches which were > missing the target. > > Cc: Masahiro Yamada > Cc: Michal Marek > Cc: Vineet Gupta > Cc: Russell King > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Yoshinori Sato > Cc: Michal Simek > Cc

Re: [PATCHv6 0/4] Salted build ids via ELF notes

2018-07-08 Thread Masahiro Yamada
hanged, 47 insertions(+) > create mode 100644 include/linux/build-salt.h > > -- > 2.17.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH v3 6/9] kbuild: consolidate Devicetree dtb build rules

2018-09-11 Thread Masahiro Yamada
$(Q)$(MAKE) $(dtbinst)=$(dtstree) >> + >> +all: dtbs >> + >> +endif Ah, right. Even x86 can enable OF and OF_UNITTEST. Another solution might be, guard it by 'depends on ARCH_SUPPORTS_OF'. This is actually what ACPI does. menuconfig ACPI bool "ACPI (Advanced Configuration and Power Interface) Support" depends on ARCH_SUPPORTS_ACPI ... -- Best Regards Masahiro Yamada

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

2018-03-01 Thread Masahiro Yamada
2018-02-22 6:39 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: > On Wed, Feb 21, 2018 at 09:57:03PM +0900, Masahiro Yamada wrote: >> 2018-02-21 19:52 GMT+09:00 Arnd Bergmann <a...@arndb.de>: >> > On Wed, Feb 21, 2018 at 11:20 AM, Masahiro Yamada >> >

Re: [PATCH 4/8] pci: consolidate PCI config entry in drivers/pci

2018-10-15 Thread Masahiro Yamada
vers/pci/Kconfig" > - > config GSC_DINO > bool "GSCtoPCI/Dino PCI support" > depends on PCI && GSC > diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig > index 56ff8f6d31fc..229a518b68cd 100644 > --- a/drivers/pci/Kconfig > +++ b/drivers/pci/Kconfig > @@ -3,6 +3,18 @@ > # PCI configuration > # > > +config HAS_PCI > + bool > + > +menuconfig PCI > + bool "PCI support" > + depends on HAS_PCI > + > + help > + This option enables support for the PCI local bus, including > + support for PCI-X and the fundations for PCI Express support. > + Say 'Y' here unless you know what you are doing. > + > source "drivers/pci/pcie/Kconfig" > > config PCI_MSI > -- > 2.19.1 > -- Best Regards Masahiro Yamada

Re: [PATCH 2/8] powerpc: simplify CONFIG_PCI_QSPAN Kconfig magic

2018-10-15 Thread Masahiro Yamada
h/powerpc/Kconfig: default PCI_QSPAN if PPC_8xx arch/powerpc/Kconfig:config PCI_QSPAN With your patch, PCI_QSPAN will become a dead config option. How about removing it entirely? -- Best Regards Masahiro Yamada

Re: move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/

2018-10-15 Thread Masahiro Yamada
nce > (when needed) and then handles everything in the bus-specific > Kconfig file under drivers/. > Thanks for great work again. However, I suspect some breakages (not testing yet, just quick review by my eyes.) I left some comments in individual patches. -- Best Regards Masahiro Yamada

Re: [PATCH 7/8] eisa: consolidate EISA Kconfig entry in drivers/eisa

2018-10-15 Thread Masahiro Yamada
@ -518,11 +521,6 @@ config ALPHA_SRM > > If unsure, say N. > > -config EISA > - bool > - depends on ALPHA_GENERIC || ALPHA_JENSEN || ALPHA_ALCOR || > ALPHA_MIKASA || ALPHA_SABLE || ALPHA_LYNX || ALPHA_NORITAKE || ALPHA_RAWHIDE > - default y > - Better to add CONFIG_EISA=y to arch/alpha/defconfig to not flip the default? -- Best Regards Masahiro Yamada

Re: [PATCH 4/8] pci: consolidate PCI config entry in drivers/pci

2018-10-15 Thread Masahiro Yamada
On Mon, Oct 15, 2018 at 5:57 PM Christoph Hellwig wrote: > > On Mon, Oct 15, 2018 at 03:37:05PM +0900, Masahiro Yamada wrote: > > I think HAVE_ is a preferred prefix in this case according to this doc: > > https://github.com/masahir0y/linux/blob/v4.19-rc4/Documentation/kbuild/kc

Re: [PATCH 7/8] eisa: consolidate EISA Kconfig entry in drivers/eisa

2018-10-18 Thread Masahiro Yamada
> Acked-by: Thomas Gleixner > --- -- Best Regards Masahiro Yamada

Re: [PATCH 7/8] eisa: consolidate EISA Kconfig entry in drivers/eisa

2018-10-18 Thread Masahiro Yamada
kernel for an EISA-based machine. > - > - Otherwise, say N. > - > config SBUS > bool > -- Best Regards Masahiro Yamada

Re: [PATCH 6/8] rapidio: consolidate RAPIDIO config entry in drivers/rapidio

2018-10-18 Thread Masahiro Yamada
Acked-by: Thomas Gleixner -- Best Regards Masahiro Yamada

Re: [PATCH 4/8] PCI: consolidate PCI config entry in drivers/pci

2018-10-18 Thread Masahiro Yamada
We could add 'depends on HAVE_PCI' or something to guard it to avoid changing the logic. config PCI_ENDPOINT bool "PCI Endpoint Support" depends on HAVE_PCI # Is this correct ?? depends on HAS_DMA or better to have 'depends on PCI' ? PCI ML is also CC'ed, so comments are appreciated. -- Best Regards Masahiro Yamada

Re: [PATCH 2/9] arm: remove EISA kconfig option

2018-10-19 Thread Masahiro Yamada
esurrect it easily by selecting > HAVE_EISA for the right arm configs after this series. What is your concern? This absolutely looks dead to me. > Suggested-by: Masahiro Yamada > Signed-off-by: Christoph Hellwig > --- > arch/arm/Kconfig | 15 --- > 1 file changed, 15 de

Re: [PATCH 6/9] PCI: consolidate PCI config entry in drivers/pci

2018-10-19 Thread Masahiro Yamada
cted. Your patch will > cause Kconfig to complain for those which mandatorily have PCI but > do not set HAVE_PCI. Good catch! But, adding a bunch of 'select HAVE_PCI' along with 'select PCI' is ugly. Do you have any suggestion? How about letting CONFIG_ARM to select HAVE_PCI ? -- Best Regards Masahiro Yamada

Re: [PATCH 8/8] kconfig: remove CONFIG_MCA leftovers

2018-10-15 Thread Masahiro Yamada
depends on EISA && SCSI > select SCSI_SPI_ATTRS > ---help--- > This driver is for NCR53c710 based SCSI host adapters. > > - It currently supports Compaq EISA cards and NCR MCA cards > + It currently supports Compaq EISA cards. > > config SCSI_DC395x > tristate "Tekram DC395(U/UW/F) and DC315(U) SCSI support" > -- > 2.19.1 > -- Best Regards Masahiro Yamada

[PATCH 1/2] kbuild: replace cc-name test with CONFIG_CC_IS_CLANG

2018-10-29 Thread Masahiro Yamada
Evaluating cc-name invokes the compiler every time even when you are not compiling anything, like 'make help'. This is not efficient. The compiler type has been already detected in the Kconfig stage. Use CONFIG_CC_IS_CLANG, instead. Signed-off-by: Masahiro Yamada --- Makefile

Re: [PATCH 5/9] powerpc: PCI_MSI needs PCI

2018-10-31 Thread Masahiro Yamada
lp > > @@ -219,6 +221,7 @@ config AKEBONO > > select SWIOTLB > > select 476FPE > > select PPC4xx_PCI_EXPRESS > > + select PCI > > select PCI_MSI > > select PPC4xx_HSTA_MSI > > select I2C > > -- > > 2.19.1 > > -- Best Regards Masahiro Yamada

Re: [PATCH 6/9] PCI: consolidate PCI config entry in drivers/pci

2018-10-31 Thread Masahiro Yamada
Hi Christoph, On Fri, Oct 19, 2018 at 9:58 PM Masahiro Yamada wrote: > > On Fri, Oct 19, 2018 at 9:23 PM Russell King - ARM Linux > wrote: > > > > index a68b34183107..b185794549be 100644 > > > --- a/arch/arm/mach-pxa/Kconfig > > > +++ b/arch/arm/

Re: [PATCH 1/9] aha152x: rename the PCMCIA define

2018-10-31 Thread Masahiro Yamada
s/scsi/pcmcia/aha152x_core.c > b/drivers/scsi/pcmcia/aha152x_core.c > index dba3716511c5..24b89228b241 100644 > --- a/drivers/scsi/pcmcia/aha152x_core.c > +++ b/drivers/scsi/pcmcia/aha152x_core.c > @@ -1,3 +1,3 @@ > -#define PCMCIA 1 > +#define AHA152X_PCMCIA 1 > #define AHA152X_STAT 1 > #include "aha152x.c" > -- > 2.19.1 > -- Best Regards Masahiro Yamada

Re: [PATCH 4/9] powerpc: remove CONFIG_MCA leftovers

2018-10-31 Thread Masahiro Yamada
amp; SCSI > + depends on EISA && SCSI > select SCSI_SPI_ATTRS > ---help--- > This driver is for NCR53c710 based SCSI host adapters. > > - It currently supports Compaq EISA cards and NCR MCA cards > + It currently supports Compaq EISA cards. > > config SCSI_DC395x > tristate "Tekram DC395(U/UW/F) and DC315(U) SCSI support" > -- > 2.19.1 > -- Best Regards Masahiro Yamada

Re: [PATCH 3/9] powerpc: remove CONFIG_PCI_QSPAN

2018-10-31 Thread Masahiro Yamada
Say Y here if you have a system based on a Motorola 8xx-series > - embedded processor with a QSPAN PCI interface, otherwise say N. > - > config PCI_8260 > bool > depends on PCI && 8260 > -- > 2.19.1 > -- Best Regards Masahiro Yamada

Re: [PATCH 1/2] kbuild: replace cc-name test with CONFIG_CC_IS_CLANG

2018-10-30 Thread Masahiro Yamada
On Tue, Oct 30, 2018 at 9:36 PM Michael Ellerman wrote: > > Masahiro Yamada writes: > > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile > > index 17be664..338e827 100644 > > --- a/arch/powerpc/Makefile > > +++ b/arch/powerpc/Makefil

[PATCH v2 1/2] kbuild: replace cc-name test with CONFIG_CC_IS_CLANG

2018-10-30 Thread Masahiro Yamada
Evaluating cc-name invokes the compiler every time even when you are not compiling anything, like 'make help'. This is not efficient. The compiler type has been already detected in the Kconfig stage. Use CONFIG_CC_IS_CLANG, instead. Signed-off-by: Masahiro Yamada Acked-by: Michael Ellerman

Re: [PATCH v2 2/2] kbuild: consolidate Clang compiler flags

2018-11-11 Thread Masahiro Yamada
On Sat, Nov 10, 2018 at 3:35 AM Greg Hackmann wrote: > > On 11/09/2018 10:29 AM, Nick Desaulniers wrote: > > On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yamada > > wrote: > >> > >> Collect basic Clang options such as --target, --prefix, --gcc-toolchain, > >

Re: [PATCH v2 1/2] Makefile: Export clang toolchain variables

2018-11-12 Thread Masahiro Yamada
ort'. > Either way, I think it would be clearer to export this after all the > relevant flags are set. OK. It is just a matter of preference, but I will move the export line below when I pick up this patch set. > > KBUILD_CFLAGS += $(CLANG_FLAGS) > > KBUILD_AFLAGS += $(CLANG_FLAGS) > > -- > > 2.19.1 > > > > > -- > Thanks, > ~Nick Desaulniers -- Best Regards Masahiro Yamada

[PATCH 0/2] Remove -fno-unit-at-a-time and -funit-at-a-time compiler flags entirely

2018-11-11 Thread Masahiro Yamada
1/2: remove dead code, which is logically obvious because the minimum GCC version is now 4.6 2/2: we can say -funit-at-a-time is no longer useful according to GCC 4.6 manual I hope, this series can be applied through x86 tree. Masahiro Yamada (2): um: remove -fno-unit-at-a-time

[PATCH 2/2] x86, powerpc: remove -funit-at-a-time compiler option entirely

2018-11-11 Thread Masahiro Yamada
GCC 4.6 manual says: -funit-at-a-time This option is left for compatibility reasons. -funit-at-a-time has no effect, while -fno-unit-at-a-time implies -fno-toplevel-reorder and -fno-section-anchors. Enabled by default. Signed-off-by: Masahiro Yamada --- arch/powerpc/Makefile | 4

Re: [PATCH v2 2/2] kbuild: consolidate Clang compiler flags

2018-11-11 Thread Masahiro Yamada
On Mon, Nov 12, 2018 at 10:05 AM Michael Ellerman wrote: > > Masahiro Yamada writes: > > On Sat, Nov 10, 2018 at 3:35 AM Greg Hackmann wrote: > >> > >> On 11/09/2018 10:29 AM, Nick Desaulniers wrote: > >> > On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yam

[PATCH 1/2] um: remove -fno-unit-at-a-time workaround for pre-4.0 GCC

2018-11-11 Thread Masahiro Yamada
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") bumped the minimum GCC version to 4.6 for all architectures. '$(call cc-option,-fno-unit-at-a-time)' is now dead code since '$(cc-version) -lt 0400' is always false. Signed-off-by: Masahiro Yamada --- arch/x86/M

Re: [PATCH v2 2/2] kbuild: consolidate Clang compiler flags

2018-11-13 Thread Masahiro Yamada
On Tue, Nov 6, 2018 at 12:06 PM Masahiro Yamada wrote: > > Collect basic Clang options such as --target, --prefix, --gcc-toolchain, > -no-integrated-as into a single variable CLANG_FLAGS so that it can be > easily reused in other parts of Makefile. > > Signed-off-b

Re: [PATCH v2 1/2] kbuild: add -no-integrated-as Clang option unconditionally

2018-11-13 Thread Masahiro Yamada
On Tue, Nov 6, 2018 at 12:06 PM Masahiro Yamada wrote: > > We are still a way off the Clang's integrated assembler support for > the kernel. Hence, -no-integrated-as is mandatory to build the kernel > with Clang. If you had an ancient version of Clang that does not > recognize t

Re: [PATCH v2 1/2] Makefile: Export clang toolchain variables

2018-11-13 Thread Masahiro Yamada
s > KBUILD_CFLAGS += $(CLANG_FLAGS) > KBUILD_AFLAGS += $(CLANG_FLAGS) > -- > 2.19.1 > -- Best Regards Masahiro Yamada

Re: [PATCH v2 2/2] powerpc/boot: Set target when cross-compiling for clang

2018-11-13 Thread Masahiro Yamada
> > +BOOTCFLAGS += $(CLANG_FLAGS) > > +BOOTAFLAGS += $(CLANG_FLAGS) > > +endif > > + > > ifdef CONFIG_DEBUG_INFO > > BOOTCFLAGS += -g > > endif > > -- > > 2.19.1 > > > > > -- > Thanks, > ~Nick Desaulniers -- Best Regards Masahiro Yamada

[PATCH v2 2/2] kbuild: consolidate Clang compiler flags

2018-11-05 Thread Masahiro Yamada
Collect basic Clang options such as --target, --prefix, --gcc-toolchain, -no-integrated-as into a single variable CLANG_FLAGS so that it can be easily reused in other parts of Makefile. Signed-off-by: Masahiro Yamada --- Changes in v2: - Use := flavor instead of = because $(CLANG_FLAGS

[PATCH v2 1/2] kbuild: add -no-integrated-as Clang option unconditionally

2018-11-05 Thread Masahiro Yamada
-by: Masahiro Yamada --- Changes in v2: - New patch Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 93315eb..da11700 100644 --- a/Makefile +++ b/Makefile @@ -497,8 +497,8 @@ CLANG_GCC_TC:= --gcc-toolchain=$(GCC_TOOLCHAIN) endif

Re: [PATCH 1/2] Makefile: Export clang toolchain variables

2018-11-04 Thread Masahiro Yamada
ke a look at my patch, please? https://patchwork.kernel.org/patch/10667369/ By using it as a prerequisite, your patch set will be more simplified. -- Best Regards Masahiro Yamada

Re: [PATCH v3 6/9] kbuild: consolidate Devicetree dtb build rules

2018-09-30 Thread Masahiro Yamada
# > ------- > # Modules > -- Best Regards Masahiro Yamada

[PATCH] powerpc: remove leftover code of old GCC version checks

2018-10-01 Thread Masahiro Yamada
Clean up the leftover of commit f2910f0e6835 ("powerpc: remove old GCC version checks"). Signed-off-by: Masahiro Yamada --- My patch had been sent earlier, with more clean-ups: https://lore.kernel.org/patchwork/patch/977805/ Anyway, this cleans up the left-over of the Nicholas' on

Re: [PATCH v3 6/9] kbuild: consolidate Devicetree dtb build rules

2018-10-01 Thread Masahiro Yamada
Hi Rob, 2018年10月1日(月) 22:26 Rob Herring : > > On Mon, Oct 1, 2018 at 12:49 AM Masahiro Yamada > wrote: > > > > Hi Rob, > > > > > > 2018年9月29日(土) 0:43 Rob Herring : > > > > > +# > > > --

Re: [PATCH v4 6/9] kbuild: consolidate Devicetree dtb build rules

2018-10-01 Thread Masahiro Yamada
is change enables support 'dtbs_install' on some arches which were > missing the target. > > Acked-by: Will Deacon > Acked-by: Paul Burton > Acked-by: Ley Foon Tan > Cc: Masahiro Yamada Please change this to Acked-by: Masahiro Yamada Thanks. > Cc: Michal Marek > Cc:

Re: How to define some additional KBUILD_CFLAGS after building include/generated/asm-offsets.h ?

2018-09-26 Thread Masahiro Yamada
epare0 >>> +$(eval KBUILD_CFLAGS += -mstack-protector-guard-offset=$(shell awk >>> '{if ($$2 == "TSK_STACK_CANARY") print $$3;}' >>> include/generated/asm-offsets.h)) >>> + >> >> Great, it works ! >> Thanks, I have sent v3 of the patches. > > Cool. > > It would be good to here from someone who knows Kbuild better than me if > this is acceptable or just a gross hack :) I am fine with this solution. Thanks. -- Best Regards Masahiro Yamada

Re: [PATCH v3 6/9] kbuild: consolidate Devicetree dtb build rules

2018-09-23 Thread Masahiro Yamada
2018-09-13 11:51 GMT-04:00 Geert Uytterhoeven : > Hi Yamada-san, > > On Wed, Sep 12, 2018 at 3:02 AM Masahiro Yamada > wrote: >> 2018-09-12 0:40 GMT+09:00 Rob Herring : >> > On Mon, Sep 10, 2018 at 10:04 AM Rob Herring wrote: >> >> There is nothing arch

Re: jump_label: move 'asm goto' support test to Kconfig

2019-01-02 Thread Masahiro Yamada
nel cannot be compiled with Clang since it lacks the asm-goto support. $ make CC=clang Compiler lacks asm-goto support. arch/x86/Makefile:293: recipe for target 'checkbin' failed make: *** [checkbin] Error 1 -- Best Regards Masahiro Yamada

Re: [PATCH] kbuild: mark prepare0 as PHONY to fix external module build

2019-01-16 Thread Masahiro Yamada
On Tue, Jan 15, 2019 at 5:07 PM Masahiro Yamada wrote: > > Commit c3ff2a5193fa ("powerpc/32: add stack protector support") > caused kernel panic on PowerPC if an external module is used with > CONFIG_STACKPROTECTOR because the 'prepare' target was not executed > for

[PATCH 2/3] kbuild: add real-prereqs shorthand for $(filter-out FORCE, $^)

2019-01-16 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada --- Documentation/devicetree/bindings/Makefile | 2 +- arch/mips/boot/Makefile| 2 +- arch/powerpc/boot/Makefile | 2 +- arch/x86/realmode/rm/Makefile | 3 +-- scripts/Kbuild.include | 4 +++

[PATCH v2 3/4] kbuild: add real-prereqs shorthand for $(filter-out FORCE, $^)

2019-01-17 Thread Masahiro Yamada
,$^) in cmd_link_multi-m because $^ may include auto-generated dependencies from the .*.cmd file when a single object module is changed into a multi object module. Refer to commit 69ea912fda74 ("kbuild: remove unneeded link_multi_deps"). I added some comment to avoid accidental breakage. Signed-off-by

Re: [PATCH] kbuild: mark prepare0 as PHONY to fix external module build

2019-01-15 Thread Masahiro Yamada
On Tue, Jan 15, 2019 at 7:45 PM Alexey Kardashevskiy wrote: > > > > On 15/01/2019 18:19, Masahiro Yamada wrote: > > Commit c3ff2a5193fa ("powerpc/32: add stack protector support") > > caused kernel panic on PowerPC if an external module is used with > > CO

Re: [PATCH] kbuild: mark prepare0 as PHONY to fix external module build

2019-01-15 Thread Masahiro Yamada
On Tue, Jan 15, 2019 at 7:35 PM Mathieu Malaterre wrote: > > On Tue, Jan 15, 2019 at 8:22 AM Masahiro Yamada > wrote: > > > > Commit c3ff2a5193fa ("powerpc/32: add stack protector support") > > caused kernel panic on PowerPC if an external module is used w

[PATCH] kbuild: mark prepare0 as PHONY to fix external module build

2019-01-14 Thread Masahiro Yamada
s: 0a1213fa7432 ("arm64: enable per-task stack canaries") Cc: linux-stable # v4.20 Reported-by: Samuel Holland Reported-by: Alexey Kardashevskiy Signed-off-by: Masahiro Yamada --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile

Re: [PATCH 0/3] powerpc: some header search path cleanups

2019-01-17 Thread Masahiro Yamada
Hi Michael, On Fri, Jan 11, 2019 at 2:20 PM Masahiro Yamada wrote: > > I am trying to get rid of crappy magic from Kbuild core makefiles. > > Before that, I want to drop as many useless paths as possible. > Actually, many Makefiles are adding around pointless options. > &g

Re: [PATCH v3] kbuild: Add support for DT binding schema checks

2018-12-11 Thread Masahiro Yamada
EMA_FILES))) > > > > I do not understand this line. > > Why is it necessary? > > > > *.example.dtb files are generated anyway > > since they are listed in extra-y. > > It is enforcing the ordering. Without it, the binding checks and > building .schema.yaml.tmp happen in parallel because both only have > the source files as dependencies. The '|' keeps the dependencies out > of the dependency list($^). What kind problem would you see if the binding checks and building .schema.yaml.tmp happen in parallel? -- Best Regards Masahiro Yamada

Re: [PATCH v3] kbuild: Add support for DT binding schema checks

2018-12-10 Thread Masahiro Yamada
ntly, the validation targets are separate from a normal build to > avoid a hard dependency on the external DT schema project and because > there are lots of warnings generated. > > Cc: Jonathan Corbet > Cc: Mark Rutland > Cc: Masahiro Yamada > Cc: Michal Marek >

Re: [PATCH v3] kbuild: Add support for DT binding schema checks

2018-12-11 Thread Masahiro Yamada
On Wed, Dec 12, 2018 at 3:36 AM Rob Herring wrote: > > On Tue, Dec 11, 2018 at 10:03 AM Masahiro Yamada > wrote: > > > > On Wed, Dec 12, 2018 at 12:13 AM Rob Herring wrote: > > > > > > > > > > +$(obj)/%.example.dts: $(src)/%.yaml FO

Re: [PATCH v4] kbuild: Add support for DT binding schema checks

2018-12-11 Thread Masahiro Yamada
m a normal build to > avoid a hard dependency on the external DT schema project and because > there are lots of warnings generated. > > Cc: Jonathan Corbet > Cc: Mark Rutland > Cc: Masahiro Yamada > Cc: Michal Marek > Cc: linux-...@vger.kernel.org > Cc: devicet...@vger.ke

[PATCH 3/3] arch: remove redundant generic-y defines

2018-12-05 Thread Masahiro Yamada
Now that Kbuild automatically creates asm-generic wrappers for missing mandatory headers, it is redundant to list the same headers in generic-y and mandatory-y. Suggested-by: Sam Ravnborg Signed-off-by: Masahiro Yamada --- arch/alpha/include/uapi/asm/Kbuild | 5 - arch/arc/include

Re: [PATCH v2 01/34] kbuild: Add support for DT binding schema checks

2018-12-07 Thread Masahiro Yamada
eparate from a normal build to > avoid a hard dependency on the external DT schema project and because > there are lots of warnings generated. > > Cc: Jonathan Corbet > Cc: Mark Rutland > Cc: Masahiro Yamada > Cc: Michal Marek > Cc: linux-...@vger.kernel.org > Cc: devicet...

Re: [PATCH 1/2] um: remove -fno-unit-at-a-time workaround for pre-4.0 GCC

2018-12-07 Thread Masahiro Yamada
x86 maintainers, Ping. On Tue, Nov 13, 2018 at 6:48 PM Richard Weinberger wrote: > > Am Montag, 12. November 2018, 03:35:19 CET schrieb Masahiro Yamada: > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > bumped the minimum GCC version

Re: [PATCH 2/2] x86, powerpc: remove -funit-at-a-time compiler option entirely

2018-12-07 Thread Masahiro Yamada
x86 maintainers, Ping. On Mon, Nov 12, 2018 at 8:23 PM Michael Ellerman wrote: > > Masahiro Yamada writes: > > > GCC 4.6 manual says: > > > > -funit-at-a-time > > This option is left for compatibility reasons. -funit-at-a-time has > > no effect,

Re: [PATCH 2/2] x86, powerpc: remove -funit-at-a-time compiler option entirely

2018-12-08 Thread Masahiro Yamada
Hi Borislav, On Sat, Dec 8, 2018 at 8:34 PM Borislav Petkov wrote: > > On Sat, Dec 08, 2018 at 03:36:52PM +0900, Masahiro Yamada wrote: > > x86 maintainers, > > > > Ping. > > You got the required ACKs. If you want me to carry this one and the > UML one through

  1   2   3   4   5   >