[PATCH] ASoC: fsl: Disable SSI in trigger() if RE/TE are both cleared

2013-07-10 Thread Nicolin Chen
in sequence like: startup()-hw_params(S16_LE)-trigger(START)-tirgger(STOP)- hw_params(S24_LE)-trigger(START)-tirgger(STOP)-shutdown() If we disable SSIEN in shutdown(), the second hw_params() would bypass the sample bits setting while using symmetric_rate. Signed-off-by: Nicolin Chen b42...@freescale.com

Re: [alsa-devel] [PATCH] ASoC: fsl: Disable SSI in trigger() if RE/TE are both cleared

2013-07-11 Thread Nicolin Chen
. Please test it for me. Thank you. Best regards, Nicolin Chen ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH] ASoC: fsl: Disable SSI in trigger() if RE/TE are both cleared

2013-07-11 Thread Nicolin Chen
On Thu, Jul 11, 2013 at 11:00:15PM -0500, Timur Tabi wrote: I definitely want to. Unfortunately, I'm literally in the middle of moving into a new house, and so everything is packed up. I won't be able to look at it for another week. Oh, I see. Actually we've been using this patch for quite a

Re: [alsa-devel] [PATCH] ASoC: fsl: Disable SSI in trigger() if RE/TE are both cleared

2013-07-11 Thread Nicolin Chen
it later. I'm okay with your decision. Thanks, Nicolin Chen ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] ASoC: fsl: Set sdma peripheral type directly

2013-07-25 Thread Nicolin Chen
Let CPU DAI drivers set SDMA periperal type directly to support more dma types(SPDIF, ESAI) other than only two for SSI. This will easily allow some non-SSI drivers to use the imx-pcm-dma as well. Signed-off-by: Nicolin Chen b42...@freescale.com --- @Timur Compile-passed with mpc85xx_defconfig

[PATCH 0/3] ASoC: Add Freescale i.MX S/PDIF controller driver

2013-07-31 Thread Nicolin Chen
* This series of patches add i.MX S/PDIF drivers, including CPU DAI, machine. * It also add two missing sample rates support for spdif dummy codec drivers Nicolin Chen (3): ASoC: codec: spdif: Add S20_3LE and S24_LE support for dummy codec drivers ASoC: fsl: Add S/PDIF CPU DAI driver

[PATCH 1/3] ASoC: codec: spdif: Add S20_3LE and S24_LE support for dummy codec drivers

2013-07-31 Thread Nicolin Chen
of cpu_dai's formats and codec_dai's formats. Signed-off-by: Nicolin Chen b42...@freescale.com --- sound/soc/codecs/spdif_receiver.c|2 ++ sound/soc/codecs/spdif_transmitter.c |5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/spdif_receiver.c b

[PATCH 3/3] ASoC: fsl: Add S/PDIF machine driver

2013-07-31 Thread Nicolin Chen
Add S/PDIF machine driver for Freescale i.MX series SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig | 11 ++ sound/soc/fsl/Makefile |2

[PATCH 2/3] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-07-31 Thread Nicolin Chen
This patch add S/PDIF controller driver for Freescale SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 63 + sound/soc/fsl/Kconfig |3 + sound/soc/fsl/Makefile |2

[PATCH v2 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-05 Thread Nicolin Chen
This patch add S/PDIF controller driver for Freescale SoC. Reviewed-by: Lars-Peter Clausen l...@metafoo.de Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 62 + sound/soc/fsl/Kconfig |3 + sound/soc/fsl

[PATCH v2 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-05 Thread Nicolin Chen
Changelog: v1-v2: * Dropped one applied patch for spdif dummy codec drivers. * Use generic DMA DT binding. * Let spdif controller driver calculate the clock div. * Added one optional clock source for spdif tx. * Reivsed documentation accordingly. Nicolin Chen (2): ASoC: fsl: Add S/PDIF CPU

[PATCH v2 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-05 Thread Nicolin Chen
Add S/PDIF machine driver for Freescale i.MX series SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig | 11 ++ sound/soc/fsl/Makefile |2

Re: [alsa-devel] [PATCH v2 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-05 Thread Nicolin Chen
On Mon, Aug 05, 2013 at 09:12:01AM +0200, Lars-Peter Clausen wrote: You are supposed to only add tags (Acked-by, Reviewed-by, Signed-off-by, etc.) for other people if they have explicitly said they are OK with it. Reviewed-by means that the person has looked at the current patch and thinks it

[PATCH v3 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-05 Thread Nicolin Chen
accordingly. Nicolin Chen (2): ASoC: fsl: Add S/PDIF CPU DAI driver ASoC: fsl: Add S/PDIF machine driver .../devicetree/bindings/sound/fsl,spdif.txt| 62 + .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig | 14 + sound

[PATCH v3 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-05 Thread Nicolin Chen
This patch add S/PDIF controller driver for Freescale SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 62 + sound/soc/fsl/Kconfig |3 + sound/soc/fsl/Makefile |2

[PATCH v3 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-05 Thread Nicolin Chen
Add S/PDIF machine driver for Freescale i.MX series SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig | 11 ++ sound/soc/fsl/Makefile |2

Re: [PATCH v3 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-05 Thread Nicolin Chen
Hi Philipp, Thanks for the comments! I'll revise it and send a v4. Here is my reply to some parts of your question. On Mon, Aug 05, 2013 at 12:07:02PM +0200, Philipp Zabel wrote: This looks to me like a case of configuration data in the device tree. Couldn't the tx/rx clock source be

[PATCH v4 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-12 Thread Nicolin Chen
Add S/PDIF machine driver for Freescale i.MX series SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig | 11 ++ sound/soc/fsl/Makefile |2

[PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-12 Thread Nicolin Chen
This patch add S/PDIF controller driver for Freescale SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 100 ++ sound/soc/fsl/Kconfig |3 + sound/soc/fsl/Makefile |2

[PATCH v4 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-12 Thread Nicolin Chen
. * Reivsed documentation accordingly. Nicolin Chen (2): ASoC: fsl: Add S/PDIF CPU DAI driver ASoC: fsl: Add S/PDIF machine driver .../devicetree/bindings/sound/fsl,spdif.txt| 100 ++ .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig

[PATCH v4 resent 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-12 Thread Nicolin Chen
. * Reivsed documentation accordingly. Nicolin Chen (2): ASoC: fsl: Add S/PDIF CPU DAI driver ASoC: fsl: Add S/PDIF machine driver .../devicetree/bindings/sound/fsl,spdif.txt| 100 ++ .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig

[PATCH v4 resent 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-12 Thread Nicolin Chen
This patch add S/PDIF controller driver for Freescale SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 100 ++ sound/soc/fsl/Kconfig |3 + sound/soc/fsl/Makefile |2

[PATCH v4 resent 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-12 Thread Nicolin Chen
Add S/PDIF machine driver for Freescale i.MX series SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig | 11 ++ sound/soc/fsl/Makefile |2

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Nicolin Chen
Hi Fabio, Thank you for the comments. On Tue, Aug 13, 2013 at 02:58:26PM -0300, Fabio Estevam wrote: On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen b42...@freescale.com wrote: +Required properties: + + - compatible : Compatible list, contains fsl,chip-spdif. Using general Can't

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Nicolin Chen
Hi Shwan, On Wed, Aug 14, 2013 at 11:27:00AM +0800, Shawn Guo wrote: I do not think we need this general compatible string. Device tree compatible should be specific. So I should just use 'fsl,chip-spdif and list all chip-spdif in compatible list? I added 'fsl,fsl-spdif' just for those

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Nicolin Chen
fsl,imx6q-spdif here, because all other cases should be completely compatible with this one. They are only different in the clock source names list, which's already being specified in dts file. Please correct me if you think this still isn't proper. Best regards, Nicolin Chen

Re: [PATCH v4 resent 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Nicolin Chen
you, Nicolin Chen ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH v4 resent 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Nicolin Chen
need to touch the name lists any more. Thank you, Nicolin Chen ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Nicolin Chen
, not the ideal way -- SoC-independent, since the clock sources are based on SoC design, not on itself. Thank you, Nicolin Chen ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v4 resent 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Nicolin Chen
into DT. I'll revise it in next ver. Thank you, Nicolin Chen ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH v4 resent 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Nicolin Chen
version. Please take a look after I send it. Thank you, Nicolin Chen ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-15 Thread Nicolin Chen
This patch add S/PDIF controller driver for Freescale SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 76 ++ sound/soc/fsl/Kconfig |3 + sound/soc/fsl/Makefile |2

[PATCH v5 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-15 Thread Nicolin Chen
one applied patch for spdif dummy codec drivers. * Use generic DMA DT binding. * Let spdif controller driver calculate the clock div. * Added one optional clock source for spdif tx. * Reivsed documentation accordingly. Nicolin Chen (2): ASoC: fsl: Add S/PDIF CPU DAI driver ASoC: fsl: Add

[PATCH v5 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-15 Thread Nicolin Chen
Add S/PDIF machine driver for Freescale i.MX series SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig | 11 ++ sound/soc/fsl/Makefile |2

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-15 Thread Nicolin Chen
a bit more on meaning of this property? I think the rx-clksrc-lock property should be included in DT as well, since it's exactly a available clock source for rx. But I guess I just need to figure out a better way or a more elaborated description. Thank you, Nicolin Chen

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-16 Thread Nicolin Chen
-lock' is present, that means ASRC will get a clock source indirectly from coaxial cable that contains the sample rate information. So it can know what input sample rate is and do his own procedure accordingly. Thank you, Nicolin Chen ___ Linuxppc-dev

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-16 Thread Nicolin Chen
and merged into mainline :( But I still don't get why we need to be so obsessed to make this impenetrable rule of devicetree that we here have to sacrifice something we could have reasonably done. And thank you for the comments again, Sascha. Nicolin Chen

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-16 Thread Nicolin Chen
and improve it later. You'll make it easier for us all. Thank you for explain all these to the despicable me. I'll try to make myself more comfortable with rules here. Best regards, Nicolin Chen ___ Linuxppc-dev mailing list Linuxppc-dev

[PATCH v6 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-16 Thread Nicolin Chen
for spdif tx. * Reivsed documentation accordingly. Nicolin Chen (2): ASoC: fsl: Add S/PDIF CPU DAI driver ASoC: fsl: Add S/PDIF machine driver .../devicetree/bindings/sound/fsl,spdif.txt| 56 + .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig

[PATCH v6 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-16 Thread Nicolin Chen
Add S/PDIF machine driver for Freescale i.MX series SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig | 11 ++ sound/soc/fsl/Makefile |2

[PATCH v6 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-16 Thread Nicolin Chen
This patch add S/PDIF controller driver for Freescale SoC. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 56 + sound/soc/fsl/Kconfig |3 + sound/soc/fsl/Makefile |2

Re: [PATCH v6 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-18 Thread Nicolin Chen
its true value from the physical registers not from cache. Best regards, Nicolin Chen ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
with physical memory each time when using regmap_read/write/update_bits(). But I think I can try to use the regcache_bypass instead. Thank you, Nicolin Chen ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
Thank you. Nicolin Chen ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH v7 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-19 Thread Nicolin Chen
tag from the commit of patch-1. v1-v2: * Dropped one applied patch for spdif dummy codec drivers. * Use generic DMA DT binding. * Let spdif controller driver calculate the clock div. * Added one optional clock source for spdif tx. * Reivsed documentation accordingly. Nicolin Chen (2): ASoC

[PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
This patch implements a device-tree-only CPU DAI driver for Freescale S/PDIF controller that supports stereo playback and record feature. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 56 + sound/soc/fsl/Kconfig

[PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Nicolin Chen
This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl

Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
Hi Mark, Thank you for the commenst. I'll Fix them in v8. Here are some remaining question: On Mon, Aug 19, 2013 at 10:18:09AM +0100, Mark Rutland wrote: +Required properties: + + - compatible : Compatible list, contains fsl,chip-spdif. What are valid values for chip? The

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Nicolin Chen
Hi, On Mon, Aug 19, 2013 at 10:24:58AM +0100, Mark Rutland wrote: Is this used semantically, or is it a completely arbitrary string? In either case I don't see why the compatible string doesn't give the driver enough to have a sensible value. I'm confused as to why we need this. The phrase

Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
On Mon, Aug 19, 2013 at 10:54:33AM +0100, Mark Rutland wrote: I see, so 'Compatible list, must contains fsl,imx35-spdif' would be okay? While that needs to be mentioned, other values which might be present (e.g. fsl,imx6q-spdif) must be mentioned, or we can't rely on them if we want to use

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Nicolin Chen
On Mon, Aug 19, 2013 at 11:01:43AM +0100, Mark Rutland wrote: At least they are separate drivers as I mentioned in the commit comments. I'm not sure that the boundary of Linux drivers should necessarily determine the way we carve up the description of IP blocks, though presumably it's a

Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
can refer to the RM, since you just got it. The diagram doesn't show which one you mentioned is true. But I think we can understand in both ways. I'm going to send a v8. So I think I don't need to modify the description right? Thank you Nicolin Chen

[PATCH v8 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-19 Thread Nicolin Chen
one optional clock source for spdif tx. * Reivsed documentation accordingly. Nicolin Chen (2): ASoC: fsl: Add S/PDIF CPU DAI driver ASoC: fsl: Add S/PDIF machine driver .../devicetree/bindings/sound/fsl,spdif.txt| 54 + .../devicetree/bindings/sound/imx-audio-spdif.txt | 29

[PATCH v8 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Nicolin Chen
This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl

[PATCH v8 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
This patch implements a device-tree-only CPU DAI driver for Freescale S/PDIF controller that supports stereo playback and record feature. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 54 + sound/soc/fsl/Kconfig

Re: [PATCH v8 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
Thank you Sascha, I'll revise them all in v9 On Mon, Aug 19, 2013 at 02:34:49PM +0200, Sascha Hauer wrote: Hi Nicolas, Some misc other comments inline. On Mon, Aug 19, 2013 at 08:08:48PM +0800, Nicolin Chen wrote: This patch implements a device-tree-only CPU DAI driver for Freescale

Re: [PATCH v8 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
On Mon, Aug 19, 2013 at 03:35:58PM -0600, Stephen Warren wrote: + core The core clock of spdif controller + rxtx0-7 Clock source list for tx and rx clock. + This clock list should be identical to + the source list connecting to the spdif

[PATCH v9 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-19 Thread Nicolin Chen
: * Removed a wrong tag from the commit of patch-1. v1-v2: * Dropped one applied patch for spdif dummy codec drivers. * Use generic DMA DT binding. * Let spdif controller driver calculate the clock div. * Added one optional clock source for spdif tx. * Reivsed documentation accordingly. Nicolin Chen

[PATCH v9 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
This patch implements a device-tree-only CPU DAI driver for Freescale S/PDIF controller that supports stereo playback and record feature. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 54 + sound/soc/fsl/Kconfig

[PATCH v9 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Nicolin Chen
This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl

Re: [alsa-devel] [PATCH v8 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-20 Thread Nicolin Chen
On Tue, Aug 20, 2013 at 11:28:10PM +0100, Mark Brown wrote: On Tue, Aug 20, 2013 at 01:53:49PM -0600, Stephen Warren wrote: On 08/20/2013 01:07 PM, Mark Brown wrote: The point is that it might turn into a more correct binding depending on what the S/PDIF device actually is. There's

[PATCH v10 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-20 Thread Nicolin Chen
This patch implements a device-tree-only CPU DAI driver for Freescale S/PDIF controller that supports stereo playback and record feature. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 54 + sound/soc/fsl/Kconfig

[PATCH v10 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-20 Thread Nicolin Chen
This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl

[PATCH v10 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-20 Thread Nicolin Chen
for spdif tx. * Reivsed documentation accordingly. Nicolin Chen (2): ASoC: fsl: Add S/PDIF CPU DAI driver ASoC: fsl: Add S/PDIF machine driver .../devicetree/bindings/sound/fsl,spdif.txt| 54 + .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig

Re: [PATCH v10 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-22 Thread Nicolin Chen
Hi Stephen, On Wed, Aug 21, 2013 at 12:30:59PM -0600, Stephen Warren wrote: I still don't think those two properties are correct. Exactly what node will those phandles point at? There definitely should not be a DT node for any dummy CODEC, irrespective of whether this binding calls the

[PATCH v11] ASoC: fsl: Add S/PDIF machine driver

2013-08-23 Thread Nicolin Chen
This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. Signed-off-by: Nicolin Chen b42...@freescale.com --- Changelog v10-v11: * Use boolean properties for spdif-out/in switch instead of codec

Re: [alsa-devel] [PATCH v11] ASoC: fsl: Add S/PDIF machine driver

2013-08-26 Thread Nicolin Chen
On Fri, Aug 23, 2013 at 08:13:53PM +0100, Mark Brown wrote: On Fri, Aug 23, 2013 at 01:08:28PM -0600, Stephen Warren wrote: On 08/23/2013 02:04 AM, Nicolin Chen wrote: This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter

[PATCH v12] ASoC: fsl: Add S/PDIF machine driver

2013-08-27 Thread Nicolin Chen
This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. Signed-off-by: Nicolin Chen b42...@freescale.com --- Changelog v11-v12: * Dropped unused spdif_pdev. * Register spdif-dit/dir depending

[PATCH 1/2] ASoC: fsl: Add wrapping for dev_dbg() in fsl_spdif.c

2013-08-30 Thread Nicolin Chen
Add wrapping '\n' for dev_dbg() in fsl_spdif.c Signed-off-by: Nicolin Chen b42...@freescale.com --- sound/soc/fsl/fsl_spdif.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index e93dc0d..98741e9 100644

Re: [PATCH 1/2] ASoC: fsl_sai: Reset FIFOs after disabling TE/RE

2014-07-23 Thread Nicolin Chen
Sir, I found this two patches are merged into for-next branch, although I haven't got the 'applied' email. Is that possible for you to drop this one? If not, I'll send another patch to fix this. Thank you, Nicolin On Fri, Jul 18, 2014 at 06:18:12PM +0800, Nicolin Chen wrote: Mark

Re: [PATCH 1/2] ASoC: fsl_sai: Reset FIFOs after disabling TE/RE

2014-07-23 Thread Nicolin Chen
On Wed, Jul 23, 2014 at 11:07:46AM +0100, Mark Brown wrote: On Wed, Jul 23, 2014 at 05:52:32PM +0800, Nicolin Chen wrote: I found this two patches are merged into for-next branch, although I haven't got the 'applied' email. Is that possible for you to drop this one? If not, I'll send

[PATCH 0/3] ASoC: fsl_sai: Fix some issues in fsl_sai_trigger()

2014-07-23 Thread Nicolin Chen
The series of patches focus on issue fix inside fsl_sai_trigger(). Nicolin Chen (3): ASoC: fsl_sai: Reduce race condition during TE/RE enabling ASoC: fsl_sai: Don't reset FIFO until TE/RE bit is unset ASoC: fsl_sai: Improve enable flow in fsl_sai_trigger() sound/soc/fsl/fsl_sai.c | 40

[PATCH 1/3] ASoC: fsl_sai: Reduce race condition during TE/RE enabling

2014-07-23 Thread Nicolin Chen
From: Nicolin Chen guangyu.c...@freescale.com For trigger start, we don't need to check if it's the first time to enable TE/RE or second time. It doesn't hurt to enable them any way, which in the meantime can reduce race condition for TE/RE enabling. For trigger stop, we will definitely clear

[PATCH 2/3] ASoC: fsl_sai: Don't reset FIFO until TE/RE bit is unset

2014-07-23 Thread Nicolin Chen
From: Nicolin Chen guangyu.c...@freescale.com TE/RE bit of T/RCSR will remain set untill the current frame is physically finished. The FIFO reset operation should wait this bit's totally cleared rather than ignoring its status which might cause TE/RE disabling failed. This patch adds delay

[PATCH 3/3] ASoC: fsl_sai: Improve enable flow in fsl_sai_trigger()

2014-07-23 Thread Nicolin Chen
From: Nicolin Chen guangyu.c...@freescale.com The previous enable flow: 1, Enable TERE (SAI starts to consume tx FIFO and feed rx FIFO) 2, Mask IRQ of Tx/Rx to enable its interrupt. 3, Enable DMA request of Tx/Rx. As this flow would enable DMA request later than TERE, the Tx FIFO would be easily

[PATCH v2 0/2] Add Freescale ASRC driver

2014-07-24 Thread Nicolin Chen
in fsl_asrc_dma.c driver. * PATCH-2: Refined commit comments. Nicolin Chen (2): ARM: imx: Add the secondary request into the structure for imx-sdma ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers .../devicetree/bindings/sound/fsl,asrc.txt | 62 ++ include/linux/platform_data/dma

[PATCH v2 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma

2014-07-24 Thread Nicolin Chen
either side later since this patch won't break any function and meanwhile it can make merge window more smoothly: we don't need to apply the change inside dmaengine branch via ASoC tree any more. -- Nicolin ] Signed-off-by: Nicolin Chen nicoleots...@gmail.com --- include/linux/platform_data/dma

[PATCH v2 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Nicolin Chen
. It converts the original sample rate to a common rate supported by Back Ends for playback while converts the common rate of Back Ends to a desired rate for capture. It has 3 pairs to support three different substreams within totally 10 channels. Signed-off-by: Nicolin Chen nicoleots...@gmail.com

Re: [RFC][PATCH 0/2] Add ASRC Peripheral to Peripheral driver

2014-07-24 Thread Nicolin Chen
On Fri, Jun 13, 2014 at 06:07:03PM +0800, Nicolin Chen wrote: This series of patches have a direct dependency between them. So we might need to push them into one branch. And sorry for this :( Patch-1 adds device to device support in SDMA driver along with a secondary request in struct

Re: [PATCH v2 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Nicolin Chen
Hi Tobias, On Thu, Jul 24, 2014 at 05:20:45PM +0200, Tobias Klauser wrote: On 2014-07-24 at 10:35:29 +0200, Nicolin Chen nicoleots...@gmail.com wrote: The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a signal associated with an input clock into a signal

[PATCH v3 0/2] Add Freescale ASRC driver

2014-07-24 Thread Nicolin Chen
() in fsl_asrc_dma_pcm_new() * PATCH-2: Added substream check in fsl_asrc_dma_pcm_new() v2: * PATCH-1: Dropped the change to SDMA driver. * PATCH-2: Dropped useless member in private data structures. * PATCH-2: Refined some comments in fsl_asrc_dma.c driver. * PATCH-2: Refined commit comments. Nicolin Chen (2

[PATCH v3 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma

2014-07-24 Thread Nicolin Chen
either side later since this patch won't break any function and meanwhile it can make merge window more smoothly: we don't need to apply the change inside dmaengine branch via ASoC tree any more. -- Nicolin ] Signed-off-by: Nicolin Chen nicoleots...@gmail.com Acked-by: Shawn Guo shawn

[PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Nicolin Chen
. It converts the original sample rate to a common rate supported by Back Ends for playback while converts the common rate of Back Ends to a desired rate for capture. It has 3 pairs to support three different substreams within totally 10 channels. Signed-off-by: Nicolin Chen nicoleots...@gmail.com

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Nicolin Chen
Hi Varka, On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote: On 07/25/2014 09:33 AM, Nicolin Chen wrote: The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a signal associated with an input clock into a signal associated with a different output clock

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Nicolin Chen
Hi Varka, Regarding a point you suggested. On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote: On 07/25/2014 09:33 AM, Nicolin Chen wrote: (...) + +static const struct platform_device_id fsl_asrc_devtype[] = { +{ +.name = imx35-asrc

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Nicolin Chen
On Fri, Jul 25, 2014 at 11:47:42AM +0530, Varka Bhadram wrote: Hi Nicolin, On 07/25/2014 11:24 AM, Nicolin Chen wrote: Hi Varka, Regarding a point you suggested. On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote: On 07/25/2014 09:33 AM, Nicolin Chen wrote

[PATCH v4 0/2] Add Freescale ASRC driver

2014-07-25 Thread Nicolin Chen
: Added substream check in fsl_asrc_dma_pcm_new() v2: * PATCH-1: Dropped the change to SDMA driver. * PATCH-2: Dropped useless member in private data structures. * PATCH-2: Refined some comments in fsl_asrc_dma.c driver. * PATCH-2: Refined commit comments. Nicolin Chen (2): ARM: imx: Add

[PATCH v4 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma

2014-07-25 Thread Nicolin Chen
either side later since this patch won't break any function and meanwhile it can make merge window more smoothly: we don't need to apply the change inside dmaengine branch via ASoC tree any more. -- Nicolin ] Signed-off-by: Nicolin Chen nicoleots...@gmail.com Acked-by: Shawn Guo shawn

[PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Nicolin Chen
. It converts the original sample rate to a common rate supported by Back Ends for playback while converts the common rate of Back Ends to a desired rate for capture. It has 3 pairs to support three different substreams within totally 10 channels. Signed-off-by: Nicolin Chen nicoleots...@gmail.com

Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Nicolin Chen
Hi Varka, Thank you for the comments! On Fri, Jul 25, 2014 at 01:05:05PM +0530, Varka Bhadram wrote: On 07/25/2014 12:49 PM, Nicolin Chen wrote: (...) +static const struct platform_device_id fsl_asrc_devtype[] = { +{ +.name = imx35-asrc, +.driver_data

[PATCH v5 0/2] Add Freescale ASRC driver

2014-07-25 Thread Nicolin Chen
. * PATCH-2: Refined commit comments. Nicolin Chen (2): ARM: imx: Add the secondary request into the structure for imx-sdma ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers .../devicetree/bindings/sound/fsl,asrc.txt | 60 ++ include/linux/platform_data/dma-imx.h | 1

[PATCH v5 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma

2014-07-25 Thread Nicolin Chen
either side later since this patch won't break any function and meanwhile it can make merge window more smoothly: we don't need to apply the change inside dmaengine branch via ASoC tree any more. -- Nicolin ] Signed-off-by: Nicolin Chen nicoleots...@gmail.com Acked-by: Shawn Guo shawn

[PATCH v5 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Nicolin Chen
. It converts the original sample rate to a common rate supported by Back Ends for playback while converts the common rate of Back Ends to a desired rate for capture. It has 3 pairs to support three different substreams within totally 10 channels. Signed-off-by: Nicolin Chen nicoleots...@gmail.com

Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Nicolin Chen
On Fri, Jul 25, 2014 at 02:13:10PM +0530, Varka Bhadram wrote: On 07/25/2014 01:27 PM, Nicolin Chen wrote: + if (IS_ERR(asrc_priv-regmap)) { + dev_err(pdev-dev, failed to init regmap\n); + return PTR_ERR(asrc_priv-regmap); + } + + irq = platform_get_irq(pdev, 0

Re: [PATCH v5 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Nicolin Chen
Hi Varka, On Fri, Jul 25, 2014 at 05:04:11PM +0530, Varka Bhadram wrote: On 07/25/2014 02:16 PM, Nicolin Chen wrote: The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a signal associated with an input clock into a signal associated with a different output clock

[PATCH v6 0/2] Add Freescale ASRC driver

2014-07-29 Thread Nicolin Chen
useless member in private data structures. * PATCH-2: Refined some comments in fsl_asrc_dma.c driver. * PATCH-2: Refined commit comments. Nicolin Chen (2): ARM: imx: Add the secondary request into the structure for imx-sdma ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers .../devicetree

[PATCH v6 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-29 Thread Nicolin Chen
. It converts the original sample rate to a common rate supported by Back Ends for playback while converts the common rate of Back Ends to a desired rate for capture. It has 3 pairs to support three different substreams within totally 10 channels. Signed-off-by: Nicolin Chen nicoleots...@gmail.com

[PATCH v6 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma

2014-07-29 Thread Nicolin Chen
either side later since this patch won't break any function and meanwhile it can make merge window more smoothly: we don't need to apply the change inside dmaengine branch via ASoC tree any more. -- Nicolin ] Signed-off-by: Nicolin Chen nicoleots...@gmail.com Acked-by: Shawn Guo shawn

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-29 Thread Nicolin Chen
On Tue, Jul 29, 2014 at 10:46:13AM +0100, Mark Rutland wrote: + - big-endian : If this property is absent, the native endian mode will + be in use as default, or the big endian mode will be in use + for all the device registers. Native endian is

[PATCH 0/4] ASoC: fsl: Add stream names to CPU DAI drivers for DPCM

2014-07-29 Thread Nicolin Chen
. Document for DPCM: ./Documentation/sound/alsa/soc/DPCM.txt Nicolin Chen (4): ASoC: fsl_esai: Add stream names for DPCM usage ASoC: fsl_sai: Add stream names for DPCM usage ASoC: fsl_spdif: Add stream names for DPCM usage ASoC: fsl_ssi: Add stream names for DPCM usage sound/soc/fsl/fsl_esai.c

  1   2   3   4   5   6   7   8   >