Re: [PATCH v3] console: use first console if stdout-path device doesn't appear

2016-11-07 Thread Paul Burton
Hi Larry, On Monday, 7 November 2016 09:26:37 GMT Larry Finger wrote: > > A revert was already submitted by Hans de Goede & is being discussed over > > here: > > > > https://marc.info/?l=linux-kernel=147826151427455=2 > > I am a little surprised that I was not CCd on that thread. Hans started

Re: [PATCH v3] console: use first console if stdout-path device doesn't appear

2016-11-07 Thread Paul Burton
On Monday, 7 November 2016 19:27:32 GMT Michael Ellerman wrote: > Paul Burton <paul.bur...@imgtec.com> writes: > > If a device tree specified a preferred device for kernel console output > > via the stdout-path or linux,stdout-path chosen node properties there's > > no

[PATCH] console: use first console if stdout-path device doesn't appear

2016-10-18 Thread Paul Burton
- testing would be most appreciated. Signed-off-by: Paul Burton <paul.bur...@imgtec.com> Fixes: 05fd007e4629 ("console: don't prefer first registered if DT specifies stdout-path") Reported-by: Andreas Schwab <sch...@linux-m68k.org> Cc: Andreas Schwab <sch...@linux-m6

Re: [PATCH v2] console: Don't prefer first registered if DT specifies stdout-path

2016-10-18 Thread Paul Burton
On Monday, 17 October 2016 19:39:57 BST Andreas Schwab wrote: > On Okt 17 2016, Paul Burton <paul.bur...@imgtec.com> wrote: > > Could you share the device tree from your system? > > This is the contents of chosen/linux,stdout-path on the systems I have: > &g

[PATCH v3] console: use first console if stdout-path device doesn't appear

2016-11-03 Thread Paul Burton
their console later than they did prior to commit 05fd007e4629 ("console: don't prefer first registered if DT specifies stdout-path") but should otherwise produce the same output. Tested in QEMU with a PowerPC pseries_defconfig kernel. Signed-off-by: Paul Burton <paul.bur...@imgt

Re: [PATCH v2] console: use first console if stdout-path device doesn't appear

2016-11-03 Thread Paul Burton
On Monday, 31 October 2016 18:31:43 GMT Larry Finger wrote: > On 10/31/2016 06:09 PM, Sergey Senozhatsky wrote: > > Hi, > > > > On (10/31/16 15:50), Paul Burton wrote: > > [..] > > > >> Actually whilst this fixes the output in QEMU it has other prob

Re: [PATCH v3] console: use first console if stdout-path device doesn't appear

2016-11-03 Thread Paul Burton
Hi Sergey, On Friday, 4 November 2016 02:40:40 GMT Sergey Senozhatsky wrote: > On (11/03/16 12:57), Paul Burton wrote: > > If a device tree specified a preferred device for kernel console output > > via the stdout-path or linux,stdout-path chosen node properties there's &

[PATCH v2] console: use first console if stdout-path device doesn't appear

2016-10-31 Thread Paul Burton
pseries_defconfig kernel. Signed-off-by: Paul Burton <paul.bur...@imgtec.com> Fixes: 05fd007e4629 ("console: don't prefer first registered if DT specifies stdout-path") Reported-by: Andreas Schwab <sch...@linux-m68k.org> Reported-by: Larry Finger <larry.fin...@lwfinger.

Re: [PATCH] console: use first console if stdout-path device doesn't appear

2016-10-31 Thread Paul Burton
Hi Michael et al, On Monday, 31 October 2016 16:28:59 GMT Michael Ellerman wrote: > Andreas Schwab writes: > > Any news? > > We discovered it also breaks VGA on qemu, which presumably is not the > type of news you were hoping for. On the contrary, that's wonderful news -

Re: [PATCH v2] console: use first console if stdout-path device doesn't appear

2016-10-31 Thread Paul Burton
On Monday, 31 October 2016 12:14:55 GMT Paul Burton wrote: > If a device tree specified a preferred device for kernel console output > via the stdout-path or linux,stdout-path chosen node properties there's > no guarantee that it will have specified a device for which we have a > dr

Re: [PATCH v2] console: Don't prefer first registered if DT specifies stdout-path

2016-10-17 Thread Paul Burton
On Sunday, 16 October 2016 20:07:18 BST Andreas Schwab wrote: > On Aug 09 2016, Paul Burton <paul.bur...@imgtec.com> wrote: > > Fix this by not automatically preferring the first registered console if > > one is specified by the device tree. This allows consoles

[PATCH 0/3] Resolve -Wattribute-alias warnings from SYSCALL_DEFINEx()

2018-06-15 Thread Paul Burton
ro for controlling warnings to linux/compiler.h disable -Wattribute-alias warning for SYSCALL_DEFINEx() Paul Burton (1): Revert "powerpc: fix build failure by disabling attribute-alias warning in pci_32" arch/powerpc/kernel/pci_32.c | 4 --- include/linux/compat.h | 8 +

[PATCH 2/3] disable -Wattribute-alias warning for SYSCALL_DEFINEx()

2018-06-15 Thread Paul Burton
sion arguments to __diag_ignore() in order to match changes to the preceding patch. - Add the comment argument to match the preceding patch.] Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82435 Signed-off-by: Arnd Bergmann Signed-off-by: Paul Burton Cc: Michal Marek Cc: Masahiro Yamada

[PATCH 3/3] Revert "powerpc: fix build failure by disabling attribute-alias warning in pci_32"

2018-06-15 Thread Paul Burton
With SYSCALL_DEFINEx() disabling -Wattribute-alias generically, there's no need to duplicate that for PowerPC's pciconfig_iobase syscall. This reverts commit 415520373975 ("powerpc: fix build failure by disabling attribute-alias warning in pci_32"). Signed-off-by: Paul Burton Cc: Mi

[PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-15 Thread Paul Burton
of the macros but serves to push people to document the reason for using them - per feedback from Kees Cook.] Signed-off-by: Arnd Bergmann Signed-off-by: Paul Burton Cc: Michal Marek Cc: Masahiro Yamada Cc: Douglas Anderson Cc: Al Viro Cc: Heiko Carstens Cc: Mauro Carvalho Chehab Cc: Matthew

Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-19 Thread Paul Burton
Hi Masahiro, On Wed, Jun 20, 2018 at 02:34:35AM +0900, Masahiro Yamada wrote: > 2018-06-16 9:53 GMT+09:00 Paul Burton : > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > > index f1a7492a5cc8..aba64a2912d8 100644 > > --- a/include/linux/compiler-gc

[PATCH v2 0/3] Resolve -Wattribute-alias warnings from SYSCALL_DEFINEx()

2018-06-19 Thread Paul Burton
_DEFINEx() Paul Burton (1): powerpc: Remove -Wattribute-alias pragmas arch/powerpc/kernel/pci_32.c| 4 arch/powerpc/kernel/pci_64.c| 4 arch/powerpc/kernel/rtas.c | 4 arch/powerpc/kernel/signal_32.c | 8 arch/powerpc/kernel/signal_64.c | 4 arch

[PATCH v2 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-19 Thread Paul Burton
ine macros for versions that we need to introduce pragmas for, and as of this series that's just GCC 8. - Capitalize comments in linux/compiler-gcc.h to match the style of the rest of the file. - Line up macro definitions with tabs in linux/compiler-gcc.h.] Signed-off-by: Arnd Berg

[PATCH v2 2/3] disable -Wattribute-alias warning for SYSCALL_DEFINEx()

2018-06-19 Thread Paul Burton
sion arguments to __diag_ignore() in order to match changes to the preceding patch. - Add the comment argument to match the preceding patch.] Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82435 Signed-off-by: Arnd Bergmann Signed-off-by: Paul Burton Tested-by: Christophe Leroy Tested-by: Staf

[PATCH v2 3/3] powerpc: Remove -Wattribute-alias pragmas

2018-06-19 Thread Paul Burton
ld by disabling attribute-alias warning for SYSCALL_DEFINEx"). Signed-off-by: Paul Burton Cc: Michal Marek Cc: Masahiro Yamada Cc: Douglas Anderson Cc: Al Viro Cc: Heiko Carstens Cc: Mauro Carvalho Chehab Cc: Matthew Wilcox Cc: Matthias Kaehlcke Cc: Arnd Bergmann Cc: Ingo Molnar Cc: Josh

Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-20 Thread Paul Burton
Hi Masahiro, On Thu, Jun 21, 2018 at 08:21:01AM +0900, Masahiro Yamada wrote: > V2 is good except one nit. > (I left a comment in it) Thanks, and yes I agree with your comment that the GCC<4.6 __diag() definition can be removed. > I can fix it up locally if it is tedious to re-spin, though. If

Re: [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives

2018-07-24 Thread Paul Burton
ook good - I don't see any issues & they pass a build test (using cavium_octeon_defconfig which enables huge pages), so: Acked-by: Paul Burton # MIPS parts Thanks, Paul

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

2018-09-06 Thread Paul Burton
s to only be > dtc. > > This change enables support 'dtbs_install' on some arches which were > missing the target. > >% > Signed-off-by: Rob Herring > --- > Please ack so I can take the whole series via the DT tree. For MIPS: Acked-by: Paul Burton Thanks, Paul

Re: [RFC PATCH] lib: Introduce generic __cmpxchg_u64() and use it where needed

2018-10-31 Thread Paul Burton
Hi Guenter, On Wed, Oct 31, 2018 at 12:52:18PM -0700, Guenter Roeck wrote: > +/* > + * Generic version of __cmpxchg_u64, to be used for cmpxchg64(). > + * Takes u64 parameters. > + */ > +u64 __cmpxchg_u64(u64 *ptr, u64 old, u64 new) > +{ > + raw_spinlock_t *lock = lock_addr(ptr); > +

Re: [RFC PATCH] lib: Introduce generic __cmpxchg_u64() and use it where needed

2018-10-31 Thread Paul Burton
(Copying SunRPC & net maintainers.) Hi Guenter, On Wed, Oct 31, 2018 at 03:02:53PM -0700, Guenter Roeck wrote: > The alternatives I can see are > - Do not use cmpxchg64() outside architecture code (ie drop its use from > the offending driver, and keep doing the same whenever the problem comes

Re: [PATCH v2 1/2] kbuild: replace cc-name test with CONFIG_CC_IS_CLANG

2018-10-30 Thread Paul Burton
stage. > Use CONFIG_CC_IS_CLANG, instead. > > Signed-off-by: Masahiro Yamada > Acked-by: Michael Ellerman (powerpc) Looks good to me: Acked-by: Paul Burton (MIPS) Thanks, Paul

Re: [RFC PATCH] lib: Introduce generic __cmpxchg_u64() and use it where needed

2018-11-01 Thread Paul Burton
Hi Trond, On Thu, Nov 01, 2018 at 12:17:31AM +, Trond Myklebust wrote: > On Wed, 2018-10-31 at 23:32 +0000, Paul Burton wrote: > > In this particular case I have no idea why > > net/sunrpc/auth_gss/gss_krb5_seal.c is using cmpxchg64() at all. It's > > es

Re: [PATCH 05/17] mips: Remove support for BZIP2 and LZMA compressed kernel

2018-11-13 Thread Paul Burton
s += vmlinux.lzmo.its > targets += vmlinux.lzo.its It looks to me like this "vmlinux.lzmo.its" was a typo & ought to have been vmlinux.lzma.its, and thus ought to be removed. Apart from that I'm fine with this in general: Acked-by: Paul Burton Thanks, Paul

Re: [PATCH] memblock: stop using implicit alignement to SMP_CACHE_BYTES

2018-10-09 Thread Paul Burton
SMP_CACHE_BYTES and stop implicit alignment assignment in the > memblock internal allocation functions. > >% > > Suggested-by: Michal Hocko > Signed-off-by: Mike Rapoport Acked-by: Paul Burton # MIPS part Thanks, Paul

Re: Checkpatch bad Warning (Re: [PATCH] powerpc/kgdb: add kgdb_arch_set/remove_breakpoint())

2018-09-20 Thread Paul Burton
Hi Christophe, On Thu, Sep 20, 2018 at 01:23:55AM +, Christophe Leroy wrote: > On 09/20/2018 01:19 PM, Christophe LEROY wrote: > > Le 20/09/2018 à 15:13, Michael Ellerman a écrit : > > > Joe Perches writes: > > > > On Tue, 2018-09-18 at 09:33 +, Christophe Leroy wrote: > > > > > On the

Re: [PATCH 12/21] arch: use memblock_alloc() instead of memblock_alloc_from(size, align, 0)

2019-01-18 Thread Paul Burton
Hi Mike, On Wed, Jan 16, 2019 at 03:44:12PM +0200, Mike Rapoport wrote: > The last parameter of memblock_alloc_from() is the lower limit for the > memory allocation. When it is 0, the call is equivalent to > memblock_alloc(). > > Signed-off-by: Mike Rapoport Acked-by: Paul Burt

Re: [PATCH 19/21] treewide: add checks for the return value of memblock_alloc*()

2019-01-18 Thread Paul Burton
b) > + panic("%s: Failed to allocate %lu bytes align=%lx\n", > + __func__, swiotlbsize, PAGE_SIZE); > > if (swiotlb_init_with_tbl(octeon_swiotlb, swiotlb_nslabs, 1) == -ENOMEM) > panic("Cannot allocate SWIOTLB buf

Re: [PATCH 1/2] mips/kgdb: prepare arch_kgdb_ops for constness

2018-12-06 Thread Paul Burton
t it can be changed to > > const in following patch, as recommended by checkpatch.pl > > > > Suggested-by: Paul Burton > > Signed-off-by: Christophe Leroy > > From my side this is > Acked-by: Daniel Thompson > > Since this is a dependency for the next patch I

Re: [PATCH v2 16/15] syscall_get_arch: add "struct task_struct *" argument

2018-11-21 Thread Paul Burton
Hi Dmitry, On Wed, Nov 21, 2018 at 03:44:22AM +0300, Dmitry V. Levin wrote: > This argument is required to extend the generic ptrace API > with PTRACE_GET_SYSCALL_INFO request: syscall_get_arch() is going to be > called from ptrace_request() along with other syscall_get_* functions > with a

Re: [PATCH v2 16/15 v2] syscall_get_arch: add "struct task_struct *" argument

2018-11-21 Thread Paul Burton
rg > Cc: nios2-...@lists.rocketboards.org > Cc: openr...@lists.librecores.org > Cc: sparcli...@vger.kernel.org > Cc: uclinux-h8-de...@lists.sourceforge.jp > Cc: x...@kernel.org > Signed-off-by: Dmitry V. Levin > --- > > v2: cleaned up mips part, added Reviewed-by I thought the last one was v2? :) Anyway, this looks fine to me now: Acked-by: Paul Burton # MIPS parts Thanks, Paul

Re: [PATCH 3/9] MIPS: remove the HT_PCI config option

2018-11-19 Thread Paul Burton
Hi Christoph, On Thu, Nov 15, 2018 at 08:05:31PM +0100, Christoph Hellwig wrote: > This option is always selected from LOONGSON_MACH3X. Switch to just > seleting PCI from that option and definining LOONGSON_PCIIO_BASE based > on CONFIG_LOONGSON_MACH3X. > > Signed-off-by: Christoph Hellwig >

Re: [PATCH 3/9] MIPS: remove the HT_PCI config option

2018-11-19 Thread Paul Burton
On Mon, Nov 19, 2018 at 01:01:41PM -0800, Paul Burton wrote: > On Thu, Nov 15, 2018 at 08:05:31PM +0100, Christoph Hellwig wrote: > > This option is always selected from LOONGSON_MACH3X. Switch to just > > seleting PCI from that option and definining LOONGSON_P

Re: [PATCH 4/9] PCI: consolidate PCI config entry in drivers/pci

2018-11-19 Thread Paul Burton
o for PCI on and the handle the > rest in drivers/pci. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Palmer Dabbelt > Acked-by: Max Filippov > Acked-by: Thomas Gleixner > Acked-by: Bjorn Helgaas > Acked-by: Geert Uytterhoeven For patches 4, 5, 7, 8 & 9: Acked-

Re: [PATCH 11/15] mips: fix n32 compat_ipc_parse_version

2019-01-10 Thread Paul Burton
tested. Please review accordingly. Nice catch! Would you prefer to merge this yourself, or that I take it through the mips tree? If the former then: Acked-by: Paul Burton I suspect kernels configured with n32 support but no o32 support are probably not very common - for internal testing we cur

Re: [PATCH 11/15] mips: fix n32 compat_ipc_parse_version

2019-01-11 Thread Paul Burton
Hello, Arnd Bergmann wrote: > While reading through the sysvipc implementation, I noticed that the n32 > semctl/shmctl/msgctl system calls behave differently based on whether > o32 support is enabled or not: Without o32, the IPC_64 flag passed by > user space is rejected but calls without that

Re: [PATCH 5/6 v3] syscalls: Remove start and number from syscall_get_arguments() args

2019-04-03 Thread Paul Burton
t; Cc: openr...@lists.librecores.org > Cc: linux-par...@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-ri...@lists.infradead.org > Cc: linux-s...@vger.kernel.org > Cc: linux...@vger.kernel.org > Cc: sparcli...@vger.kernel.org > Cc: linux...@lists.infradead.org > Cc: linux-

Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere

2019-03-25 Thread Paul Burton
Hi Arnd, On Mon, Mar 25, 2019 at 03:47:37PM +0100, Arnd Bergmann wrote: > Add the io_uring and pidfd_send_signal system calls to all architectures. > > These system calls are designed to handle both native and compat tasks, > so all entries are the same across architectures, only arm-compat and

Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability

2019-02-11 Thread Paul Burton
he actual > users. Also rename the Kconfig option to describe the feature better. > > Signed-off-by: Christoph Hellwig Acked-by: Paul Burton # MIPS Thanks, Paul

Re: [PATCH] [v2] arch: add pidfd and io_uring syscalls everywhere

2019-04-15 Thread Paul Burton
-n64 instead of common. Thanks for taking care of this: Acked-by: Paul Burton # MIPS Thanks, Paul

Re: [PATCH 5/5] asm-generic: remove ptrace.h

2019-06-24 Thread Paul Burton
nclude/asm/ptrace.h | 5 --- > include/asm-generic/ptrace.h | 73 -- > 3 files changed, 79 deletions(-) > delete mode 100644 include/asm-generic/ptrace.h FWIW: Acked-by: Paul Burton Thanks, Paul > diff --git a/arch/mips/include/asm/ptrace.h b/ar

Re: [PATCH 01/15] asm-generic, x86: introduce generic pte_{alloc,free}_one[_kernel]

2019-05-02 Thread Paul Burton
Hi Mike, On Thu, May 02, 2019 at 06:28:28PM +0300, Mike Rapoport wrote: > +/** > + * pte_free_kernel - free PTE-level user page table page > + * @mm: the mm_struct of the current context > + * @pte_page: the `struct page` representing the page table > + */ > +static inline void pte_free(struct

Re: [PATCH 08/15] mips: switch to generic version of pte allocation

2019-05-02 Thread Paul Burton
isn't quite true - we don't use __GFP_ZERO in pte_alloc_one() & instead call clear_highpage() on the allocated page. Not that I have a problem with using __GFP_ZERO - it seems like the more optimal choice. It just might be worth mentioning the change & expected equivalent behavior. Otherwis

Re: [PATCH 6/6] MIPS: document mixing "slightly different CCAs"

2019-08-27 Thread Paul Burton
Hi Christoph, On Mon, Aug 26, 2019 at 03:25:53PM +0200, Christoph Hellwig wrote: > Based on an email from Paul Burton, quoting section 4.8 "Cacheability and > Coherency Attributes and Access Types" of "MIPS Architecture Volume 1: > Introduction to the MIPS32 Architecture&

Re: [PATCH 3/6] dma-mapping: remove arch_dma_mmap_pgprot

2019-08-27 Thread Paul Burton
an explicit arch opt-in. > > Signed-off-by: Christoph Hellwig > Acked-by: Geert Uytterhoeven For the MIPS bits: Acked-by: Paul Burton Thanks, Paul > --- > arch/arm/Kconfig | 2 +- > arch/arm/mm/dma-mapping.c | 6 -- > arch/a

Re: [PATCH v2 8/9] mips: numa: check the node id consistently for mips ip27

2019-08-31 Thread Paul Burton
Hi Yunsheng, On Sat, Aug 31, 2019 at 01:58:22PM +0800, Yunsheng Lin wrote: > According to Section 6.2.14 from ACPI spec 6.3 [1], the setting > of proximity domain is optional, as below: > > This optional object is used to describe proximity domain > associations within a machine. _PXM evaluates

Re: cleanup the dma_pgprot handling

2019-08-23 Thread Paul Burton
Hi Christoph, On Fri, Aug 16, 2019 at 09:07:48AM +0200, Christoph Hellwig wrote: > I'd still like to hear a confirmation from the mips folks how > the write combibe attribute can or can't work with the KSEG1 > uncached segment. Quoting section 4.8 "Cacheability and Coherency Attributes and

Re: [EXTERNAL][PATCH 1/5] PCI: Convert pci_resource_to_user to a weak function

2019-07-28 Thread Paul Burton
Hi Denis, On Sun, Jul 28, 2019 at 11:22:09PM +0300, Denis Efremov wrote: > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 9e700d9f9f28..1a19d0151b0a 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -1870,25 +1870,13 @@ static inline const char *pci_name(const

Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware

2019-09-21 Thread Paul Burton
y: Michal Hocko If you end up sending another revision then I think it would be worth replacing -1 with NUMA_NO_NODE in arch/mips/include/asm/mach-ip27/topology.h for consistency, but in any case: Acked-by: Paul Burton # MIPS bits Thanks, Paul > --- > V6: Drop the cpu_all_mask

Re: [PATCH 08/10] soc: lantiq: convert to devm_platform_ioremap_resource

2020-01-13 Thread Paul Burton
Hello, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. Applied to mips-next. > commit 23c25c732530 > https://git.kernel.org/mips/c/23c25c732530 > > Signed-off-by: Yangtao Li > Signed-off-by: Paul Burton Thanks, Paul [ This message was auto