Re: time jumps forward/backwards

2009-08-31 Thread Paul Mackerras
Ben Gamsa writes: It appears to be the case that when the time on the system is around the epoch (1970), that time will occasionally jump forward and then backward by about 17592 seconds. When it jumps forward, it always jumps back a few milliseconds later. However, it's not always easy

[PATCH] powerpc: Fix bug where perf_counters breaks oprofile

2009-09-09 Thread Paul Mackerras
of the PMU in use flag from pseries_lpar_enable_pmcs, since that is now done in its caller. This also removes the declaration of pasemi_enable_pmcs because it isn't defined anywhere. Reported-by: Maynard Johnson mpj...@us.ibm.com Signed-off-by: Paul Mackerras pau...@samba.org --- arch/powerpc/include

[PATCH] powerpc: perf_counters: Reduce stack usage of power_check_constraints

2009-09-10 Thread Paul Mackerras
know we won't get a context switch while we're in power_check_constraints(). Note that power_check_constraints() can be called during context switch but is not called from interrupts. Reported-by: Michael Ellerman mich...@ellerman.id.au Signed-off-by: Paul Mackerras pau...@samba.org --- arch/powerpc

[PATCH] perf_counter/powerpc: Fix compilation after perf_counter_overflow change

2009-09-21 Thread Paul Mackerras
-by: Sachin Sant sach...@in.ibm.com Signed-off-by: Paul Mackerras pau...@samba.org --- I missed this problem when the x86, perf_counter, bts: Optimize BTS overflow handling patch was posted because the headline made it seem entirely x86-specific, and the changes to struct perf_sample_data

Re: [PATCH] perf_counter/powerpc: Fix compilation after perf_counter_overflow change

2009-09-21 Thread Paul Mackerras
Ingo Molnar writes: Paul, you might also want to test the perfcounter bits of -tip on PowerPC a bit more frequently - this patch was there for 5 days before i sent it to Linus. Yes, I'll try to do that in future. I hope I didn't come across as blaming anyone for anything - that wasn't my

[PATCH] perf_event, powerpc: Fix compilation after big perf_counter rename

2009-09-21 Thread Paul Mackerras
-ends where they initialize their power_pmu struct.) Signed-off-by: Paul Mackerras pau...@samba.org --- arch/powerpc/include/asm/perf_event.h |4 +-- arch/powerpc/kernel/perf_event.c | 38 +- 2 files changed, 21 insertions(+), 21 deletions(-) diff

Re: [PATCH] powerpc: Prevent unsigned wrap in htab_dt_scan_page_sizes()

2009-10-14 Thread Paul Mackerras
Roel Kluin writes: Check to prevent unsigned wrap of size before subtraction. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- Is this maybe better or are we certain that size can't wrap? Patch looks good, though while you're at it, you could add a space after the while. Acked-by: Paul

[GIT PULL] perf_event/tracing/powerpc patches from Anton Blanchard

2009-10-28 Thread Paul Mackerras
Here is a series of patches from Anton Blanchard that implement some nice tracing and perf_event features on powerpc. One of them is generic perf_event stuff (adding software events for alignment faults and instruction emulation faults). Since this touches the perf_event and tracing subsystems

Re: [GIT PULL] perf_event/tracing/powerpc patches from Anton Blanchard

2009-10-28 Thread Paul Mackerras
Benjamin Herrenschmidt writes: On Thu, 2009-10-29 at 11:56 +1100, Paul Mackerras wrote: Here is a series of patches from Anton Blanchard that implement some nice tracing and perf_event features on powerpc. One of them is generic perf_event stuff (adding software events for alignment

Re: [PATCH] ppc64: re-enable kexec to allow module loads with CONFIG_MODVERSIONS and CONFIG_RELOCATABLE turned on

2009-11-23 Thread Paul Mackerras
the modules maintainer, Rusty Russell, perhaps? In any case, Acked-by: Paul Mackerras pau...@samba.org Adjust crcs in __kcrctab_* sections if relocs are used with CONFIG_RELOCATABLE When CONFIG_MODVERSIONS and CONFIG_RELOCATABLE are enabled on powerpc platforms, kdump has been failing

Re: [PATCH 0/3] Kernel handling of Dynamic Logical Partitioning

2009-11-24 Thread Paul Mackerras
Nathan Fontenot writes: The Dynamic Logical Partitioning (DLPAR) capabilities of the powerpc pseries platform allows for the addition and removal of resources (i.e. cpus, memory, pci devices) from a partition. The removal of a resource involves removing the resource's node from the device

Re: [PATCH 1/3] Kernel DLPAR infrastructure

2009-11-24 Thread Paul Mackerras
Nathan Fontenot writes: This patch provides the kernel DLPAR infrastructure in a new filed named dlpar.c. The functionality provided is for acquiring and releasing a resource from firmware and the parsing of information returned from the ibm,configure-connector rtas call. Additionally this

Re: [PATCH 3/3] CPU DLPAR handling

2009-11-24 Thread Paul Mackerras
Nathan Fontenot writes: Register the pseries specific handlers for the powerpc architecture handlers for the cpu probe and release files. This also implements the cpu DLPAR addition and removal of CPUS from the system. ... + /* configure-connector reports cpus as living in the base +

Re: [PATCH 2/3] sysfs cpu probe/release files

2009-11-24 Thread Paul Mackerras
Nathan Fontenot writes: Create new probe and release sysfs files to facilitate adding and removing cpus from the system. This also creates the powerpc specific stubs to handle the arch callouts from writes to the sysfs files. The creation and use of these files is regulated by the

Re: [PATCH v2 3/3]CPU DLPAR handling

2009-11-25 Thread Paul Mackerras
Nathan Fontenot writes: This patch adds the specific routines to probe and release (add and remove) cpu resource for the powerpc pseries platform and registers these handlers with the ppc_md callout structure. Signed-off-by: Nathan Fontenot nf...@austin.ibm.com Acked-by: Paul Mackerras pau

Re: [PATCH v2 2/3] sysfs cpu probe/release files

2009-11-25 Thread Paul Mackerras
is regulated by the CONFIG_ARCH_CPU_PROBE_RELEASE option so that only architectures that need the capability will have the files created. Signed-off-by: Nathan Fontenot nf...@austin.ibm.com Acked-by: Paul Mackerras pau...@samba.org ___ Linuxppc-dev mailing

Re: [PATCH v2 1/3] Kernel DLPAR Infrastructure

2009-11-25 Thread Paul Mackerras
notifier chain so that it can be invoked when device tree updates are made. Signed-off-by: Nathan Fontenot nf...@austin.ibm.com Acked-by: Paul Mackerras pau...@samba.org ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [RFC] powerpc/mm: honor O_SYNC flag for memory map

2009-11-26 Thread Paul Mackerras
Li Yang writes: That's my concern too. But after all mmap without O_SYNC on I/O devices should be deprecated. It should? Why? Shouldn't the onus rather be on those proposing an incompatible change to the kernel ABI, such as this is, to show why the change is absolutely essential? A

Re: [PATCH] powerpc/mm: honor O_SYNC flag for memory mapping

2009-11-26 Thread Paul Mackerras
Li Yang writes: There was no way to set mapped memory as cacheable if the memory is not managed by Linux kernel. It's not rare in real system to allocate some dedicated memory to a certain application which is not managed by kernel and then mmap'ed the memory to the application. The memory

Re: [PATCH] arch/powerpc/boot/devtree.c: use %pM to show MAC address

2009-12-30 Thread Paul Mackerras
On Wed, Dec 30, 2009 at 02:30:39PM -0500, H Hartley Sweeten wrote: Use the %pM kernel extension to display the MAC address. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com --- diff --git a/arch/powerpc/boot/devtree.c b/arch/powerpc/boot/devtree.c index a7e21a3..a2f07a5

Re: perf_counter vs. oprofile

2009-01-21 Thread Paul Mackerras
David Miller writes: Paul, I just noticed that right now if perf counter is enabled, the oprofile module load will always fail because the powerpc perf counter support unconditionally grabs the PMC hardware using reserve_pmc_hardware() in an arch_initcall() There really needs to be a way

Re: Crash (ext3 ) during 2.6.29-rc6 boot

2009-02-23 Thread Paul Mackerras
Andrew Morton writes: It looks like we died in ext3_xattr_block_get(): memcpy(buffer, bh-b_data + le16_to_cpu(entry-e_value_offs), size); Perhaps entry-e_value_offs is no good. I wonder if the filesystem is corrupted and this snuck through the

Re: Confused about CLOCK_TICK_RATE

2009-03-18 Thread Paul Mackerras
Timur Tabi writes: Can someone explain CLOCK_TICK_RATE to me? It's defined in arch/powerpc/include/asm/timex.h as such: #define CLOCK_TICK_RATE 1024000 /* Underlying HZ */ Every architecture defines this, but some use the better comment Underlying frequency of the HZ timer. My

Re: Fix for __div64_32 locks when using some 64 bit numbers

2009-03-22 Thread Paul Mackerras
davidastro davidas...@hotmail.com writes: Basically, the numbers shown above was causing the 64 by 32 bit algorithm to divide by zero making the unit spin and also giving incorrect results. Here is the code as it was before. [snip] cntlzw r0,r5 # we are shifting the

Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI

2009-04-06 Thread Paul Mackerras
Arnd Bergmann writes: On Thursday 02 April 2009, Geert Uytterhoeven wrote: | arch/powerpc/platforms/built-in.o:(.toc1+0x4e8): undefined reference to `pci_io_base' due to arch/powerpc/platforms/cell/io-workarounds.c. I guess this file shouldn't be built when CONFIG_PCI=n? Right,

[PATCH] powerpc: Fix oops when loading modules

2009-04-06 Thread Paul Mackerras
to execute the module text caused an exception on processors that support hardware execute permission. This adds _PAGE_HWEXEC to the definitions of PAGE_KERNEL_X and PAGE_KERNEL_ROX to fix this problem. Reported-by: Sean MacLennan smaclen...@pikatech.com Signed-off-by: Paul Mackerras pau

Re: [PATCH 3/3] powerpc: allow 256kB pages with SHMEM

2009-04-06 Thread Paul Mackerras
Hugh Dickins writes: Now that shmem's divisions by zero and SHMEM_MAX_BYTES are fixed, let powerpc 256kB pages coexist with CONFIG_SHMEM again. Signed-off-by: Hugh Dickins h...@veritas.com --- Added linuxppc-dev and some other Cc's for this 3/3: sorry if you didn't see 1/3 and 2/3, they

Re: Move dtc and libfdt sources from arch/powerpc/boot to scripts/dtc

2009-04-06 Thread Paul Mackerras
David Gibson writes: The vast bulk of this patch is a literal move, the rest is adjusting the various Makefiles to use dtc and libfdt correctly from their new locations. Did you test this with a separate object directory? I get: $ make O=../test-64k V=1 [snip] gcc

[git pull] Please pull powerpc.git merge branch

2009-04-07 Thread Paul Mackerras
irqs powerpc/ftrace: Fix #if that should be #ifdef powerpc/ftrace: Fix printf format warning Michael Neuling (2): powerpc: Disable VSX or current process in giveup_fpu/altivec powerpc: Fix ptrace compat wrapper for FPU register access Paul Mackerras (1): powerpc: Fix

Re: [PATCH] therm_pm72: Convert to a new-style i2c driver

2009-04-13 Thread Paul Mackerras
is interested. Signed-off-by: Jean Delvare kh...@linux-fr.org Seems to work fine on my powermac7,2 machine (dual 2.0GHz G5). Tested-by: Paul Mackerras pau...@samba.org Paul. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman

[PATCH] powerpc: Fix bug in __futex_atomic_op

2009-04-13 Thread Paul Mackerras
the same register for 'oparg' (an input) as it uses for the result. This fixes it by using separate registers for 'oparg' and 'ret'. Cc: sta...@kernel.org Signed-off-by: Paul Mackerras pau...@samba.org --- Can anyone see any reason why the FUTEX_OP_SET case can't just do a __put_user? diff --git a/arch

Re: [PATCH] powerpc: VRM unused page hinting

2009-04-14 Thread Paul Mackerras
Robert Jennings writes: Adds support for the unused page hint which can be used in shared memory partitions to flag pages not in use, which will then be stolen before active pages by the hypervisor when memory needs to be moved to LPARs in need of additional memory. Failure to mark pages as

Re: [PATCH 1/2] keywest: Convert to new-style i2c driver

2009-04-14 Thread Paul Mackerras
Jean Delvare writes: The legacy i2c binding model is going away soon, But not before 2.6.30, right? Paul. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] Set error_state to pci_channel_io_normal in eeh_report_reset()

2009-04-15 Thread Paul Mackerras
Mike Mason writes: diff --git a/arch/powerpc/platforms/pseries/eeh_driver.c b/arch/powerpc/platforms/pseries/eeh_driver.c index 380420f..9a2a6e3 100644 --- a/arch/powerpc/platforms/pseries/eeh_driver.c +++ b/arch/powerpc/platforms/pseries/eeh_driver.c @@ -182,6 +182,8 @@ static void

[git pull] Please pull powerpc.git merge branch

2009-04-15 Thread Paul Mackerras
Mike Mason (1): powerpc/pseries: Set error_state to pci_channel_io_normal in eeh_report_reset() Paul Mackerras (1): powerpc: Fix data-corrupting bug in __futex_atomic_op Sachin Sant (1): powerpc: pseries/dtl.c should include asm/firmware.h Wolfgang Grandegger (4): powerpc

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-20 Thread Paul Mackerras
Jean Delvare writes: Takashi, please push this patch to Linus quickly, as this is blocking the removal of the legacy i2c binding model, which is scheduled for 2.6.30. I really don't think you can remove it from Linus' tree at this stage in the 2.6.30 cycle. If it was going to be removed it

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-21 Thread Paul Mackerras
Takashi Iwai writes: At least, the conversion patch Jean posted can be in 2.6.30, I think. Really? What regression, security hole or serious bug are you going to tell Linus that it fixes? :) Paul. ___ Linuxppc-dev mailing list

Re: [BUILD FAILURE 05/12] Next April 21 : PPC64 randconfig [drivers/macintosh/mediabay.o]

2009-04-21 Thread Paul Mackerras
Bartlomiej Zolnierkiewicz writes: mediabay shouldn't include linux/ide.h unconditionally so remove the superfluous include from mediabay.c (asm/mediabay.h will pull linux/ide.h in for CONFIG_BLK_DEV_IDE_PMAC=y). I don't like relying on second-hand imports like that. I prefer the previous

[git pull] Please pull powerpc.git merge branch

2009-04-22 Thread Paul Mackerras
Linus, Please pull from the 'merge' branch of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge to get some more bug fixes for powerpc, plus some documentation and defconfig updates and a MAINTAINERS update. Thanks, Paul. Documentation/powerpc/booting-without-of.txt

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-22 Thread Paul Mackerras
Jean Delvare writes: Not removing it now has a high risk of developers continuing to ignore the deprecation warnings and adding new legacy drivers, which I then must convert to the new model. This never ends. I know my behavior may seem a bit rude, but apparently this is the only way to

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-22 Thread Paul Mackerras
Jean Delvare writes: I sympathize, but throwing disruptive changes into Linus' tree when we're past -rc3 is not the way to solve the problem. We're past -rc3 because people discuss instead of testing my patches. Otherwise everything would be merged already. Well, no. The first

Please revert edada399 and 9203fc9c

2009-04-27 Thread Paul Mackerras
Linus, Please revert commits edada399 (powerpc: Use TEXT_TEXT macro in linker script.) and 9203fc9c (powerpc: Use __REF macro instead of old .text.init.refok.), which depends on edada399. Commit edada399 breaks the build because it moves the __ftr_alt_* sections of a file away from the .text

[git pull] Please pull powerpc.git merge branch

2009-04-27 Thread Paul Mackerras
Linus, Please pull from the 'merge' branch of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge to get a collection of bug fixes for powerpc. Thanks, Paul. MAINTAINERS |2 + arch/powerpc/boot/4xx.c | 56

Re: [PATCH v2 12/15] powerpc: Use macros for .data.page_aligned section.

2009-04-28 Thread Paul Mackerras
Tim Abbott writes: diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c index ad06d5c..841910a 100644 --- a/arch/powerpc/kernel/vdso.c +++ b/arch/powerpc/kernel/vdso.c @@ -74,7 +74,7 @@ static int vdso_ready; static union { struct vdso_datadata; u8

Need a patch tested on a windtunnel powermac

2009-04-29 Thread Paul Mackerras
Does anyone here still have a windtunnel powermac (PowerMac3,6) machine running Linux? We need someone to test Jean Delvare's patch to the therm_windtunnel driver. The patch is at: http://patchwork.ozlabs.org/patch/26095/ I don't have a windtunnel machine myself - I have a PowerMac3,5 but not

Re: [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept

2008-02-06 Thread Paul Mackerras
Manish Ahuja writes: Initial patch for reserving memory in early boot, and freeing it later. If the previous boot had ended with a crash, the reserved memory would contain a copy of the crashed kernel data. [snip] +static void __init reserve_crashed_mem(void) +{ + unsigned long base,

Re: [RFC][PATCH] remove section mappinng

2008-02-06 Thread Paul Mackerras
Badari Pulavarty writes: Thank you for your input and suggestions. Does this look reasonable to you ? Thanks, Badari For memory remove, we need to clean up htab mappings for the section of the memory we are removing. This patch implements support for removing htab bolted mappings

Please pull powerpc.git for-2.6.25 branch

2008-02-06 Thread Paul Mackerras
Linus, Please do git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git for-2.6.25 to get another powerpc update for 2.6.25. Various bug fixes have come in, plus there are a few patches that I missed from the previous set. Thanks, Paul. arch/powerpc/Kconfig

Re: Please pull powerpc.git for-2.6.25 branch

2008-02-07 Thread Paul Mackerras
Linus, Please do git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git for-2.6.25 I have added a few more commits since yesterday's pull request: some commits updating the 4xx support from Josh Boyer's tree, a compile fix for 52xx, and a string of commits from Roland

[PATCH] Fix compilation of powerpc asm-offsets.c with old gcc

2008-02-07 Thread Paul Mackerras
-offsets.c. This fixes it by introducing a new MONOTONIC_RES_NSEC define in the generic code which is equivalent to KTIME_MONOTONIC_RES but is just an integer constant, not a ktime union. Signed-off-by: Tony Breeds [EMAIL PROTECTED] Signed-off-by: Paul Mackerras [EMAIL PROTECTED] --- Linus, I'm sending

Please pull powerpc.git for-2.6.25 branch

2008-02-08 Thread Paul Mackerras
Linus, Please do git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git for-2.6.25 to get some bug-fixes for powerpc (1 for powermac and 8 for Cell), plus 3 commits from Badari Pulavarty that implement memory hot-remove for 64-bit powerpc. These 3 commits have been

Please pull powerpc.git merge branch

2008-02-14 Thread Paul Mackerras
Linus, Please do git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge to get a collection of bug-fixes and very minor cleanups for powerpc (plus one commit wiring up the timerfd syscalls). Thanks, Paul. arch/powerpc/Kconfig |4 ---

Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness

2008-02-19 Thread Paul Mackerras
Andrew Morton writes: Bizarrely, the original author of the patch (Anton) has fallen off the cc. Could whoever did that please thwap himself? Anyway, my head is now officially spinning. Did anyone actually have a reason why we shouldn't proceed with Anton's patch? I was wondering if it

Please pull powerpc.git merge branch

2008-02-19 Thread Paul Mackerras
Linus, Please do git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge to get a few more bug and warning fixes for powerpc. The diffstat is bloated by the defconfig updates -- the actual code changes are only a few dozen lines. Thanks, Paul.

Re: [PATCH v2][POWERPC] Fix initial lmb add region with a non-zero base

2008-02-20 Thread Paul Mackerras
Kumar Gala writes: np. Are we trying to get this into 2.6.25 or .26? I was going to put it into my powerpc-next branch and put it in 2.6.26. I don't see any need for it to go in 2.6.25. Paul. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH v2][POWERPC] Fix initial lmb add region with a non-zero base

2008-02-20 Thread Paul Mackerras
David Miller writes: I'm ambivalent but I would obviously prefer 2.6.25 because it would allow me to proceed more easily with my sparc64 NUMA work as well as get your bug fixes in more smoothly. Sounds like we should get Stephen to put it in linux-next-stable once we're convinced it's all OK.

Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness

2008-02-20 Thread Paul Mackerras
Anton Vorontsov writes: I was wondering if it would be sufficient to provide alternative versions of fb_readl, fb_writel etc. that do byte-swapping. This is of course viable alternative. And I was considering this, but later I abandoned the idea: that way we'll end up doing math in the

Re: Please pull powerpc.git merge branch

2008-02-21 Thread Paul Mackerras
Linus, Since I send the last pull request I have added four more commits to the powerpc.git merge branch, two from Olof Johansson fixing a bug and a warning for the pasemi platform, and two spufs bugfixes from Jeremy Kerr. Please do: git pull \

Re: [PATCH 5/5] [POWERPC] Add 460EX PCIe support to 4xx pci driver

2008-02-22 Thread Paul Mackerras
Stefan Roese writes: Tested on AMCC Canyonlands eval board. Signed-off-by: Stefan Roese [EMAIL PROTECTED] With 173 lines of code added, you could spend a paragraph in the patch description telling us why the patch is doing what it's doing the way it's doing it. Perhaps even tell us why it

Re: [PATCH 1/5] [POWERPC] Add AMCC 460EX/460GT support to cputable.c cpu_setup_44x.S

2008-02-22 Thread Paul Mackerras
Stefan Roese writes: Signed-off-by: Stefan Roese [EMAIL PROTECTED] That's a very uninformative commit message. :) How about putting a brief description of the AMCC 460 family in here? Paul. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH 2/5] [POWERPC] Add AMCC Canyonlands 460EX eval board support to platforms/44x

2008-02-22 Thread Paul Mackerras
Stefan Roese writes: Signed-off-by: Stefan Roese [EMAIL PROTECTED] Put a brief description of the Canyonlands in the patch description. Paul. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 5/5] [POWERPC] Add 460EX PCIe support to 4xx pci driver

2008-02-23 Thread Paul Mackerras
Benjamin Herrenschmidt writes: Actually, the patch just adds a backend to my little framework for dealing with 4xx PCIe, which basically is a boring piece of code filling registers with values mostly from the spec... nothing really fancy there. OK, then that's what the patch description

Re: copy_from_user problem

2008-02-25 Thread Paul Mackerras
Maynard Johnson writes: I'm developing a kernel module that needs to parse the in-memory ELF objects for a shared library (libc, to be specific). When running my test on a 32-bit library, it works fine, but for a 64-bit library, the very first copy_from_user() fails: Elf64_Ehdr ehdr;

Re: [PATCH][OF] Add of_device_is_available function

2008-02-26 Thread Paul Mackerras
Josh Boyer writes: + status = of_get_property(device, status, NULL); + if (status == NULL) + return 1; + + if (!strcmp(status, okay) || !strcmp(status, ok)) It would probably be good to defend against the possibility that the property isn't null-terminated (for

Re: [patch 0/6] pasemi_mac updates for 2.6.26

2008-02-26 Thread Paul Mackerras
Olof Johansson writes: Here's a set of updates for pasemi_mac for 2.6.26. Some of them touch the dma_lib in the platform code as well, but it's easier if it's all merged through netdev to avoid dependencies. Major highlights are jumbo frame support and ethtool basics, the rest is mostly

Re: [PATCH] Fix for Freescale ppc cores: major revision detection

2008-02-26 Thread Paul Mackerras
Martin Langer writes: Thanks for the hint. Inspired by that I did the logic the other way round. So we have the same default cases as we had before and additionally it will fit for the cores mentioned in the doc. Care to resend this with a proper description and a Signed-off-by line? +

Patches added to master powerpc-next branches of powerpc.git

2008-02-26 Thread Paul Mackerras
I have created a powerpc-next branch in the powerpc.git tree, which has the following commits on it so far. The master branch is at the same point. I've pulled in Dave Miller's tree (for the LMB changes) and applied some other patches from the list. I'm expecting that platform/subarchitecture

Re: Patches added to master powerpc-next branches of powerpc.git

2008-02-26 Thread Paul Mackerras
Benjamin Herrenschmidt writes: On Tue, 2008-02-26 at 23:03 +1100, Paul Mackerras wrote: Benjamin Herrenschmidt (1): [POWERPC] Fix thinko in cpu_thread_mask_to_cores() Any reason why this isn't going into .25 ? I thought you said nothing uses it. Paul

Re: Patches added to master powerpc-next branches of powerpc.git

2008-02-26 Thread Paul Mackerras
Kumar Gala writes: How do you plan on managing the powerpc-next branch in the future? For example, I assume at some point linus will pull it into what would be 2.6.26. Would you rebase this branch? etc. Yes, it is basically the for-2.6.26 branch. I will try very hard not to rebase it,

Re: patchwork missing patches?

2008-02-27 Thread Paul Mackerras
Josh Boyer writes: I'm trying to find some patches that went to the list recently in patchwork and they seem to be missing. Here are a few: http://ozlabs.org/pipermail/linuxppc-dev/2008-February/052196.html That one was in awaiting upstream state since I put it in the bundle, then realized

Re: [PATCH 1/2] firewire: endianess fix

2008-02-29 Thread Paul Mackerras
Jarod Wilson writes: Still no luck finding one here. The person I was thinking of has a Lombard, which has no firewire. I did get ahold of a 667MHz Titanium, but its got an Agere FW323. Pretty sure my old man actually has a Pismo, but its about a 3000 mile drive over to my folks house. The

Re: [PATCH 0/4] Add Emerson KSI8560 board support

2008-02-29 Thread Paul Mackerras
Alexandr Smirnov writes: I've fixed the code according to your comments. None of the patches you sent have any patch description or commentary, and that's not good enough. Yes, it all might be completely clear and obvious in your head as to what the KSI8560 is and why you have made the

Please pull powerpc.git merge branch

2008-03-03 Thread Paul Mackerras
Linus, Please do: git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge to get a collection of bug-fixes for powerpc, for the Cell, 4xx and 52xx platforms. Thanks, Paul. arch/powerpc/boot/cuboot-bamboo.c|1 arch/powerpc/boot/cuboot-ebony.c

Re: V4L2: __ucmpdi2 undefined on ppc

2008-03-04 Thread Paul Mackerras
Segher Boessenkool writes: Every occurrence of r7 here is wrong (and some of the r6). Is there any reason to do this in assembler code at all? The fact that the obvious C code generates ... a call to __ucmpdi2? :) Paul. ___ Linuxppc-dev mailing

Re: [PATCH] add strncmp to PowerPC

2008-03-04 Thread Paul Mackerras
Benjamin Herrenschmidt writes: Do we have any indication that it performs better than the C one ? I would expect it to, given that the assembler one has two branches in the per-byte loop compared to 3 in the C version. Paul. ___ Linuxppc-dev mailing

Re: [PATCH] add strncmp to PowerPC

2008-03-04 Thread Paul Mackerras
Segher Boessenkool writes: Anyway, this asm code has bugs, as do both the current C version in the kernel, and the code I posted. We need to do better :-) The only bug I know of in the asm code is the behaviour when the count is zero. Do you know of any other? Paul.

Re: Please pull pasemi.git for-2.6.26 branch

2008-03-06 Thread Paul Mackerras
Olof Johansson writes: Please pull from 'for-2.6.26' branch of master.kernel.org:/pub/scm/linux/kernel/git/olof/pasemi.git for-2.6.26 to receive the following updates. They have all been posted to the list previously, and had only minor updates to remove a couple of compiler warnings:

Re: Please pull from 'for-2.6.25' branch

2008-03-07 Thread Paul Mackerras
Kumar Gala writes: These are fixes to forward on to linus (based on his tree). Are you going to put in the fix for swap on 8xx in arch/ppc? Paul. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 8/8] pseries: phyp dump: config file

2008-03-11 Thread Paul Mackerras
Manish Ahuja writes: +config PHYP_DUMP + bool Hypervisor-assisted dump (EXPERIMENTAL) + depends on PPC_PSERIES EXPERIMENTAL + default y I think this should default to n for now (i.e. leave out the default line entirely). We can make it default to y later. Paul.

Re: [PATCH 6/8] pseries: phyp dump: Invalidate and print dump areas.

2008-03-11 Thread Paul Mackerras
Manish Ahuja writes: -static void -release_memory_range(unsigned long start_pfn, unsigned long nr_pages) +static +void release_memory_range(unsigned long start_pfn, unsigned long nr_pages) This change looks rather pointless. If you have to change it, I'd prefer: static void

Re: [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept

2008-03-11 Thread Paul Mackerras
Manish Ahuja writes: +#else /* CONFIG_PHYP_DUMP */ +int early_init_dt_scan_phyp_dump(unsigned long node, + const char *uname, int depth, void *data) { return 0; } This shouldn't be in the header file. Either put it in prom.c (and make it return 1 so the of_scan_flat_dt call

Re: [PATCH 4/8] pseries: phyp dump: register dump area.

2008-03-11 Thread Paul Mackerras
Manish Ahuja writes: +#define NUM_DUMP_SECTIONS 3 +#define DUMP_HEADER_VERSION 0x1 +#define DUMP_REQUEST_FLAG 0x1 +#define DUMP_SOURCE_CPU 0x0001 +#define DUMP_SOURCE_HPTE 0x0002 +#define DUMP_SOURCE_RMO 0x0011 I think it would be clearer if you use a tab to line up the values, like this:

Re: [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem

2008-03-11 Thread Paul Mackerras
Manish Ahuja writes: Check to see if there actually is data from a previously crashed kernel waiting. If so, Allow user-sapce tools to grab the data (by reading /proc/kcore). When user-space finishes dumping a section, it must release that memory by writing to sysfs. For example, echo

Please pull powerpc.git merge branch

2008-03-12 Thread Paul Mackerras
device trees. Michael Ellerman (1): [POWERPC] Fix large hash table allocation on Cell blades Paul Mackerras (1): [POWERPC] Add __ucmpdi2 for 64-bit comparisons in 32-bit kernels Scott Wood (1): [POWERPC] 8xx: Fix wrapper platform for adder875, and combine defconfigs. Theodore Ts'o

Re: [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept

2008-03-13 Thread Paul Mackerras
Manish Ahuja writes: If Mike and Paul are okay, then I will leave this bit as is and fix all other issues and comments. Well, part of the problem is the semantic dissonance caused by having a static variable called global. Please change the name phyp_dump_global to phyp_dump_vars or

Re: [BUG]2.6.25-rc6:Unable to handle kernel paging request

2008-03-18 Thread Paul Mackerras
Sudhir Kumar writes: Unable to handle kernel paging request for data at address 0xd82e Looks like some driver tried to access I/O port 0x2e without checking whether there was possibly anything there first. Faulting instruction address: 0xc074ded8 cpu 0x0: Vector: 300

Re: crash in init_ipic_sysfs on efika

2008-03-19 Thread Paul Mackerras
Olaf Hering writes: I cant reproduce this bug on my board, but: The global primary_ipic in arch/powerpc/sysdev/ipic.c can remain NULL if ipic_init() fails. init_ipic_sysfs() will crash in that case. Something like this may fix it: Is this needed for 2.6.25? Is the system at all usable

Re: [PATCH] Hide resources on Axon PCIE root complex nodes

2008-03-19 Thread Paul Mackerras
Michael Ellerman writes: The PCI bridge representing the PCIE root complex on Axon, contains device BARs for a memory range and ROM that define inbound accesses. This confuses the kernel resource management code, the resources need to be hidden when Axon is a host bridge. Since you didn't

Please pull powerpc.git merge branch

2008-03-19 Thread Paul Mackerras
|6 + arch/powerpc/platforms/cell/iommu.c| 41 --- arch/powerpc/platforms/cell/setup.c| 36 ++ 16 files changed, 835 insertions(+), 534 deletions(-) commit 93ce4e2d2d7404e80d5612fb1cc13d4aad5e42fc Author: Paul Mackerras [EMAIL PROTECTED] Date: Thu Mar 20 11:21:32

Re: unprivileged use of MSR_SE

2008-03-19 Thread Paul Mackerras
Roland McGrath writes: Are there any powerpc instructions that can read or change the MSR explicitly from user mode? Any that can see or affect the MSR_SE bit? No and no. e.g. x86 has pushf/popf unprivileged instructions, with which a user program can both see the single-step flag set, and

Re: unprivileged use of MSR_SE

2008-03-19 Thread Paul Mackerras
Roland McGrath writes: I'd like to clean this up for powerpc too. If there is no way at all for user-mode to set MSR_SE, then it doesn't much matter whether it shows up when ptrace reads it--ptrace just needs to ignore attempts to set it. So if there's no reason not to, what I would do is

Re: [PATCH 2/2] Force 4K IOPages when eHEA is present in the machine.

2008-03-20 Thread Paul Mackerras
Nathan Lynch writes: Searching ibm,drc-names is necessary, but is it sufficient? That is, can there be a system that has an HEA adapter without that property being present? Thinking in particular about single-partition systems that run without an HMC attached. PAPR doesn't seem to say

Re: Oops with TQM5200 on TQM5200

2008-03-24 Thread Paul Mackerras
Wolfgang Grandegger writes: Bartlomiej Sieka wrote: Grant Likely wrote: Paul, my git server is down at the moment. Can you please pick this one up for .25? It is needed to boot the tqm5200 board. Could we also have similar fixes for cm5200.dts and motionpro.dts picked up? I could

Re: [PATCH] [POWERPC] mpc5200: fix incorrect compatible string for the mdio node

2008-03-24 Thread Paul Mackerras
Grant Likely writes: The MDIO node in the lite5200b.dts file needs to also claim compatibility with the older mpc5200 chip. Signed-off-by: Grant Likely [EMAIL PROTECTED] --- Paul, this one should also go in for .26 OK, I'll put it in the powerpc-next branch. Or did you mean it should go

Re: [PATCH 4/8] powerpc ptrace: forced_successful_syscall_return()

2008-03-24 Thread Paul Mackerras
Roland McGrath writes: Define the forced_successful_syscall_return() macro to pair with our force_successful_syscall_return() definition. Signed-off-by: Roland McGrath [EMAIL PROTECTED] Looks OK to me, but what's it useful for? Paul. ___

Re: crash in init_ipic_sysfs on efika

2008-03-24 Thread Paul Mackerras
Kumar Gala writes: since you are going to send something to linus let me update the fsl defconfigs and send you a pull request. OK -- I'm about to send Linus a pull request now in case he feels like releasing 2.6.25 this weekend. I'll send him another pull request with your defconfig update

Please pull powerpc.git merge branch

2008-03-24 Thread Paul Mackerras
and so the fec driver should work. This removes .type = dma-controller from the bestcomm driver's mpc52xx_bcom_of_match table to solve the problem. Signed-off-by: Anatolij Gustschin [EMAIL PROTECTED] Acked-by: Grant Likely [EMAIL PROTECTED] Signed-off-by: Paul Mackerras

Re: [RESEND] [PATCH 1/2 v2] [OF] Add of_device_is_available function

2008-03-24 Thread Paul Mackerras
Josh Boyer writes: This adds a function called of_device_is_available that checks the state of the status property of a device. If the property is absent or set to either okay or ok, it returns 1. Otherwise it returns 0. Well actually... + if (statlen 0) { + if

Please pull powerpc.git merge branch

2008-03-24 Thread Paul Mackerras
with the older mpc5200 chip. Otherwise the driver won't find the device. Signed-off-by: Grant Likely [EMAIL PROTECTED] Signed-off-by: Paul Mackerras [EMAIL PROTECTED] commit eff2f1ec37c114fda63ac1dd15c9ca9ac7e68db4 Author: Kumar Gala [EMAIL PROTECTED] Date: Mon Mar 24 08:56:06 2008

Patches added to powerpc.git powerpc-next and master branches

2008-03-25 Thread Paul Mackerras
I have added the patches listed below to the master and powerpc-next branches of the powerpc.git repository, and pulled in Linus' current tree. Paul. Manish Ahuja (10): [POWERPC] pseries: phyp dump: Documentation [POWERPC] pseries: phyp dump: Reserve and release memory

  1   2   3   4   5   6   7   8   9   10   >