[PATCH V1 1/2] ASoC: fsl: esai: refine esai for tdm support

2014-08-06 Thread Shengjiu Wang
Add parameter for slots, and caculate the number of TX/RX pins and bclk with slots. Then driver will be compatible with slots 2 in TDM mode. Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/fsl_esai.c | 10 +++--- sound/soc/fsl/fsl_esai.h |8 2 files

[PATCH V1 0/2] refine esai for tdm support

2014-08-06 Thread Shengjiu Wang
refine esai for tdm support. Shengjiu Wang (2): ASoC: fsl: esai: refine esai for tdm support Revert ASoC: fsl-esai: Add .xlate_tdm_slot_mask() support. sound/soc/fsl/Kconfig|1 - sound/soc/fsl/fsl_esai.c | 12 +++- sound/soc/fsl/fsl_esai.h |8 3 files changed

[PATCH V1 2/2] Revert ASoC: fsl-esai: Add .xlate_tdm_slot_mask() support.

2014-08-06 Thread Shengjiu Wang
This reverts commit a603c8ee526f5ea9ad9b40710308766299ad8a69. fsl_asoc_xlate_tdm_slot_mask() will invert the mask, which isn't fit for esai. The default function snd_soc_xlate_tdm_slot_mask() is ok for esai. Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/Kconfig

[PATCH V2 0/2] refine esai for tdm support

2014-08-07 Thread Shengjiu Wang
These patchs is to refine esai for tdm support. Changes for V2 - update the comments according the reviewer's suggestion - add init value for slots and change pin to pins. Shengjiu Wang (2): ASoC: fsl_esai: refine esai for TDM support Revert ASoC: fsl-esai: Add .xlate_tdm_slot_mask() support

[PATCH V2 1/2] ASoC: fsl_esai: refine esai for TDM support

2014-08-07 Thread Shengjiu Wang
. Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/fsl_esai.c | 14 +++--- sound/soc/fsl/fsl_esai.h |8 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index 72d154e..f252370 100644

[PATCH V2 2/2] Revert ASoC: fsl-esai: Add .xlate_tdm_slot_mask() support.

2014-08-07 Thread Shengjiu Wang
This reverts commit a603c8ee526f5ea9ad9b40710308766299ad8a69. fsl_asoc_xlate_tdm_slot_mask() will invert the mask, which isn't fit for esai. The default function snd_soc_xlate_tdm_slot_mask() is ok for esai. Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/Kconfig

[PATCH V3 2/2] Revert ASoC: fsl-esai: Add .xlate_tdm_slot_mask() support.

2014-08-07 Thread Shengjiu Wang
snd_soc_xlate_tdm_slot_mask(), which is workable for esai. Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/Kconfig|1 - sound/soc/fsl/fsl_esai.c |2 -- 2 files changed, 3 deletions(-) diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index f54a8fc..f3012b6 100644

[PATCH V3 1/2] ASoC: fsl_esai: refine esai for TDM support

2014-08-07 Thread Shengjiu Wang
. Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/fsl_esai.c | 14 +++--- sound/soc/fsl/fsl_esai.h |8 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index 72d154e..f252370 100644

[PATCH V3 0/2] refine esai for tdm support

2014-08-07 Thread Shengjiu Wang
These patchs is to refine esai for tdm support. Changes for V3 - update the comments for patch 2 Changes for V2 - update the comments according the reviewer's suggestion - add init value for slots and change pin to pins. Shengjiu Wang (2): ASoC: fsl_esai: refine esai for TDM support Revert

[PATCH V4 0/2] refine esai for tdm support

2014-08-08 Thread Shengjiu Wang
These patchs is to refine esai for tdm support. Changes for V4 - update the comments for patch 2 Changes for V3 - update the comments for patch 2 Changes for V2 - update the comments according the reviewer's suggestion - add init value for slots and change pin to pins. Shengjiu Wang (2

[PATCH V4 2/2] Revert ASoC: fsl-esai: Add .xlate_tdm_slot_mask() support.

2014-08-08 Thread Shengjiu Wang
to 0. For esai when the bit value is 1, the slot is enabled, when the bit value is 0, the slot is disabled. If using fsl_asoc_xlate_tdm_slot_mask(), the esai will work abnormally. So revert this patch, make the esai use default function. Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com

[PATCH V4 1/2] ASoC: fsl_esai: refine esai for TDM support

2014-08-08 Thread Shengjiu Wang
. Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/fsl_esai.c | 14 +++--- sound/soc/fsl/fsl_esai.h |8 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index 72d154e..f252370 100644

[PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

2014-08-18 Thread Shengjiu Wang
of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA. Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/Kconfig |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index

[PATCH V1 2/3] ASoC: fsl-asoc-card: Fix build warning for maybe-uninitialized

2014-08-18 Thread Shengjiu Wang
[] = { 554 { .compatible = fsl,imx-audio-cs42888, }, 555 { .compatible = fsl,imx-audio-sgtl5000, }, Add 'asrc_fail' branch for error jump after asrc_np initialized. Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com

[PATCH V1 0/3] fix build error/warning in sound/soc/fsl

2014-08-18 Thread Shengjiu Wang
This series patch is for fixing build error/waring in sound/soc/fsl Shengjiu Wang (3): ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA ASoC: fsl-asoc-card: Fix build warning for maybe-uninitialized ASoC: fsl: fsl-asoc-card: Select SND_SOC_IMX_AUDMUX sound

[PATCH V1 3/3] ASoC: fsl: fsl-asoc-card: Select SND_SOC_IMX_AUDMUX

2014-08-18 Thread Shengjiu Wang
robot fengguang...@intel.com Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 3a3732c..dc0d08b 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig

Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

2014-08-19 Thread Shengjiu Wang
On Mon, Aug 18, 2014 at 06:52:46PM +0200, Lars-Peter Clausen wrote: On 08/18/2014 10:38 AM, Shengjiu Wang wrote: Build kernel with SND_SOC_IMC_PCM_DMA=m SND_IMX_SOC=n leads the following error: sound/built-in.o: In function `fsl_sai_probe': fsl_sai.c:(.text+0x5f662): undefined

Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

2014-08-19 Thread Shengjiu Wang
will not be selected. So remove the dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA. Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com Those if conditions where just added[1] by Arnd to avoid other build failures. So

Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

2014-08-19 Thread Shengjiu Wang
On Tue, Aug 19, 2014 at 10:45:04AM +0200, Lars-Peter Clausen wrote: On 08/19/2014 10:36 AM, Lars-Peter Clausen wrote: On 08/19/2014 09:41 AM, Shengjiu Wang wrote: On Mon, Aug 18, 2014 at 06:52:46PM +0200, Lars-Peter Clausen wrote: On 08/18/2014 10:38 AM, Shengjiu Wang wrote: Build kernel

[PATCH V2] ASoC: fsl-asoc-card: move 'config SND_SOC_FSL_ASOC_CARD' to 'if SND_IMX_SOC'

2014-08-19 Thread Shengjiu Wang
): undefined reference to `imx_pcm_dma_init' The config SND_SOC_FSL_ASOC_CARD is for IMX SOC, So move it under condition of 'if SND_IMX_SOC'. Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/Kconfig | 34

[PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Shengjiu Wang
-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/fsl_ssi.c | 38 +++--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 2fc3e66..d32d0f5 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-10 Thread Shengjiu Wang
On Tue, Sep 09, 2014 at 11:38:05AM -0700, Nicolin Chen wrote: On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: @@ -1321,7 +1333,11 @@ static int fsl_ssi_probe(struct platform_device *pdev) return -ENOMEM; } - ssi_private-regs = devm_regmap_init_mmio

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-10 Thread Shengjiu Wang
On Tue, Sep 09, 2014 at 12:59:29PM -0700, Nicolin Chen wrote: On Tue, Sep 09, 2014 at 02:37:42PM -0500, Timur Tabi wrote: On 09/09/2014 01:38 PM, Nicolin Chen wrote: make sure to have the call for imx only because it seems that the other platforms do not depend on the clock. Although I

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-10 Thread Shengjiu Wang
On Wed, Sep 10, 2014 at 08:21:18AM +0200, Markus Pargmann wrote: On Tue, Sep 09, 2014 at 11:38:05AM -0700, Nicolin Chen wrote: On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: @@ -1321,7 +1333,11 @@ static int fsl_ssi_probe(struct platform_device *pdev) return

[PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-10 Thread Shengjiu Wang
Move the ipg clock enable and disable operation to startup and shutdown, that is only enable ipg clock when ssi is working. Keep clock is disabled when ssi is in idle. otherwise, _fsl_ssi_set_dai_fmt function need to be called in probe, so add ipg clock control for it. Signed-off-by: Shengjiu

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-11 Thread Shengjiu Wang
On Thu, Sep 11, 2014 at 08:36:51AM +0200, Markus Pargmann wrote: On Wed, Sep 10, 2014 at 10:42:04AM -0700, Nicolin Chen wrote: On Wed, Sep 10, 2014 at 04:12:53PM +0800, Shengjiu Wang wrote: Then we can get a patch like: open() { + clk_prepare_enable

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-11 Thread Shengjiu Wang
On Thu, Sep 11, 2014 at 03:57:37PM -0700, Nicolin Chen wrote: On Thu, Sep 11, 2014 at 01:38:29PM +0800, Shengjiu Wang wrote: Move the ipg clock enable and disable operation to startup and shutdown, that is only enable ipg clock when ssi is working. Keep clock is disabled when ssi is in idle

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-11 Thread Shengjiu Wang
On Thu, Sep 11, 2014 at 09:43:59PM -0500, Timur Tabi wrote: Shengjiu Wang wrote: +ret = clk_prepare_enable(ssi_private-clk); +if (ret) +return ret; Will this work on PowerPC, where ssi_private-clk is always NULL? When ssi_private-clk is NULL, then ret = 0, so here

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-12 Thread Shengjiu Wang
On Fri, Sep 12, 2014 at 08:17:06AM +0200, Markus Pargmann wrote: Hi, On Fri, Sep 12, 2014 at 10:01:12AM +0800, Shengjiu Wang wrote: On Thu, Sep 11, 2014 at 03:57:37PM -0700, Nicolin Chen wrote: On Thu, Sep 11, 2014 at 01:38:29PM +0800, Shengjiu Wang wrote: Move the ipg clock enable

[PATCH V3] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-12 Thread Shengjiu Wang
. Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- V3 change log: update patch according Nicolin and markus's comments sound/soc/fsl/fsl_ssi.c | 53 --- 1 file changed, 45 insertions(+), 8 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-12 Thread Shengjiu Wang
On Fri, Sep 12, 2014 at 10:54:46AM +0200, Markus Pargmann wrote: On Fri, Sep 12, 2014 at 03:14:28PM +0800, Shengjiu Wang wrote: On Fri, Sep 12, 2014 at 08:17:06AM +0200, Markus Pargmann wrote: Hi, On Fri, Sep 12, 2014 at 10:01:12AM +0800, Shengjiu Wang wrote: On Thu, Sep 11, 2014

Re: [PATCH V3] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-15 Thread Shengjiu Wang
On Mon, Sep 15, 2014 at 12:05:41PM +0200, Markus Pargmann wrote: On Fri, Sep 12, 2014 at 06:35:15PM +0800, Shengjiu Wang wrote: Check if ipg clock is in clock-names property, then we can move the ipg clock enable and disable operation to startup and shutdown, that is only enable ipg clock

Re: [PATCH V3] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-15 Thread Shengjiu Wang
On Mon, Sep 15, 2014 at 12:32:13PM +0200, Markus Pargmann wrote: On Mon, Sep 15, 2014 at 06:22:27PM +0800, Shengjiu Wang wrote: On Mon, Sep 15, 2014 at 12:05:41PM +0200, Markus Pargmann wrote: On Fri, Sep 12, 2014 at 06:35:15PM +0800, Shengjiu Wang wrote: Check if ipg clock is in clock

[PATCH V4] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-15 Thread Shengjiu Wang
. Tested-by: Markus Pargmann m...@pengutronix.de Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- v4 change log: fix the code indent issue. sound/soc/fsl/fsl_ssi.c | 53 --- 1 file changed, 45 insertions(+), 8 deletions(-) diff --git

[PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver

2014-09-16 Thread Shengjiu Wang
The spdif root clock may be used by other module or defined with CLK_SET_RATE_GATE, so we can't change the clock rate in driver. In this patch remove the clk_set_rate and clk_round_rate to protect the clock. Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/fsl_spdif.c

[PATCH] ASoC: fsl: Add dedicated DMA buffer size for each cpu dai

2015-06-23 Thread Shengjiu Wang
As the ssi is not the only cpu dai, there are esai, spdif, sai. and imx_pcm_dma can be used by all of them. Especially ESAI need a larger DMA buffer size. So Add dedicated DMA buffer for each cpu dai. Signed-off-by: Shengjiu Wang shengjiu.w...@freescale.com --- sound/soc/fsl/fsl_esai.c|2

Re: [PATCH V3 1/3] ASoC: fsl_esai: spba clock is needed by esai device

2015-11-24 Thread Shengjiu Wang
On Tue, Nov 24, 2015 at 05:21:30PM -0600, Rob Herring wrote: > On Tue, Nov 24, 2015 at 03:03:28PM +0800, Shengjiu Wang wrote: > > ESAI need to enable the spba clock, when sdma is using share peripheral > > script. In this case, there is two spba master port is used, if don't >

[PATCH V2 0/3] add spba clock for fsl audio IP

2015-11-19 Thread Shengjiu Wang
add spba clock for fsl audio IP Changes in v2 - spba is a optional clock, compatible with previous devicetree. - change the name from "dma" to "spba" Shengjiu Wang (3): ASoC: fsl_esai: spba clock is needed by esai device ASoC: fsl_spdif: spba clk is needed by spdif dev

[PATCH V2 2/3] ASoC: fsl_spdif: spba clk is needed by spdif device

2015-11-19 Thread Shengjiu Wang
SPDIF need to enable the spba clock, when sdma is using share peripheral script. In this case, there is two spba master port is used, if don't enable the clock, the spba bus will have arbitration issue, which may cause read/write wrong data from/to SPDIF registers. Signed-off-by: Shengjiu Wang

[PATCH V2 1/3] ASoC: fsl_esai: spba clock is needed by esai device

2015-11-19 Thread Shengjiu Wang
ESAI need to enable the spba clock, when sdma is using share peripheral script. In this case, there is two spba master port is used, if don't enable the clock, the spba bus will have arbitration issue, which may cause read/write wrong data from/to ESAI registers. Signed-off-by: Shengjiu Wang

[PATCH V2 3/3] ASoC: fsl_asrc: spba clock is needed by asrc device

2015-11-19 Thread Shengjiu Wang
ASRC need to enable the spba clock, when sdma is using share peripheral script. In this case, there is two spba master port is used, if don't enable the clock, the spba bus will have arbitration issue, which may cause read/write wrong data from/to ASRC registers Signed-off-by: Shengjiu Wang

[PATCH V3 0/3] add spba clock for fsl audio IP

2015-11-23 Thread Shengjiu Wang
add spba clock for fsl audio IP Changes in V3 - update the comments for clock description. Shengjiu Wang (3): ASoC: fsl_esai: spba clock is needed by esai device ASoC: fsl_spdif: spba clk is needed by spdif device ASoC: fsl_asrc: spba clock is needed by asrc device Documentation

[PATCH V3 1/3] ASoC: fsl_esai: spba clock is needed by esai device

2015-11-23 Thread Shengjiu Wang
ESAI need to enable the spba clock, when sdma is using share peripheral script. In this case, there is two spba master port is used, if don't enable the clock, the spba bus will have arbitration issue, which may cause read/write wrong data from/to ESAI registers. Signed-off-by: Shengjiu Wang

[PATCH V3 2/3] ASoC: fsl_spdif: spba clk is needed by spdif device

2015-11-23 Thread Shengjiu Wang
SPDIF need to enable the spba clock, when sdma is using share peripheral script. In this case, there is two spba master port is used, if don't enable the clock, the spba bus will have arbitration issue, which may cause read/write wrong data from/to SPDIF registers. Signed-off-by: Shengjiu Wang

[PATCH V3 3/3] ASoC: fsl_asrc: spba clock is needed by asrc device

2015-11-23 Thread Shengjiu Wang
ASRC need to enable the spba clock, when sdma is using share peripheral script. In this case, there is two spba master port is used, if don't enable the clock, the spba bus will have arbitration issue, which may cause read/write wrong data from/to ASRC registers Signed-off-by: Shengjiu Wang

Re: [PATCH V3 1/3] ASoC: fsl_esai: spba clock is needed by esai device

2015-11-24 Thread Shengjiu Wang
On Tue, Nov 24, 2015 at 12:33:45AM -0800, Nicolin Chen wrote: > On Tue, Nov 24, 2015 at 03:03:28PM +0800, Shengjiu Wang wrote: > > > @@ -469,6 +471,9 @@ static int fsl_esai_startup(struct snd_pcm_substream > > *substream, > > ret = clk_prepare_enable(esai_priv-&g

[PATCH V4 0/3] add spba clock for fsl audio IP

2015-11-24 Thread Shengjiu Wang
add spba clock for fsl audio IP Changes in V3 - add error check for spba clock Shengjiu Wang (3): ASoC: fsl_esai: spba clock is needed by esai device ASoC: fsl_spdif: spba clk is needed by spdif device ASoC: fsl_asrc: spba clock is needed by asrc device Documentation/devicetree/bindings

[PATCH V4 2/3] ASoC: fsl_spdif: spba clk is needed by spdif device

2015-11-24 Thread Shengjiu Wang
SPDIF need to enable the spba clock, when sdma is using share peripheral script. In this case, there is two spba master port is used, if don't enable the clock, the spba bus will have arbitration issue, which may cause read/write wrong data from/to SPDIF registers. Signed-off-by: Shengjiu Wang

[PATCH V4 1/3] ASoC: fsl_esai: spba clock is needed by esai device

2015-11-24 Thread Shengjiu Wang
ESAI need to enable the spba clock, when sdma is using share peripheral script. In this case, there is two spba master port is used, if don't enable the clock, the spba bus will have arbitration issue, which may cause read/write wrong data from/to ESAI registers. Signed-off-by: Shengjiu Wang

[PATCH V4 3/3] ASoC: fsl_asrc: spba clock is needed by asrc device

2015-11-24 Thread Shengjiu Wang
ASRC need to enable the spba clock, when sdma is using share peripheral script. In this case, there is two spba master port is used, if don't enable the clock, the spba bus will have arbitration issue, which may cause read/write wrong data from/to ASRC registers Signed-off-by: Shengjiu Wang

[PATCH V2 1/2] ASoC: fsl_esai: Wrap some operations to be functions

2019-07-03 Thread shengjiu . wang
From: Shengjiu Wang Extract the operation to be functions, to improve the readability. In this patch, fsl_esai_init, fsl_esai_register_restore, fsl_esai_trigger_start and fsl_esai_trigger_stop are extracted. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_esai.c | 191

[PATCH V2 0/2] recover the channel swap after xrun

2019-07-03 Thread shengjiu . wang
From: Shengjiu Wang recover the channel swap after xrun Shengjiu Wang (2): ASoC: fsl_esai: Wrap some operations to be functions ASoC: fsl_esai: recover the channel swap after xrun sound/soc/fsl/fsl_esai.c | 267 --- 1 file changed, 194 insertions(+), 73

[PATCH V2 2/2] ASoC: fsl_esai: recover the channel swap after xrun

2019-07-03 Thread shengjiu . wang
From: Shengjiu Wang There is chip errata ERR008000, the reference doc is (https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf), The issue is "While using ESAI transmit or receive and an underrun/overrun happens, channel swap may occur. The only recovery mechanism is to reset the ESAI."

[PATCH V4 1/2] ASoC: fsl_esai: Wrap some operations to be functions

2019-07-11 Thread shengjiu . wang
From: Shengjiu Wang Extract the operation to be functions, to improve the readability. In this patch, fsl_esai_hw_init, fsl_esai_register_restore, fsl_esai_trigger_start and fsl_esai_trigger_stop are extracted. Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen --- sound/soc/fsl/fsl_esai.c

[PATCH V4 2/2] ASoC: fsl_esai: recover the channel swap after xrun

2019-07-11 Thread shengjiu . wang
From: Shengjiu Wang There is chip errata ERR008000, the reference doc is (https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf), The issue is "While using ESAI transmit or receive and an underrun/overrun happens, channel swap may occur. The only recovery mechanism is to reset the ESAI."

[PATCH V4 0/2] recover the channel swap after xrun

2019-07-11 Thread shengjiu . wang
From: Shengjiu Wang recover the channel swap after xrun Shengjiu Wang (2): ASoC: fsl_esai: Wrap some operations to be functions ASoC: fsl_esai: recover the channel swap after xrun sound/soc/fsl/fsl_esai.c | 266 --- 1 file changed, 193 insertions(+), 73

[PATCH V3 1/2] ASoC: fsl_esai: Wrap some operations to be functions

2019-07-08 Thread shengjiu . wang
From: Shengjiu Wang Extract the operation to be functions, to improve the readability. In this patch, fsl_esai_hw_init, fsl_esai_register_restore, fsl_esai_trigger_start and fsl_esai_trigger_stop are extracted. Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen --- sound/soc/fsl/fsl_esai.c

[PATCH V3 2/2] ASoC: fsl_esai: recover the channel swap after xrun

2019-07-08 Thread shengjiu . wang
From: Shengjiu Wang There is chip errata ERR008000, the reference doc is (https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf), The issue is "While using ESAI transmit or receive and an underrun/overrun happens, channel swap may occur. The only recovery mechanism is to reset the ESAI."

[PATCH V3 0/2] recover the channel swap after xrun

2019-07-08 Thread shengjiu . wang
From: Shengjiu Wang recover the channel swap after xrun Shengjiu Wang (2): ASoC: fsl_esai: Wrap some operations to be functions ASoC: fsl_esai: recover the channel swap after xrun sound/soc/fsl/fsl_esai.c | 270 --- 1 file changed, 197 insertions(+), 73

[PATCH] ASoC: imx-audmux: Add driver suspend and resume to support MEGA Fast

2019-08-15 Thread Shengjiu Wang
For i.MX6 SoloX, there is a mode of the SoC to shutdown all power source of modules during system suspend and resume procedure. Thus, AUDMUX needs to save all the values of registers before the system suspend and restore them after the system resume. Signed-off-by: Shengjiu Wang --- sound/soc

[PATCH] ASoC: imx-audmix: register the card on a proper dev

2019-08-26 Thread Shengjiu Wang
Mixer machine driver") Signed-off-by: Viorel Suman Signed-off-by: Shengjiu Wang --- sound/soc/fsl/imx-audmix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/imx-audmix.c b/sound/soc/fsl/imx-audmix.c index 9e1cb18859ce..71590ca6394b 100644 --- a/sound/soc/fs

[PATCH] ASoC: fsl_ssi: Fix clock control issue in master mode

2019-08-27 Thread Shengjiu Wang
bles the clock. This patch is to move the clock enablement to the place before checking of the device enablement in hw_param(). Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_ssi.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/s

[PATCH V2 2/2] ASoC: fsl_mqs: Add MQS component driver

2019-09-13 Thread Shengjiu Wang
provides only simple audio reproduction. No internal pop, click or distortion artifact reduction methods are provided. The MQS receives the audio data from the SAI1 Tx section. Signed-off-by: Shengjiu Wang --- Changes in v2 - use devm_platform_ioremap_resource sound/soc/fsl/Kconfig | 10

[PATCH V2 1/2] ASoC: fsl_mqs: add DT binding documentation

2019-09-13 Thread Shengjiu Wang
Add the DT binding documentation for NXP MQS driver Signed-off-by: Shengjiu Wang --- Changes in v2 -refine the comments for properties .../devicetree/bindings/sound/fsl,mqs.txt | 36 +++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH 0/3] update supported sample format

2019-09-09 Thread Shengjiu Wang
update supported sample format Shengjiu Wang (3): ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width ASoC: fsl_asrc: update supported sample format ASoC: fsl_asrc: Fix error with S24_3LE format bitstream in i.MX8 sound/soc/fsl/fsl_asrc.c | 65

[PATCH 3/3] ASoC: fsl_asrc: Fix error with S24_3LE format bitstream in i.MX8

2019-09-09 Thread Shengjiu Wang
hen update the hw parameters according to the caps. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_asrc.c | 4 +- sound/soc/fsl/fsl_asrc.h | 3 ++ sound/soc/fsl/fsl_asrc_dma.c | 93 +--- 3 files changed, 92 insertions(+), 8 deletions(-) diff --git a

[PATCH 2/3] ASoC: fsl_asrc: update supported sample format

2019-09-09 Thread Shengjiu Wang
The ASRC support 24bit/16bit/8bit input width, so S20_3LE format should not be supported, it is word width is 20bit. So replace S20_3LE with S24_3LE in supported list and add S8 format in TX supported list Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_asrc.c | 5 +++-- 1 file changed, 3

[PATCH 1/3] ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width

2019-09-09 Thread Shengjiu Wang
snd_pcm_format_t is more formal than enum asrc_word_width, which has two property, width and physical width, which is more accurate than enum asrc_word_width. So it is better to use in(out)put_format instead of in(out)put_word_width. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_asrc.c

[PATCH 1/2] ASoC: fsl_mqs: add DT binding documentation

2019-09-10 Thread Shengjiu Wang
Add the DT binding documentation for NXP MQS driver Signed-off-by: Shengjiu Wang --- .../devicetree/bindings/sound/fsl,mqs.txt | 20 +++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl,mqs.txt diff --git a/Documentation

[PATCH 2/2] ASoC: fsl_mqs: Add MQS component driver

2019-09-10 Thread Shengjiu Wang
provides only simple audio reproduction. No internal pop, click or distortion artifact reduction methods are provided. The MQS receives the audio data from the SAI1 Tx section. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/Kconfig | 10 ++ sound/soc/fsl/Makefile | 2 + sound/soc/fsl/fsl_mqs.c

[PATCH V2 1/4] ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width

2019-09-18 Thread Shengjiu Wang
snd_pcm_format_t is more formal than enum asrc_word_width, which has two property, width and physical width, which is more accurate than enum asrc_word_width. So it is better to use in(out)put_format instead of in(out)put_word_width. Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen

[PATCH V2 3/4] ASoC: pcm_dmaengine: Extract snd_dmaengine_pcm_set_runtime_hwparams

2019-09-18 Thread Shengjiu Wang
this feature can call this function. Signed-off-by: Shengjiu Wang --- include/sound/dmaengine_pcm.h | 5 ++ sound/core/pcm_dmaengine.c| 83 +++ sound/soc/soc-generic-dmaengine-pcm.c | 62 ++-- 3 files changed, 92 insertions(+), 58

[PATCH V2 0/4] update supported sample format

2019-09-18 Thread Shengjiu Wang
This patch serial is to update the supported format for fsl_asrc and fix some format issue. Shengjiu Wang (4): ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width ASoC: fsl_asrc: update supported sample format ASoC: pcm_dmaengine: Extract

[PATCH V2 2/4] ASoC: fsl_asrc: update supported sample format

2019-09-18 Thread Shengjiu Wang
with S24_3LE in supported list and add S8 format in TX supported list Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_asrc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 4d3804a1ea55..584badf956d2 100644

[PATCH V2 4/4] ASoC: fsl_asrc: Fix error with S24_3LE format bitstream in i.MX8

2019-09-18 Thread Shengjiu Wang
hen update the hw parameters according to the caps. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_asrc.c | 4 +-- sound/soc/fsl/fsl_asrc.h | 3 +++ sound/soc/fsl/fsl_asrc_dma.c | 48 ++-- 3 files changed, 46 insertions(+), 9 deletions(-) diff --git a

[PATCH 2/2] ASoC: fsl_esai: Add new compatible string for imx6ull

2019-08-09 Thread Shengjiu Wang
Add new compatible string "fsl,imx6ull-esai" in the binding document. Signed-off-by: Shengjiu Wang --- Documentation/devicetree/bindings/sound/fsl,esai.txt | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/fsl,e

[PATCH 1/2] ASoC: fsl_esai: Add compatible string for imx6ull

2019-08-09 Thread Shengjiu Wang
Add compatible string for imx6ull, from imx6ull platform, the issue of channel swap after xrun is fixed in hardware. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_esai.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index

[PATCH V3 3/4] ASoC: pcm_dmaengine: Extract snd_dmaengine_pcm_refine_runtime_hwparams

2019-09-19 Thread Shengjiu Wang
need this feature can call this function. Signed-off-by: Shengjiu Wang --- include/sound/dmaengine_pcm.h | 5 ++ sound/core/pcm_dmaengine.c| 83 +++ sound/soc/soc-generic-dmaengine-pcm.c | 62 +++- 3 files changed, 95 insertions(+), 55

[PATCH V3 2/4] ASoC: fsl_asrc: update supported sample format

2019-09-19 Thread Shengjiu Wang
with S24_3LE in supported list and add S8 format in TX supported list Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_asrc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 4d3804a1ea55..584badf956d2 100644

[PATCH V3 1/4] ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width

2019-09-19 Thread Shengjiu Wang
snd_pcm_format_t is more formal than enum asrc_word_width, which has two property, width and physical width, which is more accurate than enum asrc_word_width. So it is better to use in(out)put_format instead of in(out)put_word_width. Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen

[PATCH V3 4/4] ASoC: fsl_asrc: Fix error with S24_3LE format bitstream in i.MX8

2019-09-19 Thread Shengjiu Wang
hen update the hw parameters according to the caps. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_asrc.c | 4 +-- sound/soc/fsl/fsl_asrc.h | 3 +++ sound/soc/fsl/fsl_asrc_dma.c | 52 +++- 3 files changed, 50 insertions(+), 9 deletions(-) diff --git a

[PATCH V3 0/4] update supported sample format

2019-09-19 Thread Shengjiu Wang
This patch serial is to update the supported format for fsl_asrc and fix some format issue. Shengjiu Wang (4): ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width ASoC: fsl_asrc: update supported sample format ASoC: pcm_dmaengine: Extract

[PATCH V6 4/4] ASoC: fsl_asrc: Fix error with S24_3LE format bitstream in i.MX8

2019-09-26 Thread Shengjiu Wang
hen update the hw parameters according to the caps. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_asrc.c | 4 +-- sound/soc/fsl/fsl_asrc.h | 3 ++ sound/soc/fsl/fsl_asrc_dma.c | 64 3 files changed, 62 insertions(+), 9 deletions(-) diff --git a

[PATCH V6 1/4] ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width

2019-09-26 Thread Shengjiu Wang
snd_pcm_format_t is more formal than enum asrc_word_width, which has two property, width and physical width, which is more accurate than enum asrc_word_width. So it is better to use in(out)put_format instead of in(out)put_word_width. Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen

[PATCH V6 0/4] update supported sample format

2019-09-26 Thread Shengjiu Wang
This patch serial is to update the supported format for fsl_asrc and fix some format issue Shengjiu Wang (4): ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width ASoC: fsl_asrc: update supported sample format ASoC: pcm_dmaengine: Extract

[PATCH V6 3/4] ASoC: pcm_dmaengine: Extract snd_dmaengine_pcm_refine_runtime_hwparams

2019-09-26 Thread Shengjiu Wang
need this feature can call this function. Signed-off-by: Shengjiu Wang Reviewed-by: Nicolin Chen --- include/sound/dmaengine_pcm.h | 5 ++ sound/core/pcm_dmaengine.c| 83 +++ sound/soc/soc-generic-dmaengine-pcm.c | 61 ++-- 3 files

[PATCH V6 2/4] ASoC: fsl_asrc: update supported sample format

2019-09-26 Thread Shengjiu Wang
with S24_3LE in supported list and add S8 format in TX supported list Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen --- sound/soc/fsl/fsl_asrc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 4d3804a1ea55

[PATCH V4 0/4] update supported sample format

2019-09-24 Thread Shengjiu Wang
This patch serial is to update the supported format for fsl_asrc and fix some format issue. Shengjiu Wang (4): ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width ASoC: fsl_asrc: update supported sample format ASoC: pcm_dmaengine: Extract

[PATCH V4 3/4] ASoC: pcm_dmaengine: Extract snd_dmaengine_pcm_refine_runtime_hwparams

2019-09-24 Thread Shengjiu Wang
need this feature can call this function. Signed-off-by: Shengjiu Wang --- include/sound/dmaengine_pcm.h | 5 ++ sound/core/pcm_dmaengine.c| 83 +++ sound/soc/soc-generic-dmaengine-pcm.c | 61 ++-- 3 files changed, 94 insertions(+), 55

[PATCH V4 4/4] ASoC: fsl_asrc: Fix error with S24_3LE format bitstream in i.MX8

2019-09-24 Thread Shengjiu Wang
hen update the hw parameters according to the caps. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_asrc.c | 4 +-- sound/soc/fsl/fsl_asrc.h | 3 ++ sound/soc/fsl/fsl_asrc_dma.c | 59 +++- 3 files changed, 56 insertions(+), 10 deletions(-) diff --git a

[PATCH V4 2/4] ASoC: fsl_asrc: update supported sample format

2019-09-24 Thread Shengjiu Wang
with S24_3LE in supported list and add S8 format in TX supported list Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen --- sound/soc/fsl/fsl_asrc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 4d3804a1ea55

[PATCH V4 1/4] ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width

2019-09-24 Thread Shengjiu Wang
snd_pcm_format_t is more formal than enum asrc_word_width, which has two property, width and physical width, which is more accurate than enum asrc_word_width. So it is better to use in(out)put_format instead of in(out)put_word_width. Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen

[PATCH V5 0/4] update supported sample format

2019-09-25 Thread Shengjiu Wang
This patch serial is to update the supported format for fsl_asrc and fix some format issue. Shengjiu Wang (4): ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width ASoC: fsl_asrc: update supported sample format ASoC: pcm_dmaengine: Extract

[PATCH V5 2/4] ASoC: fsl_asrc: update supported sample format

2019-09-25 Thread Shengjiu Wang
with S24_3LE in supported list and add S8 format in TX supported list Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen --- sound/soc/fsl/fsl_asrc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 4d3804a1ea55

[PATCH V5 1/4] ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width

2019-09-25 Thread Shengjiu Wang
snd_pcm_format_t is more formal than enum asrc_word_width, which has two property, width and physical width, which is more accurate than enum asrc_word_width. So it is better to use in(out)put_format instead of in(out)put_word_width. Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen

[PATCH V5 3/4] ASoC: pcm_dmaengine: Extract snd_dmaengine_pcm_refine_runtime_hwparams

2019-09-25 Thread Shengjiu Wang
need this feature can call this function. Signed-off-by: Shengjiu Wang Reviewed-by: Nicolin Chen --- include/sound/dmaengine_pcm.h | 5 ++ sound/core/pcm_dmaengine.c| 83 +++ sound/soc/soc-generic-dmaengine-pcm.c | 61 ++-- 3 files

[PATCH V5 4/4] ASoC: fsl_asrc: Fix error with S24_3LE format bitstream in i.MX8

2019-09-25 Thread Shengjiu Wang
hen update the hw parameters according to the caps. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_asrc.c | 4 +-- sound/soc/fsl/fsl_asrc.h | 3 ++ sound/soc/fsl/fsl_asrc_dma.c | 66 +++- 3 files changed, 63 insertions(+), 10 deletions(-) diff --git a

Re: [alsa-devel] [PATCH] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-10 Thread Shengjiu Wang
Hi On Sat, Nov 9, 2019 at 10:48 AM Nicolin Chen wrote: > > On Wed, Nov 06, 2019 at 03:27:45PM +0800, Shengjiu Wang wrote: > > Audmix support two substream, When two substream start > > to run, the trigger function may be called by two substream > > in same time,

[PATCH V2] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-10 Thread Shengjiu Wang
Audio Mixer CPU DAI driver") Cc: Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen --- Change in v2 -add Fixes, Cc stable, and Acked-by. sound/soc/fsl/fsl_audmix.c | 6 ++ sound/soc/fsl/fsl_audmix.h | 1 + 2 files changed, 7 insertions(+) diff --git a/sound/soc/fsl/fsl_audmix.c

[PATCH V3 2/2] ASoC: fsl_asrc: Add support for imx8qm

2019-11-11 Thread Shengjiu Wang
request corresponding to one dma channel. So we need to request dma channel with dma request of asrc module. Signed-off-by: Shengjiu Wang --- changes in v2 - use !use_edma to wrap code in fsl_asrc_dma - add Acked-by: Nicolin Chen changes in v3 - remove the acked-by for commit is updated - read

  1   2   3   >