Re: [PATCH v3 0/7] Fixes for perf probe issues on ppc

tting in my local tree, to give > time to Masami and Srikar, ok? > Yes Arnaldo, I have looked at the patches after the __weak changes and they look good to me. > - Arnaldo > -- Thanks and Regards Srikar Dronamraju ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC 01/11] sched: introduce sys_cpumask in tsk to adapt asymmetric system

s_allowed(struct task_struct *p, const struct cpumask > *new_mask) > { > if (p->sched_class && p->sched_class->set_cpus_allowed) > p->sched_class->set_cpus_allowed(p, new_mask); > > - cpumask_copy(&p->cpus_allowed

Re: [RFC 02/11] powerpc: kvm: ensure vcpu-thread run only on primary hwthread

umask? > + } > + } > +#endif > > if (!vcpu->arch.sane) { > run->exit_reason = KVM_EXIT_INTERNAL_ERROR; > -- > 1.8.3.1 > > -- Thanks and Regards Srikar Dronamraju ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC 03/11] powerpc: kvm: add interface to control kvm function on a core

if (cpu_online(thr * threads_per_core + thr)) > + cpumask_set_cpu(thr * threads_per_core + thr, > &stop_cpus); Shouldnt this be if (cpu_online(core * threads_per_core + thr)) cpumask_set_cpu(c

Re: [PATCH v2 1/4] uprobes: add trap variant helper

where the trap notification came in > for an address without a uprobe. See [1] for a more detailed explanation. > > [1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2013-March/104771.html > > This change was suggested by Oleg Nesterov. > > Signed-off-by: Ananth N Mavinakay

Re: [PATCH v2 2/4] uprobes: refuse uprobe on trap variants

* Ananth N Mavinakayanahalli [2013-03-22 20:47:58]: > From: Ananth N Mavinakayanahalli > > Refuse to place a uprobe if a trap variant already exists in the > file copy at the address. > > Signed-off-by: Ananth N Mavinakayanahalli Acked-by: Srikar Dronamraju >

Re: [PATCH v2 3/4] uprobes/powerpc: teach uprobes to ignore gdb breakpoints

understand that the trap was inserted > by some other entity and a SIGTRAP needs to be delivered. > > Teach uprobes to ignore breakpoints that do not belong to it. > > Signed-off-by: Ananth N Mavinakayanahalli Acked-by: Srikar Dronamraju > --- > arch/powerpc/kernel/uprobes.

Re: [PATCH v2 4/4] uprobes/powerpc: remove additional trap instruction check

t; - * existing breakpoint instruction underneath > - */ > - if (is_trap(auprobe->ainsn)) > - return -ENOTSUPP; > return 0; > } > -- Thanks and Regards Srikar Dronamraju ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Panic on ppc64 with numa_balancing and !sparsemem_vmemmap

} 755 756 #define cpupid_match_pid(task, cpupid) __cpupid_match_pid(task->pid, cpupid) 757 #ifdef LAST_CPUPID_NOT_IN_PAGE_FLAGS (gdb) However this doesnt seem to happen if we have CONFIG_SPARSEMEM_VMEMMAP=y set in the config. -- Thanks nnn Regards Sri

Tasks stuck in futex code (in 3.14-rc6)

wake up was the commit thats causing the threads to be stuck in futex. I reverted b0c29f79ecea0b6fbcefc999e70f2843ae8306db on top of v3.14-rc6 and confirmed that reverting the commit solved the problem. -- Thanks and Regards Srikar Dronamraju ___

Re: Tasks stuck in futex code (in 3.14-rc6)

owever if I set the constraint to core (which means running more instances of java), the problem is not seen. I kind of guess, the lesser the number of java instances the easier it is to reproduce. -- Thanks and Regards Srikar Dronamraju ___

Re: Tasks stuck in futex code (in 3.14-rc6)

S 3fff825f6044 0 14682 14076 0x0080 Is there any other information that I provide that can help? -- Thanks and Regards Srikar Dronamraju ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: Tasks stuck in futex code (in 3.14-rc6)

lds/linux.git/commit/?id=b0c29f79ecea0b6fbcefc999 are the same. Or am I missing something? -- Thanks and Regards Srikar Dronamraju ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: Tasks stuck in futex code (in 3.14-rc6)

13/12/19/624 > https://lkml.org/lkml/2013/12/19/630 I reverted commits 99b60ce6 and b0c29f79. Then applied the patches in the above url. The last one had a reject but it was pretty straightforward to resolve it. After this, specjbb completes. So reverting and applying v3 3/4 and 4/4 patches

Re: Tasks stuck in futex code (in 3.14-rc6)

back to the explicit waiter counting code). -- Thanks and Regards Srikar Dronamraju ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] sched/cpuacct: Check for NULL when using task_pt_regs()

Works for me too. Reported-and-Tested-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC v3] sched/topology: fix kernel crash when a CPU is hotplugged in a memoryless node

an such a thing happen? > > If not; why not? Yes distances can be 20, 40 or 80. There is nothing that makes the node distance to be 40 always. > So you're relying on sched_domain_numa_masks_set/clear() to fix this up, > but that in turn relies on the sched_domain_numa_levels

Re: [RFC v3] sched/topology: fix kernel crash when a CPU is hotplugged in a memoryless node

ef_points_depth is 2) I am not sure if this will work if the node distance between the two nodes happens to be 20. > /* > * Even though we connect cpus to numa domains later in SMP > * init, we need to know the node ids now. This is because > -- Thanks and Regards Srikar Dronamraju

[PATCH 0/3] Offline memoryless cpuless node 0

: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Srikar Dronamraju (3): powerpc/numa: Set numa_node for all possible cpus powerpc/numa: Prefer node id queried from vphn mm/page_alloc: Keep memoryless cpuless node 0 offline ar

[PATCH 1/3] powerpc/numa: Set numa_node for all possible cpus

Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Signed-off-by: Srikar Dronamraju --- arch/powerpc/mm/numa.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --

[PATCH 2/3] powerpc/numa: Prefer node id queried from vphn

-ker...@vger.kernel.org Cc: Michal Hocko Cc: Mel Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Signed-off-by: Srikar Dronamraju --- arch/powerpc/mm/numa.c | 16 1 file

[PATCH 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

ned-off-by: Srikar Dronamraju --- mm/page_alloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 3c4eb75..68e635f4 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -116,8 +116,10 @@ struct pcpu_drain { */ nodemask_t node_states[NR_N

Re: [PATCH 1/3] powerpc/numa: Set numa_node for all possible cpus

* Michal Hocko [2020-03-11 12:57:35]: > On Wed 11-03-20 16:32:35, Srikar Dronamraju wrote: > > A Powerpc system with multiple possible nodes and with CONFIG_NUMA > > enabled always used to have a node 0, even if node 0 does not any cpus > > or memory attached to it. As per P

Re: [PATCH 1/3] powerpc/numa: Set numa_node for all possible cpus

* Vlastimil Babka [2020-03-12 10:30:50]: > On 3/12/20 9:23 AM, Sachin Sant wrote: > >> On 12-Mar-2020, at 10:57 AM, Srikar Dronamraju > >> wrote: > >> * Michal Hocko [2020-03-11 12:57:35]: > >>> On Wed 11-03-20 16:32:35, Srikar Dronamraju wrote: &g

Re: [PATCH 1/3] powerpc/numa: Set numa_node for all possible cpus

* Vlastimil Babka [2020-03-12 14:51:38]: > > * Vlastimil Babka [2020-03-12 10:30:50]: > > > >> On 3/12/20 9:23 AM, Sachin Sant wrote: > >> >> On 12-Mar-2020, at 10:57 AM, Srikar Dronamraju > >> >> wrote: > >> >> * Michal Hocko

Re: [PATCH 1/3] powerpc/numa: Set numa_node for all possible cpus

safer for all cases > In ppc arch's mem_topology_setup(void) > for_each_present_cpu(cpu) { > numa_setup_cpu(cpu); > mem_node = node_to_mem_node(numa_mem_id()); > if (!node_present_pages(mem_node)) { > _node_numa_mem_[numa_mem_id()] = first_online_node; > } > } > But here as discussed above, we miss the case of possible but not present nodes. For such nodes, the above change may not update, resulting in they still having 0. And node 0 can be only possible but not present. -- Thanks and Regards Srikar Dronamraju

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

s a possible but not yet present node fails. Currently node_present_pages(nid) and node_to_mem_node don't seem to be equipped to handle possible but not present nodes. > cheers -- Thanks and Regards Srikar Dronamraju

Re: [PATCH 1/3] powerpc/numa: Set numa_node for all possible cpus

* Vlastimil Babka [2020-03-12 17:41:58]: > On 3/12/20 5:13 PM, Srikar Dronamraju wrote: > > * Vlastimil Babka [2020-03-12 14:51:38]: > > > >> > * Vlastimil Babka [2020-03-12 10:30:50]: > >> > > >> >> On 3/12/20 9:23 AM, Sachin Sant

Re: [PATCH 1/2] powerpc/smp: Drop superfluous NULL check

* Michael Ellerman [2020-03-13 22:20:19]: > We don't need the NULL check of np, the result is the same because the > OF helpers cope with NULL, of_node_to_nid(NULL) == NUMA_NO_NODE (-1). > Looks good to me. Reviewed-by: Srikar Dronamraju > Signed-off-by: Michael Ellerm

Re: [PATCH 2/2] powerpc/smp: Use IS_ENABLED() to avoid #ifdef

* Michael Ellerman [2020-03-13 22:20:20]: > We can avoid the #ifdef by using IS_ENABLED() in the existing > condition check. > Looks good to me. Reviewed-by: Srikar Dronamraju > Signed-off-by: Michael Ellerman > --- > arch/powerpc/kernel/smp.c | 5 ++--- > 1 file

[PATCH 2/4] mm/slub: Use mem_node to allocate a new slab

opher Lameter Cc: linuxppc-dev@lists.ozlabs.org Cc: Joonsoo Kim Cc: Kirill Tkhai Cc: Vlastimil Babka Cc: Srikar Dronamraju Cc: Bharata B Rao Reported-by: Sachin Sant Tested-by: Sachin Sant Signed-off-by: Srikar Dronamraju --- mm/slub.c | 19 --- 1 file changed, 8 inser

[PATCH 0/4] Fix kmalloc_node on offline nodes

Gorman Cc: Michael Ellerman Cc: Sachin Sant Cc: Michal Hocko Cc: Christopher Lameter Cc: linuxppc-dev@lists.ozlabs.org Cc: Joonsoo Kim Cc: Kirill Tkhai Cc: Vlastimil Babka Cc: Srikar Dronamraju Cc: Bharata B Rao Srikar Dronamraju (4): mm: Check for node_online in node_present_pages mm

[PATCH 3/4] mm: Implement reset_numa_mem

: linux...@kvack.org Cc: Mel Gorman Cc: Michael Ellerman Cc: Sachin Sant Cc: Michal Hocko Cc: Christopher Lameter Cc: linuxppc-dev@lists.ozlabs.org Cc: Joonsoo Kim Cc: Kirill Tkhai Cc: Vlastimil Babka Cc: Srikar Dronamraju Cc: Bharata B Rao Reported-by: Sachin Sant Tested-by: Sachin Sant

[PATCH 4/4] powerpc/numa: Set fallback nodes for offline nodes

orton Cc: linux...@kvack.org Cc: Mel Gorman Cc: Michael Ellerman Cc: Sachin Sant Cc: Michal Hocko Cc: Christopher Lameter Cc: linuxppc-dev@lists.ozlabs.org Cc: Joonsoo Kim Cc: Kirill Tkhai Cc: Vlastimil Babka Cc: Srikar Dronamraju Cc: Bharata B Rao Reported-by: Sachin Sant Tested-by: S

[PATCH 1/4] mm: Check for node_online in node_present_pages

Babka Cc: Srikar Dronamraju Cc: Bharata B Rao Reported-by: Sachin Sant Tested-by: Sachin Sant Signed-off-by: Srikar Dronamraju --- include/linux/mmzone.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index f3f2648

Re: [PATCH 1/4] mm: Check for node_online in node_present_pages

* Srikar Dronamraju [2020-03-17 18:47:50]: > > Reported-by: Sachin Sant > Tested-by: Sachin Sant > Signed-off-by: Srikar Dronamraju > --- > include/linux/mmzone.h | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mmzone

Re: [PATCH 2/4] mm/slub: Use mem_node to allocate a new slab

* Vlastimil Babka [2020-03-17 14:34:25]: > On 3/17/20 2:17 PM, Srikar Dronamraju wrote: > > Currently while allocating a slab for a offline node, we use its > > associated node_numa_mem to search for a partial slab. If we don't find > > a partial slab, we try allocati

Re: [PATCH 4/4] powerpc/numa: Set fallback nodes for offline nodes

for such nodes. > > +*/ > > + if (!node_online(node)) { > > Change the above line to like below: > > + if (!node_state(node, N_MEMORY)) { > Just to clarify, this is needed if we don't have http://lore.kernel.org/lkml/20200311110237.5731-1-sri...@linux.vnet.ibm.com/t/#u -- Thanks and Regards Srikar Dronamraju

Re: [PATCH 2/4] mm/slub: Use mem_node to allocate a new slab

line nodes. However we could change this to set for all offline and memoryless nodes. > node_to_mem_node() could be just a shortcut for the first zone's node in the > zonelist, so that fallback follows the topology. > > [1] > https://lore.kernel.org/linuxppc-dev/2020030237.5731-1-sri...@linux.vnet.ibm.com/t/#m76e5b4c4084380b1d4b193d5aa0359b987f2290e > -- Thanks and Regards Srikar Dronamraju

Re: Slub: Increased mem consumption on cpu,mem-less node powerpc guest

instead of kmalloc. While Bharata is testing on upstream, which doesn't have this. > > [1] > https://lore.kernel.org/linux-next/3381cd91-ab3d-4773-ba04-e7a072a63...@linux.vnet.ibm.com/ > -- Thanks and Regards Srikar Dronamraju

Re: [PATCH 2/4] mm/slub: Use mem_node to allocate a new slab

node will never equal NUMA_NO_NODE (thanks to the > hunk below), thus the get_any_partial() call becomes dead code? Very true. Would it be okay if we remove the node != NUMA_NO_NODE if (object || node != NUMA_NO_NODE) return object; will now become if (object) return object; -- Thanks and Regards Srikar Dronamraju

Re: Slub: Increased mem consumption on cpu,mem-less node powerpc guest

* Vlastimil Babka [2020-03-17 17:45:15]: > On 3/17/20 5:25 PM, Srikar Dronamraju wrote: > > * Vlastimil Babka [2020-03-17 16:56:04]: > > > >> > >> I wonder why do you get a memory leak while Sachin in the same situation > >> [1] > >>

[PATCH v2 0/4] Fix kmalloc_node on offline nodes

a Cc: Srikar Dronamraju Cc: Bharata B Rao Cc: Nathan Lynch Srikar Dronamraju (4): mm: Check for node_online in node_present_pages mm/slub: Use mem_node to allocate a new slab mm: Implement reset_numa_mem powerpc/numa: Set fallback nodes for offline nodes arch/powerpc/include/asm/to

[PATCH v2 1/4] mm: Check for node_online in node_present_pages

Babka Cc: Srikar Dronamraju Cc: Bharata B Rao Cc: Nathan Lynch Reported-by: Sachin Sant Tested-by: Sachin Sant Signed-off-by: Srikar Dronamraju --- include/linux/mmzone.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmz

[PATCH v2 2/4] mm/slub: Use mem_node to allocate a new slab

opher Lameter Cc: linuxppc-dev@lists.ozlabs.org Cc: Joonsoo Kim Cc: Kirill Tkhai Cc: Vlastimil Babka Cc: Srikar Dronamraju Cc: Bharata B Rao Cc: Nathan Lynch Reported-by: Sachin Sant Tested-by: Sachin Sant Signed-off-by: Srikar Dronamraju --- Changelog v1 -> v2: - Handled comme

[PATCH v2 3/4] mm: Implement reset_numa_mem

: linux...@kvack.org Cc: Mel Gorman Cc: Michael Ellerman Cc: Sachin Sant Cc: Michal Hocko Cc: Christopher Lameter Cc: linuxppc-dev@lists.ozlabs.org Cc: Joonsoo Kim Cc: Kirill Tkhai Cc: Vlastimil Babka Cc: Srikar Dronamraju Cc: Bharata B Rao Cc: Nathan Lynch Reported-by: Sachin Sant Tested

[PATCH v2 4/4] powerpc/numa: Set fallback nodes for offline nodes

orton Cc: linux...@kvack.org Cc: Mel Gorman Cc: Michael Ellerman Cc: Sachin Sant Cc: Michal Hocko Cc: Christopher Lameter Cc: linuxppc-dev@lists.ozlabs.org Cc: Joonsoo Kim Cc: Kirill Tkhai Cc: Vlastimil Babka Cc: Srikar Dronamraju Cc: Bharata B Rao Cc: Nathan Lynch Reported-by: Sachin

Re: [PATCH 2/4] mm/slub: Use mem_node to allocate a new slab

v2 with this change. > >> node_to_mem_node() could be just a shortcut for the first zone's node in > >> the > >> zonelist, so that fallback follows the topology. -- Thanks and Regards Srikar Dronamraju

Re: [PATCH 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

* Michal Hocko [2020-03-16 09:54:25]: > On Sun 15-03-20 14:20:05, Cristopher Lameter wrote: > > On Wed, 11 Mar 2020, Srikar Dronamraju wrote: > > > > > Currently Linux kernel with CONFIG_NUMA on a system with multiple > > > possible nodes, marks node 0 as onl

Re: [PATCH v2 1/4] mm: Check for node_online in node_present_pages

* Michal Hocko [2020-03-18 11:02:56]: > On Wed 18-03-20 12:58:07, Srikar Dronamraju wrote: > > Calling a kmalloc_node on a possible node which is not yet onlined can > > lead to panic. Currently node_present_pages() doesn't verify the node is > > online before access

Re: [RFC 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks

de to get_partial_node with !NUMA_NO_NODE and !N_MEMORY including possible nodes? > if (object || node != NUMA_NO_NODE) -- Thanks and Regards Srikar Dronamraju

Re: [RFC 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks

* Vlastimil Babka [2020-03-19 15:10:19]: > On 3/19/20 3:05 PM, Srikar Dronamraju wrote: > > * Vlastimil Babka [2020-03-19 14:47:58]: > > > >> 8< > >> diff --git a/mm/slub.c b/mm/slub.c > >> index 17dc00e33115..7113b1f9cd77 100

Re: [RFC 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks

* Vlastimil Babka [2020-03-20 09:43:11]: > On 3/20/20 8:46 AM, Srikar Dronamraju wrote: > > * Vlastimil Babka [2020-03-19 15:10:19]: > > > >> On 3/19/20 3:05 PM, Srikar Dronamraju wrote: > >> > * Vlastimil Babka [2020-03-19 14:47:58]: > >> >

Re: [PATCH 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks

uozzo.com/ > [3] https://lore.kernel.org/linux-mm/20200317092624.gb22...@in.ibm.com/ > [4] > https://lore.kernel.org/linux-mm/088b5996-faae-8a56-ef9c-5b567125a...@suse.cz/ > > Reported-and-tested-by: Sachin Sant > Reported-by: PUVICHAKRAVARTHY RAMACHANDRAN > Tested-by: Bharata B Rao > Debugged-by: Srikar Dronamraju > Signed-off-by: Vlastimil Babka > Fixes: a561ce00b09e ("slub: fall back to node_to_mem_node() node if > allocating on memoryless node") Reviewed-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v4 0/5] Early node associativity

Hi Michael, > Nathan Lynch writes: > > Srikar Dronamraju writes: > >> Abdul reported a warning on a shared lpar. > >> "WARNING: workqueue cpumask: online intersect > possible intersect". > >> This is because per node workqueue possible mas

Re: [PATCH v2] powerpc/smp: Use nid as fallback for package_id

Hey Michael, * Srikar Dronamraju [2019-08-22 20:08:53]: > Package_id is to find out all cores that are part of the same chip. On > PowerNV machines, package_id defaults to chip_id. However ibm,chip_id > property is not present in device-tree of PowerVM Lpars. Hence lscpu > output sh

[PATCH 1/2] powerpc/vcpu: Assume dedicated processors as non-preempt

-faults16,783 ( +- 14.87% ) 16,781 ( +- 9.77% ) Waiman Long suggested using static_keys. Reported-by: Parth Shah Reported-by: Ihor Pasichnyk Cc: Parth Shah Cc: Ihor Pasichnyk Cc: Juri Lelli Cc: Waiman Long Signed-off-by: Srikar Dronamraju --- arch/powerpc/include/asm/spinlock.

[PATCH 2/2] powerpc/shared: Use static key to detect shared processor

With the static key shared processor available, is_shared_processor() can return without having to query the lppaca structure. Signed-off-by: Srikar Dronamraju --- arch/powerpc/include/asm/spinlock.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include

Re: [PATCH 1/2] powerpc/vcpu: Assume dedicated processors as non-preempt

* Srikar Dronamraju [2019-12-04 19:14:58]: > > > # perf stat -a -r 5 ./schbench > v5.4 v5.4 + patch > Latency percentiles (usec) Latency percentiles (usec) > 49.th: 47

[PATCH v2 2/2] powerpc/shared: Use static key to detect shared processor

With the static key shared processor available, is_shared_processor() can return without having to query the lppaca structure. Signed-off-by: Srikar Dronamraju --- Changelog v1->v2: Now that we no more refer to lppaca, remove the comment. arch/powerpc/include/asm/spinlock.h | 9 ++---

[PATCH v3 1/2] powerpc/vcpu: Assume dedicated processors as non-preempt

ggested using static_keys. Reported-by: Parth Shah Reported-by: Ihor Pasichnyk Cc: Parth Shah Cc: Ihor Pasichnyk Cc: Juri Lelli Cc: Phil Auld Cc: Waiman Long Cc: Gautham R. Shenoy Tested-by: Juri Lelli Ack-by: Waiman Long Reviewed-by: Gautham R. Shenoy Signed-off-by: Srikar Dronamraju

[PATCH v3 2/2] powerpc/shared: Use static key to detect shared processor

With the static key shared processor available, is_shared_processor() can return without having to query the lppaca structure. Cc: Parth Shah Cc: Ihor Pasichnyk Cc: Juri Lelli Cc: Phil Auld Cc: Waiman Long Signed-off-by: Srikar Dronamraju --- Changelog v1 (https://patchwork.ozlabs.org/patch

[PATCH v2 1/3] powerpc/numa: Set numa_node for all possible cpus

Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Signed-off-by: Srikar Dronamraju --- Changelog v1:->v2: - Rebased to v5.7-rc3 arch/powerpc/mm/numa.c | 16 ++-- 1 file changed,

[PATCH v2 2/3] powerpc/numa: Prefer node id queried from vphn

-ker...@vger.kernel.org Cc: Michal Hocko Cc: Mel Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Signed-off-by: Srikar Dronamraju --- Changelog v1:->v2: - Rebased to v5.7-rc3 arch/powerpc/m

[PATCH v2 0/3] Offline memoryless cpuless node 0

ces/system/node/possible: 0-31 Cc: linuxppc-dev@lists.ozlabs.org Cc: linux...@kvack.org Cc: linux-ker...@vger.kernel.org Cc: Michal Hocko Cc: Mel Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torv

[PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

llerman Cc: Andrew Morton Cc: Linus Torvalds Signed-off-by: Srikar Dronamraju --- Changelog v1:->v2: - Rebased to v5.7-rc3 - Updated the changelog. mm/page_alloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 69827d4fa

Re: [PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

zero node. 3. NUMA Multi node but with CPUs and memory from node 0. 4. NUMA Multi node but with no CPUs and memory from node 0. -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v2 2/3] powerpc/numa: Prefer node id queried from vphn

NUMA_NO_NODE ? If so, > should we still call node_set_online() below ? Yeah, I think It makes sense to retain the BUG_ON and if check. Will incorporate both of them in the next version. > > > > node_set_online(nid); > > } > > > > -- > > 2.20.1 > > > -- > Thanks and Regards > gautham. -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

* Michal Hocko [2020-04-29 14:22:11]: > On Wed 29-04-20 07:11:45, Srikar Dronamraju wrote: > > > > > > > > By marking, N_ONLINE as NODE_MASK_NONE, lets stop assuming that Node 0 > > > > is > > > > always online. > > > > >

[PATCH v3 0/3] Offline memoryless cpuless node 0

nuxppc-dev@lists.ozlabs.org Cc: linux...@kvack.org Cc: linux-ker...@vger.kernel.org Cc: Michal Hocko Cc: Mel Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Srikar Dronamraj

[PATCH v3 1/3] powerpc/numa: Set numa_node for all possible cpus

Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v1:->v2: - Rebased to v5.7-rc3 arch/powerpc/mm/numa.c | 16 +++

[PATCH v3 2/3] powerpc/numa: Prefer node id queried from vphn

-ker...@vger.kernel.org Cc: Michal Hocko Cc: Mel Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v2:->v3: - Resolved

[PATCH v3 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

llerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Signed-off-by: Srikar Dronamraju --- Changelog v1:->v2: - Rebased to v5.7-rc3 Link v2: https://lore.kernel.org/linuxppc-dev/20200428093836.27190-1-sri...@linux.vnet.ibm.com/t/#u mm/page_alloc.c | 4 +++- 1 file changed, 3 i

Re: [PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

resources for a node(node 0) are available but still online. However they find other nodes (nodes 1-6) with don't have resources but not online. So they tend to think the kernel has been unable to online some of the resources or the resources have gone bad. Please do note that on hypervisors like PowerVM, the admins don't have control over which nodes the resources are allocated. -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v3 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

* Christopher Lameter [2020-05-02 23:05:28]: > On Fri, 1 May 2020, Srikar Dronamraju wrote: > > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -116,8 +116,10 @@ EXPORT_SYMBOL(latent_entropy); > > */ > > nodemask_t node_states[NR_NODE_STATES] _

Re: [PATCH v3 1/3] powerpc/numa: Set numa_node for all possible cpus

* Christopher Lameter [2020-05-02 22:55:16]: > On Fri, 1 May 2020, Srikar Dronamraju wrote: > > > - for_each_present_cpu(cpu) > > - numa_setup_cpu(cpu); > > + for_each_possible_cpu(cpu) { > > + /* > > +* Powerpc with CONF

Re: [PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

ark node 0 as cpuless,memoryless and node 1 as actual node, the system somewhere marks node 0 as the actual node. > > David / dhildenb > -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

* David Hildenbrand [2020-05-12 09:49:05]: > On 11.05.20 19:47, Srikar Dronamraju wrote: > > * David Hildenbrand [2020-05-08 15:42:12]: > > > > > > [root@localhost ~]# cat /sys/devices/system/node/online > > 0 > > [root@localhost ~]# cat /sys/devices/sys

[PATCH v4 0/3] Offline memoryless cpuless node 0

"Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: David Hildenbrand Srikar Dronamraju (3): powerpc/numa: Set numa_node for all possible cpus powerpc/numa: Prefer node id que

[PATCH v4 1/3] powerpc/numa: Set numa_node for all possible cpus

Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: David Hildenbrand Signed-off-by: Srikar Dronamraju --- Changelog v3:->v4: - Resolved

[PATCH v4 2/3] powerpc/numa: Prefer node id queried from vphn

-ker...@vger.kernel.org Cc: Michal Hocko Cc: Mel Gorman Cc: Vlastimil Babka Cc: "Kirill A. Shutemov" Cc: Christopher Lameter Cc: Michael Ellerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: David Hildenbrand Signed-off-by: Srikar

[PATCH v4 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

llerman Cc: Andrew Morton Cc: Linus Torvalds Cc: Gautham R Shenoy Cc: Satheesh Rajendran Cc: David Hildenbrand Signed-off-by: Srikar Dronamraju --- Changelog v1:->v2: - Rebased to v5.7-rc3 Link v2: https://lore.kernel.org/linuxppc-dev/20200428093836.27190-1-sri...@linux.vnet.ibm.com/t/#u

[PATCH] powerpc/topology: Check at boot for topology updates

H R Signed-off-by: Srikar Dronamraju --- arch/powerpc/include/asm/topology.h | 4 arch/powerpc/kernel/smp.c | 6 ++ arch/powerpc/mm/numa.c | 22 ++ 3 files changed, 24 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/include/asm/topology

[PATCH v2] powerpc/topology: Check at boot for topology updates

19,408-415,504-511 NUMA node9 CPU(s): 144-151,240-247,336-343,432-439 NUMA node10 CPU(s):152-159,248-255,344-351,440-447 NUMA node11 CPU(s):160-167,256-263,352-359,448-455 Previous attempt to solve this problem https://patchwork.ozlabs.org/patch/530090/ Reported-by: Manjunatha H R Sig

Re: [PATCH v6 2/2] powerpc: Use cpu_smallcore_sibling_mask at SMT level on bigcores

* Gautham R. Shenoy [2018-08-09 11:02:08]: > > 3) ppc64_cpu --smt=2 >SMT domain ceases to exist as each domain consists of just one >group. > When seen in isolation, the above looks as if ppc64_cpu --smt=2 o/p says " SMT domain ceases to exist" > @@ -999,7 +1012,17 @@ static void

Re: [PATCH v6 1/2] powerpc: Detect the presence of big-cores via "ibm,thread-groups"

* Gautham R. Shenoy [2018-08-09 11:02:07]: > > int threads_per_core, threads_per_subcore, threads_shift; > +bool has_big_cores; > cpumask_t threads_core_mask; > EXPORT_SYMBOL_GPL(threads_per_core); > EXPORT_SYMBOL_GPL(threads_per_subcore); > EXPORT_SYMBOL_GPL(threads_shift); > +EXPORT_SYMBO

[PATCH v3] powerpc/topology: Check at boot for topology updates

19,408-415,504-511 NUMA node9 CPU(s): 144-151,240-247,336-343,432-439 NUMA node10 CPU(s):152-159,248-255,344-351,440-447 NUMA node11 CPU(s):160-167,256-263,352-359,448-455 Previous attempt to solve this problem https://patchwork.ozlabs.org/patch/530090/ Reported-by: Manjunatha H R Sig

Re: [PATCH v3] powerpc/topology: Check at boot for topology updates

* Michael Ellerman [2018-08-10 21:42:28]: > Srikar Dronamraju writes: > > diff --git a/arch/powerpc/include/asm/topology.h > > b/arch/powerpc/include/asm/topology.h > > index 16b077801a5f..70f2d2285ba7 100644 > > --- a/arch/powerpc/include/asm/topology.h > &g

Re: [PATCH] sched/topology: Use Identity node only if required

* Peter Zijlstra [2018-08-08 09:58:41]: > On Wed, Aug 08, 2018 at 12:39:31PM +0530, Srikar Dronamraju wrote: > > With Commit 051f3ca02e46 ("sched/topology: Introduce NUMA identity node > > sched domain") scheduler introduces an extra numa level. However that >

[PATCH 1/2] sched/topology: Set correct numa topology type

is because sched_domains_numa_level is now 2 on 2 node systems. Fix this by allowing setting systems that have upto 2 numa levels as NUMA_DIRECT. While here remove a code that assumes level can be 0. Fixes: 051f3ca02e46 "Introduce NUMA identity node sched domain" Signed-off-by: Srikar Dronamraj

[PATCH 2/2] sched/topology: Expose numa_mask set/clear functions to arch

Carstens Cc: Ingo Molnar Cc: LKML Fixes: 051f3ca02e46 "Introduce NUMA identity node sched domain" Signed-off-by: Srikar Dronamraju Signed-off-by: Srikar Dronamraju --- include/linux/sched/topology.h | 6 ++ kernel/sched/sched.h | 4 2 files changed, 6 insertions(+

[PATCH v4] powerpc/topology: Get topology for shared processors at boot

1 NUMA node9 CPU(s): 144-151,240-247,336-343,432-439 NUMA node10 CPU(s):152-159,248-255,344-351,440-447 NUMA node11 CPU(s):160-167,256-263,352-359,448-455 Previous attempt to solve this problem https://patchwork.ozlabs.org/patch/530090/ Reported-by: Manjunatha H R Signed-off-by:

[PATCH v5] powerpc/topology: Get topology for shared processors at boot

1 NUMA node9 CPU(s): 144-151,240-247,336-343,432-439 NUMA node10 CPU(s):152-159,248-255,344-351,440-447 NUMA node11 CPU(s):160-167,256-263,352-359,448-455 Previous attempt to solve this problem https://patchwork.ozlabs.org/patch/530090/ Reported-by: Manjunatha H R Signed-off-by:

[PATCH v5] powerpc/topology: Get topology for shared processors at boot

1 NUMA node9 CPU(s): 144-151,240-247,336-343,432-439 NUMA node10 CPU(s):152-159,248-255,344-351,440-447 NUMA node11 CPU(s):160-167,256-263,352-359,448-455 Previous attempt to solve this problem https://patchwork.ozlabs.org/patch/530090/ Reported-by: Manjunatha H R Signed-off-by:

Re: [PATCH v7 1/2] powerpc: Detect the presence of big-cores via "ibm,thread-groups"

;ibm,thread-groups" and a new structure to contain the parsed output. > > The patch also creates the sysfs file named "small_core_siblings" that > returns the physical ids of the threads in the core that share the L1 > cache, translation cache and instruction data flow.

Re: [PATCH v7 2/2] powerpc: Use cpu_smallcore_sibling_mask at SMT level on bigcores

ling_mask to compare with the l2_cache_mask. > This ensure that the CACHE level sched-domain is created, whose groups > correspond to the threads of the big-core. > > With this patch, the SMT sched-domain with SMT=8,4,2 on big-core > systems are as follows: Reviewed-by: Srikar Dronamraju

Re: [PATCH 1/2] sched/topology: Set correct numa topology type

* Srikar Dronamraju [2018-08-10 22:30:18]: > With commit 051f3ca02e46 ("sched/topology: Introduce NUMA identity node > sched domain") scheduler introduces an new numa level. However this > leads to numa topology on 2 node systems no more marked as NUMA_DIRECT. > Afte

Re: [v5] powerpc/topology: Get topology for shared processors at boot

* Michael Ellerman [2018-08-21 20:35:23]: > On Fri, 2018-08-17 at 14:54:39 UTC, Srikar Dronamraju wrote: > > On a shared lpar, Phyp will not update the cpu associativity at boot > > time. Just after the boot system does recognize itself as a shared lpar and > > trigger a re

Re: [PATCH] sched/topology: Use Identity node only if required

* Peter Zijlstra [2018-08-29 10:43:48]: > On Fri, Aug 10, 2018 at 09:45:33AM -0700, Srikar Dronamraju wrote: > > > > > CPU302 attaching NULL sched-domain. > > CPU303 attaching NULL sched-domain. > > BUG: arch topology borken > > the DIE do

Re: [PATCH 2/2] sched/topology: Expose numa_mask set/clear functions to arch

* Peter Zijlstra [2018-08-29 10:02:19]: > On Fri, Aug 10, 2018 at 10:30:19PM +0530, Srikar Dronamraju wrote: > > With commit 051f3ca02e46 ("sched/topology: Introduce NUMA identity node > > sched domain") scheduler introduces an new numa level. However on shared > >

  1   2   3   4   5   6   >