Re: [PATCH] PCI: Add parameter @mmio_force_on to pci_update_resource()

2016-09-29 Thread Gavin Shan
On Wed, Sep 28, 2016 at 11:14:08AM +1000, Gavin Shan wrote: >On Wed, Sep 28, 2016 at 10:06:44AM +1000, Benjamin Herrenschmidt wrote: >>On Wed, 2016-09-28 at 09:37 +1000, Gavin Shan wrote: >>> >>> Yeah, it's safe to update it with memory decoding on. As the function call >>> flow I listed in the

Re: [PATCH] PCI: Add parameter @mmio_force_on to pci_update_resource()

2016-09-27 Thread Gavin Shan
On Wed, Sep 28, 2016 at 10:06:44AM +1000, Benjamin Herrenschmidt wrote: >On Wed, 2016-09-28 at 09:37 +1000, Gavin Shan wrote: >> >> Yeah, it's safe to update it with memory decoding on. As the function call >> flow I listed in the changelog (as below), nobody should access the IOV BAR >> when

Re: [PATCH] PCI: Add parameter @mmio_force_on to pci_update_resource()

2016-09-27 Thread Benjamin Herrenschmidt
On Wed, 2016-09-28 at 09:37 +1000, Gavin Shan wrote: > > Yeah, it's safe to update it with memory decoding on. As the function call > flow I listed in the changelog (as below), nobody should access the IOV BAR > when pci_update_resource() is called. However, the PF's memory BARs might > be

Re: [PATCH] PCI: Add parameter @mmio_force_on to pci_update_resource()

2016-09-27 Thread Gavin Shan
On Wed, Sep 28, 2016 at 07:45:32AM +1000, Benjamin Herrenschmidt wrote: >On Tue, 2016-09-27 at 14:20 -0500, Bjorn Helgaas wrote: >> On Mon, Sep 19, 2016 at 09:53:30AM +1000, Gavin Shan wrote: >> > In pci_update_resource(), the PCI device's memory decoding (0x2 in >> > PCI_COMMAND) is disabled when

Re: [PATCH] PCI: Add parameter @mmio_force_on to pci_update_resource()

2016-09-27 Thread Benjamin Herrenschmidt
On Tue, 2016-09-27 at 14:20 -0500, Bjorn Helgaas wrote: > On Mon, Sep 19, 2016 at 09:53:30AM +1000, Gavin Shan wrote: > > In pci_update_resource(), the PCI device's memory decoding (0x2 in > > PCI_COMMAND) is disabled when 64-bits memory BAR is updated if the > > PCI device's memory space wasn't

Re: [PATCH] PCI: Add parameter @mmio_force_on to pci_update_resource()

2016-09-27 Thread Bjorn Helgaas
Hi Gavin, On Mon, Sep 19, 2016 at 09:53:30AM +1000, Gavin Shan wrote: > In pci_update_resource(), the PCI device's memory decoding (0x2 in > PCI_COMMAND) is disabled when 64-bits memory BAR is updated if the > PCI device's memory space wasn't asked to be always on by @pdev-> > mmio_always_on. The

Re: [PATCH] PCI: Add parameter @mmio_force_on to pci_update_resource()

2016-09-26 Thread Gavin Shan
On Mon, Sep 19, 2016 at 09:53:30AM +1000, Gavin Shan wrote: >In pci_update_resource(), the PCI device's memory decoding (0x2 in >PCI_COMMAND) is disabled when 64-bits memory BAR is updated if the >PCI device's memory space wasn't asked to be always on by @pdev-> >mmio_always_on. The PF's memory

[PATCH] PCI: Add parameter @mmio_force_on to pci_update_resource()

2016-09-18 Thread Gavin Shan
In pci_update_resource(), the PCI device's memory decoding (0x2 in PCI_COMMAND) is disabled when 64-bits memory BAR is updated if the PCI device's memory space wasn't asked to be always on by @pdev-> mmio_always_on. The PF's memory decoding might be disabled when updating its IOV BARs in the