Re: [PATCH] powerpc/numa: Correct kernel message severity

2018-03-14 Thread Vipin K Parashar 


On Tuesday 13 March 2018 03:58 PM, Christophe LEROY wrote:



Le 13/03/2018 à 11:11, Vipin K Parashar a écrit :

printk in unmap_cpu_from_node() uses KERN_ERR message severity
for a WARNING message. Correct message severity to KERN_WARNING.

Signed-off-by: Vipin K Parashar 
---
  arch/powerpc/mm/numa.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index edd8d0b..79c94cc 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -163,7 +163,7 @@ static void unmap_cpu_from_node(unsigned long cpu)
  if (cpumask_test_cpu(cpu, node_to_cpumask_map[node])) {
  cpumask_clear_cpu(cpu, node_to_cpumask_map[node]);
  } else {
-    printk(KERN_ERR "WARNING: cpu %lu not found in node %d\n",
+    printk(KERN_WARNING "WARNING: cpu %lu not found in node %d\n",

>  cpu, node);

Why not take the opportunity to use pr_warn() instead, hence to put 
back the cpu and node vars on the same line.


Christophe



Yes, Thanks!!

Send v2.



  }
  }

Re: [PATCH] powerpc/numa: Correct kernel message severity

2018-03-13 Thread Christophe LEROY 



Le 13/03/2018 à 11:11, Vipin K Parashar a écrit :

printk in unmap_cpu_from_node() uses KERN_ERR message severity
for a WARNING message. Correct message severity to KERN_WARNING.

Signed-off-by: Vipin K Parashar 
---
  arch/powerpc/mm/numa.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index edd8d0b..79c94cc 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -163,7 +163,7 @@ static void unmap_cpu_from_node(unsigned long cpu)
if (cpumask_test_cpu(cpu, node_to_cpumask_map[node])) {
cpumask_clear_cpu(cpu, node_to_cpumask_map[node]);
} else {
-   printk(KERN_ERR "WARNING: cpu %lu not found in node %d\n",
+   printk(KERN_WARNING "WARNING: cpu %lu not found in node %d\n",

>   cpu, node);

Why not take the opportunity to use pr_warn() instead, hence to put back 
the cpu and node vars on the same line.


Christophe


}
  }

[PATCH] powerpc/numa: Correct kernel message severity

2018-03-13 Thread Vipin K Parashar 
printk in unmap_cpu_from_node() uses KERN_ERR message severity
for a WARNING message. Correct message severity to KERN_WARNING.

Signed-off-by: Vipin K Parashar 
---
 arch/powerpc/mm/numa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index edd8d0b..79c94cc 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -163,7 +163,7 @@ static void unmap_cpu_from_node(unsigned long cpu)
if (cpumask_test_cpu(cpu, node_to_cpumask_map[node])) {
cpumask_clear_cpu(cpu, node_to_cpumask_map[node]);
} else {
-   printk(KERN_ERR "WARNING: cpu %lu not found in node %d\n",
+   printk(KERN_WARNING "WARNING: cpu %lu not found in node %d\n",
   cpu, node);
}
 }
-- 
2.7.4