[PATCH 14/20] block: remove the NULL queue check in generic_make_request_checks

2020-07-01 Thread Christoph Hellwig
All registers disks must have a valid queue pointer, so don't bother to
log a warning for that case.

Signed-off-by: Christoph Hellwig 
---
 block/blk-core.c | 12 +---
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index 95dca74534ff73..37435d0d433564 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -973,22 +973,12 @@ static inline blk_status_t blk_check_zone_append(struct 
request_queue *q,
 static noinline_for_stack bool
 generic_make_request_checks(struct bio *bio)
 {
-   struct request_queue *q;
+   struct request_queue *q = bio->bi_disk->queue;
int nr_sectors = bio_sectors(bio);
blk_status_t status = BLK_STS_IOERR;
-   char b[BDEVNAME_SIZE];
 
might_sleep();
 
-   q = bio->bi_disk->queue;
-   if (unlikely(!q)) {
-   printk(KERN_ERR
-  "generic_make_request: Trying to access "
-   "nonexistent block-device %s (%Lu)\n",
-   bio_devname(bio, b), (long long)bio->bi_iter.bi_sector);
-   goto end_io;
-   }
-
/*
 * For a REQ_NOWAIT based request, return -EOPNOTSUPP
 * if queue is not a request based queue.
-- 
2.26.2



[PATCH 14/20] block: remove the NULL queue check in generic_make_request_checks

2020-06-29 Thread Christoph Hellwig
All registers disks must have a valid queue pointer, so don't bother to
log a warning for that case.

Signed-off-by: Christoph Hellwig 
---
 block/blk-core.c | 12 +---
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index 95dca74534ff73..37435d0d433564 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -973,22 +973,12 @@ static inline blk_status_t blk_check_zone_append(struct 
request_queue *q,
 static noinline_for_stack bool
 generic_make_request_checks(struct bio *bio)
 {
-   struct request_queue *q;
+   struct request_queue *q = bio->bi_disk->queue;
int nr_sectors = bio_sectors(bio);
blk_status_t status = BLK_STS_IOERR;
-   char b[BDEVNAME_SIZE];
 
might_sleep();
 
-   q = bio->bi_disk->queue;
-   if (unlikely(!q)) {
-   printk(KERN_ERR
-  "generic_make_request: Trying to access "
-   "nonexistent block-device %s (%Lu)\n",
-   bio_devname(bio, b), (long long)bio->bi_iter.bi_sector);
-   goto end_io;
-   }
-
/*
 * For a REQ_NOWAIT based request, return -EOPNOTSUPP
 * if queue is not a request based queue.
-- 
2.26.2