Re: [PATCH v2] adb: properly mark continued kernel messages

2016-12-01 Thread Michael Ellerman
Andreas Schwab writes: > Use pr_cont where appropriate, and switch to pr_foo throughout. > Additionally, lower messages in adb_probe_task to debug level. > > Signed-off-by: Andreas Schwab > --- > drivers/macintosh/adb.c| 24 +---

Re: [PATCH v2] adb: properly mark continued kernel messages

2016-11-30 Thread Andreas Schwab
On Nov 30 2016, David Laight wrote: > Doesn't pr_cont() have its own major problem - garbled messages if > there are concurrent writers? > So it is best avoided if at all possible. You are free to submit a followup patch the rework the messaging. My patch is a strict

RE: [PATCH v2] adb: properly mark continued kernel messages

2016-11-30 Thread David Laight
From: Andreas Schwab > Sent: 28 November 2016 20:29 > Use pr_cont where appropriate, and switch to pr_foo throughout. > Additionally, lower messages in adb_probe_task to debug level. Doesn't pr_cont() have its own major problem - garbled messages if there are concurrent writers? So it is best

[PATCH v2] adb: properly mark continued kernel messages

2016-11-28 Thread Andreas Schwab
Use pr_cont where appropriate, and switch to pr_foo throughout. Additionally, lower messages in adb_probe_task to debug level. Signed-off-by: Andreas Schwab --- drivers/macintosh/adb.c| 24 +--- drivers/macintosh/adbhid.c | 56